From nobody Sat Sep 26 23:51:02 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C70532C11C4 for ; Fri, 28 Aug 2026 05:05:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787893557; cv=none; b=SQE1H0K2RF8/OFI6BClJMmHHQ5gHrwQfvTxSX6U4zgrrf5Nottz9nrb2D1kibPjnVRe4Zvj2vSesb5G7ZHxNcZvHXa+idqQqtIRQxbtVokFnJsV0ZcBH7ZfIf84YAeUyvGLS/p1WPuuEF06WrTpRpVcAF41SqSY2C+0494J4Hz0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787893557; c=relaxed/simple; bh=Q7QQT7/BVhDq1O498rAEP2puFeqnHzBBniDPqc+j0VM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Gwo2deqGN87jjCEv/h1YcDC1HdIbPcbTa/+kGrL9JdqaE3Mmk4PQ5rEOQwsTcekUnuzIfCzqJ/0yq+P8BctUqOV/D2Npey2A9PTXNyULN7og88pYJu3E3zCNxXJTICA7clhEJy2mE//jFFEi6xUQQ2bL4JUqwEw7Y6vrPNBFsbw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KdOGayKg; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KdOGayKg" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-39266382df6so761291a91.3 for ; Thu, 27 Aug 2026 22:05:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787893555; x=1788498355; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aHaGtDWIabgwE9bMPCVResetCLU3h+f9hWvuf0/laf8=; b=KdOGayKg73h5yOVMTM+lSR4hOWBJPZ9EeCrACOzM/88sTIJybLIcIcuyMLowwJK0q7 539iKbNghWjo/eCAnF8qePEYZV2YqDRKxMkQhx5gYtru7NiA+HYZPBH0eZ44apF1nQKE b7UrFLjLRKd2WR1rta6KBibc8U16AvMlJeX8cfGFxQxffHvZQztm4pErP+VuamOtSHzp bsNGIBFZX9SJCkmitV2gkeaIOju+cOXnfX+ELOhe+Pci9Q9Gy239DAKZFz9l39fMnUBr d00VklGy6zUpyAkidyq0oaKuHK9t91gtUqqSn+vYTsfX/3duRgQOqoZBuJPTzkmcMKyk wyyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787893555; x=1788498355; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=aHaGtDWIabgwE9bMPCVResetCLU3h+f9hWvuf0/laf8=; b=FT7L4P1WYPSFDvnMuJyqZSexdxB5Fh9VURBkAUzeUH/qVqVvlBH9Lcx1/J6BfQ1s4S EAKpprhrNE7CQfYoOsBftfs6r0uww+ygQ0XgRuj3hedfMPe57QyBITgbGp/BO1Unhvyi g6KkHp6wSBQuQIOxrN/HWirVRw5bm0TyK8HdHM7+/p6SD/jiE+oH4ycyvdSwGr2gxjXf RG/LDLzxZuoqOfpEjqURRL9yZIBEnS+ZiIgYuYAqEorAL4oCyuFrkulnIiVjzUO6F8J9 fw1if0V7ZSx8sdtKsT8qSgjMKGycbZ4yQsWRLc9dewwy8lUanMQ1iQOXgehWYwMGoP4E 6BsQ== X-Forwarded-Encrypted: i=1; AHgh+RqlHxTj51cEPLKMGbSi/AQfbdh7TSPTJxccLqV3l0fiHFiSGSfFTfQgqngeCtmTsNLpBO7orjlyUHEziPA=@vger.kernel.org X-Gm-Message-State: AFuF++kFq8G3aayXEWuRt43sZUfSj24Xn28rHb0g5GweH969KpmAX756 dfYH8uLn+ewFCQA8w/AmvWrcZ2r73XIXMs/ky+CZ9hlu7IFoMdx/voIb X-Gm-Gg: AR+sD12SC3uCgMOj2tw+GwD1FyG9/m5Uj8x+bHagCKNoMumK/k83omPVobM/M6KDLPS 9gRuQFCBT7bmfyGaLtuNK2+AkaTbTRSHF1icwD7I5OxOrPXLb8enUtbfqo0D+0hzODEZnlxMUuY QMIC+EaIAfacYtPBog/Go3ufzH+n4HlzLofuzFagDiNFRcVWnFkajWcmYEx4S4f60z8KFvH7ZUA iVhkWSXnc1vHNpA4fVxIUQlZKB7gJs1rIabSiWda2gM7I29MYxRIybJQPd2AdBkKgDxOjvMQ+qx 4t5LNfHUJw+g5ZSHgfngU3UKdKojdUQrZrV71PwcXPvMaQELhFKv9EqEVuUt45vIwRDnwSqrWmK dXM9QKmx1kyg8u6AyI1DycVgGSM3vIh0Nk+M7e5uDx7WX40DRg68fSHLXUvneY7InZt6XPMEBUz v3aA0cInaH0A3XDHDeVMixkITOSt3e8gRjNIXbCKbfpS7dnX20TjZqjlX/tOKeD5zJ5LbWpTsen b/YEKSpNuoFyLOuJqykSRvQR5vJo/X6c1jECKyrn9V22r2XFycPOzK3AU6OjIUq+U6qZ5aErRoY UQO4 X-Received: by 2002:a17:90b:1a8c:b0:366:3517:1aa2 with SMTP id 98e67ed59e1d1-396d0c0ffb5mr8090761a91.0.1787893555138; Thu, 27 Aug 2026 22:05:55 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-396dda7c922sm986549a91.7.2026.08.27.22.05.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Aug 2026 22:05:54 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Matthias Brugger Cc: Liam Girdwood , AngeloGioacchino Del Regno , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v3 1/5] ASoC: mediatek: mt8183: Fix wrong clock cleanup on clk_set_parent() failure Date: Fri, 28 Aug 2026 12:05:22 +0700 Message-ID: <20260828050526.590761-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260828050526.590761-1-phucduc.bui@gmail.com> References: <20260828050526.590761-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc In mt8183_afe_enable_clock(), when clk_set_parent() fails, the current error path incorrectly cleans up the previously enabled clock instead of the clock used by clk_set_parent(). Fix the error path to clean up the correct clock when clk_set_parent() fails. Fixes: a94aec035a12 ("ASoC: mediatek: mt8183: add platform driver") Reviewed-by: Cezary Rojewski Signed-off-by: bui duc phuc --- Changes in v3: - Add a Reviewed-by tag. sound/soc/mediatek/mt8183/mt8183-afe-clk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/mediatek/mt8183/mt8183-afe-clk.c b/sound/soc/mediate= k/mt8183/mt8183-afe-clk.c index cc4f8f4d3dab..6ab0734ad136 100644 --- a/sound/soc/mediatek/mt8183/mt8183-afe-clk.c +++ b/sound/soc/mediatek/mt8183/mt8183-afe-clk.c @@ -137,7 +137,7 @@ int mt8183_afe_enable_clock(struct mtk_base_afe *afe) dev_err(afe->dev, "%s(), clk_set_parent %s-%s fail %d\n", __func__, aud_clks[CLK_MUX_AUDIO], aud_clks[CLK_CLK26M], ret); - goto CLK_MUX_AUDIO_ERR; + goto CLK_MUX_AUDIO_INTBUS_ERR; } =20 ret =3D clk_prepare_enable(afe_priv->clk[CLK_MUX_AUDIOINTBUS]); @@ -153,7 +153,7 @@ int mt8183_afe_enable_clock(struct mtk_base_afe *afe) dev_err(afe->dev, "%s(), clk_set_parent %s-%s fail %d\n", __func__, aud_clks[CLK_MUX_AUDIOINTBUS], aud_clks[CLK_TOP_SYSPLL_D2_D4], ret); - goto CLK_MUX_AUDIO_INTBUS_ERR; + goto CLK_AFE_ERR; } =20 ret =3D clk_prepare_enable(afe_priv->clk[CLK_AFE]); --=20 2.43.0 From nobody Sat Sep 26 23:51:02 2026 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CB2F30F95C for ; Fri, 28 Aug 2026 05:05:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787893561; cv=none; b=p6zpyPBtpm758DCgFsWRY29kRyUd8GX2ZkNuMHKfdu07cgEk4Jlx66wfxQVq9Fb+DyRsxfB80AVPR6mmKhp5a5MN/pk535iG/QDjBtjoptl7LgMgcDTlJ/+THrB+koJoKChwE7p1nMIHnDrJXZZJUlpZprnki2nNyvAK5f8fFwM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787893561; c=relaxed/simple; bh=KBeCd5r28ZoCaTvZfGV/KIZe2U7TawXL60KXOy1aHs8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cwAOtxUlt1/j8NhvDgGGAQWKqskB60CMJSkZvdDZ4BoH1LfPd6i3gHjXvZG5U6I+6AkE/lEEHTzodmB5eqqPw4Hpr2zcC0ZZug0b+OUmh3KJI/VYQE3u92rfOigCpMR+ZzDsUGgyr/VEr/l7qQhDOKiVXDtbpj8qVgcVxwGIoTI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jIcm5XJS; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jIcm5XJS" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-cc1cb472b76so427404a12.0 for ; Thu, 27 Aug 2026 22:05:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787893559; x=1788498359; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wX5Pjxydk72W6dlHzm6vBpUneCYTnp+fBCLKSyxEezc=; b=jIcm5XJS8ESbte+rPWruhM2XqQjw6rizwxDXVuOScdp96SLG3BKJk7S71FcZ1qplRk drjKuP2Tvewj1BNZIIcEv9Wf//kYWicgN8jlH6hxfDnlfLUOlPc2WViYoyMeHTSw3V/e Fx0j5TPQSjFeiX2JI9zyCPh0feXV3JoSx4QoFEX3k1ZVMcs25LH+X3jUghkaW7O2CzoX IiKinoRozBnIEQ2uouAkN9MKV2O3Ml4LV/x96ukmPZKjdv93utZDKnEOqucFxdkA1wp9 xS4VtY2MHgcz4djpa6ZVqNVzqUHw88iJZRSujbOz/u3C8ti5gVjKaXCI/WlAfx927VnI nUkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787893559; x=1788498359; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=wX5Pjxydk72W6dlHzm6vBpUneCYTnp+fBCLKSyxEezc=; b=roSXCIZKiDMRYfrSddF7BV4Z+WCuEQvTfAwbGKr5i/NTCiI2bkcvLeLPmD6pZc52cN rKYeImuNAGG+e9XDlP6CTiUzwsifagEpVzZund0pwjmsqFJru3O4ljbIPCW1rLelIFr9 KWgGrpr6l+NQq5ihQlIV+x8yR8rSalz0PJmZhKMlfXuowJWXXAoxfGQJhlBj4oaaJB3w 990OSH8imYYecTjbYv0cowdpsutje21iaIG7i/weqXSewhpJ4B3omwQhDDXRcPoYxABE 2b6R1vdGbqInHwq20zonqyPu9ZS6sDQr3s4hIkIyFAsBp0AgayJf1ngdZihsz1pX1bSa 3Khw== X-Forwarded-Encrypted: i=1; AHgh+RqA+bmoJb5qE38AUzE8FsTyUYkdX5vms18lRunJq98pZso9kF/SxYl9zj3Iq5FugyJ3kFW0VfcLThAG6GY=@vger.kernel.org X-Gm-Message-State: AFuF++nMPvF0DVBntTfzldam8Z+lF+qxspK42NuEuQ99Bw8GBdhzDtMe YjnA8Xm+yZl8CZlb8B8SEcyfBJMjTv8yqjuAmv5ei1jltGReKzu9/qOwlj5qEQ== X-Gm-Gg: AR+sD13WDVkIf7dwDoQ/78Zb23FDSrkPJL6U5YgROxT9M5I7QlkMCd1LnfSBgjUPN+2 /I1HlO06jPAUD9a/gpwibLYnUw/p8OUdwE3f1uAgMI4J3Ob1CBk0icb1bsGHue7ZX4pzbCUNlN9 x0e5seXuEo3T6aeKStGi1qfu/la320oA3G6WzdFY9oeicH7b2yfQaexekDuRDsgBFxcvIPM7Esr Tvw2QUP6NGg8gx1W70fs3Zdino8TjIXnba5ugKbt3Gk77QS2lI8ke7ogtKBDasmhHGNVRVWHjek wcTeW7nkJ1ooOYpQxIWziZ5ODA3Erucb0JbANhNcNYM74lXXaSYXwJKrjV17BjXbMTND8/K912r OaTaoYFDMiPy186Jg9SQRsqXm1n9lv950dEjAKlvCgM91iAGSIEWHeeAwZPmI/bUdPPoJesQ1UZ ZWC/XbU+hqpxHTGmFwrZt5a1plKmS+iTwK3NL2yLrkrbknJCparVz2fhmQ+xPOaI7SH8/ofaIgr K6dONOM7TcfwX3x1chFZCqLlomRPn6Pu77RTCkmbnMAZ4wVtShADI5q5HfKNrIvW/EdrxurY4Uw pZ4y X-Received: by 2002:a17:90a:da87:b0:36a:5d1f:7b6 with SMTP id 98e67ed59e1d1-396d0d4c42fmr9359769a91.2.1787893559221; Thu, 27 Aug 2026 22:05:59 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-396dda7c922sm986549a91.7.2026.08.27.22.05.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Aug 2026 22:05:58 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Matthias Brugger Cc: Liam Girdwood , AngeloGioacchino Del Regno , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v3 2/5] ASoC: mediatek: mt8183: Fix clock handling in mux disable path Date: Fri, 28 Aug 2026 12:05:23 +0700 Message-ID: <20260828050526.590761-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260828050526.590761-1-phucduc.bui@gmail.com> References: <20260828050526.590761-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc In the disable path of the appl*_mux_setting() functions, clk_disable_unprepare() is called after clk_set_parent(). If clk_set_parent() fails, clk_disable_unprepare() is skipped, potentially leaving one of the clocks enabled. Move the clk_disable_unprepare() calls before clk_set_parent() so that the clocks are always disabled and unprepared in the disable path. Fixes: a94aec035a12 ("ASoC: mediatek: mt8183: add platform driver") Suggested-by: Cezary Rojewski Signed-off-by: bui duc phuc --- sound/soc/mediatek/mt8183/mt8183-afe-clk.c | 70 +++++++++++----------- 1 file changed, 36 insertions(+), 34 deletions(-) diff --git a/sound/soc/mediatek/mt8183/mt8183-afe-clk.c b/sound/soc/mediate= k/mt8183/mt8183-afe-clk.c index 6ab0734ad136..2dbe0b7f8bad 100644 --- a/sound/soc/mediatek/mt8183/mt8183-afe-clk.c +++ b/sound/soc/mediatek/mt8183/mt8183-afe-clk.c @@ -265,25 +265,26 @@ static int apll1_mux_setting(struct mtk_base_afe *afe= , bool enable) goto ERR_SELECT_CLK_TOP_MUX_AUD_ENG1; } } else { - ret =3D clk_set_parent(afe_priv->clk[CLK_TOP_MUX_AUD_ENG1], - afe_priv->clk[CLK_CLK26M]); - if (ret) { - dev_err(afe->dev, "%s clk_set_parent %s-%s fail %d\n", - __func__, aud_clks[CLK_TOP_MUX_AUD_ENG1], - aud_clks[CLK_CLK26M], ret); - goto EXIT; - } clk_disable_unprepare(afe_priv->clk[CLK_TOP_MUX_AUD_ENG1]); - - ret =3D clk_set_parent(afe_priv->clk[CLK_TOP_MUX_AUD_1], - afe_priv->clk[CLK_CLK26M]); - if (ret) { - dev_err(afe->dev, "%s clk_set_parent %s-%s fail %d\n", - __func__, aud_clks[CLK_TOP_MUX_AUD_1], - aud_clks[CLK_CLK26M], ret); - goto EXIT; - } clk_disable_unprepare(afe_priv->clk[CLK_TOP_MUX_AUD_1]); + + ret =3D clk_set_parent(afe_priv->clk[CLK_TOP_MUX_AUD_ENG1], + afe_priv->clk[CLK_CLK26M]); + if (ret) { + dev_err(afe->dev, "%s clk_set_parent %s-%s fail %d\n", + __func__, aud_clks[CLK_TOP_MUX_AUD_ENG1], + aud_clks[CLK_CLK26M], ret); + goto EXIT; + } + + ret =3D clk_set_parent(afe_priv->clk[CLK_TOP_MUX_AUD_1], + afe_priv->clk[CLK_CLK26M]); + if (ret) { + dev_err(afe->dev, "%s clk_set_parent %s-%s fail %d\n", + __func__, aud_clks[CLK_TOP_MUX_AUD_1], + aud_clks[CLK_CLK26M], ret); + goto EXIT; + } } =20 return 0; @@ -339,25 +340,26 @@ static int apll2_mux_setting(struct mtk_base_afe *afe= , bool enable) goto ERR_SELECT_CLK_TOP_MUX_AUD_ENG2; } } else { - ret =3D clk_set_parent(afe_priv->clk[CLK_TOP_MUX_AUD_ENG2], - afe_priv->clk[CLK_CLK26M]); - if (ret) { - dev_err(afe->dev, "%s clk_set_parent %s-%s fail %d\n", - __func__, aud_clks[CLK_TOP_MUX_AUD_ENG2], - aud_clks[CLK_CLK26M], ret); - goto EXIT; - } clk_disable_unprepare(afe_priv->clk[CLK_TOP_MUX_AUD_ENG2]); - - ret =3D clk_set_parent(afe_priv->clk[CLK_TOP_MUX_AUD_2], - afe_priv->clk[CLK_CLK26M]); - if (ret) { - dev_err(afe->dev, "%s clk_set_parent %s-%s fail %d\n", - __func__, aud_clks[CLK_TOP_MUX_AUD_2], - aud_clks[CLK_CLK26M], ret); - goto EXIT; - } clk_disable_unprepare(afe_priv->clk[CLK_TOP_MUX_AUD_2]); + + ret =3D clk_set_parent(afe_priv->clk[CLK_TOP_MUX_AUD_ENG2], + afe_priv->clk[CLK_CLK26M]); + if (ret) { + dev_err(afe->dev, "%s clk_set_parent %s-%s fail %d\n", + __func__, aud_clks[CLK_TOP_MUX_AUD_ENG2], + aud_clks[CLK_CLK26M], ret); + goto EXIT; + } + + ret =3D clk_set_parent(afe_priv->clk[CLK_TOP_MUX_AUD_2], + afe_priv->clk[CLK_CLK26M]); + if (ret) { + dev_err(afe->dev, "%s clk_set_parent %s-%s fail %d\n", + __func__, aud_clks[CLK_TOP_MUX_AUD_2], + aud_clks[CLK_CLK26M], ret); + goto EXIT; + } } =20 return 0; --=20 2.43.0 From nobody Sat Sep 26 23:51:02 2026 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB8782C11C4 for ; Fri, 28 Aug 2026 05:06:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787893565; cv=none; b=dq8Xv5aGUgZipDMkWgDA9zFu3B6RaXJNGNqmIQEARkVWOT7KrXEvDKL9KETELWO5/eVP9SS31q4+11uwL8vGZXnuzoLy8jjNNS+SrsraP6LGxXsJxc2621Z5J+nCXCSgJ384sYVvu3vk3/9d5sAC16SMYx7gDAAbN+PxPgFptfI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787893565; c=relaxed/simple; bh=Y/jz3BDQzxg+BSmZzlkipWm7+jQ4A9dc01+HMYYhNmE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GunzxfJ2s7zDgu//BZ0uCih5RiABwYPNDV1FkUlqdC4Qn9gqLgj1eXTggK6umu+SV1iKN7e09RuIFKvjWrOoypaXYWPBTtGdG5IbbbDN6eNVJRhCKtHVWf0xAZauQr9kUxDt4SrqcqeT61OAgsYCXdFERdBRokV/8j0ursnrKKY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hsT1gK9E; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hsT1gK9E" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-38e58034d05so685156a91.2 for ; Thu, 27 Aug 2026 22:06:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787893563; x=1788498363; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=K2ayKEtWylWEqAbqXks4/0qXdOEmw8tXU6KwY1JgJjU=; b=hsT1gK9EbQiaIMzCi5+SgtROr1ZgQB9uuh9sEggK+9hAlbpPyk2U5Cs6znvnQM6FDC L4GIqznaEWVNSR1mk5+htvdR12ehJhivD2GEOaV4R4IqxLiQMI8oKSp7hZt1ERDzMAao uOiVwG2fO2YiJX82gze8PEXLgduSI/a1lbU8sffoTIn9SN+obdtp7f0MHDFbdExXaBSp LQ/MiuTDru1Z+21d0KQcI5LR9ViKGRLHIffN6j4byk8kxknEF8jKnlN0FM3ofjbILH2H jYamozF2SuFgw1fAh2Ek3AyUhcMk5cSS+rj3qhbLrAlDigqRM0sZkWYgHt/3QKHqZeBy fwYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787893563; x=1788498363; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=K2ayKEtWylWEqAbqXks4/0qXdOEmw8tXU6KwY1JgJjU=; b=ZLbkyQYFjWS2HIT5Q/RkXXksXiJEYmeV6En3Nxfd3UqMW5yM7ddOClWuV4RJ5HpVp3 KaQ1++kaJZnRBbSDfCHJUB7VWtSBSiiNL34kUiUm+MEQYs2mkNzmg6b1YpCCLBVx9yjo Y6oFvuXalRjjltJrZ6tGAUIRiHt9W+OMv6SqRnNxElKfGgcGrlzoscJDaj5P9Dgu1cII cxFJS3AmfINPUZZf9hTXDZwczu4fwIe8B3E6A98L3fOW9YeaH5UPPH/11lI70XHLX9r+ TJejeSzgEtEjk0wNo8REsGYf5R2amELcxIupmCl40HZGXTSeZj4M3qDMRO2yNpTfox1R XNjw== X-Forwarded-Encrypted: i=1; AHgh+Rr4mgsHgwNBc7UXq4VpkdEStbcmImuhBn5afZmI3MnyBdhgJ80w+cSJrSFG6Y+ITX/fRXO7ndhTR28kpjE=@vger.kernel.org X-Gm-Message-State: AFuF++kyZh9w7q8MNF5ANn2XPsPSVp5vcowm6w8d/8GM8f1Bd8cxO2Qd U2PBzyKSkKG6B4UQGYY0jRieqQiFXHJWuhVDK0jT5DXl47PZzJT+CSvm X-Gm-Gg: AR+sD10kQoYVu3PU3XLRsvqvSahn31iFGdrfGK4IAM2ZkSiM1RcwnS8cOBvrfdQGKBq AJq/Sk/Whn5Y/3DBwiH5K1AfiQBI8yHI7mQAkdEVCS0kDntCVS2VXB7P/Se0THj3zoQSXPu5G7U PBAGkPyxFeIv0mIDH3DlkVk4+Pq4v+bMK7qCIBhbEBvoVJZZhYqOnQMyxQ+7lPPKxBbgEEP00up 8EXs3OzH0j3sH3qNYU9M7f2G19N0izowwM9Qoqs14UNaVTgfJE4QeRBc5IGKWLjMYrYf6mTpF1V QKaG4QBR+ySdt9BYTuTWTf3oE1g2H6pruM0W3JB9ZHWHrwanDaN4yqiIqMAQEZOkUu0Vpmgaj3b 61HMjMBpj55o0yBD7vODFccDZJuhPZWP03qGgts/9Vmxis93mMYCRn8CBs9bpA/ZtHJqvJE875g VCMugbxYk5wBMsdvc2pR4EfVe9VkplQiE/ZduMnLDdw4LcKPCxfr9YqTAC/yRIVnxKj4j51qblw x/URf3udLo9h3eF9dqadBQndBTA2COegWkfGDkmLh6D7/b5f5UBs0GWaCJWJVVPUslv+MWT6q4v 2DnensRmE9rIktY= X-Received: by 2002:a17:90a:d2c6:b0:392:c80b:8eff with SMTP id 98e67ed59e1d1-396d0f6cb36mr8700122a91.11.1787893563290; Thu, 27 Aug 2026 22:06:03 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-396dda7c922sm986549a91.7.2026.08.27.22.06.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Aug 2026 22:06:03 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Matthias Brugger Cc: Liam Girdwood , AngeloGioacchino Del Regno , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v3 3/5] ASoC: mediatek: mt8183: Fix APLL enable error handling Date: Fri, 28 Aug 2026 12:05:24 +0700 Message-ID: <20260828050526.590761-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260828050526.590761-1-phucduc.bui@gmail.com> References: <20260828050526.590761-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Currently, the mt8183_apll*_enable() functions call mux_setting(afe, true) but do not check its return value to handle failures. In addition, the cleanup paths of mt8183_apll*_enable() do not call mux_setting(afe, false) when the enable operation fails, while the mt8183_apll*_disable() functions do. Add error handling for apll*_mux_setting() and call mux_setting(afe, false) in the cleanup paths when mt8183_apll*_enable() fails. Fixes: a94aec035a12 ("ASoC: mediatek: mt8183: add platform driver") Signed-off-by: bui duc phuc Reviewed-by: Cezary Rojewski --- Changes in v3: - Return directly from apllx_mux_setting() instead of using a goto label,=20 as suggested by Cezary. sound/soc/mediatek/mt8183/mt8183-afe-clk.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/sound/soc/mediatek/mt8183/mt8183-afe-clk.c b/sound/soc/mediate= k/mt8183/mt8183-afe-clk.c index 2dbe0b7f8bad..43d5898357dd 100644 --- a/sound/soc/mediatek/mt8183/mt8183-afe-clk.c +++ b/sound/soc/mediatek/mt8183/mt8183-afe-clk.c @@ -384,7 +384,9 @@ int mt8183_apll1_enable(struct mtk_base_afe *afe) int ret; =20 /* setting for APLL */ - apll1_mux_setting(afe, true); + ret =3D apll1_mux_setting(afe, true); + if (ret) + return ret; =20 ret =3D clk_prepare_enable(afe_priv->clk[CLK_APLL22M]); if (ret) { @@ -413,6 +415,8 @@ int mt8183_apll1_enable(struct mtk_base_afe *afe) ERR_CLK_APLL1_TUNER: clk_disable_unprepare(afe_priv->clk[CLK_APLL22M]); ERR_CLK_APLL22M: + apll1_mux_setting(afe, false); + return ret; } =20 @@ -438,7 +442,9 @@ int mt8183_apll2_enable(struct mtk_base_afe *afe) int ret; =20 /* setting for APLL */ - apll2_mux_setting(afe, true); + ret =3D apll2_mux_setting(afe, true); + if (ret) + return ret; =20 ret =3D clk_prepare_enable(afe_priv->clk[CLK_APLL24M]); if (ret) { @@ -467,6 +473,8 @@ int mt8183_apll2_enable(struct mtk_base_afe *afe) ERR_CLK_APLL2_TUNER: clk_disable_unprepare(afe_priv->clk[CLK_APLL24M]); ERR_CLK_APLL24M: + apll2_mux_setting(afe, false); + return ret; } =20 --=20 2.43.0 From nobody Sat Sep 26 23:51:02 2026 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 026CF3C1D41 for ; Fri, 28 Aug 2026 05:06:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787893569; cv=none; b=I4VS0uwnuKyAa87md7sJePd6oZyDs0HZNlY7bQp60wSVkNwmI919xPl7fQkx3d71X4gc1MD3ZWIB6gV9snduydejuFi+TxEFI8WhN0qQiIz/F75woidm2idkeBDapD+ug4Wm2lflYkRjsnu5zy711syHt9HHSqE83GYDhnqfF2k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787893569; c=relaxed/simple; bh=cLd+n7EV3Kp2AMYVFp+K6eTGdRe62zWUaZ55f+Rfna4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IfRyWkL2fzQz/m8Jitg5hC7ParlBWJ8LgDtDmorh5Cy6JcTcDDcwSfswJkYQQjgJxg3rP4GRS3pm8A9ccAqOZKZEGPlgWQU9iRfpvcQnM2F6AoAfDaNEKjGG63D38TX+fenNnu8TYZOtj8eLfZiV5majFADlOTNfHVBLrnzzhiE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ctMcMJsY; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ctMcMJsY" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-3964e76d0f4so509401a91.3 for ; Thu, 27 Aug 2026 22:06:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787893567; x=1788498367; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+ENiToKs4o7nUJ1ZfI4T9iIUcH0bdIn9rzCQXrLjT1k=; b=ctMcMJsYBYkJ1KhZnzc7bQjPaDpJ0Akde/UrMJl/QE7O8osayY9TTQlnNt4iHOSgwT iGJa5vLdBVZu9TgHc3IL6DSy9Sl+nGEyQf3QS4IMswkYF6xEQd2FPtw9apL9/CrsdGbf fXRC2fE3anb4oa7iTAhNO3Xb7NQbz/n3mLkMqNRJUdrqwrAfUYI89j6j7t0XR6VbdEqm 3Yu5k7pOB8tkjTMddVvNYChX+G+rXswrE9BtwZyHtluFsnccuJ/B+UvP6OZt/5I5HcDY 6BVSpE3Zjuw5UMSU5UsINGz+8Jzj/Fm9DkCOtzKiFP7zQbE2ZKVtbY6tQ5LIwlZUEfCf pz2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787893567; x=1788498367; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=+ENiToKs4o7nUJ1ZfI4T9iIUcH0bdIn9rzCQXrLjT1k=; b=cej2T1zT818fJKqa28L+UD/OEedbGjCCpLSzWgsgsVg319eCnWxrGGNAgx0ZT8aG9u MIe/kMY9FvzI3PTamEFoatJ11fNytrrhpPULdf4XWD7cYEYfWDi0Zg0FL+uIOUVKUF4r +iN9d9yoOliegf6u3w7z7Ax1OHl/hiM9LAixlH1Jb0NkMGJfYplJwwMMt6MhxhCE4zhf CV8HC9tpVyTwOkpDKg3Ip3MhTjOWnSrIN5QrUl8JzLOCTxZM/XFeOuILpVesw2r09i56 Wk5lwZM10LpfVnnVhZrY5/5c7rs5dRcKZ178ZgS9k48UucqU2GWtVZ/8U35xk01aFDr9 /1+Q== X-Forwarded-Encrypted: i=1; AHgh+RoqhO79vKR1OE5FRaHwX55czZrKkwr8Sqzs2fLb7E5FGNmV5hndHqhYG0yY+Q67xp8qzMU44T5kc67rLps=@vger.kernel.org X-Gm-Message-State: AFuF++lIUKTawxp5g+6tW2et7hE2oy4+GJ5X7PEEpqAEm9wzJ+ZHyXUh DWZmHPD64V5QTDSZBvQa/DolzFfQH+8Kdm9GQXI/kg2fB4++2rpCUvJc X-Gm-Gg: AR+sD122UoAFem/34JHiaAi5yKUQ5d6u18UA8QuF44t+9QCi3DoOG3qQ9pjlekoZAHu 8l3rLjZWegdJQjjOLPXoWe0Pd9lIBMgjYm0S/m9dsC07typMW05TvHjDr40s8pVTDoS7RchI8JV uA6cDeasfQmu7QlUp9Kjj6uZ71QaFwZzV3QroVGgJ3d5z85LJ0hWAG+td5Mgjyp3M8vlt9lICP1 U54+eokguIjlJaO+T5TdkehUozedxf/SdxczqpJF4OvhlyNkKA6ZxuVE3ts+JzCQNlaazxOoGQj Bbd+Zb5lqeI37QQCYTdlWPDtG+IMdxpPfQgk7VkRxYgO16j4x6aI6qYRLXp7EP/r+gNdCVUe0sR SEZ3lyrgGj3L6jVXfsIT7nmUI2n4gtGG7Eo//yq6KcMXczj390bYCIfDLOA6DE0oDZtGY1DyiOV clVSRFYdShx67ylE/0TRxN42ZvEV+RP+ghRe6tsyXG+6lS/FKitLXt/AWlsH7BhYECNdqPqTi8I QZCkDGUKB9fPbvtblBSNLvv3HsPfC1AI1Vnt5jhF/4cwkNoQtxLrBq4PbkcECdUPimTodYIxJ8u FJFc4g== X-Received: by 2002:a17:90b:1d05:b0:396:65dd:4093 with SMTP id 98e67ed59e1d1-396d0ff519cmr8743391a91.14.1787893567319; Thu, 27 Aug 2026 22:06:07 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-396dda7c922sm986549a91.7.2026.08.27.22.06.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Aug 2026 22:06:07 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Matthias Brugger Cc: Liam Girdwood , AngeloGioacchino Del Regno , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v3 4/5] ASoC: mediatek: mt8183: Use dev_err_probe() for error handling Date: Fri, 28 Aug 2026 12:05:25 +0700 Message-ID: <20260828050526.590761-5-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260828050526.590761-1-phucduc.bui@gmail.com> References: <20260828050526.590761-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Replace dev_err() with dev_err_probe() to prevent log spam when probe returns -EPROBE_DEFER. Reviewed-by: Cezary Rojewski Signed-off-by: bui duc phuc --- Changes in v3: - Add a Reviewed-by tag. sound/soc/mediatek/mt8183/mt8183-afe-clk.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/sound/soc/mediatek/mt8183/mt8183-afe-clk.c b/sound/soc/mediate= k/mt8183/mt8183-afe-clk.c index 43d5898357dd..c67424bed329 100644 --- a/sound/soc/mediatek/mt8183/mt8183-afe-clk.c +++ b/sound/soc/mediatek/mt8183/mt8183-afe-clk.c @@ -101,12 +101,9 @@ int mt8183_init_clock(struct mtk_base_afe *afe) =20 for (i =3D 0; i < CLK_NUM; i++) { afe_priv->clk[i] =3D devm_clk_get(afe->dev, aud_clks[i]); - if (IS_ERR(afe_priv->clk[i])) { - dev_err(afe->dev, "%s(), devm_clk_get %s fail, ret %ld\n", - __func__, aud_clks[i], - PTR_ERR(afe_priv->clk[i])); - return PTR_ERR(afe_priv->clk[i]); - } + if (IS_ERR(afe_priv->clk[i])) + return dev_err_probe(afe->dev, PTR_ERR(afe_priv->clk[i]), + "failed to get clock %s\n", aud_clks[i]); } =20 return 0; --=20 2.43.0 From nobody Sat Sep 26 23:51:02 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3372038DC65 for ; Fri, 28 Aug 2026 05:06:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787893573; cv=none; b=Y8J1A4DOeSMVwXXyJYfNDI+RDl4q1p6kTaSiOodB/2bM0alQseRV1P1rnkGbG7hm8SFriVMmV3m7QOvbEzW2yVW+2mJyB3HInmZdJ5WidOceAWV4HDb0b7tN6JibRvCQaIoVQC/5o9bdscCjtVkW2HOQaf2Fw/QlyilQiKrAkhE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787893573; c=relaxed/simple; bh=3GhUN1YWxQu4bJXtiFoeLFL4w/RSX1buQvfT36CMNsY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZyOSOgdDHZme2T7kNRuDOWTOYATLympIChEqnXWToHhPghG5y1Hqgji8fjXNMThAjkZ0npyozUTtDpiWY8/W+pvhejbiOb0MZ8joy6ukM2p68Y0/xzJKyJ6NWhER3viNNuH9eL2Y3NgdL+P5uGla8XwVYyXBfPJtbRm28Mxf/QI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=noa2x3j/; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="noa2x3j/" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2d6e954afbdso4485935ad.2 for ; Thu, 27 Aug 2026 22:06:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787893571; x=1788498371; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=a4ksl9SsTnU1qraDN3sQ8M70vtHGdDPB0HKfqeC0tuc=; b=noa2x3j/O1wRwpqFuCIeimXuxdVUSQQJLIWDxpm7Jjw5WPlsT0PQKWOlaHwQwhivy9 4wZE0GvmNGnjd1AE/UuIA/iGtH7R9MC0mSqbTxPYBHinB6RsTLSfA13XgudLOYllZOw2 yMTKBTQ8mJ80jBotXdRQPOm6gE170hPAIxdX/NZX+usbbqQQVEa/RXTl+0F7TE3EIaOY 7WhO73GWKWICNt/mWEHz/mG1F9za1ndXeiGlyiW6GU3m3OgvOwHJGxzZgMeqifYjKbUq 3UAvKWHYebzhrJkty0KjODB/MYmT35tpHbjyflc0fgDxjyo/UNYJVES9Ax2LC3N2ym9k wS4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787893571; x=1788498371; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=a4ksl9SsTnU1qraDN3sQ8M70vtHGdDPB0HKfqeC0tuc=; b=Y0ou8bULV0G/S3wo8sUs9jGDvYxp2U+3r49RSH2cUdzCKkO2uXEuUzIwy+q/xG7zpX GfAkQAeOg4t42NpiE+R0Oqfy+TxY921EiVUSDW8pFfmZOw4aOwIY2vgOaunp5Cp/aWQN uOm9i69/xjs2a0F4aHLcRNFd+JcuHpQDqELYNJbjCf8E8DScOnSCiS/KznPaaOYS10Ag nuuiOOtySqd8W+AQ9jgscAlRAZ76/gKruqp8KwXzHhKW7yqWqx5M942Mw42iMf3vIaJA 9JrXFnIjjfGrf4LIETdttpOMVxV8QFcTboOMfKQS72fyLWZ0X9ti+nWqcql1GqIamg1H H29A== X-Forwarded-Encrypted: i=1; AHgh+Rqa92sJ0kI5cZYjJhxJarljVJJ44OejmP/gCbetkycbfzbJ4eXMCm3mrOweQU5OmJklp6Lr+QI8ZFpe6qo=@vger.kernel.org X-Gm-Message-State: AFuF++lIVBvPBklI6qvIcJIF1ktuBiSqSc2MNRBYi9SFlihxTyNS3mRm COx2CBJflG/I5fezkvD04EPj2DAF3gYFUdpOj7v+/lgUQwkktQ6b41tW X-Gm-Gg: AR+sD12Amt1sP8ONS8sk8hGtNaXx4w34JvWQWsB4mwGSik0YnbRjO0gcTAlWFQtr1Hx V6izOWIaiPeIAF7BqXqMcAcZYKsrLfters95xkTRGKbtjimO+36YaAqD5GUelqNdngRs5I1i00c dMWrG8kWumUCzbruLdo+QwPQ5bI9VwT8Mir4MR+pmvcCw+B+sQlochYhDaytM+k0HaD28WS0CxU wbFrA9dlXhx7/CyyNlP8xAPIfpb0kQsnJZCT4vTiNxqppBp2Xu4a0064vj5BTTw3vnM+yxof59w cCtvksUaYr+HStmscJZbGf92Vj4ENA0Ax3u0TEIFGmaEo4Cj9iRBzVwrbrkoH9e8NolQTloyIw2 6pTmvkWc7TZxHf3789MSPOwQgNzBhGIcw2+4EkSMZdxuJB+sXUeO+DBb5BcgF1Q2vq76N2y+CSf jWMkOM+puKEsMO1CkhKeycpI2r8WpjJNqJsC9XAI+BM0Tu2qFP4JEailNzJ4wx4zDBkVd8VzxKn dqc9Z8Cr6nhYt5ZEfSeTFk9d2i3Hl6BDLpduuc7Go/NcpsKWjFGpNA8GrEshBav8AxOwKENV3hR MAPS X-Received: by 2002:a17:90b:2cc6:b0:381:1f51:1ff0 with SMTP id 98e67ed59e1d1-396d0d92cffmr9327276a91.2.1787893571476; Thu, 27 Aug 2026 22:06:11 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-396dda7c922sm986549a91.7.2026.08.27.22.06.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Aug 2026 22:06:11 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Matthias Brugger Cc: Liam Girdwood , AngeloGioacchino Del Regno , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v3 5/5] ASoC: mediatek: mt8183: Drop redundant probe error messages Date: Fri, 28 Aug 2026 12:05:26 +0700 Message-ID: <20260828050526.590761-6-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260828050526.590761-1-phucduc.bui@gmail.com> References: <20260828050526.590761-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc The errors handled here are already reported by the called functions, either directly or deeper in the call chain. Therefore, the additional dev_err() calls are redundant and can be removed. Reviewed-by: Cezary Rojewski Signed-off-by: bui duc phuc --- Changes in v3: - Add a Reviewed-by tag. sound/soc/mediatek/mt8183/mt8183-afe-pcm.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c b/sound/soc/mediate= k/mt8183/mt8183-afe-pcm.c index 2634699534db..46b7a2bb6aaa 100644 --- a/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c +++ b/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c @@ -809,10 +809,8 @@ static int mt8183_afe_pcm_dev_probe(struct platform_de= vice *pdev) =20 /* initial audio related clock */ ret =3D mt8183_init_clock(afe); - if (ret) { - dev_err(dev, "init clock error\n"); + if (ret) return ret; - } =20 pm_runtime_enable(dev); =20 @@ -903,10 +901,8 @@ static int mt8183_afe_pcm_dev_probe(struct platform_de= vice *pdev) =20 ret =3D devm_request_irq(dev, irq_id, mt8183_afe_irq_handler, IRQF_TRIGGER_NONE, "asys-isr", (void *)afe); - if (ret) { - dev_err(dev, "could not request_irq for asys-isr\n"); + if (ret) goto err_pm_disable; - } =20 /* init sub_dais */ INIT_LIST_HEAD(&afe->sub_dais); --=20 2.43.0