From nobody Sun Sep 27 00:36:29 2026 Received: from mail-pj2-f3.google.com (mail-pj2-f3.google.com [74.125.227.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3C45379EFE for ; Thu, 27 Aug 2026 21:47:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787867266; cv=none; b=ASzSk6rSxLUjkMBt9QMFbvqeXfj4B8woC2aclKR+53SKPSVWkCSIsaEcDdWFFz9bjh+V1wkhiD9t/HPidSKvWNVOak92Qs0qAC49Quyy7W570zQIGHVP+2xGPSArGL6XJoM1ce1glJTcADukUQixdQhyyGCQDu7itYt357T63VI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787867266; c=relaxed/simple; bh=lCKmYmW8yf2l0SbBLQAKvKdKNtanvhtCwPx2DZVPfFA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=OBbneR6TOt55xSwUeLcGDz9Xg057iVIKtfASuBPQABacRULwynNJqyhmZzFgq6Cf47CN5IY0J/ebsUMrLn4VCvVNZVRAgZ0mnYu6/cpR+l6EhMcKO0ADJPY5c8Zx7XzEMiy0GtZgsnnuhmThd0hdxhKMgBooRsCgH6SbnuyijuA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=o5CJsApy; arc=none smtp.client-ip=74.125.227.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="o5CJsApy" Received: by mail-pj2-f3.google.com with SMTP id d9443c01a7336-2d70b1a8877so1680875ad.0 for ; Thu, 27 Aug 2026 14:47:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787867264; x=1788472064; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=IdbGRL67qpRJE5R55Xlt5nL99zqk3FRNJhY4AvBB8oU=; b=o5CJsApyjaNMYNYd8VTf7zt+MkP2JHWKRLhVYNV5ra9+J9x2DExZ0VmUEqY0Jjhm3P FVdP+dPADMy6l3URvVfduu/11OsWHqoBF19rvKwpL6+aOweVLlocU7j4uT62ctdtrE+x ZP2cZQE0XIK1EhG4vKz0WuewtwOSVpl0VeXoqrITETEFFT5X3N9n+8wqifH+M6oUebRP g0sHpfd7caBKwl9h8IWSkc5fooDt4w6Fg3xs8OhckPDY7c64UtH5ayBXauhRv5BZQx9U MVKmMlWxB0idcLLWQIo3j9NSoESVo+1fX9T1l68naWUF4IwUFZ7+8qRsSay8684Hqaya GaXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787867264; x=1788472064; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=IdbGRL67qpRJE5R55Xlt5nL99zqk3FRNJhY4AvBB8oU=; b=KRUOyrmnOzG3V0Ru+wyYvliVr/fEQpH3fdF/EGIAeQHnPL7aKH+ULWSG+O5fbIjgXL spyjU9I0AmhjAsd2vH1AKIy4HmJNBJg/XLJLZTDm0c+QAmC4iMeuKxWpg+xKzbqIphr5 Sp0Q2NUk1Pv53rGemIKEp+Xm6ZpW4mcjWXdSQ8T7M39yG2cL3QXW1yXHZfF4zE0idQ2+ vhr1SmkluwWc3OWHB3TilyqMv/8PnWsUAvvAdQqxkrYbckWXFmF9dTynepac+I7RbJeP 7KuqCYkIWj6+ZyLDeX4oDQDlaHfV1QV6SdysbnJcyg3mCzNqOBTySjPb7w5hbqlrgHYU uNGw== X-Forwarded-Encrypted: i=1; AHgh+RoBNjCpYA0S2byBrE0kh+w8y2afUVMtlcWc0Pd/cD8V4h7JCN5ubK5MlIjAZtVN5zaqK/jdSm1LyzO4hjA=@vger.kernel.org X-Gm-Message-State: AFuF++nRVN4YBE/GeGsIcjk7E7cs5qtnfq59dVofpTTAanG1CL769IHg wQT0q+8kPzTk75t37SSDPw36kZUNCxGsjAPGzi0kjQ7wiCHPD/Wm4uyL X-Gm-Gg: AR+sD13RJrgRWxj2zlG6NmDyTTIhV9gEpEkjQEICpDVci+EVB/BoRYR9j5Rtql5lLzW vwKbZVq+e8Ft/KzaM2xjDAIWUVnB1gMZiZSzfIQ8RA8ayAOpvFFxaQbKcVC2egAh58RZT0B84ex 4vKMdp/GKsFEOCGNr1tZt1fL1BC+13SYqZ8wUIQvyT0PTfpufMhjbThXtLWhjhjE1B+Qcn2X/Ix /9MMXB1vdEanMUkICslu1dV1e+RhFNKV4rtXoxz3DTyB6Gt2iu5/yNx4dd39rtXLRAhtESY7wrf /JpVOUdS2rPAjvtJa072hjWzkpuiDGOBy3vuEUE6egc+tPMsGbTYtUcDEdj63XlXqYh44q8KipS FPFLrnKGgCmagki9y5xEU4wmDLvqK3z7FbccD8S42Rl0nBKjohfeKy6GarSxL7N1ZF5BLQSP7sY 3kCdFnNmD2Vyf05vPbXCYBtt2919as/uT74SEkCNyxxu9f8dnnm8zS+11yf82UumXnrSkBHMeu X-Received: by 2002:a17:903:2a90:b0:2d7:1bfd:b240 with SMTP id d9443c01a7336-2d74dc4c2a1mr37262975ad.4.1787867264061; Thu, 27 Aug 2026 14:47:44 -0700 (PDT) Received: from Mahmudul.. ([103.139.196.183]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3283d8bc3d2sm25212613eec.21.2026.08.27.14.47.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Aug 2026 14:47:43 -0700 (PDT) From: "Md. Mahmudul Hasan Mabud" To: jic23@kernel.org, nuno.sa@analog.com, Michael.Hennerich@analog.com, gregkh@linuxfoundation.org Cc: andy@kernel.org, dlechner@baylibre.com, linux@analog.com, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, "Md. Mahmudul Hasan Mabud" , Andy Shevchenko Subject: [PATCH v6] staging: iio: adc: ad7816: Use modern IIO attribute macros Date: Fri, 28 Aug 2026 03:47:21 +0600 Message-Id: <20260827214721.19395-1-mdmahmudulhasan1511@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the legacy IIO_DEVICE_ATTR() macros with the modern IIO_DEVICE_ATTR_RW() and IIO_DEVICE_ATTR_RO() macros. This includes renaming driver-specific callback functions to standard _show() and _store() formats. Signed-off-by: Md. Mahmudul Hasan Mabud Reviewed-by: Andy Shevchenko --- v6: -Dropped extra blank lines based on Andy Shevchenko's feedback. v5: - Converted to a standalone single patch (previously part of the v3/v4 se= ries). - Updated commit message and fixed function header line lengths and wrapp= ing based on Andy Shevchenko's feedback on v3. Link: https://lore.kernel.org/linux-iio/act9ovNVsJvWO6Cx@ashevche-desk.= local/ v4: - Sent by mistake without updates. v3: - Initial version (as patch 4/4 of the series). drivers/staging/iio/adc/ad7816.c | 69 +++++++++++--------------------- 1 file changed, 24 insertions(+), 45 deletions(-) diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7= 816.c index 30644d2d7..e8c2c1bfe 100644 --- a/drivers/staging/iio/adc/ad7816.c +++ b/drivers/staging/iio/adc/ad7816.c @@ -116,9 +116,8 @@ static int ad7816_spi_write(struct ad7816_chip_info *ch= ip, u8 data) return ret; } =20 -static ssize_t ad7816_show_mode(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t mode_show(struct device *dev, struct device_attribute *attr, + char *buf) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -128,10 +127,8 @@ static ssize_t ad7816_show_mode(struct device *dev, return sysfs_emit(buf, "full\n"); } =20 -static ssize_t ad7816_store_mode(struct device *dev, - struct device_attribute *attr, - const char *buf, - size_t len) +static ssize_t mode_store(struct device *dev, struct device_attribute *att= r, + const char *buf, size_t len) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -146,25 +143,18 @@ static ssize_t ad7816_store_mode(struct device *dev, =20 return len; } +static IIO_DEVICE_ATTR_RW(mode, 0); =20 -static IIO_DEVICE_ATTR(mode, 0644, - ad7816_show_mode, - ad7816_store_mode, - 0); - -static ssize_t ad7816_show_available_modes(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t available_modes_show(struct device *dev, + struct device_attribute *attr, + char *buf) { return sysfs_emit(buf, "full\npower-save\n"); } +static IIO_DEVICE_ATTR_RO(available_modes, 0); =20 -static IIO_DEVICE_ATTR(available_modes, 0444, ad7816_show_available_modes, - NULL, 0); - -static ssize_t ad7816_show_channel(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t channel_show(struct device *dev, struct device_attribute *a= ttr, + char *buf) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -172,10 +162,8 @@ static ssize_t ad7816_show_channel(struct device *dev, return sysfs_emit(buf, "%d\n", chip->channel_id); } =20 -static ssize_t ad7816_store_channel(struct device *dev, - struct device_attribute *attr, - const char *buf, - size_t len) +static ssize_t channel_store(struct device *dev, struct device_attribute *= attr, + const char *buf, size_t len) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -204,15 +192,10 @@ static ssize_t ad7816_store_channel(struct device *de= v, =20 return len; } +static IIO_DEVICE_ATTR_RW(channel, 0); =20 -static IIO_DEVICE_ATTR(channel, 0644, - ad7816_show_channel, - ad7816_store_channel, - 0); - -static ssize_t ad7816_show_value(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t value_show(struct device *dev, struct device_attribute *att= r, + char *buf) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -235,8 +218,7 @@ static ssize_t ad7816_show_value(struct device *dev, } return sysfs_emit(buf, "%u\n", data); } - -static IIO_DEVICE_ATTR(value, 0444, ad7816_show_value, NULL, 0); +static IIO_DEVICE_ATTR_RO(value, 0); =20 static struct attribute *ad7816_attributes[] =3D { &iio_dev_attr_available_modes.dev_attr.attr, @@ -266,9 +248,8 @@ static irqreturn_t ad7816_event_handler(int irq, void *= private) return IRQ_HANDLED; } =20 -static ssize_t ad7816_show_oti(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t oti_show(struct device *dev, struct device_attribute *attr, + char *buf) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -286,10 +267,10 @@ static ssize_t ad7816_show_oti(struct device *dev, return sysfs_emit(buf, "%u\n", chip->oti_data[chip->channel_id]); } =20 -static inline ssize_t ad7816_set_oti(struct device *dev, - struct device_attribute *attr, - const char *buf, - size_t len) +static inline ssize_t oti_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t len) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -326,9 +307,7 @@ static inline ssize_t ad7816_set_oti(struct device *dev, =20 return len; } - -static IIO_DEVICE_ATTR(oti, 0644, - ad7816_show_oti, ad7816_set_oti, 0); +static IIO_DEVICE_ATTR_RW(oti, 0); =20 static struct attribute *ad7816_event_attributes[] =3D { &iio_dev_attr_oti.dev_attr.attr, --=20 2.34.1