From nobody Sun Sep 27 00:36:53 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D83E31578E; Thu, 27 Aug 2026 13:24:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787837071; cv=fail; b=W++8j350eLfFiQIxpW4X0FoJ894zDdc6lCu7QlnExJeIlHjp/hs2eW794pWGqZsAO7awpX2gTNHwy/ZV0l1LjzN13C6pN/AoZs7IGqRlOYro+q1X5Zt0Vt5iwgwtIYRdCTaXnl4F5J4qtSn+EvQWQaOOt8b5HFHOVS39Z08eIDs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787837071; c=relaxed/simple; bh=3l+N7VRjb7sCYwjUPdOx+NEFhmC5BVJCOEULINgQzmA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=luCATyhDvHvGfX3zffAQWFZvXUTuCaHiH6XEqTSQ/NiScPqOT8V4STjapgdw6s/m329cTmAwRrhr8z/P+eDrh+Kxh9ezBO9g6NHxLmjZZm6f5uPfHuyLVAUSH27PoEeYeiy37LBkOx3upizv2vLqT+o5pVoFHhJ3xoddtOXOZ0k= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=S9yD8cLU; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=Z/ii0Na7; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="S9yD8cLU"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="Z/ii0Na7" Received: from pps.filterd (m0380145.ppops.net [127.0.0.1]) by m0380145.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 67RCA9Qw2915293; Thu, 27 Aug 2026 08:24:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=r76QOfszn/d06cjyEn+KvN63bOkOlgpaVUcFIgF87 no=; b=S9yD8cLUsIuuIHTsix+SQfarXqjg7DFF1oQXpoEM55Eur/GFSHfQHw60m ZSqzRTFXeFVhp5uAFh9mK9rDpWRRBMFUyGTeooCloia5BkeqQyfakdmQekNoPKTk rbMgY1mH+SkvdStJMq7ZGsnFk/0H6V8VHjya9C427gEMKalKlFbyPwsOBLhlgNbK L4WZOcLWUchQBeSKwojQunqyC8IsW9VLQdzZGT0ja1P0n8byZO9d+aPMpbkcmZF/ 4H12WxPE9/6ZxwgNnFciNl+7mODY9kQUTOS86prfc4ZLYemkKInsrr3O6E92Pan0 BssDu12hPQdw5CNJtrWuHpVxcaSXw== Received: from dm1pr04cu001.outbound.protection.outlook.com (mail-centralusazon11010020.outbound.protection.outlook.com [52.101.61.20]) by m0380145.ppops.net (PPS) with ESMTPS id 4gahg39dbp-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 27 Aug 2026 08:24:12 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xU7MyBgLyBN02enBW5KuHUzSd8NbYnEDPOwKGEIEIL4+QwfeSJr7kfnyRqMI7cHnVItbq6hcTJkp8IUztBNlMaKdjlxbgeGKcKtCGVyhWrAuZdb57tGxAU0zyIBgT65dMwrOGUiYqrScNb0OmEf+kKfxeZNLcSj/S+cbwKJp2S8eSYivpHB1GizOCeEHBR7oUnf5LhDSyv2XuJ6LnAWnfmC2+u4vseV8x2JAUO4ww3qROVbX4PBreo8V6eOr845pQJrgYDZX9pxTA6OJ4GetLeuy68q0I8k1GaQQItxcjnTjAyZkIvElwF1o0kT71tSDS0p2VwGcT8kyaJW1VJ60Mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r76QOfszn/d06cjyEn+KvN63bOkOlgpaVUcFIgF87no=; b=xyYg6Y8YQfvkei3fbc1GvGp125dxAh+BzlCLaecSRrEAxT0w8WBX85zz63BQ9o+bUl6cGt2zN2bO0XOs3c7xClIjM/Te9BbiupXzH/z1Iyp3C3dQFS2OJtwe2abQMKk8+6cgOVr8ELV3LWgHVuNzEeJJkT0Ms5HyHFjomtcTzq0f4knC7DML/e/uejLzM9t1s20EL1QFunfQY6Ufys2+RW606q07swC12upXEPpG1eFeZj9SJs65wpWIEPc/+62iyDUlm4ikB93Dot9/4rItMX2FuDS+rWIU+QLP7YYpnc7u+hqx//M+dcAUXzrfwZm770IaI0KlCofLruelJiXevg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.194) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r76QOfszn/d06cjyEn+KvN63bOkOlgpaVUcFIgF87no=; b=Z/ii0Na7sqRCOVibf9YwVmstFfUQc/adZNyOegTNb9PBqjwZeIOK1zqwSbwt0rl7aBlc0rKz8wqkKHf2/N06TFwur2a8zc9Xa0jkMLsDv1uENYOYhcE/c4YTL8JBWZ7e0qNxXXQJ5UvoHLuhja+OYW0CULNlLZGKqLi8FD2dJpI= Received: from CH2PR10CA0021.namprd10.prod.outlook.com (2603:10b6:610:4c::31) by MW5PR10MB5827.namprd10.prod.outlook.com (2603:10b6:303:19c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.360.7; Thu, 27 Aug 2026 13:24:09 +0000 Received: from CH3PEPF00000015.namprd21.prod.outlook.com (2603:10b6:610:4c:cafe::18) by CH2PR10CA0021.outlook.office365.com (2603:10b6:610:4c::31) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.360.10 via Frontend Transport; Thu, 27 Aug 2026 13:24:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C Received: from flwvzet200.ext.ti.com (198.47.21.194) by CH3PEPF00000015.mail.protection.outlook.com (10.167.244.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.360.0 via Frontend Transport; Thu, 27 Aug 2026 13:24:07 +0000 Received: from DFLE207.ent.ti.com (10.64.6.65) by flwvzet200.ext.ti.com (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 27 Aug 2026 08:23:33 -0500 Received: from DFLE215.ent.ti.com (10.64.6.73) by DFLE207.ent.ti.com (10.64.6.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 27 Aug 2026 08:23:33 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE215.ent.ti.com (10.64.6.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 27 Aug 2026 08:23:33 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 67RDNWWX893893; Thu, 27 Aug 2026 08:23:32 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Mert Seftali , Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , kernel test robot , "Dan Carpenter" , , Subject: [PATCH v2 1/7] crypto: ti - Use list_first_entry_or_null() in dthe_get_dev() Date: Thu, 27 Aug 2026 18:53:12 +0530 Message-ID: <20260827132318.613876-2-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260827132318.613876-1-t-pratham@ti.com> References: <20260827132318.613876-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000015:EE_|MW5PR10MB5827:EE_ X-MS-Office365-Filtering-Correlation-Id: 9e39bb92-c3ce-4e92-543a-08df043e7928 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|36860700016|376014|23010399003|18002099003|22082099003|13003099007|10067099003|56012099006; X-Microsoft-Antispam-Message-Info: 2Jg9NBAw1We/oGtp0MdMrRI9iKxtPHVrxLxULBuGPIAiN7KT6WMindH0lDhYC84OXZSxSTabfAouvfk/Ra5rrV78AqFGLpHddrhcyWJgaA/VHhyojb7SMPLbSenr6gqwg2LMiGuuei8FXcbutckZfg+v6EOQrh6loMio8Ps95hcl9B6iOeU8U3CwEpQnEHauFjIGDdNBafQ45RL56wWQQAkhTK1aOIIRucOSn+U6Bvp66DaKJfq0GSvBMqAq/qajSL6iIw/BU1fev6jEIkr/tNhle5FTQ1Jb/WQppgrpVZgJBi58wly0Csvr73cgQTm3JkT+iaRnRtUm2eeNg6gj5jl+D2NKkUTG9kYmmgQ60R6k0Z87gkeLKD3kSh/t6yDQ++qVLNSTyf/fAn+zaQVdjRGYJb4habRkGG6GBe/xcZUPBQqqc8UGMMqbyK3AuOP3UxFD0wr2oi5xoFWkaKh8po/b9CCZb5MD8vGDlHa01Xo/3niqyzVJA95lI57i8PbPDmNVVQZ+7o7dTvDGCdEejsZH9udwa1JJWLckcu6a2+9thNjzDL4bdZWaQnzf1atBHhsZsuUiF+hUehUBGoUyrvS5rM8BQPrml9OA4E1cLfeJydVQReragGa3SbS3RR+ijb0Nmx17QbHwlcDi+6mIKg== X-Forefront-Antispam-Report: CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(36860700016)(376014)(23010399003)(18002099003)(22082099003)(13003099007)(10067099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 4BCl4FpzEjxkY6rYCN1fY76yEsWmIqtOX3UJjkCxMwqSe1N8fsXzkmqS11SoHHgvlkSk4iUrkbW9TJEJiLQHmU8E0e+N3GvZ6k/QRI97b6Mx2/CoWHoHxCYhSyi8XQcynix9vK8WyZv1l4MWUIXLGKltIAuaIJaYLwcr3FRS5sG4ySM5EyKAxrl41/p3xwsJUCN/yJp6fYoxUePtPJredIJfEGw9m6Tn7ucIlnCQnXl56f96JDZ2UkXBDp7fSXPmeM0TI1714wLyo2BkVlHC2/vsvUYvphuEuCT8riZ0TL2ezFTNJcCmMqml499QErOq15Jj6M9BSf8aizZrm/WpmvoGSNDgRSz4azYDi3AgtgIRSRV61NBZQgzZ48aGMyq2cA9ahdQzYyDuHON/bhOCfZmRctJk+S65+FokuvPyTnCm9YEwo1sDRiHC/3V+579F X-Exchange-RoutingPolicyChecked: wFX/UUjEVqE2wlaQEFU1eIofHFuWUsLkawZ2CSx0ZzOjypZi8Gcy33wgRccqxyyeij/Rx/VYXRuHKneoZogVSkyK5bN6yHgGC26suB9CpBmOhbvRv03yrws4icWDsBHtRBAbXWq2eCjtOWCE4ofhdpvimb8LCjGHKMHxUIIXHIODOKEOF/EAQ1DySQ1nLOno3SqXk3G0paS3fhQb5ee9uAYL2bpgOMuodIMSy4AErWIIv9chMS8PGUoay6HV5vRfG9TWU38A6lUeAk40hC8xKEmbePMRyj2QCH9FQhb1liLNEGX192NR6/XkNPzodZ6Xqbm6WxJIsTOe0LlnrPredw== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2026 13:24:07.6117 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9e39bb92-c3ce-4e92-543a-08df043e7928 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000015.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR10MB5827 X-Proofpoint-GUID: XHiO88QpRq6Cw0tTKboz7WNNjEVzJ8oM X-Authority-Analysis: v=2.4 cv=M4597Sws c=1 sm=1 tr=0 ts=6a903a7c cx=c_pps a=nwluK1hbAjewvkLeLlmlZw==:117 a=iwqwCZQqcuTv3JOpYdM7/Q==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=Sv0fKeRqtYgA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=gO1vWkAQAl3rybz1DQOp:22 a=VwQbUJbxAAAA:8 a=QyXUC8HyAAAA:8 a=pGLkceISAAAA:8 a=sozttTNsAAAA:8 a=HYHyqeARaHjSmq2Pe6sA:9 X-Proofpoint-ORIG-GUID: XHiO88QpRq6Cw0tTKboz7WNNjEVzJ8oM X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI3MDExMiBTYWx0ZWRfX1x6PR3vCNz4h KBzLK9BMdKoU5ZztBl8DWjBerH/ZPwyM3xGqQDh0tUcmU8mc6n2Xh9T7zSVDow7oRk48aPl4ESK /SryqrpN8XcYX9Y/llY/tu03i9/YXQGoljlvBre54+s8CVEPIWTY0D+6FoXi0yo0asygs+psvnX Uipa2uFY+gAiYaPCE5+gr/lLoiLv89IXMhB91xQSRjv6LNvJxqYhnvNHqeHl654QSv2QAie0kX6 5hSTzuzW/BP8613wwf9f5V20lTZp1MXARq+eTPe6ER2vV2cXW6gx06D+nb/9/nvgk8qbj5+9tQy zMWnpXGyVqal9qzVfekgyGsIRh4BbKkSvNAqqPpwhU0L+YQSn6yaly/UBTtSiu1+YuAMjtVPaM9 pXaqTODIWyq+IokAu+PO8NcdNGJYA9E3LwFVDr32Pvr4/a9drB9Y1vA3WL0rL4agOgqobGYreX7 msotYCgcz6OnKVLEO7A== X-Proofpoint-Spam-Info: AW1haW4tMjYwODI3MDExMiBTYWx0ZWRfXx7OgckkccpRB v7VY7j0yfpPLAYT7Hvaki94OgnAVAgZsHBW2mlTNaKnyFd9HIVlHwYRVLa+XmZB3Qr9A25pvSXH g0WAZBEKLApgKNiqHN+81qtDj2mUpGc= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-27_05,2026-08-26_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 phishscore=0 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608270112 Content-Type: text/plain; charset="utf-8" From: Mert Seftali dthe_get_dev() fetches a device from the global device list with list_first_entry() and then checks the result for NULL. However, list_first_entry() never returns NULL: on an empty list it returns a bogus pointer computed from the list head. The NULL check is therefore dead code, and an empty list would be treated as a valid entry and moved around as if it were a real device. Use list_first_entry_or_null() so the existing NULL check works as intended and an empty list is handled gracefully. [pratham:] Add null checks on dev_data in callers of dthe_get_dev(). Fixes: 52f641bc63a4 ("crypto: ti - Add driver for DTHE V2 AES Engine (ECB, = CBC)") Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202606111933.69GGTKxr-lkp@intel.com/ Signed-off-by: Mert Seftali Co-developed-by: T Pratham Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 12 ++++++++++-- drivers/crypto/ti/dthev2-common.c | 2 +- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index eb5cd902dfb59..4fdd24ee91637 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -112,6 +112,9 @@ static int dthe_cipher_init_tfm(struct crypto_skcipher = *tfm) struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); struct dthe_data *dev_data =3D dthe_get_dev(ctx); =20 + if (!dev_data) + return -ENODEV; + ctx->dev_data =3D dev_data; ctx->keylen =3D 0; =20 @@ -124,6 +127,9 @@ static int dthe_cipher_init_tfm_fallback(struct crypto_= skcipher *tfm) struct dthe_data *dev_data =3D dthe_get_dev(ctx); const char *alg_name =3D crypto_tfm_alg_name(crypto_skcipher_tfm(tfm)); =20 + if (!dev_data) + return -ENODEV; + ctx->dev_data =3D dev_data; ctx->keylen =3D 0; =20 @@ -571,10 +577,12 @@ static int dthe_aead_init_tfm(struct crypto_aead *tfm) { struct dthe_tfm_ctx *ctx =3D crypto_aead_ctx(tfm); struct dthe_data *dev_data =3D dthe_get_dev(ctx); + const char *alg_name =3D crypto_tfm_alg_name(crypto_aead_tfm(tfm)); =20 - ctx->dev_data =3D dev_data; + if (!dev_data) + return -ENODEV; =20 - const char *alg_name =3D crypto_tfm_alg_name(crypto_aead_tfm(tfm)); + ctx->dev_data =3D dev_data; =20 ctx->aead_fb =3D crypto_alloc_sync_aead(alg_name, 0, CRYPTO_ALG_NEED_FALLBACK); diff --git a/drivers/crypto/ti/dthev2-common.c b/drivers/crypto/ti/dthev2-c= ommon.c index a2ad79bec105a..cc02449382673 100644 --- a/drivers/crypto/ti/dthev2-common.c +++ b/drivers/crypto/ti/dthev2-common.c @@ -40,7 +40,7 @@ struct dthe_data *dthe_get_dev(struct dthe_tfm_ctx *ctx) return ctx->dev_data; =20 spin_lock_bh(&dthe_dev_list.lock); - dev_data =3D list_first_entry(&dthe_dev_list.dev_list, struct dthe_data, = list); + dev_data =3D list_first_entry_or_null(&dthe_dev_list.dev_list, struct dth= e_data, list); if (dev_data) list_move_tail(&dev_data->list, &dthe_dev_list.dev_list); spin_unlock_bh(&dthe_dev_list.lock); --=20 2.34.1 From nobody Sun Sep 27 00:36:53 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C08222C031E; Thu, 27 Aug 2026 13:24:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787837071; cv=fail; b=OhQLjYEuoxm2RbXFw+Y1ZD4g5SJyrg9A4FULFoBQ+XJd9brOZ/UinIy37N/nmYjzVoPRd3KdzzVRVqdDEt5AHGQWdNcPJX9RBTG41BDAKOL5QgDAlLd77nJhc3/1RiuV/9J52+AEsQkOw+93OeA2J29U7AnAggRANJzsJvHf9a8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787837071; c=relaxed/simple; bh=JhIYat1tDDHjynnYJrzFdJBgSwjr7d6SfSSJ0/IQWLo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=gm1V6L18CquNUSKA/7uc6JNMjNOckpm2bWNmqLin1tvpb8FUsA6f76IRO7/ASEPSEcpy4uT6sW94mQ0E5IOSVi249rrRx/aOPHz9xPxI7p6hnv9bSBssAcG7fGoDOy8RVmJhYTWlSeJsWBp+iqGDCThm0AsCXOZFHlU+qKT7E24= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=FNMl5OSP; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=VQovZvdC; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="FNMl5OSP"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="VQovZvdC" Received: from pps.filterd (m0380145.ppops.net [127.0.0.1]) by m0380145.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 67RCA9R02915293; Thu, 27 Aug 2026 08:24:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=L3d/uqtROV07wByGxF+hfQgPvMnzChdKYg2ED7CQC yU=; b=FNMl5OSPp7DMC20VfDUi2xlLzYJ9FKHf+tf4h6YYy6msMqyPIcXkxrdBH iEEGpsyWy0aOw7caFYk62HVIEAyDJeRcjf2Ouj5qwmxn5uhG6/jElHejQfBjwRYZ 65Zd1Bl0nMkn0v9UkEHkzSWBlMBgNEWUP/YG/rXqjPhSmrBo0+STt+CayRMy1F+G +RJlGI0tz3BmO5CdSVjusf5RHbCh380NUVu2FHg6lJIkX7uiMuAT7gjKBR1MgiPA yCRNJWEv1RZ9mOWQXF1B783FczNwMHP9mt+KBh97brDvdIxrO13i6UYY5Lgdhyu7 JJsmrFx4xCgnCnXEs4lCGwAQnzkSg== Received: from ch4pr04cu002.outbound.protection.outlook.com (mail-northcentralusazon11013045.outbound.protection.outlook.com [40.107.201.45]) by m0380145.ppops.net (PPS) with ESMTPS id 4gahg39dcs-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 27 Aug 2026 08:24:23 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Cy8YkwuA8eQ4p7izLte6o+AOPcAw/awkzb4JqM8+W4a0G4h9Peq/ZdlH60Nx1peu+Rto3h4Kj/rD4oAk39T1Xd2qjCArc7HE8xD1iRkmaMJX+TlXgtw/CT2EY5iAlT6d69xzzvIcJc0CYd+G+vI74mwqu4LQWxQ0FpHoMZ3AuUve6Ffip0KwV2SMw7RvqPGNdjK5GVQHj8blYUhxD5DTER9413HoG8yzImUvrY4FaY+gNrdApBeM0GIsxMa4/aAOL6ofQ4EuEmvMGGyEJGTtZa0UVuGjMOnzsiAmKZH7RLTKxTMj+Ho6BLzyWKikzT9NF/TLoGk8f4GuAOsTHo0EFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L3d/uqtROV07wByGxF+hfQgPvMnzChdKYg2ED7CQCyU=; b=u4OqXkoIqxqJD06XMuXEEBTZJu4ueDAWTMne8q3MlSIMrCf9R4rn2dCSpnbUmhUnZW6ig0JirKZKGHSokOxnqAMUCXDHIJFDGiCDZ6xlQ5WteGlXJUu7D5H1REQO57jZIpsOStwfF+hYsd1W6dnSVyT/5shxiV6gB+w0wYpDE1R1Z78DbGymTI48Xlc9qqgCXqeQUv2ogjzZFsWWmytcuCZ+RCtKqwprVE9YItDXVevmJbaztoKIt0c4kPV8kTbjuvCFrUsQesMx2itn7KKaXcOL7R538Sq/YCuhVEeyFouR814oOTxbgXQmTi2wW4TIpoQ/vgGHhqI5htAIezNwQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.195) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L3d/uqtROV07wByGxF+hfQgPvMnzChdKYg2ED7CQCyU=; b=VQovZvdCLpuu6e/6qKQzj9nZG+RuNkwhpYzQ0UeI6MNDb2qLqSFsOjHMB8uhFOqKGr4b0pdbPqUae75dlqbr4sUq3aGuQlQRHLKAAt44jfjJO3zWIjr5ScRnV++ETObHrMYsY7OdJqpAXDtoBNr6fbw9iZpzwSz9duyQlULWgo8= Received: from CH0PR03CA0205.namprd03.prod.outlook.com (2603:10b6:610:e4::30) by CO6PR10MB5651.namprd10.prod.outlook.com (2603:10b6:303:14e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.10; Thu, 27 Aug 2026 13:24:18 +0000 Received: from CH1PEPF0000AD82.namprd04.prod.outlook.com (2603:10b6:610:e4:cafe::99) by CH0PR03CA0205.outlook.office365.com (2603:10b6:610:e4::30) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.360.10 via Frontend Transport; Thu, 27 Aug 2026 13:24:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C Received: from flwvzet201.ext.ti.com (198.47.21.195) by CH1PEPF0000AD82.mail.protection.outlook.com (10.167.244.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.360.3 via Frontend Transport; Thu, 27 Aug 2026 13:24:16 +0000 Received: from DFLE201.ent.ti.com (10.64.6.59) by flwvzet201.ext.ti.com (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 27 Aug 2026 08:23:36 -0500 Received: from DFLE209.ent.ti.com (10.64.6.67) by DFLE201.ent.ti.com (10.64.6.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 27 Aug 2026 08:23:36 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE209.ent.ti.com (10.64.6.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 27 Aug 2026 08:23:36 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 67RDNY5X894060; Thu, 27 Aug 2026 08:23:35 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v2 2/7] crypto: ti - Fix potential deadlock bug in DTHEv2 Date: Thu, 27 Aug 2026 18:53:13 +0530 Message-ID: <20260827132318.613876-3-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260827132318.613876-1-t-pratham@ti.com> References: <20260827132318.613876-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000AD82:EE_|CO6PR10MB5651:EE_ X-MS-Office365-Filtering-Correlation-Id: e7086b54-b287-46ea-20e5-08df043e7e2d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700016|376014|23010399003|82310400026|6133799003|10067099003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: +AbizqspExR+mBEuPdZ/VeEyE7NtkmmyF/Kk+Gep5Rw/Tt3cnZvG40wH1ugC35F+LH20EV6iXz+Z9wLf/mtc0VJpjAigJq+jU4IhJXuv4EyiR2FHsKwoqBKej1i80yMZOq3Y4UX71cEvvFu3ajNyI2xioDivnWbkQ0qqhO4bbD85N/ad1DhUGuU7wLAkYYmcDxioTUDiKbkA9Kn99CRxVE/tWhTZ7cnYsCT3bk2htVpNJL7DcHLOEoheMwGs9XoXUA2tPpFGVfbHIAiSzLmraGg+rTFZVYsorHC5W1P0EJO2rRcczbaTSwMzXYrTQ7HlxMmoYStFn0npsn6ygH9l1W3Ky1FUe1B5RC6hCI+sRm6uSxw6Ais4Bj35GNG7a4RTyeqTy7PCw6CmCnYQgI974x+3crEZbPyon9m4/pWDAGXSqx9cSzSWW7nggok2p3Z5+6caAk8PYhGh0oXQmFT9Qf0k9qtg8ulBgFuW79ShUmUidPJK7KEW8zz2/5U0OAEplQ5WUO4TrZtAsX4ls5WSfZ3bzylcrEszOsOMEnwDGm964Ir5Mb/R9Xj7RbZ4TRKmXw73bbl4/Yq3F6ACir8h/wlXzRXrUBtEMipHnook8cakeuqssKpJc6DRhpAyDOK5Kh5aeOpI8PNkxh8/TbUrwqM24T/zx2cQVWM8DMhOIrH+u+Mk220b4et3S88MvqjgXcWQ8Q74Sa7014csbMriew== X-Forefront-Antispam-Report: CIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(1800799024)(36860700016)(376014)(23010399003)(82310400026)(6133799003)(10067099003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: nPBu6DGRKsHwDdq8rxYuaDNUPKQBXl6YWfr9XprZD5EVIUHHPlwKsxyxavm2pjCWL5UQeJQc8XgcOx487rF1Wo6+RBS8PM1KP2U5Jx9/X+II4Amb/4oYFM8iyieJR2m+sgFXmBSWPVwVLmTnl6pPB9jHVZFqVFs0qZLK+rjQhctHH4LcP2SspGR2FfphMloV/lp/1CN2Ojny/YT5niIX5LJGDo0za9XFYAyXLb/d24Iq2dmtRRZbnPU//P+TXOBN/fenFdsZpL4nyGs3z+B265ouRq9Idst5ad4QxXJ+pVlB85pPbu2/ptVHV0pOpLAhryXXZA2uhewlbKwEVM21Kj8tlRYlipx/TTIKl8w63WmtFWk6NYr4NuzHNLs8dCg6P4aoZHJzhyhGCLeXKEezCyVgemF0/TSwrSaIvJTzuenJNy2BOp97IDwo/OkdUxXq X-Exchange-RoutingPolicyChecked: EZhAtSrXX+EjAOxPH55LTSMB9DMRzdlGGGjW5ivpiN8bWlKFfvzHmxI2EawqQeboM9Nx0tQUALChzAVj4cuMeFJZbsoBr9h1u1CdqYr2z0uKL1OVQNfcoCyUsvOo3K7KeFWoOJDouL8QNTBKAlP+MeirkUzfAVqQ+t1SEtBWh2fEyAtrDgrrf3Gf1E90YLAZnIJB/+k2LUc9h7RTtBq2TQilzzPHg/xPcK0w7TNjv3/h+nsHe8eVjLW/KJSFi1lKSTnb6CilMLDGyPLCCwzezOVRMQ9PMS7HO53toQ4ncfbjbeQG7+XBEKGFaYyOEcyf60RvZEKpl3ymisfUvrEnqQ== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2026 13:24:16.0389 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e7086b54-b287-46ea-20e5-08df043e7e2d X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000AD82.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5651 X-Proofpoint-GUID: iCwOr4ky15AlI4YSSh1jJ9hBKYkntTgW X-Authority-Analysis: v=2.4 cv=M4597Sws c=1 sm=1 tr=0 ts=6a903a87 cx=c_pps a=IhFJ2QRitvxj7yHj5jvJkw==:117 a=tJyPKKxUohctrY4NYmUjkA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=Sv0fKeRqtYgA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=gO1vWkAQAl3rybz1DQOp:22 a=sozttTNsAAAA:8 a=ki2JzQWVm1jR-OH3vWAA:9 X-Proofpoint-ORIG-GUID: iCwOr4ky15AlI4YSSh1jJ9hBKYkntTgW X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI3MDExMiBTYWx0ZWRfXzJQ1/WEUJjDQ C1Rk5IxE1VMY3rMkxUO71io2LCtKZ5UVB4d8fepSbzrr2/KFbYsHVKVrpwkDOUG7wBgAOsX/Bhf 2tS3jGK1994g3zCdAb5ks7ev48hveF7ML/38xykTjYgy+5OYoaZnLkmcp78oorVy31BchYmAOwA ZDx9l54PLpRMhbcgX77TC4f8as5R1ZaZlYrFoHybKH+s0CliOB8TS3cC1UO402qLw+mxsHdocCZ tukqhroupLvHulEg6zo92sdTnJNLoqskrSnbBiiaeRA/zDBoFgPmvw2Azd4d5BAfg9EoqcSLeOD i0v+8DyAA403+yRqo4jeeFxYNQk5fDLHK1UWfm1xKs5r3is95lxGkBbUTy2nZ4gjY4SrM8FPpM8 /FTa6PwioDgXdPbi+gEaQpfQXLN6JR9MmPuR05JfFFpvaSvihKRuw2Jxo+125AjXztLCd9x3v8o bTPkOHlSi6RxIimJAuA== X-Proofpoint-Spam-Info: AW1haW4tMjYwODI3MDExMiBTYWx0ZWRfXye7klpOUFaX+ gZWUQQyhyLwL1zPv47RkfP0L6RvQY83tC5+7jUlOudENUvkgUP4N1mwMm2enCqmP/oRztAom/c0 9okbsZGvk1wrJh+TzjgpQkCUz4FYCS4= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-27_05,2026-08-26_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 phishscore=0 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608270112 Content-Type: text/plain; charset="utf-8" Probe and remove functions use spin_(un)lock for acquiring the dthe_dev_list.lock. But dthe_get_dev uses the bh variant. Change spin_(un)lock_bh to spin_(un)lock to avoid potential deadlock when a softIRQ process tries to acquire the already held lock. Fixes: 52f641bc63a46 ("crypto: ti - Add driver for DTHE V2 AES Engine (ECB,= CBC)") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/ti/dthev2-common.c b/drivers/crypto/ti/dthev2-c= ommon.c index cc02449382673..4c6b72ba104ec 100644 --- a/drivers/crypto/ti/dthev2-common.c +++ b/drivers/crypto/ti/dthev2-common.c @@ -39,11 +39,11 @@ struct dthe_data *dthe_get_dev(struct dthe_tfm_ctx *ctx) if (ctx->dev_data) return ctx->dev_data; =20 - spin_lock_bh(&dthe_dev_list.lock); + spin_lock(&dthe_dev_list.lock); dev_data =3D list_first_entry_or_null(&dthe_dev_list.dev_list, struct dth= e_data, list); if (dev_data) list_move_tail(&dev_data->list, &dthe_dev_list.dev_list); - spin_unlock_bh(&dthe_dev_list.lock); + spin_unlock(&dthe_dev_list.lock); =20 return dev_data; } --=20 2.34.1 From nobody Sun Sep 27 00:36:53 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0C9247426F; Thu, 27 Aug 2026 13:24:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787837081; cv=fail; b=pjJJn/OdIv4HGHo8q90AoyI4Z+NHhuik3tzqNXGO7SOXKbfmtQtJ+vcv1fGdM8a+QWfzgHaF0C9Bd8kgI6yh4FCRvF/uBD2pHs+p+0EpZEo28iN1cSGTaVQho0Ipqbf1IGPdpe0M3SL3wEA68E297UEMpHTzV3GBDIRV2hIu4gQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787837081; c=relaxed/simple; bh=SytUeFdB/MKaYKaubrhZRnRz1jmrcwLjp0R6X9UVqZU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=M1OyAL81pUeCE7BVsCEmmrmXAfSsUSDcH4Iepk3YEj4OIfkCSHd5O/JJOH56kxaHkGjpAmRWE7n4oGQjyLzYCiu1RXGAXp0/urPt/8UmOXVFct1H9MdYdt/ccRkCcufwXoi8SS7d8jv4yb25yX/2bVs9ElSPryAcCR7dOCRBweM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=J0I0Toi2; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=HID59Hzf; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="J0I0Toi2"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="HID59Hzf" Received: from pps.filterd (m0380145.ppops.net [127.0.0.1]) by m0380145.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 67RCA78f2915280; Thu, 27 Aug 2026 08:24:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=ys2sjHHwD+AiPU99+X4BPnXwi+/C0iIWiOc5Chq+H GE=; b=J0I0Toi2/4hN5fiF84KD6GaMYot/axjGMC96xYAul3R5ekSW7nKHfmt+X EA0Hwsor2wTu9t7LuAVIeu1yWPMT4DrgofXSezV4gyrgAJhRaJ8ZGQFdT3FtVq4Z w8+eVEROcOdhzZLqlRwxv6ijs4SRqiB++tuWz4BQ6o2jD6IC/Q5selmgFZyMTjZ0 Ha6D+tPyJ32pKdF1Z2agU4vTR2QwUsWc6jf3uH1aoVqsyWRWNKAB8IAPOdlLmT2g VyAHQQBHS0kek1OJhSUDE1fI+829Pkt+UnIpyXmXHEN6+O8Xz7BaH9zHT+mCV4bB 79KKJ8HXAnfXU9WZfRm4wOatsOdEA== Received: from sa9pr02cu001.outbound.protection.outlook.com (mail-southcentralusazon11013061.outbound.protection.outlook.com [40.93.196.61]) by m0380145.ppops.net (PPS) with ESMTPS id 4gahg39dcw-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 27 Aug 2026 08:24:27 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=g8dp5Ec7FkzFY63HMShrjbY1QP6bsl9MixIMmFa0+sEncEw9HVHzo0CbjMM73pCjHHwhz1LPqbpFZFH4IgvzDAzTAtTMLu5YXarBBIXyAZyCEJmS0Aqwgn8vSp77e+OAaou7LMFuH59N//bbEXOfE4luvHv6XGBlF6D5TUDFa3Crz/1tYJfYZtYugAnd2d2Tyy0qJdlczyrF3lZemgVSCM8+XDp3DnZqlry9sSsEHBCo1mZBTqm3uK9PQs3rWFTBsr3BeCIcUFjBat8SITseadJFDQugF5IenTb5O7SjZJgP47TBwV5RRGISdQDmKOnEmd23c80vK8XkyWHv0nAmig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ys2sjHHwD+AiPU99+X4BPnXwi+/C0iIWiOc5Chq+HGE=; b=u8hnwBVQ6ktgeQ7vvYm1X6ZSOgjA3MQG6pnb47oS6sl1fnygGMe3RXIkNMMhqwhHUcvJb/RfPKBMn1hy5YzWRrDils24V1Do9PZ6uHKsA9L7mhHhjY34dtzK7TI3vOEq25xmQhob5A/FA5g9fWpjDWKxms+tBlr4Pa8oxn4a+EzcSNQA7IeR0AMxfnnUao2c2LwNBQeCtnbb3AjfFjEdiK1cmRXkzqeEPluWDd1iIFhxMh5eDlAfssvKKWC0OG5EOdbWKeSzAhG6QYlpWntBCtLqlVFp3HrJSWeNqZAe3N6rkvgQzzuJwGrMJ1w+lcr5eM1YFRQ+Mjqs/QOOs/Zamw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.195) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ys2sjHHwD+AiPU99+X4BPnXwi+/C0iIWiOc5Chq+HGE=; b=HID59HzfTHcR6o+PcWjBozJwJUAFcDqJH6cCD9VEMNntnlH/kKSSqKn8ea8cEN+IPZHu7Ja31ZEYNkfPFrHvHXjbyTMqFsQQAIfI3QzSDNmw13r+Q8PmU43m+CXjvDaPiyFkYkTM3H2jOTPSCRAwXMoESvAa4e5XPt2yfvENUWc= Received: from CH2PR07CA0044.namprd07.prod.outlook.com (2603:10b6:610:5b::18) by MW4PR10MB5839.namprd10.prod.outlook.com (2603:10b6:303:18f::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.360.6; Thu, 27 Aug 2026 13:24:20 +0000 Received: from CH1PEPF0000AD7F.namprd04.prod.outlook.com (2603:10b6:610:5b:cafe::5) by CH2PR07CA0044.outlook.office365.com (2603:10b6:610:5b::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.360.10 via Frontend Transport; Thu, 27 Aug 2026 13:24:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C Received: from flwvzet201.ext.ti.com (198.47.21.195) by CH1PEPF0000AD7F.mail.protection.outlook.com (10.167.244.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.360.3 via Frontend Transport; Thu, 27 Aug 2026 13:24:19 +0000 Received: from DFLE212.ent.ti.com (10.64.6.70) by flwvzet201.ext.ti.com (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 27 Aug 2026 08:23:38 -0500 Received: from DFLE201.ent.ti.com (10.64.6.59) by DFLE212.ent.ti.com (10.64.6.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 27 Aug 2026 08:23:38 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE201.ent.ti.com (10.64.6.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 27 Aug 2026 08:23:38 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 67RDNbHl894112; Thu, 27 Aug 2026 08:23:38 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v2 3/7] crypto: ti - Fix potential memory corruption on highmem pages Date: Thu, 27 Aug 2026 18:53:14 +0530 Message-ID: <20260827132318.613876-4-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260827132318.613876-1-t-pratham@ti.com> References: <20260827132318.613876-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000AD7F:EE_|MW4PR10MB5839:EE_ X-MS-Office365-Filtering-Correlation-Id: 60b3df83-f248-43a5-e8bb-08df043e8006 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|36860700016|82310400026|23010399003|10067099003|56012099006|6133799003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: /1+XSWDnLm1WY6TXhRpVXoBPrIk0SUxTeAEjqAldoirVVoFp61deQoB0qhHuLDtwVQuGJVHJbCRwPb+Fiom7LY+mJEO4m9yTNeRNLOb/f40XBxsHFq8A8IGfZ/FVC69CEu9k76XMjr1IZTGSLj9O92awrE6vnqvvgdcFc6XeteV4F9/ZlIDYS4F7haQ0VxkuFrYyIZ4DZ/yVyFNPeEGp5Milr3Vqa9/FdeWx8JQzMJX4YSFCQHaajdrJ5/HGUIn4HOXlD1RIgIw6GKzwIPmSdN7n/4jf3hETEVZ+hb2oTqrNUi1oarEp/caFi+pksR0yS+RgBkXM6hwbh6AQg2Z065GKDifC7sDOu48gU/4y0QGX812lfVYZcH+nvfdo8gqxBmxb9+qvar86CHVxvVgCxgn3Oj5+/bEoybG9Pb+7NSEY1hwnZkMoSCJR575mjUEhKF3+wZ4reKz4jw/X+OXCoaTNkV0fjZulfVHENNBGC2HJmK2Dwt56cNUQrLBF1qcZkC7IA+KyFlMRsa/yho0sYEhmeHgIMaJClXgMYEUCwFxPp0S2+Pa56C0SnR5wIsD7HMyNraGS8ERyml245F011RcSkqfhSwZzxtLSFwS4MzFLNQZEKl8EUoKTYaF+SC6XGrgw9J4cvVsmpuMoaUlJD0REBqsABkiUFLFiCCAvnwOVpvWm7R4l2oeEtn0+rUw7go4GXloyn7TjlsgTWhN46A== X-Forefront-Antispam-Report: CIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(1800799024)(376014)(36860700016)(82310400026)(23010399003)(10067099003)(56012099006)(6133799003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: UCVj/OmHubqLVNJLZ8pYhkx9R2Ek2Y7UmWa+6/4awdbJB12H/5tmp+YCoaDzkyY61gZ5/t20+EEDoR5e0IZy3etL2B17kNqeLRs2l6gKJDHWw5/L1UmDm/JGQdyCdOO8t1UMHK41hKZsYpVixuo5xR+GV3A7cLS6kV3/2tCdXAoxL/XO9pDLYXGhts30TjbefL0VbqQ/GNvhNJeYrJ7r7dHyeJXY7FrgP6U+APjFGvs14NrWoQQmEY3yIXlEmMn1eh09sKsKhuTEMzcMzu7Gw7ZC4GEz1a8Xjm6RhyvJi2fe+fH6CZ2zZ74fo9yrhsTyvXpens1KCUJwmZvoouhi/vNrEKD1P9h+Ou1riJDe0GBYS3N1bJfKd3h7NDvwjubTgJkKCcC8YefdbCg++7rYrHxt7ORrpuxLi3H5kgZIBxTbIg2nkE+hz7S161jTVWiw X-Exchange-RoutingPolicyChecked: ue1MrgJwcf2mEfh0JkMtqEMiSGnlatWKhF8wUyC1a0+UAq+u1V3T59jLkmf25n4uQ6mBlHq4OcxGOLzZr8SioSIzpKJlHvyQU6uzTl4Z91tMmMaa0mj1+sgyCjvtuNklv3D0oJ+Qjto+0Tj1IiLfYH+zoWgSjUnZLuHSug8TNfb0gd40MW5QpSZCCHj91Qzc4gMGhP05Tl0gSMcov32769DWm14aLummcWGBbc3ab/PpnSEwzCXoBwuTFChL/V+mr5URb71FuswFkSflsFTjJpDD7T6JNpQr/HDTGpghTQD7gjVGfcwWwoPSTkzD/KOMJL47H2LdAVkVnflrsJ3w6g== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2026 13:24:19.1352 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 60b3df83-f248-43a5-e8bb-08df043e8006 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000AD7F.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5839 X-Proofpoint-GUID: cnFE1HMTwP9Ortl8Ns95PjRUnJY_EXh1 X-Authority-Analysis: v=2.4 cv=M4597Sws c=1 sm=1 tr=0 ts=6a903a8b cx=c_pps a=DPCWJwWgIuHEo730oqIOaQ==:117 a=tJyPKKxUohctrY4NYmUjkA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=Sv0fKeRqtYgA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=gO1vWkAQAl3rybz1DQOp:22 a=sozttTNsAAAA:8 a=IXP722aH8NCvtdUuCEcA:9 X-Proofpoint-ORIG-GUID: cnFE1HMTwP9Ortl8Ns95PjRUnJY_EXh1 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI3MDExMiBTYWx0ZWRfXzTOQCxLSvy2Z WVmuJCkUzUqoRFptft1csYvZHxq8pRg60m3f/J/Dj52rZmyntKAxAvx3leMhBFtAFMhJzB6hKGc H3xqylBJXj859emCu5OceRV2AcQ3sR84aC8lVtCxhTSy9FP+RqTGIH953RMzojKw7W9es7BBAT1 Fkrhl1N4ojtCeFD9cuy55I8h7OLyPxA8gv4xXPYXE/YpcUmiwL+sQHTPRJcrP0wuv4WM0T7jCdJ cfG7VoQavYRAJ7LH8VebIbhG9tN/V5xiYdAtSWS5omlLsaSVwBe/reUPB77LZDYe9s8+2ZtIxup gWDm/763+2PGtXM9RzHZsu8xLBkRL4ZeTK1hc2ETeTasE3LU6BhC2Dc8igZ3hdYdqH8LTRVblVo nIPuDKRpcEwDiuOaVfb/ItyzeVAaKmQbVoX/J8FLA2o8JTQplUvzDzLOY4KOKoN7No6Z+7J5hhT 8ZPoFq8dzKrDT+Yls3A== X-Proofpoint-Spam-Info: AW1haW4tMjYwODI3MDExMiBTYWx0ZWRfXxNMKO8oCu+if Ex9IJTR8anKhc+UzozzMmTCMapblWsjwnFrHEjp/qJuxapl4Z9UK3OwZDY3iYV9KOXb9aWycuEa nqZnbN1pIt3iSA0OGguFcn4nFHWyJ9Q= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-27_05,2026-08-26_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 phishscore=0 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608270112 Content-Type: text/plain; charset="utf-8" Change sg_set_buf to sg_set_page in DTHEv2 dthe_copy_sg function to avoid using sg_virt() on scatterlists. For scatterlists containing a highmem page, sg_virt() yields invalid or null adrdess, causing potential memory corruption. While we are here, also change function signature to change buflen from int to unsigned int. Fixes: 35645ca63caa1 ("crypto: ti - Add support for AES-CTR in DTHEv2 drive= r") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-common.c | 4 ++-- drivers/crypto/ti/dthev2-common.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/ti/dthev2-common.c b/drivers/crypto/ti/dthev2-c= ommon.c index 4c6b72ba104ec..8628187a32e18 100644 --- a/drivers/crypto/ti/dthev2-common.c +++ b/drivers/crypto/ti/dthev2-common.c @@ -50,7 +50,7 @@ struct dthe_data *dthe_get_dev(struct dthe_tfm_ctx *ctx) =20 struct scatterlist *dthe_copy_sg(struct scatterlist *dst, struct scatterlist *src, - int buflen) + unsigned int buflen) { struct scatterlist *from_sg, *to_sg; int sglen; @@ -59,7 +59,7 @@ struct scatterlist *dthe_copy_sg(struct scatterlist *dst, sglen =3D from_sg->length; if (sglen > buflen) sglen =3D buflen; - sg_set_buf(to_sg, sg_virt(from_sg), sglen); + sg_set_page(to_sg, sg_page(from_sg), sglen, from_sg->offset); from_sg =3D sg_next(from_sg); to_sg =3D sg_next(to_sg); } diff --git a/drivers/crypto/ti/dthev2-common.h b/drivers/crypto/ti/dthev2-c= ommon.h index d4a3b9c18bbc1..75d9a097650da 100644 --- a/drivers/crypto/ti/dthev2-common.h +++ b/drivers/crypto/ti/dthev2-common.h @@ -126,7 +126,7 @@ struct dthe_data *dthe_get_dev(struct dthe_tfm_ctx *ctx= ); **/ struct scatterlist *dthe_copy_sg(struct scatterlist *dst, struct scatterlist *src, - int buflen); + unsigned int buflen); =20 int dthe_register_aes_algs(void); void dthe_unregister_aes_algs(void); --=20 2.34.1 From nobody Sun Sep 27 00:36:53 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 964B244E042; Thu, 27 Aug 2026 13:24:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787837067; cv=fail; b=VyskYCQ/lxK3Q7NZ9C2AVFSUuPehsiTURZ7xbuxKj0EEg4g1FNTaGWA/OGqi0ibEbMamvYJpURBRBt8JcHDxT0Pc3vyK9f2S1PbDOaGPVhGEIekHS6NmJCNTHyd/AvdMnRg+newJQKyi4RLuHl/BDdiIgRx6Yx42Cc4sPQDZ5Ao= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787837067; c=relaxed/simple; bh=0J97k2ADQjTt5VgClQMfdh7rNSuYWap7NJhSkJJtdXU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tD2P0Bj1vVVdx6KgiUa4w+MCe83E7Ql7dwlW7uiGbRfoYPI1WfxZf6z51/l59Djg66q48ifP12Bfbpvia5VpTOEmPwHIwK+NkrlE8CdMqwdEGtiIRMcPq0LJ3SQrswZS9QtZNXCY5EykRS4FQTgwIjQPw21xBvpFUbrme5BmT9E= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=DAHCyTY+; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=FPHtGfWS; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="DAHCyTY+"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="FPHtGfWS" Received: from pps.filterd (m0374956.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67RCAJeX2720318; Thu, 27 Aug 2026 08:24:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=FX86iHTm/S2ECjFY6m5onM9+szkF2YYLpzTCdbj5G Ds=; b=DAHCyTY+sEw5fl6e2yT7XdnI4FU8nQZy1xYbg54knvqwR3Y20ntPSyXAt 2Ohu9oQaMQ4HnVTxmULk47iRndp/B68Dyq3A/JbnIaIO1nyBpJ1vHzZBKkwyGwkv JA1DmvnnwMDyayZ3CfPw2KsxG1yqhbsKJJ7zSKx/cGYqvij9C/BJcVbJ+j7O4VHA XWf3d4xGjNguI8eAphYpBbqB/sWEXQY3Zx6HxOQetHOAHdKjzgQulwWaa30c/xWP +/lJrSXaD8c8iv3pRt9axGkISqnsxbDtYFmXk7PJ7zhkMqVgSvIOlJAxIHB7Otkc 6jKOMjcJFWLlGiaG6EEoPdAVowRVg== Received: from co1pr03cu002.outbound.protection.outlook.com (mail-westus2azon11010060.outbound.protection.outlook.com [52.101.46.60]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gakag0wd6-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 27 Aug 2026 08:24:08 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=N/c6JaQUr/UtmrKcq3GwnvEFQ/3Rc2SvsHrrOuv5siDjBplCuuj2XEo8S8qajb65YpnZf46CO6ct0bPCXRfjrOMXQ66KllQbCIFMh1QB0bbXZvcjglgtOdWgJvRvS2v9fExzGqn2rXbmdvsfrNnwiA3ZVIKJXcHPywMuCW9W+4k/5hW7ESGOSiHcU4GJYLT0qFW7feS1gc9200oqOK5zAErcpqc6soVUCewrLccGt6Z1bXzXh4exdHkSd+izeClnwevp10LA83NUD6Bdu/rcXurfy6itekbBpyJyh1zydD/gmElArvS5M+p7nNQJs7/COvXx19tNxW6eBEYu3tKprQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FX86iHTm/S2ECjFY6m5onM9+szkF2YYLpzTCdbj5GDs=; b=twpgsb6CDp9pccuAppdyef3xt3sjJnEKBzX5GUbytajh7OJWlxMZamJ/oVvNwoQG29XGY1D7R7AQOhE5LQZ/0h0siR69Mj5T9sLmWfgZSYrVloxTpVQr0oUXgsUxL3N2kwAfg0YdjmlxOph0ehiegehlGjAlz+QaSNHD+pKYuU7vdCV1FgazQd+QXs3haQYDcNtO+m1R6zLnca4glh9Kegg+MQOGOo80PBgJjqHm0arP/Zvwv720K/1dvOLW4VTNdL3aPg/t+GhINbyd6BcACY5PmkjdmPlb9vYwgdrkzW862PbW4cUSGKgFxWr70/mp2tTHZ5W9pFc7gDNcNqC6cQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FX86iHTm/S2ECjFY6m5onM9+szkF2YYLpzTCdbj5GDs=; b=FPHtGfWSEiTxBc6HJmi04gUk1sE5OXSmB4feBJ/8pqtS5GoaRM4XbOKTHljm+4ZgSbvzXa7RMhUvulPRqX2NZay6HhS+MAn9gX08XE188px/tMReyKXm47Z3KnyD8+Mx9Mlre9434cYONDwehUbskPrDClpS4wsE4/KlcJxXCIA= Received: from MW4PR04CA0267.namprd04.prod.outlook.com (2603:10b6:303:88::32) by DS0PR10MB997675.namprd10.prod.outlook.com (2603:10b6:8:311::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.5; Thu, 27 Aug 2026 13:24:03 +0000 Received: from SJ5PEPF000001D3.namprd05.prod.outlook.com (2603:10b6:303:88:cafe::70) by MW4PR04CA0267.outlook.office365.com (2603:10b6:303:88::32) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.360.10 via Frontend Transport; Thu, 27 Aug 2026 13:24:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by SJ5PEPF000001D3.mail.protection.outlook.com (10.167.242.55) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.360.3 via Frontend Transport; Thu, 27 Aug 2026 13:24:02 +0000 Received: from DLEE201.ent.ti.com (157.170.170.76) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 27 Aug 2026 08:23:41 -0500 Received: from DLEE205.ent.ti.com (157.170.170.85) by DLEE201.ent.ti.com (157.170.170.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 27 Aug 2026 08:23:41 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE205.ent.ti.com (157.170.170.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 27 Aug 2026 08:23:41 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 67RDNeR31930988; Thu, 27 Aug 2026 08:23:41 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , Kamlesh Gurudasani , , Subject: [PATCH v2 4/7] crypto: ti - Trim scatterlists to correct length in AES Date: Thu, 27 Aug 2026 18:53:15 +0530 Message-ID: <20260827132318.613876-5-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260827132318.613876-1-t-pratham@ti.com> References: <20260827132318.613876-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001D3:EE_|DS0PR10MB997675:EE_ X-MS-Office365-Filtering-Correlation-Id: 5eabca15-abc7-4769-bc61-08df043e765f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|36860700016|1800799024|82310400026|23010399003|10067099003|56012099006|6133799003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: Kt9e6ftIsqfvriCk171pVKSuXTRSXCxBeJy8kfn2sO0Hd0yrSmDIChiuPgt4mPGbUod5soA7FmWivochMEs+NRbCyWkC3KuHojkm23hGtfSU1UqaOIPk3WcdyGIb4VbYLVmr28jtBHnhHcyOWOoJ+AmvpXcA88gccldxi8YBBpfRCSQ2mRaCBTB5PvylLRJjVNAJlh5ErrWVhtxMweR6Ck3UTnWgEekFiyT4Ak35VAuuRkqgRXbct5v28iLOaftxHIl3JSmC58rYooem5wBMNcSZ3xZMT+CEQzIlQyDHkkgeIZRUoa2/oRMayNIsiXa//nE42MJKeUIxnCA9JZ4KPABigm927htfu3XzKd2Jx+4nz/hPiW6ks9O9WCD2hcdgYwyxcWyTkaxci6sWJhngs/YIzcxn/fuBJTqczXio3v0QD0RNS4PPxsm/8W++fv+I0qjIj7fqMjrNOZYiy8A3yyHdrsS5IozNZbxJBHuB3yJ9rkfssVMN+nYn4weEwE9sDIs9sF6zvZTutI4Ihyg9NspTUR8YY94Aq6K0qr/36KVTMFKzlT3R+BeqixjDq79XAI+Ac4KsWhwSul6mV1S+1sbtMNTBTSjoEMuwv9eICsh3pylfNjxwN8YkeKIP/VJ6jshEEzq7UZVwJdb+kj8LCC+/7wKybpinVqAUIYxLjE9GNdlrSXe9jCTvYXc3c069SmOhCqtF1uNnhjbL0PJs4Q== X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(36860700016)(1800799024)(82310400026)(23010399003)(10067099003)(56012099006)(6133799003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: gppHysRWr4V+LXczYhMYfLnx1mo58uX6M2Ep74Yeo5ToU3c2KmHvrJmfqN4AzgLcysQMKxPfUYDojrOiWeKrFg9eKFqQV2/Jktpu4jd69TjkcHiYDS1+OtYWRrHHCtbeWUQSfZzvPrxiQB9kyMKz25MJjcF8dJsKBWzKXgKslyhOv3uIJUZ5fdgPvD/iMpNdo+dZWcd+utQFa/gwo1Bh3uhSv81PqMdk8/29n8Ks/d/zjR1SprSRndyVWRJo5usvAS7lHhLE8ZBczmkrHrAXSL7zsUxKZhmr1tM/IycLqxzwMtCIcsgYfYcpvlK0W4ZqbphoaQ0f25R65hGD7vGdZPdxxfbsyVg1/7m5gD6ODgvVkmWCssZO7ocMfxcSm7Co9z798mpr2+Da84tMi/+jYHBOOBoVRHyb0Dj1jJpYVYWzmjiPXxldpKx0/WNQQ3yI X-Exchange-RoutingPolicyChecked: PMHizu0Y5EbzDWqtm4wxq5QPWwewX76CCLY9K0Z0zLAphu+GA7TZMkHG1pbBYsIiCHuotfVNCh4RBB1f/+Fe0SW9mVmVBcCq5AcZp/VgZgAqP8Ym67Q4oJRiN/L7CDwOh3N1iMRJqeGrh6AQIvy4AgLwiKnXQuys+kSnQaXhr3m9iFSOsR42YZh/l9krKliJGMNiUzK4RuVvbEef0ZTgtbkuo7QwQMGoL+Ctzqw2YgH6PJvKF/gXodeA4EhOhHwz+FPhSlCwOjNAYA+eSXHcTbpf+glErCRFz3srdfD7ew+dnaHmyK+t93cnhf1PeUS3deXAVMdbgUGuDpb6t9nZRQ== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2026 13:24:02.9117 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5eabca15-abc7-4769-bc61-08df043e765f X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001D3.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB997675 X-Proofpoint-ORIG-GUID: 2rPR7pfeqDL1_5kr4Y001HnAzVbweUJ6 X-Proofpoint-GUID: 2rPR7pfeqDL1_5kr4Y001HnAzVbweUJ6 X-Authority-Analysis: v=2.4 cv=VrMTxe2n c=1 sm=1 tr=0 ts=6a903a78 cx=c_pps a=fY0JyvE1RNjZr0fjhzOn9Q==:117 a=WotqVVQAdb04rnGuttW3Kw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=Sv0fKeRqtYgA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=jwouBfj2j3NM8CExmVVE:22 a=sozttTNsAAAA:8 a=Tpn98H0sjD_mw3BxSIoA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI3MDExMiBTYWx0ZWRfXxPAk/W0q+EPd ew8Z+bnHaTlcxzs3r5vEE6ova4O2stOmKBpcqDEy/VTbQd9zXCAdRfXpKGA3+1LSI0D+pu3fbX8 QypMS/Tz3i2x6Tst9OD+H9jc8E55tUmHrwVY5Z1RW7i7P35QcaxUisBXvmGdnV1y42HWlbRwbqu cJ/sDE+mwwQ3+0Aig5BtXdAtMS2I5Qo2FklroF/flYWKsuFC0EZSUnUpSig1jmRvk33sU9jY8YR HZlRTH4PbaKB7WiXL/hXlTLwc8pQNaxDBuO6oACkMKqxbmlnFso6VFM9+6leFVSn1rmTNBdGI92 QnvS518ei7BeXUwC0HpDUviERc05PB5WVLw1jyzJWfBH2F47A3qtvz8Ikms3MHrU8HyJsw1XomO X1XFTbNQrK8p5h8TSxdoXo9yVMKhN875hj3AoFxWeuSYx9E407Pus7v4vi8HV9ps1W0x50jCDsH /47tIMzK45ROZp9cDpw== X-Proofpoint-Spam-Info: AW1haW4tMjYwODI3MDExMiBTYWx0ZWRfX201fAKzj5Uyd ugnQIZDQk56EcpG9WbIIvijGUIOtHcElQpu6b29bGH+N+8EDtxPuO77/KzuiWn5apSSMauGICh/ ljL+4kStqEW/eYGyyCBgV7fPS7n6Qpc= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-27_05,2026-08-26_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 phishscore=0 spamscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608270112 Content-Type: text/plain; charset="utf-8" AES functions were using src and dst scatterlists directly provided by the request. This is problematic as it is not guaranteed that the input scatterlist is exactly the length reqired. This problem was seen in IPSec use case when the kernel provides the scatterlist which contains space for plaintext/ciphertext and TAG. The problem comes when the scatterlist is mapped and sent via DMA. The K3 UDMA sends/waits for the amount of data equal to the length of scatterlist mapped. So when the last mapped nent contains some extra length, the DMA keeps waiting for the extra data and eventually times out and crashes. Mitigate this by copying the nents to a local scatterlist, copying only exactly cryptlen of data. Note that this does not copy the whole data, but rather only the scatterlist mapping. So it is not as penalising on performance. Fixes: 52f641bc63a4 ("crypto: ti - Add driver for DTHE V2 AES Engine (ECB, = CBC)") Signed-off-by: T Pratham Reviewed-by: Kamlesh Gurudasani --- drivers/crypto/ti/dthev2-aes.c | 146 ++++++++++++++++----------------- 1 file changed, 69 insertions(+), 77 deletions(-) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index 4fdd24ee91637..8998e02b0e86e 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -108,20 +108,6 @@ enum aes_ctrl_mode_masks { #define POLL_TIMEOUT_INTERVAL HZ =20 static int dthe_cipher_init_tfm(struct crypto_skcipher *tfm) -{ - struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); - struct dthe_data *dev_data =3D dthe_get_dev(ctx); - - if (!dev_data) - return -ENODEV; - - ctx->dev_data =3D dev_data; - ctx->keylen =3D 0; - - return 0; -} - -static int dthe_cipher_init_tfm_fallback(struct crypto_skcipher *tfm) { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); struct dthe_data *dev_data =3D dthe_get_dev(ctx); @@ -155,19 +141,24 @@ static int dthe_aes_setkey(struct crypto_skcipher *tf= m, const u8 *key, unsigned { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); =20 - if (keylen !=3D AES_KEYSIZE_128 && keylen !=3D AES_KEYSIZE_192 && keylen = !=3D AES_KEYSIZE_256) - return -EINVAL; - ctx->keylen =3D keylen; memcpy(ctx->key, key, keylen); =20 - return 0; + crypto_sync_skcipher_clear_flags(ctx->skcipher_fb, CRYPTO_TFM_REQ_MASK); + crypto_sync_skcipher_set_flags(ctx->skcipher_fb, + crypto_skcipher_get_flags(tfm) & + CRYPTO_TFM_REQ_MASK); + + return crypto_sync_skcipher_setkey(ctx->skcipher_fb, key, keylen); } =20 static int dthe_aes_ecb_setkey(struct crypto_skcipher *tfm, const u8 *key,= unsigned int keylen) { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); =20 + if (keylen !=3D AES_KEYSIZE_128 && keylen !=3D AES_KEYSIZE_192 && keylen = !=3D AES_KEYSIZE_256) + return -EINVAL; + ctx->aes_mode =3D DTHE_AES_ECB; =20 return dthe_aes_setkey(tfm, key, keylen); @@ -177,6 +168,9 @@ static int dthe_aes_cbc_setkey(struct crypto_skcipher *= tfm, const u8 *key, unsig { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); =20 + if (keylen !=3D AES_KEYSIZE_128 && keylen !=3D AES_KEYSIZE_192 && keylen = !=3D AES_KEYSIZE_256) + return -EINVAL; + ctx->aes_mode =3D DTHE_AES_CBC; =20 return dthe_aes_setkey(tfm, key, keylen); @@ -185,24 +179,19 @@ static int dthe_aes_cbc_setkey(struct crypto_skcipher= *tfm, const u8 *key, unsig static int dthe_aes_ctr_setkey(struct crypto_skcipher *tfm, const u8 *key,= unsigned int keylen) { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); - int ret =3D dthe_aes_setkey(tfm, key, keylen); =20 - if (ret) - return ret; + if (keylen !=3D AES_KEYSIZE_128 && keylen !=3D AES_KEYSIZE_192 && keylen = !=3D AES_KEYSIZE_256) + return -EINVAL; =20 ctx->aes_mode =3D DTHE_AES_CTR; =20 - crypto_sync_skcipher_clear_flags(ctx->skcipher_fb, CRYPTO_TFM_REQ_MASK); - crypto_sync_skcipher_set_flags(ctx->skcipher_fb, - crypto_skcipher_get_flags(tfm) & - CRYPTO_TFM_REQ_MASK); - - return crypto_sync_skcipher_setkey(ctx->skcipher_fb, key, keylen); + return dthe_aes_setkey(tfm, key, keylen); } =20 static int dthe_aes_xts_setkey(struct crypto_skcipher *tfm, const u8 *key,= unsigned int keylen) { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); + int ret; =20 if (keylen !=3D 2 * AES_KEYSIZE_128 && keylen !=3D 2 * AES_KEYSIZE_192 && @@ -210,15 +199,12 @@ static int dthe_aes_xts_setkey(struct crypto_skcipher= *tfm, const u8 *key, unsig return -EINVAL; =20 ctx->aes_mode =3D DTHE_AES_XTS; - ctx->keylen =3D keylen / 2; - memcpy(ctx->key, key, keylen); - - crypto_sync_skcipher_clear_flags(ctx->skcipher_fb, CRYPTO_TFM_REQ_MASK); - crypto_sync_skcipher_set_flags(ctx->skcipher_fb, - crypto_skcipher_get_flags(tfm) & - CRYPTO_TFM_REQ_MASK); + ret =3D dthe_aes_setkey(tfm, key, keylen); + if (ret) + return ret; =20 - return crypto_sync_skcipher_setkey(ctx->skcipher_fb, key, keylen); + ctx->keylen =3D keylen / 2; + return 0; } =20 static void dthe_aes_set_ctrl_key(struct dthe_tfm_ctx *ctx, @@ -341,8 +327,10 @@ static int dthe_aes_run(struct crypto_engine *engine, = void *areq) struct dthe_aes_req_ctx *rctx =3D skcipher_request_ctx(req); =20 unsigned int len =3D req->cryptlen; + unsigned int pad_len =3D 0; struct scatterlist *src =3D req->src; struct scatterlist *dst =3D req->dst; + struct scatterlist *sg; =20 int src_nents =3D sg_nents_for_len(src, len); int dst_nents =3D sg_nents_for_len(dst, len); @@ -385,38 +373,38 @@ static int dthe_aes_run(struct crypto_engine *engine,= void *areq) * We need to handle the padding in the driver. */ if (ctx->aes_mode =3D=3D DTHE_AES_CTR && req->cryptlen % AES_BLOCK_SIZE) { - unsigned int pad_size =3D AES_BLOCK_SIZE - (req->cryptlen % AES_BLOCK_SI= ZE); - u8 *pad_buf =3D rctx->padding; - struct scatterlist *sg; - - len +=3D pad_size; + pad_len =3D AES_BLOCK_SIZE - (req->cryptlen % AES_BLOCK_SIZE); + len +=3D pad_len; src_nents++; dst_nents++; + } =20 - src =3D kmalloc_array(src_nents, sizeof(*src), GFP_ATOMIC); - if (!src) { - ret =3D -ENOMEM; - goto aes_ctr_src_alloc_err; - } - - sg_init_table(src, src_nents); - sg =3D dthe_copy_sg(src, req->src, req->cryptlen); - memzero_explicit(pad_buf, AES_BLOCK_SIZE); - sg_set_buf(sg, pad_buf, pad_size); + src =3D kmalloc_array(src_nents, sizeof(*src), GFP_ATOMIC); + if (!src) { + ret =3D -ENOMEM; + goto aes_src_alloc_err; + } =20 - if (diff_dst) { - dst =3D kmalloc_array(dst_nents, sizeof(*dst), GFP_ATOMIC); - if (!dst) { - ret =3D -ENOMEM; - goto aes_ctr_dst_alloc_err; - } + sg_init_table(src, src_nents); + sg =3D dthe_copy_sg(src, req->src, req->cryptlen); + if (pad_len > 0) { + memzero_explicit(rctx->padding, AES_BLOCK_SIZE); + sg_set_buf(sg, rctx->padding, pad_len); + } =20 - sg_init_table(dst, dst_nents); - sg =3D dthe_copy_sg(dst, req->dst, req->cryptlen); - sg_set_buf(sg, pad_buf, pad_size); - } else { - dst =3D src; + if (diff_dst) { + dst =3D kmalloc_array(dst_nents, sizeof(*dst), GFP_ATOMIC); + if (!dst) { + ret =3D -ENOMEM; + goto aes_dst_alloc_err; } + + sg_init_table(dst, dst_nents); + sg =3D dthe_copy_sg(dst, req->dst, req->cryptlen); + if (pad_len > 0) + sg_set_buf(sg, rctx->padding, pad_len); + } else { + dst =3D src; } =20 tx_dev =3D dmaengine_get_dma_device(dev_data->dma_aes_tx); @@ -503,19 +491,19 @@ static int dthe_aes_run(struct crypto_engine *engine,= void *areq) dma_unmap_sg(tx_dev, src, src_nents, src_dir); =20 aes_map_src_err: - if (ctx->aes_mode =3D=3D DTHE_AES_CTR && req->cryptlen % AES_BLOCK_SIZE) { + if (ctx->aes_mode =3D=3D DTHE_AES_CTR && req->cryptlen % AES_BLOCK_SIZE) memzero_explicit(rctx->padding, AES_BLOCK_SIZE); - if (diff_dst) - kfree(dst); -aes_ctr_dst_alloc_err: - kfree(src); -aes_ctr_src_alloc_err: - /* - * Fallback to software if ENOMEM - */ - if (ret =3D=3D -ENOMEM) - ret =3D dthe_aes_do_fallback(req); - } + if (diff_dst) + kfree(dst); + +aes_dst_alloc_err: + kfree(src); +aes_src_alloc_err: + /* + * Fallback to software if ENOMEM + */ + if (ret =3D=3D -ENOMEM) + ret =3D dthe_aes_do_fallback(req); =20 local_bh_disable(); crypto_finalize_skcipher_request(dev_data->engine, req, ret); @@ -1214,6 +1202,7 @@ static int dthe_aead_decrypt(struct aead_request *req) static struct skcipher_engine_alg cipher_algs[] =3D { { .base.init =3D dthe_cipher_init_tfm, + .base.exit =3D dthe_cipher_exit_tfm, .base.setkey =3D dthe_aes_ecb_setkey, .base.encrypt =3D dthe_aes_encrypt, .base.decrypt =3D dthe_aes_decrypt, @@ -1225,7 +1214,8 @@ static struct skcipher_engine_alg cipher_algs[] =3D { .cra_priority =3D 299, .cra_flags =3D CRYPTO_ALG_TYPE_SKCIPHER | CRYPTO_ALG_ASYNC | - CRYPTO_ALG_KERN_DRIVER_ONLY, + CRYPTO_ALG_KERN_DRIVER_ONLY | + CRYPTO_ALG_NEED_FALLBACK, .cra_alignmask =3D AES_BLOCK_SIZE - 1, .cra_blocksize =3D AES_BLOCK_SIZE, .cra_ctxsize =3D sizeof(struct dthe_tfm_ctx), @@ -1236,6 +1226,7 @@ static struct skcipher_engine_alg cipher_algs[] =3D { }, /* ECB AES */ { .base.init =3D dthe_cipher_init_tfm, + .base.exit =3D dthe_cipher_exit_tfm, .base.setkey =3D dthe_aes_cbc_setkey, .base.encrypt =3D dthe_aes_encrypt, .base.decrypt =3D dthe_aes_decrypt, @@ -1248,7 +1239,8 @@ static struct skcipher_engine_alg cipher_algs[] =3D { .cra_priority =3D 299, .cra_flags =3D CRYPTO_ALG_TYPE_SKCIPHER | CRYPTO_ALG_ASYNC | - CRYPTO_ALG_KERN_DRIVER_ONLY, + CRYPTO_ALG_KERN_DRIVER_ONLY | + CRYPTO_ALG_NEED_FALLBACK, .cra_alignmask =3D AES_BLOCK_SIZE - 1, .cra_blocksize =3D AES_BLOCK_SIZE, .cra_ctxsize =3D sizeof(struct dthe_tfm_ctx), @@ -1258,7 +1250,7 @@ static struct skcipher_engine_alg cipher_algs[] =3D { .op.do_one_request =3D dthe_aes_run, }, /* CBC AES */ { - .base.init =3D dthe_cipher_init_tfm_fallback, + .base.init =3D dthe_cipher_init_tfm, .base.exit =3D dthe_cipher_exit_tfm, .base.setkey =3D dthe_aes_ctr_setkey, .base.encrypt =3D dthe_aes_encrypt, @@ -1283,7 +1275,7 @@ static struct skcipher_engine_alg cipher_algs[] =3D { .op.do_one_request =3D dthe_aes_run, }, /* CTR AES */ { - .base.init =3D dthe_cipher_init_tfm_fallback, + .base.init =3D dthe_cipher_init_tfm, .base.exit =3D dthe_cipher_exit_tfm, .base.setkey =3D dthe_aes_xts_setkey, .base.encrypt =3D dthe_aes_encrypt, --=20 2.34.1 From nobody Sun Sep 27 00:36:53 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9413834F49F; Thu, 27 Aug 2026 13:24:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787837067; cv=fail; b=c60DnHTrykIYs/lliDKXf12vNLlCcXO0DpeIBMu3TUInk9vvSFs2afVkIH0BRfBkxDJOXsFXWd6tIwA8kvCXMzOm8UwwNRcuMwzn6Ph9SgNPBw9B+QR7o7g3s2/9D0B/SdS0DIihtaZnsb01klthnwzeqXHxgMAi1Ww5iCICa4c= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787837067; c=relaxed/simple; bh=NduprVZn6wgOkyKQIQV0q07lxKi+rgX0yR7H7LNM5Gw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tq1Px+Od8dNXPge8xmXOE9PvqgseBDhOKXJ8vbNQMczLVfmp2mPDeOgrVhIdl8Trt0CIeMH+XEpwNFXFuwrVbgP42+bmK9D+SMjBkT57ygFFkUOksMJVtlGxiNhQEhFbGRkvg4/BTffs1cIahhQxGbIpPNtGD/w64meeOOMAc28= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=SF04Ds7Q; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=TxzC0kvy; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="SF04Ds7Q"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="TxzC0kvy" Received: from pps.filterd (m0380145.ppops.net [127.0.0.1]) by m0380145.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 67RCA9Qv2915293; Thu, 27 Aug 2026 08:24:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=BZfGaRICbUgpq6No8cR0RHUKYNyu2R7EIt/5uF3Hr PA=; b=SF04Ds7Qdlu+hP8V9SLibHvet9gLkRfweZtJ3x/3GPlQqUYLRugxutPu2 iEzs49oIc0zYJmpsxsVhHD8AhW9jBEg8tnSQYJWoLWkfGYVjGkqC/vbSeG8j7PgX UOy47+xa58nJdxYr100buB0UFqonV6d6zFA39uEnd6Dhe0whIoPzv5fzaxK2RlBG uKzryiMSyEzk8sA0Twv2AX6sD27eJl2/vHR8K+OlVToIjb13wgge7/6SRQGxrx0O SWZCeH6pQLKUyroBge5f1aa56M4Giu3LywJRZnjtcHeWJsWj2InVKz6KjgzLa3M1 iIiaLz2pfxL/9pz0Z2ue4vgeiuq6A== Received: from dm1pr04cu001.outbound.protection.outlook.com (mail-centralusazon11010025.outbound.protection.outlook.com [52.101.61.25]) by m0380145.ppops.net (PPS) with ESMTPS id 4gahg39dbk-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 27 Aug 2026 08:24:11 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ypP19HW7KV2FSRFDc7Yhy7ErKr6sk2rguxb61OwpkaPvtrUbHXHiCNoomQB+YqryxkI28EVZZg0Lu+M5+1WTWBUJrpMBlmAmpPj9/Nql1y4NEwbyCUJktlmIvcCU7n7kQoHNGr4Dg7yYL6jE4DijWXyH4qGxiLonEVUAahIE6Mflpawu96PCbXIcSFN1akjtFmhKA1EpBLO86buXGcckyHk3U6N7JWOomexPCL634LdAUACwpUyfE24BlAIwBQKbNJ9Y/AYiy5Oo0N3Pj+qEjBz6CV9Rgb8uUGcfBc4HvFusDlhhw92zXgi+gkfMNS3htRagzKhGlKaR+lj7FVsFWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BZfGaRICbUgpq6No8cR0RHUKYNyu2R7EIt/5uF3HrPA=; b=mjKyMl/80ff4mNa1vOkYnZx+W1GQFarm9mWEalEDj/5u7Pat0aEDqt1iSbadgalileWR6HhWLQtHmeGBOxqavWu7MU/dw+CDbDUdUcP4rpbbCj2zEJr3S1t0kh1nykbTpxX3ZLgpgqahrwLfDQUPBDexG+wbNMr2XWgR/HuNgQUhGQXet5U+CBbnCi3G8Qp6JNNWuTuNJV4jNLB8JPDvq6/3VglReGvnx05pc78Ems5xZ3hmio+lEfBrkyDrLq41hjW6vsXZ24odqTd1PCnRSMHvrbYTPuIlbfHeDyDcunl0uohp/yqMhzNHGNnVNcp1DcRxLDi6Kd6FTDI0gZRLpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BZfGaRICbUgpq6No8cR0RHUKYNyu2R7EIt/5uF3HrPA=; b=TxzC0kvylKdmwIat1Gpw5bdXQFvU6NIESJA2tbAn1Xb88wXk+rLk0lzj1f2KwQswNXrZLBehwq8EgUdSQP4To/GiQREk8/NnAvLZUmCsWr81R1T/FrgJFN4TplH/AahjawRY7hMUnHV5R64flUeKFm2QFlaiDTXCERr4DvIfkgs= Received: from PH7P220CA0097.NAMP220.PROD.OUTLOOK.COM (2603:10b6:510:32d::15) by SJ0PR10MB4750.namprd10.prod.outlook.com (2603:10b6:a03:2d5::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.8; Thu, 27 Aug 2026 13:24:07 +0000 Received: from CY4PEPF0000EDD3.namprd03.prod.outlook.com (2603:10b6:510:32d:cafe::d) by PH7P220CA0097.outlook.office365.com (2603:10b6:510:32d::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.360.10 via Frontend Transport; Thu, 27 Aug 2026 13:24:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by CY4PEPF0000EDD3.mail.protection.outlook.com (10.167.241.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.360.3 via Frontend Transport; Thu, 27 Aug 2026 13:24:06 +0000 Received: from DLEE215.ent.ti.com (157.170.170.118) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 27 Aug 2026 08:23:44 -0500 Received: from DLEE209.ent.ti.com (157.170.170.98) by DLEE215.ent.ti.com (157.170.170.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 27 Aug 2026 08:23:44 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE209.ent.ti.com (157.170.170.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 27 Aug 2026 08:23:44 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 67RDNhIs894221; Thu, 27 Aug 2026 08:23:43 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v2 5/7] crypto: ti - Fix use-after-free of dev_data on DTHEv2 driver removal Date: Thu, 27 Aug 2026 18:53:16 +0530 Message-ID: <20260827132318.613876-6-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260827132318.613876-1-t-pratham@ti.com> References: <20260827132318.613876-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EDD3:EE_|SJ0PR10MB4750:EE_ X-MS-Office365-Filtering-Correlation-Id: 8225ff8d-f165-41b3-8b5d-08df043e7879 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|30052699003|376014|23010399003|82310400026|1800799024|10067099003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: 5ewebvn8Iy1Sk3par5rb043T6a+jV/UsMQXClpg4vBoLJFuciyxMbkSqaICb4Z716or46HFVMPaNIFwf4XO7wLhEGMB2kO3/CBC154trAZ5B6yOMj2SrgAhoORGrW+/BN1OhRcH0msdi4H7p5s6Rq5OIii0okIMXxLrQRcWXkoW12QiBG4qtRQxLIITNZpcI+tT8CQd3v0LYy2/LqK/diVLg0d9t8YQ33HGiQFJVmomVWB3LuCWNNVsy7FfldNYGAvtukcq0VsWIEIq0OS5HRE5svHBus9osVy48AGn85FPQO5yCXt0o0idxppPbrZtIwkl49ex68VllLE2ZsWRXGWfmM2bTRlSUmION6fiideO/uig9nYZGZ6x4DVIrG+N3MufCcVWNt4vYd7GpJ0EJZ1KH4zcWVN7wMpe4zNElvIVTlqoo9sQZ1pty2uVb2UbMM9ZYgE9BwOv7I+skJ4CiO6U7mKVMdwkjLV8sSUD4OhJDvAMbEPEbtrl3Dyn7gMSZiFjX59VFrpzwBmOSuBtubbDXOYc+bs3AoAqb56rzp3UJ6XgxQ/EKL9F3BowZiKZ1u3jdy66ruO9TOCG6m3RwmcenUZrR53CmTo/+U4H1DCHZy1qjAD0ZC5byYqtb2y0OuIvck0XHsGUym45dh3wCVCgcLLGWxYqxdQsWc9FJziWZaPGyB7+bshh81w3Mt9tuQYXcBkh6AHUlREs0HPGjiw== X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(30052699003)(376014)(23010399003)(82310400026)(1800799024)(10067099003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: sG2fHfY8E2c8lgONYuk5SHT4eJ314AnpetVSkYNxfupzNhHEZFGZeFbR4MYMpZfjc5y+HZNlD+lCsEg112+UnJYw8Ee/lnlz64wxfLIS6wg3plir6u/dvAgvY6Kab+T8T5+Y0o/RuCrsYztw9/Stw/A5N0S9ERd1G1QTVFEYsW1pJGweJPKVAjHIkHkFqMn3Wv1560sOdjy/nwDqHBW+P/M7va+V9b3dzeL1jq42HPW/tp5NLnceCliLbMo7OqVuNqH5FnaOJ5yzTdLaZtVmeJbM+M38lqdXfGhQROyj/eCt8wr8p+Ru9rPdJIBMn3rOzKPBNvDDGlHoZptPEv6JLLVYHH1fpGdVaLUCwGXP+v7sxptK5fLfPtlEmCmqiFswjkWZss9GGNc5vSrxcHVNVHbGKDEBOiJEMZDmpoFh3NOFo5NDYKXNWP5RhF/NWpY3 X-Exchange-RoutingPolicyChecked: ormmLlK/XiPBmwDCzBg93jdnfhelqNLroTTzRc0snmv+Zs1OucfUGKPO2ZC6vmBO67GzudWOaJSx6aPIy2Er8jXF31qaiEoptn8z9mKH4de5CXEK3r/1u9lCXs/qCzonBnaMA5vaGX7pD2c9dfaEohuxhNmbqjfOXZINnL0WR/cE7Kz/Ou7rDTF9uGWY61WKPWdmWnRzh5jQOPsf/iYJZhcr8bpg4kNBhpsSaiW4oA4goJ/wMRZpkrn+LhldSIqh0U7m2nvMAQkLxtQFPuTtXMZC33rMGiTGydgsoPgsDHvzHIXbCherMmVWJjXDf/f7LqEXFN4X6Fm+RjWWYh9Fsg== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2026 13:24:06.5065 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8225ff8d-f165-41b3-8b5d-08df043e7879 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EDD3.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4750 X-Proofpoint-GUID: UAzGGrFzZsU6ZDaJCwjFxWt0xF984Olk X-Authority-Analysis: v=2.4 cv=M4597Sws c=1 sm=1 tr=0 ts=6a903a7b cx=c_pps a=vcXwJhCbSog8BousImPcCw==:117 a=f+v6EHfkeJbVwR46tk4DMg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=Sv0fKeRqtYgA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=gO1vWkAQAl3rybz1DQOp:22 a=sozttTNsAAAA:8 a=2APMjrMfoq02II8ecpEA:9 X-Proofpoint-ORIG-GUID: UAzGGrFzZsU6ZDaJCwjFxWt0xF984Olk X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI3MDExMiBTYWx0ZWRfX7Nm2xRmNAHsG ssgchNbLuAhYqv/mnk226DQolGD5qRWJy4GOBYSBUttGeicl0GvRdx1MQAxPgIsssmQyiNNFYm/ vZ66gmR0m1sjdwFVaXzu2gnUoacz18TlDXVpl7x72jQvOTDh90/QRrhkORfwHL91kfmGVRKntVY ujr9poZaRqrP7t6EAqpa8DU6TF1Zma/kotaAr71Q9HmJZ3lfAaI4U9P/rGOD9NDiT2+IWw28lVo Nxo4Y+7Oh7hXVRg+627qG73++HJHmpF6wuoqhxbIz2hI7UWfHecF7rBsyFrzg3lE+LB8wAAWE9+ cmpWTGaF2ZgY4z8UALDt1xLHSFGSHzJX6ZJqkzyO1TKSV0LWaBETNud+YLDbWPBNAo+g+U4REP2 TWQsbcKkks3pcYnzn2p9h0cu94KKYetwNnmB1lsZCYm3X2FTeq4FfjYFxgkY9e0HYc/ehpsof8o W3+tqbwQZhL8QMEGFow== X-Proofpoint-Spam-Info: AW1haW4tMjYwODI3MDExMiBTYWx0ZWRfX0IxbyKfygrg4 VLLLTIrYuJGOHVXAWJSWXvqgEvO7BpQf/oXHhN/G20E48QPdMeqJSum1sPEF+88q33m/wilQKiP FLGCOcMovcz71tIobSks43A5BtqEeME= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-27_05,2026-08-26_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 phishscore=0 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608270112 Content-Type: text/plain; charset="utf-8" Each *_init_tfm() caches a pointer to the per-instance struct dthe_data in its transform context (ctx->dev_data), but never takes a reference on it. If there are tfms in progress when dthe_remove() is called, the devm allocated dev_data gets freed. Then ctx->dev_data will point to a memory that has been freed. Add a refcnt to struct dthe_data, incrementing it atomically in *_init_tfm() and decrementing atomically in *_exit_tfm(). dthe_remove() now polls this count, with a bounded timeout, so tfms allocated before removal have a chance to be freed first. If the timeout expires, it warns and proceeds anyway rather than blocking removal indefinitely. Fixes: 52f641bc63a46 ("crypto: ti - Add driver for DTHE V2 AES Engine (ECB,= CBC)") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 4 ++++ drivers/crypto/ti/dthev2-common.c | 22 +++++++++++++++++++++- drivers/crypto/ti/dthev2-common.h | 5 +++++ 3 files changed, 30 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index 8998e02b0e86e..8ef54dacf63f2 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -124,6 +124,7 @@ static int dthe_cipher_init_tfm(struct crypto_skcipher = *tfm) if (IS_ERR(ctx->skcipher_fb)) { dev_err(dev_data->dev, "fallback driver %s couldn't be loaded\n", alg_name); + dthe_put_dev(ctx); return PTR_ERR(ctx->skcipher_fb); } =20 @@ -135,6 +136,7 @@ static void dthe_cipher_exit_tfm(struct crypto_skcipher= *tfm) struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); =20 crypto_free_sync_skcipher(ctx->skcipher_fb); + dthe_put_dev(ctx); } =20 static int dthe_aes_setkey(struct crypto_skcipher *tfm, const u8 *key, uns= igned int keylen) @@ -577,6 +579,7 @@ static int dthe_aead_init_tfm(struct crypto_aead *tfm) if (IS_ERR(ctx->aead_fb)) { dev_err(dev_data->dev, "fallback driver %s couldn't be loaded\n", alg_name); + dthe_put_dev(ctx); return PTR_ERR(ctx->aead_fb); } =20 @@ -588,6 +591,7 @@ static void dthe_aead_exit_tfm(struct crypto_aead *tfm) struct dthe_tfm_ctx *ctx =3D crypto_aead_ctx(tfm); =20 crypto_free_sync_aead(ctx->aead_fb); + dthe_put_dev(ctx); } =20 /** diff --git a/drivers/crypto/ti/dthev2-common.c b/drivers/crypto/ti/dthev2-c= ommon.c index 8628187a32e18..c5bb7fe7f9876 100644 --- a/drivers/crypto/ti/dthev2-common.c +++ b/drivers/crypto/ti/dthev2-common.c @@ -27,6 +27,10 @@ =20 #define DRIVER_NAME "dthev2" =20 +/* Interval and timeout for polling dthe_data::refcnt on removal */ +#define DTHE_REFCNT_POLL_INTERVAL_US 20000 +#define DTHE_REFCNT_POLL_TIMEOUT_US 1000000 + static struct dthe_list dthe_dev_list =3D { .dev_list =3D LIST_HEAD_INIT(dthe_dev_list.dev_list), .lock =3D __SPIN_LOCK_UNLOCKED(dthe_dev_list.lock), @@ -41,13 +45,21 @@ struct dthe_data *dthe_get_dev(struct dthe_tfm_ctx *ctx) =20 spin_lock(&dthe_dev_list.lock); dev_data =3D list_first_entry_or_null(&dthe_dev_list.dev_list, struct dth= e_data, list); - if (dev_data) + if (dev_data) { list_move_tail(&dev_data->list, &dthe_dev_list.dev_list); + atomic_inc(&dev_data->refcnt); + } spin_unlock(&dthe_dev_list.lock); =20 return dev_data; } =20 +void dthe_put_dev(struct dthe_tfm_ctx *ctx) +{ + atomic_dec(&ctx->dev_data->refcnt); + ctx->dev_data =3D NULL; +} + struct scatterlist *dthe_copy_sg(struct scatterlist *dst, struct scatterlist *src, unsigned int buflen) @@ -200,6 +212,7 @@ static int dthe_probe(struct platform_device *pdev) static void dthe_remove(struct platform_device *pdev) { struct dthe_data *dev_data =3D platform_get_drvdata(pdev); + int refcnt, ret; =20 spin_lock(&dthe_dev_list.lock); list_del(&dev_data->list); @@ -207,6 +220,13 @@ static void dthe_remove(struct platform_device *pdev) =20 dthe_unregister_algs(); =20 + ret =3D readx_poll_timeout(atomic_read, &dev_data->refcnt, refcnt, !refcn= t, + DTHE_REFCNT_POLL_INTERVAL_US, DTHE_REFCNT_POLL_TIMEOUT_US); + if (ret) + dev_warn(dev_data->dev, + "removing with %d transform context(s) still active\n", + refcnt); + crypto_engine_exit(dev_data->engine); =20 dma_release_channel(dev_data->dma_aes_rx); diff --git a/drivers/crypto/ti/dthev2-common.h b/drivers/crypto/ti/dthev2-c= ommon.h index 75d9a097650da..c4adeb34b14f3 100644 --- a/drivers/crypto/ti/dthev2-common.h +++ b/drivers/crypto/ti/dthev2-common.h @@ -18,6 +18,7 @@ #include #include =20 +#include #include #include #include @@ -53,6 +54,7 @@ enum dthe_aes_mode { * @dma_aes_rx: AES Rx DMA Channel * @dma_aes_tx: AES Tx DMA Channel * @dma_sha_tx: SHA Tx DMA Channel + * @refcnt: Count of transform contexts currently holding a reference to t= his instance */ struct dthe_data { struct device *dev; @@ -64,6 +66,8 @@ struct dthe_data { struct dma_chan *dma_aes_tx; =20 struct dma_chan *dma_sha_tx; + + atomic_t refcnt; }; =20 /** @@ -113,6 +117,7 @@ struct dthe_aes_req_ctx { /* Struct definitions end */ =20 struct dthe_data *dthe_get_dev(struct dthe_tfm_ctx *ctx); +void dthe_put_dev(struct dthe_tfm_ctx *ctx); =20 /** * dthe_copy_sg - Copy sg entries from src to dst --=20 2.34.1 From nobody Sun Sep 27 00:36:53 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7D2247884D; Thu, 27 Aug 2026 13:25:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787837148; cv=fail; b=A/vAOB3rcCfPb/VGjokwlXYPXp3xCro1WEiCPSWxEtyS5wGo8KRU6cCCmy5E6p5DVupFX0WpEak6OO8JpFQgaIdMZeY5XrO6A7QBTAtg/rO+2s56rxYS24pnSoC4rPTniryrPIVkfd+m8ddYEQzfe+qbVOPxsF9oZpohjaBw/Sc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787837148; c=relaxed/simple; bh=jTYoPoOhly8dkTl47Kzm10+YJ0U9qfjzd02BRFKGedQ=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NJ0R4eJFWTcYTx0LZjSIn9Yg3mixBdMhHobqjSn4eG6y6LlSEMFl7x1lauxVF3khZXL2+G2nbVOzfCv/20qzSJ/Y3g0ODqrpi8x/S2bwNeaARMRi8amvXnivrX0unBUptE4vI9A2JFnNcXtOOSObGHkJEfAv7loFMufY1FojY7A= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=iUTarMVe; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=qppSJYRR; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="iUTarMVe"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="qppSJYRR" Received: from pps.filterd (m0374955.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67RCAbno3085580; Thu, 27 Aug 2026 08:24:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=YUETm1FHVRgLRqlPL+dlFq444iqcLJEPmcytpsRYU lg=; b=iUTarMVe5IpUwpffDm7GyaCUi6YV19xeMVSDa8RAkoh5dA3wWq13xoqNp vM9D+284ClxGbVzhkAGwCp6qZTFeNg2+/d8GmM3ZHeOzNWWQilGHwHIx/G1pTimD UaJpBd5NTA+cl9/j2FdNMYUih6tpJU6li0lGSwWyvdWV7DUsu7yX7/3CDUTo/YRI 66ghZYHsa1uk8ClsHSQpud9MWXTK87gJo6tk/Sa/J2lnGdxuBU+eA1QnLkrtZwuR EUFR2hPLShkCvDKrh3IcUTXSCPw/Gha5/3F0Hs0lQh8vYar6AY0XGqbt9AjQaARA SR+cAXI1LsZ52xweyljHmUOvnuxwg== Received: from sj2pr03cu001.outbound.protection.outlook.com (mail-westusazon11012010.outbound.protection.outlook.com [52.101.43.10]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gajhhs3ww-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 27 Aug 2026 08:24:35 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Xa2xb9+k/yTC2n7BSKO6M7K712wnUsrudeYQHHS/lMe8JSWDLNrC/femMTSS2zwuU7h5GglNcp+NKrLIONzJ9cC70Jv1Cvfq9dabjkg4/BG5a9t7LH+NLsNTREPCA8Gm5mWsUUE1EIj5z1vtl1hi65Qqn4jydUwtq88+Xeyn/yYw+YG2DEWJ6uzxAZixgOVDyHO4YyxJTpvufIzEFegaDJNRuhA9AOHCkh4x2VvNM7h0VxgEcpcLRFSFFJeclQIptAG2yvgroB2a73tN/WAhQ3F/tOW7BLUwh8vDVvddQFKhVCZAp4zQUf2lNDoBeYOmQCl3AQFJqkDKzl6uB6rS9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YUETm1FHVRgLRqlPL+dlFq444iqcLJEPmcytpsRYUlg=; b=Y2MVNhE+NguOwE6zXoHQ1tt1TusyPZNxWLUq0xKjrj54c8LCQNTfS7fAe7tg2fBx/JfEQOg2QKBcymz3oXXLsmHIj64z/CXlaWkTxe6LrgtKxWwswnkgvQsKSAuVC8VW4G3b3InmylRs4VfFUr9qCM/WBYmdhpLlCOhLV9csx6K0S1yElsCPQJd+UYkQX6/3a5TfNDpe17+Z6655Gh5mxVwNOfuwcylT8T8lusygvE8vX5tCEcLwzlrN09OBp+wTO4R3a6P6xk+dv54BOxiDKdM20y0wqb8YQA0DZOd6kQT51k4T/i5AQiX0C1I6K9iTj9RnhWADFzp0C6heKjydqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.195) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YUETm1FHVRgLRqlPL+dlFq444iqcLJEPmcytpsRYUlg=; b=qppSJYRR8kSAHVFHdIcw2L17NM2kxlnygoT9DN81MHpddFb8IR5y2ohUARZf3CsZDc1nYi9DrLJayv7jOqf0at8HK29in2+q7xlx6FzRctqt2zp4bymcWV/6mzUR+iqx3Ct7/un8led/8/UeBwzzpaOrLiJAXTPapZyUBm+nihs= Received: from CH0PR03CA0200.namprd03.prod.outlook.com (2603:10b6:610:e4::25) by CH9PR10MB997859.namprd10.prod.outlook.com (2603:10b6:610:341::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.360.7; Thu, 27 Aug 2026 13:24:32 +0000 Received: from CH1PEPF0000AD82.namprd04.prod.outlook.com (2603:10b6:610:e4:cafe::47) by CH0PR03CA0200.outlook.office365.com (2603:10b6:610:e4::25) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.360.10 via Frontend Transport; Thu, 27 Aug 2026 13:24:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C Received: from flwvzet201.ext.ti.com (198.47.21.195) by CH1PEPF0000AD82.mail.protection.outlook.com (10.167.244.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.360.3 via Frontend Transport; Thu, 27 Aug 2026 13:24:31 +0000 Received: from DFLE203.ent.ti.com (10.64.6.61) by flwvzet201.ext.ti.com (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 27 Aug 2026 08:23:47 -0500 Received: from DFLE211.ent.ti.com (10.64.6.69) by DFLE203.ent.ti.com (10.64.6.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 27 Aug 2026 08:23:47 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE211.ent.ti.com (10.64.6.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 27 Aug 2026 08:23:47 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 67RDNjMs894272; Thu, 27 Aug 2026 08:23:46 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v2 6/7] crypto: ti - Validate sg_nents_for_len() return value in DTHEv2 AES Date: Thu, 27 Aug 2026 18:53:17 +0530 Message-ID: <20260827132318.613876-7-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260827132318.613876-1-t-pratham@ti.com> References: <20260827132318.613876-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000AD82:EE_|CH9PR10MB997859:EE_ X-MS-Office365-Filtering-Correlation-Id: 0b267fe9-b807-4db1-6f6e-08df043e8755 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|82310400026|1800799024|376014|36860700016|56012099006|10067099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: bNoC6zBxWOZD1b8eYHfi1a8YXWvLROtfZmKZ+WXYTHU8X0nTkJ04TqL+pqfD599nURefsEGTMtfRI+YMxu0IPkcbR8KZOJ+bPQ5ENSCSTSY9+FxyfaKCD+UbtX7GNRCSuY0UeltsJm4uwARY9oybbDjG2Ro15rUQPF0FhsXit+7gasyjL+vvlrRMsvaN/r6ymH6tHFUKJnD49spinwyaMvuSHO5w5o0arfkOT/mZ30QkV17sWtuDp1UdYGcmJH1hIIqNFTZHWaPVCDSTFXJkZt1L1JR95WcjKFirLxkizviG3qHkyv3UQ1tO7nbGG7Z1tYgNpgbKlvFIWv/1jF/MetiPx6heZmx5X/8gXTTQGmRmUGTDf8/cSZj6y6OMYP3+wn9twFSKtlzzbPoQ2zj2aDmzcttiZteHMXvMsJP7OhIB+P2spMMmMemjNuXEXBG3akygjal8h4CJlMYtTXFnc3R7XGYfuKLBxCCl09WlrkPrDomlT/3OXsOqGMSe84fIk1q1zYWyyn+t3RhA8EEzUDb2Vx8kW6YhmVS+JEc31JdAk0AN6jECwBHF/BraHA0jApu+txi5GU/GslrnQg3LwRP+GaWGDJlgPmfHlzKiclbsH33N4qKljfVPFAi3TJvgK5sRTMUWhAVTXwW3rqUvp4CJUmmX2WpBKgGN+Y3dWMpERmVBqAwgq5qKut9qM4GT1aHtYXuXz0gIOCvZZUBlxw== X-Forefront-Antispam-Report: CIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(23010399003)(82310400026)(1800799024)(376014)(36860700016)(56012099006)(10067099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 2LsfrVW5yaEMYl3j7KCcDXlaXwYgX+tDiCHHrGTNsfDFvvltYECzhM2Sc7/hU6Fe9LGtvQ1uJyuIOV/qrSbVfR9XQAPkoHQDp9sjEDZkb0aTid3MgwKo4Y+1asc/D8JhgyxpyU5K6Ch9rpAR99SpnqKCoby1OhVAkgRFKYb88jTFUW9RHQyOUybUAXC+L/pv8WBCw8AeKaTtv2lkpnJ4zgKcaegpDkWX2fCv09uvjePPd6e89MYryfxtuzvSlKB64zDdV3cfEjCJ7L/ybA4utT20WCXt1aV2rkUjxCL2kz12TBq3wFpwDsc/g+bVWI+lrZ90/WKJdpzHbf4OKuuMEMSa3UnHB6QJeo7aMF/V5jg68aIpmuB+FsvTAqkQsHoSXtPPMALR/tlJi3mXkjvEPPC8vrVLveGdxrdQ/sZeOARcVml0HiIywOYVcfWWrk4S X-Exchange-RoutingPolicyChecked: zCK2dv1bl8i6qdv5QnPbFqGEhYshRnztWGikl+3gH4OtqsdnSiRnJycrBR9G9wk3aSS3J1lr/TFfC4dbEe6qVhMQvZgB2LmON/Cye4zBdgbneEZzdH+nUb53aPGYRQlYEPJnw1ltvr46JiJudxXuJ2Sp5NAdSavWbpbOC6t7nG7rnHhWbqe4srDLTnu/FQLzxxF0vmNIOasOjTI94l68Rffo7MauNYrkbPKReNcHZxPDOSWjqiyZ3CfrtQpk93Pq5YJm39ceHLus4fFDDuwl+Rxuw9XuPB2IxSqE2fq7HZ+66/7RGBi9aWcJoqVc+bD1Xt01yqLObszTRgG5g4we4Q== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2026 13:24:31.3943 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0b267fe9-b807-4db1-6f6e-08df043e8755 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000AD82.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH9PR10MB997859 X-Authority-Analysis: v=2.4 cv=Fu01OWrq c=1 sm=1 tr=0 ts=6a903a93 cx=c_pps a=a15oepxCFtbapkdjUscCyA==:117 a=tJyPKKxUohctrY4NYmUjkA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=Sv0fKeRqtYgA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=fPAWb5peG099m5CrUpKH:22 a=sozttTNsAAAA:8 a=wrH6CD59uMa574BPOq8A:9 X-Proofpoint-ORIG-GUID: h4USEeP7be2RE5kpyq7VomdgsHfn0y-c X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI3MDExMiBTYWx0ZWRfX/eCxLH05XCUR Sx/F3iPE3qcz0cFMstl+CWzrGeXysA330ByL0YKlcLCosJem/xmDk3fyRAih93TDJHC690z7Rx5 thzUZgJ7Sj54E9VXGUf/Ky+mqlsxtt+qNkitUwZ4VIDe4QxUny5hyYra6e35wEG0S1lWPJSdKN4 gJnQS84j+Yps1jJNhxx+K7/ke4Rtfkh5k+k/I1cPHCHfwZw4dwGcKC0ZMdgeSw1vBEFP7PwBIeX K8/YGPX9JIUMojxXjbS5qjmFjJbojA1wNyzYbk2ldFCGSKW4pPEdO0qnqs9ZWEbaBa0O40RTquw dJIl1dkdz0bCFP5ZYpRu32OmpxRxYYavEKEHrgI3Q1de49cuun4MA0jysfX+lQKgqySlp8owfNN luiBcDDNpYHK/6pj7fy2Awo++EDbrEjt8gqHj24yOacYwQkP9OP/89mcb2+GVZJChCxWV5JY7tp Tjt9QGk2QAhjTtJmz2Q== X-Proofpoint-GUID: h4USEeP7be2RE5kpyq7VomdgsHfn0y-c X-Proofpoint-Spam-Info: AW1haW4tMjYwODI3MDExMiBTYWx0ZWRfX+DL+iy4LlaZF PooOY4BGVWFPp9RDYZE0bX6yMc3VXHGKU4XKAOLUEoCxQIOMtsXMLxk6fNoJdu+JdEBpaA3QAQX gkhsQpjdPUOjKjd+w1ZpZ33RxqhQ868= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-27_05,2026-08-26_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 adultscore=0 spamscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608270112 Content-Type: text/plain; charset="utf-8" sg_nents_for_len() returns -EINVAL if the supplied scatterlist is shorter than the requested length. Add explicit checks after each sg_nents_for_len() call in DTHEv2 AES driver. Fixes: 52f641bc63a46 ("crypto: ti - Add driver for DTHE V2 AES Engine (ECB,= CBC)") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index 8ef54dacf63f2..99fce19de81d3 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -353,6 +353,11 @@ static int dthe_aes_run(struct crypto_engine *engine, = void *areq) u32 aes_irqenable_val =3D readl_relaxed(aes_base_reg + DTHE_P_AES_IRQENAB= LE); u32 aes_sysconfig_val =3D readl_relaxed(aes_base_reg + DTHE_P_AES_SYSCONF= IG); =20 + if (src_nents < 0 || dst_nents < 0) { + ret =3D -EINVAL; + goto aes_inval_nent_err; + } + aes_sysconfig_val |=3D DTHE_AES_SYSCONFIG_DMA_DATA_IN_OUT_EN; writel_relaxed(aes_sysconfig_val, aes_base_reg + DTHE_P_AES_SYSCONFIG); =20 @@ -507,6 +512,7 @@ static int dthe_aes_run(struct crypto_engine *engine, v= oid *areq) if (ret =3D=3D -ENOMEM) ret =3D dthe_aes_do_fallback(req); =20 +aes_inval_nent_err: local_bh_disable(); crypto_finalize_skcipher_request(dev_data->engine, req, ret); local_bh_enable(); --=20 2.34.1 From nobody Sun Sep 27 00:36:53 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E98044A3EB; Thu, 27 Aug 2026 13:25:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787837131; cv=fail; b=EGg8xG0ww3EhMKrk/5YYJV7TAU3CqlEQQHiwzJOK00YFwDf3BRr+wRBX56XENXHiXrgzAFG6wqncyolSgrustH24F4eIHQstFgdNbxwOY48AKOTHEjQsnRKvtPpklULXMKptzNGA+aYsvRJpNkMjHE9NGyUKbojxu/ioHL/w8qM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787837131; c=relaxed/simple; bh=IuirD4LQxH1TR5upgYGqqnVZxVhDQsnxgjt/vrRTDHI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Qxl949+dab6JtLbRBWcZKUeYb7jTtTHwWtZFaJKGNjHNo7cWMU8R455dslATGbHWlrmaYMog47nX6hwLsBg1pOhNiBzm8FcDumcAh90qVzVrzTHRIAsWdHibIXToHofIKtI7cIdjV90wqO3x2xrBTOMtREzPdIBp5Y5zAkqEefo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=qAIOtwMa; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=UXRbdG3O; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="qAIOtwMa"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="UXRbdG3O" Received: from pps.filterd (m0374955.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67RCATZB3085440; Thu, 27 Aug 2026 08:24:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=ayxzw1XXXTPkbcWouYdN6ift4PID+VGixCU3+9/b5 ks=; b=qAIOtwMapo+ODfTEIjJWnUYwzKyiH74csbVWTy8KL1fRnmL5LfUIchBth VGVjfCduftFcZmPki/uGgQdEAqTWw6ipxrnjnWqYMTeez6gNaQRXocZ8fege13Jg X3kmDsiALcMEuFhVpS/JxCai9cxTJ7VkFvoPsVbGWqFKvy5ekXQCjHCgOW3MlnbA bgGEgDNonbwVzaUC36ZvNnXkE2MeWS/jjOCpMQwc2YochzmEokppyQ9M57WGAUMX y87jHTuxNoj/mwn5LEUP9Mh9TdlttHpvCbAyJCUGQRgWsWlIIe2On96HAKwtFy4l szhN2u+HiKhXW4JfEVw5SRGLz9sWA== Received: from dm5pr21cu001.outbound.protection.outlook.com (mail-centralusazon11011028.outbound.protection.outlook.com [52.101.62.28]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gajhhs3v6-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 27 Aug 2026 08:24:17 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TzLlJUCpTfKL50UbIcgktIxlAr3C8USpaAv5e4e9bY5t7jWbyXVkSVadv2yiqJgE8KYBVumcrnlchTLo57zYJHuDfqpIytKP51l2pfYhxxvlbkBJtzXJKCA203qJ0TyaxgivMoCpnP7rCTwOP0pmz9ecCACAe+3951QJQcsUtS1RIFv8qJi2v15ejd3ByzcRC3wxQWMICyv44x+4rK2Kamupy83TKJ6sM4tCW4bro46elEucLqOke3QMc4c6KszANJdCIA+neNOaTh2b3Y5k9cYBBNxcXWBk51g/Zh9NPIlUnJ29HLU1kDJmBlDD+5FfylLYdzdTujUDs5XragJbsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ayxzw1XXXTPkbcWouYdN6ift4PID+VGixCU3+9/b5ks=; b=SoOXVkmvcqwnQfgrtGyon2IPdp7ULPsR0bJ1zUrHgy2Ik2mpSTAlm1wUFElt5oNCDV7EcbCzFivafW43Dhl/Ig5ieQJwHujf9FOx8yu6yBcjgImunUUU7EQ/YoDL0dbdrMM0AVXmu35sVETs6XO3AKPopx7t+zD/mk/jbpoIUk+i+DXoqMT4oo/H70hg6+nWdLMCbaYgO+RNa7sU2rf6Uk5qNz2rBGwEcamVrXuhoz+0br1H4Mc6omKjp9DY+AVnMKRIOgxEO2DXTAN/lQK1xsc+Y6FBr1xSGEkWmP/iLpDj34zYjAVKE0VUrVEOxSuUyaZtPwH2zHXXomxViqxzUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ayxzw1XXXTPkbcWouYdN6ift4PID+VGixCU3+9/b5ks=; b=UXRbdG3OWfjWs0Yu/GDlpEGTO/2gvv18RZm/UIEVz/fo9AloKscDGoaXaVj1YbIcGk0Ni3RPLLQINwdth6cvd7ggoxqaPete1banlGtX6qmv6bStTNnFYLN0yUlv5KRAtbXmrgSOgMBi2l2zTFePwmHijw5fdc4bNr5qLv+CwQ0= Received: from PH7P220CA0031.NAMP220.PROD.OUTLOOK.COM (2603:10b6:510:32b::32) by SJ1PR10MB5953.namprd10.prod.outlook.com (2603:10b6:a03:48c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.360.6; Thu, 27 Aug 2026 13:24:12 +0000 Received: from CY4PEPF0000EDD0.namprd03.prod.outlook.com (2603:10b6:510:32b:cafe::3) by PH7P220CA0031.outlook.office365.com (2603:10b6:510:32b::32) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.360.10 via Frontend Transport; Thu, 27 Aug 2026 13:24:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by CY4PEPF0000EDD0.mail.protection.outlook.com (10.167.241.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.360.3 via Frontend Transport; Thu, 27 Aug 2026 13:24:11 +0000 Received: from DLEE215.ent.ti.com (157.170.170.118) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 27 Aug 2026 08:23:50 -0500 Received: from DLEE204.ent.ti.com (157.170.170.84) by DLEE215.ent.ti.com (157.170.170.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 27 Aug 2026 08:23:50 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE204.ent.ti.com (157.170.170.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 27 Aug 2026 08:23:50 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 67RDNmtN894301; Thu, 27 Aug 2026 08:23:49 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v2 7/7] crypto: ti - Validate sg_nents_for_len() return value in DTHEv2 AEAD Date: Thu, 27 Aug 2026 18:53:18 +0530 Message-ID: <20260827132318.613876-8-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260827132318.613876-1-t-pratham@ti.com> References: <20260827132318.613876-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EDD0:EE_|SJ1PR10MB5953:EE_ X-MS-Office365-Filtering-Correlation-Id: d1e634a4-3d58-4fe8-172b-08df043e7b70 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|82310400026|23010399003|36860700016|56012099006|10067099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: N5EIu67yCIW3DBHJX4S642Pt0+ID19AKxJUKis9615X/Ggdyr6gm07oLVk3BccgCM7nu9/KGkDAz20mxZGW0ZSO71WJAyXaJLmXiSr7/jbS3bujaMiQFUVp3elYIBO0+j/t0caBg3eQkraIJIbAM5bR3tstcSfQ+v3DpFAjr//VGPiZz8NAq0gN5+inl6NXo7Cltm21SZ39IokZohr/FG/EVBH6+kOt5ZhXEyxuGn6STv1N/UZf7RPo+yL02onp8MSAMbN0To+kqOFtg3wuCMFy/e2J5Qf3h4ADVndPthqop6GP3W4dTxaeEXczHeLH6luCT900agU/E6fGjeLKniF5gjX8Xz7av8EirbqMasrdkMDfXWoY4nts8uqrB1tGwNeI6uIXCPLxuM4iNEpSsH/dN6m4rDqYGHuS3N9V+ja6JbnXhVjkJXaCvwq9kaidtggLVjSuK6WYaNvFznJ/HoSWaiMbvLeBEOdj+rdEU07Z8fHtOQkkhZD8mtfgkoj1ZLO5lhL0JSS73yNiTi4GJ2gTnpkjCamvgCVpkX39M6LwVDd2A8/7VXPAPpZP/CFdQ9SZ2XxkT2PqOEWI91d0p+NH1yDny+6iZ6XXDN25QipCVEhM8r1KlR48mU/MwnP4tRoihC/OwXm5WDQE4cjyxNpeRzuwXCbFUlRwr6awqwlSyeZH0ZszvJO90zX4nm4nNFJxWM0k1H/VurDSTtrutJA== X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(1800799024)(82310400026)(23010399003)(36860700016)(56012099006)(10067099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ACTKwTSrjlDSyrwYy4YN1uwey1USuXROj0EGJPtPqWiL3wkTo5Xp9F1XvIv7EmpcA+qZ6kU2AvyRsfwJb0IVsoF6rGuw9LDUEtQnuf2DlhnrIh0N859ANmkCaGKclT8qZS3FT5pNMaLW07njhEiH+Oi5wFHW9KnbFtWqoveUfpiLFjjFObFSLGGtaQlLHadn1odiIELUioEaX3S1Cwu3CLKIb2RVeFDjsWUZF1oS7DOfirtQ7BREwHuom/xz08lVL9bNdd9GkCckgqmOpM2OjZy1dR0gocCzgQ8WkmwiMmOve+/j8Q4WJlXrQsZiuVUDWhPMJKU5knCd+jsqUVtMMUE/WU2dw3Z+gGfsLgndhwzTWOf++AC9Eh0eAo5CVulr7kn8/RuzGw7lYQEXFaokQGWK4P6kOsWul5pz/RCSdzXJnc1JXtjQqy57EPS4ls5u X-Exchange-RoutingPolicyChecked: eU3wAeUW8jVU05+fCHgL8PGZVi7R+fekTMUGsZXcWcp6vr2AEbfm0V4c2X8/ZbPxPbEo/JXDqVnY/vGbj7kFObS/+OHsCIadYqPKRGLYiEeiRU9KxZakfx3dJvU91VKSBwkwhVp3B5pruWaCD2dAOZRrE9dYiWpaTtrCyta+BxnRX+wL20UPrV14APs+3p3qn+NntXv9pGCj9K/DzOAtiwrpGYwcneMhSzNmXbX42LfoQ1VxSw4pcnZBf5WAT5OuhRWc2WRZ+n9m9QiOCRMOgaruhjmtp16v4igd7muQEex8ny53TTZ3yD58bYcbQOfb4duOg3CE6G3iM8Y0FrGvcw== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2026 13:24:11.4516 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d1e634a4-3d58-4fe8-172b-08df043e7b70 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EDD0.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR10MB5953 X-Authority-Analysis: v=2.4 cv=Fu01OWrq c=1 sm=1 tr=0 ts=6a903a82 cx=c_pps a=1ZuumbNKwQvJCYYZUadJFg==:117 a=f+v6EHfkeJbVwR46tk4DMg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=Sv0fKeRqtYgA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=fPAWb5peG099m5CrUpKH:22 a=sozttTNsAAAA:8 a=iMD6g9N4YQ2QoEUmFGwA:9 X-Proofpoint-ORIG-GUID: G3pADYX7fVxVH9LWBkblIOIi0Hmomo87 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI3MDExMiBTYWx0ZWRfX9Ou3JzyKiIjd oMSbpXRk7SuOdhDZvtgGkWtlEKy2NUN1d0ZZzFvOM8BP6Yx/vSqyrA4sz6aI+W+iSOFJw8oCpWa vLqEzXACsaUq2CO9bIdww7Uhqkoj88K2TuzxEMmkFd2m5jPLAxXG8PgxUQfK7IplIlLTXE1LLdQ ZxK4OsJ1we8A7S/FXCq0jZhxkJq4xXTSPHik1x5+pdwCRlS1LKmloWkfXUrSeneHQIyMtHLPyoa BtnTLmnQ3O7tg7cUqJ9NWZyOyeOytbNUPh7Zv4YXRlJOZIDoMEuXptMd574EnoG3jVxy3yaxjDN XOdM4/CkkNAQxCgNtvQl9RFdFVhGYYSd7SeSBG3pG4vXd9v69J8O5flqxFuWhBkXEFHF3UCWF5v 0cgsE5JVN2ApLb0Hw0vWXL5r895j/ADmLfFUsnKWpQiAK1Jm9H9xvhMgTQmtGHnWWrPsoWuRTIU utbU6XcrfGRCm1Lus6g== X-Proofpoint-GUID: G3pADYX7fVxVH9LWBkblIOIi0Hmomo87 X-Proofpoint-Spam-Info: AW1haW4tMjYwODI3MDExMiBTYWx0ZWRfX9JwDsdCZXc02 s+MIp5irzlUhvRdPmWeigUMhV365Lhb2oapuu3gUWLMGkeYx8Ul7rKjvEaPTT1lsmvi+ezCrAde cHHv8MSXOTnygJ2fz1VAPW/4+O0sIWo= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-27_05,2026-08-26_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 adultscore=0 spamscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608270112 Content-Type: text/plain; charset="utf-8" sg_nents_for_len() returns -EINVAL if the supplied scatterlist is shorter than the requested length. Add explicit checks after each sg_nents_for_len() call in DTHEv2 AEAD driver. Fixes: 37b902c603042 ("crypto: ti - Add support for AES-GCM in DTHEv2 drive= r") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index 99fce19de81d3..7e7a232f5ed10 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -627,6 +627,8 @@ static struct scatterlist *dthe_aead_prep_aad(struct sc= atterlist *sg, return NULL; =20 aad_nents =3D sg_nents_for_len(sg, assoclen); + if (aad_nents < 0) + return ERR_PTR(aad_nents); if (assoclen % AES_BLOCK_SIZE) aad_nents++; =20 @@ -683,6 +685,10 @@ static struct scatterlist *dthe_aead_prep_crypt(struct= scatterlist *sg, goto dthe_aead_prep_crypt_split_err; =20 crypt_nents =3D sg_nents_for_len(out_sg[0], cryptlen); + if (crypt_nents < 0) { + err =3D crypt_nents; + goto dthe_aead_prep_crypt_mem_err; + } if (cryptlen % AES_BLOCK_SIZE) crypt_nents++; =20 @@ -741,6 +747,8 @@ static int dthe_aead_enc_get_tag(struct aead_request *r= eq) return ret; =20 nents =3D sg_nents_for_len(req->dst, req->cryptlen + req->assoclen + ctx-= >authsize); + if (nents < 0) + return nents; =20 sg_pcopy_from_buffer(req->dst, nents, tag, ctx->authsize, req->assoclen + req->cryptlen); @@ -761,6 +769,8 @@ static int dthe_aead_dec_verify_tag(struct aead_request= *req) return ret; =20 nents =3D sg_nents_for_len(req->src, req->assoclen + req->cryptlen); + if (nents < 0) + return nents; =20 sg_pcopy_to_buffer(req->src, nents, tag_in, ctx->authsize, req->assoclen + req->cryptlen - ctx->authsize); @@ -957,6 +967,10 @@ static int dthe_aead_run(struct crypto_engine *engine,= void *areq) if (assoclen !=3D 0) { /* Map AAD for TX only */ aad_nents =3D sg_nents_for_len(aad_sg, assoclen); + if (aad_nents < 0) { + ret =3D aad_nents; + goto aead_dma_map_aad_err; + } aad_mapped_nents =3D dma_map_sg(tx_dev, aad_sg, aad_nents, aad_dir); if (aad_mapped_nents =3D=3D 0) { dev_err(dev_data->dev, "Failed to map AAD for TX\n"); @@ -978,6 +992,10 @@ static int dthe_aead_run(struct crypto_engine *engine,= void *areq) if (cryptlen !=3D 0) { /* Map ciphertext src for TX (BIDIRECTIONAL if in-place) */ src_nents =3D sg_nents_for_len(src, cryptlen); + if (src_nents < 0) { + ret =3D src_nents; + goto aead_dma_prep_aad_err; + } src_mapped_nents =3D dma_map_sg(tx_dev, src, src_nents, src_dir); if (src_mapped_nents =3D=3D 0) { dev_err(dev_data->dev, "Failed to map ciphertext src for TX\n"); @@ -998,6 +1016,10 @@ static int dthe_aead_run(struct crypto_engine *engine= , void *areq) /* Map ciphertext dst for RX (only if separate dst) */ if (diff_dst) { dst_nents =3D sg_nents_for_len(dst, cryptlen); + if (dst_nents < 0) { + ret =3D dst_nents; + goto aead_dma_prep_src_err; + } dst_mapped_nents =3D dma_map_sg(rx_dev, dst, dst_nents, dst_dir); if (dst_mapped_nents =3D=3D 0) { dev_err(dev_data->dev, "Failed to map ciphertext dst for RX\n"); --=20 2.34.1