From nobody Mon Sep 28 04:56:11 2026 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8369B35F5F8; Wed, 26 Aug 2026 13:31:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787751097; cv=none; b=cdOv1qM1jt1PCtMP9ATkTfTMz7yKnueTD03saV4nmuMW9gGNMLLZwZAdbyR+2NfmADi65MLMcmX0K7kUbDdjLXfrN4tHjw1XyvyNjAwdZbfdxRlTIgU8hvz4boAu2yhkDKu5DGxP1LNwOPTc1AiIFgRmFvFeedWjk/oaoF1A6K0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787751097; c=relaxed/simple; bh=z0rT8XRMF3p2BNUf/fFNUgznNw2WeoufOjn8z+d3Vp4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=UodnB96AZRzEQAlw8ypf3CuBxAxz6T8Z1zGdrsLM+vhaq9CIitTXCWv6wZJRZMWlL2e2E/K+UP2DFpssYx43gfrZuEEBCTGoat8tpONZYKjGce0CArEe7RC0Lhcwnn4vTJjr1AtEOAC3cXoJ5XI2K0JkafWqYxBZOrCV/MyeuXw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 6e2a6d22a15211f19a56ed5b684f684d-20260826 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.19,REQID:d5917d28-4881-4d77-97d9-3cbe021ce695,IP:0,U RL:0,TC:0,Content:-25,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:-25 X-CID-META: VersionHash:7db8b62,CLOUDID:fad3a1795dcfca7808f1dd076da237e4,BulkI D:nil,BulkQuantity:0,SF:81|82|102|850|865|898,TC:nil,Content:0|15|50,EDM:- 3,IP:nil,URL:99|1,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA: 0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_ULS X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 6e2a6d22a15211f19a56ed5b684f684d-20260826 X-User: huangwei@kylinos.cn Received: from localhost.localdomain [(10.44.16.150)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1617737421; Wed, 26 Aug 2026 21:31:23 +0800 From: Huang Wei To: heikki.krogerus@linux.intel.com Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Huang Wei , Alex Bartz Subject: [PATCH v2] usb: typec: ucsi: do not register UCSI on Lenovo Legion Pro 7 16IAX10H Date: Wed, 26 Aug 2026 21:31:18 +0800 Message-Id: <20260826133118.3327816-1-huangwei@kylinos.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260826034658.2170407-1-huangwei@kylinos.cn> References: <20260826034658.2170407-1-huangwei@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The EC firmware of the Lenovo Legion Pro 7 16IAX10H (DMI product name 83F5) has a broken UCSI implementation: GET_PDOS returns no source capabilities, GET_CONNECTOR_STATUS reports an incomplete RDO, and any UCSI traffic disturbs the EC's autonomous USB-C Power Delivery negotiation. With ucsi_acpi bound, chargers connect only briefly and then drop, and voltage_now reads 0; with the driver blacklisted, the EC negotiates full PD contracts on its own and charging works normally. The problem is unaffected by BIOS updates up to Q7CN78WW (2026-04). The AMD sibling Legion Pro 7 16AFR10H (product name 83RU) reportedly uses the same EC firmware, but it is left out of the quirk until the failure is confirmed on that model. Skip probe on this machine, which is equivalent to the blacklist workaround the reporter verified to restore charging. Reported-by: Alex Bartz Closes: https://bugzilla.kernel.org/show_bug.cgi?id=3D221142 Tested-by: Alex Bartz Signed-off-by: Huang Wei Reviewed-by: Heikki Krogerus --- Changes in v2: - Add Tested-by tag from Alex Bartz, who verified the quirk on his machine (out-of-tree build, runtime module swap, PD charging held across the reload). --- drivers/usb/typec/ucsi/ucsi_acpi.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/drivers/usb/typec/ucsi/ucsi_acpi.c b/drivers/usb/typec/ucsi/uc= si_acpi.c index 18286d3e9cc5..9f36f8cfce4a 100644 --- a/drivers/usb/typec/ucsi/ucsi_acpi.c +++ b/drivers/usb/typec/ucsi/ucsi_acpi.c @@ -173,6 +173,21 @@ static const struct dmi_system_id ucsi_acpi_quirks[] = =3D { { } }; =20 +/* + * Platforms with a completely broken UCSI implementation in firmware. + * Do not register UCSI at all on these machines. + */ +static const struct dmi_system_id ucsi_acpi_ignore[] =3D { + { + /* Lenovo Legion Pro 7 16IAX10H: broken EC UCSI firmware */ + .matches =3D { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_NAME, "83F5"), + }, + }, + { } +}; + static void ucsi_acpi_notify(acpi_handle handle, u32 event, void *data) { struct ucsi_acpi *ua =3D data; @@ -199,6 +214,12 @@ static int ucsi_acpi_probe(struct platform_device *pde= v) if (adev->dep_unmet) return -EPROBE_DEFER; =20 + if (dmi_check_system(ucsi_acpi_ignore)) { + dev_info(&pdev->dev, + "UCSI implementation in firmware is broken, ignoring\n"); + return -ENODEV; + } + ua =3D devm_kzalloc(&pdev->dev, sizeof(*ua), GFP_KERNEL); if (!ua) return -ENOMEM; --=20 2.25.1