From nobody Mon Sep 28 04:55:36 2026 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD10541DE19 for ; Wed, 26 Aug 2026 13:22:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787750546; cv=none; b=QN0V4/96hwZvWyMNzvzt4YMnaVmITHHmaxzy0j3Y9C1uNvOnFxG09qQG3HYvdufojk9UJf0Sw3SWYDPcAhGk6+PqK/JreRQFeM9kYmWSbsvKE6krZyLaiUEqZC61lA8TYn6JhQgedsmv0YBRxD9wwI0/Qoh/oR2/3Nodk5PZxLE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787750546; c=relaxed/simple; bh=TfRLd5l9OOostsSkUsmGRYqtZsyco1P25dGKTsbgTZ8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lYOkY17uQG2ILbir2lIt7ezNokpO/V2a3e79r7dIdBuxarajiYbcnhjCOKwV9PQ9Id96sbR2lhhEUQG0Z3NDiGE6nVX3iJZKB05RDrMGi2pTMws6raCG8/3ixj8IaOiI6kOHlBphFeY9aArKt4ScLG+awFhyPP0vh3jhdzYm4RQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NxugNdPf; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NxugNdPf" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-c15cf78d1a2so115917266b.1 for ; Wed, 26 Aug 2026 06:22:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787750542; x=1788355342; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ykbfK96z/RlPNdWy0bK0lNcVhnXAIGj1ew3ivLknti8=; b=NxugNdPfB+1BZuVt7Yfeam5TJ+fW84LiJ8L/9j/9fGvkd25TiVXKviOwN/tYOW6Yi4 d36a99WwiNWO5qChJ9YdS4Humt/VVMjOoH2hByRewSsB1Cnb+lZnCB46p7qNwDoWSDn8 MAvR16FTcdNyAKBnIEMfUSi52z2AOHZKVZxrgp7DaiSh5f6w5mIK6r/sRp1eYtwvVwgs ZUxJzui2RnAlD+SVnVHbKfJSSbF6qMXCIjDhqiue4KVkp/CdNJTXOclI/6R+5D5V2Cdn i3X1gM6w3uGdV9a0uyNRTp7g7mAzu3xPRBss771wihRfS6wUIu419fAOqi0c/+vAzKnA tYQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787750542; x=1788355342; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ykbfK96z/RlPNdWy0bK0lNcVhnXAIGj1ew3ivLknti8=; b=hIk1WNca4tpUbSpGQBCJL9NJS3vitOCWOQXjxXTbsRv5J16v1nfF/8NAqJ096GmcmW HhBIIM8GunffUFP1pMzUhf9h6SmGXp3DDGaG0SRVCVyHm0/Tl/52lkqTFoWbO921oGp+ Uv/0QM/TVLhavxFfodTQqRci65OJxm3dveaBzcYOiKcBF4FoyLT2qyOQ68lxCwrgQ4Fy 2gBlcdlr7+M2Qz8Uda2C4aWSkefLfyBYsZeII0JA2YYCsiupr2XYOxdGjjd9BYQU7tTd vzfIh9pxeHB/U01bSdw4r1uDSQGo+riLR02Z0e7ZByT0Mp/km0jNOIK8Rv+skvfomQzm yq7g== X-Forwarded-Encrypted: i=1; AHgh+RodgvGX5hBiW1/E4ksXiiRnjTQWBZZspNDAUgAb9RBrFLbYkmc//5q6EkWoXAM0XUSaKuHfW/Jo0sPGO4I=@vger.kernel.org X-Gm-Message-State: AFuF++lhrys9GZBg2XP/H1hCPd7kqQ9WTgYH9wS9HuuwH9iWNzGA38We V570c136TgRK3nynmUvayhyDHKx7xSjuQjkwIPPm4RUw21UhWV+dRV9zTM8906X9 X-Gm-Gg: AR+sD11//lSaKmxS6hX7StsKkPleqelP5mApHxfvXCbOMGxeYCTPhfftjjmdGjBIQiZ V1s88KKUPkNwXD/p7kHYyW4wggjPpn22fELwtlg2i7zfQpUSIx5qx9yZHc/tA03N00Nq62zlf/s k3o42MlEndjQd0t1ti4osrQjfT0CqcZYtKn7sPe9+OHzoSJjXdijn5ZYE+PqNPoq2zBUqbCqHsz shF+OCFb5C+W6cjCdGCiqWBwAR1B2hLhapBZJLImXNw3vKqsv3U8OxSm28Df83UWzRFfk5EAQfS jBii170CnKIk5YXPbHu8OgP64wOe77rM1bA679C5x3OUSUgDyj/OAxntP2Ow3MfUr6sp1nygi7u jpoKW8EO8D7OujZL/OPEKeTJkzmid9DoqmRL7hl+90vl7UPuvkTqD4nQCYTVjxtF+GKFZqqXHGD cBqO7BVBb7/KqMkge8vFAgnRINg7zM7teguRAAl2+4JpcEmISDKwIK8icd8ugp6qdPZZ4ZwcgpB AjAMCQw0cv0M/raiY6J3lqEbYtzR5BT0Z5SYtlSkK8= X-Received: by 2002:a17:906:ba83:b0:c25:544:3aec with SMTP id a640c23a62f3a-c250baf9b5amr980895766b.5.1787750541405; Wed, 26 Aug 2026 06:22:21 -0700 (PDT) Received: from 1Z10 ([37.163.238.51]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c250a72d6dbsm435905466b.24.2026.08.26.06.22.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2026 06:22:20 -0700 (PDT) From: Maurizio Casciano To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, Liam Girdwood , Mark Brown , David Heidelberg , linux-kernel@vger.kernel.org, Maurizio Casciano Subject: [PATCH 1/2] Input: drv260x: Make vbat supply optional Date: Wed, 26 Aug 2026 15:22:10 +0200 Message-ID: <20260826132211.3341936-2-mauriziocasciano7@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260826132211.3341936-1-mauriziocasciano7@gmail.com> References: <20260826132211.3341936-1-mauriziocasciano7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Lenovo Yoga Book YB1-X91L firmware instantiates two DRV2604 ACPI devices, but does not describe a software-controllable vbat supply for either device. The generic regulator lookup therefore creates a dummy supply. Use the optional regulator lookup and skip regulator operations when no supply is described. Systems which provide vbat retain the existing enable, managed-disable, suspend, resume, and error-unwind behavior. Signed-off-by: Maurizio Casciano Assisted-by: Codex:gpt-5.6-sol sparse --- drivers/input/misc/drv260x.c | 57 +++++++++++++++++++++--------------- 1 file changed, 33 insertions(+), 24 deletions(-) diff --git a/drivers/input/misc/drv260x.c b/drivers/input/misc/drv260x.c index 6c5c4c53753b..c4fbb10b254e 100644 --- a/drivers/input/misc/drv260x.c +++ b/drivers/input/misc/drv260x.c @@ -499,22 +499,26 @@ static int drv260x_probe(struct i2c_client *client) haptics->overdrive_voltage =3D error ? DRV260X_DEF_OD_CLAMP_VOLT : drv260x_calculate_voltage(voltage); =20 - haptics->regulator =3D devm_regulator_get(dev, "vbat"); + haptics->regulator =3D devm_regulator_get_optional(dev, "vbat"); if (IS_ERR(haptics->regulator)) { - error =3D PTR_ERR(haptics->regulator); - dev_err(dev, "unable to get regulator, error: %d\n", error); - return error; + if (PTR_ERR(haptics->regulator) =3D=3D -ENODEV) { + haptics->regulator =3D NULL; + dev_dbg(dev, "No vbat regulator found\n"); + } else { + error =3D PTR_ERR(haptics->regulator); + return dev_err_probe(dev, error, "Unable to get vbat regulator\n"); + } } =20 - error =3D regulator_enable(haptics->regulator); - if (error) { - dev_err(dev, "Failed to enable regulator: %d\n", error); - return error; - } + if (haptics->regulator) { + error =3D regulator_enable(haptics->regulator); + if (error) + return dev_err_probe(dev, error, "Failed to enable regulator\n"); =20 - error =3D devm_add_action_or_reset(dev, drv260x_power_off, haptics); - if (error) - return error; + error =3D devm_add_action_or_reset(dev, drv260x_power_off, haptics); + if (error) + return error; + } =20 haptics->enable_gpio =3D devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_HIGH); @@ -585,13 +589,15 @@ static int drv260x_suspend(struct device *dev) =20 gpiod_set_value(haptics->enable_gpio, 0); =20 - error =3D regulator_disable(haptics->regulator); - if (error) { - dev_err(dev, "Failed to disable regulator\n"); - regmap_update_bits(haptics->regmap, - DRV260X_MODE, - DRV260X_STANDBY_MASK, 0); - return error; + if (haptics->regulator) { + error =3D regulator_disable(haptics->regulator); + if (error) { + dev_err(dev, "Failed to disable regulator\n"); + regmap_update_bits(haptics->regmap, + DRV260X_MODE, + DRV260X_STANDBY_MASK, 0); + return error; + } } } =20 @@ -606,10 +612,12 @@ static int drv260x_resume(struct device *dev) guard(mutex)(&haptics->input_dev->mutex); =20 if (input_device_enabled(haptics->input_dev)) { - error =3D regulator_enable(haptics->regulator); - if (error) { - dev_err(dev, "Failed to enable regulator\n"); - return error; + if (haptics->regulator) { + error =3D regulator_enable(haptics->regulator); + if (error) { + dev_err(dev, "Failed to enable regulator\n"); + return error; + } } =20 error =3D regmap_update_bits(haptics->regmap, @@ -617,7 +625,8 @@ static int drv260x_resume(struct device *dev) DRV260X_STANDBY_MASK, 0); if (error) { dev_err(dev, "Failed to unset standby mode\n"); - regulator_disable(haptics->regulator); + if (haptics->regulator) + regulator_disable(haptics->regulator); return error; } =20 --=20 2.53.0 From nobody Mon Sep 28 04:55:36 2026 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EA7422423A for ; Wed, 26 Aug 2026 13:22:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787750547; cv=none; b=s3Gi2SvmfJdi/tD4WqNOrnOP5Zxi/j/5GU5jJxTs7tFblH0v/OT7LPrRnb555vEWOjDpLMN3S7rfd5lPfSI9WW6qVQ7hWve41Ib4KLJ9liOEPPEzpy7bdLL/04FV9SCJy8fS2LqvGwlLUsNiTmQ1wbIPsjCQh7hPwmVwk8kFVGM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787750547; c=relaxed/simple; bh=iAdAwTxARp1+YiznOMAmAa7ysTQVV/NT6mH/DlSKF9A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EhTEoZea/31x2UVZCkvFVYFzWlPFyim6kBo00EeoTYF4YMVwGbYc/fWFD6Oc5u6jLZ8751Y3eu6Zkf2WOf+4Zl6qR/MJIrdV8QVd+AEa6oF75NOeQjmz0l+Pa+PJLDzrqL1UxktPZnsn5OImfVjDxJw5BEsYoo9qc8aHPvkDeeg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N1kjBrzl; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N1kjBrzl" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-c250f28f1cdso145601066b.0 for ; Wed, 26 Aug 2026 06:22:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787750543; x=1788355343; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GJWRbczxBpTVEHL3IgaRo4VxJCouD04FNJY7agPmZWg=; b=N1kjBrzlnMzMjnS8gmM+I8bSsga3IfH5RFxkdHqVUmb0tJ7mlsBFJv1EOp5ZHLtyjZ od+Wdo7APJ6y52Fss9tBTdHl0c2yVnJtcS6rvCL5t9j/JbMBb68IIxHS9JzK/52IGcF8 VvT8qXv441bAvXWEea3mCKCT+6YBxexiEKzteSwL4r36tVg9TksW7BhbxjPDxhylSNbx rpDohaEd9bsbbjbQrr8ToBMvAOyvKYAZY2uHHC9x5CS87yDGm1upeinRyYUJeKwHhCGH 6zfuzqnoB03Z/V16fDDFwauEOEuNknk0ndYaPOnPQnHi/Q8cdGeqFuseJTvnJSw7TzFG H6UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787750543; x=1788355343; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=GJWRbczxBpTVEHL3IgaRo4VxJCouD04FNJY7agPmZWg=; b=myd5D7TEMusyFhF0qf98TbwmN3o+jEm59+SDzcZJdmKX5kLp9JOj6B0vP2tXeJUfYq aQy+gj1x/BR2KYaAHkzoQqbDxvEGv4dCDfvn4opcYKgrCj6fgl5PnHgfWMlFJDfgDMRx CQeltY4NSwxt2vYt3c9RwSHnDnLmIrA4pW1at46BdN0v2TJhOWDPiZWmUx8wMdOpv7TW /LmvF0bXEjIBsd7S/g/sdFeMF0vurOjH7Qd2HLyxzQIGQ6SExqadpZE5ukbHZkmEbL/G ZojCyS50uoptnq/RPv9JBZd4/eYIWSN2uPqjuNr3O6LLfJ3zvQR7rYwwFQ57AeyhGHSD Ah/A== X-Forwarded-Encrypted: i=1; AHgh+Ro4iMS16ByUIY1qxEBlpDryQb27ziSydHdOyUxZlvP/gAmbS2vetvKf38v6eot+BcbSrbuqSzri0prV3yM=@vger.kernel.org X-Gm-Message-State: AFuF++nzpabgZvzMYrSJRHcrCqzLsmiM+CsWaCEwZEah24lVKEr2d2Ap VAmLzEDFpK4zLyFNFD00Bha5TYWw7LFN+ajNimTLK6g+T2Ov+Pf3HTAv X-Gm-Gg: AR+sD11FScYn0QBQZYMJwzUOd3W+TMYH1ZySWqElsxVf5VyaeUzesdUQb9E7KV0eUCu y6N1vb8wT5flXALkmE33OghO/ui9cQxyFblJb65EDhHMvoEnkgl38jH3WYZvnBgeumQZwVqoOYj kYG/2resqe8j+2U9sznCUTFIBwb2/PQ+GO5jg66ZV/SLcPzQbp/TxQhnu7qCo9h7RlpQ6zRu8aT 4S2X2LNAf3MZUD9KY2RlEQuS+YG2MtQLa99t6x18hOBWsePVwOW4/Gbx0mRPFn2k/vzscgPI5FN rtd8GjPSwQTmw7vEEf59KFTAdK6KNrO88Bm27YiscMRk7LebHs5rxdRVFz7kcGSdfOogPV5m6No 4JT6e34fAdgGZGJuZ7Y792/4VyjO+18YNOm/vjzVALgtXl5jSrd86IA4sLFc8J6zHLXXvlCw2bI bWlH8qC++VRqw4ocEG4KWbXt/M+Em59GbJQ7WLsChoJJ+315f6knTNXfA1recOcNUEiOSuP1RDX UjEkcOMRCM0osL+8GIaEwJRvQZJ7ud6VoZqci6FHec= X-Received: by 2002:a17:906:c143:b0:c16:2dc0:e1ef with SMTP id a640c23a62f3a-c250c331e63mr707424266b.14.1787750543009; Wed, 26 Aug 2026 06:22:23 -0700 (PDT) Received: from 1Z10 ([37.163.238.51]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c250a72d6dbsm435905466b.24.2026.08.26.06.22.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2026 06:22:22 -0700 (PDT) From: Maurizio Casciano To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, Liam Girdwood , Mark Brown , David Heidelberg , linux-kernel@vger.kernel.org, Maurizio Casciano Subject: [PATCH 2/2] Input: drv260x: Map ACPI enable GPIO Date: Wed, 26 Aug 2026 15:22:11 +0200 Message-ID: <20260826132211.3341936-3-mauriziocasciano7@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260826132211.3341936-1-mauriziocasciano7@gmail.com> References: <20260826132211.3341936-1-mauriziocasciano7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Some ACPI DRV2604 devices describe the enable line as the first GPIO resource in _CRS but provide no _DSD mapping for its function. The GPIO consumer lookup then returns no descriptor, leaving Yoga Book haptics unable to complete calibration. Add a managed ACPI GPIO mapping before requesting the optional enable line so these devices can power their haptic path. Signed-off-by: Maurizio Casciano Assisted-by: Codex:gpt-5.6-sol sparse --- drivers/input/misc/drv260x.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/input/misc/drv260x.c b/drivers/input/misc/drv260x.c index c4fbb10b254e..b6243ce8157d 100644 --- a/drivers/input/misc/drv260x.c +++ b/drivers/input/misc/drv260x.c @@ -434,6 +434,13 @@ static const struct regmap_config drv260x_regmap_confi= g =3D { .cache_type =3D REGCACHE_NONE, }; =20 +/* ACPI DRV2604 devices describe enable as their first GPIO resource. */ +static const struct acpi_gpio_params drv260x_enable_gpio =3D { 0, 0, false= }; +static const struct acpi_gpio_mapping drv260x_acpi_gpios[] =3D { + { "enable-gpios", &drv260x_enable_gpio, 1 }, + { } +}; + static void drv260x_power_off(void *data) { struct drv260x_data *haptics =3D data; @@ -448,6 +455,14 @@ static int drv260x_probe(struct i2c_client *client) u32 voltage; int error; =20 + if (has_acpi_companion(dev)) { + error =3D devm_acpi_dev_add_driver_gpios(dev, + drv260x_acpi_gpios); + if (error) + return dev_err_probe(dev, error, + "Failed to add ACPI GPIO mapping\n"); + } + haptics =3D devm_kzalloc(dev, sizeof(*haptics), GFP_KERNEL); if (!haptics) return -ENOMEM; --=20 2.53.0