From nobody Mon Sep 28 04:51:20 2026 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2391E424D46 for ; Wed, 26 Aug 2026 13:22:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787750524; cv=none; b=aTHgiltaME3XwHHauk0NuxwMXPJAlerNJ67+ajd/L2hgJF7QSInrvpQVSqd6K4OW+uK1Jp4PBAm5VYhxVzj/qb+PV4Q76LON6IZbA1Fw+BaoQbPxPZ/U3G7/hyJpY+qsmKmE92SoVWWG+jZA0UvEmeLx2WbygZi0vM+Zo+cVeUY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787750524; c=relaxed/simple; bh=YfYeCCwljxs5fzIjYTOd0pysB6MB+g6pIQzXMIkWylw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=H9dqDr7OenSwWPfhg1LXb7TtRTqZutnJq4eaWgsq4npIA/gMzDy00Qj7Bz6kfL1d+hAbAbnquSvm9miVfWssTaonfF0kSdWr5AqclVOJVtPMIZS69XU9E1xn4rTZ23VD9Ve5cNNb8I9yen2N43gfcM9GSzVrKqnJKzjITr0ZmbE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=J4VZaFhq; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J4VZaFhq" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-482e2904915so497668f8f.0 for ; Wed, 26 Aug 2026 06:22:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787750521; x=1788355321; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7Q4gA+nOdeWZSwsSNe0w4DOU8QZDN/9GWMD7TfqVftY=; b=J4VZaFhqNFNWUduzpYwKCKbL7ZQH7z0wsgUNDhD6qD7SbNs96/5fvt7wG8LFqfucyj qte1hUlArFn94Vwkz889qENs+jHM1T3C7qQS7j6EAnwa1m2PV4eyzaCgHJO0LVZ5E6Pp 2AQw7tAsNELS6Z0TdkyJ2YZ+8WhLg+LDMiwDAFbcK7FcVWyGB23Rx3BfoEJEmAYwAa6s X+VYmynU7EKfvfl2mngumaHN/3QylAKLX57JWi4GRYySHjBaWKcHkzsKvivpHjrk/0hm fWK/XdnG76OFS78N0/2nTu/5387AXo2SJAQ2VrY6EP4NkeAp6NPLuokPsC5X1HmM187p xINQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787750521; x=1788355321; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=7Q4gA+nOdeWZSwsSNe0w4DOU8QZDN/9GWMD7TfqVftY=; b=sIqk9LuNdU2O8TmYr367bc4RbLlwKRlHncUPlsNIp6RaAINaKPryWFNUg3UQEKrOf2 cwZNHAqy+f/IoGarxzPNYwA80hoUJQAUoHg30KeLmew6FKMLIqs0THJKF15rlB5/UVTn tbNXoYpIlERJbcFaY79MD5ksHCydzKVGgaCbo7/lKG4qPNMhd8D6AJlninJqMYT5qbEK 6HKIUTVohFZ8r96J0ZJ3GaAbhn+E37EeUUIst/5PMZTWBe73YSpDN49+eUjwBemUxBlh InAYRXC6DZj2y0smajv18T/0/agHy3zmUCCR2UJHFP8YjrQlh8cPHliUTBT+yGacwyE6 wUaw== X-Forwarded-Encrypted: i=1; AHgh+RqJ7VFgS09dacOeEYHfK7F1YN2aDtqydnM8b3pxRiWNxhR4bTGTtqiM/bLV6DrjHnyDI+ZAnnYu4dgdU4I=@vger.kernel.org X-Gm-Message-State: AFuF++lKwgVez0Te6TAF2b6cPLFIfIB5eZRZ3BpuQxHvWkFFF/o8WeT6 apJyFcYyj0loEg7WdsWBhJHzDYshYqQC6xyupgzxZky6auEY7hIIolrZ X-Gm-Gg: AR+sD12rerHrMUzxPeySRq5tC+VW9PEFIIpzo+eAhSw+FN4TReFdTfY4IP+yC4R7ryN LdBGr31jJGB2btrxv5EDa1mSEeg0tmY8RuySV/9M+Nb1ArwkMoTbdqlCkbie1+ZiSPdTfFRupLu cKu7PTlOsYMAEHYP5dNflyexRlL0kt1sxcSQC+Yz3WncrfEkI4dYaK0wG9Oj1/bZHQsOSE3KMVW BhlUuxy3X5kbZl5VpHBKo9qumP6hjlQEv0XMfQ0m/aWJMIBdpX3RcrvwQlNmJPzU162CdQMwrtG VR0NT5F9LAxtgN8blAXkHKuZO/unbbaRDUcRS8djDjaZ4aWeNbQTegeExKrXoX6HMsczInE+LJR sl3e2cobsHCv/NZySNHDg7EcNx3rYh5IOp0rqlnS+9T5lVC57g4JSFvDlLiG6EUPtjhStleiTrn l754Cu+vtxO6+8iwuCm0VXEeQ6/4jglAlecFgevTLLki4TFhEHmT9BPfJRCdA= X-Received: by 2002:a5d:5e01:0:b0:482:e173:9949 with SMTP id ffacd0b85a97d-482e26d9657mr8019447f8f.14.1787750521087; Wed, 26 Aug 2026 06:22:01 -0700 (PDT) Received: from localhost ([5.83.201.220]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482e4f0c8f7sm2036957f8f.27.2026.08.26.06.21.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2026 06:21:57 -0700 (PDT) From: Colin Ian King To: Viresh Kumar , Nishanth Menon , Stephen Boyd , Rob Herring , Shawn Guo , "Rafael J . Wysocki" , linux-pm@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Eli Gurvitz Subject: [PATCH] OPP: of: Fix potential multiplication overflow when calculating freq Date: Wed, 26 Aug 2026 14:19:57 +0100 Message-ID: <20260826131957.1063765-1-colin.i.king@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The multiplication be32_to_cpup(val++) * 1000 is performed using 32 bit unsigned integers and hence uses a 32 bit multiplication; this will overflow if be32_to_cpup(val++) is greater than 4294967 (which is very unlikely at present). The result is assigned to an unsigned long (which is a 64 bit value on 64 bit systems), so fix this potential overflow by casting the first operand of the multiplication to an unsigned int. Fixes: b496dfbc94ab ("PM / OPP: Initialize OPP table from device tree") Signed-off-by: Colin Ian King --- drivers/opp/of.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/opp/of.c b/drivers/opp/of.c index c02e20632fa6..9c4fd1f0e944 100644 --- a/drivers/opp/of.c +++ b/drivers/opp/of.c @@ -1039,7 +1039,7 @@ static int _of_add_opp_table_v1(struct device *dev, s= truct opp_table *opp_table) =20 val =3D prop->value; while (nr) { - unsigned long freq =3D be32_to_cpup(val++) * 1000; + unsigned long freq =3D (unsigned long)be32_to_cpup(val++) * 1000; unsigned long volt =3D be32_to_cpup(val++); struct dev_pm_opp_data data =3D { .freq =3D freq, --=20 2.55.0