From nobody Mon Sep 28 05:46:03 2026 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B6923B7B7A for ; Wed, 26 Aug 2026 08:16:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787732204; cv=none; b=SHpmtuW747GN7h9LmswqgF+EwBHKvIw12yLQWLfnvSTnRA0u8WduUayC4tbm+WWtN5yT+gnpjEdNl3fv0zKjZfvyUrA3IbhSLrGs62/WNRFG1XkoQwenkK5KXvGRxyZZWcGjPUkKsERvpcRPZ1lNZv7jo+qta5dz9oO0OYjj+A0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787732204; c=relaxed/simple; bh=21Vhw8Sf8iEiUuERUCd5l+TZdmvIet77ciwl2zv72TU=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=skI0nEwF041ly6xbV0GBznxp2vffcSAA3xcNTsppyyWJl7lvK68dWa8qkJ9Xc1vR8IbH0KnHo2acIN1letoFLuRN0vpJD4tyD6h1QuQ38KfijdX/0c+ixI925SV5e3bMVOR7fzozd69sZRCwGZJ308S3XauNVrMghkFPZNmm7Os= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=EZKx7opF; arc=none smtp.client-ip=117.135.210.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="EZKx7opF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=Hq +PQvivij3P3MEGYcAKZIRnspRAwgEpPvp+39rTTpk=; b=EZKx7opF/Rug+ks6kT NJbc3Bv6nRKu55seIrP5z7RMripn0m045My98LFUO/lQLZKwHTzuCuHpwrUx5AsD h38Hzm8QMoNYM2M/zIJDMQVfXiFxBzFokUB03AqcCegzEeu+GRB4rhQg76rStNam 5BhssaqSmXUz6dQjDwtXp4yVA= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g1-1 (Coremail) with SMTP id _____wA3FQuwoI5qcmjaRA--.53472S2; Wed, 26 Aug 2026 16:15:45 +0800 (CST) From: oushixiong1025@163.com To: Matthew Brost Cc: Danilo Krummrich , Philipp Stanner , =?UTF-8?q?Christian=20K=C3=B6nig?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Shixiong Ou Subject: [PATCH] drm/sched: Create faux device for KUnit tests Date: Wed, 26 Aug 2026 16:15:43 +0800 Message-Id: <20260826081543.508257-1-oushixiong1025@163.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wA3FQuwoI5qcmjaRA--.53472S2 X-Coremail-Antispam: 1Uf129KBjvJXoWxWr1kGw1kKryktF43JF48Xrb_yoW5urW5pa 9rZFWYgrWrtFyDKrW7ua1rZFyfGw4xC347Kr1DK34Y9F1vqFy5tr4DGrW3Jry7ArW7ZFWS vwnIgw47GF4jyr7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jeFAJUUUUU= X-CM-SenderInfo: xrxvxxx0lr0wirqskqqrwthudrp/xtbC-hGSoWqOoLH4GQAA3I Content-Type: text/plain; charset="utf-8" From: Shixiong Ou The DRM scheduler KUnit tests currently pass NULL for the dev field in drm_sched_init_args, which causes a NULL pointer dereference in the drm_sched_job trace event when it calls dev_name() on sched->dev. Use faux_device_create() to create a fake device for the mock scheduler, so the scheduler always has a valid device pointer. This avoids the trace event crash without requiring the production code to accept a NULL device pointer, which conceptually makes no sense for a scheduler. An atomic counter is used to generate unique device names, since multiple mock schedulers can exist simultaneously across different test suites. Signed-off-by: Shixiong Ou --- drivers/gpu/drm/scheduler/tests/mock_scheduler.c | 14 ++++++++++++++ drivers/gpu/drm/scheduler/tests/sched_tests.h | 2 ++ 2 files changed, 16 insertions(+) diff --git a/drivers/gpu/drm/scheduler/tests/mock_scheduler.c b/drivers/gpu= /drm/scheduler/tests/mock_scheduler.c index 14403a762335..cd87e405bb1e 100644 --- a/drivers/gpu/drm/scheduler/tests/mock_scheduler.c +++ b/drivers/gpu/drm/scheduler/tests/mock_scheduler.c @@ -1,6 +1,8 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright (c) 2025 Valve Corporation */ =20 +#include + #include "sched_tests.h" =20 /* @@ -10,6 +12,8 @@ * Test cases are implemented in a separate file. */ =20 +static atomic_t drm_mock_sched_instance =3D ATOMIC_INIT(0); + /** * drm_mock_sched_entity_new - Create a new mock scheduler entity * @@ -296,11 +300,20 @@ struct drm_mock_scheduler *drm_mock_sched_new(struct = kunit *test, long timeout) .name =3D "drm-mock-scheduler", }; struct drm_mock_scheduler *sched; + char name[64]; int ret; =20 sched =3D kunit_kzalloc(test, sizeof(*sched), GFP_KERNEL); KUNIT_ASSERT_NOT_NULL(test, sched); =20 + snprintf(name, sizeof(name), "drm-mock-scheduler-%d", + atomic_inc_return(&drm_mock_sched_instance)); + + sched->faux_dev =3D faux_device_create(name, NULL, NULL); + KUNIT_ASSERT_NOT_NULL(test, sched->faux_dev); + + args.dev =3D &sched->faux_dev->dev; + ret =3D drm_sched_init(&sched->base, &args); KUNIT_ASSERT_EQ(test, ret, 0); =20 @@ -323,6 +336,7 @@ struct drm_mock_scheduler *drm_mock_sched_new(struct ku= nit *test, long timeout) void drm_mock_sched_fini(struct drm_mock_scheduler *sched) { drm_sched_fini(&sched->base); + faux_device_destroy(sched->faux_dev); } =20 /** diff --git a/drivers/gpu/drm/scheduler/tests/sched_tests.h b/drivers/gpu/dr= m/scheduler/tests/sched_tests.h index 553d45abd057..bbf4da585866 100644 --- a/drivers/gpu/drm/scheduler/tests/sched_tests.h +++ b/drivers/gpu/drm/scheduler/tests/sched_tests.h @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -44,6 +45,7 @@ struct drm_mock_scheduler { struct drm_gpu_scheduler base; =20 struct kunit *test; + struct faux_device *faux_dev; =20 spinlock_t lock; struct list_head job_list; --=20 2.25.1 No virus found Checked by Hillstone Network AntiVirus