From nobody Mon Sep 28 05:45:31 2026 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35E342F8EA5 for ; Wed, 26 Aug 2026 06:57:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787727466; cv=none; b=jQYlSxVCVJ4d2AFyqd20ED4Icm6YXifuFlfQbmUsZtKSh6yTHMUVtz2tNWWfB//q4CDtJw7M0DYqa/u+K7DVObpujzW7aJGQLcYQTSp2mJTormFSOoYQ3kJnYq1zgbiwPCeaOsAg4J+ZNzt63JGKV0oaWgpiLsNSnLx7U19qHVU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787727466; c=relaxed/simple; bh=f8OwTTpZNHfbiH2wLTIvj6a9S3UK5gxcljSHr2lehIg=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=aHu+5fiMI6O6nHOc/xPt1Nek8MCCHOGekrWLjm2HSXGlEEXvkZyK3l/5lw1v3wKgVpdjTGKmOMUiK83eh/1oc6OVe296RmPxaJWyUjuJ5HmDN82h8jrhktotD67y6W6P70KY8+V4Z3ANuvwZYyrghVa85EXVIT4QeMUciONTyZY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=GE4y075E; arc=none smtp.client-ip=220.197.31.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="GE4y075E" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=Jb pmdGWy/go06b/bKFUmGuT6wYdXB22e+au7hEoMXwE=; b=GE4y075EiM6B+yaE6k 2tJ4B6UqJZe4AiEQEJ1TIllTB/OukgmL6wpwDmlrl1oIkTUU14d52SWdMVkfTgqy dEu9dy/Kc/7SEOt076Ir0/6ythzNMbApRxPUe1X/aLkDmVpdKPh8A9DeWQmDQO54 JegK1y05XTKogBh5mv8FJP6G8= Received: from localhost.localdomain (unknown []) by gzsmtp5 (Coremail) with SMTP id QCgvCgB3+BeSjY5qs87iOA--.19815S2; Wed, 26 Aug 2026 14:54:10 +0800 (CST) From: Qingshuang Fu To: Paul Kocialkowski , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Andy Whitcroft , Joe Perches Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Qingshuang Fu , Qingshuang Fu Subject: [PATCH] drm/logicvc: fix device_node refcount leak in logicvc_layers_init() Date: Wed, 26 Aug 2026 14:54:08 +0800 Message-Id: <20260826065408.617148-1-fffsqian@163.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: QCgvCgB3+BeSjY5qs87iOA--.19815S2 X-Coremail-Antispam: 1Uf129KBjvJXoWrtry5tryUAF4fZw17Ww1xXwb_yoW8Jr1fpr WfGas0ka12vr4ayrnYyFy5ZFy8Ww4xJrZrXr1Iyw1DXrs8A3Z8J3sYvrW5Xrn8Aa97ZFy2 vryqgFyqvw1jkw7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0piXyCJUUUUU= X-CM-SenderInfo: 5iii21xldqqiywtou0bp/xtbC6hLFkGqOjZIO6AAA3w Content-Type: text/plain; charset="utf-8" From: Qingshuang Fu for_each_child_of_node() holds a reference to layer_node for the duration of each iteration and only releases the previous node when advancing to the next one. When logicvc_layer_init() fails, the loop exits via the error label without ever advancing, so the reference to layer_node is never dropped and the device node leaks. Add the missing of_node_put() on the error path. Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller") Signed-off-by: Qingshuang Fu --- drivers/gpu/drm/logicvc/logicvc_layer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/logicvc/logicvc_layer.c b/drivers/gpu/drm/logi= cvc/logicvc_layer.c index 7f5ba000188a..e83a2aafed77 100644 --- a/drivers/gpu/drm/logicvc/logicvc_layer.c +++ b/drivers/gpu/drm/logicvc/logicvc_layer.c @@ -613,6 +613,7 @@ int logicvc_layers_init(struct logicvc_drm *logicvc) =20 ret =3D logicvc_layer_init(logicvc, layer_node, index); if (ret) { + of_node_put(layer_node); of_node_put(layers_node); goto error; } base-commit: 45c13f3f9e3bb15fd89ff2864c6f627a3b4b4229 --=20 2.25.1