From nobody Mon Sep 28 06:38:06 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC54044605C for ; Tue, 25 Aug 2026 12:57:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787662675; cv=none; b=dU+ExiNucAeLASOWSTHQREkMpUqign/r6IXLAcDpR6bQpmkJ0KFQvl2GiuWRcX+d0grOxaKCuujvit7W0Z4mRfboMz7uvLGQgiIGH5yLGLJ0V/m5z7QfajYSk7QlgwKVbrJG0zNcf8OBN9AXvADgudrWQbUrtZpk4TbQIS6XriA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787662675; c=relaxed/simple; bh=QP+3/LI0nxLkgJ/Scbe7OQh/8ApQIaUvT5L3XTK6zFI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fQfFINDdvGKRjqk2Ky3sgdGf7v4mIwbBgHQOWQYORket66em0VUFDeQlM/w5RlAxlDDPcCdGe5Md2N0JaRbjcMZeLU5DEltMQ4+ZB8tuNZFxgl1KgkhmEhUsyh/uzoiiaQTNOCLirSCevdk9APTkdhiCWxI78M6r/ARhVuqf6jg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QSPzWO4p; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QSPzWO4p" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-84e27035206so1952468b3a.3 for ; Tue, 25 Aug 2026 05:57:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787662673; x=1788267473; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=mxkwXPN1Bs/FaD68NtnzI5z2SBmRZQo8jCWgYr3x1Zs=; b=QSPzWO4pm8QEHbKsMMnapIEnEE1pFB5Vbhf2sRem6thc12XyPny9eSJ5OJbcroWvWH NVHOqQ1zjJtvcOH+LoCKrwRW/9YTm7saSa3jclg1/z2ELmzEGy450JYMN7goxV9n72GY V3ecp2TlusGLHaA1v9VxnhP0PrQJ6KVk41RYtGbp9HUqtmNYvjIkzR5IczRpSIjSSOTT Bm/IEuRgSpMTXg8Obxi6dfsBTvO/2qXlzffNnqbHjQdju/fzUfSTCoDFAXHQLJhwXd5Z Ylc4lr+iQQF6hJUdEZUlJ/80oMDtig+IBVnlzGl1ZZgsdYfRpoh2OPvVs4nMwe/Vq5bG +ASw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787662673; x=1788267473; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mxkwXPN1Bs/FaD68NtnzI5z2SBmRZQo8jCWgYr3x1Zs=; b=E9gJ+Xkqw+K6hQ3lA/v+Hw/ZkHRO2lNm8rC3t5LyPbwdknv8grNqZo4yNqN5nKo4Lu V8OD7hRNEcHXSxDnN90iYJ3JBX3so7PMe8Te+QEIGxmpUDjV+Qe+Z1tqk1TPSPc/6SZo in6V23j5BHPfrb89oaY4b3p5CQfkc1wEsmAhBM9wbBtWHqoSXfr1pRVQBFfpCXn0nXz3 miAiYi49VsOCevkkn4FcmcBqoVwkD+EEnettXlSBsHgYCr5rHAGVxAMO4kT2VMf+40hi wSfp/6fUeGACy9DFnoTUeD4pgD6fWfsvK6Y2eHVkiLWmt/wYPZd/TngNB4i3CyHfd2AY c3gg== X-Forwarded-Encrypted: i=1; AHgh+RqPRu6g0NzcaJ6bk0bkXRKXfMqdzQP/J6Uvz/08Tx4GjoVnWL9c7KeWmaPMvnSHVf4UhWEdQrT2OJNfWb0=@vger.kernel.org X-Gm-Message-State: AFuF++nf0ytQTitm9dH8bWZ2xxtEMXJX3AdRlS2XlufQcYbH5XkJQNZ1 9JeCwKZPLEgVaLAbF12iZSH53D4D5i8gDkn85xs/4cpLtKxYk7wLSYtwq/quGisw X-Gm-Gg: AR+sD12XDYVJHUtxqid+xxFMxqrIt017zOcze6DytPtrxFYUbJ7fUpFmvzffay5iJLQ oy/bw/taXqF7YWj+qX9hVvvXLUVUSC6d+bHPs4Nm727evV2kHLFfE+tWrl67rh8dO+ANHzFvVmq 3OWxMwGdx19DzuMHOBqZ8EJd2o/vFWu8f1Qr52fzy2hNLGcNAZqYo64ObP7v8KNlMc+hUU4+YFT 1BM8GcjktKuRJRJWR+cgbrRjmOXXeo2cSDw71HPT+ybHG0Am5q+aTilKVYdkd8TFqo+FuZIE9U/ V+3tgcmD4aq65E7JAMbH0b2N0HF+7EXNvc1P7a3cepfVjx3/fSVJgF3HG3AhIMOW9kktd3z+b/t YFu6WyxjwT0Ry5V24NN4qBZ1JTU7cbadPoGIA2H7TzpOm58AAHU7+uwMs1EmwKT5asb/QS3PHXa 0oDrDBmsv9Le+BawBbbPGSUVPXZlDlCyLd9ncbHobv1wjb3redRjGVM0hdalL2Wdppx/utRknYf 0Nn6I8tRznzUsd6HVQ/b4HqlOAEa86glNLF4n5u9iKmjLn76l8TiQ== X-Received: by 2002:a05:6a00:3926:b0:848:4754:28e4 with SMTP id d2e1a72fcca58-851fa060bdfmr53550880b3a.15.1787662672900; Tue, 25 Aug 2026 05:57:52 -0700 (PDT) Received: from nugod-NUC15CRHU5.tail9f095a.ts.net ([218.237.104.87]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8520f03b185sm2937367b3a.39.2026.08.25.05.57.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2026 05:57:52 -0700 (PDT) From: HyeongJun An To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, lars@metafoo.de Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, HyeongJun An Subject: [PATCH] ASoC: dapm: Fix off-by-one check on the second enum channel Date: Tue, 25 Aug 2026 21:57:45 +0900 Message-ID: <20260825125745.932832-1-sammiee5311@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The snd_soc_dapm_put_enum_double() rejects item[0] once it reaches e->items, but it lets item[1] be equal to it. Both go on to snd_soc_enum_item_to_val(), which indexes e->values with no bound of its own, so an enum with a value table reads one element past the end. The indexing arrived with the MUX consolidation, which relaxed the item[1] check in the same hunk. The value MUX handler it deleted used >=3D there, and the snd_soc_put_enum_double() in soc-ops.c still does. Only adav80x pairs a value table with two shifts, and its second channel looks accidental, but the control does report two values. Writing three into it reads off the end of adav80x_mux_values. The core catches that only under CONFIG_SND_CTL_INPUT_VALIDATION, which defaults off. Fixes: 3727b4968453 ("ASoC: dapm: Consolidate MUXs and value MUXs") Assisted-by: Claude:claude-opus-5 Signed-off-by: HyeongJun An --- sound/soc/soc-dapm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index c98e917cc911..06b85313af12 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -3614,7 +3614,7 @@ int snd_soc_dapm_put_enum_double(struct snd_kcontrol = *kcontrol, val =3D snd_soc_enum_item_to_val(e, item[0]) << e->shift_l; mask =3D e->mask << e->shift_l; if (e->shift_l !=3D e->shift_r) { - if (item[1] > e->items) + if (item[1] >=3D e->items) return -EINVAL; val |=3D snd_soc_enum_item_to_val(e, item[1]) << e->shift_r; mask |=3D e->mask << e->shift_r; --=20 2.43.0