From nobody Mon Sep 28 06:32:07 2026 Received: from mta1.migadu.com (out-21.mta1.migadu.com [95.215.58.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55AB1448BAF for ; Tue, 25 Aug 2026 12:57:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787662673; cv=none; b=TRdw/96clZMOMyB/fCh/ztZo5oqEDFbIEbPilfzm5ivS79M26IGKdekc4aFGcfvTH2zI8oQbKg1OgABs7p64n+8pJHsY/3BPOGIj4lM+cm2feB5gtHIzpwHf5LZ7zG1hd6Uic+Yng/qY221x7YtWsUbgzSq6HVvel2brM8EbIP0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787662673; c=relaxed/simple; bh=RQ2tt0SwdsDYCJg0yeBJV/rAXuRLEZbNir4NgXWRYsY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Y8MV5rkvoDUTjLvxSTS/J9chzeJeF+pKZWdrth1peHwRECF+vqaEPWEBh1w8tW8J+XvdMZWv/p6FdkjtWS8QLnR5VISItsf378RJImCJAFK6bzUYJ3C7pGq/sTUnvy482S09QssnTqNB2o91ThGTJosWoAp+1+QOeMWcm36mexE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=odknuhel; arc=none smtp.client-ip=95.215.58.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="odknuhel" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=RQ2tt0SwdsDYCJg0yeBJV/rAXuRLEZbNir4NgXWRYsY=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1787662668; v=1; x=1788267468; b=odknuheldjeMHgQ3zfH0c6KfnmvWb7DTLXt86k4UzX8Wh6/T1N5+OEotuvV0Q6w6yMS/YiVZ uv1Nkq5TrYpYviHnEpehrGlEG6ynwQzqIANTUmxsZM84vXSoUcGt9snpCooDPZ17XYrF9uRHoUq cc1a9dlVWUsCDx20GzeNppDM= X-Envelope-To: linux-kernel@vger.kernel.org Received: from ctao-book.. (223.70.159.239) by smtp.migadu.com with ESMTPS id 05fca96e65d45a21; Tue, 25 Aug 2026 12:57:48 +0000 X-Mizu-Trace-ID: 05fca96e65d45a21 X-Migadu-Flow: FLOW_OUT From: Tao Cui To: axboe@kernel.dk Cc: hch@lst.de, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, cui.tao@linux.dev, Tao Cui Subject: [PATCH 1/3] loop: drop a stale reference to loop_validate_size() Date: Tue, 25 Aug 2026 20:57:18 +0800 Message-ID: <20260825125720.181793-2-cui.tao@linux.dev> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260825125720.181793-1-cui.tao@linux.dev> References: <20260825125720.181793-1-cui.tao@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Tao Cui The kerneldoc of loop_set_size() points readers at loop_validate_size(), which does not exist in the tree. Drop the reference. Signed-off-by: Tao Cui Reviewed-by: Bart Van Assche --- drivers/block/loop.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index 6f12976035b0..68a9cc7aeb13 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -212,9 +212,6 @@ static inline void loop_update_dio(struct loop_device *= lo) * loop_set_size() - sets device size and notifies userspace * @lo: struct loop_device to set the size for * @size: new size of the loop device - * - * Callers must validate that the size passed into this function fits into - * a sector_t, eg using loop_validate_size() */ static void loop_set_size(struct loop_device *lo, loff_t size) { --=20 2.43.0 From nobody Mon Sep 28 06:32:07 2026 Received: from mta0.migadu.com (out-204.mta0.migadu.com [91.218.175.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C0213FFABF for ; Tue, 25 Aug 2026 12:57:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.204 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787662677; cv=none; b=gdJ/NiRwS+0h04QkzODn745D8hNl3gTrUW0OYWWCLqLTNgf2xJ4ktC5iMpQZY2es/uIJcYVprrSUPiNf2vywn0TpMKigRo17Uudo82BYsUViEWunr2L/GFRl5t5JN6MAGie4a8DBjwhv13t/FRfmPJetvR55QczdlzcGyMjwJBo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787662677; c=relaxed/simple; bh=OxunhIeU7W6Dj0Buao+Q4xAPMOSJpjdpYcxluMBtrz4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sxQ2DgeEv83+DOuvWpmC4XWA54gtvZZLe/mb3bs6GMxLAD+IzCyab2vhfJ6GzPbKEb7dPu4/Vnvir/PZiio32Qx42ulkmXZ+BN4vd9sJaU9LoWNXoZ35q7V4rcXFD7Y6AFEMvSE9hewhYA8jwNWjRtsmuOgUemC/y91O7J5r3ko= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=neafaxY4; arc=none smtp.client-ip=91.218.175.204 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="neafaxY4" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=OxunhIeU7W6Dj0Buao+Q4xAPMOSJpjdpYcxluMBtrz4=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1787662672; v=1; x=1788267472; b=neafaxY4wvKG1Gs2QRp1eHovFAOE7mO85aEKJ7VPGkjLyE/dWajkZzAlqKStpF0ElrxxbZ1k KcWvlo0UDLd2KYYIfBgxNSHijLz+Iz6ILuPjAxfLkUSTWtnrDgdTwKUAIKbTGW8Gm+xHZP/kECK FI609gYVuxNZawtWKDTA2rIk= X-Envelope-To: linux-kernel@vger.kernel.org Received: from ctao-book.. (223.70.159.239) by smtp.migadu.com with ESMTPS id 05e8f12338600767; Tue, 25 Aug 2026 12:57:52 +0000 X-Mizu-Trace-ID: 05e8f12338600767 X-Migadu-Flow: FLOW_OUT From: Tao Cui To: axboe@kernel.dk Cc: hch@lst.de, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, cui.tao@linux.dev, Tao Cui Subject: [PATCH 2/3] loop: replace simple_strtol() with kstrtoint() Date: Tue, 25 Aug 2026 20:57:19 +0800 Message-ID: <20260825125720.181793-3-cui.tao@linux.dev> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260825125720.181793-1-cui.tao@linux.dev> References: <20260825125720.181793-1-cui.tao@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Tao Cui simple_strtol() is deprecated and swallows errors. Use kstrtoint() in the max_loop setup code; an invalid option keeps the default and now says so. Signed-off-by: Tao Cui Reviewed-by: Bart Van Assche --- drivers/block/loop.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index 68a9cc7aeb13..8ba146e76a59 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -2341,7 +2341,8 @@ module_exit(loop_exit); #ifndef MODULE static int __init max_loop_setup(char *str) { - max_loop =3D simple_strtol(str, NULL, 0); + if (kstrtoint(str, 0, &max_loop)) + pr_warn("loop: invalid max_loop, keeping default\n"); #ifdef CONFIG_BLOCK_LEGACY_AUTOLOAD max_loop_specified =3D true; #endif --=20 2.43.0 From nobody Mon Sep 28 06:32:07 2026 Received: from mta0.migadu.com (out-208.mta0.migadu.com [91.218.175.208]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51DD43815FA for ; Tue, 25 Aug 2026 12:58:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.208 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787662683; cv=none; b=huw4qLq5BFyE4zECsO1lQparvmCdjTxpE2tTdqTb0qKAdrKb3PqmF1VyxPeqZElw1uk3hmCSoHLIZDwq+bMUAISutoZ/VTMHvoYqK8V9o2uK58OSuJOGEQFkoxe/6fyCUXcYp2DZGHfA+1avbUYujFUFx1R6RvrFpOXo8/TJigE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787662683; c=relaxed/simple; bh=1YPYm6TwcZfy5y0h7vMpIpqxKy7QKXtsLrVb2wLMlJU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=i0yxfYKmdQgiafeYygQyTU5m7LgkG6AJiCMFTHKQpezd23yjbYDON8K7IYN79HMbyAD3Q+c3tDYoEg4AN1Osgp1m0Ikvaobxt5v97BQ//SvSVddLmqsmCxYyjqO/HQvXiBT32JxpFeI2xOZO972dxUgoP3Fi8N7MFK7nAy3XT90= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=wMjbQkAM; arc=none smtp.client-ip=91.218.175.208 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="wMjbQkAM" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=1YPYm6TwcZfy5y0h7vMpIpqxKy7QKXtsLrVb2wLMlJU=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1787662680; v=1; x=1788267480; b=wMjbQkAMc/18lGb2cSoaJmxH11xv9oJN4kKEgJCGZFJ9cgfPyQ0hxr/9hYTEzaErmc/Zafoj gCaXAt7HH8jGtT4V6xlqXTDMLzcdnm6kVsCb3Fdk8aIi/soP/V2/aO19z9ivn53Kq8SXI4lJUJZ XKziGct8Em8oJJkRgpBD5jQ8= X-Envelope-To: linux-kernel@vger.kernel.org Received: from ctao-book.. (223.70.159.239) by smtp.migadu.com with ESMTPS id ac232629fd2da2f1; Tue, 25 Aug 2026 12:58:00 +0000 X-Mizu-Trace-ID: ac232629fd2da2f1 X-Migadu-Flow: FLOW_OUT From: Tao Cui To: axboe@kernel.dk Cc: hch@lst.de, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, cui.tao@linux.dev, Tao Cui Subject: [PATCH 3/3] loop: drop the unused argument of lo_req_flush() Date: Tue, 25 Aug 2026 20:57:20 +0800 Message-ID: <20260825125720.181793-4-cui.tao@linux.dev> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260825125720.181793-1-cui.tao@linux.dev> References: <20260825125720.181793-1-cui.tao@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Tao Cui lo_req_flush() never uses its request argument. Drop it. Signed-off-by: Tao Cui Reviewed-by: Bart Van Assche --- drivers/block/loop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index 8ba146e76a59..e7d16e5961c0 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -270,7 +270,7 @@ static int lo_fallocate(struct loop_device *lo, struct = request *rq, loff_t pos, return ret; } =20 -static int lo_req_flush(struct loop_device *lo, struct request *rq) +static int lo_req_flush(struct loop_device *lo) { int ret =3D vfs_fsync(lo->lo_backing_file, 0); if (unlikely(ret && ret !=3D -EINVAL)) @@ -411,7 +411,7 @@ static int do_req_filebacked(struct loop_device *lo, st= ruct request *rq) =20 switch (req_op(rq)) { case REQ_OP_FLUSH: - return lo_req_flush(lo, rq); + return lo_req_flush(lo); case REQ_OP_WRITE_ZEROES: /* * If the caller doesn't want deallocation, call zeroout to --=20 2.43.0