From nobody Mon Sep 28 06:35:55 2026 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 765BF3DD846 for ; Tue, 25 Aug 2026 10:42:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787654550; cv=none; b=olXNLqPiv4FNM5IJIjqIBKSLQYdrb8bJHTVqQNHPC8s0VM36CmnkjZfJDr2aZrbkT3NjP0wco0GY+/DaZumzEA0save58s4OcCK3qmtqmW07NZS+dy5hOe3ywaxHGfy+oc6qVawW/XjeEdwJ92EzqkHbqB9Hj1pVWFFwQ1t8Dk4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787654550; c=relaxed/simple; bh=Qc/c4yoXKcp4ee+/wB1jctrJSzgKwXVzm3vCcrwBcSM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type; b=IEJ9C0nfqH5Vpxlpifor3QBRvqOI3YLt/1h/E/fQn7Ug0ZGrqPa7NITQgb7zOnnYdkjq6YupIJpm07ClpRuXBi+AD0aM0+u4kKmTejjABUXqMYmfAQ3j8ZVzThljefjIABURlQQgNzWLYXHTh2ABpAd0xT4dQ0ZYPFbP4Jp/UFw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=QG1QaBZ1; arc=none smtp.client-ip=220.197.31.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="QG1QaBZ1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version: Content-Type; bh=INQWhOLIhCHtGcOk61iUZgio4nHSvbrA+EjdpS+Q3u4=; b=QG1QaBZ1/aJAwqzXly255zuecOKv5Cx3uViQ6WYkSiijtdFYtrKDTYJuNU8vbP ASwEj8QCtF6rebGcjAjt7MTsA1CAOzHQKFglwKK83D9G68xem4PtqhE8WUDH1QG0 ZiG3dv5DTBj+vGcJu+FWMSM8RTDoXVYeyBQ6JMS1o7Cx4= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g1-3 (Coremail) with SMTP id _____wC3t_9OcY1qa+IxPg--.45577S2; Tue, 25 Aug 2026 18:41:19 +0800 (CST) From: oushixiong1025@163.com To: Thomas Zimmermann Cc: Javier Martinez Canillas , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Shixiong Ou Subject: [PATCH RESEND] drm/sysfb: Fix atomic_disable to use dst coordinates instead of src Date: Tue, 25 Aug 2026 18:41:17 +0800 Message-Id: <20260825104117.667943-1-oushixiong1025@163.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="Add_By_Label_Mail_Nextpart_001" Content-Transfer-Encoding: 8bit X-CM-TRANSID: _____wC3t_9OcY1qa+IxPg--.45577S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7WFy8tF15tr47uw1rGr1kGrg_yoW8XFWrpF ZrG34q9rsYyws0gFWDCay8try3Xa95Jw4xKryrCw4S9wnYyFy3GF1rGry7Cr4UJrZ5Kw43 ZwnIyrWDJ3WFka7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jnBMNUUUUU= X-CM-SenderInfo: xrxvxxx0lr0wirqskqqrwthudrp/xtbC-g9tfGqNcU9HWgAA3k --Add_By_Label_Mail_Nextpart_001 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain;; charset="utf-8" From: Shixiong Ou drm_sysfb_plane_helper_atomic_disable() constructs the clear rectangle from plane_state->src_* coordinates. This is inconsistent with drm_sysfb_plane_helper_atomic_update() which uses plane_state->dst \ufffd\ufffd\ufffd the destination rectangle already computed by the DRM co= re with panel orientation applied. Use plane_state->dst directly, matching the approach in atomic_update. Signed-off-by: Shixiong Ou --- drivers/gpu/drm/sysfb/drm_sysfb_modeset.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/sysfb/drm_sysfb_modeset.c b/drivers/gpu/drm/sy= sfb/drm_sysfb_modeset.c index d2de29caf89e..18466de886aa 100644 --- a/drivers/gpu/drm/sysfb/drm_sysfb_modeset.c +++ b/drivers/gpu/drm/sysfb/drm_sysfb_modeset.c @@ -380,14 +380,10 @@ void drm_sysfb_plane_helper_atomic_disable(struct drm= _plane *plane, void __iomem *dst_vmap =3D dst.vaddr_iomem; /* TODO: Use mapping abstract= ion */ unsigned int dst_pitch =3D sysfb->fb_pitch; const struct drm_format_info *dst_format =3D sysfb->fb_format; - struct drm_rect dst_clip; + struct drm_rect dst_clip =3D plane_state->dst; unsigned long lines, linepixels, i; int idx; =20 - drm_rect_init(&dst_clip, - plane_state->src_x >> 16, plane_state->src_y >> 16, - plane_state->src_w >> 16, plane_state->src_h >> 16); - lines =3D drm_rect_height(&dst_clip); linepixels =3D drm_rect_width(&dst_clip); =20 --=20 2.25.1 --Add_By_Label_Mail_Nextpart_001 Content-type: Text/plain No virus found Checked by Hillstone Network AntiVirus --Add_By_Label_Mail_Nextpart_001--