From nobody Mon Sep 28 07:19:42 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B8A93DB63D for ; Tue, 25 Aug 2026 08:13:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787645605; cv=none; b=jpLodlp9TrtN4+2o7rn3YSC3jb0V3NGOW4tx6uFVHzOBThBLWk9SgHGIiJu9wSNMxExtenBAeOA5O4lwI2iFkokz24UAfpEIqsTDnOumpGLG1rwfEz/9Q4LOvWfrtD6m/xrlFVCay9mVMLF5Vi+oTpRc2MWasXYxHDspG3OmtHk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787645605; c=relaxed/simple; bh=QQ4Mp+MQrZ0abZOXlL4Gh1EJOdpfUwc8kPhdt3VDwl0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=FXfTX6fC6wmqD0PNfjB2uVFmD/TgaiJNHqKkLXyqghWWMyfeB8RDXDAah43+pfnq8MFNKHAYMYfVIkVyPQDZdi1W/0fXuhigEK5Kb9CfEY4C3Cbw0Ua9Hg7d7Grr8NgZRr+nnoueGdHmaP8JxNPzHWQC4v3XVDrtBITX+yDgP+Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mPyjSrU7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RUevpzYh; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mPyjSrU7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RUevpzYh" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67P896Q5878137 for ; Tue, 25 Aug 2026 08:13:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=hv9r+64K3KZer1HaUJU7uPLWJOybOoMeHi6 liK+PZew=; b=mPyjSrU7iaatxis04yo5xMJkEkXPAJr+nnE5OHTt8BYiDLc1cZR EOSgU/rOYvIeKSZRChpG/pvhq12tZ91VmeTqt/MxIm/blYeAIXBeb+AxL+P48sFH aoUwKwMWNLh4N2e/L74VXobdgEFb0B5PSsjoAOZnLMLptIjYRXAZipbgtvarTkKc uk5WxTYMAq0YSkcp1JUXnUCdWfav1XC6jfIw09eIaeVQ683rfKAQ7b3E9D+ZADF4 uG/XAPwegx3i+MMndXMa7XyTvRTxsbyTmS5nBDGoxPMqkIi8aZFclObGkckmpJvn gXuFucvE7yM4ersiW17v/NaenmPNdSpJXqQ== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g8rqukafb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 25 Aug 2026 08:13:23 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-904ee4473a8so37525636d6.2 for ; Tue, 25 Aug 2026 01:13:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787645602; x=1788250402; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=hv9r+64K3KZer1HaUJU7uPLWJOybOoMeHi6liK+PZew=; b=RUevpzYhOcfCWE5kPDOzQCjlELq5P70931+QgTBOHaFGMkLHQhJARlYtYdPkrgdtaX RJoVxx8ceW0OnT6nQSQmJFtzpc29EfJyJouvU3SPrhpWBfKtbmwaCj6MD1g79MNlqZ76 gSEFah+spLGQISOmv445JhINnUy4Gl7OAYn6VDbi9TiKqxmwsu/3MFM7xqX2Zo/0DhvZ /XDWZILZaCKl2hm01Vs7h+BJyTUlJsSBETJkdj6ZP7AFommkoUvNCY83CzO4ZIB931mr cWl65tfT/E2fiEwUiB/xFbYHcj1uQ8YfjudUG4c+FlMlNpBHhdi3WxumEeaY7NtaivQu mslQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787645602; x=1788250402; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hv9r+64K3KZer1HaUJU7uPLWJOybOoMeHi6liK+PZew=; b=snaV0TcuGEqBK4SBqTwhAf2DNqn8oVjFaCniFtEORV+oa4PVQ5zOlmOqJ5hSPyFPJk RzrRYa2XlFZCb+wSkCoXvUdYQwo9g147TsicVv73D+8SNpWwlZywtdXG1qXhVWJDF9Fl qvAAfrGkhkblKILERz9jX5Bww1yiJIbGr05mcz7KbhliEZ2vl/8QgI/otc9FN0vuGTVj L4o/AAAMcpNcMQOLeXKxIrxabtk7EelbNbMIVaAx6Yzxto3CW4icIO0CU0YClsISsTQN ubwt+O4H8mabj2FF5uj6dNyC2MqZ/mafEJqASKAe9Yiec8a21Tm1nfG37vVgOtP6PjzR GKwQ== X-Forwarded-Encrypted: i=1; AHgh+RomWgnH4qWYpzKPLYZh7OcDsqgHzPO6qx9LAr/TfhwlnrY0UXtFbD2ZJOzYY0vKyWrBRMPURJqSkCYamYQ=@vger.kernel.org X-Gm-Message-State: AFuF++kdIAQvEVnVM/gck3v1Cw3k7+MP4ZOyrQLvUSsG5RdeImM6xcOL I6fVMeQDwrMXDmBgeLpyETtFf+0BAB9W4YPq9lZi+FmV41Y7mLR3Cqf24aEcm9newRqWj/vc2vH nciQRr6KoUFBSMu69l7pXHktBFGj0fmPw6kcwn9W7+B3g4eyvLPTp3c08NVitpxxHkZg= X-Gm-Gg: AR+sD12pLy0yrW0IxaWP+38o0elhNxZzNB5iBDouBtB7Og/7/HHWl46SqZZ2cPYsxbu gn11i9T/Sq3+xj1rjhKSDAfM3SdCi/AtRqJYiaqdHG62f3g10OZPbEparCl+/xa5m2hgRdwHkqW rrC/d8EnXHndwut3uNO/W5QlXA1U76LZsqTInyYDOcdfGJ7DgiC05D6tEohvpjqYxcyICrMb9Wk QJlGf9RoC42i5HWWmAL5+yzyOI2a4na5ZaRC+BOJvFkAvcdt1AQPBbtw/D/mTL4uK49U5E9JS/o Ilq1au4mVqyJANQsiIIFgfS/CElWssHwBuJ4xaUVBHypHzqSJaNEs/IBVwMvsqSEF3GjK2n22OY yl0xCUmDz8S87mVc= X-Received: by 2002:ac8:5f53:0:b0:52d:6afd:7db5 with SMTP id d75a77b69052e-52df59ec0d3mr344910531cf.25.1787645601935; Tue, 25 Aug 2026 01:13:21 -0700 (PDT) X-Received: by 2002:ac8:5f53:0:b0:52d:6afd:7db5 with SMTP id d75a77b69052e-52df59ec0d3mr344910221cf.25.1787645601382; Tue, 25 Aug 2026 01:13:21 -0700 (PDT) Received: from quoll ([178.197.219.214]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c249672becesm1687582866b.42.2026.08.25.01.13.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2026 01:13:20 -0700 (PDT) From: Krzysztof Kozlowski To: Jeff Johnson , linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH] wifi: ath12k: ahb: Revert undocumented ABI and dead code Date: Tue, 25 Aug 2026 10:13:14 +0200 Message-ID: <20260825081313.71351-2-krzysztof.kozlowski@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=3254; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject; bh=QQ4Mp+MQrZ0abZOXlL4Gh1EJOdpfUwc8kPhdt3VDwl0=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBqjU6ZmH29I4c1VwrnjgwykypA4ZmZkqL3qWwfl reZhLKS73GJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCao1OmQAKCRDBN2bmhouD 1ziiD/45tKK4t4NoPjGQYgAtqj4adc82l82kkAMngH2NL7E/kDcnYCxrDWaafpAzJTp02bwCsWA 7u9eaizT6xEKeG+y9bDo3lr/YvEaVSJ7bDH1Qzx8aaMWPl8GNM6xb4NqpPrca3L5fUHawOVjtCt Iy0wMTsx0NfUeCWmLOyRooSf+zTlFAFlFl6IvApkQeOwrFohCdGKaZ+cV9VPSL5Gu9LOZLqZi0H 4U8L44j68gY6jyybO+RXaSLTy4qg1nBrFCs1AAl1/1CASnZZ2rIIkt7rNz1NxYaXnGC14SvcbHU zAsvVkDCDN00KuZNVc1Yaq1qs23PHelxcOm9/XakIklZMtkMM7y+9gty9GXXChBAwtWrul56jQR Nskx1sxSFoMPAn8fk0t1yle1h7751f5nKKIzmb28nsF7W3yumsOfGwHyoZwSYVT0H8x79lKj+yb wEKm8XhbjWjyEWazPIgTZuseVmVwrFiJRAuIvAhMDTM92ggo+8JV9OLBp3WGHqCpLcCqKBuZJVb K0Dw/xkYdlX0ruTO/DIGLslbmUju5FnOvtXSmNPaP+SvNM3WtE6TlGRl4buc+Ff0w+UYw0++3R7 s+3W9CYaGpzlBvYDQwm7inXm15q49zNKvxrkxsOxKIIKdwHHEIEmIe2pUoe8AG5PdM0xAFRzQmW KQlKrpcbHCxZrug== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: _2CActhxHy_slybYCglqweAqfqUt0xVm X-Proofpoint-Spam-Info: AW1haW4tMjYwODI1MDA2OCBTYWx0ZWRfXwHEJZ3guRToQ vLXmqtdv3SqQn83eVEi7TbWRhmmKKoMvksR/4GLgdVx7zIHpQmgaTRHIo1H2eFLRMBhQbV1qid2 yls6xeQnv8ACCstB1PTUWo08iMCL7Do= X-Authority-Analysis: v=2.4 cv=CbQ4Irrl c=1 sm=1 tr=0 ts=6a8d4ea3 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=+bKQE0WJfmhK2875HamI0Q==:17 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=Rjp3qrauO7Pr9jUhhQUA:9 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-GUID: _2CActhxHy_slybYCglqweAqfqUt0xVm X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI1MDA2OCBTYWx0ZWRfX7roDaIBSby2K BPqqB7TuVmMjFZIYfjXr1nzDG56CvB9WkQVDiW6PyfLpeOG2p19dR1MZKlyqAJFHM2x2ncrZbRk Rg+VEfQkoanF6R/QE0ME6aJFWsGXQZ9XuhtL2MlTUfnzJoFjxWiQ8PmoMGpNdwILCN/CftsQfY1 FrqIm555EOTSwHCuItyCdKUuR+jKkLb7aFoUhyDTvUeAxEAarfesfTfjId9/2Z+zmslwfF35mZD B3jsSIVlzJND6Md7CTbcys2YRqkguRJedJl/zc5HOgTS9z2ZCMV6E0C5bjvW86yAYqUyrUgeblH l6we44Q8o/tEJszvOLzPeCfGTapGQ6zPfH8XzGzMjuuoVxWOHsHtMfzdKm4zpkV6iKelQRZVN/L vmVwnunQbYmkdR5EOd/ieepd2TpJ8GRs3grNdNiDCApWF6pOytlWI2vGeO1KkAiaCNaZZVYBfrJ OtIFVDJNa25KVKb+hfg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-25_02,2026-08-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 suspectscore=0 impostorscore=0 malwarescore=0 spamscore=0 clxscore=1015 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608250068 Content-Type: text/plain; charset="utf-8" Commit 96f46607bbce ("wifi: ath12k: add AHB platform descriptor support") added undocumented OF ABI, by relying on a very specific node name. This is not allowed and was never acked by Devicetree maintainers. Additionally that part of code is not even used, because all devices have exactly the same user pd, so this was added "for future". Adding dead code just "for future" is heavily discouareged in kernel coding. Signed-off-by: Krzysztof Kozlowski --- drivers/net/wireless/ath/ath12k/wifi7/ahb.c | 51 +-------------------- 1 file changed, 1 insertion(+), 50 deletions(-) diff --git a/drivers/net/wireless/ath/ath12k/wifi7/ahb.c b/drivers/net/wire= less/ath/ath12k/wifi7/ahb.c index 98a6606ffd76..6e9e9034cba1 100644 --- a/drivers/net/wireless/ath/ath12k/wifi7/ahb.c +++ b/drivers/net/wireless/ath/ath12k/wifi7/ahb.c @@ -15,21 +15,6 @@ #include "dp.h" #include "core.h" =20 -/* - * Node name to UserPD ID mapping - * - * The io_start field is used for additional validation when the reg - * property is present in the device tree. If io_start is 0, only - * node_name matching is performed. - * - * For platforms where not all WiFi nodes have a 'reg' property, set - * io_start to 0 for those entries. The driver will match purely by - * node name in such cases. - */ -static const struct ath12k_ahb_userpd_map ath12k_wifi7_ahb_userpd_map[] = =3D { - { .io_start =3D 0x0c000000, .node_name =3D "wifi", .upd_id =3D ATH12K_AHB= _USERPD_ID_0 }, -}; - static const struct ath12k_ahb_desc ath12k_wifi7_ahb_desc[] =3D { [ATH12K_HW_IPQ5332_HW10] =3D { .hw_rev =3D ATH12K_HW_IPQ5332_HW10, @@ -55,40 +40,6 @@ static const struct of_device_id ath12k_wifi7_ahb_of_mat= ch[] =3D { =20 MODULE_DEVICE_TABLE(of, ath12k_wifi7_ahb_of_match); =20 -/* - * ath12k_wifi7_ahb_get_userpd_id - Resolve UserPD ID from DT properties - * @ab: ath12k base structure - * - * Returns: UserPD ID (1-based) on success, 0 on failure - * - * Resolution logic: - * 1. If reg property exist in DT, get userpd_id from io_start - * 2. If reg property is absent, get userpd_id from DT node name - * 3. Return 0 if no match found (probe will fail) - */ -static u32 ath12k_wifi7_ahb_get_userpd_id(struct ath12k_base *ab) -{ - const struct ath12k_ahb_userpd_map *map; - struct resource *res; - size_t i; - - res =3D platform_get_resource(ab->pdev, IORESOURCE_MEM, 0); - - for (i =3D 0; i < ARRAY_SIZE(ath12k_wifi7_ahb_userpd_map); i++) { - map =3D &ath12k_wifi7_ahb_userpd_map[i]; - - if (res) { - if (map->io_start && map->io_start =3D=3D res->start) - return map->upd_id; - } else if (map->node_name && - of_node_name_eq(ab->dev->of_node, map->node_name)) { - return map->upd_id; - } - } - - return 0; -} - static int ath12k_wifi7_ahb_probe(struct platform_device *pdev) { const struct ath12k_ahb_desc *desc; @@ -106,7 +57,7 @@ static int ath12k_wifi7_ahb_probe(struct platform_device= *pdev) ab->hw_rev =3D desc->hw_rev; ab->hif.ops =3D desc->ops; ab_ahb->scm_auth_enabled =3D desc->auth_enabled; - ab_ahb->userpd_id =3D ath12k_wifi7_ahb_get_userpd_id(ab); + ab_ahb->userpd_id =3D ATH12K_AHB_USERPD_ID_0; if (!ab_ahb->userpd_id) return -EOPNOTSUPP; =20 --=20 2.53.0