From nobody Mon Sep 28 07:24:46 2026 Received: from mx0a-0064b401.pphosted.com (mx0a-0064b401.pphosted.com [205.220.166.238]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 021623D6CC1 for ; Tue, 25 Aug 2026 08:00:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.166.238 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787644858; cv=fail; b=eyPcOcNsff1bgzd4T7qi8eWSSCYpuVq1Rnce5y27ac+espz+BIG9YtZeXxltmX1bwyhvjICbhxDtZisu+el/NhWLdOL4/p28SP4rgop0bJpYVxN3Ec5C/4BWDxvxV3UBbbazxfjxbKFMzEE769DZesKUCV55sLEkV2GwppnGNUI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787644858; c=relaxed/simple; bh=WKyapWmlQ+HSA+VmL/EEeOw7JfXz/NV/nEnoF+1EZZw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=hOPu5QD4+i2bgJx5wbo06bP6WfAq7gFAvmoUMYiX0F2s7RyEoRbSebhhhr/lOm0RxZYyEfmuyfT0i2b0bBI/aWvvUOqFj+TPUyWKuxqhIkmkK1C3maPd8x34ANvbP7Iiq0va9TScQ3fa7DEWL3hmy+dOe3ni7ozKQv5YCWfzgyQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com; spf=fail smtp.mailfrom=windriver.com; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b=OSlwPrdC; arc=fail smtp.client-ip=205.220.166.238 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=windriver.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b="OSlwPrdC" Received: from pps.filterd (m0250809.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67P2Uqmd458899; Tue, 25 Aug 2026 00:51:07 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=cc:content-transfer-encoding:content-type:date:from :in-reply-to:message-id:mime-version:references:subject:to; s= PPS06212021; bh=h21VkAGZMP/1om2arl4En06T9IBzQRIZYdwAia9quKs=; b= OSlwPrdCANyNq11PRm6Hmov/3O7zqTf/F3L5ind3sgeDfk7BrLguC/c4QmQv0iDV RqqOLWeQk/9+JfhnY4c4wKnQPnap+Ur1opDD7wrjpZd0bac52Iko3V+QFpbwvWHj jWIOpp1cIe4c05xDpcTaK72dC6FAOZMBswtw63ZkFMbTnoswv38OodigyxnQXKRK 23mQ+Z2tXx6s1XFYYtjdZ3ojo6zH/UZgo1E5LsB1YULOfOM8nGE0MF9moeyMQe8a jBFKxkWF3n7tyzMttwcFT+swCLt8T1hm/dr316W5Cj1JHgJkUPKLNmnkscdKWFer 6h/N6b6IwIxKnAMl1lcGUg== Received: from co1pr03cu002.outbound.protection.outlook.com (mail-westus2azon11020104.outbound.protection.outlook.com [52.101.46.104]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 4g7b9gky6j-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 25 Aug 2026 00:51:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YEQbp0Xu6wYQ12YuZJvW5nD6slRbEGWMZW5n/iE01iYigHCl3sIiv0Syggv5wK0e2V73OJzWG0QzClP6ETWJyPDXd3YjJaBw3jSiPFwmEYHre1savAdRaV3V4y0SN6NmPOCfhmkfgNbS3KGYPeNgoz4OVP5zSWO05Zxhs7hktAkPLGr/Fu6/qBWtgzCJufRMjFaNgh7vGTOklBwBGDBvdsD9FxiHPOTLWKtuzHjnws57JWHDOgcPzsLEkwJj98ManrYs2ZEk1QMpcQmrC8iYySTrcJZ/K+FmERkNu4sfNjW3jIAxWg9FRe9TJST+t8f+wb8iyKGDm6pZfhea86eRLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h21VkAGZMP/1om2arl4En06T9IBzQRIZYdwAia9quKs=; b=XS/1BIOvsDzbRqn3A/yCOHPZlvjwcXl7uuzpa3ePt4Ey5Ls0Zzgj57IVq3qXlKMr+m3J/PzA4JGgnwDumfUtkNUSegTdHYHX6hJ8peB6Cii+72J7t20/fS3gkHTnLTBZ7hP+MsegddsAJnTicWBGnNTX2DjDEDIEByvVMsZ5j1cQ3F7EotnX+wBhJoLT08OgJNoksc5brYXkzWU+70Q3ZqUUaUykQe5AMonZkXdpZEUa8AQx1lHdQyYNXV6vesEz093kvVdFxm5nDNb8nJNaF4npisXGzuLeU/oz4pdBqzaEyT6NWXY0qZymMpkDg06JQ9ichQ+U4LfMpm+8Nx8jbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none Received: from SJ2PR11MB7546.namprd11.prod.outlook.com (2603:10b6:a03:4cc::8) by CH3PR11MB8441.namprd11.prod.outlook.com (2603:10b6:610:1bc::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.12; Tue, 25 Aug 2026 07:51:04 +0000 Received: from SJ2PR11MB7546.namprd11.prod.outlook.com ([fe80::ca9b:dcf:8881:bced]) by SJ2PR11MB7546.namprd11.prod.outlook.com ([fe80::ca9b:dcf:8881:bced%3]) with mapi id 15.21.0339.012; Tue, 25 Aug 2026 07:51:04 +0000 From: "Ionut Nechita (Wind River)" To: x86@kernel.org, kexec@lists.infradead.org Cc: tglx@kernel.org, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, akpm@linux-foundation.org, baoquan.he@linux.dev, rppt@kernel.org, pasha.tatashin@soleen.com, pratyush@kernel.org, ruirui.yang@linux.dev, eric.devolder@oracle.com, hbathini@linux.ibm.com, sourabhjain@linux.ibm.com, ruanjinjie@huawei.com, include@grrlz.net, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/2] x86/crash: reserve elfcorehdr for CONFIG_NR_CPUS, not CONFIG_NR_CPUS_DEFAULT Date: Tue, 25 Aug 2026 10:50:42 +0300 Message-ID: <20260825075043.42041-2-ionut.nechita@windriver.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260825075043.42041-1-ionut.nechita@windriver.com> References: <20260825075043.42041-1-ionut.nechita@windriver.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: ZR2P278CA0014.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:50::20) To SJ2PR11MB7546.namprd11.prod.outlook.com (2603:10b6:a03:4cc::8) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR11MB7546:EE_|CH3PR11MB8441:EE_ X-MS-Office365-Filtering-Correlation-Id: 6be61619-adc1-440d-f791-08df027d9d75 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|52116014|376014|10070799003|23010399003|1800799024|366016|10067099003|56012099006|11063799006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: +x9CtpMN6uM0b/3gdrf8xQs0/Sb7hXDXmEChTxYKA3GvuX/+7GvZYvzTFD2SM5vJWD+dCe9vv3Y3+oUEP6ZS+slHb8Acky8s7qD0ulN7jm9DRhPTM+ID9wG82yUCV9gQ7sUIsoDT2YHBhytvJhMhDkgs6ql4BhalGgcevY0oT5U3c9XuPECYD5eyryt0BG8WsfreMlflMxxuxNEi8wCPTsKcEAuPCBmy/dj0A79ugey3oYqSBMPwDtqHCZx9kfTxuvxTiu7YPKw3pKpGMSiMheLXpob74+EsscxrnaM916NuRQGo0urDL7zpf+hJsw7MFJth/ynRArZwUai3uGhVX+WZo1rYZJJtMZC6qJbqp+s2t7QqR4LP7LwHDj27DNW/Vok4wr70PkIW+01q/EmDOoEXO1ccJRB/nJpVu8zJcP/ZMzCECHe7skv1QcOf7stJu3OdN5Ju8ilt7NJXGQKg3avp/witj73H5+MbFgLg0sFoUInKtJktGzQ8NRTUD9z5ClgbyNDccsUIBvJ3po1Grf06CeZkTMypMoyGOJ+V8UQh7GfOlH7kOfwGaFlzbumITAxA2G1A90SNO3EeM/SRcouYxc2Q9B/7zPq16XBcxbv9Uj9YZ+fgxNmUv7irPn4nAJl1lKvK9gyKnI5Y5flbeoIYh4t2YTQd0bLi7Au3JLU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR11MB7546.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(52116014)(376014)(10070799003)(23010399003)(1800799024)(366016)(10067099003)(56012099006)(11063799006)(22082099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RP6mpnVBpkk9fg5+PQV/ruWEQdktu734kSoaV3fKee936CWmMgX3IGGLxg0d?= =?us-ascii?Q?5upxvzhJEC6gkY/Yw5JVIMKXog88ZcCFwTZWwxEKqqQRXqaf+oh5e4ETezmc?= =?us-ascii?Q?IAlqErEDNQN7Jhlf+cVVfCz4oxXh9HxGEWZiQfmrmLSri4V72+u5ZKbBvUaZ?= =?us-ascii?Q?1En2Lb7iCGaw7QGFyRiCZ9D8CFlIUaJauzJTXGWefD1Mt6uxQogIYZObuhC9?= =?us-ascii?Q?LZGsNYfsWgqSP9OEYLU7R212GUUMxTkmFadgLfg7TW4GInnYWll0mYuZg5IQ?= =?us-ascii?Q?ZrUOE+Alg+MyrXMCAbKfQbsOquCDayR3EKc3FRi6r5Vsqc6QpkMsDl6b/O5G?= =?us-ascii?Q?FV110DbDi7va4eWn7GA2b61JobbWao4ZPjYMfQ57tAJyLT0LC0Y/7rtaeFFd?= =?us-ascii?Q?+dYuCHfpVwG9Ca9Ef0QlgWa19xEFMuS3m4In1B3sh7LL86p8ZCMExg+0ypSx?= =?us-ascii?Q?upqQ3v7gJrJGv+9lCiefHGDB9wlKEX7z1UdSdGckKvfbegAb7eJ8a/qHWvP+?= =?us-ascii?Q?mBu7Ct5Ndvp2GUalRk2aGVnNpPJmkiEAWbqGRCqBcq9OeBvQyfXGU4ZbMF0W?= =?us-ascii?Q?/2jFtgsHoY1ZRwmeW5uRFLB/hnMdvFmGqOPKEogbiDxgbPEnDxxFzu1W6mAS?= =?us-ascii?Q?Lvbfg/93ZCRErjFbTOWCwTIQnuuARPrEFyQW8gj+lkZzbT7X55AbLo/JDcX1?= =?us-ascii?Q?ysBo82nCbYLLWqWD7/00wETxlOPM15gwl02kBBkG0R5yo7X3GIqZw/ldNRpy?= =?us-ascii?Q?MziOb5FNxzTTIkJUEObxte/YLPWafT0LUSA1lqOI/7aV7UzomeQiUS6FD8Cz?= =?us-ascii?Q?YlWAw6HyZt2pzVjqwpKNTinAs3ghFfw9LW+X8PIUzxPz+B8iDjyx/WHuwmer?= =?us-ascii?Q?vSStUO8DcEExm1DgJVm1M2baqnDGB9U4UioIqzTazcMcgINVXGnBKDukzCwo?= =?us-ascii?Q?boVL3yFwq7fhSyYdsQQyqy9dckXz2HlX5rX6EoFgQRJu9mBNwXdDqbuL3jVb?= =?us-ascii?Q?KV9k68sHUps0ONqfpGVl9uT2XW7dph0pR53E1LzalFyCvnRIawoCem3K2oow?= =?us-ascii?Q?aP5sYfC4DLGGTvLFEXy03hLPqHpPxO1Hfj6IgaJ60+COVGfGJHZ8fjcm0qQ8?= =?us-ascii?Q?GQGqp4EmbuKGHxR1gWTeZB/zjeFNBBy83UZkV9l6etqMjyRh2p3uz9xZWd3t?= =?us-ascii?Q?k+dmre/tw86WWPbrpE4/O0OsX96RtqnhrnJNbIWpYducELmCaSK9bECk1Kz7?= =?us-ascii?Q?W8zpPezpBgdMDDBKQeg5lD47hgokwmqn0Gl9ZDyBlknyJ2veXkp30wrxbjXv?= =?us-ascii?Q?9wjOpx+cbdXBb7b/ina01yEt7zEyvQY/JI+EgZfFDL9IKqKzZNHoVJdKNikG?= =?us-ascii?Q?0Y4e7rA2EdbiTtDHM7LkmnDV8/OZerHT9ltLveDTygYHdyUdVQ2AZ5sIF4je?= =?us-ascii?Q?nkaQBRPNZLQglD1fcBR6ehKIBVOSEBe8PU88IpZ19TdmO82el/HAH9HgvP4B?= =?us-ascii?Q?9wunJuArjAbE/6SPMhQ8zJ6iShSEV7aQbT4E0vvWbnunYknzdyYlvMQaDSTX?= =?us-ascii?Q?9HtpyziX0J0JWnbtqnifU3KzF0NTwzBUhiN3nbYuqXiDkNTfNLpeygXjp4JQ?= =?us-ascii?Q?fj+8Lif99BoaQhdAPNEDxmQ1BYSpFW1GbQL8NV0/DO8hIfcen/IFhjKtIZv0?= =?us-ascii?Q?pVbAEM09D/N/76ZJotNrjbJEcA+q9OZl82knCMtIiGHICAA3rILcesz2ScQ9?= =?us-ascii?Q?mRzs+oCxoK+9Vyzyi+jfyxFihN05LDd5NtPoJQBuzYPIQWVgcaL9IMaqVgeH?= X-MS-Exchange-AntiSpam-MessageData-1: 7qWdsXvrRe9+2BFaW7mHwNDK/pROSfBVma4= X-Exchange-RoutingPolicyChecked: KlWx9+OguaMFT1aYxWwojF5IgzOrLKFrRc2g8dLAqyF7TF+KX4SJX9DhCb/dyevVKPrKfhlvnVcbbAZzAH/ZDaEJtK1j4LtAViuj1jDJZQyu/kDULOryEzhSkcCK0K4DZ7lxkD4vLJ/ViLYVspac+bYCnYnRAgcFn7x9tg/qq7rnnIJsOMVEztmTz6RloKZUT+AgetwJwavfTVPUiv0lqOLT05xwUgI3t03c9Rte2UOPNPnuNxNoeXPuxURVP1jv1uQL8VD4hC0A5VAvzi7mk3kCr7NXjCkDpFYQh25im11lWtAxmlMefITWL7fW6gunGgFnTZ6UcdcirBoTSylbnA== X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6be61619-adc1-440d-f791-08df027d9d75 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7546.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2026 07:51:04.7939 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ScKY2Fsi7Q/xEho7oi/6qxhTZCrGxGfJtqmxTJrsb0IH+CpAdlESY2ui3+2V5uK55zvvnQOeKFeHI7fuEb2MTzeP73A8wJ8wHiJZENp9Jng= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8441 X-Proofpoint-ORIG-GUID: qnV3ZPlG_NlukSnbZjP-Ncr0rIeU7Xpx X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI1MDA2NSBTYWx0ZWRfX/iFh6IRDzi3P M0f/0U4TpXZYM2RclF2Z7p93nJcmoH0WGgPrQmPpQCNpVs5CgaulqGzWuJxHi0mMDDhHvTOy7BF 5DYOo0rrBwer6k1S3j/J5oKbCPXVq4RCIBO37ndoWrfT4/UMn6L6UfEAhlxAt97gsH4Ibh4n1u8 RKxpNADFhF54wSazyZgQO0GWZngCIHixMzn3YvkJ0FNKudLU8jlNRNg3r/BAdUVSpV12x1A0/63 eWdpDEXQK2df8CpL4Wbo1T6nnxikRqvZNTM7C+eYMhkIpFtg6Od2NufdOI/Adk3eVgr16ha+QiJ z01P3ct3ufKUlzQhzQfKyHJ+N0I4AulC7DMnmh5bpQl7XdRgFZsiazk6ozLZo/fMl+eUsedmVCW 349QxfhVrYFNQFPD4kdTVwFCGTqmwZ0vRlSN4v+YMad6DoM1326hPaLu0swhtSEOp5bLJEVgC6E jG91u6CtN+X+y4XFotQ== X-Authority-Analysis: v=2.4 cv=LtaiDHdc c=1 sm=1 tr=0 ts=6a8d496a cx=c_pps a=y/6OeRevqtbd3HODipuDjg==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=Sv0fKeRqtYgA:10 a=VkNPw1HP01LnGYTKEx00:22 a=bi6dqmuHe4P4UrxVR6um:22 a=iKiJcTA2PjBS6x5JeXcw:22 a=t7CeM3EgAAAA:8 a=i0EeH86SAAAA:8 a=jcFIXsoQAAAA:8 a=P6zNO2psS7vM0yeUzwoA:9 a=FdTzh2GWekK77mhwV6Dw:22 a=M1-Q_cRM6PFdmZSamPpU:22 X-Proofpoint-GUID: qnV3ZPlG_NlukSnbZjP-Ncr0rIeU7Xpx X-Proofpoint-Spam-Info: AW1haW4tMjYwODI1MDA2NSBTYWx0ZWRfX2Wp3AkKvfhjV 6ED2x2oKlCFGPTPuidTqOVHVJIAqIr+v5m5Lw+SplTQRv91oehn0XZjMUhbXnE8ufFYA0rQhs05 D5k6gQ8iVRoz7jR6EG2M0FZr4dVlxyoJwXQyERYQJabOrg3chVRq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-25_01,2026-08-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 clxscore=1011 lowpriorityscore=0 priorityscore=1501 impostorscore=0 adultscore=0 spamscore=0 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608250065 Content-Type: text/plain; charset="utf-8" From: Ionut Nechita kexec_file_load(2) fails with -EINVAL when loading a crash kernel on a machine whose number of possible CPUs exceeds CONFIG_NR_CPUS_DEFAULT, even though the classic kexec_load(2) path succeeds on the same machine. With CONFIG_CRASH_HOTPLUG=3Dy the elfcorehdr segment is over-allocated so it can be updated in place on CPU/memory hotplug. On the !CONFIG_MEMORY_HOTPLUG path, crash_load_segments() sizes that reservation as: ret =3D crash_prepare_headers(..., &kbuf.bufsz, &pnum); ... pnum +=3D 2 + CONFIG_NR_CPUS_DEFAULT; The value that lands in @pnum is crash_prepare_headers()'s @nr_mem_ranges out parameter, i.e. cmem->nr_ranges - the number of memory ranges only, not a phdr count. The header that crash_prepare_elf64_headers() actually builds adds one phdr per *possible* CPU on top of those ranges: nr_phdr =3D nr_cpus + 1; /* + vmcoreinfo */ nr_phdr +=3D mem->nr_ranges; nr_phdr++; /* + kernel text map */ So the reservation covers nr_ranges + 2 + CONFIG_NR_CPUS_DEFAULT phdrs while the buffer holds nr_ranges + 2 + num_possible_cpus() phdrs, and the buffer exceeds the reservation by (num_possible_cpus() - CONFIG_NR_CPUS_DEFAULT) * sizeof(Elf64_Phdr) bytes as soon as num_possible_cpus() grows past CONFIG_NR_CPUS_DEFAULT. num_possible_cpus() is bounded by CONFIG_NR_CPUS, not by CONFIG_NR_CPUS_DEFAULT, so this is reachable on any config that raises CONFIG_NR_CPUS above the arch default without CONFIG_MAXSMP. crash_prepare_elf64_headers() rounds bufsz up to ELF_CORE_HEADER_ALIGN and kexec_add_buffer() rounds memsz up to PAGE_SIZE (both 4096), so the excess is invisible until it outgrows that padding. Once it does, sanity_check_segment_list() rejects the image: if (image->segment[i].bufsz > image->segment[i].memsz) return -EINVAL; kexec_load(2) is unaffected because user space builds the elfcorehdr without the hotplug over-allocation. Observed on a single-socket Xeon 6776P (144 possible CPUs) running a PREEMPT_RT kernel with: # CONFIG_MAXSMP is not set # CONFIG_MEMORY_HOTPLUG is not set CONFIG_NR_CPUS_RANGE_BEGIN=3D2 CONFIG_NR_CPUS_RANGE_END=3D512 CONFIG_NR_CPUS_DEFAULT=3D64 CONFIG_NR_CPUS=3D256 At 144 possible CPUs the buffer exceeds the reservation by (144 - 64) * 56 =3D 4480 bytes. That is more than the 4096 bytes of page padding, so the overflow is guaranteed and kexec -p -s fails with "kexec_file_load failed: Invalid argument". Reducing the possible CPU count to 72 leaves an excess of (72 - 64) * 56 =3D 448 bytes, which the page rounding still absorbs, and the load succeeds - confirming the reservation is the limiting factor. Reserve the elfcorehdr for CONFIG_NR_CPUS, the compile-time upper bound of num_possible_cpus(), so the reservation always covers the header that is actually generated. The CONFIG_MEMORY_HOTPLUG=3Dy path discards @pnum and reserves 2 + CONFIG_NR_CPUS_DEFAULT + CONFIG_CRASH_MAX_MEMORY_RANGES phdrs instead. With the default CONFIG_CRASH_MAX_MEMORY_RANGES=3D8192 the memory range allowance dwarfs the CPU shortfall, so that path does not fail in practice; it is switched to CONFIG_NR_CPUS as well for consistency and to stay correct for small CONFIG_CRASH_MAX_MEMORY_RANGES values. This does not change the reservation for defconfig-like builds, since CONFIG_NR_CPUS defaults to CONFIG_NR_CPUS_DEFAULT. Only configs that raise CONFIG_NR_CPUS reserve more, and the worst case is bounded by the top of the range (CONFIG_NR_CPUS=3D8192 with CONFIG_CPUMASK_OFFSTACK=3Dy), which is exactly what CONFIG_MAXSMP already reserves today. Fixes: ea53ad9cf73b ("x86/crash: add x86 crash hotplug support") Signed-off-by: Ionut Nechita Reviewed-by: Jinjie Ruan Reviewed-by: Bradley Morgan Acked-by: Baoquan He Reviewed-by: Sourabh Jain --- arch/x86/kernel/crash.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c index e681ec9cf1dc..e6f23933a6df 100644 --- a/arch/x86/kernel/crash.c +++ b/arch/x86/kernel/crash.c @@ -369,9 +369,9 @@ int crash_load_segments(struct kimage *image) * maximum CPUs and maximum memory ranges. */ if (IS_ENABLED(CONFIG_MEMORY_HOTPLUG)) - pnum =3D 2 + CONFIG_NR_CPUS_DEFAULT + CONFIG_CRASH_MAX_MEMORY_RANGES; + pnum =3D 2 + CONFIG_NR_CPUS + CONFIG_CRASH_MAX_MEMORY_RANGES; else - pnum +=3D 2 + CONFIG_NR_CPUS_DEFAULT; + pnum +=3D 2 + CONFIG_NR_CPUS; =20 if (pnum < (unsigned long)PN_XNUM) { kbuf.memsz =3D pnum * sizeof(Elf64_Phdr); @@ -430,7 +430,7 @@ unsigned int arch_crash_get_elfcorehdr_size(void) unsigned int sz; =20 /* kernel_map, VMCOREINFO and maximum CPUs */ - sz =3D 2 + CONFIG_NR_CPUS_DEFAULT; + sz =3D 2 + CONFIG_NR_CPUS; if (IS_ENABLED(CONFIG_MEMORY_HOTPLUG)) sz +=3D CONFIG_CRASH_MAX_MEMORY_RANGES; sz *=3D sizeof(Elf64_Phdr); base-commit: 4b18edbd8e70f7e6860d56370f13244896d0f95c --=20 2.55.0 From nobody Mon Sep 28 07:24:46 2026 Received: from mx0a-0064b401.pphosted.com (mx0a-0064b401.pphosted.com [205.220.166.238]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 188053D75A9 for ; Tue, 25 Aug 2026 08:00:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.166.238 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787644852; cv=fail; b=B4+7PVL6TuFlai4kcjpJowa/1Kdou8RPial66/4fhPgiv5cKTg3ktXfYkwkZ89q7OR1mxTZh99RS7/K9sH8uHhYRSaJCCzGoeucHRP6hnrwoe57Bbpm64OsYFZqaQtAgSQJe+jCt3tV7OXscGwQFxj0oYUUyWgKhO3ljrERsk4o= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787644852; c=relaxed/simple; bh=8H6OFTNag6FIrRR/NByLDvjKA2mxlF7/M0NiVThWkSY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=EwbMhKXgKbiiuq51ka/oewiSqMgBvXVwwm3li+vtD6X6ObEHtTbcy+4CE6ByQgwTwbTDceev6sCJKboxb+QlJHO2Zr+1r1kkxzGuMmLyS+Of9LHxJBhrGgxAwqD3pIL2V/744LM54nNhPmMYXdNvMFinGZObnjUslEk3bY29Tts= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com; spf=fail smtp.mailfrom=windriver.com; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b=CviR6Duh; arc=fail smtp.client-ip=205.220.166.238 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=windriver.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b="CviR6Duh" Received: from pps.filterd (m0250809.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67P4GUqo639027; Tue, 25 Aug 2026 00:51:12 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=cc:content-transfer-encoding:content-type:date:from :in-reply-to:message-id:mime-version:references:subject:to; s= PPS06212021; bh=IK2tVEXdHC/8PzQA3cP9GhjuJ6Gq5QhfcIartwEmDVs=; b= CviR6DuhGDD3dZDzjFJ2LQMANSSAOAf/TZKzRhOzMmryKAH4t2EM/2r1bOlbuA6e Q0c4egqg8nwhOGhe+2KuolqDuHl3GS6UzVu//aUNHUMhAaw+29MBElZBV0wDeBMu i+asoUXhStLSH7YQvDZc84UJkxigKDHZ1G5XfoVXlUfNwz6icPQQk3SMimhoE/wN CziG1PGWRm/hGeSEnRsFoe5PpOD5R2CkaB8059U+Y+eSjLLmgZteGE2rkik7HpuL Vpwhti5KD1y8Dth6gPmFRulCfHRt5TMRW9cL18NUlEej02bhsmkYgbCefmOMbx7K gfoo3y99YmFRTv+13TjB8g== Received: from co1pr03cu002.outbound.protection.outlook.com (mail-westus2azon11020133.outbound.protection.outlook.com [52.101.46.133]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 4g7b9gky6k-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 25 Aug 2026 00:51:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DUCj1XVRTyOOWc7tnaHr+3/nYSb9AdVdccjVsD852SXTru4g7Sw6RqZUd7yKzsPQMnbnxBgE5PqkhruIpOTSl0Jl3seHwXXSDOXPuJ/WoOZrtyLhNvDxsZycqy6H3/PFBZQ7+2PmBY9eL2m8xD0zO+VAKlZss4SdScKuVrfN4JhFOlZPzPndCkXOnAdQ5kPutI9uPOAT4ZiQ4vykDdV/kThf0RvyQdRqcJvxnsuFk6WZ4QYCC7G1FWm8NRdW1mUlVbzZkOsNFgjLHYEsMQqm0aBddr9Zr1wtdVvfU2hdXEIg2xqk2UAHAIjCb8SsKPfgXmpQArAK3WNe+9enX1Ogdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IK2tVEXdHC/8PzQA3cP9GhjuJ6Gq5QhfcIartwEmDVs=; b=m+/QeqnLuYzpErZqND9ETiGH8oSp6IlK/W0/+wgBRVgWaJ8HAPPyK7PAdSdtlHX4IyZPHPtBiefY7Ibx0b1xPdFRvB0iVjMoqH1q6exdHuNomT4pG381BDcCoUdnlb6zIMcvU66y5fv3yjK9UKkYHt+WIGSVkACwItkYIF7zLJaL2yDzFsBXLJ32FHVN7CBofA6hiKn9ghtYTue65h3om8Nq8tQ4puqJXQ2yNTskE/REEM/tcKI9EsYyEJ5yTqB6Tzf7HcF+ETw3IcpGGAhpurXd+c0AXiGdiqPfL821xKJ5VvE6kyY2qTGc7uT44vyLmMuaiIcxUCydR6WMnDn7Eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none Received: from SJ2PR11MB7546.namprd11.prod.outlook.com (2603:10b6:a03:4cc::8) by CH3PR11MB8441.namprd11.prod.outlook.com (2603:10b6:610:1bc::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.12; Tue, 25 Aug 2026 07:51:09 +0000 Received: from SJ2PR11MB7546.namprd11.prod.outlook.com ([fe80::ca9b:dcf:8881:bced]) by SJ2PR11MB7546.namprd11.prod.outlook.com ([fe80::ca9b:dcf:8881:bced%3]) with mapi id 15.21.0339.012; Tue, 25 Aug 2026 07:51:09 +0000 From: "Ionut Nechita (Wind River)" To: x86@kernel.org, kexec@lists.infradead.org Cc: tglx@kernel.org, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, akpm@linux-foundation.org, baoquan.he@linux.dev, rppt@kernel.org, pasha.tatashin@soleen.com, pratyush@kernel.org, ruirui.yang@linux.dev, eric.devolder@oracle.com, hbathini@linux.ibm.com, sourabhjain@linux.ibm.com, ruanjinjie@huawei.com, include@grrlz.net, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] crash: update stale NR_CPUS_DEFAULT references in elfcorehdr sizing docs Date: Tue, 25 Aug 2026 10:50:43 +0300 Message-ID: <20260825075043.42041-3-ionut.nechita@windriver.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260825075043.42041-1-ionut.nechita@windriver.com> References: <20260825075043.42041-1-ionut.nechita@windriver.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: ZR2P278CA0014.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:50::20) To SJ2PR11MB7546.namprd11.prod.outlook.com (2603:10b6:a03:4cc::8) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR11MB7546:EE_|CH3PR11MB8441:EE_ X-MS-Office365-Filtering-Correlation-Id: f1549a68-34d4-46eb-37ee-08df027da07a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|52116014|376014|10070799003|23010399003|1800799024|366016|10067099003|56012099006|11063799006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: pf2OgSToDKRVpfOoZ9tDvp2r9BhGuLnk8xF948DRc3AlJNikCIxTXYtlF2b5cDmglehLdtxcsuRjMGKjoQU4Im2q+8/IJ6mrjy+2MDkGjP5XE0rfPofYBY/5WI0JLLuFUpq/7eRZo4XyZ91Gs6uCktRAsdCD8z3r/cju/CfWf7j53LE7+2HfT+4sOwDR0pD8mx69IxryWpxFmpiZW5u/s5xh1Ya57wZ5XXGOolfx2unKINjRCQ9ETkupMjcjSZ4pGDnl54E4oVgBcXeDNSsDy2H3wMGsApwH5qEFPV6zSlimq6MYrh3O4o0tlPmvRZmW7sz+xnd7uqnHkJG3dJ/hG3Rpjd/WbHdVOdZLFOD8dKuhDPzKZPveVxoEVQz2iCIxpuqd8Y+bVfcoCu9LrxNqQvDx1vbWO3jaxPk/zeuaQMHxFQGsZWXwBZmfYH+DAy2LLYrIZ0/6UYHxCqBR+kmmpWcUG+2Iyu1fd8KrTrv1vQfzjyi/h+QlJh6ecx16Gl+PwRK2SDfDEN0wIYeY297X8c0cB2MRVMeBmGLbAH0qNMBladS0vhrm3GqUQ0NKN+m4LvYwJMiMfh1VmjyP3IeReQU3cGvvbdTUwOyh2s3RrbBBdiHehvEJGDhjpdWkrjdepr+bKp4aaCVsUa63s2cg4D159gPlaibHeM9iF10q2yQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR11MB7546.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(52116014)(376014)(10070799003)(23010399003)(1800799024)(366016)(10067099003)(56012099006)(11063799006)(22082099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?N6nPWdbz+T1f1wJiC07PpbiD5NWf8NkpUfnqxHOBDmnlM2NUv4el0VZz5Pe8?= =?us-ascii?Q?QxJBaCv58/2Rt49uZTbVl/1WM6bFDItycKEizu8H4fkx3oSeWjE3KYfVhDuA?= =?us-ascii?Q?l9ONKHpNk54k0qAXKy+8+AzN55fLqEw1GUvhVKE8cyH/TytrGLhpYRXfmdbx?= =?us-ascii?Q?Jmr7BZIK8DIZoenbEI+Yb0uwwBffFp5Pf8EhfJiz+i1opUSFLVtcyscQy9ZZ?= =?us-ascii?Q?TOY6u5uKOnSLmPOzp8sDWY3bzGfr4LkbLABVgqgLpoKCtuitOHvNAJkU3AOI?= =?us-ascii?Q?s0yMVJ4iM+pql1TMXK6TcwF+RCw2a78Do96YU9gkUj+Qy+d+Jk08j3WY1nKG?= =?us-ascii?Q?N0PVxvQqpvZP8P37fOh2gxjGOxY7sB7s9o1nyiDGRhiBWXzYmv2A1gx8HmK1?= =?us-ascii?Q?exiTnE5CEXg8dDIgLck//BMce+u9e0z8701xVfDWVcEAU/s0jGbKa6O1+92V?= =?us-ascii?Q?gIk2tUqLoZwD8/WrvTkmvc7I79rRVlbiKCUrOKZaHLC2j64epHtvYYriEAlq?= =?us-ascii?Q?kmMe/Llu/T7aMvoRrVtQLk1NoD250A3Pcm8ciNra037Jf1RBPu1lbz/ZEXeQ?= =?us-ascii?Q?iOawWDyXnFMdNZbdtS1gamRrg2HOZ9SXswkZyAKvufgPneN9P8VwM/1BFdD0?= =?us-ascii?Q?aUwZWHiAkZUEAN0vSQlqeexDRgi30WnYkx5aJSnJcXJUnlxiMqfvU2uXAQj5?= =?us-ascii?Q?CXdtZTnbTpRPa5PRS8QOPyEXQTI15cK7WAB/J9W/7vbpT2hyeyxHBOZkOOk6?= =?us-ascii?Q?7bH7dyeds2PP+MSUc5sbyq+1kV3Szonsw2HhPeS6PPqv5P3nZGCkfmj035lV?= =?us-ascii?Q?3U7Iupc7sn0khTPLhpZ6K4tvDIYtUMWFdVlvSrjruIjPGGlU3/vZ8590j0vN?= =?us-ascii?Q?EWQERgvByB0aK4YmhmAWtv+37IYGPbYdsi61B4UuCZsjNROujHZ5pgD57Di3?= =?us-ascii?Q?LnGhJokLtly3ee09gTj2q+CRSpdtDoxRNdr28ePLsb3c9n1n4BLOZxf10x+e?= =?us-ascii?Q?FF9T2/6iUsAhHKXHm5n02G6y/MFgWKpWUlCNHVMe0QgAkU2AUuTj9S3DpqyG?= =?us-ascii?Q?WoKNtJjhWbXYCmpQ3yeLgcbGqvc+cp4A13B2zfQ0xYioi0RaI3qEwVCs8suS?= =?us-ascii?Q?ZK3MBr1+uUWi+oh81r9LS/0xNmBWT8FBOq1yDKYP3BZdBZ3rzSxRURNnSI4N?= =?us-ascii?Q?hbK/Ujlz+058STEtrv9UcEeatuDGj4u1vS+KBZDQd+B4PvfX16ijc8SKV7Om?= =?us-ascii?Q?pKfHKUO++5oeDLnkCKU7CgwxRc/cIVYjkKNPZcalDdJASVPtFul34zVG722j?= =?us-ascii?Q?QZlZhPFeTbsZa2SH7CkT5uPq2eBEAsw+GtANJ1HGbt3j0k3f/KpnjM71zc7z?= =?us-ascii?Q?fKxs7RXOcFwpoEoPOORUt1iyfXdR4DqDTrPWYWP9OTQ3eZM3ZJcQStWKnf6I?= =?us-ascii?Q?qto3oEPhZj7o+tgH3PlnDXfvNFYdxPa7ScURmgSI2WJpBUSyuns1iNTPvB7H?= =?us-ascii?Q?yB6bsvRA4f21odXAvPXBWAyhzBfMoPl5Tp27znHyJo+NXHiNWybOT3WiTCO+?= =?us-ascii?Q?iZtUQDqsdEnf/9LofoYYURMLZ20J4lssK9BdS9RZnly95s73jIsLZTyw7ltc?= =?us-ascii?Q?SxGF5Mtp5qB4hxxwo+y7w0dEdRyZjLRSt7JOy6oWoQ7uEvSNdF+WezQN5cSy?= =?us-ascii?Q?ihyRExyFaqB86bPRkkjyJlGexITYXzaYpBjDcLnfWQvlni43ZUIaWDHkHcK7?= =?us-ascii?Q?lsQ0PxvgusMZJCkfHD5Ukf42lFVDcbbq3yw1IcZpHVvxfwFNCpB/nDEaPTat?= X-MS-Exchange-AntiSpam-MessageData-1: IZJ20uh63KnSpQnywI2fab3iYKbVTujXI9s= X-Exchange-RoutingPolicyChecked: 1EAmqVqez/nTDfhW056zdOdSeL5G7ze5Bj/nJlxS46PfBGl2jTIIhmNIy552oBD7jXZgAg23d1Zkd3NGDm1fHlSq4f9xjDd7maMJM+hl6Rn9uEVLpgSTNLZD/BdjnBYrJBzwBxZ5S72Zv2a0acXq+IZi+bMGfwHik4vHBqvVLTjpYr9xqfiSq5B90x6lhx5sMgJ6kq4WgI4O8JaLB5HpvTt8SDJOnfIbNLwSdmeMs0H6wL9SYQSZhC0z5xX3zMd+O29Hz8KXTwP6awOt6b8QbMSPk99t28qNv7APYbjhOim55F/1XlTYcN3/dmJAUEhMO6ImcIX3Sdqe8CZSDAAfEA== X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: f1549a68-34d4-46eb-37ee-08df027da07a X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7546.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2026 07:51:09.8149 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DKHXFDqWIXkg2Lk/rpJkHNbawtGmXGGOnPzf44yvOcTs8zxnR1Jt/EO52iZzwASZXrgHeXkRPFH3L1I6HGBJ9m25g6qGmvkLvatQgvjHV60= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8441 X-Proofpoint-ORIG-GUID: 0BKN_MnZcKr9dPrcYp1sWpbfz2vtFd0b X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI1MDA2NSBTYWx0ZWRfX7tkbwdX2JySv mD4Rduwrejch4Xy8/NUXU+FOF6TOUfNBehR6LL2pNMDbLz3l5cINlYrmzYAXMRU/xh4/6CHkXSD r9g7eWnpFRQF4H3jd853HtxriUQKyc5g8EOsj0pKfQhIUi5kofWAyYhtDGN4KHXvTM5zNxQ2EVg hUh/+nNs9fTijpLDBl1/E9CKpkrqH8mQglT0tBp0jibvmzGL8OS8w1pweeI/Ih+zpg3Gw7m2r/l nHv4Jb9CKZhXknjaYMzYpiJmbC96hfiypJdSTYu5TRKSJrUCN+y0fYsN6qRyy/9cZTCrUiuzlCu nhossI50u52othb4A8achdCiWNwfOnGgc5lf3DzobTX8wkAREtBei5cIlZ2t9UcoNf4DMZmOWCU VsSrkJZcnrDa9JHzS/COf+Jhd0JALBEp9BlqFXkfkBhVXhwbp8K00Ev/2/NTMUfXyWHZ+TZOH0B yztDMynGqp5n0v57DDA== X-Authority-Analysis: v=2.4 cv=LtaiDHdc c=1 sm=1 tr=0 ts=6a8d4970 cx=c_pps a=/64aUU06laRl6xO2iYKDkw==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=Sv0fKeRqtYgA:10 a=VkNPw1HP01LnGYTKEx00:22 a=bi6dqmuHe4P4UrxVR6um:22 a=iKiJcTA2PjBS6x5JeXcw:22 a=t7CeM3EgAAAA:8 a=i0EeH86SAAAA:8 a=jcFIXsoQAAAA:8 a=AyFJ6eo5uNYZnhLCzmoA:9 a=FdTzh2GWekK77mhwV6Dw:22 a=M1-Q_cRM6PFdmZSamPpU:22 X-Proofpoint-GUID: 0BKN_MnZcKr9dPrcYp1sWpbfz2vtFd0b X-Proofpoint-Spam-Info: AW1haW4tMjYwODI1MDA2NSBTYWx0ZWRfX3N5oOw3ogwCM dkv3lhVagAa93yoIG1qCzKls9VpSvJZX5Yhhk5eDW3hsXwEYC+L09nnULmk2NcMBdIYeI5rt6Ny xvfWH+5rjmavpofC1nwJqCcl6Bs5YwaS2SnmVheCLO0MkhW1ZFGf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-25_01,2026-08-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 impostorscore=0 adultscore=0 spamscore=0 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608250065 Content-Type: text/plain; charset="utf-8" From: Ionut Nechita The elfcorehdr over-allocation for crash hotplug is now computed from CONFIG_NR_CPUS rather than CONFIG_NR_CPUS_DEFAULT, but two pieces of documentation still name the old symbol: the comment above crash_handle_hotplug_event() and the CRASH_MAX_MEMORY_RANGES help text. Update both so they describe what the code actually does and do not mislead people sizing CRASH_MAX_MEMORY_RANGES. Documentation only, no functional change. Suggested-by: Jinjie Ruan Suggested-by: Bradley Morgan Signed-off-by: Ionut Nechita Reviewed-by: Bradley Morgan --- kernel/Kconfig.kexec | 2 +- kernel/crash_core.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/Kconfig.kexec b/kernel/Kconfig.kexec index 15632358bcf7..a97ed9605602 100644 --- a/kernel/Kconfig.kexec +++ b/kernel/Kconfig.kexec @@ -167,7 +167,7 @@ config CRASH_MAX_MEMORY_RANGES memory regions that the elfcorehdr buffer/segment can accommodate. These regions are obtained via walk_system_ram_res(); eg. the 'System RAM' entries in /proc/iomem. - This value is combined with NR_CPUS_DEFAULT and multiplied by + This value is combined with NR_CPUS and multiplied by sizeof(Elf64_Phdr) to determine the final elfcorehdr memory buffer/ segment size. The value 8192, for example, covers a (sparsely populated) 1TiB system diff --git a/kernel/crash_core.c b/kernel/crash_core.c index 2b36aa9fade0..d0bd2d0cf899 100644 --- a/kernel/crash_core.c +++ b/kernel/crash_core.c @@ -648,7 +648,7 @@ int crash_check_hotplug_support(void) * new list of CPUs and memory. To make changes to the elfcorehdr, it * should be large enough to permit a growing number of CPU and Memory * resources. One can estimate the elfcorehdr memory size based on - * NR_CPUS_DEFAULT and CRASH_MAX_MEMORY_RANGES. The elfcorehdr is + * NR_CPUS and CRASH_MAX_MEMORY_RANGES. The elfcorehdr is * excluded from SHA verification by default if the architecture * supports crash hotplug. */ --=20 2.55.0