From nobody Mon Sep 28 07:17:17 2026 Received: from mx.nabladev.com (mx.nabladev.com [178.251.229.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CED93D0BF3; Tue, 25 Aug 2026 07:19:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.251.229.89 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787642382; cv=none; b=tXSCnfUc+rZUN4p9ODNTld9m7QEVrPjn1svTDeZHc5Jzv0GfHJiNdBxn2dXp8JfXnspeqfCxrFqBfz0oh7VYODlsoDYibScFYkcC3VnIa8OgwJIxQfquVrxdJDkEaff/8Q3tZXQ1le72NkmEekD6/0fwIR43icG4SrtyW3hFUs4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787642382; c=relaxed/simple; bh=jTlkpKX/i4IK/qqSZ+v0AWvDMXAkhg+j6xaMzMiVKb8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CFH7N3D/8J7jrSB9+1sD7CAo1xKOx46Mleyec/RmhXlkH6H1X9J4k4KhIx1aQoQ7oXFhdrg0jk4UAP/aG7Y6Z8WeZ3g0+GpzZwE3opUwxafMtbCinVMPYxPeCwsUtyFLAUEDtta3CBpu7V4clI/Onxr/Xc8luXPrvgclnPciZP4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nabladev.com; spf=pass smtp.mailfrom=nabladev.com; dkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com header.b=Ov5GqHuW; arc=none smtp.client-ip=178.251.229.89 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nabladev.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nabladev.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com header.b="Ov5GqHuW" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 1BE6211CC0F; Tue, 25 Aug 2026 09:19:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nabladev.com; s=dkim; t=1787642374; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=W429C6y4sT/FIA+4M/csrplvSTOypF/+XtDpNghU/6s=; b=Ov5GqHuW/ooR7ax4280lbRpdLF01HC1yt7XGwrJtVPPiBvmX/zY6kXohCWVDu/DvIllVz9 UzRUznLGw7Zwt8TuBq5JrcdETWC+TEuHAmZpEUtFVL9JwAwve778awkw9eDkwzLmEf3Tzq 0pFUjvGmSTSMdydd5yFnKzc8r2TxUYS4bzqrHOp3MQ0ugvPCTRngCXWsarmn7PitIL06Ac IzacjTzfxkPpK84o0Zkw3TGbutvWqV4sxwanoFAB7pcfgYd0B/Cb/d83T+mna04gYKz9R3 OtZV7r7l8X25sDhVA/Y0hfQ1/lNaw5MoNg8ZE69MnJ2snr4CIpCy3vB8JR9sIg== From: Heiko Schocher To: Alexandre Belloni Cc: Krzysztof Kozlowski , linux-kernel@vger.kernel.org, Conor Dooley , devicetree@vger.kernel.org, Rob Herring , linux-rtc@vger.kernel.org, Heiko Schocher , Conor Dooley Subject: [PATCH v2 1/3] dt-bindings: rtc: add ricoh,r2223x binding Date: Tue, 25 Aug 2026 09:19:16 +0200 Message-ID: <20260825071927.4090460-2-hs@nabladev.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260825071927.4090460-1-hs@nabladev.com> References: <20260825071927.4090460-1-hs@nabladev.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Content-Type: text/plain; charset="utf-8" The Ricoh R2223x is an I2C RTC of the same family as the r2025sd and r2221tl which the rtc-rs5c372 already supports. It drives a clock output and can be put into an eco mode that lowers its current consumption from the backup supply, so it needs #clock-cells and a property for the eco mode. The trivial-rtc binding does not cover this, so give the device its own binding. Signed-off-by: Heiko Schocher Reviewed-by: Conor Dooley --- Changes in v2: - Added Reviewed-by from Conor, no code change in patch 1 .../devicetree/bindings/rtc/ricoh,r2223x.yaml | 58 +++++++++++++++++++ 1 file changed, 58 insertions(+) create mode 100644 Documentation/devicetree/bindings/rtc/ricoh,r2223x.yaml diff --git a/Documentation/devicetree/bindings/rtc/ricoh,r2223x.yaml b/Docu= mentation/devicetree/bindings/rtc/ricoh,r2223x.yaml new file mode 100644 index 000000000000..e64a1ee378e6 --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/ricoh,r2223x.yaml @@ -0,0 +1,58 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/rtc/ricoh,r2223x.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Ricoh R2223x Real-Time Clock + +maintainers: + - Heiko Schocher + +allOf: + - $ref: rtc.yaml# + +properties: + compatible: + const: ricoh,r2223x + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + "#clock-cells": + const: 0 + + ricoh,eco-mode: + type: boolean + description: + Put the RTC into eco mode, which lowers its current consumption while + running from the backup supply. Set this on boards where the RTC is + expected to keep time on a small backup cell. + + start-year: true + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + #include + + i2c { + #address-cells =3D <1>; + #size-cells =3D <0>; + + rtc@32 { + compatible =3D "ricoh,r2223x"; + reg =3D <0x32>; + interrupts =3D <6 IRQ_TYPE_EDGE_FALLING>; + #clock-cells =3D <0>; + ricoh,eco-mode; + }; + }; --=20 2.55.0 From nobody Mon Sep 28 07:17:17 2026 Received: from mx.nabladev.com (mx.nabladev.com [178.251.229.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 701D83B38AA; Tue, 25 Aug 2026 07:19:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.251.229.89 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787642387; cv=none; b=KBd+Bff+ie1YJUFGIMN8hYoPnI6p1DZhR1I+dRMfABvBAVWVUbOZWHYNccVPSPnXfGrL6y5Eh6Ce7SZgmUuXy61Rvn/88lBf4ZXyxD0Tw4rLZ8En0waz2o/REHAFbWBt7bNCKeXu+0VyNqXu577PEBsk9nnpOPjQdcvnnpCCe1c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787642387; c=relaxed/simple; bh=64tTLfUjsiOKasoYzG6gDsbRAPUK3rskVkMUqYWNZKg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=d04KPNhRiam3kf9gAjq6uS6ldyKvhtFdejSz3hJIv9u9AZbUkr68yk9KzfR2iDjhyGwXyvUXPIooXdRfVqBJ3dCewfDycRXQnXlr3iEXm6VD89ckfs0A7++foWPeVISGibft5MpQR0grDkHUIZfIcyDUPsO2FQcqckjbhXHnZa8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nabladev.com; spf=pass smtp.mailfrom=nabladev.com; dkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com header.b=FJP0j+rM; arc=none smtp.client-ip=178.251.229.89 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nabladev.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nabladev.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com header.b="FJP0j+rM" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 1EBFF11CC16; Tue, 25 Aug 2026 09:19:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nabladev.com; s=dkim; t=1787642379; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=GeNCEPrxHWtAS5ptxcQfWjWwOtPD6ysK/kV9MqcdTzc=; b=FJP0j+rMYXffqUNEJl9kOslemhWBUC2XStSVvAzDq6OZTSLAlnFW8Lp3SDO5XjVm/A0xET OGP5ArjLpK0lFUVUCsUJFXTe3J+usgnIs9BcF8MQ1Jx9lKQdvemtDKJMVA21LcCeVrFljz vG+K+Xn14TcgTYTfqAVb3KmuktPHySdSjGfRGgRMBIleJ//M/6iGjRPzWaOyqS1y0k7Dyd rdLkfj1UkYzet1AFnvI+Brh9AogPFjQw7pJZ52KnIzRld6o3d53C6tniYGYy+/vt+HrkEU JRpvV0igIcVyKTZLxKnWzzR0K6DRTR5dBkmnoQrOenlJzpzIbeVgXHuLljjstQ== From: Heiko Schocher To: Alexandre Belloni Cc: Krzysztof Kozlowski , linux-kernel@vger.kernel.org, Conor Dooley , devicetree@vger.kernel.org, Rob Herring , linux-rtc@vger.kernel.org, Heiko Schocher , Sashiko AI review Subject: [PATCH v2 2/3] rtc: rs5c372: add support for Ricoh R2223x Date: Tue, 25 Aug 2026 09:19:17 +0200 Message-ID: <20260825071927.4090460-3-hs@nabladev.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260825071927.4090460-1-hs@nabladev.com> References: <20260825071927.4090460-1-hs@nabladev.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Content-Type: text/plain; charset="utf-8" The R2223x is an I2C RTC from the same family as the r2025sd and r2221tl that this driver already handles. It shares the R2x2x control register layout, so treat it like the r2221tl. The oscillator interrupt flag is reported through XSTP, and the 24 hour mode bit lives in CTRL1. It also has the DEV bit in the trim register, so same as r2221tl. Signed-off-by: Heiko Schocher Reported-by: Sashiko AI review Closes: https://sashiko.dev/#/patchset/20260824110452.4038870-1-hs@nabladev= .com?part=3D2 Closes: https://sashiko.dev/#/patchset/20260824110452.4038870-1-hs@nabladev= .com?part=3D3 --- checkpatch reports on this patch ERROR: trailing statements should be on next line + case rtc_r2223x: s =3D "r2223x"; break; I did not fix this checkpatch error, as the whole switch statement uses this format. Changes in v2: - Fixed the sashiko review of v1: handle the new type in rs5c372_ioctl(), rs5c372_read_offset() and rs5c372_set_offset() https://sashiko.dev/#/patchset/20260824110452.4038870-1-hs@nabladev.com?p= art=3D2 - Added sashiko review for patch 3 in this patch, as it fits better here https://sashiko.dev/#/patchset/20260824110452.4038870-1-hs@nabladev.com?p= art=3D3 drivers/rtc/rtc-rs5c372.c | 24 +++++++++++++++++++++--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-rs5c372.c b/drivers/rtc/rtc-rs5c372.c index 24bd795d9d95..c65b76cc0dc6 100644 --- a/drivers/rtc/rtc-rs5c372.c +++ b/drivers/rtc/rtc-rs5c372.c @@ -68,6 +68,7 @@ enum rtc_type { rtc_undef =3D 0, rtc_r2025sd, rtc_r2221tl, + rtc_r2223x, rtc_rs5c372a, rtc_rs5c372b, rtc_rv5c386, @@ -77,6 +78,7 @@ enum rtc_type { static const struct i2c_device_id rs5c372_id[] =3D { { .name =3D "r2025sd", .driver_data =3D rtc_r2025sd }, { .name =3D "r2221tl", .driver_data =3D rtc_r2221tl }, + { .name =3D "r2223x", .driver_data =3D rtc_r2223x }, { .name =3D "rs5c372a", .driver_data =3D rtc_rs5c372a }, { .name =3D "rs5c372b", .driver_data =3D rtc_rs5c372b }, { .name =3D "rv5c386", .driver_data =3D rtc_rv5c386 }, @@ -94,6 +96,10 @@ static const __maybe_unused struct of_device_id rs5c372_= of_match[] =3D { .compatible =3D "ricoh,r2221tl", .data =3D (void *)rtc_r2221tl }, + { + .compatible =3D "ricoh,r2223x", + .data =3D (void *)rtc_r2223x + }, { .compatible =3D "ricoh,rs5c372a", .data =3D (void *)rtc_rs5c372a @@ -221,8 +227,10 @@ static int rs5c372_rtc_read_time(struct device *dev, s= truct rtc_time *tm) switch (rs5c->type) { case rtc_r2025sd: case rtc_r2221tl: + case rtc_r2223x: if ((rs5c->type =3D=3D rtc_r2025sd && !(ctrl2 & R2x2x_CTRL2_XSTP)) || - (rs5c->type =3D=3D rtc_r2221tl && (ctrl2 & R2x2x_CTRL2_XSTP))) { + ((rs5c->type =3D=3D rtc_r2221tl || rs5c->type =3D=3D rtc_r2223x) && + (ctrl2 & R2x2x_CTRL2_XSTP))) { dev_warn(&client->dev, "rtc oscillator interruption detected. Please re= set the rtc clock.\n"); return -EINVAL; } @@ -292,6 +300,7 @@ static int rs5c372_rtc_set_time(struct device *dev, str= uct rtc_time *tm) switch (rs5c->type) { case rtc_r2025sd: case rtc_r2221tl: + case rtc_r2223x: ctrl2 &=3D ~(R2x2x_CTRL2_VDET | R2x2x_CTRL2_PON); if (rs5c->type =3D=3D rtc_r2025sd) ctrl2 |=3D R2x2x_CTRL2_XSTP; @@ -511,8 +520,10 @@ static int rs5c372_ioctl(struct device *dev, unsigned = int cmd, unsigned long arg switch (rs5c->type) { case rtc_r2025sd: case rtc_r2221tl: + case rtc_r2223x: if ((rs5c->type =3D=3D rtc_r2025sd && !(ctrl2 & R2x2x_CTRL2_XSTP)) || - (rs5c->type =3D=3D rtc_r2221tl && (ctrl2 & R2x2x_CTRL2_XSTP))) { + ((rs5c->type =3D=3D rtc_r2221tl || rs5c->type =3D=3D rtc_r2223x) && + (ctrl2 & R2x2x_CTRL2_XSTP))) { flags |=3D RTC_VL_DATA_INVALID; } if (ctrl2 & R2x2x_CTRL2_VDET) @@ -527,7 +538,8 @@ static int rs5c372_ioctl(struct device *dev, unsigned i= nt cmd, unsigned long arg return put_user(flags, (unsigned int __user *)arg); case RTC_VL_CLR: /* clear VDET bit */ - if (rs5c->type =3D=3D rtc_r2025sd || rs5c->type =3D=3D rtc_r2221tl) { + if (rs5c->type =3D=3D rtc_r2025sd || rs5c->type =3D=3D rtc_r2221tl || + rs5c->type =3D=3D rtc_r2223x) { ctrl2 &=3D ~R2x2x_CTRL2_VDET; if (i2c_smbus_write_byte_data(rs5c->client, addr, ctrl2) < 0) { dev_dbg(&rs5c->client->dev, "%s: write error in line %i\n", @@ -554,6 +566,7 @@ static int rs5c372_read_offset(struct device *dev, long= *offset) =20 switch (rs5c->type) { case rtc_r2221tl: + case rtc_r2223x: ppb_per_step =3D val & R2221TL_TRIM_DEV ? 1017 : 3051; break; case rtc_rs5c372a: @@ -600,6 +613,7 @@ static int rs5c372_set_offset(struct device *dev, long = offset) } break; case rtc_r2221tl: + case rtc_r2223x: /* * Check if it is possible to use high resolution mode (DEV=3D1). * In this mode, the minimum resolution is 2 / (32768 * 20 * 3), @@ -750,6 +764,7 @@ static int rs5c_oscillator_setup(struct rs5c372 *rs5c37= 2) return ret; break; case rtc_r2221tl: + case rtc_r2223x: if (!(buf[1] & R2x2x_CTRL2_XSTP)) return ret; break; @@ -768,6 +783,7 @@ static int rs5c_oscillator_setup(struct rs5c372 *rs5c37= 2) break; case rtc_r2025sd: case rtc_r2221tl: + case rtc_r2223x: case rtc_rv5c386: case rtc_rv5c387a: buf[0] |=3D RV5C387_CTRL1_24; @@ -847,6 +863,7 @@ static int rs5c372_probe(struct i2c_client *client) break; case rtc_r2025sd: case rtc_r2221tl: + case rtc_r2223x: case rtc_rv5c386: case rtc_rv5c387a: if (rs5c372->regs[RS5C_REG_CTRL1] & RV5C387_CTRL1_24) @@ -876,6 +893,7 @@ static int rs5c372_probe(struct i2c_client *client) ({ char *s; switch (rs5c372->type) { case rtc_r2025sd: s =3D "r2025sd"; break; case rtc_r2221tl: s =3D "r2221tl"; break; + case rtc_r2223x: s =3D "r2223x"; break; case rtc_rs5c372a: s =3D "rs5c372a"; break; case rtc_rs5c372b: s =3D "rs5c372b"; break; case rtc_rv5c386: s =3D "rv5c386"; break; --=20 2.55.0 From nobody Mon Sep 28 07:17:17 2026 Received: from mx.nabladev.com (mx.nabladev.com [178.251.229.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 514293CFF6C; Tue, 25 Aug 2026 07:19:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.251.229.89 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787642391; cv=none; b=NawFvVSCEQY72jV3lMPEZT3oai1A2uEFhDi/OAeFObySLzIxO/CFJbXStdEe5jopsFUzPBkev2YNSRaWNthUzpfZ6AOHmkKi96RZ/Qbh+QfJYugSfDk9vXSDsxOKSOO6jMT7Q1BGrzr+XhRosG0ml0fHaJeqNCxLRQYS4241cu8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787642391; c=relaxed/simple; bh=85P/R5gcif35u3BDK1lWztpzNfA68IzZXgV7sHTiI5g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mJ2Uuj65UikOGmgt46nmzzBqjXKYQFuhBsqoAaLEUN1ZyFD69XQ6lT4zc2s0WchCiW7W5F/aU4YU8MKcKlQ0DL9aVGlUhw9rG0n2c90tEg+t9sKFtureySVl6dVtL6JuyQKzzLk+mJcpRSliZ1ZkTtPL/CajWTs85TH5Nkzaw04= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nabladev.com; spf=pass smtp.mailfrom=nabladev.com; dkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com header.b=RR4M+vhH; arc=none smtp.client-ip=178.251.229.89 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nabladev.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nabladev.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com header.b="RR4M+vhH" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id D4EBE11CC1B; Tue, 25 Aug 2026 09:19:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nabladev.com; s=dkim; t=1787642384; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=qc/xQJmsi42iCIOkJ2wF2iMJ9+EWHiTHbIMYFOtTR9I=; b=RR4M+vhHhH9nrx9bHBtybt4Yzk/2+61NKX3oRzWxwIV28CWfkA6Qc9uyC00Nq5NRZu+LU6 Bf/T1BZ7IVbIKasLx2vM/yhXw6KHCNh4lOUt5oTkplmxC6tFeJ9JwABTuJUU6YuMI/r17x JqP4xUk1DQa0SpP6jmnN+2EPok87/L0qXiu8TCERcqdf5K/x2bBJ3+fpGCKVzfXV2SMW7v E45dDRnM6d/dit13GH/GNbznQ1icy/yJE5bv0bXn6B7qrRSGdMu+DF6yp7WeSi/HvjH44z jAQ2Wp7TcOViD0pvhTjt9cFw2t8xUZ/iiQo6w91fOVTTqqbGBcemwTV/wRD0pw== From: Heiko Schocher To: Alexandre Belloni Cc: Krzysztof Kozlowski , linux-kernel@vger.kernel.org, Conor Dooley , devicetree@vger.kernel.org, Rob Herring , linux-rtc@vger.kernel.org, Heiko Schocher Subject: [PATCH v2 3/3] rtc: rs5c372: support eco mode on R2223x Date: Tue, 25 Aug 2026 09:19:18 +0200 Message-ID: <20260825071927.4090460-4-hs@nabladev.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260825071927.4090460-1-hs@nabladev.com> References: <20260825071927.4090460-1-hs@nabladev.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Content-Type: text/plain; charset="utf-8" The R2223x can run in an eco mode that lowers its current consumption from the backup supply. Follow the ricoh,eco-mode property from the device tree: enable the mode when the property is set, turn it off when it is not set, as the bit is in CTRL2 register, which is backed by the same supply and keeps its contents across a reset, and no other path in the driver touches it. Signed-off-by: Heiko Schocher --- Changes in v2: - Fixed results of a local run of the sashiko review prompts: apply the device tree setting in both directions. v1 only set the eco bit, so the mode stayed on when a board dropped the property. - Leave rs5c372_probe() through goto exit like its other error paths, instead of returning directly. drivers/rtc/rtc-rs5c372.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/drivers/rtc/rtc-rs5c372.c b/drivers/rtc/rtc-rs5c372.c index c65b76cc0dc6..9ab6f2c28f7b 100644 --- a/drivers/rtc/rtc-rs5c372.c +++ b/drivers/rtc/rtc-rs5c372.c @@ -52,6 +52,7 @@ #define RS5C_REG_CTRL2 15 # define RS5C372_CTRL2_24 (1 << 5) # define RS5C_CTRL2_XSTP (1 << 4) /* only if !R2x2x */ +# define R2223x_CTRL2_ECO (1 << 7) /* only if R2223x */ # define R2x2x_CTRL2_VDET (1 << 6) /* only if R2x2x */ # define R2x2x_CTRL2_XSTP (1 << 5) /* only if R2x2x */ # define R2x2x_CTRL2_PON (1 << 4) /* only if R2x2x */ @@ -807,6 +808,24 @@ static int rs5c_oscillator_setup(struct rs5c372 *rs5c3= 72) return 0; } =20 +static int rs5c372_set_eco_mode(struct rs5c372 *rs5c372, bool eco) +{ + struct i2c_client *client =3D rs5c372->client; + int ctrl2; + + ctrl2 =3D i2c_smbus_read_byte_data(client, RS5C_ADDR(RS5C_REG_CTRL2)); + if (ctrl2 < 0) + return ctrl2; + + if (eco) + ctrl2 |=3D R2223x_CTRL2_ECO; + else + ctrl2 &=3D ~R2223x_CTRL2_ECO; + + return i2c_smbus_write_byte_data(client, RS5C_ADDR(RS5C_REG_CTRL2), + ctrl2); +} + static int rs5c372_probe(struct i2c_client *client) { int err =3D 0; @@ -903,6 +922,15 @@ static int rs5c372_probe(struct i2c_client *client) rs5c372->time24 ? "24hr" : "am/pm" ); =20 + if (rs5c372->type =3D=3D rtc_r2223x) { + bool eco =3D device_property_read_bool(&client->dev, + "ricoh,eco-mode"); + + err =3D rs5c372_set_eco_mode(rs5c372, eco); + if (err < 0) + goto exit; + } + /* REVISIT use client->irq to register alarm irq ... */ rs5c372->rtc =3D devm_rtc_device_register(&client->dev, rs5c372_driver.driver.name, --=20 2.55.0