From nobody Mon Sep 28 07:17:44 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C25123A7F4C; Tue, 25 Aug 2026 05:43:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787636631; cv=none; b=dLJ+eVYN75TIyGJtrW54k6oDkPnXm2URO/xWsj2Thq5/5w3xSzXo75lVDeo1dBJHUNuhJ+BxbspSgB+LO6GAS+bC6+baBdNR9g1pQ/w454gnB9YYvNG4FtF8hZfd5NK5z75YVV6xpKsPdkPdN+u7jeF6vrNnZhaouqjPQPog7aQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787636631; c=relaxed/simple; bh=f/16kBJ47bSVdkU7GRfgVdz91xbpoWU30jxgMcY/usA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cStUJ/9AAize2DibHud0L4J8i1PBBmXg00rvZBbnlLutl+zq6sFMxbGOXCOkWu2JmfGent4nlIpYDTkSkq4dOULg8YGu39lukwzVHZ7mt9ZGqoKjuttFY0s5dXmHhm9P34W6TtjNiwSld6tWerde9Vi/8Pk5KUe7adgveEsT8dw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=DwRHN5fy; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DwRHN5fy" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1787636629; x=1819172629; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=f/16kBJ47bSVdkU7GRfgVdz91xbpoWU30jxgMcY/usA=; b=DwRHN5fyPDYpxEIpCJZbsrp5xcqFHL3l9+JG9CztIGYm96GdOEp95iGQ /VtXJdnhUAFD+Te3tTxc7HzNPUaNNKdH3L0Ulq3xpTPoJjpS+iwUUt/XO KA028KSNj953Fc8lozYVNdH0zPHOEcEgZkn5YmWQfKDtdeLnh6Ty5Czu6 jYulobkP2aUy4KLMMZrc3a8ut/ujKP0eRKIDcl87jYgVC6izUrasGw2Sw 0XDn+wnI7jIwG8fPwggsybdTZqACxA0BIRma7CAtGMNtjQ1DMtZgrMSCT JXogORnRpyyQg+nfx93Rtef/qs6GsjWLh3CejCSCKgZc8xSsvP+0czG4R g==; X-CSE-ConnectionGUID: rOwDtRdsQvSryC6UFqUtOg== X-CSE-MsgGUID: lbzn3+/ES06TgNtwm4l7Ag== X-IronPort-AV: E=McAfee;i="6800,10657,11885"; a="88152512" X-IronPort-AV: E=Sophos;i="6.25,242,1779174000"; d="scan'208";a="88152512" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Aug 2026 22:43:49 -0700 X-CSE-ConnectionGUID: qFNzBAs7R8GtfBuV4GtguQ== X-CSE-MsgGUID: vCV7bPe+SQOcWsPhZwoCSA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,242,1779174000"; d="scan'208";a="272418216" Received: from unknown (HELO jraag-Z790M-ITX-WiFi.iind.intel.com) ([10.190.239.23]) by fmviesa005.fm.intel.com with ESMTP; 24 Aug 2026 22:43:45 -0700 From: Raag Jadav To: dave@stgolabs.net, jic23@kernel.org, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, djbw@kernel.org, iweiny@kernel.org, ming.li@zohomail.com, bhelgaas@google.com, rodrigo.vivi@intel.com Cc: linux-cxl@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org, lukas@wunner.de, riana.tauro@intel.com, michal.wajdeczko@intel.com, matthew.d.roper@intel.com, Raag Jadav Subject: [PATCH v2 1/2] PCI/AER: Export pcie_aer_is_native() to AER namespace Date: Tue, 25 Aug 2026 11:12:50 +0530 Message-ID: <20260825054312.1319951-2-raag.jadav@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260825054312.1319951-1-raag.jadav@intel.com> References: <20260825054312.1319951-1-raag.jadav@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" pcie_aer_is_native() was originally exported to CXL namespace in commit 49f776724e64 ("PCI/AER: Export pcie_aer_is_native()"). This is a bit misleading as the symbol or its underlying implementation does not reflect any distinguishable CXL functionality. Change this and export pcie_aer_is_native() to AER namespace, which is cleaner and more suitable for its implementation. Suggested-by: Lukas Wunner Signed-off-by: Raag Jadav Acked-by: Dave Jiang Reviewed-by: Rodrigo Vivi --- drivers/cxl/port.c | 1 + drivers/pci/pcie/aer.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/cxl/port.c b/drivers/cxl/port.c index 99cf77b6b699..00f675163b3d 100644 --- a/drivers/cxl/port.c +++ b/drivers/cxl/port.c @@ -340,5 +340,6 @@ module_exit(cxl_port_exit); =20 MODULE_DESCRIPTION("CXL: Port enumeration and services"); MODULE_LICENSE("GPL v2"); +MODULE_IMPORT_NS("AER"); MODULE_IMPORT_NS("CXL"); MODULE_ALIAS_CXL(CXL_DEVICE_PORT); diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index c4fd9c0b2a54..8660b18bac8b 100644 --- a/drivers/pci/pcie/aer.c +++ b/drivers/pci/pcie/aer.c @@ -248,7 +248,7 @@ int pcie_aer_is_native(struct pci_dev *dev) =20 return pcie_ports_native || host->native_aer; } -EXPORT_SYMBOL_NS_GPL(pcie_aer_is_native, "CXL"); +EXPORT_SYMBOL_NS_GPL(pcie_aer_is_native, "AER"); =20 static int pci_enable_pcie_error_reporting(struct pci_dev *dev) { --=20 2.43.0 From nobody Mon Sep 28 07:17:44 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4A7E3A7F4C; Tue, 25 Aug 2026 05:43:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787636637; cv=none; b=QYmPGGXstKBGIEFkY+jn0G7Lfpbr9ci+JdxaXvvgsWCAjy9LdE99BkLQlU/9G2V1LKA2HW9Nfu3kMGc1fb8KlcMJSjhZkJdwv02s7iQhSS08JqMvJJUZ3RNoKu+zyE6MBtrYOE6neMr2dadYyA7hoUzGkx3+oMCwhpiZuhSWUwc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787636637; c=relaxed/simple; bh=NckCnP6OWUrT+a8Ar5FSx/z1JUqU1muMHZoGOJ3whYU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bmSiKdMD3C/m1aZypowfMQuzqpmSX0gkOBuXvrfh5+9GweWVhdBPNUySV0lF8esaN8CCWv6O1K4CBbYnBJEPlrcKgXNm5CKK5WVkGB9dnYL7vrFFVmPnRLYJ91yd1Ypf59uBh1+2cGJpHFsZMW64kIT3CK1r1nKsBybSLpjgdP8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Cm9F4lMR; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Cm9F4lMR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1787636635; x=1819172635; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=NckCnP6OWUrT+a8Ar5FSx/z1JUqU1muMHZoGOJ3whYU=; b=Cm9F4lMRD5qqIrK193gVfvpTni5yNUcnxVqqgWSskVXiJXAMwv6tVkAm seSaqeqLAZg+iY2kkaqCZKIAVSS+JR+Sk4jOwovwgfLUd4fNIatBd2dJH STIXbxcfkYA6jaNwUqPA+sHwy0zzswYFuKWpodELvh3fMtWTf/+bmgz8J Jb+eiIG/ivlVXPhhRVcA0uOJLhVmID2uTsU8BLzPsjgHUSy9QBtGgl2vo ldwXJqFNc1hICo8+X24BuP0MkVTUVwUKimN0Px+M39+a3tWUkI5d76tTe jg9DvaKOQp8s7NmCxcHFvOcw+gCHwcln2E7p6iO3aOv19nctqZRyIJy6M g==; X-CSE-ConnectionGUID: xeYNzSERTOasEQ/LozITqQ== X-CSE-MsgGUID: Qy07r0C0RWuKUZK+hMo7Jw== X-IronPort-AV: E=McAfee;i="6800,10657,11885"; a="88152524" X-IronPort-AV: E=Sophos;i="6.25,242,1779174000"; d="scan'208";a="88152524" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Aug 2026 22:43:54 -0700 X-CSE-ConnectionGUID: uVLU52bNQX+noE1BJyA8yw== X-CSE-MsgGUID: /bmHWHGpQPGdSX2Zhu/uNw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,242,1779174000"; d="scan'208";a="272418233" Received: from unknown (HELO jraag-Z790M-ITX-WiFi.iind.intel.com) ([10.190.239.23]) by fmviesa005.fm.intel.com with ESMTP; 24 Aug 2026 22:43:50 -0700 From: Raag Jadav To: dave@stgolabs.net, jic23@kernel.org, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, djbw@kernel.org, iweiny@kernel.org, ming.li@zohomail.com, bhelgaas@google.com, rodrigo.vivi@intel.com Cc: linux-cxl@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org, lukas@wunner.de, riana.tauro@intel.com, michal.wajdeczko@intel.com, matthew.d.roper@intel.com, Raag Jadav Subject: [PATCH v2 2/2] drm/xe/ras: Enable SGUnit PCIe error reporting Date: Tue, 25 Aug 2026 11:12:51 +0530 Message-ID: <20260825054312.1319951-3-raag.jadav@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260825054312.1319951-1-raag.jadav@intel.com> References: <20260825054312.1319951-1-raag.jadav@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable SGUnit as a PCI endpoint is not AER capable and requires explicit programming of error reporting bits in DevCtl register of it's config space for upstream error propagation. Hack it. While at it, add native AER sanity check for upstream port before programming SGUnit register. This is as per pci_enable_pcie_error_reporting() logic implemented in PCIe AER driver. Signed-off-by: Raag Jadav Reviewed-by: Lukas Wunner --- drivers/gpu/drm/xe/xe_ras.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_ras.c b/drivers/gpu/drm/xe/xe_ras.c index de4cb9ef7355..c4b5c0b5eb0d 100644 --- a/drivers/gpu/drm/xe/xe_ras.c +++ b/drivers/gpu/drm/xe/xe_ras.c @@ -3,6 +3,8 @@ * Copyright =C2=A9 2026 Intel Corporation */ =20 +#include + #include "xe_debugfs.h" #include "xe_device.h" #include "xe_drm_ras.h" @@ -234,6 +236,9 @@ static struct pci_dev *find_usp_dev(struct pci_dev *pde= v) return pci_upstream_bridge(vsp); } =20 +#define PCI_EXP_AER_FLAGS (PCI_EXP_DEVCTL_CERE | PCI_EXP_DEVCTL_NFERE | \ + PCI_EXP_DEVCTL_FERE | PCI_EXP_DEVCTL_URRE) + static void ras_usp_aer_init(struct xe_device *xe) { struct pci_dev *pdev =3D to_pci_dev(xe->drm.dev); @@ -251,6 +256,14 @@ static void ras_usp_aer_init(struct xe_device *xe) return; } =20 + if (!pcie_aer_is_native(usp)) { + dev_warn(&usp->dev, "No native AER support\n"); + return; + } + + pcie_capability_set_word(pdev, PCI_EXP_DEVCTL, PCI_EXP_AER_FLAGS); + pci_save_state(pdev); + /* * Clear any stale Uncorrectable Internal Error Status event in Uncorrect= able Error * Status Register. @@ -279,6 +292,7 @@ static void ras_usp_aer_init(struct xe_device *xe) pci_save_state(usp); dev_dbg(&usp->dev, "Uncorrectable Internal Errors downgraded and unmasked= \n"); } +MODULE_IMPORT_NS("AER"); =20 static void ras_send_error_event(struct xe_device *xe, u8 severity, u8 com= ponent) { --=20 2.43.0