From nobody Mon Sep 28 06:36:20 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 573473955EB for ; Tue, 25 Aug 2026 11:41:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787658110; cv=none; b=lu+C0XTdmXi1M5GzF+TrrvtQ/JGGo3nXcc+fmUjZuLknjTAnS5M4i/iKm2+lv9k7+RrXE5dQ5YmJYEeuxj94hU2SkmwnzzRL2ex+BWZtgPniUKpwrYDh/nPEOw+j1U1vlVW+T+giTblTwZlkJV0MDwymHWKSzZUHku7yORHQ/RY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787658110; c=relaxed/simple; bh=wosuwikMoz3gDvLoC+hERTwDj0vuY/3L2+sga5V0z4w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=deMpzUj7TkljtP0epCJFNaW9qPvkimfS5kQ32397rnqMLZtWybRFDwt99nRwJj8Rjd2r25dOgX7iN/0gKTJYLvWUQl2HRFykbzruV7NrXu7JPrPddT/qqCZxyh4CX8c0L+UEq8d37fpsvqxL59hn2u1NvZ/36rIm+AMo9CYuIAs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Am4l/S0H; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BWynQ+Ju; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Am4l/S0H"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BWynQ+Ju" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67PAvNmL1251282 for ; Tue, 25 Aug 2026 11:41:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=yQKcjQhqJbPmjn8LPqLdh6 zUEBmJh7PLXDIlBz6jV9Y=; b=Am4l/S0HS7bmVodFScqKwhK4JDEBMkPq0QJ89/ mgiBRQ4evtSoZ2aD1xhFP5dR+ZBPjxMrA1lCXpDizYiOtQ6X5LpL66RSOBc9Blv7 nTuif9VcwZX2D4xY8OMKwBAx0p2mh2f0Ime23Nzpz96zoUgMSVZcKL1uda/MSHJj wm5Nxh+PxuxUCSOzFLKpNoA5Jakh+1/4LKQSKwZKRgIQ2toXPnx6xusX86lQt6Z8 RtScNkvG9oSJ0MEcUGW1xUoAabJD13qt8EOmWhDgcJ+UNSsgmBOHYAl3ske7oiZH UDXag21S0sWc0cMuTGCchXlWlj5UUa4cAqJej31H8ysylbng== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g8t3dur0c-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 25 Aug 2026 11:41:47 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-5276aa86d00so52967661cf.2 for ; Tue, 25 Aug 2026 04:41:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787658107; x=1788262907; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=yQKcjQhqJbPmjn8LPqLdh6zUEBmJh7PLXDIlBz6jV9Y=; b=BWynQ+JuhKaRXyOLEfZmYvfLqiPPkS1SdJvpoPKEoO5fyORE0Nd3dY5MsfXF0yPyb3 Kb5YuQzvZn8u+efBuahFqZicvXQUDMPuAcAH1E93KFGgLfWqeAqAnRQjqQeRdrguHAnT 200mib/F+GDog0wnV0thzJGu9jYxVaNBeFYSQvUoOqTm72SXSJWsq2Yr3kzNzbnAH+lS orgFfW+VmzNR6Q0X19cBeivy1x95pmpFPHTb7YJobsjSrZZJJgy5mFcjF2hWOj/2wGEG 6DOtRvwZybFogVh/efLxiV4rNZhgAc/dElHwsv4nOPqARWyntZnANTCxCdzxXcUk1Z8o NeMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787658107; x=1788262907; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=yQKcjQhqJbPmjn8LPqLdh6zUEBmJh7PLXDIlBz6jV9Y=; b=WuR4VpdrE65qfmnDuaciRxN3niQ7vflrvT8wIwWbdQxS9XrEs2pLqAZaII376RCXdJ O1I8Dp7/WY2bLqy2cuVHYeGROoL8nuWPaKDR+3dY9rjKuzrTego7zZss8MoFUH3/mfqg ZjYrzPdBhAwuUfvbutwbp3vXJNakfWeIWnrN7AzTFvtZUi0M6a2TSH4+oj+4CbQwAO3k Y79ElxqIvKdUuJp7RJ5DsTp0vqZSiR8pctBSk+rA5jnCmW7upD46AFmBC+tGJanJ0Ijp +MgNO8I9hX95ldUbNCb+yYPa6FvOq2VTT9IU52SL5ZXjOcJZvyAQqAMDn6Clz4lhPogW SgoA== X-Forwarded-Encrypted: i=1; AHgh+RqbxTFir+QvgsnFMnGzbDgKW3DE0oDVuNtPEWT8eZoYYMsxrhrjyWvojxd3FlIw/NnOpl7UnkVPPgkDA/A=@vger.kernel.org X-Gm-Message-State: AFuF++msK/R4/TCVGjwotKqce9NzEnragE/51UAJfoHiHY5E9+97IA29 2annt03W7ynyKWsykwpf9he5C9gekvg8vYNI0bUwu/YGnLnWAzLNBJZIopwdPfxR8imQPI658Wi cGNEi3A7bvEXp0KMsykinaUMwhVDGbyUhNaApuP4vsCeqSi/kCXEeC5xiSNgsMrDulRo= X-Gm-Gg: AR+sD11svNuDyJL7DyEMv7v9ccAd4+H8GR9awa/dfBNPS4w/CN+GTs/iVIiMoB6Tsw5 s29IoaYbqeMFWzvSJWhkE/lwpeIA81hcGpTNKMs8xdGSze9Cs6t0HZYBCKenyUBRn4IomzCj+iH AMZ8Gy8UhqeAbkgc6vF8PQ4MTn5gzX/9h9Q6K/EfkHUc0Xp+dKJ/yeXFG+sbWqp+l+ekeoK1sUv YY/YHn4ddRwJ4Uh4IjQedsKcXOLDYjAK0JUxO9ESrNXCM0hljHvQXifk3k7ZxpFGkmzQ/Y1kQJR 64DSjSe7gzIz8f3NyNZ0zyzpFd2hRIZ2gWSX+/DmksOgE/oWQnChyEKp3s6m/X7CU9ToB1pBnzU xVGHVNQ== X-Received: by 2002:a05:622a:4d08:b0:51c:805:1be3 with SMTP id d75a77b69052e-52e2f1453aamr61072081cf.31.1787658107113; Tue, 25 Aug 2026 04:41:47 -0700 (PDT) X-Received: by 2002:a05:622a:4d08:b0:51c:805:1be3 with SMTP id d75a77b69052e-52e2f1453aamr61071491cf.31.1787658106527; Tue, 25 Aug 2026 04:41:46 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c24966f809bsm1918957066b.41.2026.08.25.04.41.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2026 04:41:45 -0700 (PDT) From: Abel Vesa Date: Tue, 25 Aug 2026 14:41:31 +0300 Subject: [PATCH] PCI/pwrctrl: tc9563: Use gpiod_set_value_cansleep() for RESX Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260825-pci-pwrctl-tc9563-use-cansleep-for-resx-v1-1-0dbe7cfd8200@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAGp/jWoC/yXNSw7CMAwA0atUXmOpDSR8roJYFOOAUZVGdgqVq t6dAMu3mVnAWIUNTs0Cyi8xGVNFt2mAHn26M8qtGlzrQntwHjMJ5rdSGbDQ0YctTsZIfbKBOWM cFZVtxhi4i8H73T4S1FpWjjL/TufL3zZdn0zlm4d1/QC1tfeaiwAAAA== X-Change-ID: 20260825-pci-pwrctl-tc9563-use-cansleep-for-resx-f6e1f65547fc To: Bartosz Golaszewski , Manivannan Sadhasivam , Bjorn Helgaas , Krishna Chaitanya Chundru , Bjorn Andersson Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1833; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=wosuwikMoz3gDvLoC+hERTwDj0vuY/3L2+sga5V0z4w=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqjX93aTtbHW+c5FVSm6Qi/5RABaggkVD9OOoUw BGQLXYUdLCJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCao1/dwAKCRAbX0TJAJUV VtDfEACIYJ9ZJxpvL+O/tDgWUYRCxg9cVsV/0tXOcQffN0BVrYm4kY8MzTY1o/8r73cdAd/sNil HMWvSxziWOObklwqhh7aAJjmEFB4uIrcGTxG1Fv4xJIOcSyRCwQipgnNnmN3nOJd4jb+rB9FgvB 6OeOafvfYwwWSKFtu6xBwTL/9RRKo1ujiV073YgkxLpI25ceOExTI5I4Bm5rACYQM134O2peTUi yamS7YclM/DS2w0Lo59jWh4VLD0OrOBixHvXwnX6+dKU8Syud4JIL2jLk0eYCT2Rba7GbEnUkjm ub+00p9afEZHxhJqC3qrwgn/U6YQ9O+X67qKb4n0BgkgVzCejzqaX0pcSLoEeQRpIJyP8LFfXgf w94xUs8k65kc+gg9lwL8F7qYAFr3Sfu0nDqDfwdyx0tqC/uutW4ukFZ1CIUSfssPdX22hRzhdMb pKdYzwoje5yIB4FwyiWdARAwZlM9amyk+aPdmIFErKnR/bC37V7BHzqOCZ2CHP6Pt2kC6Ff8QXK ba1zglehI7x8hXUUfzA5je9Ub0puWiZJBmFtBc1gGWv53knGLiXvflLqcDE5poDRKtfrMAfNidY pzJz/mEPtlS+Dmv/W1HeKunDFkVp1n2yN/ZROfkvMuDlzmEp69hkD9VRLAPrAJXchXhuXv8ZYVm do5SuruaTE/K7uw== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-ORIG-GUID: hvWmQPVdvUPCp-BMw13La4Ve9N8T4s2h X-Authority-Analysis: v=2.4 cv=OLAXGyaB c=1 sm=1 tr=0 ts=6a8d7f7b cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=clBUptZa5v5FR042Ey+sjA==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=zkraGWfKDus0AwAJxKMA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: hvWmQPVdvUPCp-BMw13La4Ve9N8T4s2h X-Proofpoint-Spam-Info: AW1haW4tMjYwODI1MDA5OSBTYWx0ZWRfXzQJaNHJ37o1F xKGCRGzovWWMebfp8ejWtyxvJf+7Adz8p3rymTOg6l3Vukx0GwIgb4eTZ1Lccpf9gijygPI4im1 e5DMWKA8q5yt7Knco0cngE/SrXt5QJA= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI1MDA5OSBTYWx0ZWRfX7qQdUjW05i8i l0Gv3DtAyXh09wZotoXnlI7Jv34M8DnrsSKTbL9eMM1yoKktzA8zyhCCwR6uTqu5LHOlcWIxvxl K34inV1H6gqNtwKuGaI05zF2xW5oEMpqpera16azZd55SnQHSgiPGFaLMi5qJsbBpUeAm1k065B BWOlNVkYkt1bI08fgFOSO6fa0I1KIFwumN2e0nGRyOdiT4e2eQPTccNrqi2leOHV8ZMR7dvjrxp 5H8zVXojjYHs5E5bk1VPSQxWNcMQxZjbiR9VRO0DQQJSKt3vLxI2xJLZI8hevLKmSLZ1pstHDV2 9DwHSPcfBJnkNWwW6speL3oICXxZ/exrHdyDohNA5uXn2DA6OZP73CATz6xlFfMLao/t5prbJS6 /C2hxksfTyLvG5c4zrD8SaPSFxlW9FyYaLqB6FcinnKSgRLa+5I55mwA8MIHA+dFbVKIinTioMm G0IgrDdJJYzcd92S6DQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-25_03,2026-08-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 adultscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 spamscore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608250099 The RESX GPIO may be provided by a sleeping GPIO controller, such as an I2C or SPI I/O expander. Calling gpiod_set_value() for such a GPIO triggers the following warning: WARNING: ... drivers/gpio/gpiolib.c:4030 at gpiod_set_value() The TC9563 power-on and power-off callbacks already sleep while enabling or disabling regulators and while waiting for oscillator stabilization. Use gpiod_set_value_cansleep() for RESX so it can be driven without triggering the warning. Fixes: 4c9c7be47310 ("PCI: pwrctrl: Add power control driver for TC9563") Signed-off-by: Abel Vesa Reviewed-by: Bartosz Golaszewski Reviewed-by: Manivannan Sadhasivam --- drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c b/drivers/pci/pwrctrl= /pci-pwrctrl-tc9563.c index fd53a7db9875..1b7718d07d15 100644 --- a/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c +++ b/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c @@ -481,7 +481,7 @@ static int tc9563_pwrctrl_power_off(struct pci_pwrctrl = *pwrctrl) struct tc9563_pwrctrl *tc9563 =3D container_of(pwrctrl, struct tc9563_pwrctrl, pwrctrl); =20 - gpiod_set_value(tc9563->reset_gpio, 1); + gpiod_set_value_cansleep(tc9563->reset_gpio, 1); =20 regulator_bulk_disable(ARRAY_SIZE(tc9563->supplies), tc9563->supplies); =20 @@ -501,7 +501,7 @@ static int tc9563_pwrctrl_power_on(struct pci_pwrctrl *= pwrctrl) if (ret < 0) return dev_err_probe(dev, ret, "cannot enable regulators\n"); =20 - gpiod_set_value(tc9563->reset_gpio, 0); + gpiod_set_value_cansleep(tc9563->reset_gpio, 0); =20 fsleep(TC9563_OSC_STAB_DELAY_US); =20 --- base-commit: 4b18edbd8e70f7e6860d56370f13244896d0f95c change-id: 20260825-pci-pwrctl-tc9563-use-cansleep-for-resx-f6e1f65547fc Best regards, -- =20 Abel Vesa