From nobody Mon Sep 28 08:12:16 2026 Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010023.outbound.protection.outlook.com [52.101.201.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EB65364043 for ; Mon, 24 Aug 2026 17:50:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.201.23 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787593828; cv=fail; b=LDlL5j//wcXctUrTVmqKUtDIijP6VGdm0JFtp7Rgpx5yPRbfCey7Rs2gRIUIOsMaVSZzbfriBHBtDnwfGMzBnI3YqxGquoBxYq40Cn/EUfK4PT+05Uc1cYsCZHFaoly7uxjvaBPgPY+XsHpecAJJYtIBx6Wt+vZwg9DAi43ZxoA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787593828; c=relaxed/simple; bh=JItpSyXb4Xbe4NdCdyLjq9DQpZ5qsPez8InJ5umfj7c=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=hLp3590ZFFK+vIrV0FACQ0OdR4D7RnThGutisyEt+YCdaoYgZ2bR+W4Ay8v2ULtHLO2ZOCv4TWX3tjpkWHeys4ujNRgS3q8OpPoYNK2ozNv6MG0sm7ZboNnjy1azvaA+UvCOLYOjCx4Qlqcl/PSqvIwWy5Zpdznm2evHRYoHCGw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=5saFFLC/; arc=fail smtp.client-ip=52.101.201.23 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="5saFFLC/" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=o/JKtJ/i+aBZ1RiIHCJdzVfy9bv/ZdJa6UwV0r5U9SrIkun6Ir89qsgHb5I5M0qfMGfo5sy9nvJgIGofMsYLIMbw/NdlqWZ5MALQ5a6fd88WKIepe9rns1ncM4ftYggWdeTOcn3h9rj9MbgZMnhUr4NQyI7RSyXvkVbOJ4RbQ4tFuNSToe+5Sr2bqhLdPa1TeHuNH0UW5lOi6275GHvFyA61YE/XCgTwojDhrog1g5Qf1O9Yjr0f3LBKtdrK3JYbWETOZc+dBMEUmphZtgzB0W+eewMnZBujnKA2JHbrws2dfeTI+6jaLSKdWM7OyTI9bzT3QqBRcZa6QgxJsA7UYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l7uOcNSXZp2JiXPqT9+GVA54y/ILlR6f6/tUO2Yr+U4=; b=P+TspGd/XygiVXAln1cHp0/STe4QkaEn56xjWV5FY7UwdZs9rXpWwU18m1CZRO26NIQVxBL3zf+wQ9SOq/CLwjFKqen5+5z6hTS9I7Gm+23urSAs4kTp4J70/tZ5tZzNLRKcQAbecMzb5XxTU3dsvJ1XTBEOfEDCdZSO4vX85M6+0yll20Im9g45vhgH/5JjsZCff5a19c3lnxxCmxk5g4O01r5s6YE6+dwUQEQ3gVoDhoDbc6ZUSTRehCL0ETkbJIn7hp6PNuRpYAMrK9MFPVXHEriIpwDEsh0pFALr23WadFqL3JE0FbU6XDBLF8eHg7VzgJquj0z6rfvoO3jLdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l7uOcNSXZp2JiXPqT9+GVA54y/ILlR6f6/tUO2Yr+U4=; b=5saFFLC/abgQlGMH5dI3txFyM5bvrxeyEh2DF0JjFrLF1X1up/xwtvB8wAFvBIsiPLGhTP7vgdsJftIDObnwc0o0FHb3BBx6JKA4z1eeftZAKxhXLAG1rNi7Cl0ce3negS33Bp8fX7h+mMskjfn6q802tELtp/SNq6q2jgqRc9o= Received: from DS7PR06CA0019.namprd06.prod.outlook.com (2603:10b6:8:2a::18) by PH0PR12MB8774.namprd12.prod.outlook.com (2603:10b6:510:28e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.12; Mon, 24 Aug 2026 17:50:20 +0000 Received: from DS3PEPF000099DC.namprd04.prod.outlook.com (2603:10b6:8:2a:cafe::2d) by DS7PR06CA0019.outlook.office365.com (2603:10b6:8:2a::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.339.12 via Frontend Transport; Mon, 24 Aug 2026 17:50:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by DS3PEPF000099DC.mail.protection.outlook.com (10.167.17.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.360.3 via Frontend Transport; Mon, 24 Aug 2026 17:50:20 +0000 Received: from quartz-7b1chost.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Mon, 24 Aug 2026 12:50:19 -0500 From: Yazen Ghannam To: CC: , , Yazen Ghannam Subject: [PATCH] x86/amd_node: Fix PCI device reference counting in amd_smn_init() Date: Mon, 24 Aug 2026 12:50:03 -0500 Message-ID: <20260824175003.335196-1-yazen.ghannam@amd.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF000099DC:EE_|PH0PR12MB8774:EE_ X-MS-Office365-Filtering-Correlation-Id: 05cb5471-7ed9-4438-aac9-08df02082a6d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|82310400026|1800799024|36860700016|376014|10067099003|56012099006|18002099003|11063799006|13003099007; X-Microsoft-Antispam-Message-Info: 4B/dL/Yefmj4tOvx5JmKZcxjlpaX5N0iHPurkqW6uLe206uOThPdVr6CGTZkCrrg9Rvg2EMmgritjssjZ1rIsNphXIVaOKC2/8prN8lElEax5PON8lrlnzbH80pwCfHHDnG/QtVXsCvq6L2gkAnlNOJcVsl881lhQzkwyTOn/wLw5B1jFmgQcr1MOFU+5JPICrJp6uMmHP8TvNHa6FiyQuoh8J9BF0ZboH4aSyQtNAEM+yBswBqWjnv/m+Me65neLoAgJM+4U274W+8oB+ZJptsWmXyWS0Z7HzXnCJ/MeTEn0yy+A10otpbsoW7usbFi9Qqphjut+4SjiHZQzC6Te96jsAjEfjRsev8msSrhnQmyJVPqFkdEfbONiJUsmws6nAusr3b+A3url6XoLvxIljkgjhWZ8RpjHrMGJWosee/oyXQrp1N9dCgQJvwW8XQFGtwDjJA0MZdoFQzvGCqbQV+WyHv0WDUgtjFgDW9TM+BxxoqChqNltwqRoh1loI3UvK6PD0dZuxvMvi/Mnp6ofcjAt8IG98h4mZ8C1ZnMCf6kZK8PYjPoHIxMM5VRaVxAlL4ayWLjHtJ3Wl7WVFWG+ty5KAD8oR5Nv55uSDaOKIf5MJJMruC0I0ygNt+1AvpOnqQRnzy5P6kae/pyJ9YtQw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(23010399003)(82310400026)(1800799024)(36860700016)(376014)(10067099003)(56012099006)(18002099003)(11063799006)(13003099007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: rVSRWkTgwtcnRVD8KGCX9yH2Hgk/SahTs2A1kZpOOlZkzFjhkZUFgEoDGy3TIRiGFiRY7Ar6aA4/z9E6LKstFQcDZpy4DbCLzN7QSWduc3wbQJegbIoQGs/o8V+matrKOtS+x/Dtfs7FOgaEP09F1rJPWiMvEOtwbMWI+a4FhvZJmQq3Pk3nWnY3Xxnd9IqBRq0uECt5qsyds1s5ZnlQqdnpk+Ouuhcp6PALLHzwk6vpLj1UgXQVrdtl3XvC7TTQDwASvqhJjVl1nbuC3mt7tMrurxlV8nhou2b+D3FSu+A6W5Q3qFOFQg0kcbcCc4fPP3aptd3YGKWVwA7w2G6KdlnGW9Z1hWTb56zzRvp76owNSBubnZM+DSd/qYQahMwXfYOvkityoRB8lZFZYxvpS86lBwNBIxnyr+r+u3uQ63Bkr0LSbKE3/MMUgklQLx7E X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2026 17:50:20.3990 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 05cb5471-7ed9-4438-aac9-08df02082a6d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF000099DC.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB8774 Content-Type: text/plain; charset="utf-8" The local "root" pointer is a temporary variable used during the device search. Therefore, refcount related to the search iterators should be cleaned up after the search is complete. Use the __free() cleanup macro to ensure the refcount is decremented when the temporary pointer goes out of scope. Additionally, increment the refcount when caching a root pointer. This ensures the in-use refcount is separate from the temporary search refcounting. Fixes: 0a4b61d9c2e4 ("x86/amd_node: Fix AMD root device caching") Reported-by: Sashiko Closes: https://sashiko.dev/#/patchset/20260806160159.230453-1-jason.andryu= k%40amd.com Assisted-by: Claude-Code:claude-opus-5 Signed-off-by: Yazen Ghannam Reviewed-by: Mario Limonciello (AMD) > --- --- arch/x86/kernel/amd_node.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/amd_node.c b/arch/x86/kernel/amd_node.c index 0be01725a2a4..312adf73313b 100644 --- a/arch/x86/kernel/amd_node.c +++ b/arch/x86/kernel/amd_node.c @@ -247,7 +247,7 @@ __setup("amd_smn_debugfs_enable", amd_smn_enable_dfs); static int __init amd_smn_init(void) { u16 count, num_roots, roots_per_node, node, num_nodes; - struct pci_dev *root; + struct pci_dev *root __free(pci_dev_put) =3D NULL; =20 if (!cpu_feature_enabled(X86_FEATURE_ZEN)) return 0; @@ -258,7 +258,6 @@ static int __init amd_smn_init(void) return 0; =20 num_roots =3D 0; - root =3D NULL; while ((root =3D get_next_root(root))) { pci_dbg(root, "Reserving PCI config space\n"); =20 @@ -297,7 +296,7 @@ static int __init amd_smn_init(void) continue; =20 pci_dbg(root, "is root for AMD node %u\n", node); - amd_roots[node++] =3D root; + amd_roots[node++] =3D pci_dev_get(root); } =20 if (enable_dfs) { base-commit: 8d3ae59288f1e7d58d76558a6ee96d533bc5019f --=20 2.43.0