From nobody Mon Sep 28 08:12:16 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5193C417BF9 for ; Mon, 24 Aug 2026 14:28:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787581697; cv=none; b=WwRUvflrUoh/GRUglf5APT6Yb1pPL02gdAUiMILrLKGR40Fd4ZshokpIa5QypSxojr7mGSq+cwlawoeMk/TSKAPvhx0Jbd/wk+MQnm9Ooy2HloW3x+EDXhJsfiPsHGpolOUVlu4Hcft3cfiJn2VmuR+6GhzqFSEirE52wiGGjUc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787581697; c=relaxed/simple; bh=CyvFyzFd1gbYPxjEkZ4TAXB+esuJNZ3LdYISRv/gmHA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ESx8aH1d4eEzlAPz1d5L1XUs7o1kOBjTDAS4j6xgdiZnGE2DdYdFezGCVeiTyuB50q/aBo78Kq79mf92WCSErpMffPb2KTWxY7A37qvAmspldFONY5j9Vh2vWEbeT3iIIHbb1Yxs8a7f1CYafjw16wNgcFZ4O4UR/sB7ZrC2e5k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FdFvtps3; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FdFvtps3" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2cfbbdfa60bso28371575ad.3 for ; Mon, 24 Aug 2026 07:28:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787581696; x=1788186496; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=CZRV0fsadUb2RGyF330MZobT+Dwgs5Uikgpa9gJZ9qc=; b=FdFvtps3vBp2OgEHODb2betFLZ8dXjAuqcCsDFp5DaHX5argoBXrLtlCk85VJ8HZaI RNyUxhlN/UMPIo1W1Gk6wS0AABoukTA1dvIJSZQI17BfEPEveZGinTyBov0i0ahnF/XK OpUNCdFVcB5rUKrFzhVQc2dBa+B/PwDFCsggOR06SyqUtwSx1St1AgnoXXRefxJ3nqzP GKYhryA7iDO4jaQaMJTerIobdcsyLFiLcJHM1kjS1bLHenWB153YXCvRZsznkrDAU3jc +NOXyKk4fuE2b5EXKdGhsV+318yUrIMS2CnnOxbXzsR5FQTjgtmDNvL9XE4gW5Fr0tEc zfrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787581696; x=1788186496; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=CZRV0fsadUb2RGyF330MZobT+Dwgs5Uikgpa9gJZ9qc=; b=a8YrUvgolrlkedUVXNhGeQpmGusHgHzKICqs4LCj3i/tNdVE0qhlAgSNeyL8AYyFWq UjbD1KidA8Lt4/TNmEjaJs/mh5iiJI0Tr6vo92HAq+V1hqZLxtNdN3ghn81zJn3+QHIB ryx/lfdaahjBSGZG8ftna44Gug1qe7KrIviqS+aC/DHiRJOShFIr9yoWdl1T91Fw0gx0 BY4cZZ2DA5ME7LzWmklRbgHwXTH+33gXroGi9AzvwuRPsyxitXdK46nxzdX4oVydZQXT eqP/ufur8pRJvXSCeimhfNeCtfmvfwinbTFG8e9ON3fAddXTYw7w7Zzs6pCfsVt2PZ43 jmEw== X-Forwarded-Encrypted: i=1; AHgh+RoHWJGfUT06fs7++Ft9HtN6usSjLCtbw/5P32WxlLsaFpyh0T+ucxMPTm+nNbN7Ox784kym/qZPcrVl57Y=@vger.kernel.org X-Gm-Message-State: AFuF++lddxz7KiqAKstEUDe6KSaBH5+yQ1aOTqdw5b9QtK4Q5RN/2Ml/ xsPS2aNBVJlHbwub/f20C9GDtxvRrzdNBqK0KPYTqsLwIaTheqV/pm36 X-Gm-Gg: AR+sD12A5+YLTSEpkmvThELW4xUhYEwN6almwxMM9d51zvxeR2LbutTtCzYr/7hGC9E 8QeptTWJDGzSm7cyywyPIoHaqAufBBCdLAqRy7jvaGeO4JpwckJE7Yy+ovqfz6Gv1rmjGSazs3F PSgDx9D5mfO8no2z6ko6HNhM50WryAGqMdzqTOmIiHXjwewJ/3D4zZee1GMaqMKsdv1qVqjfgNC PqdgXNM7dNZYF0lbJ5QdA3/zMNTNFV/M1cgBKHYTKJyU3dpZapWvL5bX4Wfvub0ey0UFAT97gXL OeAK3aHSTSI16I4iq4UkNihUQOHmxi2CoFkWf6bdaQbswI8TSmu/nxu6Ej4la9iMEIkTsqRf4jm tZ9G3j9rlasmjMKTooZhuOqNrBcHFAsE9ApAzhIdlXtZL6FsW9Czo9kX5FMMCZ7oEqCBLxz6nlg TIiuCmkdjqpAD+iVYp1LsHw3PtgAIP4ceMWrz9xPCxCVYWQmW9BQRoJ+NqqqXcxrLvism+zdiZr zKPf50OHpkjEIwwvez7UbI1aLkYj77JNjJHXuABwgL5LPyAW/lL X-Received: by 2002:a17:90b:224f:b0:381:1f51:1ff0 with SMTP id 98e67ed59e1d1-395c354d445mr44970306a91.2.1787581695499; Mon, 24 Aug 2026 07:28:15 -0700 (PDT) Received: from hanzj-mi.. (ec2-99-79-140-187.ca-central-1.compute.amazonaws.com. [99.79.140.187]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-395e4a1597csm10201997a91.13.2026.08.24.07.28.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 07:28:15 -0700 (PDT) From: hanzhijian To: Daniel Palmer , Romain Perier , Michael Turquette , Stephen Boyd Cc: Brian Masney , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, hanzhijian , stable@vger.kernel.org Subject: [PATCH v2] clk: mstar: msc313-mpll: fix off-by-one in clock array allocation Date: Mon, 24 Aug 2026 22:28:00 +0800 Message-ID: <20260824142800.3497263-1-hanzhijian1991@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <67ec3261-9f3d-4dcc-b916-19dc8be56a6e@web.de> References: <67ec3261-9f3d-4dcc-b916-19dc8be56a6e@web.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The hws array of mpll->clk_data is allocated with struct_size() using ARRAY_SIZE(output_dividers) as the element count, giving it 7 elements. But the probe function stores the MPLL clock at hws[0] and one fixed-factor clock for each output divider at hws[i + 1] for i in [0, ARRAY_SIZE(output_dividers)), writing 8 elements in total. The final write to hws[7] is past the end of the allocation. clk_data->num is also set to NUMOUTPUTS (8), so the clock framework reads hws[0..7], again accessing hws[7] out of bounds. Use NUMOUTPUTS as the element count so the allocation matches the number of clocks actually stored and exposed. Found by smatch: drivers/clk/mstar/clk-msc313-mpll.c:134 msc313_mpll_probe() error: buffer overflow 'mpll->clk_data->hws' 7 <=3D 7 Fixes: bef7a78da716 ("clk: mstar: MStar/SigmaStar MPLL driver") Cc: stable@vger.kernel.org Signed-off-by: hanzhijian Reviewed-by: Brian Masney --- v2: add Fixes: and Cc: stable tags drivers/clk/mstar/clk-msc313-mpll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/mstar/clk-msc313-mpll.c b/drivers/clk/mstar/clk-ms= c313-mpll.c index 61beb4e87..bd45aa0ae 100644 --- a/drivers/clk/mstar/clk-msc313-mpll.c +++ b/drivers/clk/mstar/clk-msc313-mpll.c @@ -105,7 +105,7 @@ static int msc313_mpll_probe(struct platform_device *pd= ev) return PTR_ERR(mpll->loop_div_second); =20 mpll->clk_data =3D devm_kzalloc(dev, struct_size(mpll->clk_data, hws, - ARRAY_SIZE(output_dividers)), GFP_KERNEL); + NUMOUTPUTS), GFP_KERNEL); if (!mpll->clk_data) return -ENOMEM; =20 --=20 2.43.0