From nobody Mon Sep 28 08:46:38 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D0AF346AE1 for ; Mon, 24 Aug 2026 11:28:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787570919; cv=none; b=m7uRWbJ1x5/8AOveJBZU7/yaGRXOlTlRjAGqB7nqTUYDNHikhuOUI2LpNeOLk7KIO5Q23maiUcgrdrM7ruJpcwwoPAzRv1Sd/z0vmQcBRYgRJHfLpxCVhO5WbSkSodDh5YHKYpWe16vKjeNrIBPQT/g0FUf3sd3CluQCeS0dogA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787570919; c=relaxed/simple; bh=y2k61bLaxakC11xmIND99HCevfgEkScpEhGzbvIkkXg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ccz3ckqtly3fH1S8ayotF8DMFHx6R7z+Leq8epY7cae9VHRX0gNWEuK4GddeguOpzaUfydZAxWBs0Q6b/5ng/coZvP6azws2o7jdtZz6gCOf5k+VIZrXjwwKggbx+W6bbZKruVgmvC4deVZm6jQ9zqbfijv+nDv2DctqQDbJ/zE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DrsQ/At1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=P1QYAzMk; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DrsQ/At1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="P1QYAzMk" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67OBMgww2864725 for ; Mon, 24 Aug 2026 11:28:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vYF8IMeScLS8uXOagtGPkjVovyxJMz305NPZ1OMf6D0=; b=DrsQ/At1BkqIW5SJ 1Ug2h1z697x60kZ6pcWAdp9YIBS5SGu6qE3ugXMp74AS3EgTMN/sF24/6uTy7KGL noFUjjLxKbeLlVCvd5sJ8FFz6NlRHQE3pYoqAP81BkpKfEigkosbAkAuqYFrRvVW R1YvaDvey9yItrInIh8CITS6W1pbtgdf7WeR8tVXB8cPF5HH+FEzawFXLthNSMZJ N1BeLda4Ppo9P8J7leRZHlxXu5QvMl4Y3wsOBlPy/gDC3DznjamJx47gT+21tPXx /uOiI4caUKOhh6r0l+ZP/Ty174Lbsa9ZQCR1Us7Z16cICtj9phkbABlfZagFXLdm mgVdJQ== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g8bdr26t3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 24 Aug 2026 11:28:37 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-38dc085b0a7so6587128a91.2 for ; Mon, 24 Aug 2026 04:28:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787570916; x=1788175716; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vYF8IMeScLS8uXOagtGPkjVovyxJMz305NPZ1OMf6D0=; b=P1QYAzMkKl6ON0EelKI9tdSkg5X52vS/oXdKEH3rpnDjb0pA0It1hCS6RID/3NZzbX wcXfxaLEW4VDdDeK1LoBvEROY912buStkw9+Rwy1oKhOqLLgARDkRPxRg+E62crGpRas D3kkLjHLdNJDAIokujV83DvLcAh80t5iYiXYInlQaq1ZlncqffPv09nOrfbfctQW7LvK NITKfg1mpudXe0hTuLBF8OtTGNDnKajpHdlqQo7hrWe8WswNW+vunHK833ukjBVAWeJe A8CfzRGJIK7cJsSTGpDabvM8ovuKgvcU7xBbSEa+MeyaLM6xOSgt9ZqB0QsCFWLCFZk6 ni2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787570916; x=1788175716; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=vYF8IMeScLS8uXOagtGPkjVovyxJMz305NPZ1OMf6D0=; b=CI9gctCIawxKpmgPg0+v2jwgaxZuJTQ344ToTcB9LIiVm9MTuiHoQXsTVIAe4vEi7z sqOZCEymNpGCJoxzEtMYYALMZ7JPc0UTdD0wSxC0Z3dFl0m5ZYA31coF09FSa+fpiD3I kTsFFSXV4Uir/0xHRFvg+d9loHYt+8m3lectKuvIDkhmLfRoiWc+Y6pxCYAEyO3iNKMn 29qdlHmNQymnSiI1SEj4VbUTbdkEDuD84K2dhFo4Y2/YlblBduUB8SmuPK3kpnNQMB+5 JIrBQ7ttS6n5CILvxfNq964EI2HNgmEYn0+j5r/1M6nfZHQSdWBEuGwGLL4sMSDC58Se 1gAQ== X-Forwarded-Encrypted: i=1; AHgh+RrcwI+FYLpjTvjk1yELVy0/sLDq3H/jnQ3Pa60+WW6KOv+awusPvkNDCQwJUKmEDqUpmBF9uXqRGGHl7qg=@vger.kernel.org X-Gm-Message-State: AFuF++noaKSUu8Y7EvhXmNM6yF+Ce4vDYPCB5lVh06d0YmqtpYYEtymS qzEnBH7QaljnjcFtg+JGFaTCg1GiJt8jvVDSDqF8q7/ifBR7PfFknL8ra/gEZA3wSbt69VYRje1 ec//tjtyCzaxwLLZlplL7qHeQ+MsEkmg7wuL51s7c7IRVth69Hy74nnJkKNCjbV2BRxM= X-Gm-Gg: AR+sD12nhEIkwb92waYPgfV8b11f//q/CwfSMBeVhHM6FnrMJTq6aQhTFGCbQliE4n0 HFetqC1qBfzqD5A84QQPoOJiDzFa9EvOHY+KTcOxIggBEhT0u0sllIFMApvkBFOMRF+mKgiRWH9 t1i42ndSUNWpKqkdAbV6RpxW7Yvb7MREu/rYXk2Okm6hsNwIoyQVuIokgHiYU8ApBMLP+ZI57fx jkkvwjln38QFSdpE/3UoOaM4EleqVgiedFJo48j0CFr7fVT0zfSsXlVhEx0zbsLV5dCQBa4GuiN vY4f4f6QTwMyyAk8AkzMPnTc0cwfkKYxmz7D9H34WNUi0EZv3SzTMZU2otFYdgNs643fxEpsib0 Cb9Oa3U7ab9BtzAjt X-Received: by 2002:a17:90b:580d:b0:38f:5869:387b with SMTP id 98e67ed59e1d1-395df24e757mr34344895a91.9.1787570916300; Mon, 24 Aug 2026 04:28:36 -0700 (PDT) X-Received: by 2002:a17:90b:580d:b0:38f:5869:387b with SMTP id 98e67ed59e1d1-395df24e757mr34344681a91.9.1787570915598; Mon, 24 Aug 2026 04:28:35 -0700 (PDT) Received: from [10.213.109.15] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-395e4af750esm9825643a91.11.2026.08.24.04.28.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 04:28:33 -0700 (PDT) From: Saurabh Anand Date: Mon, 24 Aug 2026 16:58:04 +0530 Subject: [PATCH 1/4] phy: qcom: qmp-combo: delay Type-C mux switch while DP PHY is initializing Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260824-qcom-dp-typec-reconnect-fixes-v1-1-2825e5bf8a96@oss.qualcomm.com> References: <20260824-qcom-dp-typec-reconnect-fixes-v1-0-2825e5bf8a96@oss.qualcomm.com> In-Reply-To: <20260824-qcom-dp-typec-reconnect-fixes-v1-0-2825e5bf8a96@oss.qualcomm.com> To: Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Ritesh Kumar , Vishnuvardhan Prodduturi , Mani Chandana Kuntumalla , Mahadevan P , Saurabh Anand X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1787570901; l=1390; i=saurabh.anand@oss.qualcomm.com; s=20260824; h=from:subject:message-id; bh=y2k61bLaxakC11xmIND99HCevfgEkScpEhGzbvIkkXg=; b=YnnBPYMDGOpuT28P13YjgvNgaUOm0REayyFOl+w9n1bbmuJYRSC7ZPy5YJYHSEBYNFN1d8YLv Rc8x5As6KkpDsdlwWZrEpgf+gGmLjqagkMCGtUsW2tIEzhikWNOlVr7 X-Developer-Key: i=saurabh.anand@oss.qualcomm.com; a=ed25519; pk=AzGwbGUPO11yi5XTeGyJKOJWLfzXp5Dru4z+PCg/uXs= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI0MDA5NiBTYWx0ZWRfXzToML31QM5tz qWP07U7ErjSb+cqRh0Dc+Rx4PeDsUr2SnblxS6lAYodzzxtvGPVuppEoFYGFLKcKdCY97V/I/0E 1RNOHsQfFRK8TbOAlECvkm4L0SY6bFxOfJhJJDo2ciTHM3wpR4sCea0CsKCMpc7FcbZwL9gXdBv URYNSSM2NdanZgrCtbKm5PyW//kWedwFvE/As/X0JYFWlk4Kai57ryTPKO5AHnoeoZ/W40sIBOn GITJLj9v9biiYiwX64B/3tDcFfNFjjQjUDqDVe4J1HnJ3jHeBW2DluZOfrq5DW3RedqZc9tVvyz /MX06of+4CsNst+DI104nmBo5F/cAYcZAJi/7MZQdLXDeWTkflnMhFYkOO/o14ae5OyfDDW2umW qeise0oUzxW5RcykLv5lxgQTxaB/UGEd+6citwnKk+2qGNuP/iEyg4/hjaNbaR8GEn+H67mzSYI r6BfMMvt6EZ7lFUHa3w== X-Proofpoint-GUID: R-j2kFtbU49Ohf7XVUsG0x1fPCkLt1hv X-Proofpoint-ORIG-GUID: R-j2kFtbU49Ohf7XVUsG0x1fPCkLt1hv X-Proofpoint-Spam-Info: AW1haW4tMjYwODI0MDA5NiBTYWx0ZWRfX/XN3Ftz5EM+M Orzh453P+utzPGxRo+oZ+bGFvjwjv0Mi7ET3LJUD5/wjwz01G2PrSq9Ws9aAZoelS5+iB61owcj 1H2xV6Ktb3CZFtnlvQ++tYu8xrfBiNk= X-Authority-Analysis: v=2.4 cv=W8cIkxWk c=1 sm=1 tr=0 ts=6a8c2ae5 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=HxeoS3nH6iSbXD-5zs0A:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-24_03,2026-08-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 clxscore=1011 bulkscore=0 malwarescore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608240096 The Type-C mux switch guard only checked dp_powered_on, which is set in qmp_combo_dp_power_on(). However there is a race window between qmp_combo_dp_init() and qmp_combo_dp_power_on() during which dp_init_count is non-zero but dp_powered_on is still false. A Type-C orientation change arriving in this window would proceed with the mux switch while the DP PHY is mid-initialization, corrupting the PHY state. Extend the guard to also block the mux switch when dp_init_count is non-zero, covering the full period from dp_init through dp_power_on. Signed-off-by: Saurabh Anand --- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualco= mm/phy-qcom-qmp-combo.c index c39ced168d03..f23aff79ca08 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c @@ -4842,7 +4842,8 @@ static int qmp_combo_typec_mux_set(struct typec_mux_d= ev *mux, struct typec_mux_s return 0; } =20 - if (qmp->qmpphy_mode !=3D QMPPHY_MODE_USB3_ONLY && qmp->dp_powered_on) { + if (qmp->qmpphy_mode !=3D QMPPHY_MODE_USB3_ONLY && + (qmp->dp_powered_on || qmp->dp_init_count)) { dev_dbg(qmp->dev, "typec_mux_set: DP PHY is still in use, delaying switc= h\n"); return 0; } --=20 2.34.1 From nobody Mon Sep 28 08:46:38 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8208240BCDA for ; Mon, 24 Aug 2026 11:28:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787570925; cv=none; b=BqfWvHpyr8/uSXBX+zkvG+IWCiI5ZdEqs+HG+C9WXh8isnxiULT+SGmcjcg9lsHm6tjmunwcVghVFhkGgbiYJGZMtL8TUDva5H1Rj9qnzwcxC5dAU0VeA5ZMxeol8OEG/USKH/TOLlQr9wbYotKjdoCWE/a7pCUeXJqJnN7e7rE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787570925; c=relaxed/simple; bh=Mk2iABepIE1j1SqlHuK8xywuEsIdXul0/MUc4PhM33o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Qd58By6ASqoQyHz+acvB1oYiuoJzBL4yRedNr9SpnE+XnZFQNBncq9SoLIpsBiBTJ8Pzr4F2/cmQAM2/rWtteC84Hj6yvZz/EbDvw74O7EzGZ60c4XSYGpjrSomdn7Vs804k/MphESgA+JCfFdxp1VQy4cU/UNjwjYWpBHwqpn8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kgWveR9e; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ELY4wyDh; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kgWveR9e"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ELY4wyDh" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67OBMUO71673143 for ; Mon, 24 Aug 2026 11:28:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ZLZv27GFMdz2STMsdvHGdhaNYpEqqU2M4a1flwXbgR0=; b=kgWveR9eOeTiZKf9 JtBtq/rJHMgjCrLl3uUTfLmATdPeZn0AwKvmmPN97fAtMilH4Gxm7xK3y/nHWGfe XPIn7EF5PdYkyPfEFHyNspHDOCMSFCGe1PpA1QahHxrCvC0kEbTco7H2l24uQlKJ 3j/kUV+uZkXdIj1g6VWKpa44WxmtGf7JqaeVI4xOPllPR8d6fmafJUQSZqAUel7q tQv8JVjkw31hoxsCshcK9zBIHyaaQi/JLtPnelTsaa3dhI9wxb5qIqqPnWPv3Ycu 6c9BWKilvRtOrsR+ceHQOPObRGq1N7w1Qian/vGE/Ytz4djet5IooAoFtgYZUE4r 0YgN7A== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g8huf0xh7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 24 Aug 2026 11:28:43 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c89704da8c7so5000051a12.0 for ; Mon, 24 Aug 2026 04:28:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787570922; x=1788175722; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZLZv27GFMdz2STMsdvHGdhaNYpEqqU2M4a1flwXbgR0=; b=ELY4wyDhL6ydmUUf+8YemyvIUrCIV4QuGyGvwz/UkeY1QxmmIzjPjemkIk4JMiP+8Y ZrZAkYvxCclNc9SfU2S1aID7wVjhpRGmvJ4bEAIXUG7GIeXJR7uHl/iVUDjKb0RPhyhM UMWQgtljyw0lFfFTzRyXgNozOUJEga5x/lqhxLBQUa7Vk8ISk04XWhedvHZnG7ZS+FCs 6qfPzBnJohUOGeuVZ9poCn1RFhMm8uCGbi74+kp9C1LL5moV8zu1fanfJtZhHzAlcsfW Lll8EKd4Fhhc0rSecEVErjKfOW9E/rEu8vxm4QeNXcQ+qS49VGn4THrndYwZUlNXLrn4 elmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787570922; x=1788175722; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ZLZv27GFMdz2STMsdvHGdhaNYpEqqU2M4a1flwXbgR0=; b=OxNMyXdLUt4nyC5haRGn8lhm3ARL+7wVaMtWqZQvFWajI1asJnTufKOF8qeYkAEfMa b8DALLQFb5aDYM3A44SuIHavZytbAfjdDuODdzANqpLuJ3MI3UnBB1yPbBxqCZq86pTD vT45kytZoyb7pPfauH8RmKxdTLXRmOzvxBLo7e+vshVDyU2YgW2labhv2ygTbLFtOARJ zlTH+n+c81KHRqslyZLh1CHZiyBVH+E2bgwqrmgmYGXpHcvjygDZtjD0g8vKbajDSz5A ufofQDiTLfhkzx3m8+BtKYGYU0KSoFttmg5B+1A6ww9lwtqmTM2IEu0m32vZ5aVpO4pw Nzrw== X-Forwarded-Encrypted: i=1; AHgh+RpzWO3ocIqvMzeY7ViwTqM21Bj/KtbuconjBQqpoY+1WWX+THQn4OH1VhXGxjVEF2WtfJZWgL4t3KNDlOM=@vger.kernel.org X-Gm-Message-State: AFuF++lSs7x4RVW384Bnr/nFAJetFv1JqJK5pUDWrloJqkNUCf4ozJnM ndUvL0kbRy2RML9pT08t1ipjtSJdi4XbzsOW2YZG2wewZEYG0yGiXRiB0UhVZKEUiqGGprd3/7t JKau9I09g3Rou7UtwPYuc6dgZQzuO73YjO78WaVLzi3MitgSpL7xkNv7gJEuZDcVeFO0= X-Gm-Gg: AR+sD10HiKnIrSPwfCuZNHNd0C2NZrCMUJeeMeKj16zI6xmvyDOQQZgbq+YHqdIZO0x JCJqviBGFIPthwBhWs0LyGq0Qb2OMIjINecih+TxNNgPaXA27UeXYBS6OQs9/9RBs0i9PE6YESM j7bXa4hh+slRTk5pgyGyI7VEm+p4U0E7KCgU1lqF/AL27JtvI+d7DOP+r+G0tvgtMm2k+551sUZ KejkMtizct01y+QHAH9JnNu1HazyYa74vYTQvYF0FUR9fs//rJYRJ6waFqm7gXsRJBWxiTGj90V nu/9/yVIE0NhL1r2E7T9SHMcIFWFJR0txMV4sZRkH8Bv/aWICqS9zMP+NAwHac3l2Bvv8tAQiWt TkNVvnr/SipUtnyso X-Received: by 2002:a17:90b:4a81:b0:381:a766:efcb with SMTP id 98e67ed59e1d1-395c34fed98mr40733950a91.4.1787570922484; Mon, 24 Aug 2026 04:28:42 -0700 (PDT) X-Received: by 2002:a17:90b:4a81:b0:381:a766:efcb with SMTP id 98e67ed59e1d1-395c34fed98mr40733876a91.4.1787570922038; Mon, 24 Aug 2026 04:28:42 -0700 (PDT) Received: from [10.213.109.15] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-395e4af750esm9825643a91.11.2026.08.24.04.28.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 04:28:41 -0700 (PDT) From: Saurabh Anand Date: Mon, 24 Aug 2026 16:58:05 +0530 Subject: [PATCH 2/4] drm/msm/dp: clear force_link_train flag when link training succeeds Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260824-qcom-dp-typec-reconnect-fixes-v1-2-2825e5bf8a96@oss.qualcomm.com> References: <20260824-qcom-dp-typec-reconnect-fixes-v1-0-2825e5bf8a96@oss.qualcomm.com> In-Reply-To: <20260824-qcom-dp-typec-reconnect-fixes-v1-0-2825e5bf8a96@oss.qualcomm.com> To: Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Ritesh Kumar , Vishnuvardhan Prodduturi , Mani Chandana Kuntumalla , Mahadevan P , Saurabh Anand X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1787570901; l=1035; i=saurabh.anand@oss.qualcomm.com; s=20260824; h=from:subject:message-id; bh=Mk2iABepIE1j1SqlHuK8xywuEsIdXul0/MUc4PhM33o=; b=xSb/4S4PD++J9HOE9OF1wpOpDqfbMO52EZhU9enL2AW1OLH6rpVrajVg5lZG4CpUFO50HQdNr tarYw9mrH7qDRnCK4w60xn724kYZhx8AlG7MKTQybAPWUvWyCxyQNPt X-Developer-Key: i=saurabh.anand@oss.qualcomm.com; a=ed25519; pk=AzGwbGUPO11yi5XTeGyJKOJWLfzXp5Dru4z+PCg/uXs= X-Proofpoint-Spam-Info: AW1haW4tMjYwODI0MDA5NiBTYWx0ZWRfXxOfT2jJ9nbvq IA6pZ3aTLrAvE6aRI9SypLAvrNaSFxtspl9PgX5c2YiAq2RZ6+q7SV/pXoBJSIXxa6dJNdkfxcb 908TNNC6UnYgytYjPayu0VJYCdcpvek= X-Authority-Analysis: v=2.4 cv=Wac8rUhX c=1 sm=1 tr=0 ts=6a8c2aeb cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=rL4VQYfKDX0HzXWNMRkA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-ORIG-GUID: wzrvdQKBIjN7jRmblsww5FNMqMJTHoCm X-Proofpoint-GUID: wzrvdQKBIjN7jRmblsww5FNMqMJTHoCm X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI0MDA5NiBTYWx0ZWRfX3cmQs+pkW3cr Ph8Kwdy+nKa05YA1VPfEE6mrKW1OI8t7TwxsF83c6BNuPgu2BZ7WRhzLZCthqrRXUDn5msr9B++ HUt+HuGaX/L77zTT7wScAKr08lTIMpAXGBmqHT96U7VmepiwS6MVEc9PPnKI8Hn8GHfzth/4/rD S/57KAzu5JEnvGI2wjQ837h8vvYHBxlS3XDeozHOgLAk6ac7WmcCHLKzapfTKTdR1wgazQky0Wc u/fGhMl/CT3fzoMdOS5S3/qntIKw0O/dtPr9IS8gAlOZLWY+E+HBK29nzv8REmT3Ww9+KcgQo30 rgDJoJcVD1VTYei0+GdHyMA8okHvnV2H4pDVWRF7Tr54CK7VTO6QV6x7pDMlbuwealhkA2qu9et OwcfFqIKQ4gNXZYO3Y3X7E4kTROal6YjoeRhedyn9zBPXykfAjivjYJHeF15N1q2yF51yRcnhZC /qZR+NGbKAN1m48YmTA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-24_03,2026-08-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 impostorscore=0 adultscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 phishscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608240096 msm_dp_display_prepare_link() sets force_link_train =3D true before calling msm_dp_ctrl_on_link(). On success the flag was never cleared, so msm_dp_ctrl_prepare_stream_on() would unconditionally trigger a second link retrain even though the link was already trained. Clear force_link_train on the success path so that msm_dp_ctrl_prepare_stream_on() only retrains when the channel EQ check fails, as intended. Signed-off-by: Saurabh Anand --- drivers/gpu/drm/msm/dp/dp_display.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index bc646d172abe..40e19d506a45 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -649,6 +649,8 @@ static int msm_dp_display_prepare_link(struct msm_dp_di= splay_private *dp) return rc; } =20 + force_link_train =3D false; + return msm_dp_ctrl_prepare_stream_on(dp->ctrl, dp->panel, force_link_trai= n); } =20 --=20 2.34.1 From nobody Mon Sep 28 08:46:38 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C045838E119 for ; Mon, 24 Aug 2026 11:28:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787570932; cv=none; b=PQ6/x10krKlKT1LvfvGgG3MFls4U7ymY7sSXZNo7J+5q80NVUeReb50DVm3RVRechd/20MBIV1LJMOf9Zc7qB+vqGh+qvDov7o71/BraANObF89DRQezDUVS5kIjSoHG4+S7u1X/C9oMyYTiqA0mzVYR1F7FaQUH4CP3Ifx0gaI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787570932; c=relaxed/simple; bh=IbcoGzqn73EF/bO8GfdSrufbJAGc5IIrFGhyjXEiifk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PEDVdKy2GuRqEM1uSXlYk2nNCly6dplDUPGA2XSEiR12Lg0lfHvTOShHhGRqy4r+T8KbFfThodEAFvrEO2IeIxUA4U6h8yAj9mPaMNt7JJhAVR5fTluUJ6QZczGw4vjG7zE1hp0JGHrayMFAOkTpXOAF40/Ty3g735wblvhx710= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YUUmRSM3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Y4vOAuA3; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YUUmRSM3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Y4vOAuA3" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67OBMmNV2865074 for ; Mon, 24 Aug 2026 11:28:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Z4joxmXfur7eXOiFFe3oqnFTTbEYcCWRQbkIKaQk2W4=; b=YUUmRSM3CJDubSmL OtcYcHNkHDipg3dVuaMDEehgY+hHE64+B9o82A1Ixo06Fc/kQQfRLkg1Jw6hX17s xm0SlJudYbEb1KNd0nMkMOO3/S7HHj+jN2H6RjYGIH9oOA81dHLP1iwqTAzPtuGq yEW9F/wlV1gOgkwjcmBjU5n7Ch5Ss5tuqmRQRlAE/X2YP5HEitRothDJVJZd0FvD Y9YmMPcoT9EIPyqSmfd6EcXKEUV4eRtrV9EvvIPBCcE+u9xNY7IUYrzl4rKHcJ0A pSFyB6NhMPFcspzfJUIGJONShsMNIiJpPfzPKNq5D0j8eu+4Lwj+8iqhiqJoU8bM tsz/jg== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g8bdr26ug-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 24 Aug 2026 11:28:49 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3954def0191so5893191a91.3 for ; Mon, 24 Aug 2026 04:28:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787570929; x=1788175729; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Z4joxmXfur7eXOiFFe3oqnFTTbEYcCWRQbkIKaQk2W4=; b=Y4vOAuA3fNoJPIwo01k26EGwmG7lNcUPlDrszPNWXM8SVEGL5O8gMif3zx3aJJvNdR r1RjCfERZ9oEpAr4XEFcf5HClwqgiVTghWkb7PiZivteTHIiNMZMlGamdYRrxuJeaAYl EoULZ9WmlHGWy8bKVUy4UH5gdtDvRhIkKdMkf2IYTzdxlmjJEbpEX6hC/y61Kb/MGrTe 6DBF5TZ2UynZwtrzAyK1GatGjC3cGuAT973JG9BbQUqeD/skFc3wY12k2XX/CZk+MIFy KsoXopk5dyNDshQE1gt6Hwgdlw3u7vKKHhWbfPVtcWgLQeMOCoWW2ZUYcbrGsI9xM2HE G2Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787570929; x=1788175729; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Z4joxmXfur7eXOiFFe3oqnFTTbEYcCWRQbkIKaQk2W4=; b=Zg6a5NylLv5QjRtr3FNiyN1UbnY5Q6o+dWIhU9D4l11oL70RXb9qUTUrzU+adSbwEF UXLTxfJnFkw5wg8TdaZ9gtBLPDueSvsJSZ0gP54tg040yQ88ryrrIWGpbGnx7kV2Qtwc iIRyOP3/IMXNtMQ2YyWgv72x4BUJvGrsOLyaRu8AI5saMaehmgMDcuxkXfb9qHxuuJS1 dHvGVOuxajlb58yQqlCCUq/HzPaLciHYWx1Mpczo5TLD9dIZsRFVGXA4psbzRx8JsUba 6QYwCCIIjZaz8Fg5WsEznVCJnlWrSJDtFzV81HEB40U28TQQYj+XnKDn1F1SDqCllFCU Xt4w== X-Forwarded-Encrypted: i=1; AHgh+RoiS/CR1ajPnoNoAzY4oTaTIsnRA5V7l5vReH89lgd07YfbCIFXm0jBubkeSZaSFcZCx7B9luOlDkyYviE=@vger.kernel.org X-Gm-Message-State: AFuF++n3GHIOYlmJtF/w0gelMhskYSZgvC4na2QFE4poQYbDjT40TDp5 ARs69iFC7cpcuteATlLbipVnRk4oF5+an7N1TwEomgJMmzS1zkQ5GpnmoZTGwAKDJEaa9uZhFhr 6U7R4PjaYDSZpsJ25HWJuXhpFhDrBX3JzyU7XhrURXMnKrOeVGYzyL4elq6c8/x4gams= X-Gm-Gg: AR+sD13KvZVEokbOVTA3cNPx8DR86kPcSYqQISzewGvnyZ4qbnneAN2MDBcbdf92dEU T5lPf27BOoix90HfLo6tE9ybOjomXxi6eI5KCYg51aaue+QhsRvuZw8cpxxF9En6boM9mIKFsIf 6Igd9EhbsSZTxVw5daZ3V3iiK6mZxECinkNJiJl80a8Lggj5DnXA9nMqOxoCG1bmdTmeeYjaIme 2TRutA6YO6nl4EbdpQCs0lcw1nZKxn+RiwbqHIRwcbgYCsMu1BVOJnMvs+CwIsVqa22F0fFnOIj JvMLWD6H1bt+ySCH7Btp+n4EeKJBgcyWOTFOopUCE93PzoUsuFQwhHiJpY+k+11+79ytbJsiN+R WruwKNYngaj077f+S X-Received: by 2002:a17:90b:3d8a:b0:38e:6d4c:14e6 with SMTP id 98e67ed59e1d1-395c33daf0fmr49022323a91.3.1787570928742; Mon, 24 Aug 2026 04:28:48 -0700 (PDT) X-Received: by 2002:a17:90b:3d8a:b0:38e:6d4c:14e6 with SMTP id 98e67ed59e1d1-395c33daf0fmr49022262a91.3.1787570928363; Mon, 24 Aug 2026 04:28:48 -0700 (PDT) Received: from [10.213.109.15] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-395e4af750esm9825643a91.11.2026.08.24.04.28.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 04:28:47 -0700 (PDT) From: Saurabh Anand Date: Mon, 24 Aug 2026 16:58:06 +0530 Subject: [PATCH 3/4] drm/msm/dp: skip LTTPR init when no LTTPRs are present Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260824-qcom-dp-typec-reconnect-fixes-v1-3-2825e5bf8a96@oss.qualcomm.com> References: <20260824-qcom-dp-typec-reconnect-fixes-v1-0-2825e5bf8a96@oss.qualcomm.com> In-Reply-To: <20260824-qcom-dp-typec-reconnect-fixes-v1-0-2825e5bf8a96@oss.qualcomm.com> To: Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Ritesh Kumar , Vishnuvardhan Prodduturi , Mani Chandana Kuntumalla , Mahadevan P , Saurabh Anand X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1787570901; l=1187; i=saurabh.anand@oss.qualcomm.com; s=20260824; h=from:subject:message-id; bh=IbcoGzqn73EF/bO8GfdSrufbJAGc5IIrFGhyjXEiifk=; b=4Hj0CTrR6JsyaJTEBY/gXkQi3xfkAI2GTUD0DlJ+E7juBslV44zaJGm+H2nQxgdmzkFSp/rVI Iqbl/NaJexwBTQS0lsnfQTAnRMS/qgOSiunA+H5lWE4hyqry+bFIz2G X-Developer-Key: i=saurabh.anand@oss.qualcomm.com; a=ed25519; pk=AzGwbGUPO11yi5XTeGyJKOJWLfzXp5Dru4z+PCg/uXs= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI0MDA5NiBTYWx0ZWRfX96xRnmyfczUk 6W8dBUArMw3sb6HRyB5prK0cMnBOdB2f7yKlEAXSEWCs3FUHQ+nKm0epGBVPzh+dYPgkN9e31P7 /kuufmHywu6LrcnXFk7ySjLD6e2Uz06kS6v3gTtuFePoxpHsdybc17/tBXWK1oasfi9HLRHeWWW J9zVlQIzGjBkkHPojuOJbJ/NdsvFkcTMwD1NruyxZorhLhpv+V2mJfdsoArogWDW8BRppT2jJjA OymS4pkW6iHgMDyjVmlsq2lwBVjtd+4fILmzmi4h89CNdDs1dvL2FJA1BvvmC5bCH4xX4rwrp1e eZNyudbjquH/KjMrQzSupS3G8W3XpbEeqozQInfHVAncp7ysaVDFSn/KLGtO2NXH+LmDFQxzBss kQBRShrA8YVaX1lt3cd+Esys4Ya0qa5drDQG2pIaDqS/9ouZR5V2CEpuGRnZqqx+rnvet/YogRq FJ3dTdZH8E2Sw6vyleg== X-Proofpoint-GUID: RTkW5DvgSHYiKS9FWYAGyTQF4MteTtNS X-Proofpoint-ORIG-GUID: RTkW5DvgSHYiKS9FWYAGyTQF4MteTtNS X-Proofpoint-Spam-Info: AW1haW4tMjYwODI0MDA5NiBTYWx0ZWRfX2RNXpF/NwCxw R7Yk1TU639htYfFIEcpZmFfOen3X7tHA2opbCv4iCwMGTz+vWB730SIW3dvDBVmYjcisEu7vd/Z 9UWDHdgow3MfFiARCIXWCeumuUmP7X4= X-Authority-Analysis: v=2.4 cv=W8cIkxWk c=1 sm=1 tr=0 ts=6a8c2af1 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=1b-Prb_CKxP05DS9zwcA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-24_03,2026-08-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 malwarescore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608240096 drm_dp_lttpr_count() returns 0 when no LTTPRs are detected and a negative value on error. The previous code passed the result directly to drm_dp_lttpr_init() without checking, which would call into the LTTPR transparency-mode setup with a zero or negative repeater count. Add an early return for lttpr_count <=3D 0 to skip the init entirely when there are no repeaters in the link, matching the expected usage of drm_dp_lttpr_init(). Signed-off-by: Saurabh Anand --- drivers/gpu/drm/msm/dp/dp_display.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index 40e19d506a45..1f60c78a463d 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -253,6 +253,10 @@ static int msm_dp_display_lttpr_init(struct msm_dp_dis= play_private *dp, u8 *dpcd return 0; =20 lttpr_count =3D drm_dp_lttpr_count(dp->link->lttpr_common_caps); + + if (lttpr_count <=3D 0) + return 0; + rc =3D drm_dp_lttpr_init(dp->aux, lttpr_count); if (rc) { DRM_ERROR("failed to set LTTPRs transparency mode, rc=3D%d\n", rc); --=20 2.34.1 From nobody Mon Sep 28 08:46:38 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 069C3390603 for ; Mon, 24 Aug 2026 11:28:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787570938; cv=none; b=LE5BwHENjSUP1y+DJbIQs0UrHTU+b082NgxQKN9iLEr9PEHw3zs1/HWM28v9R8nHJDsmItHuPD1nZJ/Ag8c4U5M0/Do4QIyBPWIGbzEze9wuOEfGnwDF728tRFWeaoXtCdC+9Yob09NeWC+M3J+Q6NbDLemUAeQhZOWsj/DHy3s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787570938; c=relaxed/simple; bh=IfIz+h7lQZygsMdbtFUdSpKAhh+9x4RQKe/zH5OKDOc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ASzbo03UBXiqLyNt/L2hA4dO8qtrfBBhooatA8m2f/PtdkPZyi2rs+GU6M5P/RQwzIeGHHuSRDabkXcNYyIIib200XuTIN/pG6SJVp/RSx+P3jFg2bM+pF6Ar+aP+3co7CcrS083JWoJYPuhEICPT2tLHQH00T/ZXUww6Dw1+As= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OCW5fEbG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KvzaUMlg; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OCW5fEbG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KvzaUMlg" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67OBMgGe2864728 for ; Mon, 24 Aug 2026 11:28:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kHNvx8/yUX7DH2/W13exwyYo7xL3jhjIg5S8O7VsuNE=; b=OCW5fEbGmsu+L/sP MLAkFdgWm4+qipjmp28jZfMrN6N3FmHAU4cgdL2mIm9875YIRkRcmwDgdp7xrCg8 COAntFPPV93h2hoqw9x2U2aXwCa8sarkw2HShjtVcFJ/GMaEmbwRL9Ew2ny/yct3 pFsKwfmYmRnRQ6jt4rAZgRvivCLeGj9pe+B0lR3AOLoPZPImE1rUtUvG0AIIVzqk HX7HNmWMB0wujF0qXPxc0922ayPgutW1p2K10nRX/12+id622KQzbq5/9TiyPDr1 0rSQA5wwrtU70CzWhTPIYd0kOvvuy31lPEwPCJv2MBI1gb7R+xuNGDJ1aYGMIOfj ZQtR4Q== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g8bdr26v2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 24 Aug 2026 11:28:55 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-cb11535e6a1so3083474a12.0 for ; Mon, 24 Aug 2026 04:28:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787570935; x=1788175735; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kHNvx8/yUX7DH2/W13exwyYo7xL3jhjIg5S8O7VsuNE=; b=KvzaUMlghDpM/QNtsax1nSnMX3zfC69UyiB7vGAadMcu8VunSzFDN8BB8DZo5RMCZI 463WJ6NDV1Rhh6f5tKRcUE3O++aAVWGYrTEyRYhItUhol8KcU2dNnOvw5oj3p2fxy7ty BKsOh2o2r5eRaz3uOYZyO+/COmKMPbc6elsgNEhjQVRR+27enjgUXVlQD9fndLKARaD3 BTcdgX0Z/M6lVh4ypuPnkpfNMxoUUFJ1EGm2tXRoGTOe315gGx5rIfMW8jYbf3u8lkTc prFP/JlS1RY2HKAHu7GpAxc8T8BSHnA12wLF81v7RaMx5yWguvZtIXIPVWFcIKkrKZ7W ld9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787570935; x=1788175735; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kHNvx8/yUX7DH2/W13exwyYo7xL3jhjIg5S8O7VsuNE=; b=CQxAacFCjEbOP9dCjuY0j3AXfj8J1rFqL4QG5kILHzQcNchKjvXMMfpD7p55yoNJLj Kn9FnDOIUrlwRlYGGIko1WtdD3CvnrMc+4bsiLOLp+op1dfUoEE+7IBJTp32v3n+CXHP e22Sj7KwYxjk4NiJw+U9GZLdrE4vlCvnOLSzrB3FidIZ4yX3RA0ukzPCTEFcdVU4iAaG 9vrkkAET+SrurAcQm3o+Lq9UzNCm4yZVZzNzvHD+lZWi4NYvizN4ULAqY6D7ti+I2Kg6 nglvX9K1w/TiCon7bwXlovo1tMKzTUqcRT0O5BYo9DbsHs9ZnMeZH4i24Na1+WPhJLba SqLg== X-Forwarded-Encrypted: i=1; AHgh+RpkMr7YgZ9CfSJavRntF5Bo/yKJ9sScfCKbXlIAJDJKfzemkXFn+go0gBei6kluMBRRl/5VpgytDo7Bots=@vger.kernel.org X-Gm-Message-State: AFuF++nXwCfDsJYQbp0eaBM46VrIHC8Ti8N1y2hiuX0JntI2cWUGwOIl kJTqOtt+fATzQFYK0JOKbPMwX0j1+NlLGh5u2Z6+RBPmZyiFkh3xsRXgzWob24SnEroDdRzN7Ga PmXMiGVQs5w48WHvMIW2UtpN8lRe4PIPj2DKFY4eK3KwbKVH9lvXDwM8KStWYOp139wI= X-Gm-Gg: AR+sD10UrVcFpPY0rs1t0QXh3WryLMVYSsHFSfQYXVVjwY0xvt1hFOu0Oga8/knaBVP prXiGx2HDu2xQbfc4yuqLDYMZUSTstXz+3cUW/y9l7bkADw+xaqUxMI0QkwYN27EFd12Hyw8N1a g6X5c4k38MYhXN1b1zxhKAmbUPbMEFzbNUUJdAs+845dCS5zyoHuMTln26sfPE9ZMR00W7iF4O0 8wuIYhZu+vxE6rVka4xf73PM184ArKstF/608/vPImQ6uAONF7keMeO+8tpDyKzwxRBxqhjeYNX tbaxOz4SjalP/KFopy7Vl14gz5jNl4nwGmMwzw8Cqgm8C/0wTQQ7lkAFXveHlrvVLyx4bcm5uMB Pq4tRRTd8yeTkbsRp X-Received: by 2002:a17:90b:3883:b0:380:540:d499 with SMTP id 98e67ed59e1d1-395def03e79mr30789694a91.6.1787570935021; Mon, 24 Aug 2026 04:28:55 -0700 (PDT) X-Received: by 2002:a17:90b:3883:b0:380:540:d499 with SMTP id 98e67ed59e1d1-395def03e79mr30789587a91.6.1787570934583; Mon, 24 Aug 2026 04:28:54 -0700 (PDT) Received: from [10.213.109.15] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-395e4af750esm9825643a91.11.2026.08.24.04.28.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 04:28:54 -0700 (PDT) From: Saurabh Anand Date: Mon, 24 Aug 2026 16:58:07 +0530 Subject: [PATCH 4/4] drm/msm/dp: continue link training downgrade when cable is still plugged Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260824-qcom-dp-typec-reconnect-fixes-v1-4-2825e5bf8a96@oss.qualcomm.com> References: <20260824-qcom-dp-typec-reconnect-fixes-v1-0-2825e5bf8a96@oss.qualcomm.com> In-Reply-To: <20260824-qcom-dp-typec-reconnect-fixes-v1-0-2825e5bf8a96@oss.qualcomm.com> To: Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Ritesh Kumar , Vishnuvardhan Prodduturi , Mani Chandana Kuntumalla , Mahadevan P , Saurabh Anand X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1787570901; l=2888; i=saurabh.anand@oss.qualcomm.com; s=20260824; h=from:subject:message-id; bh=IfIz+h7lQZygsMdbtFUdSpKAhh+9x4RQKe/zH5OKDOc=; b=70s+9NlE/x16oDLy3h3yl/e0qgXl8cliK6Ap3cvHqBav7G3wt3ikUBcZo/oLqVYiI0KPj32BW gb5Bfb6yrglCOkGTi5sK9oNebP+RwX+OI0MuE9RzHEYSyImEo1FBfaW X-Developer-Key: i=saurabh.anand@oss.qualcomm.com; a=ed25519; pk=AzGwbGUPO11yi5XTeGyJKOJWLfzXp5Dru4z+PCg/uXs= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI0MDA5NiBTYWx0ZWRfX2lBt+z32Omyf GxfhvKyhNXPAqOe2m5WejL8Weqnk46sIvHCrdBDSHgDVI5xdoTXdnPoVt++v+PtP7URPiCYlkbT jUykRmSQZXSQkz7qM0uDP+zc1lRyhz04eKrTbDaxNOSMMeXyRaf4MxUcdt1VWTjkRbFTyamxptj UqeddXrsKZ7PVi5hPM0E1BWP/DyRIDQcxyrkVl8qM1ryCudo7JucYfaIYdu0CwxWfmBx0E4grdy 6M2ymn/SLtDBK0WdfVwhIUUcNqKJulkA+HyHZPs8m4TEi+diC4B4+qFKqy8A7J9nvNtUiaabZhg +C88YYBl1mA2DFf+Rsh6ygSheEFWsWBaXJfDn06cCgzJwK52rSG8frmO0HoNH3MpoIj5F2hB3pt vDP1wzDUc3405YykSPjzdIFDAHSssbR8U7+AVsnSuDYlRwaEaeIWk5q3U9l+PO6gskMLpAs0Y/i 7m2KMx8v27SfwCX78wA== X-Proofpoint-GUID: YdMr4oAroViDTZ6d4_no3BCTYKna0uwN X-Proofpoint-ORIG-GUID: YdMr4oAroViDTZ6d4_no3BCTYKna0uwN X-Proofpoint-Spam-Info: AW1haW4tMjYwODI0MDA5NiBTYWx0ZWRfX8Yw4Ojdq2wie 8ufMt6Veevh9g3LhQsshutvEaj8liAqNvCCKIIozrd9Pt7ebDAk4uWZwha7VZkgu9miEbr23s3w UphHUYN6AuVeseTdY4D32bpa4lFTMB4= X-Authority-Analysis: v=2.4 cv=W8cIkxWk c=1 sm=1 tr=0 ts=6a8c2af8 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=mNJOpbDVpywo_FzgO_AA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-24_03,2026-08-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 clxscore=1011 bulkscore=0 malwarescore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608240096 During a Type-C reconnect the AUX channel may report link-disconnected transiently while the physical cable is still present. The link training retry loop in msm_dp_ctrl_on_link() was aborting immediately on any msm_dp_aux_is_link_connected() failure, preventing the rate/lane downgrade path from running. When the display is known to be plugged (msm_dp_ctrl->plugged), an AUX link-disconnected status is likely a transient glitch rather than a true unplug. Allow the downgrade loop to continue in that case by requiring both conditions before breaking out of the retry loop: AUX reports disconnected and the display is not plugged. The plugged state is snapshotted from dp_display into msm_dp_ctrl just before msm_dp_ctrl_on_link() is called, so the retry loop has an accurate view of cable presence at the time link training started. Signed-off-by: Saurabh Anand --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 4 ++-- drivers/gpu/drm/msm/dp/dp_ctrl.h | 1 + drivers/gpu/drm/msm/dp/dp_display.c | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_c= trl.c index 59070f399e2d..e8fd8f4c75fe 100644 --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c @@ -2379,7 +2379,7 @@ int msm_dp_ctrl_on_link(struct msm_dp_ctrl *msm_dp_ct= rl, break; } else if (training_step =3D=3D DP_TRAINING_1) { /* link train_1 failed */ - if (!msm_dp_aux_is_link_connected(ctrl->aux)) + if (!msm_dp_aux_is_link_connected(ctrl->aux) && !msm_dp_ctrl->plugged) break; =20 drm_dp_dpcd_read_link_status(ctrl->aux, link_status); @@ -2404,7 +2404,7 @@ int msm_dp_ctrl_on_link(struct msm_dp_ctrl *msm_dp_ct= rl, } } else if (training_step =3D=3D DP_TRAINING_2) { /* link train_2 failed */ - if (!msm_dp_aux_is_link_connected(ctrl->aux)) + if (!msm_dp_aux_is_link_connected(ctrl->aux) && !msm_dp_ctrl->plugged) break; =20 drm_dp_dpcd_read_link_status(ctrl->aux, link_status); diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.h b/drivers/gpu/drm/msm/dp/dp_c= trl.h index 5902cf7e746a..95533b0b6297 100644 --- a/drivers/gpu/drm/msm/dp/dp_ctrl.h +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.h @@ -12,6 +12,7 @@ =20 struct msm_dp_ctrl { bool wide_bus_en; + bool plugged; }; =20 struct phy; diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index 1f60c78a463d..93a37a44273f 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -644,6 +644,7 @@ static int msm_dp_display_prepare_link(struct msm_dp_di= splay_private *dp) if (!msm_dp_display->power_on) { msm_dp_display_host_phy_init(dp); force_link_train =3D true; + dp->ctrl->plugged =3D dp->plugged; } =20 rc =3D msm_dp_ctrl_on_link(dp->ctrl, dp->panel); --=20 2.34.1