From nobody Mon Sep 28 10:44:10 2026 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57F4D367B84 for ; Sun, 23 Aug 2026 11:20:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787484031; cv=none; b=InyS34RKZSzdh/hgAdz93C9YT14UR0p8OBAU4nRnTHYdspPIo4sn9Ry96wyWTDi4CZ2EL1efWhTHy7DzgGYJ3t48/ISl1mI+K3FnOe5AjqPvOtWn4jegsx66b7h39+dVNJ55SpPsPisreLOzQvgzVUMQU/87yhy7KcqhFT2XCCQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787484031; c=relaxed/simple; bh=BtMVAHXM9KoBuSaBgXcPyEGGY8yWHDBQpY2nHDSPMuc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZVUhr97gif/kmDuLaWYpLyIJWr5uQh/3dntgfPHArVwpo8+8BW/ogWxn7qWhrFcqRuOBfIUvReZLtGWIRaBquKD7VPem7MeUQE+b8bOd3QkLIr/84rTUc3Pl/p9nA2X7aaQa7IAOCDjCEZsWb9mOVLv48ecr2Rpye7qnYVEUAMc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mBOpDFF6; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mBOpDFF6" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-6a0a4a28cbdso4535186a12.3 for ; Sun, 23 Aug 2026 04:20:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787484028; x=1788088828; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JlTQW/BF9URteLWdGLssLkReJV29Ip7yvpMIAoyvb8I=; b=mBOpDFF68B0DVu9vcsNMhxvHmY42qCKDmc3Hma9rFtgUs7MAvcz0bdcJMwyOpjMiF4 YXrnBOSY37G1m7FI8i4EAOg2B6HDFTF4FW2jwGCnifffJdk8rSGjBXHYXEYPMuI4E01l ml8zEJDrDhGR9tV6JXPemznr1p4mzgIMyKdLr9aVWo+LycPzAC4stLl/5TTZhOjxvkSH 0GoJrAzUULBLPZry5SiTD6yAmxzOw95zDSB1BxEtEc4z+0So7GFY+pif0JO1bGNaMRCv w9erKBlZER6rl9XLn3wqrAy0/c/CcxfJlYT4iQes79/khtjMp+gexFkvQ8ki98/bko0I b32Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787484028; x=1788088828; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=JlTQW/BF9URteLWdGLssLkReJV29Ip7yvpMIAoyvb8I=; b=r20paO87WSXNi2CHW1a/0bx0c3Qg7kJNL7wPinTmoQB7esb61d/ccd0ku+UfBPA4QY 9w8dy2jAs+3WxsUAmvuSuy2mBWCjJMelEGpNqIxA8MEVTeYUDYWaRIgqPcXz9xtF1CLm 42IE2GUwZrEGwFKsHVrb16VgRf4ORMKscdhR8IFGzrIxZDrESuQmpEdTwP2ulj21+4nj 3JxJDkJQ/GW6mHwNefZoJu0dKuy/ejUl3hNoTSoLtiXmvFj4lg3rSAXWCub6G3AFVDFk sM7RRWrrwW0cdi55/PhGTuvPedbBXcf867Ow2JRxUyEtGWeQ7omKSjOhRCMRywvOR1ai vtaw== X-Forwarded-Encrypted: i=1; AHgh+RowtE/1jYWylm27Smuky++Pfr2qeCZDc627zwVjYyxw40EjPCLetQr5i5NnjUTFkLQbCTMpDAH3IYF8H4M=@vger.kernel.org X-Gm-Message-State: AFuF++nxtn9/IPKC/w8+kWmu7LSysAek7zdCuG7RwjfLbvnbuQ9UFGdd e/xWSQbKQC5nFP3SLkjw8ZBU//a32UsYlWiDfXxXGiVTumJmQCo4eP09 X-Gm-Gg: AR+sD11uMyna6sHOcaMzhK4avFr4RS5qL5zsuvNAeV/hjW1u/is3LGjws+noFLDf8KA sQgu/qFwhNMTC9YGv7d2gELmrMRP9GTsDSOaMU/bIbxvtlGLXJzTsntpnLM036cVt2mYKnnuaK0 C55f7XBAB127lNQ/J4JC1Jd+WS5K3B3n6nB/FIKCtXeQkr1cAjGgTCJJf88WVhxmKDjoKEJU9+9 P0ttvVPhbfSuudBRWBli0mMfeyuqfz3/WxR1gMCORXSW8fTtosivzuK1vNy0Lar82arW+qeGRA0 MD6/n/djIXn0hyRAwObdr4ZqZwl4pM8fBqW8WWr6muMqEIQiLJ1gqgS+w+dsBp6/vZqwLV/3RNV 5RC2aQmIdK1XjA8Jwjt2OndgHuEwKh4HBJ20lDDZw8VBol0Vm0oXDZ3hPGZe2gptqwgOfgE1qgB MmojB6LcwPpfu2svDWMCBajEwSgP8IBybDZ7WSTsjCmriCF6hR5+w7M44NsgUtfBie8g== X-Received: by 2002:a17:907:3ea2:b0:c15:f598:60c0 with SMTP id a640c23a62f3a-c249238cd84mr1203250766b.4.1787484028294; Sun, 23 Aug 2026 04:20:28 -0700 (PDT) Received: from thinker ([2a13:54c2:f000:e268:6d0c:d746:2b12:231f]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c24966f58dfsm707233866b.38.2026.08.23.04.20.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Aug 2026 04:20:27 -0700 (PDT) From: Amit Barzilai To: javierm@redhat.com, airlied@gmail.com, simona@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: andriy.shevchenko@intel.com, holofermes@gmail.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, Amit Barzilai , Krzysztof Kozlowski Subject: [PATCH v5 1/6] dt-bindings: display: Add Solomon SSD1351 OLED controller Date: Sun, 23 Aug 2026 14:19:54 +0300 Message-ID: <20260823111959.17029-2-amit.barzilai22@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260823111959.17029-1-amit.barzilai22@gmail.com> References: <20260823111959.17029-1-amit.barzilai22@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a device tree binding for the Solomon SSD1351, a 128x128 65k-color RGB OLED display controller driven over a 4-wire SPI bus. The binding builds on the shared solomon,ssd-common.yaml properties already used by the other Solomon display controllers. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Amit Barzilai Reviewed-by: Javier Martinez Canillas Reviewed-by: Krzysztof Kozlowski --- .../bindings/display/solomon,ssd1351.yaml | 42 +++++++++++++++++++ 1 file changed, 42 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/solomon,ssd13= 51.yaml diff --git a/Documentation/devicetree/bindings/display/solomon,ssd1351.yaml= b/Documentation/devicetree/bindings/display/solomon,ssd1351.yaml new file mode 100644 index 000000000000..80850c2ab5b3 --- /dev/null +++ b/Documentation/devicetree/bindings/display/solomon,ssd1351.yaml @@ -0,0 +1,42 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/solomon,ssd1351.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Solomon SSD1351 OLED Display Controller + +maintainers: + - Amit Barzilai + - Javier Martinez Canillas + +allOf: + - $ref: solomon,ssd-common.yaml# + +properties: + compatible: + enum: + - solomon,ssd1351 + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + #include + + spi { + #address-cells =3D <1>; + #size-cells =3D <0>; + + oled@0 { + compatible =3D "solomon,ssd1351"; + reg =3D <0x0>; + reset-gpios =3D <&gpio2 7 GPIO_ACTIVE_LOW>; + dc-gpios =3D <&gpio2 8 GPIO_ACTIVE_HIGH>; + spi-max-frequency =3D <10000000>; + }; + }; --=20 2.55.0 From nobody Mon Sep 28 10:44:10 2026 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06B9038DC5D for ; Sun, 23 Aug 2026 11:20:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787484035; cv=none; b=CugAYxtEs+w5V/csXcmt9aLkwxiS1Ha65kTAQpDD6SK2k2pZMJXH3fam5egrbIjeGOCeGr7+HLU53fAeMVhO28Rbh4C+un07gkXWkzyjFsFaMUkKo82iWLJeISlmvH/vISzP8VECLqowXW8yQH7wTULtZaqDVjN2j73TvZlvQiE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787484035; c=relaxed/simple; bh=sS+JQZ85OpW7bY3sDFgkgCR9UWbFFQQuEfzVJqKunbc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HwS89MNlxZ4kURoMpK5kYQTwFd6MhomSUZGZFrjJs/QMKUw4biz7nRMwTI/x8hFo/qiZvJEUfOVJcPiEUcMRm1vjn95CpDgAVzmtjfusGRilYF20jz1jH8rsF2Ey8NhrWzevzjG/2tifHdlU8AR2ef1KuoWT6GI8OWSUbHEcMnU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=osA8EUBa; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="osA8EUBa" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-6a18840e2abso4489383a12.0 for ; Sun, 23 Aug 2026 04:20:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787484032; x=1788088832; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=O2nHmLuWlmB9nT6PWD8W1i/ls2Umb2NuoFiA04KEePk=; b=osA8EUBawZ0heovjb25FQajptwNPN/DzUbbO/VBCR0zPArKIz69alwAXKes1mwGe4d B0x0AVjzIrPkiwym0Mmle8OqbKplgJ21RLxuA0qdW0zDnuGAESoxx08XLnZHhNKxkcDm fwIRPfMYriLPnussVhHak87k+MDEiyiepq8Iwl+zMfL5WdFOj0ZkC8mvRfA8giv+AupZ 7/b0F+Aq+8BfWZjl1Ci9Z0ZuouD+autyZXyaifMk8IHWf3W8FKpacFOyFZ4KJ1fems8+ kmcB9vcsuUKJfiGCSSnmeDFXo0D9VW9yTDeZ9Bw4FFWJS2x6VWNfEJ3OdrfYFhftTLsD 1uQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787484032; x=1788088832; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=O2nHmLuWlmB9nT6PWD8W1i/ls2Umb2NuoFiA04KEePk=; b=oVAZ2k7Vq3ZxQzYHRRnI3sb0C1fQ2dwJntzdHhzoPx9d1Da+DT11AUpMs5dksKYg84 FqizzdqZH9/NnXGKuhdEgxiGlL25CwpNdBn2fmliWeCXZlBRPQNCi8s+rjhE+7Irl406 zYijQM0PQP7EuDG1MjSvnX54CGhRSpI6z3gl1yL7X0Y1i2St6gr30K0278GIm8UWaZLO XzX5QL9cZ95GYNHBoo4DPivUiwILjjDqg5qTf4z34WFetfHJ4o58nAMX5+pnV9wPrJ3s zXsRKcCkUgUGKdwzzoa+simN44TKIx53RpzwTYRNAM8m21LH6oVTJJ++lxyo5FfXG83v PNTg== X-Forwarded-Encrypted: i=1; AHgh+RroC3hzRE8vQG+XxKgSBTUc/SNgJNhX5SNNer2dwmFWKC1S8lD39KVQ63iSRxL4+fU11bDf7RRlYtjrfaU=@vger.kernel.org X-Gm-Message-State: AFuF++kqK+KjDJIP0Kb8FULLVmAyfq+wfQQ7kO7milfvGfADMvItMAQA sz9whlXxG/6v0J1kjqgVzGrgkZF7HG4N8dMm7jfVppD7LTB6wcNWTV/z X-Gm-Gg: AR+sD12imO3PISzx/PdX688U5XUd2r+g9H8/X7HW512teO/ecv/xwnfZJoBm1q2fOED QaDtEwzvvfRsAsz1+7IAFHmTchWRe2x+ACqnkeqG/NFqywuOsStf3Ev7T396BZvmktxE7WO2YEB 0p6ewaGakmdd8uslEEc2KGfTFJMZzz21oNX4OeFOi8Ye4ubi5OiSx3q4jLRXH7rNwfHEUrTilsT HfpHWxh5JYLlNxEmH8KqG/sES9Aajn5SYxmBbrnCxEdKI7vjNNFdUo5tvMsJu50SQu2mTMM3CVQ LmGBOxluTTzL6ga9a36iW4neQy8LsE0MnJKp2wpTCWR9WYkZET9O2Ahj2g3BAU6ZjIfFRsYglbk 6UjTizCB2p4bx61jkxMFKEym9//nT7KsyG1qboSqA15fwxvEftpxG/qJPacSaFegEjlCX1mZbuY viO4/BHSdtfYXFiBjn+sqw9j3Rvc3qwKC8kiU1xc6LppeAw29clCS26QZfxzsdoFgljg== X-Received: by 2002:a17:907:9495:b0:c21:49df:1650 with SMTP id a640c23a62f3a-c2491c9bae2mr962084666b.8.1787484032115; Sun, 23 Aug 2026 04:20:32 -0700 (PDT) Received: from thinker ([2a13:54c2:f000:e268:6d0c:d746:2b12:231f]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c24966f58dfsm707233866b.38.2026.08.23.04.20.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Aug 2026 04:20:31 -0700 (PDT) From: Amit Barzilai To: javierm@redhat.com, airlied@gmail.com, simona@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: andriy.shevchenko@intel.com, holofermes@gmail.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, Amit Barzilai Subject: [PATCH v5 2/6] drm/ssd130x: Change SSD133X color format to RGB565 from RGB332 Date: Sun, 23 Aug 2026 14:19:55 +0300 Message-ID: <20260823111959.17029-3-amit.barzilai22@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260823111959.17029-1-amit.barzilai22@gmail.com> References: <20260823111959.17029-1-amit.barzilai22@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" SSD133X screens were driven at 8bpp RGB332 despite supporting 16bpp RGB565. Switch the SSD133X data path to RGB565. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Amit Barzilai Reviewed-by: Javier Martinez Canillas Reviewed-by: Andy Shevchenko --- drivers/gpu/drm/solomon/ssd130x.c | 48 ++++++++++++++++++++----------- 1 file changed, 31 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ss= d130x.c index 0b0fc6fe3df2..8cf1e9c84a81 100644 --- a/drivers/gpu/drm/solomon/ssd130x.c +++ b/drivers/gpu/drm/solomon/ssd130x.c @@ -146,6 +146,11 @@ #define SSD133X_DEFAULT_CONTRAST_B 0x50 #define SSD133X_DEFAULT_CONTRAST_C 0x7d =20 +/* ssd133x remap byte (data of SSD13XX_SET_SEG_REMAP) */ +#define SSD133X_SET_REMAP_COM_SPLIT BIT(5) +#define SSD133X_SET_REMAP_COLOR_DEPTH_MASK GENMASK(7, 6) +#define SSD133X_COLOR_DEPTH_65K 0x1 + #define MAX_CONTRAST 255 =20 const struct ssd130x_deviceinfo ssd130x_variants[] =3D { @@ -618,17 +623,17 @@ static int ssd133x_set_contrast(struct ssd130x_device= *ssd130x, u32 brightness) static int ssd133x_init(struct ssd130x_device *ssd130x) { int ret; + /* + * Horizontal address increment, normal SA,SB,SC (e.g. RGB) sub-pixel + * order, COM split odd even and 65k (RGB565) color depth. + */ + const u8 remap =3D SSD133X_SET_REMAP_COM_SPLIT | + FIELD_PREP(SSD133X_SET_REMAP_COLOR_DEPTH_MASK, SSD133X_COLOR_DEPTH_65K= ); const u8 cmds[] =3D { 2, SSD133X_SET_MASTER_CURRENT, 0x06, 3, SSD133X_SET_COL_RANGE, 0x00, ssd130x->width - 1, 3, SSD133X_SET_ROW_RANGE, 0x00, ssd130x->height - 1, - /* - * Horizontal Address Increment - * Normal order SA,SB,SC (e.g. RGB) - * COM Split Odd Even - * 256 color format - */ - 2, SSD13XX_SET_SEG_REMAP, 0x20, + 2, SSD13XX_SET_SEG_REMAP, remap, 2, SSD133X_SET_DISPLAY_START, 0x00, 2, SSD133X_SET_DISPLAY_OFFSET, 0x00, 1, SSD133X_SET_DISPLAY_NORMAL, @@ -829,14 +834,20 @@ static int ssd133x_update_rect(struct ssd130x_device = *ssd130x, * COM0 to COM[N - 1] are the rows and SEG0 to SEG[M - 1] are * the columns. * - * Each Segment has a 8-bit pixel and each Common output has a - * row of pixels. When using the (default) horizontal address - * increment mode, each byte of data sent to the controller has - * a Segment (e.g: SEG0). + * Each Segment holds one pixel and each Common output has a row + * of pixels. A pixel is 8 bits (one byte) in the 256 color + * (RGB332) format or 16 bits (two bytes) in the 65k color + * (RGB565) format. When using the (default) horizontal address + * increment mode, the pixel data is sent Segment by Segment + * (e.g: SEG0 first). * * When using the 256 color depth format, each pixel contains 3 - * sub-pixels for color A, B and C. These have 3 bit, 3 bit and - * 2 bits respectively. + * sub-pixels for color A, B and C. These have 3, 3 and 2 bits + * respectively. + * + * When using the 65k color depth format, each pixel contains 3 + * sub-pixels for color A, B and C. These have 5, 6 and 5 bits + * respectively. */ =20 /* Set column start and end */ @@ -909,9 +920,10 @@ static void ssd132x_clear_screen(struct ssd130x_device= *ssd130x, u8 *data_array) =20 static void ssd133x_clear_screen(struct ssd130x_device *ssd130x, u8 *data_= array) { - const struct drm_format_info *fi =3D drm_format_info(DRM_FORMAT_RGB332); + const struct drm_format_info *fi; unsigned int pitch; =20 + fi =3D drm_format_info(DRM_FORMAT_RGB565); if (!fi) return; =20 @@ -978,17 +990,18 @@ static int ssd133x_fb_blit_rect(struct drm_framebuffe= r *fb, struct drm_format_conv_state *fmtcnv_state) { struct ssd130x_device *ssd130x =3D drm_to_ssd130x(fb->dev); - const struct drm_format_info *fi =3D drm_format_info(DRM_FORMAT_RGB332); + const struct drm_format_info *fi; unsigned int dst_pitch; struct iosys_map dst; =20 + fi =3D drm_format_info(DRM_FORMAT_RGB565); if (!fi) return -EINVAL; =20 dst_pitch =3D drm_format_info_min_pitch(fi, 0, drm_rect_width(rect)); =20 iosys_map_set_vaddr(&dst, data_array); - drm_fb_xrgb8888_to_rgb332(&dst, &dst_pitch, vmap, fb, rect, fmtcnv_state); + drm_fb_xrgb8888_to_rgb565be(&dst, &dst_pitch, vmap, fb, rect, fmtcnv_stat= e); =20 ssd133x_update_rect(ssd130x, rect, data_array, dst_pitch); =20 @@ -1446,10 +1459,11 @@ static int ssd133x_crtc_atomic_check(struct drm_crt= c *crtc, struct ssd130x_device *ssd130x =3D drm_to_ssd130x(drm); struct drm_crtc_state *crtc_state =3D drm_atomic_get_new_crtc_state(state= , crtc); struct ssd130x_crtc_state *ssd130x_state =3D to_ssd130x_crtc_state(crtc_s= tate); - const struct drm_format_info *fi =3D drm_format_info(DRM_FORMAT_RGB332); + const struct drm_format_info *fi; unsigned int pitch; int ret; =20 + fi =3D drm_format_info(DRM_FORMAT_RGB565); if (!fi) return -EINVAL; =20 --=20 2.55.0 From nobody Mon Sep 28 10:44:10 2026 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB3803C3BF1 for ; Sun, 23 Aug 2026 11:20:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787484039; cv=none; b=CvA1n0FiDTMrIn3Q3iNIV//DBYRlHVkUxaMxCbQU5SB17SNJM4rUxh2gV9Cxay1bQyXm8fwXIIRF02LXqZ8rNO4oZkYQ27HDZ9lnWDHK6Mdy6KwfAOSVn4r5NfFSsYldvQe3gpqrAvsl/z9W8RNryPPYpo38WSp17ghvM7U85GI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787484039; c=relaxed/simple; bh=G4D/tLQlr5MskfBE1LEuWc9pIfnVArKK2j3Z9+4DMo4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=O/X6lHwRHaFC2w7bTQuPwyJPuWEr2mQMAwO4a9v0vqQtFkfGzNcq1O+EoK0pjC4m8uvNa/eg78lo7dzWKqQXmk38iEpVVqFJqcG4tj9ShqKSBdeGmy08ivSBF3RWN+1I69AWgKPxlIRMuM752mDKeTEEvG/zUet8OjbJXGsX69U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mlCeB4mr; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mlCeB4mr" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-c15ba3a2b4bso357230566b.1 for ; Sun, 23 Aug 2026 04:20:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787484036; x=1788088836; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ITWcZ5jiF/pXFpj+1UU2crAZw5A+n08+7Om7GUXkowQ=; b=mlCeB4mrbRx8dEC/qmju6K78Wh1TnBzDJ9dZLL6WdHC+raku0O3/vUh4KHKPLa2idw 3JgtsQCcoWq+CHf8EHmAYkMFz0rDVQvFIAVk1qtusf6/9fgswOHpCXsEF2nmksj6GkF+ aBDKweuBbdtx+zxKrl+B6CfnGJ25+k4vMBigvnYMIsr2ih65BWOupbN9h6l1hEBc/nLs fjL0+pJWi6oGAud+oS/ToN9+BNZcE4zoIIDCoxIoqyfE0T9AUtwYcrP25zPbe+6L1/L9 TA82IeEByTvZlz7lmEJ56bNi+Sk/otjC8DsTbdK8NWY3ZF7YN16RRoL10d+T03drKES7 kKww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787484036; x=1788088836; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ITWcZ5jiF/pXFpj+1UU2crAZw5A+n08+7Om7GUXkowQ=; b=g72tQLoc1YG6BvGBNKTYRVTUHndEJGCsmzKvvZV7YC/chASql7WoFnMkX8zmqQeV1Z I2lrIM+z/sOIx4DCxU2qcckGRgYWS/b+jOjnYuFiJyZtCb5tZV1oZaP6/ReeGGFYmAtD 2D/Im5XaenBe+kEM3R44n4DiNNupFvEEbqhXtEvuCBw3BmU0NwdCLJHO+qXtG/AGsJSJ Haw9eBcajeUdzzNBpweWoU0IpG7EP8ygL4I1zM/gYOYOHAtmyC9pS3ICKf/YJGiRXndh KPT9qtAD8d4CeU3G7dv9Q4u/iaIWMfpCTuGkRgem4fEcM3UyAHY/SyUkl3vTXtApH6U7 BM5g== X-Forwarded-Encrypted: i=1; AHgh+RrjWzJ9gbVQJ7omUM9YqkmB8Lw3sEhtj8853DddRAqDyTlTx1lwMnEOhRUU/AtiOwNim3V+vkLprP3vrgg=@vger.kernel.org X-Gm-Message-State: AFuF++kHwKFXHjDyxl+l4zXcSzs5ty3waEeG2dKWRZsJT9oKVxGTYMED Z5/vOxF5kwZGcqdAJdFhccavNtoGfdv2N/6A0YYSWh7DztTC7REXvOZd X-Gm-Gg: AR+sD13f/XaYRwqauHVBmNFE1ziO5ZncuhV3E3uElcOO7CWWVP1JSVAEMg8jmOP+E3u f7XbuRrrAE9mnAqaAPRdUF0HadUFhGBrWz5W35iqgppW/IR+OdAeuow/J1VByDC6XIqRDpFF+rg TDtRONUDhUNDooQDLpQrKt1qZ2+QW83Cyb4R1tNkn/gwHYi/TdJMQ6afxVrAxYFZgNDB1snvKdy OjjPtkEF7IbPzJ/PC3D0VlphWVpD10sKKMdlvsU2cxE5SZMl8Aktf2egqsm83FWITcvA4X4elyX 18WqjsbZoZBq6QRnlJjMWoHVtpA9DPSRlipkTFJlVQeufA+mJDG/v93cGY+0ctC90W1cmPrYNSp cvL7DMYJ1y503UDW1Bch0wJCJcY+sAWiIIFvAsXB3E59i6B3Mde7Rm4QVN0p5JaukpZoketa7jz Ed5GOIccQ3+DnONOciLvctDejheQ5kSViduCkY8XLt9OYEHTGhMNyY25uWRKDdrygnBw== X-Received: by 2002:a17:907:e1d0:20b0:c20:f864:d480 with SMTP id a640c23a62f3a-c246a6559aemr1554170866b.13.1787484035807; Sun, 23 Aug 2026 04:20:35 -0700 (PDT) Received: from thinker ([2a13:54c2:f000:e268:6d0c:d746:2b12:231f]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c24966f58dfsm707233866b.38.2026.08.23.04.20.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Aug 2026 04:20:35 -0700 (PDT) From: Amit Barzilai To: javierm@redhat.com, airlied@gmail.com, simona@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: andriy.shevchenko@intel.com, holofermes@gmail.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, Amit Barzilai Subject: [PATCH v5 3/6] drm/ssd130x: Constify ssd130x_write_data() 'values' parameter Date: Sun, 23 Aug 2026 14:19:56 +0300 Message-ID: <20260823111959.17029-4-amit.barzilai22@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260823111959.17029-1-amit.barzilai22@gmail.com> References: <20260823111959.17029-1-amit.barzilai22@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" At no point does ssd130x_write_data() change the bytes it receives via the 'values' parameter. Constify the parameter so const-qualified buffers pass through without casting away const. Signed-off-by: Amit Barzilai Reviewed-by: Javier Martinez Canillas Reviewed-by: Andy Shevchenko --- drivers/gpu/drm/solomon/ssd130x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ss= d130x.c index 8cf1e9c84a81..73e7f2a8b730 100644 --- a/drivers/gpu/drm/solomon/ssd130x.c +++ b/drivers/gpu/drm/solomon/ssd130x.c @@ -252,7 +252,7 @@ static inline struct ssd130x_device *drm_to_ssd130x(str= uct drm_device *drm) /* * Helper to write data (SSD13XX_DATA) to the device. */ -static int ssd130x_write_data(struct ssd130x_device *ssd130x, u8 *values, = int count) +static int ssd130x_write_data(struct ssd130x_device *ssd130x, const u8 *va= lues, int count) { return regmap_bulk_write(ssd130x->regmap, SSD13XX_DATA, values, count); } --=20 2.55.0 From nobody Mon Sep 28 10:44:10 2026 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89F18339372 for ; Sun, 23 Aug 2026 11:20:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787484043; cv=none; b=XkGkk2cYUQ0Oq+PxLBIvZrGjcG7vz9q64Yf6xv6ik/aMrTTpxfn0viFF9qQ6t+c2keb6r5pgupk50jM0qQ45b/nsfcesnB7J3rKA0xXNxcu3MQYJ1GGqxPCUo9m2Gv+xHJgkVOjUkNHmsKqtaOi4ldy7i4K8ZfZ+W86F5N/Sh5Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787484043; c=relaxed/simple; bh=lOHqOlIvPJWO2MOvJv0kGLGvV1DZo4M8ElXRI6PgaVc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tQ601k+DbVEk9EXdwf5EcAlzPy47ARc2jKCmEGQwkaeJssaeTi7VTwvmdp9v+CHcgXostcDGQsFLT0zgsEexnqrkkUi11tt8++efPlCqNY9cPZdm6LC6gC+9c3ZjvpGOIhKL5NFVX0DYInIGIC2RdpCermOY5PpoyBwbkK+DIGI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VRJBnE/9; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VRJBnE/9" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-c15cf78d1a2so282242366b.1 for ; Sun, 23 Aug 2026 04:20:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787484040; x=1788088840; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hXbW16L5wvPepfurbHdIAab5lg7qHN9GJKcsA1M84NI=; b=VRJBnE/9klHRKPMsWMz0i/UfnR2hN3k5oCq2HAomABU5oAAlYQOkd02sx+LmmgN/wX M+0k06PMDNapxwrnRYwRBMU8KGVoFuqkE3ev6kaSFBNeu5YKno+bDPH0Lwyp/kfMOUhF zXxnXsNOHfVxfw5X0h4Fu4e4CkGhEq6Wik/VaSxVNotdSP7qgReGS5Okh5bCNlsFK7ku k6fcdLGbGuAp8A347JEul3hBptUyiAwStlP+4nX6t0HBeqKXFos0h0+frxmTnBXssJBi P0PkW3fs16uxvckeOzFMkq3vZpoHUxQmQoZdydreAyutUgkysQfqAWs1TidU0IXT0psI QPew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787484040; x=1788088840; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=hXbW16L5wvPepfurbHdIAab5lg7qHN9GJKcsA1M84NI=; b=dhcVb1GP05dYH+Cwl8DOrxYoCo+LFIMC+e40WBAQSnEt/M0VYcU4mbTprpiQbCtXN/ O3UyKPpdhlmefYRCkIa04iJyC+VV1QjrvIpwLHNB6Tj6ywcvBauut+HJhBZayLcKD3yX 9cRTATJz6A+ewsds1HnZWH4xm9X6MBUX/Z6lVkNt2JRO5eOxzt8sKRvqfAHZyy8AOOw1 Sf+ZWGGKNmNMzJFJ8Fq4x6o/6Qn5sme1ockz7vhV32i1F50Yjyw5mE1KICrJUb3DucBP F8WLbYb11xcXT3h1Nvz+LyiU2ThI4RmFHDKgRFUjytopBRHd9qBzS8+1RQZuALNNPukL 3DXQ== X-Forwarded-Encrypted: i=1; AHgh+RqsGX02JKI71eChZGuOVEGJTwiiJGAUZf71BCQ1rNRv3w5ATvpFph+7XuCFTuSr8Yszpkjh37U6grKFC20=@vger.kernel.org X-Gm-Message-State: AFuF++kJfyT/2qp9YOP4oIj15FZ/4ukjtsoIfPsvkOtB6xnWGH+qdHji aKxbApFpuPpGJ7m2pBFyRtRhngTAnLxseeuY9BvhVj6m6+DQhYSZAWv4oYQdBw== X-Gm-Gg: AR+sD13kzQFLSPHNKsSYhMItWJ/2MDmLIrYtO8FxfwajyQGo/B4IyBET68sCsyFXQvU pO9XhjFPoeYmboyi15EkxtKWu1zDhFe+l/cMn6YRnRgzExuqGOgBnvRUDodLYy/8LyCB5kItuOy 5ysKyiwpEFIhjF9R+Ks5juQIryUYsQL72pxr5dmI+Ae9CrIoznJB/g4v8iLk26x4Tk1Flq/ReKw /0n2+6rHbkCouD/1sKXjnVbkq7O1jkjTf6z3zfJY4d5atwZX/nJPm7f0tXdN2hjNJEZm2cL49IL aeGUjCqpj6wBX/OHFCGFOLLFmrQCOD/SY1nI3DAWmC5eXmsJgE1vxtPt9v82aTXE3dX8sw4hYls 84UDGoMDgfuZhy0gu8KCVNQ9zTLVN7zWadjPrOorA2fSHZqDxkX9lMhevkg3/RVtRmG/x68+qjG zHZaSkqwsmWQufKwU/FQ+GxDdPT63SyI6lg/7wahn8DKwCdQK0Hi6ie7YaQDQhhmfKBg== X-Received: by 2002:a17:907:1b0b:b0:c12:e178:9e68 with SMTP id a640c23a62f3a-c246a63071emr1921055866b.19.1787484039486; Sun, 23 Aug 2026 04:20:39 -0700 (PDT) Received: from thinker ([2a13:54c2:f000:e268:6d0c:d746:2b12:231f]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c24966f58dfsm707233866b.38.2026.08.23.04.20.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Aug 2026 04:20:39 -0700 (PDT) From: Amit Barzilai To: javierm@redhat.com, airlied@gmail.com, simona@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: andriy.shevchenko@intel.com, holofermes@gmail.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, Amit Barzilai Subject: [PATCH v5 4/6] drm/ssd130x: Replace positional ssd130x_spi_id[] initialization with C99 Date: Sun, 23 Aug 2026 14:19:57 +0300 Message-ID: <20260823111959.17029-5-amit.barzilai22@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260823111959.17029-1-amit.barzilai22@gmail.com> References: <20260823111959.17029-1-amit.barzilai22@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ssd130x_spi_id[] is initialized with positional initializers, which easily create easy-to-miss bugs when changing the members of the target struct (struct spi_device_id in this example). Change this to C99 initializers to guarantee each member is initialized with the correct value. Signed-off-by: Amit Barzilai Reviewed-by: Andy Shevchenko Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/solomon/ssd130x-spi.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/solomon/ssd130x-spi.c b/drivers/gpu/drm/solomo= n/ssd130x-spi.c index b52f5fd592a1..be50e5aa2c87 100644 --- a/drivers/gpu/drm/solomon/ssd130x-spi.c +++ b/drivers/gpu/drm/solomon/ssd130x-spi.c @@ -160,17 +160,17 @@ MODULE_DEVICE_TABLE(of, ssd130x_of_match); */ static const struct spi_device_id ssd130x_spi_id[] =3D { /* ssd130x family */ - { "sh1106", SH1106_ID }, - { "ssd1305", SSD1305_ID }, - { "ssd1306", SSD1306_ID }, - { "ssd1307", SSD1307_ID }, - { "ssd1309", SSD1309_ID }, + { .name =3D "sh1106", .driver_data =3D SH1106_ID }, + { .name =3D "ssd1305", .driver_data =3D SSD1305_ID }, + { .name =3D "ssd1306", .driver_data =3D SSD1306_ID }, + { .name =3D "ssd1307", .driver_data =3D SSD1307_ID }, + { .name =3D "ssd1309", .driver_data =3D SSD1309_ID }, /* ssd132x family */ - { "ssd1322", SSD1322_ID }, - { "ssd1325", SSD1325_ID }, - { "ssd1327", SSD1327_ID }, + { .name =3D "ssd1322", .driver_data =3D SSD1322_ID }, + { .name =3D "ssd1325", .driver_data =3D SSD1325_ID }, + { .name =3D "ssd1327", .driver_data =3D SSD1327_ID }, /* ssd133x family */ - { "ssd1331", SSD1331_ID }, + { .name =3D "ssd1331", .driver_data =3D SSD1331_ID }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(spi, ssd130x_spi_id); --=20 2.55.0 From nobody Mon Sep 28 10:44:10 2026 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 550E4386C36 for ; Sun, 23 Aug 2026 11:20:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787484049; cv=none; b=ZdHzMpPzMG4AM4wHhcDx/QsexP9+8018bVZUFEADJYW+b7QXMpWyfpduf4BwwyLCWwvhbKajv+X2iZIIG0CxcHsXF53gYpGiVqd58xTVUARgvZOHUGSUlqZTLvt4e512X77r4NLN688KTyX253Ucd2EQdTz4F+gKI/EbjVcil+o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787484049; c=relaxed/simple; bh=YCQmStD21VL0vqDdwDJHRxmOjVQaOVxz/3cF0MNYmpM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=i8mrXiw+9TZTkB2Tggv1WZ2SfowFWBD+sY9QTcK0Ds6e7JYSYKotT+YZAfPcsxtUsSGIwWfQ2qHI5+MbHFQEvI6WsM7ksZwETg2z9x45Fl9/M3lhZ1rVnfou2sRZF3HSFm8PpqL9vpXQkGm7ujPPJPGv769y3+PJcyJ94d1Pdek= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=laa0mM69; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="laa0mM69" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-6a051b737d8so3186318a12.1 for ; Sun, 23 Aug 2026 04:20:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787484043; x=1788088843; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SZlvya7+gytEhYd4eQsQn/QeDP25uctPqe5cmCgXCPc=; b=laa0mM69fk2brvxJqlJEZi5ns5YnuTVYo0/E4S+Mj+mVaXNdu/0SpWpgSUn7rbUZ6K Qtr8io+RbsE5XWHscBdkH6ReMbQR14vAdegAn7vMRS23O8KqJgUe7KJmjMDXV1tA0l4i Uj9CWd2BMokvUtfSfCdcKrHGps+kJjx0HacFw1Tu3TlSTcLmyEVWAeomYAhrdr+rGsVB 3W/GVAtV/k1OAUolrp8IC7Shi9gNiqcUdr2bKnwy1YHB5fZxkFMO5R9vfw5wzShqHrDH Xrzo6OC8hN0/1Awz/UeoF+2PTG3fskSksMFubp7Wubn6BVHWe3I3jSxGUzl1iPFVql4H Dg1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787484043; x=1788088843; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=SZlvya7+gytEhYd4eQsQn/QeDP25uctPqe5cmCgXCPc=; b=Nqtaa6AHXzCO0UREBXOKXu196kxC1CLtiDW/BuIoeX5IuMayjYFUDUotAGoSN9jY02 vvhqN9Hk/Acw9TNMulogvf/UchKnWYt8Ivy/8NmDAb95Fau/Cxu5zJ1oCL1MdKs3lmAw QsGrUD1mbeUb/07frDrkvK8ss8LlZEDzP+MxQ+YmLh+6aq6/0H523Qab+f9WiarEnoi4 r2x7hcd9iig5A+Ilf8Il8XYcDMMkXurCBdrnWnQJUqBJvEFZbIlGNz5g0ZrGdtUQoK0D gHybF5yajR3pFezOJWUqMkvmYZR4rUXgYo/Vz7ObD9j1xRypXI0VdbLOZL8ON7b0wLe+ pRsQ== X-Forwarded-Encrypted: i=1; AHgh+RoAmy3Br9Hba3VJH9bhtdbzVB3vraMI1l2LAYxc8yuSpnY1oK8VgQKFl1yzmtfbG3TLr3nqX8/GJLVZ0L4=@vger.kernel.org X-Gm-Message-State: AFuF++l8sXAPWtb3IpteFukPFcziOxUX7H8QzZuRWKEAXuhSyDOu/KlN BWPPoiAOBiYweWiYix2s1Z4MTeY6U9S2WyFF2tM8bD69T1uTl0QuW01k X-Gm-Gg: AR+sD10fxzoZqjC+TEeDj6IY4qbr6xSoWKadDAeOgeer57dgmzZnT6j2gdnKKh3yPam tklKLGi/OjnKJLnhdoQlmlEX1hyujvguHtJ/p1+2k9mUCExOeJf7P/XLfwUHMKVR/LdOL2jN9rf OZGU0/sUxf3avswm8dBXT1Ck9gdYG4hrdZn8/awziwiyKTREZT20GhcMXtW76v1P8vQhRmMnp8l A0G4dUqSLFs86+24zfLj+iHwYsnQ4Slxp4mFscQF2WgWDDEMr5lX1lNCvimUZKdzDtJuMYjzug1 cSSGzaNW4+WFD41hwVMTvow1eoA5Sn8Kvfw3zGwwUyU2Hzo+3GrLkNEg9d7Cl0zv5uUVxEPlL5C 8IaR++OfxaC+af2lZV7tykOn7Jg727PukR9/Zz+HHDjPKDBe9u8HODdeO894Q+nToO9non+HBFN alAIylo6SE169Zy1E8hiY5HkMqY46Ezzbnoht9B41OVYYVyjPhxeW9aFf8xcrYtVoKBg== X-Received: by 2002:a17:907:72c1:b0:c24:bf0b:6b62 with SMTP id a640c23a62f3a-c24bf0b6d6fmr40013866b.4.1787484042903; Sun, 23 Aug 2026 04:20:42 -0700 (PDT) Received: from thinker ([2a13:54c2:f000:e268:6d0c:d746:2b12:231f]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c24966f58dfsm707233866b.38.2026.08.23.04.20.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Aug 2026 04:20:42 -0700 (PDT) From: Amit Barzilai To: javierm@redhat.com, airlied@gmail.com, simona@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: andriy.shevchenko@intel.com, holofermes@gmail.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, Amit Barzilai Subject: [PATCH v5 5/6] drm/ssd130x: Implement ssd130x_write_cmd() on top of ssd130x_write_cmds() Date: Sun, 23 Aug 2026 14:19:58 +0300 Message-ID: <20260823111959.17029-6-amit.barzilai22@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260823111959.17029-1-amit.barzilai22@gmail.com> References: <20260823111959.17029-1-amit.barzilai22@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ssd130x_write_cmd() and ssd130x_write_cmds() each carried their own regmap_write() loop over SSD13XX_COMMAND, differing only in how the caller supplies the bytes. Turn ssd130x_write_cmd() into a thin variadic wrapper that collects its arguments into a small stack buffer and defers to ssd130x_write_cmds(), and move the protocol comment onto the latter, which is where the loop now lives. No functional change: the bytes sent and the bus transactions used to send them are identical for every chip on both the I2C and SPI transports. Assisted-by: Claude:claude-opus-5 Signed-off-by: Amit Barzilai Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/solomon/ssd130x.c | 65 +++++++++++++++---------------- 1 file changed, 31 insertions(+), 34 deletions(-) diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ss= d130x.c index 73e7f2a8b730..cdef0c09b050 100644 --- a/drivers/gpu/drm/solomon/ssd130x.c +++ b/drivers/gpu/drm/solomon/ssd130x.c @@ -258,41 +258,12 @@ static int ssd130x_write_data(struct ssd130x_device *= ssd130x, const u8 *values, } =20 /* - * Helper to write command (SSD13XX_COMMAND). The fist variadic argument - * is the command to write and the following are the command options. + * Helper to write a command (SSD13XX_COMMAND) from a buffer. The first by= te + * is the command opcode and the following ones are its parameters. * - * Note that the ssd13xx protocol requires each command and option to be - * written as a SSD13XX_COMMAND device register value. That is why a call - * to regmap_write(..., SSD13XX_COMMAND, ...) is done for each argument. - */ -static int ssd130x_write_cmd(struct ssd130x_device *ssd130x, int count, - /* u8 cmd, u8 option, ... */...) -{ - va_list ap; - u8 value; - int ret; - - va_start(ap, count); - - do { - value =3D va_arg(ap, int); - ret =3D regmap_write(ssd130x->regmap, SSD13XX_COMMAND, value); - if (ret) - goto out_end; - } while (--count); - -out_end: - va_end(ap); - - return ret; -} - -/* - * Write a command byte sequence from a buffer. - * - * Like ssd130x_write_cmd() but takes a pre-built byte array instead of - * variadic arguments, handy when the command is already in an array or - * when the caller wants to use sizeof() for the length. + * Note that the ssd13xx protocol requires the opcode and each parameter to + * be written as a SSD13XX_COMMAND device register value. That is why a ca= ll + * to regmap_write(..., SSD13XX_COMMAND, ...) is done for each byte. */ static int ssd130x_write_cmds(struct ssd130x_device *ssd130x, const u8 *cm= d, size_t len) @@ -309,6 +280,32 @@ static int ssd130x_write_cmds(struct ssd130x_device *s= sd130x, const u8 *cmd, return 0; } =20 +/* + * Variadic wrapper around ssd130x_write_cmds(). The first variadic argume= nt + * is the command opcode and the following are its parameters. + * + * The arguments are gathered into a fixed size buffer, so at most 8 bytes + * can be sent per call, i.e. an opcode and seven parameters. That covers + * every command this driver sends through it. Commands taking more parame= ters, + * such as the grey scale tables, must use ssd130x_write_cmds() instead. + */ +static int ssd130x_write_cmd(struct ssd130x_device *ssd130x, int count, + /* u8 cmd, u8 param, ... */...) +{ + u8 buf[8]; + va_list ap; + + if (drm_WARN_ON(&ssd130x->drm, count > sizeof(buf))) + return -EINVAL; + + va_start(ap, count); + for (int i =3D 0; i < count; i++) + buf[i] =3D va_arg(ap, int); + va_end(ap); + + return ssd130x_write_cmds(ssd130x, buf, count); +} + /* * Run a packed command sequence. The format is a flat byte array where e= ach * entry starts with a length byte followed by that many command bytes. A --=20 2.55.0 From nobody Mon Sep 28 10:44:10 2026 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C31533C3BF1 for ; Sun, 23 Aug 2026 11:20:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787484054; cv=none; b=YZQS9vtpjnIWvST3pqDNLGMPmx+7YpiBC5pAG91iNAF25GTcAr4vxchlMthrrI27ezo8ssDX3857ElUpfnT/T7g0cBgPH3UMTUiAPn+MmCHTJWFbVMzau4sT6qGuTBWNhQcjujWMGrZ3Rszv6p4nlntvT2vqDkOTVWEZtX2D1Ok= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787484054; c=relaxed/simple; bh=tAR54kBvRfhHk16I5/BF3EV8Z8Oyzy8kLAF+C6LEftA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ilRcVOYyetcFL+qIKttoIuXf2ZCdiUPr07QR+eHnYATsfvT/eShvCNPyf7ihHhiS70DsBTVSicTxF2nwVzdIPt7zGVPn8p6mQGMBRGj7CY8Q9xl4tSHTe7I1BvJaAKhg03r+nDmDocRiq69hiH/2FjDlxzXSRU84UupKY5hf9KQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WK1kOrnY; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WK1kOrnY" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-c214e625259so351339666b.2 for ; Sun, 23 Aug 2026 04:20:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787484047; x=1788088847; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/ZeSDS753afu+VwEFedbDANoyqa3UBLs8gHOxfx3d3k=; b=WK1kOrnYbqxeybEdFbVXUjZQZ1My7Znjre8bkKQsFzGW5u3NDH2NAismQOLNkyCybL SR8ZEkOmJdA5R2C5tcqYj4socC3gDH9fOgBA+Ys7338E1OXJj0BJi4EtVkxYJYYuoslE +XD4NSI4304LIMwq2EZr/x31MJcxh6wvmws0XhpNQiBB8DG3ZBdLSsCZFsl12EV71vrH 8aZdzDgNih9FIz5jVDkTvurE2NXjcMeHCihM31T19l3wy1HN3wEvDFLTS6gRty1HsOaZ u9YMS7iNzXjh0UbG0LbIw10IC6/U19Y3k5vQG8fCnV10T9lje+fHyjE5LIWhudk4qUKJ +axA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787484047; x=1788088847; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=/ZeSDS753afu+VwEFedbDANoyqa3UBLs8gHOxfx3d3k=; b=GPpPFa+190zso1acFo6dHlaU3fkrEdeYH0kBoZ1Tsa7AOCfgZ19WZYA+696bJu7E8m fI8Z3Hq530ubwFMRCx0K+zLvUxII13tuH33PMEZFuzyvd+gp/vd8kJfRnIhiqMYFmAZ2 phJ70NCyZyFnN9hFhZuD/d667kdFxxwd8/m7BGROEimoe0qcISTh5R+8v2Aw5R51iBC4 GOVekPe4tIMmRhPA2hn+KvLnM4pZn854RbA0608mAE1BNAZegbG9FfSWNdWNx/b+CcGq T6mycGQV61aBiE7UEVGCYMYwKV5Y+c7pElVjrcc1Ki+lZO0uurte06OcbxfDoEyluV/G SiSw== X-Forwarded-Encrypted: i=1; AHgh+RrSYeWpDp4YeJrVB99ZG8wmJdfbIaTAsHQdsWh+YhjH9v4fsDOEg7I0ZVke3YTfj9Ib9kfWDFz0uaEJoiw=@vger.kernel.org X-Gm-Message-State: AFuF++lqyVrv4TEAtMP79JOxmBYMRG97kqTzRpBzd8R15ez1Jw9m3be0 1TBPk2l3bYI60Gmhxkf3gjpPEwlZhQbr1TiBCKqIB7oxtPA9E2e1hoKa X-Gm-Gg: AR+sD12IiRrK9h63vAy4oPGWSzZPCWKBpXH6ndmxKaiLC9CHR5ezfu8XFtAvSgKlYOW CgsEL1tbMfHDBzUWsPfxbzMKuNMRoVt+RSlWgvQxU/7hTfVAX7FFRAzghq1T+t4lMs9BzQwmrbH D2fLOn2txCU3a5WueUmDEz5kIGA9jabzn7OThoTNJXxXqo3ELjfZ9LPe/8f0xNs85yFfJCm2eUQ UazUgJ1sJvkNjfDeT4JQv/CWfFdfM62Lgi70a8gx1ZBzc2xZRA4D21eZltKlVDG8Q06TQUfylla kaNjn9Dx2sPr6oqxt4dWvmcLuAmoBSwLpKTEBmeC97DbyxYvnmFEfpJFGMqZo9FJHu1AsYTIg2x dWI/p650oLa0mHYkO3UdrVLWl4Y4XxHAjkRt/Jb5Su339MC8T5drcVaEuyd5PNbXGtb40QRKExR Oeg8eWbpZJHlrucrFVCHmo1lDPHAvMJ+8g+/+xbe8mDDAOSshiCSecfqBVx1SH0z79hA== X-Received: by 2002:a17:906:9c8a:b0:c21:792:8257 with SMTP id a640c23a62f3a-c246a5f67e6mr2085096466b.15.1787484047157; Sun, 23 Aug 2026 04:20:47 -0700 (PDT) Received: from thinker ([2a13:54c2:f000:e268:6d0c:d746:2b12:231f]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c24966f58dfsm707233866b.38.2026.08.23.04.20.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Aug 2026 04:20:46 -0700 (PDT) From: Amit Barzilai To: javierm@redhat.com, airlied@gmail.com, simona@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: andriy.shevchenko@intel.com, holofermes@gmail.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, Amit Barzilai Subject: [PATCH v5 6/6] drm/ssd130x: Add SSD135X_FAMILY and SSD1351 support Date: Sun, 23 Aug 2026 14:19:59 +0300 Message-ID: <20260823111959.17029-7-amit.barzilai22@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260823111959.17029-1-amit.barzilai22@gmail.com> References: <20260823111959.17029-1-amit.barzilai22@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Solomon SSD1351 is a 128x128 RGB color OLED controller. It shares the SSD133X pixel layout: one 65k color (RGB565) pixel per Segment, written as a bulk transfer once a column/row addressing window has been programmed. Add it as a new SSD135X_FAMILY rather than as a separate driver, so that the ssd130x plane, CRTC and encoder infrastructure is reused. Give the family its own primary plane update and disable, encoder enable and backlight callbacks instead of teaching the ssd133x ones about a second family. Only the callbacks that carry no family specific logic are reused as is: ssd133x_primary_plane_atomic_check(), ssd133x_crtc_atomic_check() and ssd130x_encoder_atomic_disable(). The data path differs from the ssd133x family in one respect. The SSD1351 only starts accepting pixel data after an explicit Write RAM command (0x5c), while the SSD133X enters data mode as soon as the address window has been programmed. Emit it from ssd135x_update_rect(), which both the damage update and the clear screen paths go through. SSD1351 differs from previous controllers in the command protocol. While the opcode is still sent on the command path, the parameters are sent on the data path. Introduce the cmd_params_are_data flag to struct ssd130x_deviceinfo and let ssd130x_write_cmds() split the buffer in accordance to the device specifications. The SSD1351 also needs its own init sequence (ssd135x_init). The remap byte is fixed at horizontal address increment, COM split, reversed COM scan direction, BGR sub-pixel order and 65k color depth; rotation is not supported. Contrast is calibrated per color channel as for the ssd133x family, but the three channels are parameters of a single command (0xc1) instead of one command per channel. Add ssd135x_set_contrast() for that and use it from both the init and the backlight update paths. The SSD1351 is SPI-only, so only the SPI transport match tables gain an entry; no new config symbol is needed. Assisted-by: Claude:claude-opus-5 Signed-off-by: Amit Barzilai Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/solomon/ssd130x-spi.c | 7 + drivers/gpu/drm/solomon/ssd130x.c | 311 +++++++++++++++++++++++++- drivers/gpu/drm/solomon/ssd130x.h | 10 +- 3 files changed, 321 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/solomon/ssd130x-spi.c b/drivers/gpu/drm/solomo= n/ssd130x-spi.c index be50e5aa2c87..c41064aa8221 100644 --- a/drivers/gpu/drm/solomon/ssd130x-spi.c +++ b/drivers/gpu/drm/solomon/ssd130x-spi.c @@ -146,6 +146,11 @@ static const struct of_device_id ssd130x_of_match[] = =3D { .compatible =3D "solomon,ssd1331", .data =3D &ssd130x_variants[SSD1331_ID], }, + /* ssd135x family */ + { + .compatible =3D "solomon,ssd1351", + .data =3D &ssd130x_variants[SSD1351_ID], + }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(of, ssd130x_of_match); @@ -171,6 +176,8 @@ static const struct spi_device_id ssd130x_spi_id[] =3D { { .name =3D "ssd1327", .driver_data =3D SSD1327_ID }, /* ssd133x family */ { .name =3D "ssd1331", .driver_data =3D SSD1331_ID }, + /* ssd135x family */ + { .name =3D "ssd1351", .driver_data =3D SSD1351_ID }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(spi, ssd130x_spi_id); diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ss= d130x.c index cdef0c09b050..546f3df62cfa 100644 --- a/drivers/gpu/drm/solomon/ssd130x.c +++ b/drivers/gpu/drm/solomon/ssd130x.c @@ -151,6 +151,37 @@ #define SSD133X_SET_REMAP_COLOR_DEPTH_MASK GENMASK(7, 6) #define SSD133X_COLOR_DEPTH_65K 0x1 =20 +/* ssd135x commands */ +#define SSD135X_SET_COL_RANGE 0x15 +#define SSD135X_WRITE_RAM 0x5c +#define SSD135X_SET_ROW_RANGE 0x75 +#define SSD135X_SET_DISPLAY_START 0xa1 +#define SSD135X_SET_DISPLAY_OFFSET 0xa2 +#define SSD135X_SET_DISPLAY_NORMAL 0xa6 +#define SSD135X_SET_FUNCTION 0xab +#define SSD135X_SET_PHASE_LENGTH 0xb1 +#define SSD135X_SET_CLOCK_FREQ 0xb3 +#define SSD135X_SET_VSL 0xb4 +#define SSD135X_SET_GPIO 0xb5 +#define SSD135X_SET_PRECHARGE2 0xb6 +#define SSD135X_SET_PRECHARGE_VOLTAGE 0xbb +#define SSD135X_SET_VCOMH_VOLTAGE 0xbe +#define SSD135X_SET_CONTRAST 0xc1 +#define SSD135X_SET_CONTRAST_MASTER 0xc7 +#define SSD135X_SET_MUX_RATIO 0xca +#define SSD135X_SET_COMMAND_LOCK 0xfd + +/* ssd135x A/B/C channel contrast at full brightness (white balance) */ +#define SSD135X_DEFAULT_CONTRAST_A 0xc8 +#define SSD135X_DEFAULT_CONTRAST_B 0x80 +#define SSD135X_DEFAULT_CONTRAST_C 0xc8 + +/* ssd135x remap byte (data of SSD13XX_SET_SEG_REMAP) */ +#define SSD135X_SET_REMAP_COLOR_BGR BIT(2) +#define SSD135X_SET_REMAP_COM_SCAN BIT(4) +#define SSD135X_SET_REMAP_COM_SPLIT BIT(5) +#define SSD135X_SET_REMAP_65K BIT(6) + #define MAX_CONTRAST 255 =20 const struct ssd130x_deviceinfo ssd130x_variants[] =3D { @@ -218,7 +249,14 @@ const struct ssd130x_deviceinfo ssd130x_variants[] =3D= { .default_width =3D 96, .default_height =3D 64, .family_id =3D SSD133X_FAMILY, - } + }, + /* ssd135x family */ + [SSD1351_ID] =3D { + .default_width =3D 128, + .default_height =3D 128, + .family_id =3D SSD135X_FAMILY, + .cmd_params_are_data =3D true, + }, }; EXPORT_SYMBOL_NS_GPL(ssd130x_variants, "DRM_SSD130X"); =20 @@ -261,9 +299,10 @@ static int ssd130x_write_data(struct ssd130x_device *s= sd130x, const u8 *values, * Helper to write a command (SSD13XX_COMMAND) from a buffer. The first by= te * is the command opcode and the following ones are its parameters. * - * Note that the ssd13xx protocol requires the opcode and each parameter to - * be written as a SSD13XX_COMMAND device register value. That is why a ca= ll - * to regmap_write(..., SSD13XX_COMMAND, ...) is done for each byte. + * By default every byte is written as a SSD13XX_COMMAND register value, h= ence + * the regmap_write() per byte. Controllers that set cmd_params_are_data e= xpect + * the parameters on the data path instead, so only the opcode is written = as + * SSD13XX_COMMAND and the rest as SSD13XX_DATA. */ static int ssd130x_write_cmds(struct ssd130x_device *ssd130x, const u8 *cm= d, size_t len) @@ -271,6 +310,17 @@ static int ssd130x_write_cmds(struct ssd130x_device *s= sd130x, const u8 *cmd, unsigned int i; int ret; =20 + if (ssd130x->device_info->cmd_params_are_data) { + if (!len) + return 0; + + ret =3D regmap_write(ssd130x->regmap, SSD13XX_COMMAND, cmd[0]); + if (ret || len =3D=3D 1) + return ret; + + return ssd130x_write_data(ssd130x, cmd + 1, len - 1); + } + for (i =3D 0; i < len; i++) { ret =3D regmap_write(ssd130x->regmap, SSD13XX_COMMAND, cmd[i]); if (ret) @@ -617,6 +667,20 @@ static int ssd133x_set_contrast(struct ssd130x_device = *ssd130x, u32 brightness) return ssd130x_run_cmd_seq(ssd130x, cmds); } =20 +/* + * Same white balance calibration as for the ssd133x family, except that t= he + * ssd135x controllers take the three channels as parameters of a single + * command instead of one command per channel. + */ +static int ssd135x_set_contrast(struct ssd130x_device *ssd130x, u32 bright= ness) +{ + u8 a =3D ssd130x_scale_contrast(SSD135X_DEFAULT_CONTRAST_A, brightness); + u8 b =3D ssd130x_scale_contrast(SSD135X_DEFAULT_CONTRAST_B, brightness); + u8 c =3D ssd130x_scale_contrast(SSD135X_DEFAULT_CONTRAST_C, brightness); + + return ssd130x_write_cmd(ssd130x, 4, SSD135X_SET_CONTRAST, a, b, c); +} + static int ssd133x_init(struct ssd130x_device *ssd130x) { int ret; @@ -654,6 +718,47 @@ static int ssd133x_init(struct ssd130x_device *ssd130x) return ssd130x_run_cmd_seq(ssd130x, cmds); } =20 +static int ssd135x_init(struct ssd130x_device *ssd130x) +{ + /* + * Horizontal address increment, COM split, reversed COM scan direction, + * BGR sub-pixel order and 65k (RGB565) color depth. Rotation is not + * supported, so the remap byte is fixed. + */ + const u8 remap =3D SSD135X_SET_REMAP_65K | SSD135X_SET_REMAP_COM_SPLIT | + SSD135X_SET_REMAP_COLOR_BGR | SSD135X_SET_REMAP_COM_SCAN; + const u8 cmds[] =3D { + /* Unlock the controller, then the extended command set */ + 2, SSD135X_SET_COMMAND_LOCK, 0x12, + 2, SSD135X_SET_COMMAND_LOCK, 0xb1, + 1, SSD13XX_DISPLAY_OFF, + 2, SSD135X_SET_CLOCK_FREQ, 0xf1, + 2, SSD135X_SET_MUX_RATIO, ssd130x->height - 1, + 3, SSD135X_SET_COL_RANGE, 0x00, ssd130x->width - 1, + 3, SSD135X_SET_ROW_RANGE, 0x00, ssd130x->height - 1, + 2, SSD135X_SET_DISPLAY_START, 0x00, + 2, SSD135X_SET_DISPLAY_OFFSET, 0x00, + 2, SSD135X_SET_GPIO, 0x00, + 2, SSD135X_SET_FUNCTION, 0x01, + 2, SSD135X_SET_PHASE_LENGTH, 0x32, + 4, SSD135X_SET_VSL, 0xa0, 0xb5, 0x55, + 2, SSD135X_SET_PRECHARGE_VOLTAGE, 0x17, + 2, SSD135X_SET_VCOMH_VOLTAGE, 0x05, + 2, SSD135X_SET_CONTRAST_MASTER, 0x0f, + 2, SSD135X_SET_PRECHARGE2, 0x01, + 1, SSD135X_SET_DISPLAY_NORMAL, + 2, SSD13XX_SET_SEG_REMAP, remap, + 0, + }; + int ret; + + ret =3D ssd130x_run_cmd_seq(ssd130x, cmds); + if (ret < 0) + return ret; + + return ssd135x_set_contrast(ssd130x, ssd130x->contrast); +} + static int ssd130x_update_rect(struct ssd130x_device *ssd130x, struct drm_rect *rect, u8 *buf, u8 *data_array) @@ -863,6 +968,44 @@ static int ssd133x_update_rect(struct ssd130x_device *= ssd130x, return ret; } =20 +static int ssd135x_update_rect(struct ssd130x_device *ssd130x, + struct drm_rect *rect, u8 *data_array, + unsigned int pitch) +{ + unsigned int x =3D rect->x1; + unsigned int y =3D rect->y1; + unsigned int columns =3D drm_rect_width(rect); + unsigned int rows =3D drm_rect_height(rect); + int ret; + + /* + * The pixel layout is the same as for the ssd133x family: one 65k + * color (RGB565) pixel per Segment, sent Segment by Segment when the + * (default) horizontal address increment mode is used. + * + * But unlike the ssd133x family, which starts accepting pixel data as + * soon as the address window has been programmed, the ssd135x family + * needs an explicit Write RAM command before the data is written. + */ + + /* Set column start and end */ + ret =3D ssd130x_write_cmd(ssd130x, 3, SSD135X_SET_COL_RANGE, x, x + colum= ns - 1); + if (ret < 0) + return ret; + + /* Set row start and end */ + ret =3D ssd130x_write_cmd(ssd130x, 3, SSD135X_SET_ROW_RANGE, y, y + rows = - 1); + if (ret < 0) + return ret; + + ret =3D ssd130x_write_cmd(ssd130x, 1, SSD135X_WRITE_RAM); + if (ret < 0) + return ret; + + /* Write out update in one go since horizontal addressing mode is used */ + return ssd130x_write_data(ssd130x, data_array, pitch * rows); +} + static void ssd130x_clear_screen(struct ssd130x_device *ssd130x, u8 *data_= array) { unsigned int pages =3D DIV_ROUND_UP(ssd130x->height, SSD130X_PAGE_HEIGHT); @@ -932,6 +1075,23 @@ static void ssd133x_clear_screen(struct ssd130x_devic= e *ssd130x, u8 *data_array) ssd130x_write_data(ssd130x, data_array, pitch * ssd130x->height); } =20 +static void ssd135x_clear_screen(struct ssd130x_device *ssd130x, u8 *data_= array) +{ + struct drm_rect screen =3D DRM_RECT_INIT(0, 0, ssd130x->width, ssd130x->h= eight); + const struct drm_format_info *fi; + unsigned int pitch; + + fi =3D drm_format_info(DRM_FORMAT_RGB565); + if (!fi) + return; + + pitch =3D drm_format_info_min_pitch(fi, 0, ssd130x->width); + + memset(data_array, 0, pitch * ssd130x->height); + + ssd135x_update_rect(ssd130x, &screen, data_array, pitch); +} + static int ssd130x_fb_blit_rect(struct drm_framebuffer *fb, const struct iosys_map *vmap, struct drm_rect *rect, @@ -1005,6 +1165,30 @@ static int ssd133x_fb_blit_rect(struct drm_framebuff= er *fb, return 0; } =20 +static int ssd135x_fb_blit_rect(struct drm_framebuffer *fb, + const struct iosys_map *vmap, + struct drm_rect *rect, u8 *data_array, + struct drm_format_conv_state *fmtcnv_state) +{ + struct ssd130x_device *ssd130x =3D drm_to_ssd130x(fb->dev); + const struct drm_format_info *fi; + unsigned int dst_pitch; + struct iosys_map dst; + + fi =3D drm_format_info(DRM_FORMAT_RGB565); + if (!fi) + return -EINVAL; + + dst_pitch =3D drm_format_info_min_pitch(fi, 0, drm_rect_width(rect)); + + iosys_map_set_vaddr(&dst, data_array); + drm_fb_xrgb8888_to_rgb565be(&dst, &dst_pitch, vmap, fb, rect, fmtcnv_stat= e); + + ssd135x_update_rect(ssd130x, rect, data_array, dst_pitch); + + return 0; +} + static int ssd130x_primary_plane_atomic_check(struct drm_plane *plane, struct drm_atomic_commit *state) { @@ -1247,6 +1431,45 @@ static void ssd133x_primary_plane_atomic_update(stru= ct drm_plane *plane, drm_dev_exit(idx); } =20 +static void ssd135x_primary_plane_atomic_update(struct drm_plane *plane, + struct drm_atomic_commit *state) +{ + struct drm_plane_state *plane_state =3D drm_atomic_get_new_plane_state(st= ate, plane); + struct drm_plane_state *old_plane_state =3D drm_atomic_get_old_plane_stat= e(state, plane); + struct drm_shadow_plane_state *shadow_plane_state =3D to_drm_shadow_plane= _state(plane_state); + struct drm_crtc_state *crtc_state =3D drm_atomic_get_new_crtc_state(state= , plane_state->crtc); + struct ssd130x_crtc_state *ssd130x_crtc_state =3D to_ssd130x_crtc_state(= crtc_state); + struct drm_framebuffer *fb =3D plane_state->fb; + struct drm_atomic_helper_damage_iter iter; + struct drm_device *drm =3D plane->dev; + struct drm_rect dst_clip; + struct drm_rect damage; + int idx; + + if (!drm_dev_enter(drm, &idx)) + return; + + if (drm_gem_fb_begin_cpu_access(fb, DMA_FROM_DEVICE)) + goto out_drm_dev_exit; + + drm_atomic_helper_damage_iter_init(&iter, old_plane_state, plane_state); + drm_atomic_for_each_plane_damage(&iter, &damage) { + dst_clip =3D plane_state->dst; + + if (!drm_rect_intersect(&dst_clip, &damage)) + continue; + + ssd135x_fb_blit_rect(fb, &shadow_plane_state->data[0], &dst_clip, + ssd130x_crtc_state->data_array, + &shadow_plane_state->fmtcnv_state); + } + + drm_gem_fb_end_cpu_access(fb, DMA_FROM_DEVICE); + +out_drm_dev_exit: + drm_dev_exit(idx); +} + static void ssd130x_primary_plane_atomic_disable(struct drm_plane *plane, struct drm_atomic_commit *state) { @@ -1319,6 +1542,31 @@ static void ssd133x_primary_plane_atomic_disable(str= uct drm_plane *plane, drm_dev_exit(idx); } =20 +static void ssd135x_primary_plane_atomic_disable(struct drm_plane *plane, + struct drm_atomic_commit *state) +{ + struct drm_device *drm =3D plane->dev; + struct ssd130x_device *ssd130x =3D drm_to_ssd130x(drm); + struct drm_plane_state *plane_state; + struct drm_crtc_state *crtc_state; + struct ssd130x_crtc_state *ssd130x_crtc_state; + int idx; + + plane_state =3D drm_atomic_get_new_plane_state(state, plane); + if (!plane_state->crtc) + return; + + crtc_state =3D drm_atomic_get_new_crtc_state(state, plane_state->crtc); + ssd130x_crtc_state =3D to_ssd130x_crtc_state(crtc_state); + + if (!drm_dev_enter(drm, &idx)) + return; + + ssd135x_clear_screen(ssd130x, ssd130x_crtc_state->data_array); + + drm_dev_exit(idx); +} + /* Called during init to allocate the plane's atomic state. */ static void ssd130x_primary_plane_reset(struct drm_plane *plane) { @@ -1387,7 +1635,13 @@ static const struct drm_plane_helper_funcs ssd130x_p= rimary_plane_helper_funcs[] .atomic_check =3D ssd133x_primary_plane_atomic_check, .atomic_update =3D ssd133x_primary_plane_atomic_update, .atomic_disable =3D ssd133x_primary_plane_atomic_disable, - } + }, + [SSD135X_FAMILY] =3D { + DRM_GEM_SHADOW_PLANE_HELPER_FUNCS, + .atomic_check =3D ssd133x_primary_plane_atomic_check, + .atomic_update =3D ssd135x_primary_plane_atomic_update, + .atomic_disable =3D ssd135x_primary_plane_atomic_disable, + }, }; =20 static const struct drm_plane_funcs ssd130x_primary_plane_funcs =3D { @@ -1542,6 +1796,10 @@ static const struct drm_crtc_helper_funcs ssd130x_cr= tc_helper_funcs[] =3D { .mode_valid =3D ssd130x_crtc_mode_valid, .atomic_check =3D ssd133x_crtc_atomic_check, }, + [SSD135X_FAMILY] =3D { + .mode_valid =3D ssd130x_crtc_mode_valid, + .atomic_check =3D ssd133x_crtc_atomic_check, + }, }; =20 static const struct drm_crtc_funcs ssd130x_crtc_funcs =3D { @@ -1629,6 +1887,31 @@ static void ssd133x_encoder_atomic_enable(struct drm= _encoder *encoder, ssd130x_power_off(ssd130x); } =20 +static void ssd135x_encoder_atomic_enable(struct drm_encoder *encoder, + struct drm_atomic_commit *state) +{ + struct drm_device *drm =3D encoder->dev; + struct ssd130x_device *ssd130x =3D drm_to_ssd130x(drm); + int ret; + + ret =3D ssd130x_power_on(ssd130x); + if (ret) + return; + + ret =3D ssd135x_init(ssd130x); + if (ret) + goto power_off; + + ssd130x_write_cmd(ssd130x, 1, SSD13XX_DISPLAY_ON); + + backlight_enable(ssd130x->bl_dev); + + return; + +power_off: + ssd130x_power_off(ssd130x); +} + static void ssd130x_encoder_atomic_disable(struct drm_encoder *encoder, struct drm_atomic_commit *state) { @@ -1654,7 +1937,11 @@ static const struct drm_encoder_helper_funcs ssd130x= _encoder_helper_funcs[] =3D { [SSD133X_FAMILY] =3D { .atomic_enable =3D ssd133x_encoder_atomic_enable, .atomic_disable =3D ssd130x_encoder_atomic_disable, - } + }, + [SSD135X_FAMILY] =3D { + .atomic_enable =3D ssd135x_encoder_atomic_enable, + .atomic_disable =3D ssd130x_encoder_atomic_disable, + }, }; =20 static const struct drm_encoder_funcs ssd130x_encoder_funcs =3D { @@ -1731,6 +2018,15 @@ static int ssd133x_update_bl(struct backlight_device= *bdev) return ssd133x_set_contrast(ssd130x, ssd130x->contrast); } =20 +static int ssd135x_update_bl(struct backlight_device *bdev) +{ + struct ssd130x_device *ssd130x =3D bl_get_data(bdev); + + ssd130x->contrast =3D backlight_get_brightness(bdev); + + return ssd135x_set_contrast(ssd130x, ssd130x->contrast); +} + static const struct backlight_ops ssd130xfb_bl_ops[] =3D { [SSD130X_FAMILY] =3D { .update_status =3D ssd130x_update_bl, @@ -1741,6 +2037,9 @@ static const struct backlight_ops ssd130xfb_bl_ops[] = =3D { [SSD133X_FAMILY] =3D { .update_status =3D ssd133x_update_bl, }, + [SSD135X_FAMILY] =3D { + .update_status =3D ssd135x_update_bl, + }, }; =20 static void ssd130x_parse_properties(struct ssd130x_device *ssd130x) diff --git a/drivers/gpu/drm/solomon/ssd130x.h b/drivers/gpu/drm/solomon/ss= d130x.h index a4554018bb2a..fd81262f2ceb 100644 --- a/drivers/gpu/drm/solomon/ssd130x.h +++ b/drivers/gpu/drm/solomon/ssd130x.h @@ -26,7 +26,8 @@ enum ssd130x_family_ids { SSD130X_FAMILY, SSD132X_FAMILY, - SSD133X_FAMILY + SSD133X_FAMILY, + SSD135X_FAMILY, }; =20 enum ssd130x_variants { @@ -42,6 +43,8 @@ enum ssd130x_variants { SSD1327_ID, /* ssd133x family */ SSD1331_ID, + /* ssd135x family */ + SSD1351_ID, NR_SSD130X_VARIANTS }; =20 @@ -54,6 +57,11 @@ struct ssd130x_deviceinfo { bool need_pwm; bool need_chargepump; bool page_mode_only; + /* + * Whether the controller takes a command's parameters on the data path + * instead of as further command bytes. + */ + bool cmd_params_are_data; =20 enum ssd130x_family_ids family_id; }; --=20 2.55.0