From nobody Mon Sep 28 10:49:11 2026 Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2B053A9639 for ; Sun, 23 Aug 2026 05:14:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787462095; cv=none; b=MQRy9oKt3V7Rj2ld4pt4aky2fbT5V2BnMp+e5IXgkNEVS1yJ0F/Mu6C/C9MJuaWBytiTdaH90lTebTAXCqLu6F+gSwJYhzVqZnKqacjPfEKmsxFm2bEkX3LCEI5xMe9VEoNb6Sie3WqxBb8a7jvNAPbNXVZgL3MjQDVri4iKUUI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787462095; c=relaxed/simple; bh=hBTl3OplU1p8q6ZU/4irMEs/GM5uPPfjX2GZfSCnwkA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=r6r0oQgetUKtL0+ax8gsdF0s0k0WTzuHV7i7Fgkmn1GczWGf5Ye1wyV65/GO/Ws7Vc5yv4j18KmCGIcnkyoXqt1A4yez70BArl7cC1sctopj62lCs6HhW6qgLl1MmdM10cyRZTFP11JZpbsZ3is9tyocmEbeNuylTyU6UXCxDtU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from f3f1baf57000.home.arpa (unknown [36.110.52.2]) by APP-05 (Coremail) with SMTP id zQCowABXh0G_gYpqRuZuBg--.53855S2; Sun, 23 Aug 2026 13:14:40 +0800 (CST) From: liutong To: Anup Patel Cc: Rahul Pathak , Jassi Brar , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, liutong Subject: [PATCH] mailbox: riscv-sbi-mpxy: Fix inverted notification loop Date: Sun, 23 Aug 2026 05:14:30 +0000 Message-Id: <20260823051430.530304-1-liutong@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowABXh0G_gYpqRuZuBg--.53855S2 X-Coremail-Antispam: 1UD129KBjvJXoW7WrWxXw1rKry5JFyfAFWkJFb_yoW8XFyfpa y2ka4YyryUJa13Z3ZrAF1kua4jg395Wr98KF40krnYyrZ8WryYqFWDta429F1rtFW0yFWI vanaqw1DZFyq9FDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvj14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r1I6r4UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j 6F4UM28EF7xvwVC2z280aVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr 1j6F4UJwAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv 7VC0I7IYx2IY67AKxVWUAVWUtwAv7VC2z280aVAFwI0_Cr0_Gr1UMcvjeVCFs4IE7xkEbV WUJVW8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc7CjxVAaw2AF wI0_JF0_Jw1l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4 xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1D MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I 0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWU JVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjfUOD GOUUUUU X-CM-SenderInfo: xolx301qj6x2xfdvhtffof0/ Content-Type: text/plain; charset="utf-8" In mpxy_mbox_peek_rpmi_data(), the while loop condition checks: (events_data_len - pos) <=3D sizeof(*event) This is inverted. The loop should continue while there is enough remaining data to hold at least one event header, i.e. >=3D. With <=3D the loop body is entered only when the remaining data is smaller than one header, which is never useful. In practice, since events_data_len is always larger than sizeof(*event) (4 bytes), the condition is false on the first iteration and the loop is never entered. All RPMI notification events are silently dropped. Fix the condition from <=3D to >=3D. Fixes: bf3022a4eb11 ("mailbox: Add RISC-V SBI message proxy (MPXY) based ma= ilbox driver") Signed-off-by: liutong Reviewed-by: Anup Patel --- drivers/mailbox/riscv-sbi-mpxy-mbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mailbox/riscv-sbi-mpxy-mbox.c b/drivers/mailbox/riscv-= sbi-mpxy-mbox.c index 7c9c006b7..18da9efcc 100644 --- a/drivers/mailbox/riscv-sbi-mpxy-mbox.c +++ b/drivers/mailbox/riscv-sbi-mpxy-mbox.c @@ -480,7 +480,7 @@ static void mpxy_mbox_peek_rpmi_data(struct mbox_chan *= chan, struct rpmi_mbox_message msg; unsigned long pos =3D 0; =20 - while (pos < events_data_len && (events_data_len - pos) <=3D sizeof(*even= t)) { + while (pos < events_data_len && (events_data_len - pos) >=3D sizeof(*even= t)) { event =3D (struct rpmi_notification_event *)(notif->events_data + pos); =20 msg.type =3D RPMI_MBOX_MSG_TYPE_NOTIFICATION_EVENT; --=20 2.34.1