From nobody Mon Sep 28 10:47:10 2026 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF52C217723 for ; Sun, 23 Aug 2026 04:43:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787460243; cv=none; b=OIe1FDvn4OiUmuVj+j+YB8ewMFoBq+O3zjlQTMWbVXV9wFGP+jdy8nT9M/5B1Nd+4ww5QUAyfR1qIO58ZSbAymHuJ5W/LUAEYC15rRGBD1JHb1eQvLu3vhWjb9elQ4hlSH1dNHUgz3vIPD51WjqYOSwlNLfGZqmfIY4NWOQdXu8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787460243; c=relaxed/simple; bh=lEM6CGNGOm9nesN/v3NCQQGlfItlhaqICSI0/GaloCk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=KziMJnJibQs14aHjcIDorYhNEguir4cYQR7GG7+fvXHzyDNuUBNWds14LMLoeOw5dcC0TYcM+uhKj/gwKrnrCO8EMTo9bdJWn7eQLTb8QW1lOTXZVGPiR4l8YFFhKricS7q/h7Z136siGwHo1cd00/swJAX3H+HCYJhHE6kgz94= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from f3f1baf57000.home.arpa (unknown [36.110.52.2]) by APP-01 (Coremail) with SMTP id qwCowACXae2CeopqFCNTBg--.57015S2; Sun, 23 Aug 2026 12:43:46 +0800 (CST) From: liutong To: Atish Patra Cc: Anup Patel , Palmer Dabbelt , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, liutong Subject: [PATCH] perf: riscv: Fix counter_idx_base in PMU snapshot restart Date: Sun, 23 Aug 2026 04:43:37 +0000 Message-Id: <20260823044337.517125-1-liutong@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qwCowACXae2CeopqFCNTBg--.57015S2 X-Coremail-Antispam: 1UD129KBjvJXoW7tr4xtw17Xw17Zr4UtFWfAFb_yoW8Gry7pr WYkay5Kr15Z3y8t34xJFWkWa4Yywn3XFZxKF4qk39Y9r13Xr1rXrykK34vyr1kt348tryU ur4Y93yfC3Wfuw7anT9S1TB71UUUUUDqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkE14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r1I6r4UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j 6F4UM28EF7xvwVC2z280aVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr 1j6F4UJwAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv 7VC0I7IYx2IY67AKxVWUGVWUXwAv7VC2z280aVAFwI0_Cr0_Gr1UMcvjeVCFs4IE7xkEbV WUJVW8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc7CjxVAaw2AF wI0_JF0_Jw1l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4 xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1D MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I 0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWU JVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x0JUXeO JUUUUU= X-CM-SenderInfo: xolx301qj6x2xfdvhtffof0/ Content-Type: text/plain; charset="utf-8" In pmu_sbi_start_ovf_ctrs_snapshot(), after for_each_set_bit() finishes iterating used_hw_ctrs[i], idx is left at BITS_PER_LONG. The subsequent sbi_ecall() uses idx * BITS_PER_LONG as counter_idx_base, passing an out-of-range value (4096 on 64-bit) to SBI_EXT_PMU_COUNTER_START. This causes the firmware to reject the call and overflowed counters are never restarted. Use the outer loop index 'i' instead of the exhausted iterator 'idx'. Fixes: a8625217a054 ("drivers/perf: riscv: Implement SBI PMU snapshot funct= ion") Signed-off-by: liutong Reviewed-by: Anup Patel --- drivers/perf/riscv_pmu_sbi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/perf/riscv_pmu_sbi.c b/drivers/perf/riscv_pmu_sbi.c index dfc886dee..099ba974a 100644 --- a/drivers/perf/riscv_pmu_sbi.c +++ b/drivers/perf/riscv_pmu_sbi.c @@ -1021,7 +1021,7 @@ static inline void pmu_sbi_start_ovf_ctrs_snapshot(st= ruct cpu_hw_events *cpu_hw_ sdata->ctr_values[idx] =3D cpu_hw_evt->snapshot_cval_shcopy[idx + i * BITS_PER_LONG]; /* Start all the counters in a single shot */ - sbi_ecall(SBI_EXT_PMU, SBI_EXT_PMU_COUNTER_START, idx * BITS_PER_LONG, + sbi_ecall(SBI_EXT_PMU, SBI_EXT_PMU_COUNTER_START, i * BITS_PER_LONG, cpu_hw_evt->used_hw_ctrs[i], flag, 0, 0, 0); } } --=20 2.34.1