From nobody Mon Sep 28 10:46:32 2026 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9654236D9FE for ; Sun, 23 Aug 2026 01:11:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787447514; cv=none; b=tag29GSzbVMvIVfH0/25A38L1QxO0dPgMcjrfEqIUzyH+swuizV3Ss2S2Blfqa3C/MIMOMzx5CCbAxju3x3Ia6AgS1wjOHr2ADr1K4sa44wlqii2GQwnGb1MSnNvuR5fJB5FX7bm9MYEnfmPAaj7/YudQ2x+yBN78qbV3TqaXmI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787447514; c=relaxed/simple; bh=iUuqAf0i9Av2yS+RuRVgLyRKLXwR5X29p2We1+dWVNY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JwPODfRX/a3vPPxHaoQsL/SsUYWwh5/5j86qOudAQo4M72/a3tY5mGrRmILHeIlkMDaAY/d+sEh/4/t+7BZx7GzSS9j8dUftIuOOKxs1LWeuSUoiOjBTvrpxVhcRYKSVOj9uXJfyPYq+KBm+0jPCozc0YFj6GvBXIAhywlN/MKE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UvZYQL0Q; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UvZYQL0Q" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-8485ef63b68so1712371b3a.1 for ; Sat, 22 Aug 2026 18:11:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787447504; x=1788052304; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=gJTfLnp0J7T2ypG1rf2UnD2iP61DjaHR8pWm0DBXUoM=; b=UvZYQL0QKzKYzyywaV+rPCwN7va7jg3xhJ1Vj78JAstYe7X9TZMwZL7K7PVWeUktlr Mn0u9X0PGe7CWMh53TFlO5mrpqTXv7XP+2fiWPCmtDYRMRlwee8jUaFC+uwU9qpaLUNv zpMLBpoaZfxTyAhIk+mOvXBXMD76NGTrWdsW+kgY8ZyD6Yp5dXg3jPT374rUP9uVsSYE NGaW0teU8qpw1qChaevaU4vFydzh9VZ0h9J2umBYsCOoATmkb/dHFpzOFsO0r7w8D41h IR5UXRIWuEDrSmNSSiW6C0iOw/VtCzPsIj6N+Fw75oyTy/GDDaBYSI11rLvciXDvcAGn D1dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787447504; x=1788052304; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=gJTfLnp0J7T2ypG1rf2UnD2iP61DjaHR8pWm0DBXUoM=; b=gwu0yWF848xrMXp2qdp1Kf6qcwzCz67cJbqBKQB2eiQtLp+qKQul69eIM7+/gmPsk6 Brnqx93jtiAPM5WOVcL1e340UkepSfFcYLv2ElHL768zHp2LNaT90ZgQE9CYvbcySEXN nhq8C2WwP9n8/DcV4z1QHVwZ0Xl4duA1ANm2MDT6AXzMzJvxdIS26KiroqsfyXJbk0pL HCyMDDKdcYfzm4nIyTzI//0btoS7aWUuBsafNf3X5ezCDYUT2riefyC9Q2UX4DoXD6ty 8fIqwvUjezxI+ITUVOR/JU3Plx8yder+VCPgpZ4FwCD3DvXhBxmBTTfcTfNDczWxWygM hrlw== X-Forwarded-Encrypted: i=1; AHgh+Rr4xW/ZjUy5uNa+OGpwLgZuaVB+ALoo2aiEp4YYZyEOe7Q8+X8YFco27yWz9Ybe5Og5bL2xGtlbFfnVjfc=@vger.kernel.org X-Gm-Message-State: AFuF++lncCMsBlN5ErJj4kZum+xNH61lMtOx4F4LDy9MCikSZ4F5p3h9 B9wYOAgeKcvShY1lstXJOdL1WqoY3dHcetDntNXytAYJpRMGgwfOh4I0 X-Gm-Gg: AR+sD11UCIR1jXh/87qX0cBm1USSVyZJjnynYgdDnDYtRcRSEtcFKJdquf3fi+IuLpF G1LUW//NM2oeWYcIuOTr11uB7o8zwif9J3lMjtHY4MeKntP4S85NpgZ/bNicMHlp6VvtFXs9SWP LkjN7g8Zc/CHlRqj9AIxrKQz51Eo/4POb9ZuSdYk/IcUk6zsBTRU2ZyIhNdhC4PJXwFjuTm3BVr xCZFh2JYE6iaUi0YVAiQpvO2idX38GKzHKfUVAI0+LiEs7uDYnjEAECjPkks2PrcgeeYMAA9uDd uXAoR/vmPBOZROOW797/yIZLDogH8f4WntFZqePh4eCVVNsVnF07AqA3r1lO8gsgSTeNSFvrupA tzhD1zKVWpxxryjoFem69c0e5LdxEc30LCkIB5JyprGQImpS7ESezzimkidQCqMFRUdq3eAnJe2 euq+sELoxOgLWAZsV/G1wKf3npm1fegXtqqAglKMipiMFQq8RtWEBtGy0iGiSp+Jf1UMjvh6rMx nT7jtBUzT+UaAVZ/N2sFlzPVVmJ81OeRqmEtZhKhs8/CqoSMkQb X-Received: by 2002:a17:90b:558b:b0:37f:fdc8:71b4 with SMTP id 98e67ed59e1d1-395c33371a9mr31055560a91.2.1787447504358; Sat, 22 Aug 2026 18:11:44 -0700 (PDT) Received: from hanzj-mi.. (ec2-99-79-140-187.ca-central-1.compute.amazonaws.com. [99.79.140.187]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-395e49b406bsm4272706a91.8.2026.08.22.18.11.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Aug 2026 18:11:44 -0700 (PDT) From: hanzhijian To: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Bjorn Helgaas Cc: Rob Herring , Frank Li , Sascha Hauer , kernel@pengutronix.de, Fabio Estevam , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, hanzhijian , sashiko-bot@kernel.org Subject: [PATCH] PCI: imx6: fix power domain leak on probe failure Date: Sun, 23 Aug 2026 09:11:25 +0800 Message-ID: <20260823011125.2876504-1-hanzhijian1991@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" imx_pcie_attach_pd() attaches the "pcie" and "pcie_phy" power domains and creates device links to them, but nothing detaches them when imx_pcie_probe() subsequently fails or defers. This leaks the power domains and device links on every probe failure or deferral. Save the device links and add imx_pcie_detach_pd() to release them, calling it from the probe error paths. Reported-by: sashiko-bot@kernel.org Link: https://lore.kernel.org/all/20260822013640.182C01F000E9@smtp.kernel.o= rg/ Signed-off-by: hanzhijian --- drivers/pci/controller/dwc/pci-imx6.c | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller= /dwc/pci-imx6.c index 39790e66b..4df548679 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -182,6 +182,9 @@ struct imx_pcie { struct device *pd_pcie; /* power domain for pcie phy */ struct device *pd_pcie_phy; + /* device links for the power domains */ + struct device_link *pd_link; + struct device_link *pd_phy_link; struct phy *phy; const struct imx_pcie_drvdata *drvdata; =20 @@ -662,6 +665,7 @@ static int imx_pcie_attach_pd(struct device *dev) dev_err(dev, "Failed to add device_link to pcie pd\n"); return -EINVAL; } + imx_pcie->pd_link =3D link; =20 imx_pcie->pd_pcie_phy =3D dev_pm_domain_attach_by_name(dev, "pcie_phy"); if (IS_ERR(imx_pcie->pd_pcie_phy)) @@ -675,10 +679,24 @@ static int imx_pcie_attach_pd(struct device *dev) dev_err(dev, "Failed to add device_link to pcie_phy pd\n"); return -EINVAL; } + imx_pcie->pd_phy_link =3D link; =20 return 0; } =20 +static void imx_pcie_detach_pd(struct imx_pcie *imx_pcie) +{ + if (imx_pcie->pd_link) + device_link_del(imx_pcie->pd_link); + if (imx_pcie->pd_pcie) + dev_pm_domain_detach(imx_pcie->pd_pcie, true); + + if (imx_pcie->pd_phy_link) + device_link_del(imx_pcie->pd_phy_link); + if (imx_pcie->pd_pcie_phy) + dev_pm_domain_detach(imx_pcie->pd_pcie_phy, true); +} + static int imx6q_pcie_enable_ref_clk(struct imx_pcie *imx_pcie, bool enabl= e) { if (enable) @@ -1956,8 +1974,10 @@ static int imx_pcie_probe(struct platform_device *pd= ev) return ret; =20 ret =3D pci_pwrctrl_create_devices(dev); - if (ret) + if (ret) { + imx_pcie_detach_pd(imx_pcie); return dev_err_probe(dev, ret, "failed to create pwrctrl devices\n"); + } =20 pci->use_parent_dt_ranges =3D true; if (imx_pcie->drvdata->mode =3D=3D DW_PCIE_EP_TYPE) { @@ -1999,6 +2019,7 @@ static int imx_pcie_probe(struct platform_device *pde= v) return 0; =20 err_pwrctrl_destroy: + imx_pcie_detach_pd(imx_pcie); if (ret !=3D -EPROBE_DEFER) pci_pwrctrl_destroy_devices(dev); return ret; --=20 2.43.0