From nobody Mon Sep 28 11:40:13 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69FF537FF53 for ; Sat, 22 Aug 2026 08:00:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787385622; cv=none; b=gaogSOhE6lacklfNAIleO8J7RmRiBy/lhCysLarYO94VzrfOSxxrhFWF122X1RkWQfFYfkfmtMJBVZOurgKOie502CRY434UcMJsMFSy0l/1najwI5YKv2DM7egcoADrI1hBoATGWW2gD9ttPcngehEmZGMhg9DtLqTJB32hT10= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787385622; c=relaxed/simple; bh=yAOiruEm9L8AjUBZGFt6yw9dAsrnsAkjYEMNNqDarWo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=e7iKLNq8n0Q80DGVfHdMgA2NfJ5GrHFHTy9J9TTswCCqW+nSFPH3Q2f+R7rCBoZO7LkSzQdu/i2tCF94+zzw0rKdqc3ly/EPaej6qcabl84DY0A4ELr/RWIHygs0RKvaJ3ZHudOZ9Vleu4qjMdLjxdH6VHlsicrTzqupDFP+qI8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oagJeHyV; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oagJeHyV" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-395ea741d07so134455a91.1 for ; Sat, 22 Aug 2026 01:00:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787385621; x=1787990421; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=vDG9YXYoRtMkAetCjmKzpnMDn+Xh8GlN8oNesgXLH1w=; b=oagJeHyVlwtClV7l2gpw8K0kF9mFeM0vIb0o/2l9raenmWa9RvIqYNjrt4XrGfpZFx MrOyb0TbA7pJREpdJ3cYl/ri5Wgl+3MlrYdR078YYiDnYjt3T4QZm7pkfAWVA+7xyoqX WnsCuCrCeODPRbXtadDlw44OtguiKjAJtE5BkimYdCHRNbHov52PM+5RaR4lqxEmsB0+ jqDHthH3lTQFRHdyP/I+eyqdu4QYYJB5DJDnIJbFx5QifmLE6fBK8gqIJlYLkDDBcIkC CWAmzh3AOUu26Kh8VYPbK2Iwp/R35alXDOhtNIWDWLsqWsxpISeEiuoao+HCgF9xqJV1 yl6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787385621; x=1787990421; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vDG9YXYoRtMkAetCjmKzpnMDn+Xh8GlN8oNesgXLH1w=; b=n2NwliiGMns1ygPG0vpULf9Hp3nCMcXDNc3ojldb4BRgY4T7WPOWblmdBIUWCMUud5 4WBUegNv08MUb08qfxhtpaEVO5eFSxyyySlSJJ5U3E8aeTfQqaSIO6Wkw9h0zjrK7J2E RkIFCsN15l+7iTm88K/BHfPuCIhIUHSDN4n/nO8m4X8ynV1V3RAiIE5xKMaiQv2cmZL9 xzkIzkuopMwpzC9FT2pV1wA3BelbeLtNTSM6w0p8YJC0JbYym7VTQnaZ2cGhTlZnN3hX xXVytWX3y1q39r5UX4216UYDwOo/QnjJDo6HgTC1tJ/G6CkD8V3KpRNUToW+CUD/GGOr NVVg== X-Gm-Message-State: AFuF++mug5EZ26s+vTtJDKoSKKaKNXtMiSEYZald2jOCgIyqaFIL4x+s Pj05tAaXAuTtSu0qAukKpSElnbZBdSJ3yXyTpGvhexmLiaG3VGVs6UmYMHDnzg== X-Gm-Gg: AR+sD11AWOLTJTjrfe7fyC2jBPpVxE9aqrY2vXxh1mew6h5AwgGLWlisvyZO/3T/js4 TDOu+PRMlmGoLPKylLEBr5KGAi/hXit6JsWR1UlIJpAAcaLTXap+tY/BVqC1x33gjqT/LdH3TC5 y0N68MiqIGZSq7mRJMsUB/hMx5TCM9IrOfSquXpVLmmg1RiL4N5kX2tRF4e2cEqhuirbeTJr1mm 4cAOzjghPmmy6wFsDmuQ58BaedUju3SPVNjlJfq7jDQF8CR/QUW8RX8X1S4Yw8T7GjNhQ7L8Huo 3JbopDqFQ1vj/5o1mdpzO04LFzlmmGDl+kdTnn000Fi++Xu23IKtGP6D2RJ4B1X9CddBmhQfvSM bDJo9X6rXickyPxsDNTI2OTjaFTSUBL4g7zvnZILxadNxViNpbyVcTLXbjISQuXvx7Y5J+m7COG wmZwCDrheFvtrrVbYfUvKW33NLTToX7DGlcVG+wK/MUWTYv6MARdaf9gLoXBbiH7ZiLpBIQyis5 YZ9SaMT0QTkh5Qi0ZVB/P4nsrUAknUlQB+XOYc5m7tA5AOgvEM3+dbJ4Bg0HxUvwD7WFZsvRxs0 2fj3PZyQcw8x2FM6VZKI0KPiWSq8si1F6UV9nJSc9qgdqCohf6DFcGOsiHv6eZOQSTAfgtqUIeh YX/ssBUaZ4l15rqESg7zjVQEv85ZuzhdYlMbT5344O0PZnQnW4qNFP2xC1IHsvJIO5N9pIQ== X-Received: by 2002:a17:90b:3bc6:b0:393:194d:5366 with SMTP id 98e67ed59e1d1-395c354da4fmr22617902a91.10.1787385620517; Sat, 22 Aug 2026 01:00:20 -0700 (PDT) Received: from localhost.localdomain ([101.251.7.10]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327f909c6c9sm4897116eec.6.2026.08.22.01.00.17 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 22 Aug 2026 01:00:19 -0700 (PDT) From: Laxman Acharya Padhya To: Ping-Ke Shih , linux-wireless@vger.kernel.org Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH] wifi: rtw89: cap firmware section_num before parsing Date: Sat, 22 Aug 2026 13:45:14 +0545 Message-ID: <20260822080014.29611-1-acharyalaxman8848@gmail.com> X-Mailer: git-send-email 2.51.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" rtw89_fw_bin_info.section_info has FWDL_SECTION_MAX_NUM (10) entries. The v0/v1 header parsers take section_num from an 8-bit firmware field (0..255) and write info->section_info[i] with no cap. rtw89_fw_download_suit() keeps that object on the stack, so a crafted firmware blob overflows the stack. Reject a truncated header and a section table that does not fit in the firmware image before reading fw_hdr->sections[i]. Cc: stable@vger.kernel.org Signed-off-by: Laxman Acharya Padhya Acked-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtw89/fw.c | 30 +++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/drivers/net/wireless/realtek/rtw89/fw.c b/drivers/net/wireless= /realtek/rtw89/fw.c index 0099c5c03e7a6..57d4252ee78f0 100644 --- a/drivers/net/wireless/realtek/rtw89/fw.c +++ b/drivers/net/wireless/realtek/rtw89/fw.c @@ -156,8 +156,23 @@ static int rtw89_fw_hdr_parser_v0(struct rtw89_dev *rt= wdev, const u8 *fw, u32 le if (!info) return -EINVAL; =20 + if (len < sizeof(*fw_hdr)) { + rtw89_err(rtwdev, "[ERR]fw header truncated\n"); + return -EINVAL; + } + info->section_num =3D le32_get_bits(fw_hdr->w6, FW_HDR_W6_SEC_NUM); + if (!info->section_num || info->section_num > FWDL_SECTION_MAX_NUM) { + rtw89_err(rtwdev, "[ERR]invalid fw section num %u\n", + info->section_num); + return -EINVAL; + } + base_hdr_len =3D struct_size(fw_hdr, sections, info->section_num); + if (base_hdr_len > len) { + rtw89_err(rtwdev, "[ERR]fw header truncated\n"); + return -EINVAL; + } info->dynamic_hdr_en =3D le32_get_bits(fw_hdr->w7, FW_HDR_W7_DYN_HDR); info->idmem_share_mode =3D le32_get_bits(fw_hdr->w7, FW_HDR_W7_IDMEM_SHAR= E_MODE); =20 @@ -455,9 +470,24 @@ static int rtw89_fw_hdr_parser_v1(struct rtw89_dev *rt= wdev, const u8 *fw, u32 le int ret; u32 i; =20 + if (len < sizeof(*fw_hdr)) { + rtw89_err(rtwdev, "[ERR]fw header truncated\n"); + return -EINVAL; + } + info->section_num =3D le32_get_bits(fw_hdr->w6, FW_HDR_V1_W6_SEC_NUM); + if (!info->section_num || info->section_num > FWDL_SECTION_MAX_NUM) { + rtw89_err(rtwdev, "[ERR]invalid fw section num %u\n", + info->section_num); + return -EINVAL; + } + info->dsp_checksum =3D le32_get_bits(fw_hdr->w6, FW_HDR_V1_W6_DSP_CHKSUM); base_hdr_len =3D struct_size(fw_hdr, sections, info->section_num); + if (base_hdr_len > len) { + rtw89_err(rtwdev, "[ERR]fw header truncated\n"); + return -EINVAL; + } info->dynamic_hdr_en =3D le32_get_bits(fw_hdr->w7, FW_HDR_V1_W7_DYN_HDR); info->idmem_share_mode =3D le32_get_bits(fw_hdr->w7, FW_HDR_V1_W7_IDMEM_S= HARE_MODE); =20 --=20 2.51.2