From nobody Mon Sep 28 11:39:59 2026 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CDDA2F3632 for ; Sat, 22 Aug 2026 01:22:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787361745; cv=none; b=RypJJevcix3tK3WDdRTj+zfif9gGPejcbN1pNz8V4+qSoqdwjMkoKAAA51YCs17OQTwd52nDHuNExCccvoDUaXsdsXInhz32L/QVGbNQG6+EgLP1XCZuT4yLEAoGvKiwfBCkq1uccPhO1I/P7jPGDx6m0L6L9TsUszNBk4DC3qg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787361745; c=relaxed/simple; bh=AURKOmGEjz8Y2p/odOo8yUCzmm57mPtXY6UFzZRhmi8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=O1LI8PCbuxBkUKZeeGendZm65aTO9ti8KAQ0LQblny3Yu+dVgCdJwJdPtv67QnbDOB4+Z9BLW+q3i2/3kbnFwg6hoOM4Y4xeTo8xmM551elddIty0h3lLTY43yaLuG5kkkA2vNtINDo6U/mVYvH0Rs20L8dbP8hdKBUWxqvPYgE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=c2Pp7kQp; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c2Pp7kQp" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-ca00f126b7eso1201637a12.2 for ; Fri, 21 Aug 2026 18:22:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787361743; x=1787966543; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=XNcfeMEYwNlJBKitvYBP+hWuT3fX1KTsmGqaiTl4+vY=; b=c2Pp7kQpeU+yRfCKZ9BQxfyBW9Jifr4+YY6UOrw/eSN6QnRqoW3E3k2G73PfjgWNQa RxFO9BuGSnpcqeaWwd7Rl2N+7qMxyubILqVUVQtMNmdvRhgAcVqHvucxOZGVEJCoSCox XpOdIeCvwtJq6lqjyoW4QoeixWlVOeYSwDiEvEdpYdp8cDFTwk7Ek79Puvj5iWVMaAT2 IZ5ph8FJmW/WARDJ470H0ItiUqOf0E0mtj5kn3/D5G1AHidk/pe17Id5kKLvTLtO9Wjr XS1vJpZnNLAO44g+jD3ki53+0woB7h0u4kTs1160paVGtEALSOsx6hgWqCHslnDnCqhj EQig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787361743; x=1787966543; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XNcfeMEYwNlJBKitvYBP+hWuT3fX1KTsmGqaiTl4+vY=; b=NqL93hnQKs4tdVaUWADyppoTkpW0mNGsVr3RKnVSiZZOWFElU9fax0PBQTmC1pB6jg PIKfnxpvBQ+5sB9Jzf7fxboIWzVtsdlUxnp+Of56UF/7VOoHRATqeTf0OF4zmcjtnrUf D3UpRjv0MxFXuAIGZrykE+NbYGZzWxVQo6QUvsOHfzO9OEZRL888b46QjdoCE0zT9jpb vgVpV8gqyJX/wnqfmoXjD65m1Ou9GfPp3k6zj8qpO2pKVfuins5h33NI6c7tL+64aBDt ySSP5kfJERjwqMbjnnAhHkRcmdUcXG2JPhYztleCt7K9rKpbaiBRhp5GLs7Vl6Uwf2R5 llBQ== X-Forwarded-Encrypted: i=1; AHgh+Rp1ICELO6leNYZhR4r+gTyn/Sgy2dPf3Oo3edxMGrtGyeZnQYA5sKeIC1QQcroqOxXCYM73Gif+gQtJ3QU=@vger.kernel.org X-Gm-Message-State: AFuF++lOXo5jxnIZwKzxeXMgj+zqxDvMsDCTv3BXQgKh4hLhD88lOL2R /G3WlsfhnU6wDgJjpmCgS+EUSCd32KuqThWh5ANa6MJBSlCkez5ZDznY X-Gm-Gg: AR+sD13EK8nosUphWimXVhDeYuXFeP8WCR9AonvI4Ndq9PKkwbyRu60VXfPs4ADtKAN gOxuZYxGtY8+d6g7kNYnK2Q2taaIALJGtgplVktCMV3WTjojt9jf7livM6+GEiXqFv9GWnIlIxn kwlo2KWMIXiInKJk+x4JloRZ0ziPHhoaBMatZBh89YRiu4GOQLfHfPTaRaEKBrrrXQjhq5GyE3r gsW9NJpVdA6YiNwfmzwqyTDUa6TOYqDk5TtrDmOxDuXYKzdRf2KXWm0UadLo6YDW/fPFtSFNc8v X+JlV1NdQct5ZIJHXEZFiwot5UNgGdoxp2msR2TjOI5R9AmMVxpNW/n43MI8Tru5ztoox6Jk/YM tN/mc7Up/TcrYxQlINt+cg6zVezuCEi3isNo0Ez8g7nHVXecRLSfxHqLh3eKstk9QVLTjyHiih0 uj63jooxZo6/wB+ZKYR1YoIaIVIGNoj/3SlOobphEoBh8tV3oGwZWF+McqfvBeQco0EqymqlCGf IycZUST0xKLGw0wllTlroEle8nF3a0xzhUnlf1+jke31CgxXpVFi8F5iPWp3yg= X-Received: by 2002:a05:6a00:1407:b0:851:8394:1696 with SMTP id d2e1a72fcca58-8520ba16a9bmr3668474b3a.12.1787361743351; Fri, 21 Aug 2026 18:22:23 -0700 (PDT) Received: from hanzj-mi.. (ec2-99-79-140-187.ca-central-1.compute.amazonaws.com. [99.79.140.187]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8520f03b243sm144370b3a.31.2026.08.21.18.22.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 18:22:23 -0700 (PDT) From: hanzhijian To: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Bjorn Helgaas Cc: Rob Herring , Frank Li , Sascha Hauer , kernel@pengutronix.de, Fabio Estevam , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, hanzhijian Subject: [PATCH] PCI: imx6: fix pwrctrl device leak on PM runtime setup failure Date: Sat, 22 Aug 2026 09:22:05 +0800 Message-ID: <20260822012205.2459806-1-hanzhijian1991@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In imx_pcie_probe(), after pci_pwrctrl_create_devices() creates the pwrctrl devices, the error paths for imx_add_pcie_ep() and dw_pcie_host_init() both jump to err_pwrctrl_destroy to tear them down. However, the error path for devm_pm_runtime_set_active_enabled() returns directly, leaking the pwrctrl devices. Jump to err_pwrctrl_destroy instead so the pwrctrl devices are cleaned up on this error path too. Signed-off-by: hanzhijian --- drivers/pci/controller/dwc/pci-imx6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller= /dwc/pci-imx6.c index 39790e66b..616c42932 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -1975,7 +1975,7 @@ static int imx_pcie_probe(struct platform_device *pde= v) pm_runtime_no_callbacks(dev); ret =3D devm_pm_runtime_set_active_enabled(dev); if (ret < 0) - return ret; + goto err_pwrctrl_destroy; } =20 if (imx_check_flag(imx_pcie, IMX_PCIE_FLAG_SKIP_L23_READY)) --=20 2.43.0