From nobody Mon Sep 28 11:39:33 2026 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9A293D1AA6 for ; Sat, 22 Aug 2026 15:08:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787411289; cv=none; b=jJ3NuAVXuRRndEU8BleOhj8tu96GwoCJj/D6USDswkCaA/mgCnRlyx4Zmq52n3QfgHR3XvvmCqsQy0raOY7zHCIOfthujAt5pY9tUqJQGxUwCaUpV2iw6taByWsvUpqf5yaUyRYdD+GIVR7zXYIfx+ThegG0utUBlCGtkxrN3A0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787411289; c=relaxed/simple; bh=iqwaq39/Zpa0iH6/a6W3yQV4x79xW81LRfZe/TmtbhQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VcIK/GY2P98faYrKHwFQkjJiV55kMJcKnbKd/xR6pq8FZcC3zEgkwexcaq5RUnBJglJExYBy4wbN1SPG53oyUiRfmARqxT6JTAYOR+xMK8bwF97Ver71ivxTyFzYdp+nP3U0Fen4M4wsx23QPsWR9UrTa9hxqD7CJCHWU4LcIeI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QJPwKErX; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QJPwKErX" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-ca00f126b7eso1467847a12.2 for ; Sat, 22 Aug 2026 08:08:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787411288; x=1788016088; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3WRamQXpDUK+MxHYzTl3WtRIEBUdJqjnF0kXvecvEq4=; b=QJPwKErXINwroUyaBXwl7z+C7w4M53TYAvgwn2DaJp6gIJWHI+iU5A9PKm+/N1kX3q rdtAzEUb4LUd82+2yup3iqXdDsInAuS9e+d9EP5v+Imefb5Zy8ODllPyenWkmCDIgkh7 4l8bSDwl/aziD+YFS8Zlb7oOMuPHniVFexo1XFsNP3iPhW/AJbdnRRppRKi7m+DVxD7h d7v7XMhR/W4fMQ3/gj3BFC89+eU6WM4TayhOPnh3WIA+VKqfj7WGJLTBxd+qDYEEzFHH xeGenPtNVEE7g3iXPu88tblzUdBMBzru4YYj+0xyHqaUiZZqzxc9uqdFZQbfrxuXH/py 5QWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787411288; x=1788016088; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=3WRamQXpDUK+MxHYzTl3WtRIEBUdJqjnF0kXvecvEq4=; b=sZEMQo4LJu77enAaMpg8JrFA9kg54V6/20PZbg2CzdSj3ACP+ALjLGqelwujQrCpHR hvSEL7lvgQLu/3Nx2CwtxBh11XYivrYU6ADmCRyaMZau+Y4Y80Yu5KHlX1ay5foOVgbY /hEZlWhZzZXhMiQIKu0nYNSD6wGQv8hedVl/ifbcD82IsTJU4p8U3RUEc913KWHivIH5 tz/BlfzeuqUz04qD2h99wN3XJyMK3vzvNYzViQR6V650OsGguyP5hpAwlK5x5FkJE2G4 68EGKD/x7Ur5hL2WJZ83Dc0zYmVkOj4OWY4c+vs+iqeGQ5/REN+ZBVapYlcjPxnnCLMc degA== X-Forwarded-Encrypted: i=1; AHgh+RqJvzvShpYykiItN4hBEqomj6UyrKhMIix/U2DNYPDOiu/PiHpVqsR8yJaW70Xx8XemTXF1HxJR2uqJTRI=@vger.kernel.org X-Gm-Message-State: AFuF++kBD/MfeOK+UQ3BRKPtj7U1S+YGMYVxS5W/Q7zbdWRwDtm8Yrdx jK14jVLTsS6g5Q9oms4E2sJJWWCLcvJ7Q7c0Q+X3SVPbuXNCYPYYCKCPjzkuvZYJHiA= X-Gm-Gg: AR+sD13j9x0/CdnprdVk8jVDOFDPaEtsoTiuLsfEqnd45X8KfobvHAZNPk9ihIsGANZ GThqSvp2rPSj3Gjnukk6J2fsbdgiYmRlQ6mHZdtw6Ea4T1U6C2BF5DnueLMGce/9BZrqMp/O9tv hgIVVePKc7I0d/XnYgnBobIMN97NaCfe0J0thsIA/Hd3JNRClv1XMY3YNevQnSLLGA6jdrN6Pik VnKdiK2KEP9vaP0UXxtobT0qmdWyqWsS/coa5RZl+NsoEnaDn/D8oTPXOH9Ezpdr1tFoS2Y7Sen /uhdUlehmgczvsqbuU/kwxAHQ9VaLFa6fwUtDbH16w5HLs+PoS6kQu0IHPt5dSixon/TfLkbMiK Ambkm55jP8IMi6U/Uns4760aE8a7VMyj6axh7/Bm0sW+/qPirH0Ko2SrcwFuLCFjQs3wYrVlaCA WbGLWFOItFke9EggeEcbrj7FDSqHtHaok0mv5Iy/CFI/Jpk2T49CrDTswI828XX7IFx87yhe5Wf C014K+OGKoTQ2JCSNQnLRhuIbjX/jCFlEZrxGH6BebUTqAdYxssHMGz96yS4g== X-Received: by 2002:aa7:88c4:0:b0:82f:2b0:2809 with SMTP id d2e1a72fcca58-8520b942d1fmr10233534b3a.1.1787411287768; Sat, 22 Aug 2026 08:08:07 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.166.246.74]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8520f03b1ebsm628242b3a.30.2026.08.22.08.08.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Aug 2026 08:08:07 -0700 (PDT) From: Felix Gu Date: Sat, 22 Aug 2026 23:07:47 +0800 Subject: [PATCH 1/3] PCI: dra7xx: Fix clock enable leak on probe failure Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260822-dra7xx-v1-1-23e204d5548b@gmail.com> References: <20260822-dra7xx-v1-0-23e204d5548b@gmail.com> In-Reply-To: <20260822-dra7xx-v1-0-23e204d5548b@gmail.com> To: Vignesh Raghavendra , Siddharth Vadapalli , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Kishon Vijay Abraham I , Luca Ceresoli , Sekhar Nori Cc: linux-omap@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1787411275; l=1209; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=iqwaq39/Zpa0iH6/a6W3yQV4x79xW81LRfZe/TmtbhQ=; b=JQwJxBp9JSiXLkuvgP9DsAqIhnNVN95oebkqBf5QP+o8m9TooJuuD3/GmQ47Qgmh0RJ1HbYN/ XhZFZF9+3GCASDzQMKX+JxGYZMzSbVHilzqclpMzDdh1CfPZODqjapy X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= dra7xx_pcie_probe() enables the optional clock but never disables it when probing fails afterwards. Switch to devm_clk_get_optional_enabled(), which disables the clock automatically on failure. Fixes: 5af9405397bf ("PCI: dra7xx: Get an optional clock") Signed-off-by: Felix Gu Reviewed-by: Luca Ceresoli --- drivers/pci/controller/dwc/pci-dra7xx.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controll= er/dwc/pci-dra7xx.c index 6ae5b27e27b3..d43253f7dea6 100644 --- a/drivers/pci/controller/dwc/pci-dra7xx.c +++ b/drivers/pci/controller/dwc/pci-dra7xx.c @@ -732,15 +732,11 @@ static int dra7xx_pcie_probe(struct platform_device *= pdev) if (!link) return -ENOMEM; =20 - dra7xx->clk =3D devm_clk_get_optional(dev, NULL); + dra7xx->clk =3D devm_clk_get_optional_enabled(dev, NULL); if (IS_ERR(dra7xx->clk)) return dev_err_probe(dev, PTR_ERR(dra7xx->clk), "clock request failed"); =20 - ret =3D clk_prepare_enable(dra7xx->clk); - if (ret) - return ret; - for (i =3D 0; i < phy_count; i++) { snprintf(name, sizeof(name), "pcie-phy%d", i); phy[i] =3D devm_phy_get(dev, name); --=20 2.43.0 From nobody Mon Sep 28 11:39:33 2026 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FD9C25B0AB for ; Sat, 22 Aug 2026 15:08:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787411295; cv=none; b=bBTgSPTiu7ky12m5Jh3V0oI0HbBmIMQ4FTZ5caFILamDC61KV8d8W19byUX9sJZMwaYbVGjg9VcOznMW1ya7UTvX11MB8vz/bB+xLIeVudvLzqqTBYDB0aNtKR7kYOcGwZ81SgaMLaLmqqa9qTYK11crF9XMpe0GtxfWRnVkT5A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787411295; c=relaxed/simple; bh=B23Kydln9+sFNwl/EddPsXeSNGxgpJc+Bv5D8Nfp/CM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bnybP+/62KPsz12rOpr0dZrKANwyCjCEk58hjBkdnJuc9afvVDAFPP/sQgAiuTFfloGHz7UCHVHBr3Ko2Kfxx0fUgfV7bTpTvErrbD5+oHcZSHM50fdRsStr3sRxNTnXL8zz5o6mtyzTAVnAlX6oscTT/bhvfRMK7nXCShVF8Kw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sfroaLax; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sfroaLax" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-8518d5ddaabso1477325b3a.2 for ; Sat, 22 Aug 2026 08:08:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787411294; x=1788016094; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7/zhBj9KsrWu1iz3uRFGRfIc5hKkqLHf63XbozGChRc=; b=sfroaLaxYUfoSaeQ/atwN8JuYjCSALC9mC5xCx6sF+524JQ7rfY5vLRJDlHMq/Y5db 6vDRF4NerW6nLO7WcoHY/my1AOcIp+pnKy/6UecV9c6B/EpgueiRgyhbSezXELfiAaJ9 iHIit0wlX+NMT+piVs9CFbsQMkuTA4WsLsM/pMt5kjMt6I10jinjL56ULG17iRWDWuB1 CuF7KIeeG4hHly9Meo9sPFaWBiO+Nt/rTZrh14MjCeQcRGIVecmyEZCEqL2ncsAJ/o+/ WRg6d0LMZodoG6FMUJXjdHfEpyvM2RbuHzZN/7y5NOblMd5DASfK8aZVot7M5nK+1K3Y G6pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787411294; x=1788016094; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7/zhBj9KsrWu1iz3uRFGRfIc5hKkqLHf63XbozGChRc=; b=jubEH0axf6oRD247ma9mrXPgOoOTBVETCxWlwahbIbS3n6gyTLSVWeaidaWsacujdt Wr9DX/HRRtYVuQyXNUwjSexI9F9qKeFTN1gfbSSwmziHHIKaMpA9Oqc4MThmq9zgKicZ YcgJwLeeMRd/TyqKuKfOKRj+JvcuLcfmL97prJlxxCPb0uY6bR02mejTSsrqffXKCOyR cOcP6PsbJtAD4AvvOQ4ZZWqrGNVPV/emghZeQGOLJdY0egLs7EvoamnN+lqj5crqGEig zCTrFjr6uUof09RfIYxJ7WnxWD35YUYfVrIfOVtJaDZt0HmYE1u2ac/I9nu1gdJKUVHZ 8Vmw== X-Forwarded-Encrypted: i=1; AHgh+RpSbb7UCzfpMMY7cTnmiX7qMdnng4sx+IT0OAcyaIkW6vGRnyFFFq3ltkB0QBCGnWHl07jZt3TSbzYI3ug=@vger.kernel.org X-Gm-Message-State: AFuF++nNOtn4vV5G28JxsibnAmvBU35OwIRsHAu2QDCc2G1OHk+s5w9y yN+tUhhQDjvXoG23l7bOZu5jD7JZdqaPiLofNnKbwMsTIIFyb8UiyU+g X-Gm-Gg: AR+sD11CivkZFFLRT3ST2VgxmjeQoKPozgFyLiGdNnAU29ZpWJh1l5EVvMKLHUk7TSN DPx9XtdczaOmfkPHUxVUOWyHJ9s/v+buV//Pj5AFIc6BLyrAnrVMTri6XmGZAHLUVlZPsjmZH5/ bWwJE7fx05N6vr/5fwgXHSZuGayDHdNuRsaTEahw2XQXHO5dt0XiLwA4Y86suRyeI3uhy7s+2OR Kmtav/4ad5Hh1cm+fsOPIPVZdZz5BN8zHnrvnRGquNtXez88ijL9Uy5yBVVf0XgTmLPrYlO6lW7 J5ymDbfTxVtzxpb5xTHemMwyYDYq6niTj2NuR/DgGhj59nQX/KkBMegLkFBLAXPmZMyX2lyx1mW VDrQoOC7FGDGHMWWgi7I2LaPcFodGXJsGOMH2dn/DTdsD8x3sxaRh3DV1bC9AX1xxFCe9jCQagR tbuMq3xbsYrkLQmcLi07gYtS5dGCPaXutDSPZ8ESjxNHqu62iHGAZ7fyiHrfhFghJgTKOOGNW4W FovZchunZJfElnRhaG7lDZx2J5SvclJN8iFl8wPJpk5nmOA5DEtO46t X-Received: by 2002:a05:6a00:14d4:b0:84a:2fff:cef9 with SMTP id d2e1a72fcca58-851f9f84b8emr18586843b3a.13.1787411293482; Sat, 22 Aug 2026 08:08:13 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.166.246.74]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8520f03b1ebsm628242b3a.30.2026.08.22.08.08.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Aug 2026 08:08:13 -0700 (PDT) From: Felix Gu Date: Sat, 22 Aug 2026 23:07:48 +0800 Subject: [PATCH 2/3] PCI: dra7xx: Fix device link leak when devm_phy_get() fails Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260822-dra7xx-v1-2-23e204d5548b@gmail.com> References: <20260822-dra7xx-v1-0-23e204d5548b@gmail.com> In-Reply-To: <20260822-dra7xx-v1-0-23e204d5548b@gmail.com> To: Vignesh Raghavendra , Siddharth Vadapalli , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Kishon Vijay Abraham I , Luca Ceresoli , Sekhar Nori Cc: linux-omap@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1787411275; l=1121; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=B23Kydln9+sFNwl/EddPsXeSNGxgpJc+Bv5D8Nfp/CM=; b=TX1ESX7RK6u/H0zkVg6E0SCFWHpFzbnS5YCn4VL1Y4bMfduClDLmt6rcMJoaUKwAyiOBXMhmO cENEnoJzPM9DLryFJyE8Xfafq84ILfLThjpcV/5SGBtHXPuUruKAjOu X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= When devm_phy_get() fails, the code returned immediately and left the already created device links behind. Jump to the existing err_link cleanup instead so those links are deleted on failure. Fixes: 7a4db656a635 ("PCI: dra7xx: Create functional dependency between PCI= e and PHY") Signed-off-by: Felix Gu Reviewed-by: Luca Ceresoli --- drivers/pci/controller/dwc/pci-dra7xx.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controll= er/dwc/pci-dra7xx.c index d43253f7dea6..bf32b14436f9 100644 --- a/drivers/pci/controller/dwc/pci-dra7xx.c +++ b/drivers/pci/controller/dwc/pci-dra7xx.c @@ -740,8 +740,10 @@ static int dra7xx_pcie_probe(struct platform_device *p= dev) for (i =3D 0; i < phy_count; i++) { snprintf(name, sizeof(name), "pcie-phy%d", i); phy[i] =3D devm_phy_get(dev, name); - if (IS_ERR(phy[i])) - return PTR_ERR(phy[i]); + if (IS_ERR(phy[i])) { + ret =3D PTR_ERR(phy[i]); + goto err_link; + } =20 link[i] =3D device_link_add(dev, &phy[i]->dev, DL_FLAG_STATELESS); if (!link[i]) { --=20 2.43.0 From nobody Mon Sep 28 11:39:33 2026 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E3B33DFC6D for ; Sat, 22 Aug 2026 15:08:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787411301; cv=none; b=hX5ga8VSBjb4svXLX/x0oK9ujdK5peWQ/JYMpGxcoVOM0g4plYbG2Of26ilFoSpxkPu/NvXxX8mxqihXcGOQc2YwDGJvpc7ShK4DnEc+12sXH56LeUvqBxl2N7tIGKB/SIzJoG2QHtTm+igmYcctvtEGG3cLbxB1Y8aCCh8QKkg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787411301; c=relaxed/simple; bh=MgRL359uSGGq2G+dbIIbcTFNFWELMsvNpKc3wpRExyk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tXEVxK3Ltb/y7kpDlgCrl3Oz5vSMHIIqQVJNWBtb4xHFieMZrNcsicY/Tv/sfhfgssitgE6ZeaBwohOq/xow+NMGIGWienPljg6ifaCmxIxEe9mGtEdrFGqrhYPXfSFE4GPsl6LGt5GcwInIiuVQYqji155ptE1Ik9Vzd98F5x4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cD9A96Ud; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cD9A96Ud" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-8486672f03cso2077035b3a.0 for ; Sat, 22 Aug 2026 08:08:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787411299; x=1788016099; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=l+Gfsbw2LT91VcPxORecg8qTC2JGjipjq7k/HN1uFUI=; b=cD9A96Udp16/qOdlAflpdBDBlO6daKFiLH+nqRLFwVvstYigVbd5pALihbldHjSYE6 VPGTFVFbhJMR3tSZbZkZgtin6GLADjXXGTDcnm3ryiUHhZ+Sy1EzpbbZxVzj4OvCeIp6 yRiYqZz+A6IXvzbTD4F4nfaJlVXC0wVnynlpUklFhW/NEH4KeGGK4+vSBFnQC6Mv69c9 BrmPj/fiMvpvlV6+eyuwFE0LcadC1b1CXpyd0sr2sYZRqbelJK4OEx1jc4aNn5Q6f6RB V0Z8wzHRkknueXL0WK0C5EuGzA07DmVr06wpvMoNdm2plok7B+K/LEhqapehfN5IhlvE MRKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787411299; x=1788016099; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=l+Gfsbw2LT91VcPxORecg8qTC2JGjipjq7k/HN1uFUI=; b=mcwR2cN93ceml4oX+vgvP4QIohgLHFmGPsVMM/DstCkHgPgGsrHWGhik+vdXc5pX4L ojnZ4oaREcQkGqBlTBK5RNi9T2RYdARM7D+4vRoKaaTqEpSLXSmBcfib5xjOOCiDwwc+ iyt5cR5tJEQgi3OCnVhFsVrCwC+T6qBobjV10gPvNqiSrNFzXkKG41oIUVYC5KW31kEf wSJT4fWZmKRbOWKvr6z4lqgUWvgsFP28x/9bcyoUBTxNFrP+1+KI+XAZUQr1nvE73Xeu 1YtZAKOihi5kA+r6I37Qbh8hpzP0xzCkKI/aXN5imx36J502hNQkqfcyr+81wFmi2od/ ChDQ== X-Forwarded-Encrypted: i=1; AHgh+RqF5h4bsRREgBnisBihtrcK9Vu1kDVFLwqppimmf9PJ6xTWVE+/KmgqFdzvsyS+vRH3KA6cPRHlRtRFcak=@vger.kernel.org X-Gm-Message-State: AFuF++l0kDk1tE0nP3mXi3g63PonBstQm36VW2Qx/PnO+3OYeyXDwmf4 k5+fbdJ1c7a2DaE922DnJl2np3WjNtblf1Go5iXOBVPFC+zjV7p4fHek X-Gm-Gg: AR+sD11lAV+ptBoPefWao+nral8tDkDyyp12AQJOTObJ8PeiW7kHyQhdfX3ACVbHWi8 22TA5NywZSv9u9b8JhkCZDRpvEUqDRwinr721fOsXLvCI3AXGWTY5HFfLj4z+N2WIB4ja+PPQKP N/Pd/8lrD6aXbvD4bsOBqKLVqnrtj+JadLX2YxWEMagA5WmdtWwADVZLCdrsNCC46LisVHnIu0Z KeFMDwEubpygfYwfxopfAij0/nzeA1R4NCXYe2A2yJge/6lpwbtP7/59KiSIFc85waSkNJhc8fy c+j8DFQ4U7WiyfBV3xLKWekOMNLeg8bDckbDVd4hOdmZz/ujsNlvEqO9gMF8s6xM1quqXRNPafR 8a+wnpgdto9RP4WLrRfwmulHLSy1vayhuYVnxnSF43Hxk9FM51xFGF++lkxjRVAIfp1c7CL2tIj k2oZ86N+MSe7uUWTr9nlTkidewYfmUNGJDFwggYrWYRglF3qi+pwlbSV6Ta5I28XXG3VAeXIYFu yOz67QhP4CHnmeyknGjr9kTL2iDmSl/LFRmjuystuoM7ltmlS6rSjQi X-Received: by 2002:a05:6a00:1808:b0:84f:a170:4f5b with SMTP id d2e1a72fcca58-8520b984b8dmr9996781b3a.8.1787411299270; Sat, 22 Aug 2026 08:08:19 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.166.246.74]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8520f03b1ebsm628242b3a.30.2026.08.22.08.08.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Aug 2026 08:08:19 -0700 (PDT) From: Felix Gu Date: Sat, 22 Aug 2026 23:07:49 +0800 Subject: [PATCH 3/3] PCI: dra7xx: Fix device links leak when dra7xx_pcie_enable_phy() fails Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260822-dra7xx-v1-3-23e204d5548b@gmail.com> References: <20260822-dra7xx-v1-0-23e204d5548b@gmail.com> In-Reply-To: <20260822-dra7xx-v1-0-23e204d5548b@gmail.com> To: Vignesh Raghavendra , Siddharth Vadapalli , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Kishon Vijay Abraham I , Luca Ceresoli , Sekhar Nori Cc: linux-omap@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1787411275; l=954; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=MgRL359uSGGq2G+dbIIbcTFNFWELMsvNpKc3wpRExyk=; b=/wH7RY13/PmdaWC+y3rHEMhSz5gPR2a9yx18qu5QxBfXm8zCfDM7l7ShTSaTY6YWygwzHEBur iqgTLyLhnIBBzsUZogCfpqSjebU/34Pm6axVzTGhU5eDzfBT/Je8Qm5 X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= When dra7xx_pcie_enable_phy() fails, the code returned immediately and left the already created device links behind. Jump to the existing err_link cleanup instead so those links are deleted on failure. Fixes: 7a4db656a635 ("PCI: dra7xx: Create functional dependency between PCI= e and PHY") Signed-off-by: Felix Gu Reviewed-by: Luca Ceresoli --- drivers/pci/controller/dwc/pci-dra7xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controll= er/dwc/pci-dra7xx.c index bf32b14436f9..5bd9d1df80ad 100644 --- a/drivers/pci/controller/dwc/pci-dra7xx.c +++ b/drivers/pci/controller/dwc/pci-dra7xx.c @@ -766,7 +766,7 @@ static int dra7xx_pcie_probe(struct platform_device *pd= ev) ret =3D dra7xx_pcie_enable_phy(dra7xx); if (ret) { dev_err(dev, "failed to enable phy\n"); - return ret; + goto err_link; } =20 platform_set_drvdata(pdev, dra7xx); --=20 2.43.0