From nobody Mon Sep 28 12:34:52 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DEEB3358B0 for ; Fri, 21 Aug 2026 21:10:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346655; cv=none; b=GPOev0dZZH2qZ0hB/864dUvp0eYxGQpRX/sUvlhQfY++nWNiN/wfLP+89lTLF9uozxh83bVAJbeEDOObrwKhlzdBeMB7h/ZRzgjv2rsSQDBpz7a4F++eg0pyr0Qw5j0S9DK95MFQKj4YW2mowGFLqHqOAObc5QIAq8xHoqj8VlA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346655; c=relaxed/simple; bh=yCAVOIE++bw4Ie0FV54LDXmsp6naqMKl9wiNs7eJ4Dc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=e+ggl45EvNOFkMRf2/oYAthqpwakRY6Zje5a53eeneJas+Via1vuml/B7V3W+T9WwRb9gR5rndBukF90s/yz7iapkPmqk2bSIABxtKN85x0JaZsfyX7s+hVwNudyYkcBtgfy8T1nnwQcUTi3uEMi8J8qp86pcl0jrq6OQVG4HAE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GJFZtTAD; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GJFZtTAD" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2cfbbdfa60bso12216885ad.3 for ; Fri, 21 Aug 2026 14:10:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787346653; x=1787951453; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LnRzPupI/2uu/oLvh9jVLVDDJ3EE4OAdAA4PYQ0nS8U=; b=GJFZtTADDVfDzAC7QXPleU/IrdeHoefBg/xEZ7As8zCsT/xnwj5Hzni81lRVHgbqpy grRmJAExEz9bt2WjBQluC0olHNo7bzQ0gdRf6IicSkQNkyyhZX3kN9wSpZhpPPooHsUr 2sw5eBgS2dDfDz9JMOJxnAxS1mkY1djabtgQjLULMVozQmDXIPTjkvWVAnymICX/zBm6 iavZ2SHhf9qILre4Fc7LFfl6Gx3vCP87WSVPwKBinA7I2BJT7Gog/3tUKVjTPabGpLqy MZ2qWxemeseljwwchzBshWdHR8JB3ksEi7toqf2KlNO6XMCi295tc9I9UbT5P5iG7w87 0Trg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787346653; x=1787951453; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=LnRzPupI/2uu/oLvh9jVLVDDJ3EE4OAdAA4PYQ0nS8U=; b=hDwl7LTWy/GWZFb6t8P7/0CNBPoYXky8Sx+MxdyKSqS7BNFC7DJrkZRSqRLvbX9oia fQ0NkU8z8xeUupdZi4c9IkUEwWdzRryzvvvZkHR97xzkrtUSE2ZnqNYL5KBDu7uPQUmv jd/tv8vfMzQO4Na91Z38H67DXWfCWyaBHeSnPmJaFoJtE6j9sx9SoZOXky4nIIxsave3 Uomj7Ug+U0myL9YWx9HD0QpDCr8nOyLjei5upVDErn784S9p4NsRSU8J3SDwcttm2ncA wxtm1ksiuY8pLKYDNIiqIEV20iJ/jmGiSWhuI8zd7zBubblTVPvAmnyOQ5HZ21UDJI6U L9Pg== X-Forwarded-Encrypted: i=1; AHgh+RrrKT9X95wTy1LOGed70/OwGhZR/Zy/2OmpP9hKW1yLxCFDRg5+8zRitu663SH+Or6r2cZgAXHsP6uepVY=@vger.kernel.org X-Gm-Message-State: AFuF++m/J1V1LwYN6gfYVrF7KM5qcCzc6zUbp6KMMLSvxIsMZO4zUNg4 MmNjPLkfdbB7+0uhjJUMEb1i3gXkkfMonviN5Axrt16D8RpzbKK1i5N9 X-Gm-Gg: AR+sD13FDMR/p5TUBrboeFixzO1Ruq45lezKMcxR4Jrg1QdM2vrcp5I2AhMyX9SCkKg Wzw4tkyt/Lue6FgOBd1rEAW75eo9fstmbaJwlmLVTzL3v8u6wp959C3Ceis0XHW+QhwnSrx3SAh jjB6GMDDGFjpNIli+l7ZduY82idahZBAx7VDkNaq8toI8Y/r9yRnK6iA/ywM0hpmebVVx36WbfJ rK0tFMR6iRF0BEFH3MhfE1bCTmAdEn4VNotqacVzcbjDOJsPr+KBhSxwlCr7Z4XISYT++ApE8Kr QixHHLUBYbA34i8kmhD0A0awFseVnmiKy/lM6zeWjaQgy7oT4yQLIWk0NhhJY/KXn/iMAMq/+Nq s9TdLYQAEmYXlKOs3qXQMylS8krmMXlr4Qvz+4DAR4kfTaaTGTupnAfE+ta7JxMMCTfEX0DwCij JzHGG2Asj9Q44jdf8y3of2QT9yJbWBSXzIstGb1Ex7yeGn/lmcc7JIx4tKhkYPCnNfBoJv1auPh Q06E7N2feow5Jf4UdiWuuK3T3tTg/OefC9SZF924AZ5y5aTHP68pXxHewRk1nxVpiZOGgCS X-Received: by 2002:a17:903:b4b:b0:2c9:e846:a57e with SMTP id d9443c01a7336-2d64a9a1b03mr185088355ad.0.1787346653386; Fri, 21 Aug 2026 14:10:53 -0700 (PDT) Received: from iku.. ([2401:4900:1c07:194c:dba4:ea1e:d7d1:affe]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bf175399sm49755257eec.26.2026.08.21.14.10.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 14:10:52 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar , Conor Dooley Subject: [PATCH v6 01/17] dt-bindings: rtc: renesas,rzn1-rtc: Add RZ/T2H and RZ/N2H support Date: Fri, 21 Aug 2026 22:10:16 +0100 Message-ID: <20260821211032.13554-2-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Add compatible strings for the RTC block found on the Renesas RZ/T2H (R9A09G077) and RZ/N2H (R9A09G087) SoCs. These SoCs integrate a closely related variant of the RZ/N1 RTC IP. Unlike RZ/N1, they do not implement the RTCA0SUBU register. This is not a limitation for Linux support, as these registers are not used when the RTC operates in "scmp" clock mode, which is required on RZ/T2H and RZ/N2H due to their 195.3 kHz input clock. The RZ/T2H RTC variant also supports a 1Hz output signal on the RTCAT1HZ pin, controlled by the RTCA0CTL1[RTCA01HZE] bit. This bit is marked as reserved in the RZ/N1 hardware manual. Update the binding schema to require the additional clock inputs used by these SoCs. Signed-off-by: Lad Prabhakar Acked-by: Conor Dooley Reviewed-by: Wolfram Sang --- v5->v6: - No changes. v4->v5: - No changes. v3->v4: - No changes. v2->v3: - No changes v1->v2: - Updated commit message to drop reference about RTCA0TCR register. - Added Acked-by and Reviewed-by tags. --- .../bindings/rtc/renesas,rzn1-rtc.yaml | 35 +++++++++++++++---- 1 file changed, 28 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml b/= Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml index 1860f0e4c31a..ea7b039a91e7 100644 --- a/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml +++ b/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml @@ -9,15 +9,19 @@ title: Renesas RZ/N1 SoCs Real-Time Clock maintainers: - Miquel Raynal =20 -allOf: - - $ref: rtc.yaml# - properties: compatible: - items: - - enum: - - renesas,r9a06g032-rtc - - const: renesas,rzn1-rtc + oneOf: + - items: + - enum: + - renesas,r9a06g032-rtc + - const: renesas,rzn1-rtc + + - const: renesas,r9a09g077-rtc + + - items: + - const: renesas,r9a09g087-rtc + - const: renesas,r9a09g077-rtc =20 reg: maxItems: 1 @@ -54,6 +58,23 @@ required: - clock-names - power-domains =20 +allOf: + - $ref: rtc.yaml# + + - if: + properties: + compatible: + contains: + enum: + - renesas,r9a09g077-rtc + - renesas,r9a09g087-rtc + then: + properties: + clocks: + minItems: 2 + clock-names: + minItems: 2 + unevaluatedProperties: false =20 examples: --=20 2.43.0 From nobody Mon Sep 28 12:34:52 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE3EB387566 for ; Fri, 21 Aug 2026 21:11:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346662; cv=none; b=S+k1QwR9d62bLC0WY66iyS1mb8rP9J4o0PFhJGTQwrK+enBJLmi8xdkOnR5+cOZ19s3ej0kjDJKw22gs4jZoZzWG7Fi6awgQn4eVce1BgvarzyEOefEffyZsVzSMYde7A7Nj9S5HYCve8u0UkwSepz0NVJNuNHeHj/COGuKSXII= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346662; c=relaxed/simple; bh=FcFe84J70STVXadjwGrYhB5cH2/wxennvKnATh/rQVU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pDPZTkpjc6OayRYNp3oUTbXOMPWadt+dtjT8lMkpiCtzMutJRZYt7+Ta3AWBarBmbCqJeX2Ph05dL97x8+bO2nzsDB+EWq58XA8Y2mX0ZTeWxMYfohPpdzCxPPiv4I/+LQBesadrZDivs2G3KdYK9Hg6n5w444EjslesDoBLCE8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G5NoM7Yi; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G5NoM7Yi" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-38deea72eebso1541411a91.1 for ; Fri, 21 Aug 2026 14:11:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787346660; x=1787951460; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=gIt6UFBBZvWrPn4NfEvT8ScoUcoqt+wSNI1OUlfCTAU=; b=G5NoM7YiCH9RvXAXA90hGh7k69JueHpczMVYzOO89627Bs8ENB7nOrRmJ5febnQhSc qGHRiYPntC/USEIqPlNr4rk13Nmq3H9zp+N4qUacRYewh6321IleR+gBsobod4rpfqcm sHZTAaRQX6PG/TMxQJvoRGBmvHa7wcj/88qR6HJ2DT664/jg6C2ybLc7AVFVkkXiqBOc EpujOyLtpW2ODgLf26Qa8tFepXuA6vRCBDmmnFhwQeQ5pbqJjD3lzC8wHV2KlOvwBjq0 ergA6qbGUnTLNYgpLEB1ZD/Pw1+OmS4rNcMXdEbaipWQlBMJzk7Jy8X99JfoRBbjXd5s mWOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787346660; x=1787951460; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=gIt6UFBBZvWrPn4NfEvT8ScoUcoqt+wSNI1OUlfCTAU=; b=jYYgtD2B0Pp82UN3XoYRraVYWGkdLmpNCUUjhZU6KJYP4DK7aRwxw6QT8NcAA4WuPj 9b5jHemZML5sHDtrPI31yuGyhJpzjNWgl17PgRgkCcV3eflrFtDY1zY5Gzmcyfi69Uln VzupeyRvDkP17N6KGBEnPAcxTM8wuOLXTa+LW064Qmn1HwkF1HRgYxlwlyqF+n7p2ESp q7yMC/9tY6/kwlKQUfeeyivhNAbL9j2Ddk6nV8LyNpHn0FcEPWZqffUj2gQ4tJnIsnPk KmdUvSZP/gXgG2HtjkNxx5mnHSza/RH5iwEfcLfYaMOnmvz7BMtl8mWg6I5yDYdCdbYH sSlw== X-Forwarded-Encrypted: i=1; AHgh+Rq/sjeGs7JxzqowDFO+9LPWRz91/LcpnOCCFEC5tWcvNYiaP8BO40e33JQrrQ7D9eA03xaWhRVvmgaYaig=@vger.kernel.org X-Gm-Message-State: AFuF++n3uvEMJqOawMgI6/qivCZUbNvltZd8zmZwHiKi18dhawh8AqWT XeIbXxggfGiLYZUfCPVASvuIjUXeFbunuMAtEiKiX3e8zYHUfRxqCGjq X-Gm-Gg: AR+sD132EOAVl1UP0U1EfhAAwtXt3hkkd7IL3cy51c4M9Qt1T7AGHr2LPtkhleAU6fJ QI8qKv+uBclrRQ5+/JlQPswOaFjqkdbzl8hf7JtO5gz7tI96I3wzWWi6w1MkJFkW7cqNGWTtw6u Qpiv0hfvu8E+ze+O4KfyiL/2ppiXIsufSXjsZ3icpja4SNBM2AeHo0V/zKSM09NXwSEEXpz+6XK c0vyu+AtPlOFuSD16IrRzjjqd6KuTsOv5PXKAffILG4UNHy48b5kJxPV5xBO8Mp1Z62rQ8DlkDE eTHHmAkMKqwWfZTjjzmVXE4mIdBlcdVtBjZ7YWoU9ur+BoyulVD5ajrb3Q+w+pKrT9wdOQv02AX 09k73fC67wncoERraEHOKsDGg6D0dM2wFnay4/KdUMILxSkNnw1Bne62Rnut2q/xSaaA9jB9xS9 ejOU5IPVHuvGEII9whG/xwggtG80TnsBNVYos1i8vE+FXUkTxCsZtXJz0fWEd12hnW4BZuHV89d 9Oyi+ziS4WkRNlcAjPtGvWi8MItdlFI3M/YWQGYb5tUEgU25mJgWQWwdq6bxM3rXSVFe+JU X-Received: by 2002:a17:90b:4b02:b0:36b:bec8:94c5 with SMTP id 98e67ed59e1d1-395df2595femr2125893a91.10.1787346660098; Fri, 21 Aug 2026 14:11:00 -0700 (PDT) Received: from iku.. ([2401:4900:1c07:194c:dba4:ea1e:d7d1:affe]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bf175399sm49755257eec.26.2026.08.21.14.10.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 14:10:59 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar , stable@vger.kernel.org Subject: [PATCH v6 02/17] rtc: rzn1: Handle EPROBE_DEFER for optional pps interrupt Date: Fri, 21 Aug 2026 22:10:17 +0100 Message-ID: <20260821211032.13554-3-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Check for -EPROBE_DEFER from platform_get_irq_byname_optional() and handle the deferred probe request properly. Although the "pps" interrupt is optional, an error code of -EPROBE_DEFER indicates that the interrupt subsystem is not yet ready. Intercept this specific error condition, assign it to the return value, and jump to the dis_runtime_pm label to avoid ignoring a valid probe deferral. Fixes: eea7791e00f33 ("rtc: rzn1: implement one-second accuracy for alarms") Cc: stable@vger.kernel.org Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v5->v6: - No changes. v4->v5: - Added Tested-by tag from Wolfram. v3->v4: - Added Reviewed-by tag from Wolfram. v2->v3: - No changes v1->v2: - No changes --- drivers/rtc/rtc-rzn1.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index c4ed43735457..f81d691c8b9a 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -465,6 +465,10 @@ static int rzn1_rtc_probe(struct platform_device *pdev) } =20 irq =3D platform_get_irq_byname_optional(pdev, "pps"); + if (irq =3D=3D -EPROBE_DEFER) { + ret =3D irq; + goto dis_runtime_pm; + } if (irq >=3D 0) ret =3D devm_request_irq(&pdev->dev, irq, rzn1_rtc_1s_irq, 0, "RZN1 RTC = 1s", rtc); =20 --=20 2.43.0 From nobody Mon Sep 28 12:34:52 2026 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DDE23CB551 for ; Fri, 21 Aug 2026 21:11:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346669; cv=none; b=i+09urA7Q4HfUttR1bZKjcSiVfeSVlqexeuStaALRTfmSoDgMj7E3ZAqggsqOZPhIpxWFIVjlhxIPUK5HEAWUNzGrQOLr/bivStMd6R59mZLD9EHhN44cPYPIc+o7KoYPvN9s/8akP7GGq5tux3hPnoa3aD9rRkda5o8Ic9Oq5g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346669; c=relaxed/simple; bh=G8py0KfqTCUThOelxLCduHUIUi1Im6OxQnN8n8LKgdM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Z0g9evkXia6Qb0sWQsx0xr0T8xCwKlCpX63m79Mf6t3G/UAD7/jbbSisekrUHrBpOoAoacCHGQ96N0T1qDZ5zUYUXRKpOKVhbmZ707GNaj1jyrmJ8PIoir7a/yFzso/bkI8QFOOr/N1xolTxM+arrou+y0GXIrZ0yn9Y+KZlL7Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X8dZQz+8; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X8dZQz+8" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-c9b373d5af0so1143593a12.2 for ; Fri, 21 Aug 2026 14:11:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787346667; x=1787951467; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=CU1oP/ljlYx+FVX14t93B7e35BUmi8NVJJ5FxmAJfS4=; b=X8dZQz+8ob8TBEAglcNHwCSbz2hY3zGwqtd/rynrRJq5sT6MBvyuqp87ITMzx5D6FQ uh/1UiIhyuOb+sNHN49eNQmS4eXQtzBuxPvjQFJJ8QfVafLPziOcvjlLArHrC0HT2wbY 4lT+qMazTQY7EblfgKGd/GtjOC++67DZLEpJdb4y7m4p4hJbizQQOBSm/gBgxeJ1Rz5l 830c7ECts+mFr3yNRUYzSwdkKdaiOliguyMEJaGg8l5SATZHrwE6CX1+/q/gzGQcy9Yf 2tBHZBNw8WKMnKq5jbx6B8kX4ZT/rR2eRQIkEcOpmNmGeBsSLJ2ju/n+pFz51gpBvLst Ro7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787346667; x=1787951467; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=CU1oP/ljlYx+FVX14t93B7e35BUmi8NVJJ5FxmAJfS4=; b=EQFXmSZ5SpttrBHv7je7pPPIpvEe/BsXNBXCJcH/lvACUd6cxTOW3VXAnWSMgSMlqk j5YVyQUcLIxdNRb/JUm3z4P1SEYQxywf8iTMqSFWZF/scHUDSjqziWLlZzHN7FFiPL6X KzBhRL47QprWNZ0NjdXcg2ri+wgvdyzCaVTkh4PZENQdxQxD46asVFW3JJYImEB5TEOj sX3cGnG5o/XSrUNX9qsrM2P+bMyJSpO6seRzm5lWyTEGcrQ2RRxB/OgCn66d/WxIoy6x 1ww4rUpwe9/KcIQD6XCJ9w/szgORmL6qYBhyibLzSwYMlSm+vghK90BmOXgnkdpbS7AM w3jQ== X-Forwarded-Encrypted: i=1; AHgh+Rp8gnc1qgji4B3B0tpKsRYy0Vbxto1Ih7mxXT4xGVlGQ2BAk2RBV0jPR3HT76Nz7KdHKPhDhxuhQvGQxXQ=@vger.kernel.org X-Gm-Message-State: AFuF++klRb2pXy0xvzCzg+C7NOnBkaHJsZnrMaEUDq2Zn9QkparqXimt jETCNkHwk+KmArBJPn2zfJhfXC0cOf7aIM3m4kiWJedDIdsIRyrxhUaH X-Gm-Gg: AR+sD13KtFnCW78snAq0yz1JsoJYUhrsAMjOT0svneBFJ07NcKB/5W9eMXmYkfMZ130 VwhlRGNa5g2sMVTk0NsWKp9200ExsLvd9LnSLJCKlxmA+LQ01foQV+ubjK1EYBH1h559Exl0cDl 93/uplOk/WwxP65lvnnTahQJ7HBY+dxjdfb/hdzHnDeYCnhNNhKbewFXabkLQ6L05fvWoDIL7Qt tybSnA+nJ0/moArs/VeQBp9X0pHkrdzk+M5d52EnI9AbfFNGRyiMw/TsZk4vyFmzUHbjzv+ftld G5ndslErd9Ug04HXObd67rEGnelKl0ArIxctt2Aip90OvygXcaLNsDkf1ulvy8jwrmWCLEovEkJ VgnWdZP0Lgd7M6N9lr8BvAX88chmI3+gzCIRhuKgROS7z+pKiV9JxFnDA3FRafysHaPT3bI34mo lcmgBPSYXajL4Hwdr2oFJgVzylDv/KsYf6JoL2YTp7Q1j/eoCDmNWefbIMqwQz9AUuJ3s76f9wI zk/T39N58insiwi4eVTdlThnqNOhjULj669IFT+lqyQQCudJ03Zenr68YR/M7EGZLf/NdWO X-Received: by 2002:a05:6a21:8cc9:b0:3c3:a3f4:5485 with SMTP id adf61e73a8af0-3cd4ba0d216mr3000476637.6.1787346667011; Fri, 21 Aug 2026 14:11:07 -0700 (PDT) Received: from iku.. ([2401:4900:1c07:194c:dba4:ea1e:d7d1:affe]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bf175399sm49755257eec.26.2026.08.21.14.11.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 14:11:06 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar , stable@vger.kernel.org Subject: [PATCH v6 03/17] rtc: rzn1: Fix weekday underflow when alarm crosses month boundary Date: Fri, 21 Aug 2026 22:10:18 +0100 Message-ID: <20260821211032.13554-4-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar rzn1_rtc_set_alarm() calculates the alarm weekday from the difference between the alarm day and the current day of the month. When the alarm crosses a month boundary, this difference can become negative. Since days_ahead is unsigned, it underflows and results in an incorrect weekday being programmed into RZN1_RTC_ALW. The RTC core already provides a fully populated struct rtc_time for the alarm, including the correct tm_wday. Use tm->tm_wday directly instead of recalculating the weekday from the day-of-month. This avoids the underflow and ensures alarms scheduled across a month boundary use the correct weekday. Fixes: b5ad1bf00d2c4 ("rtc: rzn1: Add alarm support") Cc: stable@vger.kernel.org Signed-off-by: Lad Prabhakar Suggested-by: Wolfram Sang Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v5->v6: - No changes. v4->v5: - Added Tested-by tag from Wolfram. v3->v4: - Made use of tm->tm_wday directly instead of recalculating the weekday from the day-of-month. - Updated commit message. v2->v3: - New patch to fix weekday underflow when alarm crosses month boundary. --- drivers/rtc/rtc-rzn1.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index f81d691c8b9a..56284a4320ae 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -261,7 +261,6 @@ static int rzn1_rtc_set_alarm(struct device *dev, struc= t rtc_wkalrm *alrm) struct rzn1_rtc *rtc =3D dev_get_drvdata(dev); struct rtc_time *tm =3D &alrm->time, tm_now; unsigned long alarm, farest; - unsigned int days_ahead, wday; int ret; =20 ret =3D rzn1_rtc_read_time(dev, &tm_now); @@ -274,13 +273,9 @@ static int rzn1_rtc_set_alarm(struct device *dev, stru= ct rtc_wkalrm *alrm) if (time_after(alarm, farest)) return -ERANGE; =20 - /* Convert alarm day into week day */ - days_ahead =3D tm->tm_mday - tm_now.tm_mday; - wday =3D (tm_now.tm_wday + days_ahead) % 7; - writel(bin2bcd(tm->tm_min), rtc->base + RZN1_RTC_ALM); writel(bin2bcd(tm->tm_hour), rtc->base + RZN1_RTC_ALH); - writel(BIT(wday), rtc->base + RZN1_RTC_ALW); + writel(BIT(tm->tm_wday), rtc->base + RZN1_RTC_ALW); =20 rtc->tm_alarm =3D alrm->time; =20 --=20 2.43.0 From nobody Mon Sep 28 12:34:52 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 036A9412C0D for ; Fri, 21 Aug 2026 21:11:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346676; cv=none; b=Mp5XhPRNkQhv431ZgAecYRDRdKmvCvKbX0jGDZF234QbSB9S/WtE6L6kazC5wdxsUoOnyBlmIC37Ucq1E3VU/1NRB7RAyE4e9x8cCi5p1pqWzDiuAyYPZ6LRdF6KRLJqmgq94QbJUNJlCLOTrE8X/DWqpzNZW+cszTKNl4vZ0j0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346676; c=relaxed/simple; bh=2otbn34nfGVAQWDoW3kygwVPRAZNy6bTzKDAgEDbuA4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PTsm3HAg2fOuyci3j9H7izjPsjzrp+A4hDpxRYqITuhRGRf/ITl2+niYCmlcLP9qKnJSJJFe3LGgrwvA1oKh8aQRMIn1o2IlCp6dHjNeCz+h3pSDxtO9MZPr0YufkJ48bM2H+/i/CuVBuSz2g8/etqAJhig6SvuIidyPg0nkCvY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=owohuVT+; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="owohuVT+" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-38ea87caafeso1061896a91.3 for ; Fri, 21 Aug 2026 14:11:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787346674; x=1787951474; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9sCsIOnwlsCxJXPIRVBkV12bzXwBoxzZvCo61RvGv4w=; b=owohuVT+66KwR1dYuxvUunOIPP6jS6bnC6CHQ7uCrTSeKG5pGd9NBkEmGvaeOoIn0x EQw85R1sLBzPBd6EvlaLsOaQPQER+2tn6pexbWokjSRINw6qC7DgVUSh59svgwWZC4Iw gfT2/ENf5OZB8oK4hCqCGhNw/M0/f3Zn3UKUBIK+1VkcG7+s5QNnpLSj0ScqPuNl4XRx 8HAhP1KMMw8ctALf65FC8/M8/cNgAK8ws0rgNRaiDVINCzTFad1ocdL8NOOdfGCGvdDC dZqhIVi1jUvoMkx2ZFYX/dV7Vb3Nni1okAnVUN9rn0HyFfKFe+X6Ni0d/b9SIB2+Rjty vRPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787346674; x=1787951474; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=9sCsIOnwlsCxJXPIRVBkV12bzXwBoxzZvCo61RvGv4w=; b=hdVmmHAiP7SCLABlP76L+TwkvIzvXUDXM15d3EfNydfpptO9MXl+SQ+y8j7dP0m2Bq oAng7ZnOBv4+IkgrJOnKKMRMYQ8fFKQBtMIU56M47x4t7XqnKdswLJg8H4tBqLf+qgsf WPug4u1mQd0CUxCRwZV3DKrfBB7VJJGRI8+UBg8WAxEHlILKQcRV8Bgl1GAG8zaKCVJA h5qpWW1U51LnV4bqrX8Turay7gVbhJ9j35L0TDR+vpEDRiYwThVW+8VLvn0Hxuxhs1kb kY4eaaE1nERGbd9C8JRV3QxLvvMNr7HImMswA3mqfXjBmtW5s7eujwjbCHrGQ/VbFQNU YOVA== X-Forwarded-Encrypted: i=1; AHgh+RoAku10FDc87iPX05FL+Yq1CNhrjqX7OvWRRuHpQ+2mgREzETskXt6qiza4oolMNpVZiPQdtInMODKkGb0=@vger.kernel.org X-Gm-Message-State: AFuF++lLr0waYEm0t9Wd5ZlaYQGrNyQk+80ZwcoGXJZjgRMk6L9UeM1r EtWQYYo0aZHKQu9lHGrl4lzWtpXqJ7LKJ50LnxAz55P/PGPFSyS6x7uM X-Gm-Gg: AR+sD12LGyGEDd6cAtWJNWNKoyvndMOFwf73ZFz64oE9pNFg9sdc74mxiwmcoebVuEN UOodhaZycV1X3lH9i64PAr98D5wdXuwS5NWR4W9LVzEG75H791eY4whJFuD2wLbUFNhqznCNKCP IhGZlUP7lEwgTmR49XWAlzLdiGw4eViH72EOco05nB8xwJaT7B0TVXEwNBQO2OztHytzQWWtTGa Ap+emYm3bkg6g5fer6mplK5CJ3+FNjhYJ5Hsz6vTnOpOPJZPm9UnNCzQgwg7HXC9HRJmOgmFnE4 k5TZMbEX55cIlXWILJKuqwxTXonEBXczRut9GJhOX3RJPIbxcT8ckPjMumxPZ95KZlCdYCslwjX MtdCVHWCnoThmyIHki9LMyzs6jC2Rp2YA+mxFV76C2oRHUaWP7WXcgNSMQYM+tgl2BCtPxUdzZV Ohu/BcEOmlwasTMqzU4iIUFV1vuAU3U+AN2UrAej6YOr3JmQHjdLrbfJKXgMvm0WaSg7MkraQjo dS5UFC/kXTPLbixgmO1aHNzaivO7weHUZSqhgnrIMh21NG6WKdVpbgcxFM22PGLDHmUMM+d X-Received: by 2002:a17:90b:2c87:b0:392:7f74:58c9 with SMTP id 98e67ed59e1d1-395c3a43766mr18539447a91.15.1787346673939; Fri, 21 Aug 2026 14:11:13 -0700 (PDT) Received: from iku.. ([2401:4900:1c07:194c:dba4:ea1e:d7d1:affe]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bf175399sm49755257eec.26.2026.08.21.14.11.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 14:11:13 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar , stable@vger.kernel.org Subject: [PATCH v6 04/17] rtc: rzn1: Handle unset alarm weekday in rzn1_rtc_read_alarm Date: Fri, 21 Aug 2026 22:10:19 +0100 Message-ID: <20260821211032.13554-5-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar RZN1_RTC_ALW is a weekday bitmask where bit N represents weekday N. When no alarm has been configured, the register has its power-on-reset value of zero. rzn1_rtc_read_alarm() uses fls() to convert the weekday bitmask into a weekday number. When RZN1_RTC_ALW is zero, fls(0) returns zero and fls(wday) - 1 evaluates to -1. This invalid weekday is then used to calculate the alarm date and can either leave tm_wday set to -1 or produce a fabricated alarm date. Treat a zero RZN1_RTC_ALW value as an unset alarm weekday and return without calculating the alarm date. Move reading RZN1_RTC_CTL1 before this check so that alrm->enabled is updated for both configured and unconfigured alarms. Fixes: b5ad1bf00d2c4 ("rtc: rzn1: Add alarm support") Cc: stable@vger.kernel.org Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v5->v6: - Dropped the output log from commit message. - Added Reviewed-by and Tested-by tags from Wolfram. v4->v5: - New patch --- drivers/rtc/rtc-rzn1.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 56284a4320ae..d4cba0d415b6 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -235,13 +235,24 @@ static int rzn1_rtc_read_alarm(struct device *dev, st= ruct rtc_wkalrm *alrm) if (ret) return ret; =20 + ctl1 =3D readl(rtc->base + RZN1_RTC_CTL1); + alrm->enabled =3D !!(ctl1 & (RZN1_RTC_CTL1_ALME | RZN1_RTC_CTL1_1SE)); + min =3D readl(rtc->base + RZN1_RTC_ALM); hour =3D readl(rtc->base + RZN1_RTC_ALH); - wday =3D readl(rtc->base + RZN1_RTC_ALW); =20 tm->tm_sec =3D 0; tm->tm_min =3D bcd2bin(min); tm->tm_hour =3D bcd2bin(hour); + + /* + * If wday is zero, no bit is set in RZN1_RTC_ALW. This is the + * register's power-on reset value. + */ + wday =3D readl(rtc->base + RZN1_RTC_ALW); + if (!wday) + return 0; + delta_days =3D ((fls(wday) - 1) - tm->tm_wday + 7) % 7; tm->tm_wday =3D fls(wday) - 1; =20 @@ -250,9 +261,6 @@ static int rzn1_rtc_read_alarm(struct device *dev, stru= ct rtc_wkalrm *alrm) rtc_time64_to_tm(alarm, tm); } =20 - ctl1 =3D readl(rtc->base + RZN1_RTC_CTL1); - alrm->enabled =3D !!(ctl1 & (RZN1_RTC_CTL1_ALME | RZN1_RTC_CTL1_1SE)); - return 0; } =20 --=20 2.43.0 From nobody Mon Sep 28 12:34:52 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D2933D47A1 for ; Fri, 21 Aug 2026 21:11:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346682; cv=none; b=fSHCt2GxKmRdP8ZfX6E+Q9PFD0GMvU4qlEnHBMxZxfMOx5koN3lT28mJY2+oXM9ILP1ZN96qepEYGnooGRZCzbuKHLGxkoSjIU8kIT+cCO1xGoNrVO4/qsYv5ZGCcDdU3esO4YwcTaO8i8N7L6CB1THPm1xQAMJSYLvjSDnXosY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346682; c=relaxed/simple; bh=4qPzU1qyixVbSt/2x/vRlwNrYljQ8mnf/LV2SZCpJyg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=S9Z5UEKAABLYbLILU1kODgJr77CTn3UWCIG3C+b4+tR6bwngZpIW2HlJne9f33bW3izp7g3FxZJ3gShj2fuBFGsxe5SVe+U/Wiy+460KFRfV6a/qt9CjREtdSy1BdTY80+ExtQq+SvhrZ0qZDN0GTzzgM3S3rlyHSqjOYA5P0K4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=s5zR8mai; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="s5zR8mai" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2d032846c95so17718825ad.1 for ; Fri, 21 Aug 2026 14:11:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787346680; x=1787951480; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=yn9Flz79IoiVRVBjWq6xrtU5CbtD7DazplXOHiCs9RY=; b=s5zR8maipP+0MMv0lyPDQXbcWWrvQokpqP8HaTs8t8mlphvkOyTK4h+9XnHnkguFXc dD0zrMCz5FyKGsYywOnPcAdTgvkux1rDDegMEKC80p3Sil0DO6ua1YPdXqyGYDuyDXQR N1OJx4Z+F9N3kDbb8c39LGhbbO1bV9oxhVKYLaqK4cmPBMmmKdrrGcqhRefhmWrPXS1U 7FcVURB1jj2rki6XnDM/wUa9C5mkkXWHOrl9z9c17HiQQPeyU6UcycfjAjtDOQYHPUI2 mMLJ2+RC1i6AnQ0Wvk0piwlS66vZnRJEMvA996XFQV5zj1Aqua7cLgiYnG0sG9J6QSrJ cbjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787346680; x=1787951480; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=yn9Flz79IoiVRVBjWq6xrtU5CbtD7DazplXOHiCs9RY=; b=grEXB2WFfQgcctqBtMZ+Rjivu5qy/e/Q1cZ84jRdXeKY2uPc7EdcwvRP5MYw0sIwJw bMgOwoGtXNFdUTklIw48KCDzE9c/Qjh27Wm/SMbWDgYtFF7awE7mi2k24ZfW7iUD4CxB /6E4+wAOE6vHLBO1wQ5j2hmDXllDwL770FHUpDhF+5vjmbzN5qvD4v/Cq8/Eo2rI5A7E 5sx4PVt29lPlpH0IwavvkVW7erOIjMePw2ez9OzwTcefgWgl3NrPXVG65EjvUDsvB20T /ZNZYr3VU/ltjqVAWIdSU38Q6Oli73yXN+QV3/PD9AP9iMKyFG2pqOwDCJva9VVeIEGj IeXQ== X-Forwarded-Encrypted: i=1; AHgh+RoiVOd37gkyZzY+WN0/9Rn4VFRzc5EL1eA0E3gr+49bu3eSwNEJGjWpIDSnMHeyFxQPdVPIwD8pGvG5AKI=@vger.kernel.org X-Gm-Message-State: AFuF++k5xVhmjAEdgwsCtLpMHXaQiKuuOaXBDM+/emrMtEtSraDlhqoQ m4+XRVxcGumjBLxibEb9o0zgDoopO+7Qj/ZLItlyb/a2VKs18/5h9xWG X-Gm-Gg: AR+sD11mG4t82M1a6WDYpACYq3iF5+M0cDzzK8Oa9qIyFX1SGXJZ8SEBLrFrXdbLo6N YQjy/CwX5NPLgLfuGA3Bj2E4ky0p1iAVcVJL8LFVOMruS1Kk3vU2MZ9UKScmRM5K+xsEz9mKYLU 3x519muRHWyocgfon/fThxdudCLyXR0LMvc31rBgiAt4QB7rGqpTfWDx8XHLgE+PINBd7C/4hc6 q39l+PneYOlexUbD8r9AP0jn1qyNgbfL/L7f8ri5H/vk0cR7Kz/3B3JC1ksPIAb76Zu4T4Nttq0 RMoRpe6p/vzqdFqp1rDIaq9xy4nuwZfdhAk98IVnRqJpMjom22RX20tMQqlxgwdXlmbQuNLcg8u Qdl+iifv4vRjh7kkN9xIO4nlXuM5C+2a+lG+mEVlrotVm8vmt9XmUlnvBSeriHSMtQDfKXAm8QM tXKUIUZMbt9INscVqV2DjFGt4f3iWzC0mFC/59S+jRXGhYb8mfL61Qd18E/Zdj1VHl9RBfvDFDd SC84wiT+UxMMyQpRpm4RLa0AkEQXtQ9IuIuGR5z0M3azn9zhXoULDprfTtmzgSBEoWcb40SzVnk GQf4EpcKAwi3 X-Received: by 2002:a17:903:354b:b0:2d3:2e86:647a with SMTP id d9443c01a7336-2d64af6f896mr181704325ad.5.1787346680507; Fri, 21 Aug 2026 14:11:20 -0700 (PDT) Received: from iku.. ([2401:4900:1c07:194c:dba4:ea1e:d7d1:affe]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bf175399sm49755257eec.26.2026.08.21.14.11.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 14:11:19 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v6 05/17] rtc: rzn1: Fix alarm range check truncation on 32-bit systems Date: Fri, 21 Aug 2026 22:10:20 +0100 Message-ID: <20260821211032.13554-6-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar alarm and farest were declared as unsigned long, but rtc_tm_to_time64() returns time64_t (s64). On 32-bit systems where unsigned long is 32 bits, the assignment silently truncates the upper 32 bits of the timestamp. Fix by declaring alarm and farest as time64_t and replacing time_after() with a direct signed comparison, which is correct for time64_t values that will never realistically overflow. Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v5->v6: - No changes. v4->v5: - Added Tested-by tag from Wolfram. v3->v4: - Added Reviewed-by tag from Wolfram. v2->v3: - No changes. v1->v2: - Added Reviewed-by tag. --- drivers/rtc/rtc-rzn1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index d4cba0d415b6..f3268655fd37 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -268,7 +268,7 @@ static int rzn1_rtc_set_alarm(struct device *dev, struc= t rtc_wkalrm *alrm) { struct rzn1_rtc *rtc =3D dev_get_drvdata(dev); struct rtc_time *tm =3D &alrm->time, tm_now; - unsigned long alarm, farest; + time64_t alarm, farest; int ret; =20 ret =3D rzn1_rtc_read_time(dev, &tm_now); @@ -278,7 +278,7 @@ static int rzn1_rtc_set_alarm(struct device *dev, struc= t rtc_wkalrm *alrm) /* We cannot set alarms more than one week ahead */ farest =3D rtc_tm_to_time64(&tm_now) + rtc->rtcdev->alarm_offset_max; alarm =3D rtc_tm_to_time64(tm); - if (time_after(alarm, farest)) + if (alarm > farest) return -ERANGE; =20 writel(bin2bcd(tm->tm_min), rtc->base + RZN1_RTC_ALM); --=20 2.43.0 From nobody Mon Sep 28 12:34:52 2026 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6499F3BE652 for ; Fri, 21 Aug 2026 21:11:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346689; cv=none; b=GhBMs+GxJMtPXrgUQLueCrN96ZTBqMYNutUqM8NzaVBLeETkGrqBk+VLq/WCZl0bKPO7GzLWJH21UZ1e2GP/uME12ZebgOF+97MoJpB9Yb4XzxU2WnlIdR3HFkH7m5kDJiqcl0BCzs1o1D6dfg//H9RDaTJUD4JwhEcKNmcyXy8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346689; c=relaxed/simple; bh=OCvICYb+/dgelt4iCQOW0q7NZ8lOQA6YG4zyM/aRMjo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IcQrid44ONZ+5sjocD512Wlge3CPB3DHLAza+Oji4apQX2lc4q7FCCz1tF9UTGotlYIGzLc7YePnW5z0awmO4oIZSPxQyEghsaoGA0zscFQFPOtPW1O09lKYpkpqxu+mJQEWIsNai56eSnUf9KTOPMs0Wbi2hx3dQC1ka46tN9A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hyHYUmVo; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hyHYUmVo" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-ca12086c06eso1134223a12.0 for ; Fri, 21 Aug 2026 14:11:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787346688; x=1787951488; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Qu7PJFtPksXhb1y6jab3sxIPaMUT5D7gnfgKv2YPKow=; b=hyHYUmVotRVla/v4zr4RPIjQGXvdP+vlvD3nhSjPgkQdOxOyP22xZbBQyqbjv0fpeJ I4jB6zrqeoNXhj+x4/T2CFXQJ1eOLRvuIrWYMkvIpTICRSmUC3L1uNCrPN40wr6K7dSD /5xx8FD48e4BWg76P796ge+E5lVZHY+WZV7C9pGyV+s/kBaV3fSsdJEflyfi+aw+2avg qVRMBIH6YtYveKxJ1+bYkez5NHAxqdeVbQtIwE6cfnjvmrP9UwIZyG3a3Dh2yMseqycl f26C2cXMxV0yLLyOpfMZpgF1Tstu9I+uCKyDIx29YZhRRyMr+v7p8MJbNVzAnni5Isbr JazA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787346688; x=1787951488; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Qu7PJFtPksXhb1y6jab3sxIPaMUT5D7gnfgKv2YPKow=; b=Rfhdr0DyoGfxIlnZUjOqMUN9dquonmqH8JX9fwa1p/PY5OC0lGaRELH0m8G3b3Dy/m N8EW36mC5vVNCgMtNSXHKzDpk0aVFtICfV8W5a241jpyc6I+qREAncMksJEYtmXqT0Bk j3IJuoXYeimAzOhA8n0bOQ01eef4uDCE+pcJosVm3Luz58dz8isUaapuY97rD35wIeRl fgS+L3DrbM5I54YT8iKpTf5jdnjJghXWChJF3a44ES7xSjWSYUrBXyB7r4pUtVCf07uG ZAm5+w7D/ZEU6x2hMcktfNwoNYtGaS51OnvhNlL4y5URiQrjWVw1zcwxLHFhEss1W26a YkGA== X-Forwarded-Encrypted: i=1; AHgh+Rp3m1Dqo6DQTm9tsImb2E/B/m8YmWR6/8p2WESpmzGk9IQf6wNBSGdjk8/ESQNzdBe5wMxhQtVsJzJL6DE=@vger.kernel.org X-Gm-Message-State: AFuF++mdBMTzx1dS0kqG68goB/POnwfcvzT+FFRdxJMxCSwlJRGBb2W+ /TSUdAygrTwsLoW/AbuKA+2JVZXtW/K6E42tp20IjJ1K/KvX4/s5LSFn X-Gm-Gg: AR+sD102pfZQoiLJPS3IocvPtQPFYFseKUJvbtHNLXVxkTEMFkQtZrd6jeoTI0PhkaA C0t6zQJOaj2q4uMWFLOWyO0+UeGqAOzPR9brEn4Yq69cqrbMYYPsniPqphkqdiVo9a7j1X1JVjN rN25eI6XERpxaP+GIS4QvPyPnTc8Gnn8WPnKYENfs+ItB5+0w9EmqkjhAMc/nStWgNyHhYoy+Eg 361nTfnv2QaDxZLGBxILZJnottzZpUm6hUDh81qPw2aMle+odzNa9v8NIjf6dOv6j+aSCybXfNf lGT+uxvHs2O4VlPL3hDtzTQW24WhEeBD+BZWLBSqmgBtGZsipDig8DmhdhnB70F+CvoJ9aQVrBV pUcMjyLYYmWgjfX9Vn86ATPxv6P+EgRfyaukigd16rQ0UuuPqRpew0pIj/GIBfdEGs4CTu1SRMW d0POWVP49JfEuewpdNEwJM0z+r03VWn0piqVPCp6vgsLtSHO5qU95GzCwo5e7dD+xuUYJMaVp31 qBmSfB+PBUWEF1nHilBkuGrjl7ioWGippsuhGwJusUfqZtr4dbL7MoaLmj85b2fM2mSPvm3 X-Received: by 2002:a05:6a21:a93:b0:3c3:a140:9392 with SMTP id adf61e73a8af0-3cd4b6850aemr3354970637.0.1787346687662; Fri, 21 Aug 2026 14:11:27 -0700 (PDT) Received: from iku.. ([2401:4900:1c07:194c:dba4:ea1e:d7d1:affe]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bf175399sm49755257eec.26.2026.08.21.14.11.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 14:11:27 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar , stable@vger.kernel.org Subject: [PATCH v6 06/17] rtc: rzn1: Disable alarm interrupt before reprogramming alarm registers Date: Fri, 21 Aug 2026 22:10:21 +0100 Message-ID: <20260821211032.13554-7-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar rzn1_rtc_set_alarm() updates RZN1_RTC_ALM, RZN1_RTC_ALH and RZN1_RTC_ALW using separate MMIO writes without first disabling the alarm interrupt. If a previous alarm is still enabled, the interrupt can fire while the alarm registers contain a mixture of old and newly written values. Fix this by disabling the alarm interrupt before reprogramming ALM, ALH and ALW with a call to rzn1_rtc_alarm_irq_enable(). Fixes: b5ad1bf00d2c4 ("rtc: rzn1: Add alarm support") Cc: stable@vger.kernel.org Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v5->v6: - Added Reviewed-by and Tested-by tags from Wolfram. v4->v5: - New patch --- drivers/rtc/rtc-rzn1.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index f3268655fd37..42e57bf0b4aa 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -281,6 +281,11 @@ static int rzn1_rtc_set_alarm(struct device *dev, stru= ct rtc_wkalrm *alrm) if (alarm > farest) return -ERANGE; =20 + /* Disable alarm interrupts before reprogramming the alarm. */ + ret =3D rzn1_rtc_alarm_irq_enable(dev, 0); + if (ret) + return ret; + writel(bin2bcd(tm->tm_min), rtc->base + RZN1_RTC_ALM); writel(bin2bcd(tm->tm_hour), rtc->base + RZN1_RTC_ALH); writel(BIT(tm->tm_wday), rtc->base + RZN1_RTC_ALW); --=20 2.43.0 From nobody Mon Sep 28 12:34:52 2026 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84A763CB551 for ; Fri, 21 Aug 2026 21:11:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346696; cv=none; b=uhhbxaBtPfT48KRLicbY+bPyiwX0ODbgIS5Lv5taXcHrhS9ULZY24c/9Lb2Mt+U5CWp9fNsi/QiN6RgZecqP4Q9D/G02W4hU/+51Zcb27shbeeDk+9cT4BCvCjAyhcMx/7ZbU0lMeXhVcQ875GPSlJ62iMJhDtqBELMkbXOfEwk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346696; c=relaxed/simple; bh=BNRstsXO9Qn5hNwHi5BiqdQ6ynmasEGVgbJ6LG8IhFQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DeZfKehKb3jcfPFucvkD72PjGgZQdyb8S0Jhd1mmLfbx/MqivDRw++j+IMNUiGyhAKpc9j8SWa7JtwaRTYmWJgEJPQZzEKN270XBbjnz3+xTq7lJScTETRf6IIIo/jLn7QW7KF7iZh4kiN5zkanweTX9fBJNRhEzkBgqTHztJrk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oVcOPJPU; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oVcOPJPU" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-381b831d535so1986117a91.0 for ; Fri, 21 Aug 2026 14:11:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787346695; x=1787951495; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cseIckdQQAKYtcHlbi/8vX8CHGe20BNek8ocdDs8KAE=; b=oVcOPJPUjh/9WLwcNylFgGDhkQnYlWzndUTDtTdGM9i0/i1pLqZjA6tnDezIewFPON 5xzv3h8gZWuhuo25eAoSBt0scBVHrNnd5xLx6O6DdSjBdW1qcbxO3qSocGJHbd2itOrR n3sqKemDeFUXiQr5OWfT6bvpBkswEchGlVozlMCJeO1BPYKdfqotAaWxLKJ6sYtbRzeO wAvpn3tLAA0ChgLg+kYpkjE4Nad04+x8Yv9s+cQzOpX23SuVlLbwHZ+H1e6HRvBpbYyM wVu4JMQHEXYBlcDrPk11RIKqMsQhBbrOqNTZHzRMYCl+xoX5QZQaRkY6wYQ7kZc6VKz1 XGVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787346695; x=1787951495; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=cseIckdQQAKYtcHlbi/8vX8CHGe20BNek8ocdDs8KAE=; b=oJtk541sQY1ksWTygDQODk+PUufgUnrymAqgobegwxHmRNyCS7+Dbv3MvZnje0eAzg IFleoxooBLI2kxf1FwRW3CR6/WtMVEFtd/mYBBm/sFsfMeUsYxJ1aTouUyQVwKpD1Y6m PHLLaYCL/30d4wogG9dki+eHdlEcNozGzYepyVlYqUIUOfIOsVEJy4C1FWtrUapQN7Tl DQSx7e2aOGiWCygbvU6KoOdEY+dsXjXlOphomtzFFuVHZ+VzqCgyy0s9dTTyvBBTALpG Pfzrs/86RetlZP4ch5ciyIurVOK0gID/SiSKszFzvi7wyontFdthNiWG5klGlmSZ17Ni ZD5g== X-Forwarded-Encrypted: i=1; AHgh+RqriE5nDgIJ/DjPlRRb36jmWiq+5rRWYMU3DZDs6kL+hF8bN8SZ+5BOJfFBeu4eVavqjQYErBhLvep47pQ=@vger.kernel.org X-Gm-Message-State: AFuF++lOyYeBKtP50QVcqyWYJ0xL0rYS9ioKpayronrl7Bzh4QgF38TR 0CF/LgJUpS8GhM1RD7ymouo+8S6cMiswwgGdKdliIuPZab+PIK0lY2uf X-Gm-Gg: AR+sD11Jv/4EwlTQiWmGq5eVuSHRsmkaFB77TXPOgvVE1D/nUFRKWtbc/6GTTEQxTXv QmrLeiULbdCqMAmljDQ6CqESCfboKy8FiaPCIsObPcQxXI/D0ZzvFdTxMwpJUTGtuVjxPAQH3Le VZ/iO/9vpCWVMw6AWyUpmNK20l70yC9LzSWxEZfG8kWL12xNL8+FxV9JtZTujyRYSw1a2STX7Cn qF7IhkXfbzKScBwFoPchtp8nImt88Xmhp76DqpOpAFtzCUXk6AVtkhmQfU5XS2tC8gtOLWPcfHX PDwFoJMwSJr74XmB2K3G9sLGqHPDJofsv9EH6R0PnhJjEdLxfL1DlgPl9ELtEuHINP1N9pnvPwb EQkau9MpHuTEREY88DNYrlCvYg8d2P4WMXLMITLhPCsix4yYE6qAM054jCgS+lQdVmcM3GCSw+S 26JXntT/Ox/bmqz3QcRubMJgDHUwzDOLy2H6s7Wz3t7/Zjn321qeJokJ387tj9bDfIa2na/QE2U q4byBH6X0x3OsYlo/eHWSEdYcLEZcpPfZlLGzNQx98SkZCUCt8rvHpibUgeJ+MRm1XvYzOQzQnl oJQb8sA= X-Received: by 2002:a17:90b:1d49:b0:38e:70d5:b12d with SMTP id 98e67ed59e1d1-395c3566ba6mr18408601a91.6.1787346694873; Fri, 21 Aug 2026 14:11:34 -0700 (PDT) Received: from iku.. ([2401:4900:1c07:194c:dba4:ea1e:d7d1:affe]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bf175399sm49755257eec.26.2026.08.21.14.11.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 14:11:34 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v6 07/17] rtc: rzn1: Fix malformed MODULE_AUTHOR string Date: Fri, 21 Aug 2026 22:10:22 +0100 Message-ID: <20260821211032.13554-8-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Fix a malformed MODULE_AUTHOR macro in the rtc-rzn1 driver where a missing closing angle bracket on the second author entry creates an invalid format. Correct it to the standard "Name " format. Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v5->v6: - No changes. v4->v5: - Added Tested-by tag from Wolfram. v3->v4: - No changes. v2->v3: - No changes. v1->v2: - Added Reviewed-by tags. --- drivers/rtc/rtc-rzn1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 42e57bf0b4aa..12c52003a7dc 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -525,6 +525,6 @@ static struct platform_driver rzn1_rtc_driver =3D { module_platform_driver(rzn1_rtc_driver); =20 MODULE_AUTHOR("Michel Pollet "); -MODULE_AUTHOR("Miquel Raynal "); MODULE_DESCRIPTION("RZ/N1 RTC driver"); MODULE_LICENSE("GPL"); --=20 2.43.0 From nobody Mon Sep 28 12:34:52 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 715853002DD for ; Fri, 21 Aug 2026 21:11:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346703; cv=none; b=jOWlwRc/VFEjZRFehbJyphEM3bbVhHUH8ELNrMQs83nJy7ew/J+Vd5u1BjXnsCscKY1pR2nqHWGkE9XNiA8axh3MAQnZlGLe+APjpgC4mp0dqDk5ebVm2HNuvouvCWqAYwhQcZzxWSEr6+y4jB1Me4AKdlIIj9rgcQ6Zz961evo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346703; c=relaxed/simple; bh=TCfg9FySj1A3MosqchjQdCzn5q0GtaBDifvwCt7XMRU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DyhEBCSJT3fphg9ULAwfGmap0PpQYhsQQbvlZUhaftFauJUwfFSrZph0GbCeLJoXIjlyVt0uuqCtrvpO6oGdTep4XhVvoTnNWuqBEzhWFLRjW1MHOdz7gVblo3JDkXDqleBcLWikp2iGYsKcM7E3mphWQinzEEfEFpf2EAu6pCc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IudF2TRL; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IudF2TRL" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2ce7d2adef4so20744175ad.3 for ; Fri, 21 Aug 2026 14:11:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787346702; x=1787951502; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zHPkqe47KzasEbjrOs9jLV7PJvfAFaVGFaYKGVwJi+M=; b=IudF2TRL/BKH+lgj+4bnrsoh+91G3vbCIwgmI365CpQ3XuI8SpCSxueJNt//GTbrXr WhTmU2UPvDiZiKFuBLygVqbHxZpjSoCi0GjA1nqlhhHLS2taCbj1avBcnOfM/zE4tk4e lvtrzOORFm6KPwb1Z0g8iKW3gOC+YVkCVHtnKGuXJyMArtFMP/Sp8/j//wZIZmAKq+aT 3PctvpbzSpLB9/SpSL+gK8hRA0OZ+D6GGuriaFIHPmSugQrMCivEW03vr/cTNzpxNzit 53YIxrQPumYNfUrPzPlFDHhMURNaDcAPKjI4HOeUfcH8rbKR4yQeYh07KeNTMCdSoFHd SxPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787346702; x=1787951502; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=zHPkqe47KzasEbjrOs9jLV7PJvfAFaVGFaYKGVwJi+M=; b=M2V/xhFJXYB4r35ZlNwuua/FLyjQSpIMEo0qj4djNIpZNqFVot05W1hkjDv7ndVWZ8 df7eICuz8JT8scp8pLcZsk+ySIgv8UKPIQVQhsATcRWk8rji2vlFrNCi5/TEhyLhflGh P6HGzS3mKlcEMGLsFtSxyZaWQUWh3OobnzbauUjCeMeslhiV/PLgX+2xiXjza+juOYpo 5E4el8S3JvlesOYDQ5Rtd4aOwzfhFiUm7iiOoKDvH3VQSHfkI4jXTMpxfgpRTnyl0nb6 8iMJbyVaOlwCkOwIUIboiHIP7pABY7i7tEF5qH/mxPrBlZ3jH+mJvdD8MK1+Mh0+TF6V GBDw== X-Forwarded-Encrypted: i=1; AHgh+Ro0uTVaAe8nWTIrjjSh9yas1g9FzMz9CoZp3/pg5IftgLQBdqVZEcv9JbJJ+N0tglpODl0mmOkiDM2yaEs=@vger.kernel.org X-Gm-Message-State: AFuF++ndOADWEafHKxYtx2Y5nviS8KaWn2LU0zB004D6PLCgo1jYZUOh nT5GhnzIhzf35ufEcKru/Gcexg0G7tYdgyc+WDkAT45nn7n90hvqj1uJ X-Gm-Gg: AR+sD12yTGM4M0J+gyw2JYqFn7qdL3rfyQTBdR3PNMn13mGyVaFcGXN9DPJu9CEDd6g p15mmEm97MVrsRb12qk6tWHWc4dLnU8RVOOvG+MuVqX0YT4j/PNjaNLO7+pnOFzAnyPNzSAQbaV 18ewxPYOckTN0g4ic13Yvhecd49bkoOU1Nn2UxIF3l1jDVE5vSQu1ALW8If8LXKK0q+2aJqfEay LPqyAILv6l+Zy2yd5Gtw4FvNDwR8Slx/eS1ziTHfKNrkwOrbxTehjnPVyr0naIAm7qMKm65BzLM x6Q9tUGTPDm3DZ2IReJ5/rRh7YmjNSD0rVGY54c9vVV4z8f7NBqo1eA+UqPumww4YjtEKYfkkCn MPFITxrfWtJO6rHdZd82Fnmjk+5btt8HHtgg9c8MG12RLPtiXNKoKEOgZBsUxMM7LZyJQ8awUVR gDLN5WGcGYUOPzuRdH7n/829NKhdd2t3pd8NlPBpbigFlfGEIYoRIDQhX583kvaaO0bd9AO8h1K hQNvBu0F0ZTLnJeV0exqry29nj8KUyDoVc4L/0qq0FCbFb2mO9R5rVfxlLYxc744pwrPMMXHRWT +A== X-Received: by 2002:a17:902:ec8a:b0:2d6:3c1a:85e0 with SMTP id d9443c01a7336-2d64b185640mr162835195ad.14.1787346701853; Fri, 21 Aug 2026 14:11:41 -0700 (PDT) Received: from iku.. ([2401:4900:1c07:194c:dba4:ea1e:d7d1:affe]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bf175399sm49755257eec.26.2026.08.21.14.11.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 14:11:41 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v6 08/17] rtc: Kconfig: Broaden RTC_DRV_RZN1 dependency to ARCH_RENESAS Date: Fri, 21 Aug 2026 22:10:23 +0100 Message-ID: <20260821211032.13554-9-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Replace the ARCH_RZN1 dependency with ARCH_RENESAS for the RTC_DRV_RZN1 config option to make the driver available across both ARM32 and ARM64 Renesas architectures. The newer RZ/T2H and RZ/N2H ARM64 SoCs integrate a closely related variant of the RTC IP block found on the RZ/N1 SoCs. Update the build dependency and expand the Kconfig help text to allow this driver to be selected for these additional platforms. Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v5->v6: - No changes. v4->v5: - Added Tested-by tag from Wolfram. v3->v4: - Added Reviewed-by tag from Wolfram. v2->v3: - No changes. v1->v2: - Updated help text to keep it generic and not specific to RZ/N1 SoCs. --- drivers/rtc/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index 01def8231873..d23a0fbe8d89 100644 --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -1635,10 +1635,11 @@ config RTC_DRV_RS5C313 =20 config RTC_DRV_RZN1 tristate "Renesas RZ/N1 RTC" - depends on ARCH_RZN1 || COMPILE_TEST + depends on ARCH_RENESAS || COMPILE_TEST depends on OF && HAS_IOMEM help - If you say yes here you get support for the Renesas RZ/N1 RTC. + If you say yes here you get support for the RTC initially found on + Renesas RZ/N1 SoCs. =20 config RTC_DRV_GENERIC tristate "Generic RTC support" --=20 2.43.0 From nobody Mon Sep 28 12:34:52 2026 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CE03414DEE for ; Fri, 21 Aug 2026 21:11:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346710; cv=none; b=sPujJXE19XHaUFSXMHsG+C5yT9d1IJBtjxPpGk/QGFxB0/IssEbOaEbU+vWKjYBMSO0TEqgoay0zTDWi01+1TBRoAxC0Pe0Ey5GT0i6q5UcHdLr8iiB/ppZaW1tFpEJ1/foBKD2XWqjue9y1ZUVLQU3GPuC13bMu1IL3mD0AJKU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346710; c=relaxed/simple; bh=5VW0bECDsMauSvaKs56MCVCbEPQcV05TjHG5C7nHTk8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ubHoWkeySbu4694OV8OtW5/F2Jm9eSoBgNJXhimEgQKJiQcen9wjlSJtUy7SstsqvmIuqqhpo7x5YS+olwDsbPerol7ZtecC1BwK0fUFOhR0odMuKSEaDQAYIPJZo1aqJbD3Yl5evuAqUoyUG9drZaLzCixzuclH5tSGCMljjU4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=koQvz4wY; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="koQvz4wY" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-cc11a30a259so1491470a12.3 for ; Fri, 21 Aug 2026 14:11:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787346708; x=1787951508; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5/9L56pVAtDYTQEB8I2wsSse1txCSpY+BJszOWMEp7w=; b=koQvz4wYI6FmDM0fvgvnH9OtC2PSIU/zi9xPdTT4FEfKN3bIeg01iDRIRFLC/Wsd8i EMp3DsZ/Xpm9WLt1CAKlP+666CC6HdDqeSQScP+j++xvqUGAF1zL0NtlIkcsj9raoCpe 4AHmz9ATUpMas3QfPQ88MneuPBfO2tEy0yNt6HGFfLVdMRJ2udkQwZbVrTJQa/NbQW5c a5JsV5cf/a414DvqKROmWzSvGbdRTTIPDhd0ymAWxFX8NuN1hpdDblsvMX4uvO8DfZVD tm52yaEULW3EmlZ9T8z/b4lnMpGhxktPnUY+32cNPZXwONPe9NFETjxaU16K8u9i33Mp /WTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787346708; x=1787951508; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=5/9L56pVAtDYTQEB8I2wsSse1txCSpY+BJszOWMEp7w=; b=SQDToGokEXhsPp+ueWqekaQEjhuZWPn72ZkSs866qeKUCmBVb5WZVegJfPNeYhvDhy 7QZJ609HPjgkbtmVpe5dZ1AqwipLS4eGIVZ46/8HBlw69e6Rj7NBNBF7qtwKDA6Zn7WN XWKvVcRPSRjPfpQeZ4X+NKV4Gow95Qa/I2YoHy6s8rnkbedkiUTN2rImOpa3y2X+OP6y 0FFxRsnMc8p3BqOaBdEf12ipehYGKhSchLaTx7aTpCq7mmKhLRoAou3Y3owwjbT+QWBx V/y4vDvB/cedksn3JIAMYW4/ALnpRPOp7YTquV8YfYJmFqfYOTjTKmfL1jXLb0iZ6F4U ddfg== X-Forwarded-Encrypted: i=1; AHgh+RopxR7QxspNSFMkzvpJNlmCG8D/W8pQRhUkan2W+ZgMm9aj4PG/1L2r6vFE/f54rw3SQaIotImphEGWE94=@vger.kernel.org X-Gm-Message-State: AFuF++norc5Krqpa+pKfFCfMrdTvVJ5E4JRbI2PjIC4KNiLejFQ3Kted DxFCOZjpL2vey6aBc9OHClUu3Xi5Yi4Lqx1VNyM0AnbbpTQyuI3c4YtZ X-Gm-Gg: AR+sD123iUVbud873b3/kKnNVQWcVgxU4NJRPwf+HnR+T5ypO7QCqkQ52011GddSJc2 WT3uPFF0iunTGorMC+CdKTv3Vdhv6rND832Z3gZMb9RFFMab+c7+gdrmLiXwrqhUPNNcvbN7Izu dzjqD6soiZL+/s8yp1j7M945rM3uYSGeGvFlVafnerLZyV0h24WyXETA8x0Otd8pCY1Nh0O2t6n OA8uX7PV1g847VVVgOOyDBiAU+o+oCwJ/by306eM0zUA2f6FFIHRdobpH08fxXW0mzvrqsHirBL sT0BnooW73hcUmBjRU/DfDk3pTuGIFXTplHjoGdWq+a9h3OxPyR6uMEpR3PM5DZLPu9JnFWdMmp 5zDiJWTNvdM3xiymIOQqyByybrIfPs5Q/hvszUkaahOOqSRinndqOwISvyR28p7zIT0hhCqFVbX V0fATnqaB5alpMiP8UFwwMD67vNg46MFjs18HT1XCy4QVO48CIf8d3e9AcPreGKFdMAGoxS/Ud+ Cxu/bonB0FqV0FX0/G6JiE68PYjWxUQi6aMJqwTDcHC7lYkFzs3yIREr2LgMwyKTil+eFLg X-Received: by 2002:a05:6a20:1eb0:b0:3c3:8c91:5da0 with SMTP id adf61e73a8af0-3cd4bbef78bmr2989189637.15.1787346708460; Fri, 21 Aug 2026 14:11:48 -0700 (PDT) Received: from iku.. ([2401:4900:1c07:194c:dba4:ea1e:d7d1:affe]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bf175399sm49755257eec.26.2026.08.21.14.11.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 14:11:48 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v6 09/17] rtc: rzn1: Use pm_runtime_put_sync() Date: Fri, 21 Aug 2026 22:10:24 +0100 Message-ID: <20260821211032.13554-10-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar pm_runtime_put() may trigger the idle check after pm_runtime_disable() is run as part of devm_pm_runtime_enable()'s cleanup action, leaving runtime PM active. Use pm_runtime_put_sync() to ensure the idle check runs synchronously. Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v5->v6: - Added Reviewed-by and Tested-by tags from Wolfram v4->v5: - Updated commit message - Moved the patch prior to the patch that replaces the .remove() callback with devm_add_action_or_reset()=20 v3->v4: - New patch --- drivers/rtc/rtc-rzn1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 12c52003a7dc..84ec8dc397e5 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -493,7 +493,7 @@ static int rzn1_rtc_probe(struct platform_device *pdev) return 0; =20 dis_runtime_pm: - pm_runtime_put(&pdev->dev); + pm_runtime_put_sync(&pdev->dev); =20 return ret; } @@ -505,7 +505,7 @@ static void rzn1_rtc_remove(struct platform_device *pde= v) /* Disable all interrupts */ writel(0, rtc->base + RZN1_RTC_CTL1); =20 - pm_runtime_put(&pdev->dev); + pm_runtime_put_sync(&pdev->dev); } =20 static const struct of_device_id rzn1_rtc_of_match[] =3D { --=20 2.43.0 From nobody Mon Sep 28 12:34:52 2026 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFFD3414DEE for ; Fri, 21 Aug 2026 21:11:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346717; cv=none; b=PA2rFLBKWo5Vj8HOeqs3x8dTacLgajYU6CjJJcZlk5ii95aEdaSsrQ6lP9QSGWm/Hsr0AEwoc8c/zY8iAaObUKx7tYhkUsK2D3xJDtCJucTXP+6VJX36iHj3Ek6hfxtZXKJsPp2ur6XhIffeTNB9woLxnWrLaW1VJOnro8RLIec= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346717; c=relaxed/simple; bh=d2UnVodaVm/N8lN47MQEhAtOqQObzsirhygSI9irOJM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aNeAxw/+j2zAoWBmqzQY27xhueijC9Oy6552HRqZCZF5nt9AJW5HQDZOSmWHHPNZybLlvGAnNoAKHsa8OKbH3E09ywKLSik1RaubxdG3H0e0xmlj/wJqE8jN//FGij2ShIO7K3bTdIrIhTWO2ph6x6xLYt03BIPee797FJ7l3Pg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b7tgj6cS; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b7tgj6cS" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-c998fd549a8so1114729a12.2 for ; Fri, 21 Aug 2026 14:11:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787346715; x=1787951515; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Os1dA2r+cmzBxD6OAoS0KdmNVaKSS6rJQ9hDdA7As9E=; b=b7tgj6cSuYFsr1UjVkQ7jii/OaDU5B6VZOPl1CUinsNF2FSrETN0vWxrYvEZfvvIv1 h2VqNL5qDze46v/JTZuhDGH6qAQnf3GwNyvoY/oZaVyvk4kT/dprZaD5McSWXXjKHXgg zT0jn+c9EquF4YnIxzfZKa2eieTEXimmCAP8BLDe/FauUJ1hrKf0EJZ9paoUznIp+Xz0 7gwwLf7/LTDKofGR1gD8LbE65KS1Nsrjxskp6BYDMSAhSMlJTPghc6eQXZuo/H+ecOVT 60g3jtggO5cY+2eZ/HPOEdb3Iyqiwxw5e9DS/59MMnc+FX94pmi319z4kMGjK3Pk3Alg 7hbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787346715; x=1787951515; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Os1dA2r+cmzBxD6OAoS0KdmNVaKSS6rJQ9hDdA7As9E=; b=W9WHx4W+xaeAP1+auo1OSzSLvoPbBjfr9aAqcrlJlJrTb2jirNrWKU/UJHKzTR9lOA 6RHa7gik/wRPCZuwmD7F7HH/hjKkK3KHh7RQsapGtIsIaNSo0u9o+Rl+fD9iSiJc9Fzt Rbqwn9aYJPM1PI8xxQ6c+Ot6kr2Nwf59c1UhuH1s7XVYSPFE5BktDkFrBJzSYB9MzzUp ZzD+t454BgigWYZJwF7hPhp7ghKd+AcnmbgnSrQ3p0sVIq4HRPxF3Zzz9EdcDH9ouflF hlbZVnnKAP5QrjaEliMfKA5yv2tM7ZsbjTVDbJcX7bvUWl5pFff8AgjBtC2RAOb2idXc mweg== X-Forwarded-Encrypted: i=1; AHgh+Ro9ENsfLT08rlUIpClH/wm/EJBDqLfqT7YUWKKF1nhqZxmHiiU76FpX1EdTCbqdEyeuqjaoCr8axEC+koU=@vger.kernel.org X-Gm-Message-State: AFuF++mod+YWHikeVcOn3BCZhoAU/tFO+t7HDhMr8CIVZewEr+qwlXs0 pEa76wjyZHARZ7KEgSvLqYuD1QGdc2PaO0KX3yaA0nWrkLXWBnfosMhG X-Gm-Gg: AR+sD123qfttIviibqJZwy9eJKmKpzc51QRN1THNuF99iLToDS2rl2BBd/Z1TM1Xh/D 4N05rbKZN4D+LZkko4GN60HA3T2sBTXqcXuYx6ChhOCrqg0Z1kdaZn0zvP7RU+FCMFEVZZXL8HW cBM06uhvsnNOvQFMX6o2p1Ni1JWsGxAkmXWhueZ1tBjm5J56rsCDLNqfygRzuxcCVYq9H7/u6LT HrfiA4Tza69/ql64e6Nzyqf8tpeiIoN7MfRzNMEuSGzbOj/HsUf8OcLkBgHWihHTIHsNLMp+ANB Xw4Yjshl/qB1TU4bmInph7BOD532s7pvzOr9+l1sPqn9UIAToKwbJ3Fc1Yxq7xiR+F2+BlwLL2T WwC/n0/d+QJLlhXU9sLdL3o50XJBmvp0hQHw43ZihA9HG6DQ0S19qOY/cX9gFkWxSu7YRcmaJkF LAjnuzCVhURL/vRcuyjD1IJXF5D7e4d48+6da8VpL4+6o4msInugBzfsORB0zqcqIcmzshezw8S 3UoVqlROQbpPkG3jh9sVTnN6/bpjuQ3A2ENgjSCm+1nqOwXspHw4J2OGhOqgXkcBF/VMB8+ X-Received: by 2002:a05:6a20:7f92:b0:3c4:1c9f:d81 with SMTP id adf61e73a8af0-3cd4ba456b5mr2824576637.7.1787346714895; Fri, 21 Aug 2026 14:11:54 -0700 (PDT) Received: from iku.. ([2401:4900:1c07:194c:dba4:ea1e:d7d1:affe]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bf175399sm49755257eec.26.2026.08.21.14.11.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 14:11:54 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v6 10/17] rtc: rzn1: Replace remove callback with devm_add_action_or_reset() Date: Fri, 21 Aug 2026 22:10:25 +0100 Message-ID: <20260821211032.13554-11-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Simplify the driver teardown by registering a managed cleanup action with devm_add_action_or_reset(). This eliminates the explicit probe error path and allows the .remove() callback to be dropped. Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v5->v6: - No changes. v4->v5: - Fixed conflict due to moving the pm_runtime_put_sync() patch prior to thi= s one. - Added Tested-by tag from Wolfram. v3->v4: - Added Reviewed-by tag from Wolfram. v2->v3: - New patch to replace the remove callback with devm_add_action_or_reset(). --- drivers/rtc/rtc-rzn1.c | 56 +++++++++++++++++------------------------- 1 file changed, 23 insertions(+), 33 deletions(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 84ec8dc397e5..f90785827945 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -385,6 +385,17 @@ static const struct rtc_class_ops rzn1_rtc_ops_scmp = =3D { .alarm_irq_enable =3D rzn1_rtc_alarm_irq_enable, }; =20 +static void rzn1_rtc_disable_hardware(void *data) +{ + struct device *dev =3D data; + struct rzn1_rtc *rtc =3D dev_get_drvdata(dev); + + /* Disable all interrupts */ + writel(0, rtc->base + RZN1_RTC_CTL1); + + pm_runtime_put_sync(dev); +} + static int rzn1_rtc_probe(struct platform_device *pdev) { struct rzn1_rtc *rtc; @@ -422,18 +433,19 @@ static int rzn1_rtc_probe(struct platform_device *pde= v) if (ret < 0) return ret; =20 + ret =3D devm_add_action_or_reset(&pdev->dev, rzn1_rtc_disable_hardware, &= pdev->dev); + if (ret) + return ret; + /* Only switch to scmp if we have an xtal clock with a valid rate and != =3D 32768 */ xtal =3D devm_clk_get_optional(&pdev->dev, "xtal"); if (IS_ERR(xtal)) { - ret =3D PTR_ERR(xtal); - goto dis_runtime_pm; + return PTR_ERR(xtal); } else if (xtal) { rate =3D clk_get_rate(xtal); =20 - if (rate < 32000 || rate > BIT(22)) { - ret =3D -EOPNOTSUPP; - goto dis_runtime_pm; - } + if (rate < 32000 || rate > BIT(22)) + return -EOPNOTSUPP; =20 if (rate !=3D 32768) scmp_val =3D RZN1_RTC_CTL0_SLSB_SCMP; @@ -446,7 +458,7 @@ static int rzn1_rtc_probe(struct platform_device *pdev) ret =3D readl_poll_timeout(rtc->base + RZN1_RTC_CTL0, val, !(val & RZN1_RTC_CTL0_CEST), 62, 123); if (ret) - goto dis_runtime_pm; + return ret; =20 /* Set desired modes leaving the controller disabled */ writel(RZN1_RTC_CTL0_AMPM | scmp_val, rtc->base + RZN1_RTC_CTL0); @@ -469,14 +481,12 @@ static int rzn1_rtc_probe(struct platform_device *pde= v) ret =3D devm_request_irq(&pdev->dev, irq, rzn1_rtc_alarm_irq, 0, "RZN1 RT= C Alarm", rtc); if (ret) { dev_err(&pdev->dev, "RTC alarm interrupt not available\n"); - goto dis_runtime_pm; + return ret; } =20 irq =3D platform_get_irq_byname_optional(pdev, "pps"); - if (irq =3D=3D -EPROBE_DEFER) { - ret =3D irq; - goto dis_runtime_pm; - } + if (irq =3D=3D -EPROBE_DEFER) + return irq; if (irq >=3D 0) ret =3D devm_request_irq(&pdev->dev, irq, rzn1_rtc_1s_irq, 0, "RZN1 RTC = 1s", rtc); =20 @@ -486,26 +496,7 @@ static int rzn1_rtc_probe(struct platform_device *pdev) dev_warn(&pdev->dev, "RTC pps interrupt not available. Alarm has only mi= nute accuracy\n"); } =20 - ret =3D devm_rtc_register_device(rtc->rtcdev); - if (ret) - goto dis_runtime_pm; - - return 0; - -dis_runtime_pm: - pm_runtime_put_sync(&pdev->dev); - - return ret; -} - -static void rzn1_rtc_remove(struct platform_device *pdev) -{ - struct rzn1_rtc *rtc =3D platform_get_drvdata(pdev); - - /* Disable all interrupts */ - writel(0, rtc->base + RZN1_RTC_CTL1); - - pm_runtime_put_sync(&pdev->dev); + return devm_rtc_register_device(rtc->rtcdev); } =20 static const struct of_device_id rzn1_rtc_of_match[] =3D { @@ -516,7 +507,6 @@ MODULE_DEVICE_TABLE(of, rzn1_rtc_of_match); =20 static struct platform_driver rzn1_rtc_driver =3D { .probe =3D rzn1_rtc_probe, - .remove =3D rzn1_rtc_remove, .driver =3D { .name =3D "rzn1-rtc", .of_match_table =3D rzn1_rtc_of_match, --=20 2.43.0 From nobody Mon Sep 28 12:34:52 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 842E33C6A5C for ; Fri, 21 Aug 2026 21:12:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346724; cv=none; b=kmuw2h6LXT/ZsY+i3fg2Er3DyZVuh3ZK0xAQ/04vDZOrlmhSIPmt/7MedWxUU2t5GyAqeyflNErVSmdnXNdJnsAys9A8YolOa5YpwwHDoD2+K2+ePuDt7RuZWF6H7KLWKRfqVKYV4X82Nb8IUqwYpLNNby5wfN85xPqZtgYapqk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346724; c=relaxed/simple; bh=s9BUVibUcdXFVsJInMHWm2yG1ceknFhn/TVwbVDtmuo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QH+RTKjf0db9tl17++X4+v9CXU+H9nG1WmBezZXP6HNi6fgkQEedqbYC+u40xlrOP+CtlvZ5fP1D96JKYUdodr4pVCNu9YPdIgo4XwMtYUvxIwAzjU16SNutWVBlG8KLMeC4Lo4zZT+RuL6Xlh1ExDLD0QjeM8decZNB3no7giE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dHOwoIrm; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dHOwoIrm" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2d01663d816so13377015ad.1 for ; Fri, 21 Aug 2026 14:12:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787346722; x=1787951522; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2RAGswYTmu3NrFU6zGdKpepBZD/bOxZ1HCrIvY615qE=; b=dHOwoIrmlrGbMeNqHKOy7Hq8R0UCxUm4IhQZvojRuxxl7hyFNqR0nOKtnCpzv0jJ5C qhYg/n59z4ClnNXgnPkXokJUYuj1YVjcIb9Xyb8tkSIfZdlTqBUTK7HjJfFWXpK1sxrU 2DaMi9gcycXcU8RYsVj2GfaxCTzbdiYeoF2yDypxMLg/b3X41Xo5qUSp6BtikFzbizBA vdEilnbI4pFxlxaA8umtmP2c29BrP3WjEecUN1JYbKEk+ilqHJ4fj1tqxjjeRPOW1+4J E1yIJO5TKzC9BYHo0xcgOSdhxUGzpseET8TRU0OmxNzEAUJ4cQ5IKxlqWhh1ausyTDs4 00Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787346722; x=1787951522; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=2RAGswYTmu3NrFU6zGdKpepBZD/bOxZ1HCrIvY615qE=; b=iqkusBMr/g/keXMMuES+cJhnWEh0o/dfxgeKcG7jkW2jg1YmB9OUNYmhCnJKlA8nZI jvpPgfqJwxEmEVJfpf6Tmx7QL2lJ0y5kuVXMyOdN+/iy5ZA/TUyfmNIJodWooIpS24EJ 3WhacCv8ImOhq0nPUMkkuvuTjhQJuzKJ4zHaVQQ+LryN8HFwAiwcTLkiI9lMnQ3gRATh U3lgW/sk1f3eYSOKCucpAZqA2Ma7NvN1S+Kvbzri3S2WEbhGRhcim002Dp1Zko3W1cVp e1w/HIDeMFwnUpCsNl837pFTBJ4z4AOcpqGpcizC+6ZVXO8Jz9xbhx+y4YULZ7G7KCFX x0JQ== X-Forwarded-Encrypted: i=1; AHgh+RoLxIkc8w+3VjgrgLgaf7aSau3eL7iphk5kv+mxp4COpYNGUPLUcBaVy8HgYE/9uFddycH+ETqM+Y+usfA=@vger.kernel.org X-Gm-Message-State: AFuF++nbe9IQtWcZUGOQGITbScp7d9QClQNjEdODhrjD3lkJ4rXq0DcN VSvmoxtH+KzGDRo+7NLlqX9mrLMmqeVuTHrvTHYOOgbT4o1lp/AhzKxO X-Gm-Gg: AR+sD11GGiU+NTZKqLJdHRBF0Q8jNC8JdG72sXd/pJk4Ye3PmldlE7KwVplpVgkm4/D XKN9ZaaUDaFu+ifxM1i9UmtrPN4sMRDbGZF7A91/3i6zL4NsC/uBotnAtaoq/7b1bZYsN+XKtgT 3kAFwF/9zYT2FzADweqW6NwvSiZCjPwxFGDSSF1FRgPzYejwRrYvf7Aqv15y5dQXSK/8zznxnoS W4qg+0KTqiA6SBhCZNh/+tNMfwl8mekp2MvhBFKdroQV4nCpmDaoE0ONquXwhkDTj4O7czWCBhP iZHc/xIaU4N8sU/MfCs7TVMSAauqwGrPhJ7M4WP8p8CjTXP9LITGMgM6LLtH59yCE+CpoJ8uXtl zpwhbXAJZlMeGPGjNm/mbtoq3Y5JYlZjQwlD+FTjDv3RVE++Ojpk0royKtSHx2Y665mzU4uAxYB blrJ9fv8QTBwND/1vqgxqHmdQIQGG7w4oXI/iRzQKArFHWCA7NBMTkZCCpUfSkne4uIu2iXR7S5 oPRev/2vIWHe0mhU2uzNxmQxpo4egI39YH9dVXU54FzVJHxvQnioqLiPXL6U3YXAWGoqbeAsd5u 9Oj4smo= X-Received: by 2002:a17:90b:3ec4:b0:381:528a:808c with SMTP id 98e67ed59e1d1-395c397c6ccmr14692155a91.12.1787346721862; Fri, 21 Aug 2026 14:12:01 -0700 (PDT) Received: from iku.. ([2401:4900:1c07:194c:dba4:ea1e:d7d1:affe]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bf175399sm49755257eec.26.2026.08.21.14.11.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 14:12:00 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v6 11/17] rtc: rzn1: Dynamically calculate synchronization delay based on clock rate Date: Fri, 21 Aug 2026 22:10:26 +0100 Message-ID: <20260821211032.13554-12-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Replace the hardcoded hardware synchronization delays with a calculated time window derived from the operating sub-clock frequency. The driver currently hardcodes microsecond ranges assuming a fixed sub-clock frequency of 32.768 kHz. Newer SoC variants, such as the RZ/T2H, drive this hardware block using a much faster clock rate (~195.3 kHz). Hardcoding these wait windows forces faster blocks to over-sleep, introducing unnecessary delays during clock initialization and register configuration. Calculate the duration of the required clock cycles in microseconds based on the runtime clock rate, and store this value in the driver private structure to adjust the usleep_range() and readl_poll_timeout() boundaries dynamically. Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v5->v6: - No change. v4->v5: - Added Reviewed-by and Tested-by tags from Wolfram. v3->v4: - Shortened the comment describing the calculation of RTC_PCLK. - Updated usleep_range() value to use 2 * rtc->sync_time. v2->v3: - No changes. v1->v2: - Initialized rate variable to 32768 to avoid timeout_us of 0. --- drivers/rtc/rtc-rzn1.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index f90785827945..4e62f7bc2e34 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -70,6 +70,7 @@ struct rzn1_rtc { */ spinlock_t ctl1_access_lock; struct rtc_time tm_alarm; + unsigned long sync_time; }; =20 static void rzn1_rtc_get_time_snapshot(struct rzn1_rtc *rtc, struct rtc_ti= me *tm) @@ -120,8 +121,8 @@ static int rzn1_rtc_set_time(struct device *dev, struct= rtc_time *tm) /* Hold the counter if it was counting up */ writel(RZN1_RTC_CTL2_WAIT, rtc->base + RZN1_RTC_CTL2); =20 - /* Wait for the counter to stop: two 32k clock cycles */ - usleep_range(61, 100); + /* Wait 2-4 RTC_PCLK clock cycles for the counter to stop */ + usleep_range(rtc->sync_time, rtc->sync_time * 2); ret =3D readl_poll_timeout(rtc->base + RZN1_RTC_CTL2, val, val & RZN1_RTC_CTL2_WST, 0, 100); if (ret) @@ -398,10 +399,10 @@ static void rzn1_rtc_disable_hardware(void *data) =20 static int rzn1_rtc_probe(struct platform_device *pdev) { + unsigned long rate =3D 32768; struct rzn1_rtc *rtc; u32 val, scmp_val =3D 0; struct clk *xtal; - unsigned long rate; int irq, ret; =20 rtc =3D devm_kzalloc(&pdev->dev, sizeof(*rtc), GFP_KERNEL); @@ -451,12 +452,16 @@ static int rzn1_rtc_probe(struct platform_device *pde= v) scmp_val =3D RZN1_RTC_CTL0_SLSB_SCMP; } =20 + /* Calculate the duration of two RTC_PCLK clock cycles */ + rtc->sync_time =3D DIV_ROUND_UP(2 * USEC_PER_SEC, rate); + /* Disable controller during SUBU/SCMP setup */ val =3D readl(rtc->base + RZN1_RTC_CTL0) & ~RZN1_RTC_CTL0_CE; writel(val, rtc->base + RZN1_RTC_CTL0); - /* Wait 2-4 32k clock cycles for the disabled controller */ + /* Wait 2-4 RTC_PCLK clock cycles for the disabled controller to stop */ ret =3D readl_poll_timeout(rtc->base + RZN1_RTC_CTL0, val, - !(val & RZN1_RTC_CTL0_CEST), 62, 123); + !(val & RZN1_RTC_CTL0_CEST), rtc->sync_time, + rtc->sync_time * 2); if (ret) return ret; =20 --=20 2.43.0 From nobody Mon Sep 28 12:34:52 2026 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8CDA4156ED for ; Fri, 21 Aug 2026 21:12:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346731; cv=none; b=oC3gr49LyWDNxdRWTD5fTHjTRy+yjfU/I2LFKPmEzcnv9NI8YhRxe0V1Opde34irswZxnhDdnTNW5uFaBq1yOI6+ItWOBNnGjfttszMwFwdluRuCvBg4lnp6fM9/F1BoTkFpCTVWcrh1GSs/zGkdn548KL57EOwR67lUNmFtUH4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346731; c=relaxed/simple; bh=NGzA0VQ/OCeDwBZt1QE+AIRvAaTUIuyro5ezBJUttkg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=moAxpDBvR0fY6ZXxBJVVibb17pxRm7cbFkcZ3q0R5y6cQPgQmH/+h356621xoOYpj99t0sPSaAeLrE3h24q00A90GJrEgk2mlfXoZx+Z5Sji+2ThfRJ5NI6YinDypepJlPDr/gJ2WYeIgCXyL2vGocv3EhHfzWBIpdJ/qp6X+uY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TXbJov1f; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TXbJov1f" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-c9b373d5af0so1144384a12.2 for ; Fri, 21 Aug 2026 14:12:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787346729; x=1787951529; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5nOxAjAbSX3AphlP3iCgTjG48U+KGU7cBosPA522YNg=; b=TXbJov1fkALBPANHyxTxvVLwWj3J5GU2vInRSqT1MaeW6ERZbby03pWPoqlNGzZ1xd ttQmPDwz2ma69iiY5VJqC/gsHoSz/6ZTHiHTti6qlOVg6pf//SvyPQVR1RdseSEgBsEn QPcU1UZwV4zp+06UeZflaDNNxQ/d8fI/liJYv7jm3OUSYTYL3eYg7sPY8jZ+LQNWQWsF cftOIAl8LHpgWdQjSsfTUNTUURnCPAeYERypwD1SkmUdQMBQo7BIP59thdBbRV3ObkAi hyGpJjzfvXKJGvbZdcw5qNjwGJVewp1WBhidBf92xfPOm7n42LeWptBXb+eFh0PXL+lO 62TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787346729; x=1787951529; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=5nOxAjAbSX3AphlP3iCgTjG48U+KGU7cBosPA522YNg=; b=YQidQc4RhTKo3JLsG0JEA+bQEjHYPiJtX0kLz8pEytwFkENyJQWRDo7AJ61oGJKFVm 5xoFhr9jxG5/s7C8qqedTMHK0dLSsRfszjgJCTKbXqHrmAvOuprijHw8Ctj0lfrOa8yS dGjgfgHb00eDlnhxVV3VAs26m42X8s0A5BPhLDcu8J+5vwiRhpILTgguAqo2w1h/BAly ES0WFSpIUbiV4uCLEoVK2vrc4/HoALCXucIQ2AvbvfJKBTYe9SCv823CIsYyVGOhpo8b dOD5r0M4sjU2CLU179wxnhQOau+0W/tHZjaNxNlS/d9sU+eZXUEk7Wbj5Esa3F/WawHQ Er5A== X-Forwarded-Encrypted: i=1; AHgh+RrV19R3rSo1i3Ya5kwzGmhEk2DcYCRTvgPURR5HjsSJKqKAbTailDRtvgCaM1GUDmmxKu1WRE5TvwgmLuI=@vger.kernel.org X-Gm-Message-State: AFuF++mAqOrYGNJRsa++dOXuiMGlbmwvNNKSrz2dnBEJ6oDulJYNCSUv 3fPJ1oKTZsdQKlkrU7HSafQ33D1t0GPCYj2v98yPe3hItr+BfIk4KVUj X-Gm-Gg: AR+sD11nTFFLHrUmIXOxui/FDat/A/CWhuJlCc9V62t8wP75RXjJGr4vPLMU2jdtkIF ZT1l9EtEouKg7R4J8G6oCak9nQO+TWalCEfxlkD9bpPtRGzm3jPqaF0kYyCM2B1o1L73OxVEH2m 5A+vu66pHiVaEddhnVClSH95UiD2riPWCEWXlLk8GmnL0vaFCaeU7fjhgCuLVCfqus0qDj9jfdl W/0eyDfkwC+3+YEjsfYR82jjaY0b3AhHfgbNNLGHVsZtNciOtjBEL3gj7grxNRJG4RMg3zlNk03 uhYkoi4DqVIrVK3S8F96R+grwsKwqO5RH0xNDigWVduTE29ec/XtXY8bKpUeUDWyf3tXbaeg6n+ SrqakAr5mjPP4VuLdcEg6Td315ykH/jcO+vqAUtUzA72zeWSRi3p00xifgaKEeF4ZzavXBnKKHM yRVMTBvlgb2ij8mM6jZINZPlk0vB3xyrS8WzlMzZ8WvBDOQD/ZwZ+Zxhk+XAJPITKo0e/ioZErS CZZBtM60usEXd06d3C+cdT7vdhHixJtwyOUpYVAc8vgiXeP09zz34y4JcwBs5ezCHbXY2Yc X-Received: by 2002:a05:6a21:168c:b0:3c4:3321:4fe8 with SMTP id adf61e73a8af0-3cd4bbe89c6mr3227466637.14.1787346729187; Fri, 21 Aug 2026 14:12:09 -0700 (PDT) Received: from iku.. ([2401:4900:1c07:194c:dba4:ea1e:d7d1:affe]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bf175399sm49755257eec.26.2026.08.21.14.12.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 14:12:08 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v6 12/17] rtc: rzn1: Use temporary variable for struct device Date: Fri, 21 Aug 2026 22:10:27 +0100 Message-ID: <20260821211032.13554-13-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Use a temporary variable for the struct device pointers to avoid dereferencing. Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v5->v6: - No change v4->v5: - Added Tested-by tag from Wolfram. v3->v4: - No changes. v2->v3: - No changes. v1->v2: - Added Reviewed-by tag. --- drivers/rtc/rtc-rzn1.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 4e62f7bc2e34..7598efc31e09 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -399,13 +399,14 @@ static void rzn1_rtc_disable_hardware(void *data) =20 static int rzn1_rtc_probe(struct platform_device *pdev) { + struct device *dev =3D &pdev->dev; unsigned long rate =3D 32768; struct rzn1_rtc *rtc; u32 val, scmp_val =3D 0; struct clk *xtal; int irq, ret; =20 - rtc =3D devm_kzalloc(&pdev->dev, sizeof(*rtc), GFP_KERNEL); + rtc =3D devm_kzalloc(dev, sizeof(*rtc), GFP_KERNEL); if (!rtc) return -ENOMEM; =20 @@ -413,13 +414,13 @@ static int rzn1_rtc_probe(struct platform_device *pde= v) =20 rtc->base =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(rtc->base)) - return dev_err_probe(&pdev->dev, PTR_ERR(rtc->base), "Missing reg\n"); + return dev_err_probe(dev, PTR_ERR(rtc->base), "Missing reg\n"); =20 irq =3D platform_get_irq_byname(pdev, "alarm"); if (irq < 0) return irq; =20 - rtc->rtcdev =3D devm_rtc_allocate_device(&pdev->dev); + rtc->rtcdev =3D devm_rtc_allocate_device(dev); if (IS_ERR(rtc->rtcdev)) return PTR_ERR(rtc->rtcdev); =20 @@ -427,19 +428,19 @@ static int rzn1_rtc_probe(struct platform_device *pde= v) rtc->rtcdev->range_max =3D RTC_TIMESTAMP_END_2099; rtc->rtcdev->alarm_offset_max =3D 7 * 86400; =20 - ret =3D devm_pm_runtime_enable(&pdev->dev); + ret =3D devm_pm_runtime_enable(dev); if (ret < 0) return ret; - ret =3D pm_runtime_resume_and_get(&pdev->dev); + ret =3D pm_runtime_resume_and_get(dev); if (ret < 0) return ret; =20 - ret =3D devm_add_action_or_reset(&pdev->dev, rzn1_rtc_disable_hardware, &= pdev->dev); + ret =3D devm_add_action_or_reset(dev, rzn1_rtc_disable_hardware, dev); if (ret) return ret; =20 /* Only switch to scmp if we have an xtal clock with a valid rate and != =3D 32768 */ - xtal =3D devm_clk_get_optional(&pdev->dev, "xtal"); + xtal =3D devm_clk_get_optional(dev, "xtal"); if (IS_ERR(xtal)) { return PTR_ERR(xtal); } else if (xtal) { @@ -483,9 +484,9 @@ static int rzn1_rtc_probe(struct platform_device *pdev) =20 spin_lock_init(&rtc->ctl1_access_lock); =20 - ret =3D devm_request_irq(&pdev->dev, irq, rzn1_rtc_alarm_irq, 0, "RZN1 RT= C Alarm", rtc); + ret =3D devm_request_irq(dev, irq, rzn1_rtc_alarm_irq, 0, "RZN1 RTC Alarm= ", rtc); if (ret) { - dev_err(&pdev->dev, "RTC alarm interrupt not available\n"); + dev_err(dev, "RTC alarm interrupt not available\n"); return ret; } =20 @@ -493,12 +494,12 @@ static int rzn1_rtc_probe(struct platform_device *pde= v) if (irq =3D=3D -EPROBE_DEFER) return irq; if (irq >=3D 0) - ret =3D devm_request_irq(&pdev->dev, irq, rzn1_rtc_1s_irq, 0, "RZN1 RTC = 1s", rtc); + ret =3D devm_request_irq(dev, irq, rzn1_rtc_1s_irq, 0, "RZN1 RTC 1s", rt= c); =20 if (irq < 0 || ret) { set_bit(RTC_FEATURE_ALARM_RES_MINUTE, rtc->rtcdev->features); clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, rtc->rtcdev->features); - dev_warn(&pdev->dev, "RTC pps interrupt not available. Alarm has only mi= nute accuracy\n"); + dev_warn(dev, "RTC pps interrupt not available. Alarm has only minute ac= curacy\n"); } =20 return devm_rtc_register_device(rtc->rtcdev); --=20 2.43.0 From nobody Mon Sep 28 12:34:52 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 620EF414A21 for ; Fri, 21 Aug 2026 21:12:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346738; cv=none; b=olICfzdHRsNCgPKLqPnnK1ZBgGFvikIs3Azx9ujNlK4ZDh9ptXqX29N1WXwr9Gar23bUZIN6jQ/UtQHVsVURK44avx3gE2znoAO+YKbfmrxB6SSOhYB/R6p+LRmoL8IXTK8cQziY+7g2nk7bsHvJVhzdeX4pDKG8pfA32Z4dU6Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346738; c=relaxed/simple; bh=bqLMPVulyGO3uPN192UU8p/Ih7Y6Dwy6WAN72JRYMms=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mqLHR/kisFJrtVebh84wLK+r+eyomS1vSJgAyHt4DOZgTUgNRpl8lsWqaROw1GfPBazprMGOOoCt8msev5zXEkPgnfdatwHQHfDgz/XIFDrL99ioRp5lZCp5N+k3RX3TKzsi7y8g4H93edW+BBTpCe/QX3f0+GPTEcGJAUZVOhc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NtMVtVPp; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NtMVtVPp" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2cca0c5799eso13924845ad.0 for ; Fri, 21 Aug 2026 14:12:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787346736; x=1787951536; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VufRgxSYxCIl2Jf8aNb9F7AHOcOxi7eWJscZy8FNEAY=; b=NtMVtVPpv6sFBmmpadwMhaDkNClKtuRnsUWJCPTpRdcO7aI43sjb9LBnfz0ZgQs3Y/ 9xitwiV7e+ygIMZ+RUQzv6nXq2ZMiI+19j3W5opcspf7gTZWn5HR6qI160amrqH+IiOV zkijTG4EAcLnzfjCg6H562c7CPstvOJAQfeCiu+mBmRYB8Y15E+P7JX+F44OTaeb+tO+ ydFFc2QTd3GxZYV92tOqTd5lKto3vG2E4p3S/xEutS++m69Q686qLsWhWoehpHyMwRCG H8MkhzyltAAup5Xu+lPQtGcUIKTLIjkN+aweTkyzoIOncH08gUlk0vaqxzmc7pFVLP0u 8hgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787346736; x=1787951536; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=VufRgxSYxCIl2Jf8aNb9F7AHOcOxi7eWJscZy8FNEAY=; b=dlaucE47wibmkOOTbO/X9ne7SyHObaltcqRH34oMu2vbeXF0owveRY2BLpoJwpk2j9 jMzESQdhDumlyH2jubqE5L2FgGqS733LD39fZDt9QMefv9WVdBD13JHLJ4S6QwoTEQrb v9CQLlhzQh8D1iOpcDfG4zVEcyypOJo91Ugr/Dk21zp67UFgFGjEZT/NsFu4MwEduAbP 1S5ncs5+Z3LQIHT4MzmibaYhQE8BnszIJPQKs5KlpqQW0xhHV4B5nK9jApdNHFVS5wHY yOJrtfv6smqvfzPVbyHM3MSBeujXwlgafGdlEA7baGSY17jcWYcM3QTION7KvLc3gMGZ cztQ== X-Forwarded-Encrypted: i=1; AHgh+RrxepdRRR0dNcqXnXR5+2sU/VOlx9jabsG/3RvSJJfLC5f8Q/HpztQ4J9zXvirTWRBJnOykFfztr8O9M7g=@vger.kernel.org X-Gm-Message-State: AFuF++mCHgnouFkhFK6HN5EZu/3gDaUmWev+s16wRi93F2SeSl8fMfV0 7OdAmZvfKaEXwdzs5oRAvL8dwPEXrUSxfXBvJ6+ahvYrTuAkpPdNlPQq X-Gm-Gg: AR+sD13/+k8Tgqo2OnLqyjTHKgZ7yVT9qlc9yrvl12wZsnhLYElx6Whls6Dn3AUrTxF BiAHo+R87CgkJw/LnnBnIGmu0GGNPPOM4kUfUieT3UsutFN4b8khpSpXR4yUAhGdMjrw2HQztR6 JEGur0ynb1aHnM4fEtFMUNtB+eLUBn5K0V2PBLxXv8cqQysuEyLpje1cUzjGYk75Q9dUZO6WghC ChbAUa4RAnLEG6FV/QBi84RnCRq/eQac9Fy9oTbQyeBz4TbtuVagHl7ajPf6VECXXo86QAahhvZ tzdv8FVlE2hIcYYy0C2aNnlvIdREujkPLNwUqWxgNBYw5V+uSeJ0sg5E6oHK16SdMKSymdXXgvs Vf/jb4ARCHvI1TrSQSUFggKk3R+iktTkHS9Fkex36kS3idF4UGn/Y/L+3UJ8PxjRBB/35B8imfK LuHZem4Bfed+nTLE7luvQbxHr1q6MeuhYQf6Cmy/hOVMXyDnfhrFpiUFV9SA9VxqOzTUoXnhSaB m6Kn8DrKDQRAgaHCl76G0dATE0Kim7BSZZaHJKQPAyZxjEkZlTe48kDVXrA+GQp0NJ21BPj X-Received: by 2002:a17:903:1a30:b0:2d3:160b:c01f with SMTP id d9443c01a7336-2d64adce8e3mr179152855ad.6.1787346735900; Fri, 21 Aug 2026 14:12:15 -0700 (PDT) Received: from iku.. ([2401:4900:1c07:194c:dba4:ea1e:d7d1:affe]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bf175399sm49755257eec.26.2026.08.21.14.12.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 14:12:15 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v6 13/17] rtc: rzn1: Consistently use dev_err_probe() Date: Fri, 21 Aug 2026 22:10:28 +0100 Message-ID: <20260821211032.13554-14-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Use dev_err_probe() in the IRQ request error path to make error handling consistent with the rest of rzn1_rtc_probe(). Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v5->v6: - No change v4->v5: - Added Tested-by tag from Wolfram. v3->v4: - No changes. v2->v3: - No changes. v1->v2: - Added Reviewed-by tags. --- drivers/rtc/rtc-rzn1.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 7598efc31e09..9fc93afee1e5 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -485,10 +485,8 @@ static int rzn1_rtc_probe(struct platform_device *pdev) spin_lock_init(&rtc->ctl1_access_lock); =20 ret =3D devm_request_irq(dev, irq, rzn1_rtc_alarm_irq, 0, "RZN1 RTC Alarm= ", rtc); - if (ret) { - dev_err(dev, "RTC alarm interrupt not available\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "RTC alarm interrupt not available\n"); =20 irq =3D platform_get_irq_byname_optional(pdev, "pps"); if (irq =3D=3D -EPROBE_DEFER) --=20 2.43.0 From nobody Mon Sep 28 12:34:52 2026 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 529D6414A21 for ; Fri, 21 Aug 2026 21:12:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346746; cv=none; b=ZD0AnPl3ZlCmrE8Rk283xjisymjPkLGLKlvHLdTAGLGJ8+LqviObuKR0jtuuvy5ofFLt1tz3lshpzOun4QFDxXkhqs3M97zuD9FMmROqb7QwqG+Xogp5UNJpISJijg6yVo7hu3HpN/be3txifhfHAHqetwyxNaoeRVsaF6GFXlQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346746; c=relaxed/simple; bh=kp0XQgrlKVOiCLMcJ6To99Zr2GXCqqLHe0FU78FVMEc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=W2pfPS469ZAPJg6Xy5cm9VUSglouKvFCCYQYoRCzBw1sd5cfQp3MLV6k6sdiabgjvnCnPmV7qabXJWZDzYMl/eP0PTFf58QyVYcGRfhbh1AfV8mIQ6+gDwnKtcSST8rEFPMQewWJl7WR64xYm2a9+mHI4DnnVDkH54Mjaq/La2Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I9orZ8me; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I9orZ8me" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-8518d5ddaabso1128707b3a.2 for ; Fri, 21 Aug 2026 14:12:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787346743; x=1787951543; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZaUWtPTrtueUn4WNcW3dNefbXmXkUwCgtLqgcO6NO5U=; b=I9orZ8meI/WEodCIPLys4xKzDWV2ggBtDQ7IT4gtdru7uB+YvAE/fl4rIQcryjazMg KjsDzNfzty+kAIwU9Cr1iXAfUueVMfvDlgCQuxobDWmSGldIMC8x6CrTwF0jc4nXivuf F0122ySdE3FEvQrDb0A22YaRnpaUOsbPEqphsbJT/VXmjAflvsRAhJEU1DEFjWQBbeHd 22gpEMTKQdihRLzNxdwu0Z9qo8quplKFUxrkohxe7hPG8AmUCwyhxF/WJSWJ3jS5f7JT Qgolple6i5phJoqRS83MLQQTYPvHbFCx5GeU3g+4Q85mzYWUU6NMW7ldsufTcdGanmv6 VaXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787346743; x=1787951543; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ZaUWtPTrtueUn4WNcW3dNefbXmXkUwCgtLqgcO6NO5U=; b=pvHPYdAI/572gv/GBeX0kitzBmQDzZO6qFOfp+a7ZXSs9YGd1pynssjawqDpm7oHfP a3PYcMgd7/cXb7fKRCQ+BndmxONB1VTYsvUJD717f4vFT4O29x8dASps/YvCMfNFzUDp uI8nrsfy0ghd1eSxeWEkpqgDz4QFmbYVR4T1aC0CaYVPuS4pJIG/BVX7uUBmizuH4B7T Fbl/Hf1UjW1qUPDmredgeMPxZZa4sZ1uqJq6EybYSlxUg0mGb/oTPJg8iT2DhQEnfGE9 tfCa+j4TQLvzLZ+xBR2ToK5k02aWJL6iop+NwiLVtKK3uwDoaYcRUwjQk4mpOdj920Oa 0sEA== X-Forwarded-Encrypted: i=1; AHgh+RoXfq7fKKVHRmyWmMT2R+EE4fPAq1eGQC/vZIFE3OhTpeO2y2VxPa7sI4G/mavL9t5uVPHNFU4K7pDS1bs=@vger.kernel.org X-Gm-Message-State: AFuF++nV7yi+5SA87UKrSxcnOrK7ylq3i98n9kqXQKiUIOoi3LAhMYtL FBnEdD/EbeJc+3A6GzMpD7TGYBNGseONG2zUM5C2L00W0CfB8CAFCIKw X-Gm-Gg: AR+sD1359cyjqrLZyhFjgLlGRv0gVf0mJvd/YzL+WBM1wM0p2DxG+LHIZ1n4i/AFvFD +tkq7BvpicKZ1OrvCq4nwamKcB347RPLMpzNl57k5/Asw6NTeyW/3VO3SqlPP0UdQ2XbIOfYY4k BzAtxLa0bmxWgB2zeJVSTrX3giFZnZQyyjKKonFBCG0EXJcn1Zw4b8vrPEYFvMBT82S9a3Q2kwV qXmzvlnN7gzqpxqFzPpjIgWm+E4HtCUisOBcDeWEKrb2EC3WNwdt54MsRZn1BIp3xS5E+LDXqH9 A++7ZNJj3IQHCWNA8lXVIczJcNTNV6Ui0FBIRyYycfIgsEkuFyYXvzTZHa1DkVCj3Rt9lWEJzdM 9Vf81KNB2EYCXKhVnmC5PHVG540MJJdI94UbOjnMgy2VfuX74Y2OMVUMYCZ/9yzy/8Wuypjb6Ku mttkLrzu1yMe2f7TuwFw84PcwIE3RwvP8wLFhdiUQ1kf/TxUGSrXrPznDP+4+1IOyRWG3Gb5IP6 02wjQgxEHUcNGydUIompfFqS3SLram+f7trEYm4C0GsZJt9kLFxHZloXxnVHaZxkxhCbHbL X-Received: by 2002:a05:6a21:1fc8:b0:3cc:9316:cad3 with SMTP id adf61e73a8af0-3cd2fa367c0mr19094132637.0.1787346743522; Fri, 21 Aug 2026 14:12:23 -0700 (PDT) Received: from iku.. ([2401:4900:1c07:194c:dba4:ea1e:d7d1:affe]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bf175399sm49755257eec.26.2026.08.21.14.12.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 14:12:22 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v6 14/17] rtc: rzn1: use FIELD_PREP/FIELD_GET and GENMASK for register access Date: Fri, 21 Aug 2026 22:10:29 +0100 Message-ID: <20260821211032.13554-15-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Replace open-coded shift and mask operations with the bitfield API. Note that the weekday field is changed from an explicit 0x0f mask to an 8-bit field definition, matching the hardware manual. This does not change behaviour, as valid weekday values cannot exceed 7. Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v5->v6: - No change v4->v5: - Added Tested-by tag from Wolfram. v3->v4: - Added RB tag from Wolfram v2->v3: - No changes. v1->v2: - Made use of RZN1_RTC_SUBU_RTCA0FX mask for SUBU register access instead of 0x3F. --- drivers/rtc/rtc-rzn1.c | 50 +++++++++++++++++++++++------------------- 1 file changed, 28 insertions(+), 22 deletions(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 9fc93afee1e5..33c7ef5c1eba 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -12,6 +12,8 @@ */ =20 #include +#include +#include #include #include #include @@ -39,14 +41,18 @@ #define RZN1_RTC_CTL2_STOPPED (RZN1_RTC_CTL2_WAIT | RZN1_RTC_CTL2_WST) =20 #define RZN1_RTC_TIME 0x30 -#define RZN1_RTC_TIME_MIN_SHIFT 8 -#define RZN1_RTC_TIME_HOUR_SHIFT 16 +#define RZN1_RTC_TIME_SEC GENMASK(7, 0) +#define RZN1_RTC_TIME_MIN GENMASK(15, 8) +#define RZN1_RTC_TIME_HOUR GENMASK(23, 16) + #define RZN1_RTC_CAL 0x34 -#define RZN1_RTC_CAL_DAY_SHIFT 8 -#define RZN1_RTC_CAL_MON_SHIFT 16 -#define RZN1_RTC_CAL_YEAR_SHIFT 24 +#define RZN1_RTC_CAL_WDAY GENMASK(7, 0) +#define RZN1_RTC_CAL_DAY GENMASK(15, 8) +#define RZN1_RTC_CAL_MON GENMASK(23, 16) +#define RZN1_RTC_CAL_YEAR GENMASK(31, 24) =20 #define RZN1_RTC_SUBU 0x38 +#define RZN1_RTC_SUBU_RTCA0FX GENMASK(5, 0) #define RZN1_RTC_SUBU_DEV BIT(7) #define RZN1_RTC_SUBU_DECR BIT(6) =20 @@ -78,15 +84,15 @@ static void rzn1_rtc_get_time_snapshot(struct rzn1_rtc = *rtc, struct rtc_time *tm u32 val; =20 val =3D readl(rtc->base + RZN1_RTC_TIMEC); - tm->tm_sec =3D bcd2bin(val); - tm->tm_min =3D bcd2bin(val >> RZN1_RTC_TIME_MIN_SHIFT); - tm->tm_hour =3D bcd2bin(val >> RZN1_RTC_TIME_HOUR_SHIFT); + tm->tm_sec =3D bcd2bin(FIELD_GET(RZN1_RTC_TIME_SEC, val)); + tm->tm_min =3D bcd2bin(FIELD_GET(RZN1_RTC_TIME_MIN, val)); + tm->tm_hour =3D bcd2bin(FIELD_GET(RZN1_RTC_TIME_HOUR, val)); =20 val =3D readl(rtc->base + RZN1_RTC_CALC); - tm->tm_wday =3D val & 0x0f; - tm->tm_mday =3D bcd2bin(val >> RZN1_RTC_CAL_DAY_SHIFT); - tm->tm_mon =3D bcd2bin(val >> RZN1_RTC_CAL_MON_SHIFT) - 1; - tm->tm_year =3D bcd2bin(val >> RZN1_RTC_CAL_YEAR_SHIFT) + 100; + tm->tm_wday =3D FIELD_GET(RZN1_RTC_CAL_WDAY, val); + tm->tm_mday =3D bcd2bin(FIELD_GET(RZN1_RTC_CAL_DAY, val)); + tm->tm_mon =3D bcd2bin(FIELD_GET(RZN1_RTC_CAL_MON, val)) - 1; + tm->tm_year =3D bcd2bin(FIELD_GET(RZN1_RTC_CAL_YEAR, val)) + 100; } =20 static int rzn1_rtc_read_time(struct device *dev, struct rtc_time *tm) @@ -129,15 +135,15 @@ static int rzn1_rtc_set_time(struct device *dev, stru= ct rtc_time *tm) return ret; } =20 - val =3D bin2bcd(tm->tm_sec); - val |=3D bin2bcd(tm->tm_min) << RZN1_RTC_TIME_MIN_SHIFT; - val |=3D bin2bcd(tm->tm_hour) << RZN1_RTC_TIME_HOUR_SHIFT; + val =3D FIELD_PREP(RZN1_RTC_TIME_SEC, bin2bcd(tm->tm_sec)) | + FIELD_PREP(RZN1_RTC_TIME_MIN, bin2bcd(tm->tm_min)) | + FIELD_PREP(RZN1_RTC_TIME_HOUR, bin2bcd(tm->tm_hour)); writel(val, rtc->base + RZN1_RTC_TIME); =20 - val =3D tm->tm_wday; - val |=3D bin2bcd(tm->tm_mday) << RZN1_RTC_CAL_DAY_SHIFT; - val |=3D bin2bcd(tm->tm_mon + 1) << RZN1_RTC_CAL_MON_SHIFT; - val |=3D bin2bcd(tm->tm_year - 100) << RZN1_RTC_CAL_YEAR_SHIFT; + val =3D FIELD_PREP(RZN1_RTC_CAL_WDAY, tm->tm_wday) | + FIELD_PREP(RZN1_RTC_CAL_DAY, bin2bcd(tm->tm_mday)) | + FIELD_PREP(RZN1_RTC_CAL_MON, bin2bcd(tm->tm_mon + 1)) | + FIELD_PREP(RZN1_RTC_CAL_YEAR, bin2bcd(tm->tm_year - 100)); writel(val, rtc->base + RZN1_RTC_CAL); =20 writel(0, rtc->base + RZN1_RTC_CTL2); @@ -308,12 +314,12 @@ static int rzn1_rtc_read_offset(struct device *dev, l= ong *offset) val =3D readl(rtc->base + RZN1_RTC_SUBU); ppb_per_step =3D val & RZN1_RTC_SUBU_DEV ? 1017 : 3051; subtract =3D val & RZN1_RTC_SUBU_DECR; - val &=3D 0x3F; + val =3D FIELD_GET(RZN1_RTC_SUBU_RTCA0FX, val); =20 if (!val) *offset =3D 0; else if (subtract) - *offset =3D -(((~val) & 0x3F) + 1) * ppb_per_step; + *offset =3D -(((~val) & RZN1_RTC_SUBU_RTCA0FX) + 1) * ppb_per_step; else *offset =3D (val - 1) * ppb_per_step; =20 @@ -355,7 +361,7 @@ static int rzn1_rtc_set_offset(struct device *dev, long= offset) subu |=3D steps + 1; } else { subu |=3D RZN1_RTC_SUBU_DECR; - subu |=3D (~(-steps - 1)) & 0x3F; + subu |=3D (~(-steps - 1)) & RZN1_RTC_SUBU_RTCA0FX; } =20 ret =3D readl_poll_timeout(rtc->base + RZN1_RTC_CTL2, ctl2, --=20 2.43.0 From nobody Mon Sep 28 12:34:52 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 622F5419304 for ; Fri, 21 Aug 2026 21:12:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346751; cv=none; b=cDeOJVH/rOvm/AKlWI0sSVlpEdzCIlTwJotrNSfyS7lsg/BVF+JUcxfQE4MWC9VrhKs+azN/lNFMFp34NlX3NrV3qmtnSNEwwrb8vNmjdOcAuTLD3Lor6x7ABiytTMyarCgjsPmERiuq8qC6WodhHwJO+UQXaXxbHqwOG+k9sds= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346751; c=relaxed/simple; bh=yBObii33XQtUMDVLhg3tSMOFUhkADs9/f6LHaLvE8qs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fZbqy6D+8OqMMgvjZSJbL68/L9Ls6GbRIdLyVgUYNci+6R0fksPwacoApdUn3TWcJWl52ZYRnk4nN/cRLtfXgfxtpCkELW/yrxXmuS6CtLUd8k0A7JayBJ/YfIrnGiiLEPMZr+Lad3a5PRdFbWi576oEIXfYZPDjovawsTLP+48= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ca2NyiPH; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ca2NyiPH" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2d5655cc850so18557215ad.3 for ; Fri, 21 Aug 2026 14:12:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787346750; x=1787951550; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fF5C2lxgka8/ldFjOYo/eP0wFxrYBeqRPIw1nyxaOJ8=; b=ca2NyiPHpK5c1eh75RVL34aHtY3cfEZhhklEXCbFt2HrTOz1/YKJm4PGh6yN12dRbd aKXQvcxEJmTQogVGwU3OlT4UA8FsHTqAhi5bhumVYFHIZ3m9ekcSqxj/dKUJwXCuhPKp pFz2QMiA7t5hdjkELVwDgpbm/ShZ9A0F7bJRkt5I5TmErXCfjnrBk1EslpqR1SIFZ4HO iv2pKG656ML3/uHCP+ZVa13Io0XzZqSGIxpWJ6Ody+DD+S04Zz+q1QrMpxKEfcwwSnvA iuKZVhqBnAr5+hIQAYNOzb2t3anP/dwKNet7th8mKhZ620ijoB9tJRp75//WNknA/el8 h70A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787346750; x=1787951550; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=fF5C2lxgka8/ldFjOYo/eP0wFxrYBeqRPIw1nyxaOJ8=; b=oL0WI8UFJmvNGcNUMTHyXSX/i0pC2+b6PQxAgVnziNTXl0rDHSBYExrqjB0YLcC+62 T9/m6503fXfnCqCELmGJdMAWP0XrxS70f7Jbvd/ogDCdQm8dB2OcuCoY4VH3ywCgvY2o UXldmmZSvAI6TgoTngm/B2FNDsoRoNUiq+rKuqfn6b/6iTPyLUSPkWzhSw6E7KCgfAuG 1z6bnArdW2o3+D2mK/Pu8I3RPROBN3zyhP0Ro5yMqGIzSTDGkDTOgIEUis8pK5Rlps7x f+1lIGWl4TgHe4eZZl/UlWDJnrqji0+BU9RE/Cg9fUFFyp2qQiWNDn9/oolZjpt3QYWX 6EZA== X-Forwarded-Encrypted: i=1; AHgh+Rofn30Sb9jOvHo42Z1siBRMLzStAFQ/24MUzJm97uqhcxdfwRT1QKyxHhHyL0zlhDVqKLj26Rh7t2xaAYU=@vger.kernel.org X-Gm-Message-State: AFuF++lmHsixTahLlYUJf5Y7U9QeJWl/LE1WxZtmVjawVldhNCxLXSKz dDkR/lNmERpffGVjbbnYVwfBeFIkgTdtNRbizTqGOe08bfiG2Wuz+/cU X-Gm-Gg: AR+sD10kSrxgNOigk2PHDrkr/yuehOvnkP2QQnIn6mLkyXX79A335K/wl2aJZHqJfIT Du0L6BgGwCpvszbw1sjr+JuCoag/yY4l7/K0CddTqp82VONVxXhup5pxUUYCHSBrkdB2mBVuf6Z srGT/YZ68UtCZgjyP1iRy+BjKlr7MYQfyN5ya27jx+PNvwrw5WUWyLJ5rK7oJ+EZqaS8hviH7Sd DpkzcM06j/MrcjIoStRktSa2xeTF9Md9gQr6IEsBJOfFHOb7qPOaUKnvA+Cd3G1Nf7VGc1tDPNc pN1gIBUYWQPdw0bdmXbiRz8KRTBefc6OGxW0pfhsTwjUQV/GwPMhnDmttxWg0hikvBeJXs8gV8j TUVkd/vLCoztgZJWTkLoQBA31L0lf7gDT1LKfJIF4ffbtVK5Ez+qXBv1tXcjSUw44CfChU/PYTr F7pcPLhpn+sE4rjetJsWlkC4zC9hM3sd4YdwltO9NdIFB3D5Crmy3h9QuuclSIN7vfezE9UOH9L VeZwvCQBfyq2h6XwwgxZ28kA2CmyjMjEPRz0iGh7/XnZ/qTRbbFIY06ZMJ3Jyc1VZqEtTVY4Rmf rQ== X-Received: by 2002:a17:90b:3985:b0:380:71eb:4014 with SMTP id 98e67ed59e1d1-395c357d3a3mr15702940a91.15.1787346749757; Fri, 21 Aug 2026 14:12:29 -0700 (PDT) Received: from iku.. ([2401:4900:1c07:194c:dba4:ea1e:d7d1:affe]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bf175399sm49755257eec.26.2026.08.21.14.12.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 14:12:29 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v6 15/17] rtc: rzn1: Add OF match data to gate SUBU register access Date: Fri, 21 Aug 2026 22:10:30 +0100 Message-ID: <20260821211032.13554-16-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar The RZ/N1 RTC driver selects SCMP mode only when an optional xtal clock is provided at a valid rate other than 32768 Hz. Without an xtal clock, or when it runs at 32768 Hz, the driver uses SUBU mode. However, the RTCA0SUBU register used by SUBU mode is not present on all SoCs that integrate a similar variant of the RTC block. Allowing SUBU mode on those variants would expose RTC offset operations that access a non-existent register. Add OF match data to describe whether the RTC supports the SUBU register. Reject probe with -EOPNOTSUPP when SUBU mode would be selected on a variant without SUBU support. Signed-off-by: Lad Prabhakar Suggested-by: Wolfram Sang Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v5->v6: - Fixed merge-conflict on rtc-next - Added Reviewed-by and Tested-by tags from Wolfram v4->v5: - Renamed rzn1_data to rzn1_rtc_rzn1_data - Added a print message to indicate that SUBU mode is not supported on the variant. - Added a comment to indicate that the xtal clock is NULL when SUBU mode is not supported. - Added Suggested-by tag from Wolfram. v3->v4: - New patch --- drivers/rtc/rtc-rzn1.c | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 33c7ef5c1eba..8c3dbbc34717 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -19,6 +19,7 @@ #include #include #include +#include #include #include #include @@ -66,6 +67,10 @@ #define RZN1_RTC_TIMEC 0x68 #define RZN1_RTC_CALC 0x6c =20 +struct rzn1_rtc_data { + bool has_subu; +}; + struct rzn1_rtc { struct rtc_device *rtcdev; void __iomem *base; @@ -405,6 +410,7 @@ static void rzn1_rtc_disable_hardware(void *data) =20 static int rzn1_rtc_probe(struct platform_device *pdev) { + const struct rzn1_rtc_data *data; struct device *dev =3D &pdev->dev; unsigned long rate =3D 32768; struct rzn1_rtc *rtc; @@ -412,6 +418,10 @@ static int rzn1_rtc_probe(struct platform_device *pdev) struct clk *xtal; int irq, ret; =20 + data =3D of_device_get_match_data(dev); + if (!data) + return -ENODEV; + rtc =3D devm_kzalloc(dev, sizeof(*rtc), GFP_KERNEL); if (!rtc) return -ENOMEM; @@ -455,8 +465,12 @@ static int rzn1_rtc_probe(struct platform_device *pdev) if (rate < 32000 || rate > BIT(22)) return -EOPNOTSUPP; =20 - if (rate !=3D 32768) + if (rate !=3D 32768 || !data->has_subu) scmp_val =3D RZN1_RTC_CTL0_SLSB_SCMP; + } else if (!data->has_subu) { + /* xtal is NULL here */ + return dev_err_probe(dev, -EOPNOTSUPP, + "No valid XTAL provided and SUBU mode not supported\n"); } =20 /* Calculate the duration of two RTC_PCLK clock cycles */ @@ -509,8 +523,12 @@ static int rzn1_rtc_probe(struct platform_device *pdev) return devm_rtc_register_device(rtc->rtcdev); } =20 +static const struct rzn1_rtc_data rzn1_rtc_rzn1_data =3D { + .has_subu =3D true, +}; + static const struct of_device_id rzn1_rtc_of_match[] =3D { - { .compatible =3D "renesas,rzn1-rtc" }, + { .compatible =3D "renesas,rzn1-rtc", .data =3D &rzn1_rtc_rzn1_data }, {}, }; MODULE_DEVICE_TABLE(of, rzn1_rtc_of_match); --=20 2.43.0 From nobody Mon Sep 28 12:34:52 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BC9D41687D for ; Fri, 21 Aug 2026 21:12:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346758; cv=none; b=re2yGQpAe9ByKaQCGmEGduNBglv1ONkEXxk2aNby+V2fTC4mBxnSmIM+0vyNJjLL676Met4f0mra/Yw77IozyiTA2MCtVKzeXha9VO6qVmF2jsHrpNBv53nNO+B0MHS+UmFQKBUzbmmSGH/o0OlsMWz+ZQkqSL4YuAmdyaekYng= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346758; c=relaxed/simple; bh=pqm8lJvKyQBek+VRRquT1stu70Oudwpmv5uE5mWefoo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oIcW/5be5rEB0hYiQ1WFYSTnsoAPg2OIKAC02frF6BWZO53cx15efOto9nY/E+otQ3l/2mrRaznsKuxh93CoUS9TTBzay8wst5Osud414gUbROkdevdCDOpKdXarJOLV2GFHyrSqvZd/tPOvFB51tRwbDfLVbojJWZivWVgRbWE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cue0kEvA; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cue0kEvA" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-38e07ebd263so920054a91.1 for ; Fri, 21 Aug 2026 14:12:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787346757; x=1787951557; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hPE5YqIeze9+5WQD/4I5qaaAjG465/ANUVJrXtv+vZ8=; b=cue0kEvAhGWqrohDdI93OyATrdNKWcU0dab8E26lYXx6MipsjvIAF+HqVxGUeMqBTY bU4xHK32p+7s9JPzfhxAb4jkHxpbEYQ8ozMcm5fV35Dg6dyrsmtq4igicY7J5s7O4x9x 8J+9Y9ZwOMRLy9vEGCypWskfJAahJSiUE3J9FTAO4sOp8KNwceQgj0DS9g4u1Jqmpnec BbD4An1JO2IUgiS2Z7M2cBYYubkF9rbZQRqhOVCl/uCMuiQlyyhJRU4ezzEnw0yHepGc OCgdAQVncHmBLccIqX4dPSIfhm+plDUxTH/3cuMf+uEPidAbfzB41H8oYUkNZH5xYIiZ +2Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787346757; x=1787951557; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=hPE5YqIeze9+5WQD/4I5qaaAjG465/ANUVJrXtv+vZ8=; b=JDlB6MoJU5P44zJJxQUVSLcvbQ350K2fi11U92xzlYAxpg1NJ7rSC/ZLp7lG1Uma9a tdZnoBMJV0AAmkp2U/f7SdEKcJiopu1zIjUP5/sOoja4j1jbH6jttugkPOtSgaOTd/63 lAU4ieo6j2Gk9LlufC3sUqI3YBrMK2nQYSA6BIbIEc044h+nhArESkFMbM3999nhxoX8 wVMQakZoFkBYmmLUzEvw4KrZ4MHwU8ocn8gurQr72HIzVEMbrOit5dBeHa3iw541Qq/n LyBLdlI4PLFOgMjY3zvdu0lFDgkqKjQYTS6Jw4LYYy8P/aiUyEkNQw1KHyG8jdGryXiw /+Bg== X-Forwarded-Encrypted: i=1; AHgh+Rq8r2XBWYeyHeQHLAni/6j47g1y6zQkZb8ByV5N2U7n091/lh/8DZma2RFtdzc+L8my9P84EjWzFdxqXKs=@vger.kernel.org X-Gm-Message-State: AFuF++nORA3+uX2PncBkN8KBJJIapHvb4ZuaOH0dwnBcI0DIinxn3Qpe U7ACgqSFp2uW7yJuSMlH9OniO+pIPB6gyzCuMrAuhIQB4QTaHN3vGdJx X-Gm-Gg: AR+sD11ldaN5kqpQetGbWJknEMb2t5nYxwMa38nPpzoYCjqyCALSJ6rRC1BKdNqUQHe 5frWeBkd367XUSUGnVVAGcdzClZepzfLO/a8wsUG3zAYu+u2xLSl0Q+k21Xg5YZP3GwSO7bJ4R7 fcByQ71AZBkywJXzREXHa2npXaTmKiYiukrB5Immo0HyVvun24NRrEIGHqATXFsV7DgBHXNTK8H qI3pDcdZWcAaBvx8VRwHXMXnh6rXnltvJoO25Q5URG31DKZtA4l8sHdagWRbl+O4BRwIsK/kbcx gaBi6wjJATumV2zzQQotm3rMX12zseCTznOgYcFyCrw9OoAxi5WcyGT9sLTlxSQxZGM9kxI2GUf v+MHK6ckQ4sHSPlhstGfzy7gusU+odzZzVyaBCWgFqh3sR00jezLKVf0clpz5FgLRI6enjpfhRF Vks9b6FG9wNfE97//zYrw8vJvfitHGMe2wgNKGZfI6Dtgbk7QbAXvaqkNuHqjQ4Nhe2LmY9obD+ g+NsBig6tXWbZETWn0eOGcVhWb+59EP3IjoIlm6QwI4F8AoMUP1dseCXRG+/HjBQ1KxYJdk X-Received: by 2002:a17:90b:1a85:b0:38e:250b:122f with SMTP id 98e67ed59e1d1-395c3aa9e26mr16109390a91.16.1787346756800; Fri, 21 Aug 2026 14:12:36 -0700 (PDT) Received: from iku.. ([2401:4900:1c07:194c:dba4:ea1e:d7d1:affe]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bf175399sm49755257eec.26.2026.08.21.14.12.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 14:12:36 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v6 16/17] rtc: rzn1: Drop trailing comma from OF match table sentinel Date: Fri, 21 Aug 2026 22:10:31 +0100 Message-ID: <20260821211032.13554-17-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Drop the trailing comma from the final empty entry in the RZN1 RTC OF match table and mark it explicitly as the sentinel. Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v5->v6: - Added missing sentinel comment v4->v5: - Added Reviewed-by and Tested-by tag from Wolfram. v3->v4: - New patch --- drivers/rtc/rtc-rzn1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 8c3dbbc34717..906d03c65df3 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -529,7 +529,7 @@ static const struct rzn1_rtc_data rzn1_rtc_rzn1_data = =3D { =20 static const struct of_device_id rzn1_rtc_of_match[] =3D { { .compatible =3D "renesas,rzn1-rtc", .data =3D &rzn1_rtc_rzn1_data }, - {}, + { /* sentinel */ } }; MODULE_DEVICE_TABLE(of, rzn1_rtc_of_match); =20 --=20 2.43.0 From nobody Mon Sep 28 12:34:52 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 128DB41835F for ; Fri, 21 Aug 2026 21:12:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346765; cv=none; b=ZtTUtgmRemfGLngzh8T0Y2Wg9KBRT54zP8UiaRxlxOoNPBIFXmkZzfb2QTCjWV+170ixhWzCVizY8rqAYVI/XMnUBWHRtQalH81zwqooeVZDICFc3z50WQWQuAkUu2OH6ZdskeGHoFs4uaUDu/BZZc+HIlUudU6qmzU6nctQ1Fw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787346765; c=relaxed/simple; bh=A+v7mWu+wCAlwX2apMuc3TGMtMv4ggi9HrGbcDSLrQQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QzzRmXo+QCfo5oZqCdvr2Qz4r/gWfgC/i1QNk2PT1Tj0iGXqHFcpPoSZTaugtoqtDF4X6GuggzCTNHbB7HrXGXxM4VhPoMpK5DikQfNDoa1PhInJUXkJtYfWLUSIStAFdCZliIvooQ/Yro6wwp6VtpzEMEhH5QMdHVUJteDYe8A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G+bsGhnt; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G+bsGhnt" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-383cb94f742so1621205a91.3 for ; Fri, 21 Aug 2026 14:12:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787346763; x=1787951563; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4l8YNQk41/fppyfIDksrLwHHQ57AKnk38Us5hixv6DA=; b=G+bsGhnt7HVIcww9MuoR89rkzMxJbcgAtccPBw601hymCbaRQRh/KN5v+f9fGDvSjZ FTgLuxIC8kWJdS5wyRHtCO+NY9oCNgoN8IOzEGKmokLT0dR6yjx6CcsfrqB0i6ze60DS fcPxos/90zpHWD9VGW67r9tOZdYNHv59GOt6dDpm+2Y2QZeX7jc3DKrHcim3C0TJIMxO Mlm4YUFgD6BLGeWXRCR9LCcZMomHRjOQfU4Tw2Dy47XUp+owI0P3ckmUlZVWjSGKxjZo OYDrKasf9df7Rp8Hcgqm8G91YjoERtzyRupa+L8T3oahFcpoigsXYdD/LvkIeJLpeGmx kiZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787346763; x=1787951563; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=4l8YNQk41/fppyfIDksrLwHHQ57AKnk38Us5hixv6DA=; b=L3b8kCUgUWEGLFeD0bXgrfubPUMPhqYhvQlKpxvHdZxzBGDcSF8WzxKRa+ECfp4hiA Six0dUp81fs9HaHA07pz1hihe0Pu3lfh3DS8L715APVbaQ047/VErECmsuS08wrhIX/W 8K6pTJKdaeGjFqcmlGv8jexvt3K4uxQD+b8TBgNQTRCskxOOVaZl1TVV5gaq63vH64sD EMzMHCrKL371KRxq/xY7YL4T0j3wYhsQBdG1o1Qx7MH8Tx2q6RrtL+9j6Fh3lXb9zSUB NgLVlbdz/5KZOBRGTQ1AnOHWRxqqn4UuWF8A5mmw3HDZCoviUCjLdBUVDpvtxbftMKeT Fzzw== X-Forwarded-Encrypted: i=1; AHgh+Rp+KVmKus4ZSqc4nzz5pLAmdo2EWutGEcCivxCA4ReDKDBniww9pMVt/EGE2WSGDO05z9Ffd6WMKh8WQ/c=@vger.kernel.org X-Gm-Message-State: AFuF++lSqe2I0s4YqUjH/VH0U11aA6Z89t8n0C3GMss0VBdNKwK8iV00 OvaABsGacuvNYOTv7JB5vyJd8i1GQfZsqtB4HGeYa6c3B87mlWftPNjU X-Gm-Gg: AR+sD13x0i5zwtNf9sOjsCf32WNyH2+6NPLmDYUPLs3HFyFGjkAyvM+GMYlwvLm/SUj R7Dut1mvsmtRjrKEiaUAMym4n8+xi3PWiu9rqh7ZsaL0N0ZXWXEdUvNF+y0CWWdqkccwYfqCCFA 8Xo4LpSZxJeNVvL7ybK22XqzdbTsNjk6uyCrS9qyWq++1BeenH3zLbHe011rncoVpX8cN7iTCzA mjijqdeyRnoTIex8p+T2yCUZtz3SNKTLqqDqfTOwCltR6fgkX/quU+UU4jMSwN/smbtXYPh6FMw d/+5JJi5VB0oZQFRu+cyGdNb1nJrpPMIJaR64B8gfmBnfs26vu49nxwr4as/eow+QcWJcyUQA/F FuuoCZGFFzkMiJSwqfuTxe+EVuMwyAYPttpkK0PrQeQufn6P28A9BxtiFLfuYTMfSAsiR2xk48Z 9v4TuFGzhrBU4fRbr7jQz6YrjpxnQHhvb3jFYQWDrT85s8YquGwZqpI5P5ukexoDxyojFUMvvno 45i7jQx8DjoP9Pv4GdGFVekkzCY9mO6doVXhpoxEknltYqCwj95S/Pxy9Joz2S/EjpF3s4F X-Received: by 2002:a17:90b:3dc5:b0:37f:be6c:f3f2 with SMTP id 98e67ed59e1d1-395dee7e2dfmr2594815a91.2.1787346763290; Fri, 21 Aug 2026 14:12:43 -0700 (PDT) Received: from iku.. ([2401:4900:1c07:194c:dba4:ea1e:d7d1:affe]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bf175399sm49755257eec.26.2026.08.21.14.12.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 14:12:42 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v6 17/17] rtc: rzn1: Add support for Renesas RZ/T2H and RZ/N2H SoCs Date: Fri, 21 Aug 2026 22:10:32 +0100 Message-ID: <20260821211032.13554-18-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Add support for the RTC block found on the Renesas RZ/T2H (R9A09G077) and RZ/N2H (R9A09G087) SoCs. These SoCs integrate a closely related variant of the RZ/N1 RTC IP, but do not implement the RTCA0SUBU register. Use variant-specific match data to disable SUBU support for these SoCs. Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v5->v6: - No change v4->v5: - Renamed rzt2h_data to rzn1_rtc_rzt2h_data - Added Reviewed-by and Tested-by tag from Wolfram. v3->v4: - Dropped RB tag from Wolfram. - Added OF rzt2h_data - Updated commit message. v2->v3: - No changes. v1->v2: - Updated commit message to drop reference about RTCA0TCR register. - Added Reviewed-by tag. --- drivers/rtc/rtc-rzn1.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 906d03c65df3..1e1676a7f3cc 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -523,11 +523,16 @@ static int rzn1_rtc_probe(struct platform_device *pde= v) return devm_rtc_register_device(rtc->rtcdev); } =20 +static const struct rzn1_rtc_data rzn1_rtc_rzt2h_data =3D { + .has_subu =3D false, +}; + static const struct rzn1_rtc_data rzn1_rtc_rzn1_data =3D { .has_subu =3D true, }; =20 static const struct of_device_id rzn1_rtc_of_match[] =3D { + { .compatible =3D "renesas,r9a09g077-rtc", .data =3D &rzn1_rtc_rzt2h_data= }, { .compatible =3D "renesas,rzn1-rtc", .data =3D &rzn1_rtc_rzn1_data }, { /* sentinel */ } }; --=20 2.43.0