From nobody Mon Sep 28 12:35:06 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C12E2931D9 for ; Fri, 21 Aug 2026 13:56:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320597; cv=none; b=UONOroimP7sK4iV4iMVUbHdz85yQHGgNTps4tIbVLt48H1kGiWV/fb8eNceCZMBWKTGDv7kKBb13FuGQNOPfdTt2CZA7BmE3udCDV+gAdu2cghsuFBdw/BLXsJwiLYiZj+mxeKwxEKi+HP5aO7VjjbZqscwWgPExs3lGxEFFigU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320597; c=relaxed/simple; bh=cYr1RAs3gvAuqJZWfuQo+taemyMfp1Anvin255uabiA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cdRlmsHr3mNbJcwrprWt0tOP6/jkLCSFmVwCZwf3DCamqadL0ppqTTGnxVoIk+5kOmaqopTD/r1JeV9BVbyK1auzfFeqdrNzR5D9yqY2wp9+6dUT+yIB2WEovlVdzx11gkH7TO1U/1gsP63W+tuAPSJxRKiNz8VQ4cNrKcP9ytI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fZRrbRb8; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fZRrbRb8" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2ce98cb8165so9253745ad.1 for ; Fri, 21 Aug 2026 06:56:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787320595; x=1787925395; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=n3IQsf8wvtCdNJq/Wm/ZZ1xAHtNzc7iLcDZ8zTr7S5c=; b=fZRrbRb8oJa5DZr73vvVRTwm9fpcMu74uGSlTIINOIgp6OtvGpuxIwGZnscMOlT5wa VBjqE7lNgKU51TIjpnVNhVBKv7tMJ0rXYdON5uwNADjNAHs48B4H/WLH96TsqGgM1uSu EqdHHRr7quaHPlU/4JlkvPXjVRC4XUtUOCT2GbZQ/xMfc+kWvkqno0l0caHQmvdYODpK LYP7e5REYzR7vIfNtOwduKfwS0xUiMf0igCpUAz+cuW6PxMsB0vFMLozit+PH8Pvea6U d1DY+YtdU1+WeP5oQ+HOQUeCqei2sF8EFcJa2v45SOXjndCkb7O6jYAzwyXD0jhmgWfm Szmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787320595; x=1787925395; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=n3IQsf8wvtCdNJq/Wm/ZZ1xAHtNzc7iLcDZ8zTr7S5c=; b=WqTSuakEJoZyskTM2mr73BujY5QR/WhBu+E4M22GH26rcHcJdde6kgdZeIicwrUuVE dO59jywOxsna9W1Es2t7dW6jr9X1XzHzTAKk+k9N7D6FXksIL5J7SeySY0Cfl6LCsLus uEiCeM9RqGSUT7k9g5udsmuZZUNKZ5NG0nKKiqxLSNUcssNGSAq4Z3blVXAe8yYgXry9 4v8eNxvFzJrgB5SF5KUsl0GFy7k2Yy73rqDW5bvlxzN9t4cf/qBtA4f8qlW25CpQ0XXb +T4zz95jOsl2v3frs/ZJnMOM74rODqwUIoutYTgeLhCRzE23g+26FVned2bHn94RlQBN RAIA== X-Forwarded-Encrypted: i=1; AHgh+RpAMzT6MRlYZcYYGD7n1NSQP7YeoSkuF55X6pwe537fGfGuDfWNda9MJksHOV4O7zcNqzyNl6mr/J+akSg=@vger.kernel.org X-Gm-Message-State: AFuF++lWjhnE7LbUhEnSKB5zO9MboNNErxbkLuS0n6zJNM7Jl/Dt/YT/ pLLWHBDpACHm574n1UkAH8MNci3sL1SvarzYSe/UkLt+MoBXx0o2Lq0F X-Gm-Gg: AR+sD12rnM2vrWyYgOe7DptGaiXM7ACZIV9J+7MLyGqlwhznmVH75iUQ4Jv7N8tRfkS BelXqLzE2dKYdkRifHbqE3HAtbLfH3+L+E8j7t9s1Lx0tj91g+afhEN+BEfBUOitqvRj3qJwut8 zH+ptg+nze11koUQNoC9mfkmoANcuV5HWXkCILUYkJsvPTllZuSFjhFpp/eqfRpNor6DOGWdR0i GJkM+ipT4WpNkK92p/WnTcSyvOGieRiWo86CNB1Ykgrhc2e76rqxwinRAeirANOCt4y4azFWm1Q ZyWq2n/Z3Co5nWrC1F7g1ifjMvcTireaENHa0elik795lVqGve7bHphEcy6fq4no4wvBZGFgV9W zhUkyHqjBTclgNL9OnoL6bRk0dPQcR3osQ/bARySRsb91vwghj7gW6a1YtiEpEf7v/KenFB+S7t 7ZVcxdnOqJTbCyQCJ8tHyaSYiznLj3iDcACdxUuBSLmGuKq0odogfaS3V9/88ynUbk59eBiXGqe CMo7Gw4muN7KteH0OOqDPQ0FLoJvYPCleqCzlXj5ruB+7qjJIaH55SPJmghcJ/ZoBG8sK+AsY3K vVKqnwjcgw== X-Received: by 2002:a17:903:94c:b0:2c0:d94f:50c7 with SMTP id d9443c01a7336-2d61a0c9415mr190790765ad.7.1787320594915; Fri, 21 Aug 2026 06:56:34 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:773c:1c8c:24ea:eff6]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327d01ff056sm19972277eec.19.2026.08.21.06.56.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 06:56:34 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar , Conor Dooley Subject: [PATCH v5 01/17] dt-bindings: rtc: renesas,rzn1-rtc: Add RZ/T2H and RZ/N2H support Date: Fri, 21 Aug 2026 14:55:52 +0100 Message-ID: <20260821135608.275233-2-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Add compatible strings for the RTC block found on the Renesas RZ/T2H (R9A09G077) and RZ/N2H (R9A09G087) SoCs. These SoCs integrate a closely related variant of the RZ/N1 RTC IP. Unlike RZ/N1, they do not implement the RTCA0SUBU register. This is not a limitation for Linux support, as these registers are not used when the RTC operates in "scmp" clock mode, which is required on RZ/T2H and RZ/N2H due to their 195.3 kHz input clock. The RZ/T2H RTC variant also supports a 1Hz output signal on the RTCAT1HZ pin, controlled by the RTCA0CTL1[RTCA01HZE] bit. This bit is marked as reserved in the RZ/N1 hardware manual. Update the binding schema to require the additional clock inputs used by these SoCs. Signed-off-by: Lad Prabhakar Acked-by: Conor Dooley Reviewed-by: Wolfram Sang --- v4->v5: - No changes. v3->v4: - No changes. v2->v3: - No changes v1->v2: - Updated commit message to drop reference about RTCA0TCR register. - Added Acked-by and Reviewed-by tags. --- .../bindings/rtc/renesas,rzn1-rtc.yaml | 35 +++++++++++++++---- 1 file changed, 28 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml b/= Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml index 1860f0e4c31a..ea7b039a91e7 100644 --- a/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml +++ b/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml @@ -9,15 +9,19 @@ title: Renesas RZ/N1 SoCs Real-Time Clock maintainers: - Miquel Raynal =20 -allOf: - - $ref: rtc.yaml# - properties: compatible: - items: - - enum: - - renesas,r9a06g032-rtc - - const: renesas,rzn1-rtc + oneOf: + - items: + - enum: + - renesas,r9a06g032-rtc + - const: renesas,rzn1-rtc + + - const: renesas,r9a09g077-rtc + + - items: + - const: renesas,r9a09g087-rtc + - const: renesas,r9a09g077-rtc =20 reg: maxItems: 1 @@ -54,6 +58,23 @@ required: - clock-names - power-domains =20 +allOf: + - $ref: rtc.yaml# + + - if: + properties: + compatible: + contains: + enum: + - renesas,r9a09g077-rtc + - renesas,r9a09g087-rtc + then: + properties: + clocks: + minItems: 2 + clock-names: + minItems: 2 + unevaluatedProperties: false =20 examples: --=20 2.43.0 From nobody Mon Sep 28 12:35:06 2026 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7ED5D492183 for ; Fri, 21 Aug 2026 13:56:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320604; cv=none; b=N7xWvC7Jd0LLweX2UAckG+ul7U3gx62entXuCJZslNvUxnyzfGvTrP/kqRTnoT4YgH5NhNuKuCBaTXCmc8mXXBJy2mVdoU4qfxBBWJQyqBwcp3aXGzm12iHCGJx0UM+z8T5Rdnpi1oP+GD9L+5ddhaYpCF8olWm+G+pCscgPAJg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320604; c=relaxed/simple; bh=uLWrx8VP0XvMS4lZzOPKXcGwF34UPrlN0NDYQcb++Vw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hBjRBgOX2x/dD6ziDS2hjLWNLMOezO40gyH7E2zutKBfIVWmRhbIjhbeM4SHMu1wSksI6QK5wuCJDRq9+bnp/FahMOGr+wyy24TvXqPqgbBqgVhmiyzjVzU+itWK6FC461NmeLfqGbrMb0JKQw/2o1MBzauj+uhVA0SvGU2NikQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M+LLsdd+; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M+LLsdd+" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-c96b08cdd1cso815132a12.0 for ; Fri, 21 Aug 2026 06:56:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787320602; x=1787925402; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=s4uKJIgLF3adY62zLAWtHXEgyUnOp/s/pf5/chMDvJU=; b=M+LLsdd+5WcNN2CF9wFBWTm/GoK3oATdYy88DYbuELkZKTnLYEjEbcCcfl0XbET29h 1HjX5vmKyGKYcbyWZHFiwOqJtX5yCFQFNGZxK8IdNRoUt0JK7dS6AC2kWUaPzTeC1pGf e4RQ1xXhTN78uXrAvW/9WXRhlbIB8nQafUwRZ9DDsXjZa054TPQ1pLoUHLOeAZrLGZDg VBGLgXAE5oxyWi3jfaIYXVap6jI/e8gFe+TC8nA8Bp5a0oi5G378F1B11Tgou1qBIlw4 AUFqOaJ9yF8iPpcZgciMcCJPiN63Q3VplkKVnZEk2hi1Cv5y0gmcEekJv1HBOFupOt4W V7lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787320602; x=1787925402; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=s4uKJIgLF3adY62zLAWtHXEgyUnOp/s/pf5/chMDvJU=; b=c9bBSvLBg6hL7+XSH6U2PbNGQWFieuk4qm60Iuf8wr7c+hFz29DukuUf/MeSmRtqKD zyVMprZ2ikN33Lw24z9S2RG+U2kebYuNic6dtLZk0lwEw2YMJj1uorNClzCcxi4s3okK FFFDe6EQ6gf/dUzaVx1YSd/lIUltQsXucGrlI71FQzkr/4jWHuKe3//45vHd5DREM8Hk RYh0/2QQACuh/22sl5zAPl+Tgo0WNMORA4DXxJ8oMlRAfbxtoGJYpstPrHgsXMlTSij4 S9+JEli/buDWycsm2AJJ3x+eBZ1y38ASD7zv9n0KVN+P3wZtL6JXo4RdNvlWlek9O7hu Ub/w== X-Forwarded-Encrypted: i=1; AHgh+Rphpu8gzu50sVJM7VSXve0IljOcIFQ9aTASnr3UfXbkp7/t7DTZi7pVCStHtGerC9/2ocFkHZpGE12lfG8=@vger.kernel.org X-Gm-Message-State: AFuF++kfDqTbQcAEzQLaRHRHNrevvZ+PafyV9uugl4foFyj5t1Ix7/zd RROmWOC6BqMw+ybJfCzAvmwsKqpgGHvA4EySfysbZ0wmuSPS0aHXCgul X-Gm-Gg: AR+sD10kd1tjL7fOi4zMjVEEKdWIJYL/ptBS6aFsidBZ8o4a1OjyhgyeiXxd1ynk0f8 iaUknejL/dP0Zz1EAtUVdA4PT/66UXQO2J9gUatTlVkxwBFj52AgoJKiVcLguhhiZWnI/B0d5/a shQBJ1rZXT/08sSID+4JH190BDDtkDlh86gdZy3GarYze3IdEvp7BVDlx1K9gIxudKQkWDEn9EV cPL0rCbur7mTdSHNbzqh2ItbCUwkPKnMeJEoT7yca0xaf+Hvms4pErhaESOiPT5OmB107BYYitF 7QjQRh82yyr9iZKWYaGTeWjcyyBTru+zuWZwji4fGWdfqe3uipMIJ1RZj6gtWt9+Wq3HwyaxO6C YLDxp+G1ho/FlUY0eIrVUAK01+KHWJX8xEt9WFgqkZSOy/am/CllMHol2yxkV+1D0hSYRsD+Nm8 QYQJeTwnlF8BuO63SV817cBWLxOH/sREsb+QK2tqnDm8mcMnItEvzRC+AYyM2R+fJvsAcjD+x0v q03X9GefUq+ShWRnuloyKTWJ/SpVk3Ds8FgDBEmBtIMM1KIfFE9+zZP02JqU4ksOGcQQXyNKKb8 qLE4PK1R8SiligdtzFOPew== X-Received: by 2002:a17:90b:4c0a:b0:38f:de97:b06 with SMTP id 98e67ed59e1d1-395c351386amr11634937a91.5.1787320601681; Fri, 21 Aug 2026 06:56:41 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:773c:1c8c:24ea:eff6]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327d01ff056sm19972277eec.19.2026.08.21.06.56.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 06:56:41 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar , stable@vger.kernel.org Subject: [PATCH v5 02/17] rtc: rzn1: Handle EPROBE_DEFER for optional pps interrupt Date: Fri, 21 Aug 2026 14:55:53 +0100 Message-ID: <20260821135608.275233-3-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Check for -EPROBE_DEFER from platform_get_irq_byname_optional() and handle the deferred probe request properly. Although the "pps" interrupt is optional, an error code of -EPROBE_DEFER indicates that the interrupt subsystem is not yet ready. Intercept this specific error condition, assign it to the return value, and jump to the dis_runtime_pm label to avoid ignoring a valid probe deferral. Fixes: eea7791e00f33 ("rtc: rzn1: implement one-second accuracy for alarms") Cc: stable@vger.kernel.org Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v4->v5: - Added Tested-by tag from Wolfram. v3->v4: - Added Reviewed-by tag from Wolfram. v2->v3: - No changes v1->v2: - No changes --- drivers/rtc/rtc-rzn1.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 305f10a8a85b..aa27ad7f5941 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -464,6 +464,10 @@ static int rzn1_rtc_probe(struct platform_device *pdev) } =20 irq =3D platform_get_irq_byname_optional(pdev, "pps"); + if (irq =3D=3D -EPROBE_DEFER) { + ret =3D irq; + goto dis_runtime_pm; + } if (irq >=3D 0) ret =3D devm_request_irq(&pdev->dev, irq, rzn1_rtc_1s_irq, 0, "RZN1 RTC = 1s", rtc); =20 --=20 2.43.0 From nobody Mon Sep 28 12:35:06 2026 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F25E4476CE5 for ; Fri, 21 Aug 2026 13:56:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320610; cv=none; b=cgvYUD9fbjuSIvGccaz552eZN261UqyjED5z04JotegK6Xvaad8tec0c4c2TWisvjtm3Ewb86PEslC66sKQ+K/twsHEIsJSNV3El9ZZPgCf/Rl+JtGr16jrGvkhUeH4pamLnC0ohhPzLaKfVTQbXyy7Fj+14XJnMlnSYyO9FrsM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320610; c=relaxed/simple; bh=nOwCB0GUu636xzrMDwXRCKSR8TtZ4OMEI81GMCIE7vM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Hasedx/ld/+aJBvqwQ07mfEl9VEDSUxQUydltsuZOaftpshtl3lJJiKkCZbwIb0ebQA0IrwBySXbMdAoKc/DZnP3RvrxTM/MRLGIvuViBdPEH3aZaX08lPXUBRAxYAEeZGT3iCyI+Br3MrnHskTyDs5xJ7IZZ35ZSGYdT9YKgx8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GZlSwPEA; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GZlSwPEA" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-ca00f126b7eso753162a12.2 for ; Fri, 21 Aug 2026 06:56:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787320608; x=1787925408; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=d0FHwOXmdVjq/fR8LKjN0dCSgITp6opJdRR3Iv2IfwI=; b=GZlSwPEArMzym3mMiIDUoMBvgTPk1zsx40bWbVKQToRaXTN7Jttyz8G7pOnaLsJmKm eaU6JxtDXMghu5Fkb29IFtMKKYnaeY0nredMIOhYO73maawqLzAGD2NQ3YC9j+n+mGzH EwT9sahdv0VOz3KKn9kqsDo91KUNWBVvlHYTh60XeaN7aq35LEwIDTPKZgN2rD9xEvWt LguIJLZCO2IBy5+a6F9C+qN2MxJ0ZQyAipEkw9uH3sOmM6VozVMNLaysAZ7yWJ2+uTse bqsW6uQJi+evP/vaZqnaM2TGxhQIlF10WYooPsCnIkGBnWBxhIMZeZuMitgAGP+TWiQK pfSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787320608; x=1787925408; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=d0FHwOXmdVjq/fR8LKjN0dCSgITp6opJdRR3Iv2IfwI=; b=XSrXPnX7gLNVMC5De6NlKsaFPHRAGcsazhrIfnit4JiqsTaaagmt7bwu2mT9+1l2XN iSrH9XY2IkJieDEzWfHFhcF6u1sElrWwN0cNdsSS/SAbo8NDblCthyVrdUWvvD+hwyi9 /LUD8U/nwb6e6tnl+MzQOpMp+mnnomOcJLHO5R8NcvivZuNa6ECBZqK2VNp0iXPN6jUt 8TSClVIRMGGCmQiM1D8p/EGPvA46bX4T6xfvgON8Pnbpp09QkhTPhh1erfBSfROnAQvr kZKFqFgdFT2fp8WIWrhfk0WyxIToKnqgDfBlRwPO/b9Vw/XQ2dOdod1glAgxXayKL/gz gqAA== X-Forwarded-Encrypted: i=1; AHgh+RpTkSRkPI+/fkhhcvEKdGGdZ83HOdrMyA0CKE1uJZAxtJF/cf0Kstv3uSpnOw6LkSvw9Y9CG0mHj/fKlO0=@vger.kernel.org X-Gm-Message-State: AOJu0YwRko+Es0PM3izzzcIq6hgkAZieCzPkxH4t0Aye52c7Tkxh60rp 97BFZCWY3ZvuiGlicNeGjh8kdMwGsjtC5Ev4pgxUglii65yFM/KAodzt X-Gm-Gg: AR+sD11dd7lsZL4uS8aKUPKuPYjb4f7uJDjZ54cY8dMUcv09AeFXg2eyok9b4OqznPm NIqLMW6fQafZFDchPzmdF461p7dsxvMEwSJ0H9lMmejP0EqTJwG+uZfdw27FWVcsJeotwcwxiFs CC/Hx+Xhb9kK6L207Qs5i+KiraYfdPP8HprOIK1klH32Idqq5nPKVwqwqbLpbKloRI8BHhJdENZ kElgbqJX3sUgxVBmE5S5gj3RwxH5x8IAGMo1Z4zslx1BWfUHZMtAF1K7FNaRvmg9mvIFEFjbImJ xYKd3QmTxk3ihJ2BONu6cURJsBdthfme2hA6+lFpEJ0sns8AQtoK/WZhEiRPTP1a7jBTsPz0hfd gj0d2OSfL5C27oOqwHt5GOe43AsQE9YMoxP4ZWXt0eWhhO+GV8zquQNh7Gew/O4G1B+wgISNzXD XZgO9sokgmtsYjoJEEZxZ71i1AxpPSgqFTwL0hns1iSR4bT+jKbefqltVap3Rad7jnTL3A6PocG TA8lpUb4CZzXWdjrQ9CWt0vxaU+60tqVN7HN17Kbe4srWGCYGGUQ2C9pyVQMngpHsezVh5QEV/X 5vl3KiLBitLRvri+RJvejaTJFAr8i822 X-Received: by 2002:a05:6a21:6f16:b0:3bf:8de9:c647 with SMTP id adf61e73a8af0-3cd2fa2dfa0mr14028111637.0.1787320608326; Fri, 21 Aug 2026 06:56:48 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:773c:1c8c:24ea:eff6]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327d01ff056sm19972277eec.19.2026.08.21.06.56.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 06:56:47 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar , stable@vger.kernel.org Subject: [PATCH v5 03/17] rtc: rzn1: Fix weekday underflow when alarm crosses month boundary Date: Fri, 21 Aug 2026 14:55:54 +0100 Message-ID: <20260821135608.275233-4-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar rzn1_rtc_set_alarm() calculates the alarm weekday from the difference between the alarm day and the current day of the month. When the alarm crosses a month boundary, this difference can become negative. Since days_ahead is unsigned, it underflows and results in an incorrect weekday being programmed into RZN1_RTC_ALW. The RTC core already provides a fully populated struct rtc_time for the alarm, including the correct tm_wday. Use tm->tm_wday directly instead of recalculating the weekday from the day-of-month. This avoids the underflow and ensures alarms scheduled across a month boundary use the correct weekday. Fixes: b5ad1bf00d2c4 ("rtc: rzn1: Add alarm support") Cc: stable@vger.kernel.org Signed-off-by: Lad Prabhakar Suggested-by: Wolfram Sang Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v4->v5: - Added Tested-by tag from Wolfram. v3->v4: - Made use of tm->tm_wday directly instead of recalculating the weekday from the day-of-month. - Updated commit message. v2->v3: - New patch to fix weekday underflow when alarm crosses month boundary. --- drivers/rtc/rtc-rzn1.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index aa27ad7f5941..8c70dbf8c7ec 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -260,7 +260,6 @@ static int rzn1_rtc_set_alarm(struct device *dev, struc= t rtc_wkalrm *alrm) struct rzn1_rtc *rtc =3D dev_get_drvdata(dev); struct rtc_time *tm =3D &alrm->time, tm_now; unsigned long alarm, farest; - unsigned int days_ahead, wday; int ret; =20 ret =3D rzn1_rtc_read_time(dev, &tm_now); @@ -273,13 +272,9 @@ static int rzn1_rtc_set_alarm(struct device *dev, stru= ct rtc_wkalrm *alrm) if (time_after(alarm, farest)) return -ERANGE; =20 - /* Convert alarm day into week day */ - days_ahead =3D tm->tm_mday - tm_now.tm_mday; - wday =3D (tm_now.tm_wday + days_ahead) % 7; - writel(bin2bcd(tm->tm_min), rtc->base + RZN1_RTC_ALM); writel(bin2bcd(tm->tm_hour), rtc->base + RZN1_RTC_ALH); - writel(BIT(wday), rtc->base + RZN1_RTC_ALW); + writel(BIT(tm->tm_wday), rtc->base + RZN1_RTC_ALW); =20 rtc->tm_alarm =3D alrm->time; =20 --=20 2.43.0 From nobody Mon Sep 28 12:35:06 2026 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C92B6495039 for ; Fri, 21 Aug 2026 13:56:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320617; cv=none; b=SpjrdeDNcJ+Xe/CDYukMHXttSAkQ2i5pS3sL+cXc9cbAySz/TD3e/+zoAQI3wWpdYF1VMiESSwQo5Jlr/4oOipA0+PP6LTCPegsS3A13cmz/y5qhdeLUb6/x2H4s8UjMWEJKYFIQEg05Z0KUxHkIYq8+8spqBirJU707srNcJgM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320617; c=relaxed/simple; bh=UTdaoDgRCp5m/9ZYPIxOt/TUt2k/3Iv3XjJlMaJ38PQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JNulYke4yaXbqBYy5hOXXO8fer86bw9L9fbh45m0ZzKI4TVkVV7utrxCIr4JZi7YxKQbDIqBvUjHLTOzmT+qHWiFjR0xnVkY/IdBGnin4IBGrvL4LlN3X6i2cL7toOoWA4Nh6P4NQcCoH3f63bLjPM7Ty0i1FmPu15EOSbMgrIU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SP7LBz99; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SP7LBz99" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-cc11a30a259so1045037a12.3 for ; Fri, 21 Aug 2026 06:56:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787320615; x=1787925415; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=oIn/JR7QSML3LbxalAPrR4Gs+07rBcCA789wVYtHyok=; b=SP7LBz99tQGWq5iWJtd6FvXFClJQLZm4iULsiJcipIxbMwwVBOwR1DgTxTRYwpQtSx uzPOpOM3/7ZB4+Ygzbe2lREPI9RVwA5nt5ZtXPdHWR9DIdorTpDUR1TgxqdZ//MB3/qq vf4yJ5TXlFvuXGjR8kkGfyn1a6RqifzzafkRcLJgCqiKfiwDjGWliDiKxeWMaXdxnSGP NPQXhwBBPEcWMlOR0QEMbc0RoqPCJmlbcspKTdS52wVYYh0FCVoGN/fFmQAT3OvtXQfE j0yCMSqrXOSXwngKt5ZqOc94lJ+vqHo23ao3T0zdAXhJwjF+2e06aknPU++bdwfn5L0p Bx+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787320615; x=1787925415; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=oIn/JR7QSML3LbxalAPrR4Gs+07rBcCA789wVYtHyok=; b=g4iDPteIcsK3VgYeuRSccwU3rL0p2ffnxkhzao4/B3jHl17fNy8hs6mPUl/faPmm8x gxA8m8MPHCrdu+786htj0ASmlkYlb3DGZEQ0DpBFFxSfvddQMO9vBxGOMxd/ljT+t6ZO AK2kawFwvt1YFdiUCNEbFdwGiHGljup/nzHwZuZInZncDYcxBuvKr0+BJuZ/7/EUQic7 mYaX5kD2dUADWAheHM46Ci2xYaNruRomJ+J5x6BlA8bByWaoPUlOChD9dJkO+oGZGe+k /GbEGlx4gqQTlVdWrWDGEf9sFS9NFL0iR2fD6K5wI/atCe+2zv6ITzw2mwG18AG7NQ+1 qv+w== X-Forwarded-Encrypted: i=1; AHgh+RqLEblJ9lyhXZzOaUSckxzOuJaljnCKl66ZOzTyCTj8TlAONYP3hPXE/IOTXGi8/GSlk7StUY4s4SInBmw=@vger.kernel.org X-Gm-Message-State: AOJu0YwISLuXCJc54oK9B5V/MSd3WZEiKQ3uML1HH6UpOQqSjTPRr+xu 1ycihE4bYRUljSyIhpDZuzYX5UJWAVTuFvj+/w0/XfX/QvTZR2ahyvF6 X-Gm-Gg: AR+sD10uJLClXIqJOMjlPwN2kJr2IBjTZy2Yrnqtwd+NI+37Qbsw8JhBQhXx7DySDGw If9898p8M9KhaUCEfwKriL//xSA0DV0imyXwTP+lEn1vrFlznbr5iTuLF+4JSsKHbgviKGqvaVY Sp3HSuF+qkL2YZOiF6JM+cpR3IU5Y3rUo919GBtCZxd5ksxAUyL2RCV9C2xjz8ZHzHHf29tt2ZD Q+mMD3NKF9FAwCfl6smX4erfau1QxemjltTbUL+JtGT2wnD6UTls2NrEGnO4L7pULzsdNVpyR9C syQQe93HnQhpmVzhlvf8HLXYiVnpzonbLV3i2ermbquf3bnKYhNhhBQoB0rPEVsAdfLVeVIflG2 gKv+E+HyKNe+8Pra94F3rjqsP2dItVSDNwYqi36jwwUkeeESqXv+wU9kswvpVF4tsbtd9P1b+dB y2dWsJvFzZbsdQ9zarIfNTR9G4SgMnRerUcXIS/7c/DyJsM+poPThJS4VnA+X7cGfhP7ckqfOqH X3BU/YJlkuprs2PvHVmZH/1vKp1OzWM3k6LBBglmiKnm622ur8fsb/BX8pRfWdzrE6EMMDcnqqR j/8ue1DRu56jyWrb0dJqMg== X-Received: by 2002:a05:6a20:ac44:b0:3cc:f008:8123 with SMTP id adf61e73a8af0-3cd2fd9e554mr13238918637.8.1787320615049; Fri, 21 Aug 2026 06:56:55 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:773c:1c8c:24ea:eff6]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327d01ff056sm19972277eec.19.2026.08.21.06.56.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 06:56:54 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar , stable@vger.kernel.org Subject: [PATCH v5 04/17] rtc: rzn1: Handle unset alarm weekday in rzn1_rtc_read_alarm Date: Fri, 21 Aug 2026 14:55:55 +0100 Message-ID: <20260821135608.275233-5-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar RZN1_RTC_ALW is a weekday bitmask where bit N represents weekday N. When no alarm has been configured, the register has its power-on-reset value of zero. rzn1_rtc_read_alarm() uses fls() to convert the weekday bitmask into a weekday number. When RZN1_RTC_ALW is zero, fls(0) returns zero and fls(wday) - 1 evaluates to -1. This invalid weekday is then used to calculate the alarm date and can either leave tm_wday set to -1 or produce a fabricated alarm date. Treat a zero RZN1_RTC_ALW value as an unset alarm weekday and return without calculating the alarm date. Move reading RZN1_RTC_CTL1 before this check so that alrm->enabled is updated for both configured and unconfigured alarms. On a cold-booted board with no alarm configured, the following was observed before the fix: root@rzn2h-evk:~# cat /proc/driver/rtc rtc_time : 00:00:19 rtc_date : 2000-01-01 alrm_time : 00:00:00 alrm_date : 2000-01-07 alarm_IRQ : no alrm_pending : no update IRQ enabled : no periodic IRQ enabled : no periodic IRQ frequency : 1 max user IRQ frequency : 64 24hr : yes After the fix: root@rzn2h-evk:~# cat /proc/driver/rtc rtc_time : 00:00:25 rtc_date : 2000-01-01 alrm_time : 00:00:00 alrm_date : 2000-01-01 alarm_IRQ : no alrm_pending : no update IRQ enabled : no periodic IRQ enabled : no periodic IRQ frequency : 1 max user IRQ frequency : 64 24hr : yes Fixes: b5ad1bf00d2c4 ("rtc: rzn1: Add alarm support") Cc: stable@vger.kernel.org Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v4->v5: - New patch --- drivers/rtc/rtc-rzn1.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 8c70dbf8c7ec..e0fdb591ba91 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -234,13 +234,24 @@ static int rzn1_rtc_read_alarm(struct device *dev, st= ruct rtc_wkalrm *alrm) if (ret) return ret; =20 + ctl1 =3D readl(rtc->base + RZN1_RTC_CTL1); + alrm->enabled =3D !!(ctl1 & (RZN1_RTC_CTL1_ALME | RZN1_RTC_CTL1_1SE)); + min =3D readl(rtc->base + RZN1_RTC_ALM); hour =3D readl(rtc->base + RZN1_RTC_ALH); - wday =3D readl(rtc->base + RZN1_RTC_ALW); =20 tm->tm_sec =3D 0; tm->tm_min =3D bcd2bin(min); tm->tm_hour =3D bcd2bin(hour); + + /* + * If wday is zero, no bit is set in RZN1_RTC_ALW. This is the + * register's power-on reset value. + */ + wday =3D readl(rtc->base + RZN1_RTC_ALW); + if (!wday) + return 0; + delta_days =3D ((fls(wday) - 1) - tm->tm_wday + 7) % 7; tm->tm_wday =3D fls(wday) - 1; =20 @@ -249,9 +260,6 @@ static int rzn1_rtc_read_alarm(struct device *dev, stru= ct rtc_wkalrm *alrm) rtc_time64_to_tm(alarm, tm); } =20 - ctl1 =3D readl(rtc->base + RZN1_RTC_CTL1); - alrm->enabled =3D !!(ctl1 & (RZN1_RTC_CTL1_ALME | RZN1_RTC_CTL1_1SE)); - return 0; } =20 --=20 2.43.0 From nobody Mon Sep 28 12:35:06 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE5B443CECB for ; Fri, 21 Aug 2026 13:57:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320624; cv=none; b=YRcheN82HY1AWQjhIXdzg31Z6XSibBq4PK7eQOVhHsMPncBcQoWV3IsGzIo0XUWHRINJqjaXaMQRs/JRnZRXqo3ZgJIQX7FZr0jSqXsUucOUT4K9Q+ICAwhBFGRGabjSZ2Hsvemj+hj4pG1dmpEr/oTz6CW2vFHB3O8YTHHnGuo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320624; c=relaxed/simple; bh=At5m3bowVGd9aMKqLO6E2xKZxUY4pGoxgPP7q7tGP6Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Wrp4WQBfX45p6Zz3RbvEBgwRtcdT+4oU/khRhVuVXwpb8OcK5Lho66ZhDQQEnO1kry9jr+zhT4UH1lMqfBncC3CSoYlBJrUEet/368YHP6AReHywS1gpVGAuW7SwjGf4EazEYMEv4drQX2UR0Za5f/aILeJIWr/VaMFSvG378gM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sHTjbO9l; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sHTjbO9l" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2cc891373e0so12162715ad.2 for ; Fri, 21 Aug 2026 06:57:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787320621; x=1787925421; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cpJa6Rc5FC+z/scmXNU06IkGTT32th6RwcEKPAtBpjs=; b=sHTjbO9lyK0K1fEBVoFK9c75OnPvzf1DaGpbxflB20LOs/j1BHkeNxXtbCqjFSPB9i 1aprWJZC3guv0eFB0PZLi/7JM0vNLdWTZxYBVzgjkl2o3UOptgU+KGsYzpNkTaKNgqf6 saec1Y4ymd1yN7ae8Y/4sp436aJS6MvUXGX2pyTZjuDp7NZ1hImUzoI9OWwC0pk+/8BU kNhra8PXH/F9+sFbdIHDXjZL/UiruUmfdRRlDXwV3r3mb1qZeg0nvxC+/n22sRgVRE0X 7hApWI2Vhcu/Uh3YwgE33i7UMFU5Hcx1F6PZr8oCwdkzUuXzSPynR1SpZbtO0vg1kXy6 z7gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787320621; x=1787925421; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=cpJa6Rc5FC+z/scmXNU06IkGTT32th6RwcEKPAtBpjs=; b=LopYuBEv+L/ByK1uvc1PozIN0pue6Ianh43/XgbwwSvpF3bbsRce9XDotPOJAK6y0j l8Cm790fQDXfe7EpyXA8zwezy6LgL3s/Q3R+KpCPVgBYVr5OFOPf+xI50F3B7FZVbSP9 0GEb+MhPXC36MRfuF8SCJGbrKHf4KdQiAzeTP+uz8Yn9Fzs9/COJ1gw0fhnGlw280lCb o2n53jwBi6KSt0vDhAgPSX0s8ufsOLFm4XqP9HMY7AvkbqavFbo+QbzjCSiDkLJkXyQG Bs4+nZevNQUufCdiuID/TRz+AnFrW5rpF6PJOaSCW2XQjXa0qjV4iijTuH/Yr0/2CzvA SxIw== X-Forwarded-Encrypted: i=1; AHgh+RqjtnN+KvsME9NJKp3xhWby7BIpJl4SBObvrq1YDfyeUiDkumrjbudTw78Ip3LRz0Sn3lOVyk4DHe5S8R8=@vger.kernel.org X-Gm-Message-State: AFuF++l18LdDU6pJiJ5TEa1PJ9MiVKoF/aoxxZIozAmCwRDpMNdcwhLy L53gsvVbpBPjTeAZU+ASdjz63Wv750uEKW6rMW1Dv3I+8mh6RdwHgL/4 X-Gm-Gg: AR+sD10K/TM4awDp6mvjN0raQ2ehew/Vt+Uw0Bi7Dfmw5aBA7FEf7EkJkVG+1CcfIOO VQwJbYMMjrwAKSUdCoX/9+NQFsKMi+HSJPUO28L5SIgL415WX5RZrQMsDr2GA7Mm6VfSyG/BoS3 g8IRXHhbMbQFRlvsSrO78eIxwtWZv6LXBgewZ7DX4OrKsMKZsFuY3y/zq02rqcEcla5wFHNFhLD g2212QIOLJADPYEcSZUAOnN8hdmLm3tfihcbaJAwWdQ+sqYv2ws253EZZ8A0b3PUh/B/6DyAI3B ZkKoLzRONWLyg7DLmq0wHSEM372pF/pRryc4pVsevuJtZNIDlbhSCWqzAdvQiIs4tuQ+KOs+vsv W8DTOEUWEkKw/uMH5qFYAh5Am2DDS/5dV+qMeaQyOOKygSxoVBpXl0LIrjIyE1wC06NlS9Hf7NK 5fYpsurCB+Twea80eiL4XTWB1SAtj/Z+teYvR8Vhl2G+nVRDq3iUn585jURmfzAoAgepQi4f6Mj ZnrocFpyyEFXgeOwmWu1LsNOsG/G4V/naF6hsFsbGPDCz0C7F2vJ760PPcQSJZrXQsJXc6JqwAY Xn90zCYDz4RVLr9Ky3ju X-Received: by 2002:a17:902:cf08:b0:2d5:3f5f:e645 with SMTP id d9443c01a7336-2d64b0d8789mr134872595ad.12.1787320621316; Fri, 21 Aug 2026 06:57:01 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:773c:1c8c:24ea:eff6]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327d01ff056sm19972277eec.19.2026.08.21.06.56.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 06:57:00 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v5 05/17] rtc: rzn1: Fix alarm range check truncation on 32-bit systems Date: Fri, 21 Aug 2026 14:55:56 +0100 Message-ID: <20260821135608.275233-6-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar alarm and farest were declared as unsigned long, but rtc_tm_to_time64() returns time64_t (s64). On 32-bit systems where unsigned long is 32 bits, the assignment silently truncates the upper 32 bits of the timestamp. Fix by declaring alarm and farest as time64_t and replacing time_after() with a direct signed comparison, which is correct for time64_t values that will never realistically overflow. Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v4->v5: - Added Tested-by tag from Wolfram. v3->v4: - Added Reviewed-by tag from Wolfram. v2->v3: - No changes. v1->v2: - Added Reviewed-by tag. --- drivers/rtc/rtc-rzn1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index e0fdb591ba91..44e8db466cb7 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -267,7 +267,7 @@ static int rzn1_rtc_set_alarm(struct device *dev, struc= t rtc_wkalrm *alrm) { struct rzn1_rtc *rtc =3D dev_get_drvdata(dev); struct rtc_time *tm =3D &alrm->time, tm_now; - unsigned long alarm, farest; + time64_t alarm, farest; int ret; =20 ret =3D rzn1_rtc_read_time(dev, &tm_now); @@ -277,7 +277,7 @@ static int rzn1_rtc_set_alarm(struct device *dev, struc= t rtc_wkalrm *alrm) /* We cannot set alarms more than one week ahead */ farest =3D rtc_tm_to_time64(&tm_now) + rtc->rtcdev->alarm_offset_max; alarm =3D rtc_tm_to_time64(tm); - if (time_after(alarm, farest)) + if (alarm > farest) return -ERANGE; =20 writel(bin2bcd(tm->tm_min), rtc->base + RZN1_RTC_ALM); --=20 2.43.0 From nobody Mon Sep 28 12:35:06 2026 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B372A494A08 for ; Fri, 21 Aug 2026 13:57:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320631; cv=none; b=B2BJvTOrgPZYd9DnroTPfRHE404CaGEp71MGaq8kD+F/9YwpmcNM2g0F6D8OnC4Om78AWfTImVkwIH1q0P1UH+Qnvw6qMlL0uBJcLAmQrtNaQ1Z6F//KBZ19NudLY0QI2UYXoteBG2aGQOBYkoTQ6Ds5U6bz4qYRy+iaEjtwHfE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320631; c=relaxed/simple; bh=bbhgCz/PoN/VYdzPfW9SJ8KfnpB9xgPHLKXOVw3ZwZg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=le1xJOoG1xGdU1snzCpxB6qk1H46HALRVDM3pEVveYH2HmV7/DXJbUUFA/kLDSz+SJG12kRq9m6QDHGj11Qe8oDQQGb3Q6AvoXdvCmuNBZswB72wKK0XHLAWSfyV4hznjAIripMQE7aAwTcXokgpspSNW4tn2F/Hpiz9R+SniPg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gZiWBeC0; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gZiWBeC0" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-381c51fde6bso1079656a91.2 for ; Fri, 21 Aug 2026 06:57:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787320629; x=1787925429; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=gyOnyMmEXCZBKLQwxjb8ydf3Caf3mgLgb333lC5gOLY=; b=gZiWBeC0bNZZc8Um0ba82DQvLE2/79GxbL1RK6D+w/OqbYVvzHRum6X1BL+87376qD HwKpsUEsS2HQO1QWJx0OMIwXXqxPiVGuJmWFsOgPmffNYnmFLXLR+TBgK/VfosN9Tk05 26RJJkvZpRPz+8ZocjOzpr+kvEilzXv+t+0a2uISg2hf/udZ7scI4FHrCw9OCEJ0IuLw lDjCZ5Qg13xQweFnVi2MHcyfsX8m4keJUjyLV5zG8Lk6s1X36sfxm4XAkVt5hd5R2XC4 TUv/l1Kt5ZkeIK+gOTefF69q7tQVndDQCMqnyfv9XMg1j/DtyxfDp8AKo0Oub9V0in+K FZeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787320629; x=1787925429; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=gyOnyMmEXCZBKLQwxjb8ydf3Caf3mgLgb333lC5gOLY=; b=renNyjWAKGopgBRsKWTyACF5/RoJwhdQ6u8272lN0IJYYocqds7ytu29D5/l3iUPBR JN49sZWvNAclrEXAaFCYttB7G/Dr5InQrxhNBPCsr1BpmVYpoO2deI3nmEMOIOMzdcOr zBDbAfuMRGmrGL4qAFdXZ9paC7MmZcUflpjg80EsRr1uUUW7qdyu6yLGP9pdzceDI24k TIT/mCdqronj3C071Aq5i5VWwR/o6OAmYw+eQQHIPJrPZKoekve9HJ093q/YRX1KfnrG hryXdjBMFNN1rnTeI8aueDnjYUZtitz1+ecVPBmmJXgTHKMYMXvvrEsG5dSJsW+O9rQ7 osug== X-Forwarded-Encrypted: i=1; AHgh+RrQkigcodKG+kOZ+pJK1JwKzX3RqQkbAMJX2YyjrDpFVT1aJmAnGy/XZILr3S8c7/ZSsnNExDYIJAY6/Qk=@vger.kernel.org X-Gm-Message-State: AFuF++kn3m+HXlg7z9VS8y43IuDwKB4lzkZ08/zm8Elz9wA7G3sxvmJT zp/O0pO9fBh0UO8MgKPzl06SNd7RvOA524ER8KMjmDaKmHMqINhrem8h X-Gm-Gg: AR+sD11kTZrSSI7cX2MWxjtIuSlIpOqpzC7EX/lFCmejzc8ME9I4chb+NkKcWPtq1oq PhxtLUn0ijeXlBVhwq+qrABoY/fTni6PQZ9Tq61g57Aq95FYk8cOhyQwOgdhuFHFSXCIkaI66Qb TObSAH1s6YmKbGSydR11Co+4py4E/gtIKthkGBY1VH9THdgo3SOeTmT024KATqxIVo9EXt9KqFE 19F0anZ37KvUSeh05KNBb3EHIOjNNaZJvOm6PehViAybMFPR28SDcIUUuLT+8wvWsrFK+wvKZap hBqBmObrIV6Md9I0YPk5geFtLiBymLZrNrcr3n7c+2J0Cn9LVPFz2TmsZpt09Wobk32Vx8wB0ac 9x2ZxtKhvS2e9N7epCuJjHZIRTgS7jbt7P+4cugdTCVKiBieXnmQC9KOZ38Y3E5iUs/qNAl7rG0 54Smq7PTTSYDPJju2e69K4R3LnA1qY8vbMIiFn2ab9Ggf6wmSyPOyrkBg1iJSqbfHivDeoSvzKu 2bgOwzHejfakwxQw1EMEJcY2TtHfl/lgb/eYZd5MtU9PEAvK41PeeLqZOqOC8Jhbq7PfWJRNwsj 95CNMwJAATGQYtBCZz9FOQ== X-Received: by 2002:a17:90b:314a:b0:37f:eafd:3505 with SMTP id 98e67ed59e1d1-395c3522213mr11052450a91.6.1787320627942; Fri, 21 Aug 2026 06:57:07 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:773c:1c8c:24ea:eff6]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327d01ff056sm19972277eec.19.2026.08.21.06.57.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 06:57:07 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar , stable@vger.kernel.org Subject: [PATCH v5 06/17] rtc: rzn1: Disable alarm interrupt before reprogramming alarm registers Date: Fri, 21 Aug 2026 14:55:57 +0100 Message-ID: <20260821135608.275233-7-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar rzn1_rtc_set_alarm() updates RZN1_RTC_ALM, RZN1_RTC_ALH and RZN1_RTC_ALW using separate MMIO writes without first disabling the alarm interrupt. If a previous alarm is still enabled, the interrupt can fire while the alarm registers contain a mixture of old and newly written values. Fix this by disabling the alarm interrupt before reprogramming ALM, ALH and ALW with a call to rzn1_rtc_alarm_irq_enable(). Fixes: b5ad1bf00d2c4 ("rtc: rzn1: Add alarm support") Cc: stable@vger.kernel.org Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v4->v5: - New patch --- drivers/rtc/rtc-rzn1.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 44e8db466cb7..09631a3a5134 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -280,6 +280,11 @@ static int rzn1_rtc_set_alarm(struct device *dev, stru= ct rtc_wkalrm *alrm) if (alarm > farest) return -ERANGE; =20 + /* Disable alarm interrupts before reprogramming the alarm. */ + ret =3D rzn1_rtc_alarm_irq_enable(dev, 0); + if (ret) + return ret; + writel(bin2bcd(tm->tm_min), rtc->base + RZN1_RTC_ALM); writel(bin2bcd(tm->tm_hour), rtc->base + RZN1_RTC_ALH); writel(BIT(tm->tm_wday), rtc->base + RZN1_RTC_ALW); --=20 2.43.0 From nobody Mon Sep 28 12:35:06 2026 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C62D43CECB for ; Fri, 21 Aug 2026 13:57:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320636; cv=none; b=e94Y+z3HQVYzHxjhCjxm3bsjIFt8gpIqE4KxNmQdb4uRXBxp17PEpVpyhbUFBJ5oB9PSKr0IjPmer4MAuXZB/Kk71HzhY8eLmWRHgFR5xkFH/ZUij2v3nUMr46e/jxhHkUMttIL6/iMatGL0CyVX1iy+FrhSxWXDUM+OXwV2owc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320636; c=relaxed/simple; bh=AH6oUfHnmcXsnjm+DxjEoBqd1Vb5FnHglP4xh9aXyJo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uVrRSZsmscGug311FHrw5jhigoIb0EGJSj7PXgq2nLvNHBSeg7liCbFbyh+tqsN/q1uyQAxdb73XUN4GQDCNiesztj1VT1wdNP+87EoNwHqEzXmVR+a/i9adZt3oAuqBvXFU50C1ponO1WbLQ54HzVw8vEcUotnxQyM961I8teA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dZeQPy5o; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dZeQPy5o" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-cbeea240819so616550a12.1 for ; Fri, 21 Aug 2026 06:57:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787320635; x=1787925435; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4G1vL/8vEDUkF7LKjkQY5Lqad8PP0uoAQCy9KkC2pcc=; b=dZeQPy5oWrPmBZoAC7p9feIB7O2ObUy6iBDR+P06GpkVb/USsyALQ/i4rLEhduOSpb 1V9sEsFOlRVKiub+uNv7KVAW5gCKXDIW7a8L5MFoY8w+d39rOHWVUr8wQOmeH6xDkT1s j/1AnnbeBIqzR8nsNJ0pisGbDHmVhGU+9qJKcITbXuawUSO97YPommA//1kL/6JItfnO xO5SuRz4wRFgQfqiv6XAnPj4r93ugOe79ZBzkxr1VM3JT29cpmqOUBKde9XzK3buEjfL 3Yvxks2kdiPLCuHFzxNWAfPBgkR+7FqE5brRUO9R0V83Ba95eYCexdkiVQ3BLraZfOvv k8VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787320635; x=1787925435; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=4G1vL/8vEDUkF7LKjkQY5Lqad8PP0uoAQCy9KkC2pcc=; b=IJOi0e7txOT7RBJYTuEdTjTv+bcmwjkOWDQYK7A/Fy3yYkZscJX1I9Bo8mbD1wahbq eJ1jCH4dWJmQjSvIr3Eqh7YdQ/T4+5MN5KS2KlGrIyu4pzK4BGZ1bCG9UR7KfraGG+Df fKLulounYT4cOAHXg/Om/nb74Etl2EzEuW0pqr4ITepHLFot5f3Y9GhCeEYvM85C2HoH ul+P78oYZ8xu1AvNxNHx0/8k9dqWXtwxWkikFDkGnd6DhFD8bZ1nzOvIuJG5MS4XzmV3 3ZIZg6oG9kLq8rcOquwAAa/lP6ttnmT+9VLpLdCezb4YU436bR5Y7sb3jKPfKu49kQBX nWrQ== X-Forwarded-Encrypted: i=1; AHgh+Ro0TT+B+T+WPJrk2GuRXdSGlWxCuE5KHLA+BLA10F2pHaDbf1OAH4lSJhDTje5HOFjgyal51L0lZ9ltAPI=@vger.kernel.org X-Gm-Message-State: AOJu0YwBn9/KaS6LyLsYbFdSwY+cT/Eq5AuMVP8YQ6Dujpi1SVUHpGs4 vJ8Dw4n+uSbt/OSMLBUBmHiK3HksTG49VLuC4NURKMAHjPO3lLCLECrA X-Gm-Gg: AR+sD13apFs8bxM2U1mnMx+ayQrKbK+dCO5SBqwmMBugMXqj3UIXSd4yREw5X1Z9U+c TMtRuB0AT5oh+XeLFm1Qdon8wl1/1roYCgz8F9PwGFPRtW8W1mLiyfJaWafcRE0FJhoPFeH8VhO 7Md1/6yCPQojQTEKFQOjbi7IP9l44PsQRVYPK9xbqpLohuuu7m/luYJXoEkBkok8Z+NMUnhzYg/ R7DbunNpS2HSQVHQd6XMacbF27e6iYgEBMGDdDmSHOQaprx4szJ07uAk3FnQXMX4G9J3bCuD1TT dLir8GtrPRG4DAD+kZSUs/6HK+TTk409bZsCtSqseSnOnI6Fl4mvEXIlzCdvw3/WNek03habEoR fVtVbQXNE49tjAHuwoDYDA1P4waNwlYQY9DRHB1VC1PUzUOuv2WHQ1nzLyb63vNPDP7WZ0EPpul 1tD35W068+hBEO+4cfZFsu7XC7dbiCge8rRXc/B6CePEkEwt5Qk6zJ0pzgOLblCOmwkTw/uM+8A nWUn6QuzuJ7gJq2pIehNqBEQ915dYXu2uR6QIGlDaB9wcag/e+4Pw0wtncS2tTDOAIdcXj8W8s2 lK8YYglcIA== X-Received: by 2002:a05:6a21:9d48:b0:3cc:fe21:bf6c with SMTP id adf61e73a8af0-3cd3009d046mr14054819637.11.1787320634827; Fri, 21 Aug 2026 06:57:14 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:773c:1c8c:24ea:eff6]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327d01ff056sm19972277eec.19.2026.08.21.06.57.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 06:57:13 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v5 07/17] rtc: rzn1: Fix malformed MODULE_AUTHOR string Date: Fri, 21 Aug 2026 14:55:58 +0100 Message-ID: <20260821135608.275233-8-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Fix a malformed MODULE_AUTHOR macro in the rtc-rzn1 driver where a missing closing angle bracket on the second author entry creates an invalid format. Correct it to the standard "Name " format. Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v4->v5: - Added Tested-by tag from Wolfram. v3->v4: - No changes. v2->v3: - No changes. v1->v2: - Added Reviewed-by tags. --- drivers/rtc/rtc-rzn1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 09631a3a5134..a7f22a491d61 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -524,6 +524,6 @@ static struct platform_driver rzn1_rtc_driver =3D { module_platform_driver(rzn1_rtc_driver); =20 MODULE_AUTHOR("Michel Pollet "); -MODULE_AUTHOR("Miquel Raynal "); MODULE_DESCRIPTION("RZ/N1 RTC driver"); MODULE_LICENSE("GPL"); --=20 2.43.0 From nobody Mon Sep 28 12:35:06 2026 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C45F495500 for ; Fri, 21 Aug 2026 13:57:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320643; cv=none; b=QMnb5YxUW1P812rwhQI9FteLXyLmgJGor2VteYw3CezUmuf3fmT+6jRWrz3ihfUpDDFOCb5TwS85AXDSxyBs2NfIusNLkjVlvX5jBfgCTja7zLneqaZbGgqGE/RD7hnUxlnWmN+1fxafZsH4dlKmAsJ/SVgu0vrPdQ4PaGKLi44= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320643; c=relaxed/simple; bh=uGPIzdxc4KXBsjdGJiahS3bTCttkeJU0jZQMXBJYgIg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eiRtEPV7P5e2jL3xN7JNs51Ozagi8Lu3ZnSNJc36g7YQqMXXFKXpHsqtmzlmL5zoU+yCBpBaaRVvtU6MlfWfeiNhr98cyWEMFUhOikpS+C+HkZ6ZXtYlNmeuYW8DxGYoJyGEW79KVhgbYctTqfDidoUHhWUc84N/XSoEa2/mZjA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MV9bhoit; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MV9bhoit" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2cf50c6f235so12756075ad.0 for ; Fri, 21 Aug 2026 06:57:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787320641; x=1787925441; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NsGnVgZXLIDkEiMG9qEO5rplY3MpoMwwrWWVu2HHkug=; b=MV9bhoitF3aUd4fbGnqC/4IX6MoVOL1j0lbyv6jJcAEgmMMzZzOTO4RcMjqAYd1rTY qts5lgm9IOGvg6JEiaELZpneB98ZPtuL00e1+98tCuRBOFx4f0X4eI1ihba6rE7s03nf 0HX/i1Br4CPlv1dL8B2NqE3/elgW8ZoGtC5r98++oezQaub3OUzKjSBxuky0z2b/fU6Q ITIblVI7InG2BGDGZz8QYviUaGDDOD5oAgMMe6N7rg5kcARuPwp3yeEWgG4i5e++zUrr hKBU7AZdXPkYUfGxT7YUvVkXWWtr4He9MGBoiMfrj9WsDd0YEjsX58rudVTm12Gz5EY4 A7dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787320641; x=1787925441; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=NsGnVgZXLIDkEiMG9qEO5rplY3MpoMwwrWWVu2HHkug=; b=MphYrQ0cSwf1LnfyMvltIvCdJV79WDs0pJOFsuuWD0Tzv3vPW+ZG0M+DyfSlAcYlwE 4kl+TPtnX8KF2CtI5oVirL2zBR4wIP+qjziXpQFViyerxVFRbT3dR7w4aWOfyLStPWGQ Mn44s8mz0LThU1Ya8slksW/RYTgUIYAmRLKj71uLYiJjR5Cz7VELVXSyipmVt6GsEpm4 iC38zFH8iK9VV5pxMYnqA7ukspbCWCCo4Q430fR/55w8PEegWMQpsPC1s3mEqqF8jUpV fMS6uqwoHDYGGu5Wi/UGubU6rv1I/JMc/k1eVNuZnstCdfCf2gR9NvHK8D9AAQ3MMsI5 zIqQ== X-Forwarded-Encrypted: i=1; AHgh+RqjJnW+0Uo+z8SAH7WV4lemyYKndBK9O8/wyCZyAenLN0jQUVIJBp34liP3dkhFPaWlxEovO90QS6ZZGwI=@vger.kernel.org X-Gm-Message-State: AFuF++mBGrxkwUbWEId0os6TW+thKddBr7y0gqAFu5Yu+MgZmmdC+xBc kyC/k44Jeigepe8ZnUUUW+2Oj2sOaoeCe6n3pDZVnblw3iLPb1jaMRAq X-Gm-Gg: AR+sD11QQ+5ofs2Z/WzgMAYjJurx7D/pGfupf+T+XcditCc5TuktaTIPdBg3AZDOoHP 73MnCGsjSjcmz0vlBvJnbLPiLHEp/DbofqP52R8RAc06GXYUpAED6JMNU9MPjEMCX+t1E7PM131 XN+BTtB0pTxEJBXYT/kjR/8S7fWpJawYjkTAmuophchV9vb0xjrfpSAKwNhKjsavMoXz88pxp+c npNtnHFcaWWL5qNCRXq822sXghUMGUvAAfb74wr4mj0ZNQ3tz05dK7/2HzIwFofr+8+/voHu8sX aKmH7oA3NhqyPIFQ7HM2wc7s5k2dTLjLFXOJ5mnR8REC+6AWtT/8VJ8DFt63xX5eYNtUmNCxfq1 Q+RFaU3Pp4DfI/WNElYn5x3oJyDw88wm9gwHj6McyzCP1BpVOg/FF9JH63LZOjMsWS63QY2Ybyk PUbuIOEHovUHjayLRAc/PT+uzo4mmyoyppCy5Yv5esacOTCKolyFD4OlxfMVHZa3CCoPv/n58eB Y2KEyQCYQcx/uE59jRVtml5VcRSqKLma1prNM3HDZpE2d105VcJ4lrccF1N/coac9oy3y2hPma+ IcndK8Xecw== X-Received: by 2002:a17:902:e785:b0:2ca:6eca:492f with SMTP id d9443c01a7336-2d64b0e2c7fmr140267145ad.14.1787320641223; Fri, 21 Aug 2026 06:57:21 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:773c:1c8c:24ea:eff6]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327d01ff056sm19972277eec.19.2026.08.21.06.57.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 06:57:20 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v5 08/17] rtc: Kconfig: Broaden RTC_DRV_RZN1 dependency to ARCH_RENESAS Date: Fri, 21 Aug 2026 14:55:59 +0100 Message-ID: <20260821135608.275233-9-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Replace the ARCH_RZN1 dependency with ARCH_RENESAS for the RTC_DRV_RZN1 config option to make the driver available across both ARM32 and ARM64 Renesas architectures. The newer RZ/T2H and RZ/N2H ARM64 SoCs integrate a closely related variant of the RTC IP block found on the RZ/N1 SoCs. Update the build dependency and expand the Kconfig help text to allow this driver to be selected for these additional platforms. Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v4->v5: - Added Tested-by tag from Wolfram. v3->v4: - Added Reviewed-by tag from Wolfram. v2->v3: - No changes. v1->v2: - Updated help text to keep it generic and not specific to RZ/N1 SoCs. --- drivers/rtc/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index 01def8231873..d23a0fbe8d89 100644 --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -1635,10 +1635,11 @@ config RTC_DRV_RS5C313 =20 config RTC_DRV_RZN1 tristate "Renesas RZ/N1 RTC" - depends on ARCH_RZN1 || COMPILE_TEST + depends on ARCH_RENESAS || COMPILE_TEST depends on OF && HAS_IOMEM help - If you say yes here you get support for the Renesas RZ/N1 RTC. + If you say yes here you get support for the RTC initially found on + Renesas RZ/N1 SoCs. =20 config RTC_DRV_GENERIC tristate "Generic RTC support" --=20 2.43.0 From nobody Mon Sep 28 12:35:06 2026 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 398372931D9 for ; Fri, 21 Aug 2026 13:57:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320649; cv=none; b=XGNzZ8H0BWz60a4jUCh2IYjQTdxPBjHl7M9EotGw52Khq6WOA77h/7SfA9dPturuQfOsyKtUJtudheJ7jlX3bcjSKELvz9mHMREVmdEi7iApnuH0Qpd04hwdWjECfnwHIiBDiBKKaTaNnZ5HmjXqdvWyzScrl8jZ088zQpbnsw4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320649; c=relaxed/simple; bh=gBBs6/Ia6sSV95Cqo1e4c2MfPAgzo8DPkk69LA9oeJo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nVF992LDFMiYxJXKW0F/WyuTfEI7iTnDzNW3MA1WZVvFFUU0tlKT5D5Vbn/hXlSQSz6A36qfcLVXmMiSlY3Dq1J6vLo3CX5fWqG1H40nvuT8eIwYs1YQn8FdszxYYdTij3yllNHPc2sz4jnvg+9B7DBcgLm5hreFHklayNTVsxQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=k0DBEXGs; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k0DBEXGs" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-cbedf433a99so987203a12.2 for ; Fri, 21 Aug 2026 06:57:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787320648; x=1787925448; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2YJ6zhi/Ow6W3tSjF84cEQa+6scy6/f5V+3PwsGj9A4=; b=k0DBEXGsNvnzXh4ighT4wkhQELGDx5KC/Z4omO7zYMxWP4ssSt4ZatUjqpS08Lol57 O/kd5mUm9iAmpBQvhL863tqvahR2xEVsJMvKOtguGe70pFLob7vuhbpgIZrPEqR0dbwr 5CsDBljk9VnAiorMrK98DA4anaDD5kRHskHiqj3W6NJ1hOYOtSs6e3lUZrGdLoI23KJw VLu3bQmBMulNLLmdIF471xa4t+MBeImCY9UlE2+kp3EK8uLamDZ0vOhsCpXbxWnNtycu 2dMPcA0imK64YIReNHi0fhm98757ogczBq6QQqpdrqaMtqLp+UqZAsWbvsefQIUIZGYn A/Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787320648; x=1787925448; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=2YJ6zhi/Ow6W3tSjF84cEQa+6scy6/f5V+3PwsGj9A4=; b=VKfc7gY19sC2SoHeVprXoUzLMkGLc2yACkKI6aSBpGKUcrKr6Bvx/CrMPy/XpRNK2N 7SncanrvX7ZxbGBDcEGnf4bcSV4zprRCSJxqOKemUzV1blqDfrRoQPLDHPLk1jTdt+VO 9ftEUsiYQlUleDKkxT7fXfhW2Xbs/HaaMmUAV5L7l2yISBQP7JUVQT7XV69miKDzNKNz QZJxPwlZ9VC9XnkuRZvJCh5BSzaQqErgKLUU9zwBwwYK4hallTLnnbOhezOBPsldH3Mq Ff6w/Eix8Wm5bda1buVdB4ULBoUnCxaE2DCgWyyfVc2aDQifqpIQderkJ0FY5f+S4ccf yDdg== X-Forwarded-Encrypted: i=1; AHgh+Rr8wwY0GNZOs460Cc8iJDJD8aXsVRK6S98xX/0tN7Y1ew21HIVuPH0mitlPnfvdM6F14yfQ1mR7NUiscIc=@vger.kernel.org X-Gm-Message-State: AFuF++lrN4ewMY6XVX94FqPOhoFkV+P7b6tbWTnvcUbMbZ+5nzK/AVcT FcF9ZxMYAJahs5fjOT/8pIyD9pp49jsPjJnc4nA/M960NVjX81eG3OaR X-Gm-Gg: AR+sD13dH5XPCpZRUmiMlZbFzFjx8OmiTc6uQW8C3jE+t2LKyXGA1lFY22OtzQWo+jG aCSPXnYZ9qPLCckVOp/T7KnVrxkLLlc7K2ltw76doS/vdHlQXjJsQ4a5CRe5FORPS7bPj+ncB2m mUm1VVz09W45iSzXlgI8lPksCWrx7ZckJstnz6mkRjVzlkaeH5N5OwtzSyuTv/eNVWLalUwH8FH fXJ7WSRqdJppQVJoA/a/sg3Yi77bY5pqT5FrgqmOu+5MUdxGV79v6yPt+69g7Fp6JjcbboS4cXt lbmGwyop3Fq2lmFtjg9UtJDPLt2hUrOYQfuIv+dYK6K8cRHKQKis4fllJDdAvvZJ3tfR3IvqKO3 qTALPjaAn9OAZItwITCg7DRa7FfnJ3buDthPTt1mNgerxmRMPktAjNY4663jpLECx6zlDxD3r9G skpmtMXwwU1kcCekSXQ+T65uU2tmhe7BVhnjmznKkfxzlWsN8CX1thuddrIpQYS6wS1k+U+tdlT BDMldAUwK4GwSM+4Csjd55pYTcmf6cnKS6znwVVEYdOA3ikbaS1Y1FWC50+n7MSsg3jUjcqYG44 Fw7luUVGMA== X-Received: by 2002:a17:90b:2687:b0:38f:26c7:165e with SMTP id 98e67ed59e1d1-395c383cae0mr13124474a91.9.1787320647529; Fri, 21 Aug 2026 06:57:27 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:773c:1c8c:24ea:eff6]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327d01ff056sm19972277eec.19.2026.08.21.06.57.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 06:57:27 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v5 09/17] rtc: rzn1: Use pm_runtime_put_sync() Date: Fri, 21 Aug 2026 14:56:00 +0100 Message-ID: <20260821135608.275233-10-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar pm_runtime_put() may trigger the idle check after pm_runtime_disable() is run as part of devm_pm_runtime_enable()'s cleanup action, leaving runtime PM active. Use pm_runtime_put_sync() to ensure the idle check runs synchronously. Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v4->v5: - Updated commit message - Moved the patch prior to the patch that replaces the .remove() callback with devm_add_action_or_reset()=20 v3->v4: - New patch --- drivers/rtc/rtc-rzn1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index a7f22a491d61..6a434cb418cd 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -492,7 +492,7 @@ static int rzn1_rtc_probe(struct platform_device *pdev) return 0; =20 dis_runtime_pm: - pm_runtime_put(&pdev->dev); + pm_runtime_put_sync(&pdev->dev); =20 return ret; } @@ -504,7 +504,7 @@ static void rzn1_rtc_remove(struct platform_device *pde= v) /* Disable all interrupts */ writel(0, rtc->base + RZN1_RTC_CTL1); =20 - pm_runtime_put(&pdev->dev); + pm_runtime_put_sync(&pdev->dev); } =20 static const struct of_device_id rzn1_rtc_of_match[] =3D { --=20 2.43.0 From nobody Mon Sep 28 12:35:06 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D02F4495500 for ; Fri, 21 Aug 2026 13:57:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320656; cv=none; b=JJD5s8bB7FWWlBhef+rch6aMbaBZ4IByAnpg1mBdWOupALfrr2/EImg1BB1j2l+EIaohH3fN4GvW6zn5WLmSPcIUAir1YNqOQCTMTj0SoWql+pToyHs9Xs+/Bs0Ze2Y/LW66Fp1ZESaqLnDmOwPxGCVmCAlz0Ujj5ODcFjAk4LM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320656; c=relaxed/simple; bh=IluQ6/88LjvYk9tKrCE8MgZCp/KUwgzS1AviHu4hA3I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=l5pmIM9JTZTSorUW9TCzBlx9rPay1xp3+iA06Vq+BrzE0i9XHlma0cyCeYJZHayYeNo7AjvB7xq9NeAO/1Tbux/KVytfTCVghozHhGM0ji3+vkukik2AXGGfrqwoj34aWlTj9A4YsZCSSf4/FVf527nm03VF4rCbVVyiQzb8mM0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qpqhsCbM; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qpqhsCbM" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-38f0f132f56so1486395a91.0 for ; Fri, 21 Aug 2026 06:57:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787320654; x=1787925454; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ioElP7foXHU/zV+3aMWaDuBuUqmVQTzgyvOHav4k8hU=; b=qpqhsCbM+r/RIJ/Vj2FxSJy7ZOoXNbDmeKDn9q4Bb7A/ZQzaeieoH9ZrczFnIcKlzh yRwr9hHxlF8uiTMiKQ8MGF+VIdB4DAF3s3mwIhguCUln7hvTMKF6V7TiMobuy2w4p+uR jPAqE8veLQU0g5e/lNhSVFLNCZgEPL3fKo7sF9jkqc6S55U7GOKumub9C/ofM54OGbNA YHa4/iN6EGMNg7kg82QT2XLFjCMy9zZjGa/8RfI1+8MQHIYO/wT3zUPH1+3MPZVVLNkr SI+0FZcKGpCEIpKUVvSqAz4NII+220+QfBaDK2AWdKyRjUgf+vw1tALeKSt73FAuJ2PU DokA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787320654; x=1787925454; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ioElP7foXHU/zV+3aMWaDuBuUqmVQTzgyvOHav4k8hU=; b=T+k3N6GGHie3Wcw4uv3udqDbeh11Y1HiBjVa15xs1tR3SU65KvSKP4r6/iVQjuHK68 wru0nrEGfCR5mD7AE8WLV5luf5MHxmk/nuU/ZKIf1i2oke/OR7r47Nd3j6Gu4pLBSVWk G+c5Zuy7udthwy1GCnQUM/obz+xBapvhBjCIwYnOF21MoicnmccuKxW+m2VbP5xDpXVU rOVqdALlquYO/AGEqQNL7LERDgtVdSInfIHFacOXFNEQNfa85RNGmhaUjiy80rF3TJv3 C+hnub56m7OXluRYpvUqRAjIwSfczwdqR9VfLKcfPOL4t0Z6vucI/PDOXVM3Zi+O+2q8 3q5A== X-Forwarded-Encrypted: i=1; AHgh+RppqcMHNc7tFqmLOMIAxNGTyo6o7KWxKnVEvnxDaYQ3ml+DSHqVCt9FL8qrlXFwW8GB1ReurUC5G44BcaE=@vger.kernel.org X-Gm-Message-State: AFuF++nIb2WeEzGyHT5Fd7ClDIMtYPDxCjtVdCCQsMArxVGFrFJzskLb JKlRcie3qm73oL11SmZq01UjqlGLNy06okkONam60aveIc2M1deHRF4t X-Gm-Gg: AR+sD109N0HC3zUBAWbeFXUvqH1HEXIv+seqM662rM93okpWWpqkJBLrdizBeOCJ+ap UzyC57IK7MzSwuZrpwm9aPjKDSROGBk0xLzIEIhTR0vaL6nTqTrLvhD6FqjhPTgQ49fnZEYjkxV 93+vq6DWUuiWTtt7k04oSn5tSJGmy6EVYWwPXLLHq6F7/P5mOvzh7qWRSO8zos+k07e3QWazJCd FpyEACQCy65zh2Ev8PHf+MNExKBu9SWahP9mQho52ELa3K3lT22c0mATxQNPm5NDA53/0JnMj8/ 5UPeBI3OPcp3Iv8i25kFDOF+vyAcfpTAOWHq5FhjEW3JPkjl1ARmJmn1Edwzh8cBHuH450BBKJ+ HNWXzpzs/QtC2pWJfPjR5dEnecj76UIfOaKzy/oOrF7kRQwc308LkOiH323TDbYcPfY4v/zECOy mTv+b2oNV1msKISukK7AZhVmnLIRUrkJL1hQCiThxDScvls8G43guCJuiMNPS187H9hFE92wDPY ZDbBg+sKQm1bEoLWSAV61gEvkqLYAOcNZGzSrLGiaZdIcRsoj/bmFvsXnFqNR1MkeJnOKbUkH/2 w+Xs+sZtyQ== X-Received: by 2002:a17:90a:d40e:b0:38f:a81:15b1 with SMTP id 98e67ed59e1d1-395a071b857mr17915084a91.19.1787320654034; Fri, 21 Aug 2026 06:57:34 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:773c:1c8c:24ea:eff6]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327d01ff056sm19972277eec.19.2026.08.21.06.57.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 06:57:33 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v5 10/17] rtc: rzn1: Replace remove callback with devm_add_action_or_reset() Date: Fri, 21 Aug 2026 14:56:01 +0100 Message-ID: <20260821135608.275233-11-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Simplify the driver teardown by registering a managed cleanup action with devm_add_action_or_reset(). This eliminates the explicit probe error path and allows the .remove() callback to be dropped. Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v4->v5: - Fixed conflict due to moving the pm_runtime_put_sync() patch prior to thi= s one. - Added Tested-by tag from Wolfram. v3->v4: - Added Reviewed-by tag from Wolfram. v2->v3: - New patch to replace the remove callback with devm_add_action_or_reset(). --- drivers/rtc/rtc-rzn1.c | 56 +++++++++++++++++------------------------- 1 file changed, 23 insertions(+), 33 deletions(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 6a434cb418cd..02d720e95a7f 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -384,6 +384,17 @@ static const struct rtc_class_ops rzn1_rtc_ops_scmp = =3D { .alarm_irq_enable =3D rzn1_rtc_alarm_irq_enable, }; =20 +static void rzn1_rtc_disable_hardware(void *data) +{ + struct device *dev =3D data; + struct rzn1_rtc *rtc =3D dev_get_drvdata(dev); + + /* Disable all interrupts */ + writel(0, rtc->base + RZN1_RTC_CTL1); + + pm_runtime_put_sync(dev); +} + static int rzn1_rtc_probe(struct platform_device *pdev) { struct rzn1_rtc *rtc; @@ -421,18 +432,19 @@ static int rzn1_rtc_probe(struct platform_device *pde= v) if (ret < 0) return ret; =20 + ret =3D devm_add_action_or_reset(&pdev->dev, rzn1_rtc_disable_hardware, &= pdev->dev); + if (ret) + return ret; + /* Only switch to scmp if we have an xtal clock with a valid rate and != =3D 32768 */ xtal =3D devm_clk_get_optional(&pdev->dev, "xtal"); if (IS_ERR(xtal)) { - ret =3D PTR_ERR(xtal); - goto dis_runtime_pm; + return PTR_ERR(xtal); } else if (xtal) { rate =3D clk_get_rate(xtal); =20 - if (rate < 32000 || rate > BIT(22)) { - ret =3D -EOPNOTSUPP; - goto dis_runtime_pm; - } + if (rate < 32000 || rate > BIT(22)) + return -EOPNOTSUPP; =20 if (rate !=3D 32768) scmp_val =3D RZN1_RTC_CTL0_SLSB_SCMP; @@ -445,7 +457,7 @@ static int rzn1_rtc_probe(struct platform_device *pdev) ret =3D readl_poll_timeout(rtc->base + RZN1_RTC_CTL0, val, !(val & RZN1_RTC_CTL0_CEST), 62, 123); if (ret) - goto dis_runtime_pm; + return ret; =20 /* Set desired modes leaving the controller disabled */ writel(RZN1_RTC_CTL0_AMPM | scmp_val, rtc->base + RZN1_RTC_CTL0); @@ -468,14 +480,12 @@ static int rzn1_rtc_probe(struct platform_device *pde= v) ret =3D devm_request_irq(&pdev->dev, irq, rzn1_rtc_alarm_irq, 0, "RZN1 RT= C Alarm", rtc); if (ret) { dev_err(&pdev->dev, "RTC alarm interrupt not available\n"); - goto dis_runtime_pm; + return ret; } =20 irq =3D platform_get_irq_byname_optional(pdev, "pps"); - if (irq =3D=3D -EPROBE_DEFER) { - ret =3D irq; - goto dis_runtime_pm; - } + if (irq =3D=3D -EPROBE_DEFER) + return irq; if (irq >=3D 0) ret =3D devm_request_irq(&pdev->dev, irq, rzn1_rtc_1s_irq, 0, "RZN1 RTC = 1s", rtc); =20 @@ -485,26 +495,7 @@ static int rzn1_rtc_probe(struct platform_device *pdev) dev_warn(&pdev->dev, "RTC pps interrupt not available. Alarm has only mi= nute accuracy\n"); } =20 - ret =3D devm_rtc_register_device(rtc->rtcdev); - if (ret) - goto dis_runtime_pm; - - return 0; - -dis_runtime_pm: - pm_runtime_put_sync(&pdev->dev); - - return ret; -} - -static void rzn1_rtc_remove(struct platform_device *pdev) -{ - struct rzn1_rtc *rtc =3D platform_get_drvdata(pdev); - - /* Disable all interrupts */ - writel(0, rtc->base + RZN1_RTC_CTL1); - - pm_runtime_put_sync(&pdev->dev); + return devm_rtc_register_device(rtc->rtcdev); } =20 static const struct of_device_id rzn1_rtc_of_match[] =3D { @@ -515,7 +506,6 @@ MODULE_DEVICE_TABLE(of, rzn1_rtc_of_match); =20 static struct platform_driver rzn1_rtc_driver =3D { .probe =3D rzn1_rtc_probe, - .remove =3D rzn1_rtc_remove, .driver =3D { .name =3D "rzn1-rtc", .of_match_table =3D rzn1_rtc_of_match, --=20 2.43.0 From nobody Mon Sep 28 12:35:06 2026 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDC104968E2 for ; Fri, 21 Aug 2026 13:57:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320663; cv=none; b=htI2mOHceQjb5Su+a9rQbI16wGKluAjynfMgd5Kk+vaBiLzc/OmPbDb4pkLztsixppibiydgCgPN9I0T22Ynrwe31AqnigFDXURRtO3YHhRb+aqn2ZxbDF46z5xcbbG8AeTap3Y2fAOkcpGj12I0oNCuoRVTVy7Pi60jXI9gzFA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320663; c=relaxed/simple; bh=hePhqd6mttCdYocRKJ9lHAUTzqYuMejlYulz3MEh0Bw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tGbhW2PIUA8xi7yV13wSIE/X+K7z0/0lX4y0DxnS/F/1OfQUcaV06uzM7xlKYdCAlVkeYE+enwimLSNoRv9UvmCPCQyK3WBr0FBYqnNcR+4XnGVoxe8l3KoWQCNm7Ce5WQDlPn5+TC2GmF9MZv9bD+eQS7anDPtgFbTxkMQXBb8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ovq7Bz6F; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ovq7Bz6F" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-ca7c1176317so889891a12.1 for ; Fri, 21 Aug 2026 06:57:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787320660; x=1787925460; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=X+vlz4a3cPeY5oqSreIwjjufXcNcsB/FD9+DW9/zOaQ=; b=Ovq7Bz6FylXcP2VEEJ1G14rzfb+oxTcO1obpjjiUxPeG8w7IPQcRO8YzHPTraeaFbb 4PJoAgOXdRaHlw0mFst3bgpPCkMV0O5rjidEUO4pHMsj4ilIcoH2kz4OuDeHIBxTCtsB a6iCSjMvdrdYzWVeErULYEs6MOChAXGa5dWhdp/jdah6lFF5OVQ+fV/kdii1EIkiDz7N gmzn112KjNCCrTv8cXv25oaLG5K5pAWEU7ZV3ARMNpvyyblZBceRCTWWAhVcNXwFsnAD HHDcDM0ML0oT5fKQR4w3xqulmffXKDDCIp+5pk8VjGklSpDFm4LUFfAFMi+O8++PCFH1 LxHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787320660; x=1787925460; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=X+vlz4a3cPeY5oqSreIwjjufXcNcsB/FD9+DW9/zOaQ=; b=StdHVM+TIFiHL2ejwvNIc7F0XbdXDz7qFkheUgXqDwZHaXQEYmvwgf3gMrckXcSCGl 1XXxb7nPxJG9oLvQSHrObYcSwrNLNIxQS9QM5PIZaZOKuviuCZbFXgwuLcuJOr2tHnT3 YGYbhacI7APo4KQgZUB/bYza9EShLIpsz+fgHKajfnhO1l7HW6ILavOAxeUkV7GU9Sl6 nE3cYIPs5BZH+Ygn6fnrRX4s++EJvymUOfyNZ+cEShk4fY4GE7DflJxTdlD3Gc1egYDO HkEYHg9y5mKiMJnBO0iU23whg8y2c0ZGQPS1MJDcBS8KAHnFAqOzXdJIVFv5XqtUMNeK Og7Q== X-Forwarded-Encrypted: i=1; AHgh+Ro5AwTuUAQAz+uaCqn2+BADCsjqXS+gCSfHefRDXjhTFsND+XETdQhA2ZI+cf45x2qtB0fFT94rXOfysIc=@vger.kernel.org X-Gm-Message-State: AOJu0YwkqzKMzJ9yBr/ca0cyNgm4pFg7YK82naZsle96sZFUPmzX6VpH P9ATcTKVyeqr+4Hm5nMUnyePdYrU2AI1L8tmm6nt8YLc5kQXwTW/dNH9 X-Gm-Gg: AR+sD10tQA9d/avrUwgEvOcaq3rARNg62TBhfKcGYe8XSQGI7ThYMYdxMT/vhpGe89q gbgM07BrnylfTYlsacFgWwwshRRkAMt6+ZMk+r/b3VFpZS/rFOMAf3Y85S/15f1OUVIWXeRCDeb tBulIZJZfYVweEzh6VZxpMHnyqmVV5OeNyaPdkdHdrpa8dohQuqhmc+QC3/lEFp0v8bxqHJxOM6 IHNPYlO5NcjCVhVTrmdXYi2IzPl/Npf+gJDa/tv2pDph0HUtuEICINUPSH3Orjah2AtLChNRGfM pM6nFw5u/1RSiJ1EaItV568aJBgfmGqWij0/g1atyVeUOkyWQoHQ1eFXYHsf3ula2V4LIDrsyU0 U6WpIlLytrcwYFWDl8C6+PF7sDg7lfdBjOXBBqUkKg/TZWzBWmogo6yZOT+6t275N0te5C1RuHS M9kwaujWf91FZ+I2BC2si9CJrDzkygDAk1lXPPX6JYwiXw25fUJZGuzfDPLKEohZGgZ1OOBFqUH c25Cuj29bwtb4Hv2b/5HOrduBYZ+pdqoHIA6slOqsFHTK9uz8+yDGOgNvUi600VP5WoUfHKBT4E fiEDPjBpjvaj4jQwyaFFbA== X-Received: by 2002:a05:6a21:44c8:b0:3c3:6f6c:aa21 with SMTP id adf61e73a8af0-3cd2ff85523mr13296522637.11.1787320660230; Fri, 21 Aug 2026 06:57:40 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:773c:1c8c:24ea:eff6]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327d01ff056sm19972277eec.19.2026.08.21.06.57.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 06:57:39 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v5 11/17] rtc: rzn1: Dynamically calculate synchronization delay based on clock rate Date: Fri, 21 Aug 2026 14:56:02 +0100 Message-ID: <20260821135608.275233-12-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Replace the hardcoded hardware synchronization delays with a calculated time window derived from the operating sub-clock frequency. The driver currently hardcodes microsecond ranges assuming a fixed sub-clock frequency of 32.768 kHz. Newer SoC variants, such as the RZ/T2H, drive this hardware block using a much faster clock rate (~195.3 kHz). Hardcoding these wait windows forces faster blocks to over-sleep, introducing unnecessary delays during clock initialization and register configuration. Calculate the duration of the required clock cycles in microseconds based on the runtime clock rate, and store this value in the driver private structure to adjust the usleep_range() and readl_poll_timeout() boundaries dynamically. Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v4->v5: - Added Reviewed-by and Tested-by tags from Wolfram. v3->v4: - Shortened the comment describing the calculation of RTC_PCLK. - Updated usleep_range() value to use 2 * rtc->sync_time. v2->v3: - No changes. v1->v2: - Initialized rate variable to 32768 to avoid timeout_us of 0. --- drivers/rtc/rtc-rzn1.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 02d720e95a7f..2e5d2460d79d 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -69,6 +69,7 @@ struct rzn1_rtc { */ spinlock_t ctl1_access_lock; struct rtc_time tm_alarm; + unsigned long sync_time; }; =20 static void rzn1_rtc_get_time_snapshot(struct rzn1_rtc *rtc, struct rtc_ti= me *tm) @@ -119,8 +120,8 @@ static int rzn1_rtc_set_time(struct device *dev, struct= rtc_time *tm) /* Hold the counter if it was counting up */ writel(RZN1_RTC_CTL2_WAIT, rtc->base + RZN1_RTC_CTL2); =20 - /* Wait for the counter to stop: two 32k clock cycles */ - usleep_range(61, 100); + /* Wait 2-4 RTC_PCLK clock cycles for the counter to stop */ + usleep_range(rtc->sync_time, rtc->sync_time * 2); ret =3D readl_poll_timeout(rtc->base + RZN1_RTC_CTL2, val, val & RZN1_RTC_CTL2_WST, 0, 100); if (ret) @@ -397,10 +398,10 @@ static void rzn1_rtc_disable_hardware(void *data) =20 static int rzn1_rtc_probe(struct platform_device *pdev) { + unsigned long rate =3D 32768; struct rzn1_rtc *rtc; u32 val, scmp_val =3D 0; struct clk *xtal; - unsigned long rate; int irq, ret; =20 rtc =3D devm_kzalloc(&pdev->dev, sizeof(*rtc), GFP_KERNEL); @@ -450,12 +451,16 @@ static int rzn1_rtc_probe(struct platform_device *pde= v) scmp_val =3D RZN1_RTC_CTL0_SLSB_SCMP; } =20 + /* Calculate the duration of two RTC_PCLK clock cycles */ + rtc->sync_time =3D DIV_ROUND_UP(2 * USEC_PER_SEC, rate); + /* Disable controller during SUBU/SCMP setup */ val =3D readl(rtc->base + RZN1_RTC_CTL0) & ~RZN1_RTC_CTL0_CE; writel(val, rtc->base + RZN1_RTC_CTL0); - /* Wait 2-4 32k clock cycles for the disabled controller */ + /* Wait 2-4 RTC_PCLK clock cycles for the disabled controller to stop */ ret =3D readl_poll_timeout(rtc->base + RZN1_RTC_CTL0, val, - !(val & RZN1_RTC_CTL0_CEST), 62, 123); + !(val & RZN1_RTC_CTL0_CEST), rtc->sync_time, + rtc->sync_time * 2); if (ret) return ret; =20 --=20 2.43.0 From nobody Mon Sep 28 12:35:06 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B2BD476CE5 for ; Fri, 21 Aug 2026 13:57:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320670; cv=none; b=mwwjOzUS1p00ksT2dsfGAcVI6Nl+Do9pETnTNOp2DNsjUEPKMapVXiQ0t0IWa9UcdhNx/9VddyYyyNKBq7B9j2GRAm8bxPXGU4uPgaCG55Fy3TQxF+LU4J/Hn32k/oMAqqIhbVy9YrPrR3NVzq1Tyb0DczoK8fMHxD75iAhraxg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320670; c=relaxed/simple; bh=uAvFRJq8JPI+Gwlw+Khw9+LTv1Cj/4pa5aFIspu/MvM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Y6r+T7ru8UgHOGslAEs27S9lupXVZimbTlC8KwyS2yDe7c+c4SBk2TmsZqu1ZChj9zwFIJ/RvZql3spM1/n8ZbiRbg6+387LDtppEuICSeVls0u7HdBEA4agckBHKgh17KC8S6clLiz2Qaxq1cFMcmIL/ssCTNyvVaIl18erD/U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bnsGmAju; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bnsGmAju" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2ce98cb8165so9272265ad.1 for ; Fri, 21 Aug 2026 06:57:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787320667; x=1787925467; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fKcq58zoAwSFjLtipval/n+rqoXw1i5Wq0T4A/rBNmU=; b=bnsGmAjurGYQI7Po+fxC/V8g/m8UruFVJEKbQt0pgVIJzuLv1wpEaplHinKex4aidv CwSG+pPbUVhqSWxbsMuLP2DVPPeoG67Wo7zL1uMgbeLSLZ6BhDc3r/ZPRIyMiWoT+YN+ A8ffmulVjMQW7U4lK6mam9Z93ASxxxTmIrF0PxRprknNaAGRo+bQTNmKIJk+SFR5s+lm iIkbCcPHWmwv/oJ9hzGbrgpc7fRw7LdWwPDIsS0+rcs6T+eKs8i/H6T6d5+K3EN+zVlL 2cvXqQcwpyyhHyyHtavpM3sX+ISoVZH2wOA2yy5V1no1NOro8JiNzZWEtKzgF4gZ+66O WOCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787320667; x=1787925467; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=fKcq58zoAwSFjLtipval/n+rqoXw1i5Wq0T4A/rBNmU=; b=RMt/faUYiUwct7+nl17MTV/2aGb/VTutell+sg9SdowcaB9R8q+iodo5VDSh8pixIg EfpGn6LCAf0dA2EKytH1TNpzJt76/ebhZ03kkPIsAUMk2peqTLWMYNFCeYh8MBjEnV+w l30RiYZ+M1GH0B6Mf5ctXmGYn1PW1t/3dCZtP74qB6IOnhFqwtEbEurdF4NGBmgKPpt/ uVrG4g6ueeLy8F1fKbmcWjACJboFDxhDS5S2AJeDMDRD0+TcL1Kwhg6FUx+6eF8l8etO G9P7x32nNRJbcdKwfzXCdNM1qSPNooTnw+0ogQ6jA7KWUhEU0Kkeatxng5K7AeASjq/y A/1A== X-Forwarded-Encrypted: i=1; AHgh+RpJgZJzl06sPV6tIdK7vMrGZk5RKkrbLoJyHpPDC2eqYSA18sQrH0Jl6zFSOT6B7fpUnpchkTzhVPvAh4w=@vger.kernel.org X-Gm-Message-State: AFuF++lFxvLqQ9nSLoYvYTY81+w1wiO6mKUDMeYDrEwFLMKEk2+Png1T BqvW2PVQZEtouk3ZIB7bQ+37lZoEQCWnUtx83iSTz9CilxJY8zjvooutMSeNe6rf X-Gm-Gg: AR+sD11q1z9YfuhY5r28ILhcB7scCyk3qRhGPV5fRMsUoIuvBWCX+IIfzwchqAcrTx9 srtq7cjHVlf2ea2761Y/TlutCSs0gJcIQbmbol8wP/NR2YsjLc4jVs3iBwYRXknJkqmGJzl5QXK Oa5dkYAnW9PXcJ32UfG1nmM8QAzidocckCc+HyGpVKIUxDLfGW9ab5fk2D5k5u+n2+t1VumNb7i QeGLvvvqVl0/N5cTGzsg8o1KXy/b6tkyfExmD5YiCjw9WSlCaiPAwII0D5en9kAjPsrXPnW+nhV SFYUBHYwYxtcjr3b8JAAwEgCwtsTSIQ+m989Djy566IWJgpqKrREHXqzFzKRXM7W2WP0o0VMgKj Lwqol12iNWBtpyx6MMBLSJqa9yr1MSE18/LFcjq8yvdsG888EGE7PvC8saiqteBbVkbj7SV0/DL IrQAEGdF4mweZ1HH/YNgg7bnzpZWVhzlChcp4wMi4rct2OjiFSq4qYdjxDgEy9uCnr/4cmK2n4G evn6unoFtw+JISK1gP6eehFRNeGMNGVtzNm9e47wKtQYIjoeDd++ZFHySZAmUi+oEGsqDexKaVV CV+awZHGpg== X-Received: by 2002:a17:903:94c:b0:2c0:d94f:50c7 with SMTP id d9443c01a7336-2d61a0c9415mr190878155ad.7.1787320666958; Fri, 21 Aug 2026 06:57:46 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:773c:1c8c:24ea:eff6]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327d01ff056sm19972277eec.19.2026.08.21.06.57.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 06:57:46 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v5 12/17] rtc: rzn1: Use temporary variable for struct device Date: Fri, 21 Aug 2026 14:56:03 +0100 Message-ID: <20260821135608.275233-13-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Use a temporary variable for the struct device pointers to avoid dereferencing. Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v4->v5: - Added Tested-by tag from Wolfram. v3->v4: - No changes. v2->v3: - No changes. v1->v2: - Added Reviewed-by tag. --- drivers/rtc/rtc-rzn1.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 2e5d2460d79d..1b16fc06bce7 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -398,13 +398,14 @@ static void rzn1_rtc_disable_hardware(void *data) =20 static int rzn1_rtc_probe(struct platform_device *pdev) { + struct device *dev =3D &pdev->dev; unsigned long rate =3D 32768; struct rzn1_rtc *rtc; u32 val, scmp_val =3D 0; struct clk *xtal; int irq, ret; =20 - rtc =3D devm_kzalloc(&pdev->dev, sizeof(*rtc), GFP_KERNEL); + rtc =3D devm_kzalloc(dev, sizeof(*rtc), GFP_KERNEL); if (!rtc) return -ENOMEM; =20 @@ -412,13 +413,13 @@ static int rzn1_rtc_probe(struct platform_device *pde= v) =20 rtc->base =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(rtc->base)) - return dev_err_probe(&pdev->dev, PTR_ERR(rtc->base), "Missing reg\n"); + return dev_err_probe(dev, PTR_ERR(rtc->base), "Missing reg\n"); =20 irq =3D platform_get_irq_byname(pdev, "alarm"); if (irq < 0) return irq; =20 - rtc->rtcdev =3D devm_rtc_allocate_device(&pdev->dev); + rtc->rtcdev =3D devm_rtc_allocate_device(dev); if (IS_ERR(rtc->rtcdev)) return PTR_ERR(rtc->rtcdev); =20 @@ -426,19 +427,19 @@ static int rzn1_rtc_probe(struct platform_device *pde= v) rtc->rtcdev->range_max =3D RTC_TIMESTAMP_END_2099; rtc->rtcdev->alarm_offset_max =3D 7 * 86400; =20 - ret =3D devm_pm_runtime_enable(&pdev->dev); + ret =3D devm_pm_runtime_enable(dev); if (ret < 0) return ret; - ret =3D pm_runtime_resume_and_get(&pdev->dev); + ret =3D pm_runtime_resume_and_get(dev); if (ret < 0) return ret; =20 - ret =3D devm_add_action_or_reset(&pdev->dev, rzn1_rtc_disable_hardware, &= pdev->dev); + ret =3D devm_add_action_or_reset(dev, rzn1_rtc_disable_hardware, dev); if (ret) return ret; =20 /* Only switch to scmp if we have an xtal clock with a valid rate and != =3D 32768 */ - xtal =3D devm_clk_get_optional(&pdev->dev, "xtal"); + xtal =3D devm_clk_get_optional(dev, "xtal"); if (IS_ERR(xtal)) { return PTR_ERR(xtal); } else if (xtal) { @@ -482,9 +483,9 @@ static int rzn1_rtc_probe(struct platform_device *pdev) =20 spin_lock_init(&rtc->ctl1_access_lock); =20 - ret =3D devm_request_irq(&pdev->dev, irq, rzn1_rtc_alarm_irq, 0, "RZN1 RT= C Alarm", rtc); + ret =3D devm_request_irq(dev, irq, rzn1_rtc_alarm_irq, 0, "RZN1 RTC Alarm= ", rtc); if (ret) { - dev_err(&pdev->dev, "RTC alarm interrupt not available\n"); + dev_err(dev, "RTC alarm interrupt not available\n"); return ret; } =20 @@ -492,12 +493,12 @@ static int rzn1_rtc_probe(struct platform_device *pde= v) if (irq =3D=3D -EPROBE_DEFER) return irq; if (irq >=3D 0) - ret =3D devm_request_irq(&pdev->dev, irq, rzn1_rtc_1s_irq, 0, "RZN1 RTC = 1s", rtc); + ret =3D devm_request_irq(dev, irq, rzn1_rtc_1s_irq, 0, "RZN1 RTC 1s", rt= c); =20 if (irq < 0 || ret) { set_bit(RTC_FEATURE_ALARM_RES_MINUTE, rtc->rtcdev->features); clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, rtc->rtcdev->features); - dev_warn(&pdev->dev, "RTC pps interrupt not available. Alarm has only mi= nute accuracy\n"); + dev_warn(dev, "RTC pps interrupt not available. Alarm has only minute ac= curacy\n"); } =20 return devm_rtc_register_device(rtc->rtcdev); --=20 2.43.0 From nobody Mon Sep 28 12:35:06 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02415499F08 for ; Fri, 21 Aug 2026 13:57:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320675; cv=none; b=C3shlJuiek97VpXq8f7KJGlpn+RnYf4p03XHTcd1SJ2+mIR7iZHvQZpuP/CwL3CjMPVF4G4k1R+DgsfcvIE7EGeFGPt6AFNTQiHPQGnbgz6UnwVZ2CMUedx/tKjeZkFvUA+Z6rk0SA9KDKs2OCd8XV3go5nlAUo2+RVV4PWb1YE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320675; c=relaxed/simple; bh=GZSZWo7FCGuFvodhKjJU6K3a2wT+h/1TynS72/UOdJE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iXDcepdNAou4xnKPDd8rjLsvkd1TMWi7wBc77wmMhQ4UlVkKYlqrfrP86mZZib89oCdqO1InguyEW8KiLUeRj0ZT7e/Lr91Nd5drYiQ9MpBOMGi6aajqFVuaIUzCxRXB2EMM7zjwQQigu+Grs+cXbkQYG5xs/gi16CIickXYrcE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BPcrtoDk; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BPcrtoDk" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-38deea72eebso991632a91.1 for ; Fri, 21 Aug 2026 06:57:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787320673; x=1787925473; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1oLG+YxbJjR89MQkaFvxx9kQt98tBR55Lpko/eQdEoQ=; b=BPcrtoDk5bvNKyaAZ2TR0oAOxha5qSwree1kr70ABNB2yVw/+OM1Asil9WolBfSvII ErK3ceWjT+hGpYA2Z0I3Baa7LhL3Z0pUmRowZswB+uFe7QPmgpkj6gB/1dTbJ25N907Z 9J7RyLbqiO9zP+QvS31IE2xf7PzhFMKavDRBLdtpy4vQEG/0158k3hKns56+f4yDP9i/ UeXwMdRQNbrRWs5ChP4g+SZ+AvMXXMxgsgA3tUSBuYhmTlFtQ0ghNP1nAuWgls+edoFi eknM09Ht2r19y1svG87KbjKWjeGajoDzjAX6y9h4y9kWgPLYUyxt/1nV/mKsFjwDHzs5 dyPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787320673; x=1787925473; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=1oLG+YxbJjR89MQkaFvxx9kQt98tBR55Lpko/eQdEoQ=; b=bx7yxR1ujc2019WAzUyFh8cR7t24Jh5Agi0MToWL76O0RRr38Plz523QuHLcT2aXaO KG2XGbItbBQx3SH6RMg8WUDccJ7hkfLbvphTinRNmDdi4ZZNzJguZeCDBd+ZhotcPLfM T++PFm1NnlVUGVeG1qvhjAumATu5CzUEi/uxQlKLokxG5tZUU7HxufEDpvyRWAXVf+xi VUBK/KhJiz7UHn7cEkA5JIE47Fv7pKCsVbQY9+lJ1PJfTBjI40932mMChV0CHozaRSQp WtfgcROPw09B9qKMmwhHytOg7FlxrSbXr0XaBBloNrd3jXyq9b3dtI5bqegQnzPTBCnd 0C6w== X-Forwarded-Encrypted: i=1; AHgh+RoG1bp/IqM3+oqdLNikMMBMGScxKadMhQYrJJbm830FiHQKCopT15EJw522o0yjPGZ8vTI8bmrUfoZTBA0=@vger.kernel.org X-Gm-Message-State: AFuF++kp+cjOitKZhRMMgIRVWpfi2cKzfi6DLD1MoMNtKs1xXvmQ75v/ mnV3A1yOGwMVu1KKYFmwWSGVKrB/suUSGmsU83cN//VsQExjao0NNGIl X-Gm-Gg: AR+sD12Y3B7O7jsACyh4lmPaUJhrrBgEGgvcaYG3r8J3DUmgGw5CdQFi6VkM7i0SaAS egyvNsxHJ0bexF7+VVQQOH2Y+t6+T/f7OKFzOOwlvacfWsYbcpX440r5aI+0iM4Z10HWunpWZfk P2YPzVfAVeCzeHu4luPZ+bt7aiQvoxSIlU0p7r934G7iiiyxAFKf2DJC+cVF9vZN9lssIzVGKMF YjyCArK3AZYb8pwIZBh4RBRGKs+oS/5TZoSSgV8Kk/D/HxgQZS3wM8/qa1ErR87MAz2x+bbLoaL 8H7jXdA9lFqNmVs2htrRIrnZGxFbYSVK/CkR3h9bHMT2SdBQNwKUf3TtY0ZJgRfeWk82Np+AXgu 0WNyF7bkF6aZ07vh7PN6iKqW39mzuEzrHz8lKQ73eN9r1s7TAvOSLl8c70kSwc0HHjc4rlPDp+h 1Tf5Ljh5clZ20YVz3rKDCEpkqDfQ48sQSqTeskiHEnVHpHBiJ/Ea1+bLU4VgJyC8xHgNGT3HOxW ZK9KwGDhbC6/uNJTZU2VmzNCECDdTFkJgp1ArdxY9V3DiirF1sjL2XZ1LPstsUBbwXkfJ5nqmxH oYOR6915Ew== X-Received: by 2002:a17:90a:da8c:b0:381:a766:efcc with SMTP id 98e67ed59e1d1-395c3865a2emr12630467a91.14.1787320673241; Fri, 21 Aug 2026 06:57:53 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:773c:1c8c:24ea:eff6]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327d01ff056sm19972277eec.19.2026.08.21.06.57.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 06:57:52 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v5 13/17] rtc: rzn1: Consistently use dev_err_probe() Date: Fri, 21 Aug 2026 14:56:04 +0100 Message-ID: <20260821135608.275233-14-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Use dev_err_probe() in the IRQ request error path to make error handling consistent with the rest of rzn1_rtc_probe(). Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v4->v5: - Added Tested-by tag from Wolfram. v3->v4: - No changes. v2->v3: - No changes. v1->v2: - Added Reviewed-by tags. --- drivers/rtc/rtc-rzn1.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 1b16fc06bce7..ea3906d1f868 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -484,10 +484,8 @@ static int rzn1_rtc_probe(struct platform_device *pdev) spin_lock_init(&rtc->ctl1_access_lock); =20 ret =3D devm_request_irq(dev, irq, rzn1_rtc_alarm_irq, 0, "RZN1 RTC Alarm= ", rtc); - if (ret) { - dev_err(dev, "RTC alarm interrupt not available\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "RTC alarm interrupt not available\n"); =20 irq =3D platform_get_irq_byname_optional(pdev, "pps"); if (irq =3D=3D -EPROBE_DEFER) --=20 2.43.0 From nobody Mon Sep 28 12:35:06 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86608499F27 for ; Fri, 21 Aug 2026 13:58:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320681; cv=none; b=Pgz6ytg8tjf6Fi5peM3ap6brhEDtf/vE8kqadrOyAJtr8HnO4gRzgjmQZqdYozEu4mpOTo+BgbZ0r6MgusmAyq2Gukl/83c/9aVstHk07ZpkYxO6/6/mmEHtnuOijuxPU9qGJCH3ayl0R9qxaCnXdwidH4UZg0euzQMv6NBYENQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320681; c=relaxed/simple; bh=zhnl8YLIlQ4utT3JT2vKNwCvLziZtCJGZk/rhl8bdj0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NkJbSygvU7OQGFSKmZmx8Y1YNOXudzdPeBKr0HJLz5LgKVRARDOW2tjkKpxOGED7Qw8M95Vzh7sImUZKq84I21xyHAwFCIilpmh5jqcn36snHC7aUG4wpMrDXTYtwdfJHy06l5j3fUFgmaXkBF8NsjkhgoQJ1x9PFEPt/knBcRI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Wh/om1zo; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wh/om1zo" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-3900e39d935so924162a91.0 for ; Fri, 21 Aug 2026 06:58:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787320680; x=1787925480; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qj9P03d1ymDbOhIBXqu+dDsa+eCWHeVye4sMzpPS870=; b=Wh/om1zoCuhYQIt+vWNh8foNXi0WTximxFKo5UFKUOjQyeydxM76v+KxE4FlOzb+Qg FDO+fAoF+pN2H8BNzpge7iMPlHvl+Qq3d1RG39QaPwVFd1nxT8PlkcHR9Shyr+JlcnDo H0I1/bJj8LQgUo99SP66zvIYGnnDeU10ddDX2Vsz+DIMr2rlVdeGXO7r8hNQ8iHuPVT6 D4HcyQ2ydmSs2e+RiIo1hP0jyapplm1cjVMnvqnJI2Ihb3RleVsF4hwjTIecxpZe3IyQ wCnMqkhzVYF/JjmzFoW7Z6hV+YLKtyJZa6TmSiWb2cUOFzKhMqAFt2dxZXJC2GuYh9GA O/VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787320680; x=1787925480; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=qj9P03d1ymDbOhIBXqu+dDsa+eCWHeVye4sMzpPS870=; b=q9IxfiH3viPXCJOJX6uVoO85j4XfzF0cKG15b/fkDgrprXpr+39SeS0sz4Mbk2snls Y8HTDpLHuJYpPwbqKVq+apdrx0MjTBRtpmzXeYwIcSywwOMeUYL17wfyWvDJFfsBVNNT SdOr/LtllK+5VbXS59MJi5sa4FBU9WVd+PcRKYJhca2YjVPV34gPm5OiGC87TXxtpSXa HUifMAGzaU17rOnSw5SgRFkjzVkuiSf+jkmJk+wE7P1lN2q+iu4Y8KBf63ONP9EB+0Kb e15rD99l4JAPK6RGHVe1ujnxCOATuai2CdeKmfHS2x9XN0C+8LObhZa6MDm4nfNpl/kZ j+Jw== X-Forwarded-Encrypted: i=1; AHgh+Rqy51Xb4dd4VYu7fKcdAPuE1rG/g3Ih3iIbeWma51ZcymT1LTykHqQc4dl2XPn3wta46xew26hzDIBEwyU=@vger.kernel.org X-Gm-Message-State: AFuF++nrKfIN2rxBvPmCClSDOZnOO/9Co18l54m1tkE4bhMMMB6eaUiO 6myIkWaXsrxkv2zmwIGf7wDgqmd52GsGkE8ETdYzTuJJ5UitN2+8+N6Y X-Gm-Gg: AR+sD116wKuIjWSX3WgkyaV8MBV9r7IJON2INkzZ/cCIUf60SiaAOO0u5OVXVR1eJXv TTZsNQw+Xk+zFN+ZDrRVAGHHj2iimABDlY4A+SsnDq64wCLpB1y1foatQY1S7uJeyCjqAxEH84U uDS1ybgrn53feR6oByniF/xV79x+rrqmlPsA7XOIQgGr2X4WDsTWgk/7tAKF/eQXxI8pv056TeD KhBfRFGXk7OoRcufUIQBUaipZmNT910wvDMBlyCYILVJxfHLLuGoot+xP2LEaf/DR1OV836PbEN HDKJ1o6BhyoB0iUWGV3Z9OwAjVEhrLnqFu2YIfJjTLEUgKpNtAb2rjNSdez89bYLBXTwOIcGIYg L4swRcGuE60LCQyNojFV0o/ODKHd4UG93SXi/18mfdNFhVTNpF8BNdL2P0ybvPdAb56vMcaKOBa Yr7e2SiGTh/bIlK03LYbZdT7mIK0c9yF6d8JlzAJLR4szkbq4uVb35D7bwFao+QvXpJEnOqqyoT ay4XwJO/2/pbYBcfU4UpvF1vqMKfttWHDIp2lip3nbMeip2mdYYD11/0vCBm7DzNRxK6yzYHKDN jisidJ57EA== X-Received: by 2002:a17:90b:3912:b0:392:e5b1:d833 with SMTP id 98e67ed59e1d1-395c3738b35mr10836523a91.13.1787320679624; Fri, 21 Aug 2026 06:57:59 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:773c:1c8c:24ea:eff6]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327d01ff056sm19972277eec.19.2026.08.21.06.57.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 06:57:59 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v5 14/17] rtc: rzn1: use FIELD_PREP/FIELD_GET and GENMASK for register access Date: Fri, 21 Aug 2026 14:56:05 +0100 Message-ID: <20260821135608.275233-15-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Replace open-coded shift and mask operations with the bitfield API. Note that the weekday field is changed from an explicit 0x0f mask to an 8-bit field definition, matching the hardware manual. This does not change behaviour, as valid weekday values cannot exceed 7. Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v4->v5: - Added Tested-by tag from Wolfram. v3->v4: - Added RB tag from Wolfram v2->v3: - No changes. v1->v2: - Made use of RZN1_RTC_SUBU_RTCA0FX mask for SUBU register access instead of 0x3F. --- drivers/rtc/rtc-rzn1.c | 50 +++++++++++++++++++++++------------------- 1 file changed, 28 insertions(+), 22 deletions(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index ea3906d1f868..8b68a5ad19c0 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -12,6 +12,8 @@ */ =20 #include +#include +#include #include #include #include @@ -38,14 +40,18 @@ #define RZN1_RTC_CTL2_STOPPED (RZN1_RTC_CTL2_WAIT | RZN1_RTC_CTL2_WST) =20 #define RZN1_RTC_TIME 0x30 -#define RZN1_RTC_TIME_MIN_SHIFT 8 -#define RZN1_RTC_TIME_HOUR_SHIFT 16 +#define RZN1_RTC_TIME_SEC GENMASK(7, 0) +#define RZN1_RTC_TIME_MIN GENMASK(15, 8) +#define RZN1_RTC_TIME_HOUR GENMASK(23, 16) + #define RZN1_RTC_CAL 0x34 -#define RZN1_RTC_CAL_DAY_SHIFT 8 -#define RZN1_RTC_CAL_MON_SHIFT 16 -#define RZN1_RTC_CAL_YEAR_SHIFT 24 +#define RZN1_RTC_CAL_WDAY GENMASK(7, 0) +#define RZN1_RTC_CAL_DAY GENMASK(15, 8) +#define RZN1_RTC_CAL_MON GENMASK(23, 16) +#define RZN1_RTC_CAL_YEAR GENMASK(31, 24) =20 #define RZN1_RTC_SUBU 0x38 +#define RZN1_RTC_SUBU_RTCA0FX GENMASK(5, 0) #define RZN1_RTC_SUBU_DEV BIT(7) #define RZN1_RTC_SUBU_DECR BIT(6) =20 @@ -77,15 +83,15 @@ static void rzn1_rtc_get_time_snapshot(struct rzn1_rtc = *rtc, struct rtc_time *tm u32 val; =20 val =3D readl(rtc->base + RZN1_RTC_TIMEC); - tm->tm_sec =3D bcd2bin(val); - tm->tm_min =3D bcd2bin(val >> RZN1_RTC_TIME_MIN_SHIFT); - tm->tm_hour =3D bcd2bin(val >> RZN1_RTC_TIME_HOUR_SHIFT); + tm->tm_sec =3D bcd2bin(FIELD_GET(RZN1_RTC_TIME_SEC, val)); + tm->tm_min =3D bcd2bin(FIELD_GET(RZN1_RTC_TIME_MIN, val)); + tm->tm_hour =3D bcd2bin(FIELD_GET(RZN1_RTC_TIME_HOUR, val)); =20 val =3D readl(rtc->base + RZN1_RTC_CALC); - tm->tm_wday =3D val & 0x0f; - tm->tm_mday =3D bcd2bin(val >> RZN1_RTC_CAL_DAY_SHIFT); - tm->tm_mon =3D bcd2bin(val >> RZN1_RTC_CAL_MON_SHIFT) - 1; - tm->tm_year =3D bcd2bin(val >> RZN1_RTC_CAL_YEAR_SHIFT) + 100; + tm->tm_wday =3D FIELD_GET(RZN1_RTC_CAL_WDAY, val); + tm->tm_mday =3D bcd2bin(FIELD_GET(RZN1_RTC_CAL_DAY, val)); + tm->tm_mon =3D bcd2bin(FIELD_GET(RZN1_RTC_CAL_MON, val)) - 1; + tm->tm_year =3D bcd2bin(FIELD_GET(RZN1_RTC_CAL_YEAR, val)) + 100; } =20 static int rzn1_rtc_read_time(struct device *dev, struct rtc_time *tm) @@ -128,15 +134,15 @@ static int rzn1_rtc_set_time(struct device *dev, stru= ct rtc_time *tm) return ret; } =20 - val =3D bin2bcd(tm->tm_sec); - val |=3D bin2bcd(tm->tm_min) << RZN1_RTC_TIME_MIN_SHIFT; - val |=3D bin2bcd(tm->tm_hour) << RZN1_RTC_TIME_HOUR_SHIFT; + val =3D FIELD_PREP(RZN1_RTC_TIME_SEC, bin2bcd(tm->tm_sec)) | + FIELD_PREP(RZN1_RTC_TIME_MIN, bin2bcd(tm->tm_min)) | + FIELD_PREP(RZN1_RTC_TIME_HOUR, bin2bcd(tm->tm_hour)); writel(val, rtc->base + RZN1_RTC_TIME); =20 - val =3D tm->tm_wday; - val |=3D bin2bcd(tm->tm_mday) << RZN1_RTC_CAL_DAY_SHIFT; - val |=3D bin2bcd(tm->tm_mon + 1) << RZN1_RTC_CAL_MON_SHIFT; - val |=3D bin2bcd(tm->tm_year - 100) << RZN1_RTC_CAL_YEAR_SHIFT; + val =3D FIELD_PREP(RZN1_RTC_CAL_WDAY, tm->tm_wday) | + FIELD_PREP(RZN1_RTC_CAL_DAY, bin2bcd(tm->tm_mday)) | + FIELD_PREP(RZN1_RTC_CAL_MON, bin2bcd(tm->tm_mon + 1)) | + FIELD_PREP(RZN1_RTC_CAL_YEAR, bin2bcd(tm->tm_year - 100)); writel(val, rtc->base + RZN1_RTC_CAL); =20 writel(0, rtc->base + RZN1_RTC_CTL2); @@ -307,12 +313,12 @@ static int rzn1_rtc_read_offset(struct device *dev, l= ong *offset) val =3D readl(rtc->base + RZN1_RTC_SUBU); ppb_per_step =3D val & RZN1_RTC_SUBU_DEV ? 1017 : 3051; subtract =3D val & RZN1_RTC_SUBU_DECR; - val &=3D 0x3F; + val =3D FIELD_GET(RZN1_RTC_SUBU_RTCA0FX, val); =20 if (!val) *offset =3D 0; else if (subtract) - *offset =3D -(((~val) & 0x3F) + 1) * ppb_per_step; + *offset =3D -(((~val) & RZN1_RTC_SUBU_RTCA0FX) + 1) * ppb_per_step; else *offset =3D (val - 1) * ppb_per_step; =20 @@ -354,7 +360,7 @@ static int rzn1_rtc_set_offset(struct device *dev, long= offset) subu |=3D steps + 1; } else { subu |=3D RZN1_RTC_SUBU_DECR; - subu |=3D (~(-steps - 1)) & 0x3F; + subu |=3D (~(-steps - 1)) & RZN1_RTC_SUBU_RTCA0FX; } =20 ret =3D readl_poll_timeout(rtc->base + RZN1_RTC_CTL2, ctl2, --=20 2.43.0 From nobody Mon Sep 28 12:35:06 2026 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E500C499F27 for ; Fri, 21 Aug 2026 13:58:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320688; cv=none; b=rUq925Ta50dsl5JqDkc0L55LKOuKFsQIRJ61jXjon+Skh7906hNQBP2aNK384HmWpLTA65Ise8vlAUBcijUrsUQkutI7rTDgMpbvm5T8yA0CTH3o3cRe8vWC/+gyrrWKiXg/LJQu0vRKL/KO6/P3NJBJq51dVwusJYJFKeL6fX4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320688; c=relaxed/simple; bh=s467x5BITEEd5Yvk33pvjHg4Q7phFZ4tY0bKBjCHYug=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cB8NwL6mTw6VYLf/Ac/HGll+Jh/t4Gu4zttz243F+UvGDpVYEKWOT+eN4n+7fbI3ztdtFdfvou9xU5i8YWO6hU1BvRmUko63wLB0/MFdo0WnuyUnKxBhZeKYV0mE6zjFMjBDvLHJoVQfb9UlfgpdkWpHt7Oqqx4ieun6JZQaU70= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ymvp3gwH; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ymvp3gwH" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-cbeea240819so617139a12.1 for ; Fri, 21 Aug 2026 06:58:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787320686; x=1787925486; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cnH4Er9TSQRm4rDEAqO5Z8IUygxN15a86ai14kfQ5IQ=; b=Ymvp3gwHYST52LYXiFG3P0xhk8nFKbkrsn5EZx12H5E5fly9F2g2hKr14zUBqq+Pec 3/8adjigG1Suy23BEEmzGsTVcDs8nR1oPVh/YnhkTx6kaWRxAjNm45j/8pz/3h9qw/LN uTag+ydD9BuSetwR7bztKKI78ngMiPIARA0NQGUOtrea7fSbrTkIS2qewx11wLcT5hjI 6DaqE6nzbK9vYF1j5ylE2CYTuBwQmRgRXoubvyyaHQ7JQ1B9MgMN6gn1w+OB2/X4XJK1 h0PbKU5VZ/LriECU4/Hy9BdZMeYBaJOj8lotXMFsU+GfnnqExcn51mv/hVpDB+mikCNs +Twg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787320686; x=1787925486; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=cnH4Er9TSQRm4rDEAqO5Z8IUygxN15a86ai14kfQ5IQ=; b=RN1oQlAcYrx1oIYAOPSPFd5woXeFcsZAVDWKej9pgFwVs47v7Cr1O8PjKElnrasXBs ho/UPrJP8z+UA10VAScQneULQJ9/Ey6a0U3dwY2f6gzNF4wnIoKjpi3iXufili1xw5sB nxxbIrHDJjtRSRJ8l5LVG6tX2n5c38q2hbaVbhex2ZrITyJLuGxac7+K4R17ElXLOXeh WGLyaWIZmNafnfkhgpjcKWqZHQzPMfOID78itoOmkHl4okZZQr+kBnUx4uCn6VGzfbUZ +9rmi/sCNrOV3px3PZZHQ0jahaVqXVaTeeZpxpuOBlx7+KztQM8EW27IiJibM69PfYtC MmDw== X-Forwarded-Encrypted: i=1; AHgh+RrV36OIi+LdI6w72B7bRRSj2rspAPt+0/XsCQK4PzYaN2/wbBU1znvCoO4ogAdMuOtlmGWNPXQCLAAI0Ek=@vger.kernel.org X-Gm-Message-State: AOJu0YybOTOLhC5rlneEL+0IL8zVK7wKUzBe1cEFphjGrg76f1KKuzMm U5ToCqDGC8APveimyb7tGwHNG69rJYu4Qg7KETDzIAJphU+GwVn4Q6eg X-Gm-Gg: AR+sD13bdzXgxW1Ighs73wzvcyrxvPPaZrmQ4FQPR8YSo+FDr2eSxCn2J6cs9JEpx37 WqpJFpvrsiwE0r6+wURdWnSbC32LEgGkzD22T2nPpZErhzeQW9goqHGar9O9QhNEQY+p+ZJfnTv aezkOnTn9oqIDXUw0twMYeo8n5WZcnV4Qx66MftyYBYiPrEDK7zU8Fa/bOlqtleSdZBPJar4dQJ 2kNIA756zdvk+HT7fJCEh1O2qbrV6R7OAElVMHeaLtTFatrimxXSpBWnNPlwAcX3cxU3A84dcBg NKcpZIZC7DGMoZtwB4WN3cBZOn/w/vVUvrnceG8/Raz8y6mUnOZKs8Kjm2eI5779NsAJe+6lKfQ Wh+mrO168aWlESH8yx4Mqk10F356/CvcufjB56aQdLvBsIWhjM7gHwdeAd38RSGv6dPfc4/LrT6 UixJP5xdXwXh2SzcNVBy1PnEZogPrrXUcuqlmzCdmx74nsDvif4vLi2fRadA02SVVWyWu+oO9qX Ue+2+7QuTUOddUGLukctUO4wS0GJeLV/Y4JReaou+0xLvqGApb9TfwTJT8+3ysFe9hLwwRQM00l ZDOZaAt87NTeUCk= X-Received: by 2002:a05:6300:67c8:b0:3cc:3d08:da3e with SMTP id adf61e73a8af0-3cd2fdd1cfcmr12809142637.2.1787320686119; Fri, 21 Aug 2026 06:58:06 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:773c:1c8c:24ea:eff6]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327d01ff056sm19972277eec.19.2026.08.21.06.58.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 06:58:05 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v5 15/17] rtc: rzn1: Add OF match data to gate SUBU register access Date: Fri, 21 Aug 2026 14:56:06 +0100 Message-ID: <20260821135608.275233-16-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar The RZ/N1 RTC driver selects SCMP mode only when an optional xtal clock is provided at a valid rate other than 32768 Hz. Without an xtal clock, or when it runs at 32768 Hz, the driver uses SUBU mode. However, the RTCA0SUBU register used by SUBU mode is not present on all SoCs that integrate a similar variant of the RTC block. Allowing SUBU mode on those variants would expose RTC offset operations that access a non-existent register. Add OF match data to describe whether the RTC supports the SUBU register. Reject probe with -EOPNOTSUPP when SUBU mode would be selected on a variant without SUBU support. Signed-off-by: Lad Prabhakar Suggested-by: Wolfram Sang Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v4->v5: - Renamed rzn1_data to rzn1_rtc_rzn1_data - Added a print message to indicate that SUBU mode is not supported on the variant. - Added a comment to indicate that the xtal clock is NULL when SUBU mode is not supported. - Added Suggested-by tag from Wolfram. v3->v4: - New patch --- drivers/rtc/rtc-rzn1.c | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 8b68a5ad19c0..35770bff129f 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -18,6 +18,7 @@ #include #include #include +#include #include #include #include @@ -65,6 +66,10 @@ #define RZN1_RTC_TIMEC 0x68 #define RZN1_RTC_CALC 0x6c =20 +struct rzn1_rtc_data { + bool has_subu; +}; + struct rzn1_rtc { struct rtc_device *rtcdev; void __iomem *base; @@ -404,6 +409,7 @@ static void rzn1_rtc_disable_hardware(void *data) =20 static int rzn1_rtc_probe(struct platform_device *pdev) { + const struct rzn1_rtc_data *data; struct device *dev =3D &pdev->dev; unsigned long rate =3D 32768; struct rzn1_rtc *rtc; @@ -411,6 +417,10 @@ static int rzn1_rtc_probe(struct platform_device *pdev) struct clk *xtal; int irq, ret; =20 + data =3D of_device_get_match_data(dev); + if (!data) + return -ENODEV; + rtc =3D devm_kzalloc(dev, sizeof(*rtc), GFP_KERNEL); if (!rtc) return -ENOMEM; @@ -454,8 +464,12 @@ static int rzn1_rtc_probe(struct platform_device *pdev) if (rate < 32000 || rate > BIT(22)) return -EOPNOTSUPP; =20 - if (rate !=3D 32768) + if (rate !=3D 32768 || !data->has_subu) scmp_val =3D RZN1_RTC_CTL0_SLSB_SCMP; + } else if (!data->has_subu) { + /* xtal is NULL here */ + return dev_err_probe(dev, -EOPNOTSUPP, + "No valid XTAL provided and SUBU mode not supported\n"); } =20 /* Calculate the duration of two RTC_PCLK clock cycles */ @@ -508,8 +522,12 @@ static int rzn1_rtc_probe(struct platform_device *pdev) return devm_rtc_register_device(rtc->rtcdev); } =20 +static const struct rzn1_rtc_data rzn1_rtc_rzn1_data =3D { + .has_subu =3D true, +}; + static const struct of_device_id rzn1_rtc_of_match[] =3D { - { .compatible =3D "renesas,rzn1-rtc" }, + { .compatible =3D "renesas,rzn1-rtc", .data =3D &rzn1_rtc_rzn1_data }, {}, }; MODULE_DEVICE_TABLE(of, rzn1_rtc_of_match); --=20 2.43.0 From nobody Mon Sep 28 12:35:06 2026 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13CD3494803 for ; Fri, 21 Aug 2026 13:58:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320694; cv=none; b=e62+sjxhka2g6J/wYOxY5xD713pPPnkWgNXvFYrT34oSr9FhhlNKbNVP4HJPDqW7D1VRRW/1Pv32N4Xa75bnWd4iB7E/FhS8zUry6SN5hH/AoKR3L8Xh45eBIX+I4peBQ2NtZvEOxjHZ2ynandjuaO389e3Mm9/xOoTEbU51zB0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320694; c=relaxed/simple; bh=04GCmteGIux4olAHeskFAacFufwWGnwkFW1GWc2dsNk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sxJ3WRd8r+2jkxMkGaMg6jSVaTsT8MNCqsynZ0f64V89cYpH2KhgAQetLS9PwD/7/d/x/d1y+gTygWn06G3qBc89dNdN6xoanC6LheZPqFESPShD1HGoLlSqvlFG1yQIgTXvtzS92zrMlUd4w9eWK/7KiU0hpvfEl201d8OmHCI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gk3YzsBB; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gk3YzsBB" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-395cf2535acso556231a91.1 for ; Fri, 21 Aug 2026 06:58:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787320692; x=1787925492; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NwGs2ndQ+fjxjLIqK9oi+yaLvoYinheEb0GyyG+r0eg=; b=gk3YzsBBhccMwhwaXya8roFyFS0OtV07f62bDiN6vdNaXwW1vJ7afYyYqHlR5ode1x 5xdGMT8w7dO1Wl/B8lZYB6x7ro0LLkesFhMLP5rGKB+3VO2EQy96PFk3G7DrCeJ5rkMK f/8T4AZ3wOCFoGXIBjl+zrsfRHEmyX9aoEU11yB4b+SLVUsL8XtBx8LbNZYsadJ787ij ffwHCodjlbhz/eMsr5ds4ZUoBlTR3ZEQA86IS4a4b8tXDboGfEF8EpX8YULfPDKEuhPa 2ZpPJxnog6voiJOnozWyMYCKV91EOjvQsH0fk+QljJMXdMpxdwPucEG5uqggs4CVYwaE UUSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787320692; x=1787925492; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=NwGs2ndQ+fjxjLIqK9oi+yaLvoYinheEb0GyyG+r0eg=; b=gODaR7oWNqEaXCi/HucI/XvF4LibJkmTgLyV4Nads0hQsHDKEMWY/BL1ekLF3GYdUU +oHO2uOlzMWGJw1elB6G0wYxikBfGghAUVXCQlp66lcvhSARr4aikTnZHsIq06LxMnhY tO40CAff06oizs4WljDfHiQUlHM2CL0F3NGczid96z2/++/cOQaWWHQjNFb2kOvCK7qU hb/l9hPcORHJQNiq5sbKDPZTEokFQqOOO9H4Lj3I2PagNOQGctuj0WXOCrm5XwE3hol/ dpblbx5aoWtsJZq8DJMPToENoU/HFVZTFvpDlFYYGSDAq2akxNextafKYt4/GlD7YAZ8 19rw== X-Forwarded-Encrypted: i=1; AHgh+RppcupyAJs25MAm6I3nVQdEedJoYnPklZ/RbQF41TsuI5csBxyT55fecK1vC59U160khMus7+T8WXpH4Vc=@vger.kernel.org X-Gm-Message-State: AFuF++mVVGM4Wbut6g2+jO0hJ3DCd7IsIdYOIiK5BUu9MFmgwjYdyIHk yhgVqy72GbgKOGu8IRKaWkpjImAPBaGqv5sP5qZr8BflOftXkVub0+eQ X-Gm-Gg: AR+sD100FqwIFKMLK6wnVqXDHRZB7KrZGbBZzcYS9xl7dRNZS+W91dQsSh5JenoNkbL /yabq9JT9VounAvGzLeOEUPodlnn2b5ioQtbQUZqziVs+Xe5FcKxs5ugWEKs3f+w2gzSA6EOZkH rQygoPbdaPrz2oEea/OfDdy1VaDG4myqaQupwF/2XQdwqwdIHJzt3/XeAvmScr7Dka+acXmfCpt C6wBUWT5TOa+dTf1s8wqypW3QaxsUJAiMHkWJ+OaSjAo8A0R7rOKtfH24aoy1jGU8RzmeZT/hZa lBUILvn6pLYwR4obkxVNh44tpxsolc33xhan6Qv7KVYsmT2nWxA5X6z1/6QWn/GixQkvcs2W2sY frhlKyGhwIjdN4BoNpUaAy5GYnk95Yut3hxcutkaaomvgSUrXdFHZQxZZOZg5kwbNREr6P0ikb1 s+C5AE1UdbqZGAh9IESdxd1E+GHj7Jsb84++xNBabmxCvbBC3Xh0bIo8mU+WgF6PhMu2bGkGWmt FV1ShIQfZPSEi9cqEMtb+I5iqCE8V7hmao3BXKJym+KIjwjII2MTMjabLLCupMhxdu2CtLtLkDB dpoiQhFJrw== X-Received: by 2002:a17:90b:2d0b:b0:38e:9784:dd47 with SMTP id 98e67ed59e1d1-395a044f2c1mr18208312a91.1.1787320692568; Fri, 21 Aug 2026 06:58:12 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:773c:1c8c:24ea:eff6]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327d01ff056sm19972277eec.19.2026.08.21.06.58.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 06:58:12 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v5 16/17] rtc: rzn1: Drop trailing comma from OF match table sentinel Date: Fri, 21 Aug 2026 14:56:07 +0100 Message-ID: <20260821135608.275233-17-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Drop the trailing comma from the final empty entry in the RZN1 RTC OF match table and mark it explicitly as the sentinel. Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v4->v5: - Added Reviewed-by and Tested-by tag from Wolfram. v3->v4: - New patch --- drivers/rtc/rtc-rzn1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 35770bff129f..75713e7b045b 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -528,7 +528,7 @@ static const struct rzn1_rtc_data rzn1_rtc_rzn1_data = =3D { =20 static const struct of_device_id rzn1_rtc_of_match[] =3D { { .compatible =3D "renesas,rzn1-rtc", .data =3D &rzn1_rtc_rzn1_data }, - {}, + {} }; MODULE_DEVICE_TABLE(of, rzn1_rtc_of_match); =20 --=20 2.43.0 From nobody Mon Sep 28 12:35:06 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A6C6495039 for ; Fri, 21 Aug 2026 13:58:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320700; cv=none; b=PRROYakILsnXKy+11HXDtyZGqH47ySA+LT5lsektXppV+HZnvFLjWV17G0eStA+bzJB74aPp9HfomB10D5S6oe3FLtbQBGQBBYiPPVc7U+kJs7FwOKxde6C30lRQnnkSpvlBQcwOQmKvzLm4itg+FoVFHjIVdSTOi68inSr9M5o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320700; c=relaxed/simple; bh=UPDJbJGCBOg6+lUDxPQ/+xKfCV/KTrJ9OCvxOLU+LNo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=muvvwb24+/eWrStRwJcuAuhrBVp2sxXEXC2r0QKz4Tc5+lV7/CL1JdI5x5XMn1wiNI36F4CJUwbcsoEn1BW+RXbfSwrJ9NDAwz6JWCOKD/4sxDNjmcKT6nzzbfqPrIHFHfsrLcyeRUvLj8BX95g+yWEBFu6w4FmrT7hh3qXItRo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SFZRhpen; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SFZRhpen" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2d560775ca2so8621515ad.1 for ; Fri, 21 Aug 2026 06:58:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787320699; x=1787925499; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aYvzNltPmk0j/AWbkVpb3n9XCUKtHiz/lu4CDiEtMAs=; b=SFZRhpenZfTxxR4rr4HJ+DsDcZ/5jxD0MOnVAaH1dQ+UQNxJ/c4ip50ba/TFiGf+uD wEKJIcxzmq4XsUOUNxjWBmu9WUKeMcx9K/PEOa8fH12I5cJUXc/8n1gAeqznWUB/69cF GcPhnxQjlJ+xyY+JCDd/WB89eOiKkbYe256mPMK23xqnX6EgBe9PBImOMCxmy5HGhIJC MGnapZm9cohfSrkVh4/tXN29+E155fi8YmNFFOsKMGu547G2RK/fED3IatVvvATV0u64 C8NE8oWSN2hPrYcgWRYy8I90CtMCCvj5J/0lFSHHLPGEpgW3mhuhvyIxVDIAhzVWS1DL PslQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787320699; x=1787925499; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=aYvzNltPmk0j/AWbkVpb3n9XCUKtHiz/lu4CDiEtMAs=; b=SF35301RKTUBDfihbnxrUMYPd2GPWFRGkL6sjfRaC3fJAw3UxUHh5FQILN/8YxOC79 xI9YMNP8AC+RqZuRSs1UdifOVAOoZqPd6IC+zt1W7qvsaneoYxow7y4Lsa57NHW7AbcL G5C9szUHGSx1CtBa74aVxUgiohi5k3Qz/fwvSy+vdeghj+hyHaSDKNVyeHSLbauOnrw8 +f/zWFJUTqEuEKmvH4/8+nTrwAaUCIuUzfN0itf6S8S6NF1DYicgtTDb3zGBcxPn939F YQJ7afVjv8IRmZAymDjsP9SOlirFm6Z3iVupA3NIANgbTvEqNEAUR1ImaIY6r0Swgr3m dncg== X-Forwarded-Encrypted: i=1; AHgh+RrTZEiDMW4mlawJliCDT4ovlHriABRqHomlIk5OLpF7CQFShXMin5C5TBUJlAkwyPXxc0HqMexOGmYqOv8=@vger.kernel.org X-Gm-Message-State: AFuF++mKNDY4qQCR+wkmUPAdwHQmRgtz6OEOL6i+8imUjq27gd0s1Ew0 iEMIjrNacSSV06pYNYv2nGVgmcpOAILSJuVAa1HqzZUsBXvtQNH9hAei X-Gm-Gg: AR+sD10rDc6A/5U+qnzus+m7MdkxvLyzjNa6M9h3cLCuD/yGlnftkqx4qbQadpKfAaR gXEBmkYmWfdpEHpWym1upwd+MVPX+FH622hGVckqODHyWboKtNgxsVG4JFX534KlAuI8BT5Fe0/ 95CM437nLJ1hO9IvP3Fw7v1CFO7BF4x2WH+YO7IZ6dOtv89WwZqrz8ju0cU0K9juBlFSuGARvYg JrWyzjpwJj8lEMLH4UttxIQ9Ihj4TkTtlTRSslxTlXk+bTsDphtQaWV0HvRwC7wbnmWokSjavgg FWgJJgZlTgdz4ScWuWjYboMbqej83hYFbFWPLUGMT1FvpUEisjG89kxAFy1J5bxp0dJncL++XOu CU5q41sIgjQFY5JTf9MYxbH5clj18J9PEzpGjypYS9x4OIW2OzKOaiNuntrc5++PdpY+dzZAw9p 1/Wp9eg7wwKXCHlFPPxOD47WJyF+MvG9AxI9eqNnpUr2KcmwVy0gKm/5hKdNvgBk6YIsQHDlwDR 1tj3A40XI9fN7MjL4w1Z1aAAVu/EIqTLFBDxMgJpjUEeSFrrImHHHVyp44L/X6AQTp0ttEQ8/sU 6Y5k37kWQg== X-Received: by 2002:a17:902:c948:b0:2ca:e62c:9e96 with SMTP id d9443c01a7336-2d64af3946emr118545095ad.5.1787320698880; Fri, 21 Aug 2026 06:58:18 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:773c:1c8c:24ea:eff6]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327d01ff056sm19972277eec.19.2026.08.21.06.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 06:58:18 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v5 17/17] rtc: rzn1: Add support for Renesas RZ/T2H and RZ/N2H SoCs Date: Fri, 21 Aug 2026 14:56:08 +0100 Message-ID: <20260821135608.275233-18-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260821135608.275233-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Add support for the RTC block found on the Renesas RZ/T2H (R9A09G077) and RZ/N2H (R9A09G087) SoCs. These SoCs integrate a closely related variant of the RZ/N1 RTC IP, but do not implement the RTCA0SUBU register. Use variant-specific match data to disable SUBU support for these SoCs. Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v4->v5: - Renamed rzt2h_data to rzn1_rtc_rzt2h_data - Added Reviewed-by and Tested-by tag from Wolfram. v3->v4: - Dropped RB tag from Wolfram. - Added OF rzt2h_data - Updated commit message. v2->v3: - No changes. v1->v2: - Updated commit message to drop reference about RTCA0TCR register. - Added Reviewed-by tag. --- drivers/rtc/rtc-rzn1.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 75713e7b045b..fab8213c5244 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -522,11 +522,16 @@ static int rzn1_rtc_probe(struct platform_device *pde= v) return devm_rtc_register_device(rtc->rtcdev); } =20 +static const struct rzn1_rtc_data rzn1_rtc_rzt2h_data =3D { + .has_subu =3D false, +}; + static const struct rzn1_rtc_data rzn1_rtc_rzn1_data =3D { .has_subu =3D true, }; =20 static const struct of_device_id rzn1_rtc_of_match[] =3D { + { .compatible =3D "renesas,r9a09g077-rtc", .data =3D &rzn1_rtc_rzt2h_data= }, { .compatible =3D "renesas,rzn1-rtc", .data =3D &rzn1_rtc_rzn1_data }, {} }; --=20 2.43.0