From nobody Mon Sep 28 12:33:33 2026 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56520492516 for ; Fri, 21 Aug 2026 13:16:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787318225; cv=none; b=KkOj179GGTF0lsj3vjiCw/u91YQmjMzrn/iGUFV3nKtaPzhHchhEvCp233Uf/DgapSqcuuaLTm+FTEIesbiiazidBMWw1nc+uGIeIXrysjEiKnBenfrKzk+BpCvqLV399qlhzrXoixN8qGqbAIOb7Ob3emBrHfe4AjMs0JRCUSU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787318225; c=relaxed/simple; bh=Rfp9zD+AGtMykHgxraJrydRglaXqcINy3OxmCxjWxBA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=uAlf1Y+mD7QQkwO+et8Kvd0WrmAulgEq6y4b8SpIjJ00S3F9JS2sc/7EnGfu1e+RKPMXVngl9Pfbe8RnigZqZ1lrpNmtDY1t9B8y9xMNK/yPC+hgqCIFjdPo8VqMzCX4oymWT4u/qmkhfHhA6oP/LX74F30FaDkbXvGuUreX8nw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Kk7psQmL; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Kk7psQmL" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-cbeea240819so586227a12.1 for ; Fri, 21 Aug 2026 06:16:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787318210; x=1787923010; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=MD/tlVb6F1Cs+xT8QKsJqaYk8IH2DGL1DxA0T5Wod/Q=; b=Kk7psQmLvoDAl6hkd/yStmxCuAk2ZmhHZCx5B3u9feY+DhJmhAN8aAuP9lA3VtmyCb MZw4Vy+k1atzgPDdnq+hMwV+fLehNnJ5uzwCis1tym8pyyFBd20QJPqwLs3UZvoLyDCS Z0lHDBRwASO+RxlOo9yjyjb8c3VRD/2eoawCtZpN0tRuBBBjIiuCyHn+qjDYcfVxxe16 8yz/XPWCkf50/PCtyVdrrRi8Sc6mq6asi7SAXGiCZw8zTcw52T/iCB16rta4k87H6u5f QwvJDF6wqLPPPO5ZhhFDzpxiXLCoeNqDbUuJE88Ss8GVwiQTnsYObNnyNIgvgw2R5jM2 ODqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787318210; x=1787923010; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MD/tlVb6F1Cs+xT8QKsJqaYk8IH2DGL1DxA0T5Wod/Q=; b=pTQi7RusDM1SWy7TEr6Dj3ap+RpOk6L5wp0xcM4dfcnZOECnD3WidYyw3PDxGShfgJ IWQ9xTrMxCXZvn7gEelT/5G+4q3gQSdIbWzqQY1PnuNIwWxefXIV1nGFVOVjNmbTQxCW aZfrskRISSEovsHygTfHbVPnaV6C0lNSVHQKDLOyLonca28Ntc8C+J9GCtsYQXLoSq8W TmODlsNbTo7nlr5FxfXCZaIUpGDKGlCeIuPq91wyjDSx/w6n7OCds/Yi64NfnE4SFFqk wi4HSq/8IFbX3L2ZGrDGwhG1i9JTBkiz16qYEBwgPYM4d5LF6ysDx1RJkNGr0YtbLcZ0 s+Sg== X-Forwarded-Encrypted: i=1; AHgh+RpqE/o0Ux0Yrz0yaeMtoj+8infoHy1GCvAhPX7No4+s+BegGPX9Hk/C3BtHWxMMgkXaFoS0FIWeAsfrj6M=@vger.kernel.org X-Gm-Message-State: AOJu0YzNW3w49xsGEUyPVn0Wt0QOVEqUFxUwM7DlGJ/Bd4Sj4KXmtWiw j22eZNe2CnX1P+G1kSlX7KI7jFoiQGSCwpSp5jj4ldUJcr9jm1QxMsfiffSxcehzgMgv7A== X-Gm-Gg: AR+sD12GdfyhPixcqj0k4ySXE6V/yrLbNuEgTRxiROcwT/3DhFAgcMj4nNn67dxr5oq utQGmYXnwpwJ8j7zddQFhpYcWDk9Uo7hJ7k4jclLSrYyisrFXDy1o0839liVN4Yj1v4WyJ/u6n3 NVCcJukudE6dS7P4+nXWy/IIJMWGLSp3wrVXfJmNueb9qwkaWn/LQdK63sIoT9b34ArEDBcFO8g HhSi2RjK9x+UojZ2BeJTd27HzamBz+Q8NHzxECy0PPBC9vzsHM3WZngdGkV5ZKIaDz8ix67OhQy dLQwnP6QKmzsdbZ4RPp7jMNRmOYDhSyPViZSngc+TsVEGapIGtob8ZYzNSd4P57bxw8TEzdKVyX WTOqUHu81i1B6Nv2o/RnlLmYA7v9NP7gbsagU1VfOAnGO2qn+P8mNQo2SVZfM+usXP/Lcz1VTGb gqDY/WQBqv79j9s8G2f1qNsKyNmjRe/R8fsityvymXMIeqQInsLM4+jKd0C2hljkksxNg0KCkrr csVCL1Q X-Received: by 2002:a05:6a21:58b:b0:3c3:875d:7053 with SMTP id adf61e73a8af0-3cd2febf6c4mr12831954637.8.1787318209868; Fri, 21 Aug 2026 06:16:49 -0700 (PDT) Received: from localhost.localdomain ([129.227.183.200]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc15568cb22sm2878114a12.25.2026.08.21.06.16.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 06:16:49 -0700 (PDT) From: chenguoming88s@gmail.com To: alexandre.belloni@bootlin.com Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, Guoming Chen Subject: [PATCH] rtc: ds1307: drop redundant dev_set_drvdata() in probe Date: Fri, 21 Aug 2026 21:16:44 +0800 Message-Id: <20260821131644.71794-1-chenguoming88s@gmail.com> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Guoming Chen i2c_set_clientdata() is a thin wrapper around dev_set_drvdata(&client->dev, ...), so calling both in ds1307_probe() stores the same driver-data pointer twice. The two calls were introduced together in the regmap conversion in commit 11e5890b5342c ("rtc: ds1307: convert driver to regmap"). Keep i2c_set_clientdata(), which matches the convention used by every other I2C RTC driver in the subsystem, and drop the redundant dev_set_drvdata(). Signed-off-by: Guoming Chen --- drivers/rtc/rtc-ds1307.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c index fd3858b6569e..5913210183b8 100644 --- a/drivers/rtc/rtc-ds1307.c +++ b/drivers/rtc/rtc-ds1307.c @@ -1891,7 +1891,6 @@ static int ds1307_probe(struct i2c_client *client) if (!ds1307) return -ENOMEM; =20 - dev_set_drvdata(&client->dev, ds1307); ds1307->dev =3D &client->dev; ds1307->name =3D client->name; =20 --=20 2.34.1