From nobody Mon Sep 28 12:32:53 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4C164756CC for ; Fri, 21 Aug 2026 12:33:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787315594; cv=none; b=H3Bxi6t7nYiPeIOC8A4gjbH16/Ynqv5riy/jyKToQ72pO/VqDUIfn7dcweYD5U2EwLrGSLJh0tcrE0ve8wB/kYC4e2kdPxac1wlYss2g2o+crTsw3h1ofLElGZOgIJ07+MmelGUTXCJ9MSZBYAORGZZlWZBfEcLQZZW+S64zgBE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787315594; c=relaxed/simple; bh=5qMEuy5eGy/JVQD+dpqf2Q/66DUF3xuDuOpkz4CMcPI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RdLUzg4wNcHiKTR14xlUfo2YryJE/l/xPr8i6eNuLpGpc0HYL12d7O6K5mZh9xABZFOLANt1/0vlW6BdHjA3y/4HIgEREt1GAh+HFL7vh09CvAysf1GHnCjdSMr0bxwXthd+6Nb6TonpJBrbzMqAtPI7hAmiUmTfsaJhvTqTrIE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QSiPdCzE; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QSiPdCzE" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2ceaf8a1265so10774375ad.2 for ; Fri, 21 Aug 2026 05:33:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787315591; x=1787920391; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fQhuxUhRanThkxdEOXasCJ4w6JBVmta7BprVKmAc0/A=; b=QSiPdCzEsjkoAJIdg8hWwIk4hzaBSMvm/wgaaD3+4YCZIWKvGkW4hL7eEZlt2NAePy Q5XLRnglu9yG4X3X/baI9TAiZLyVxwEKCykglLoCO7xWLrFmwNI8HFVpbJ10gvDVcZJG xj6+Lz5p+hjB9QRTKu4BOzbnWZHuEjio5dZaH/UJqzWJDAbvFlx8/ygDl5v4iU2aPOMS 6cVEjq0yfWVjWuZFMVFrUses4mRcvStoZhMKQd0aU9pzQ6UmlyGXp6RTzaH9Zuc3V13N 3R7hxK4Z8P/mfRzMglIZeNmUFcqfU4v6TCBmb/tVUPRwsGwfvv2zoSZu6ygM9iUPYswy YRaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787315591; x=1787920391; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=fQhuxUhRanThkxdEOXasCJ4w6JBVmta7BprVKmAc0/A=; b=JjI4sIEYQYucm6FJzZMSY0Im4ozvV1eIfDx0w6FvBzmkpgWozKrTqWV+S2h719SNg5 iDlzjh0h/Ri/oX3ZVr+vikY+KHBZpwg7B875Ua9OhNIjLBX/QfwclhEyh9iNYv90/Ww2 DIXy4a+h1nLnVC0OhBOuOrVGwklRpu2QG5EMLqxi1PScPDUZQFWW/ovBZxiPFsgXmiM5 LeYOPIE8ah+EuRk0V2WiaZMbDWTIsSoda3g99gfiohC5MSP2BHyrabdJA0NFTGKpwg1y JJjRh2EQhu14BJHqP+TxPz/KAwHgeDigf+CYo/otGM0LeQb+oh3AAziiUQETX2uYvwr4 o89A== X-Forwarded-Encrypted: i=1; AHgh+RpXiofbIiqHvK/cHMX8Cq93BInC5+hhsJfLi6h0IsaV8I53l3E0QSAE/1acn125nO416Duvxvb2bKTdeAE=@vger.kernel.org X-Gm-Message-State: AFuF++lw50oJq08UgT6Ga+AGO5N8tVk0V6JYXfXRHOHR42NpryfZQc7g w83bkVTs9tLH2mXpeKxdwZXXmgr8jXX3KdjzI3TghJ2WkGntbmbZTmE+ X-Gm-Gg: AR+sD11C8IOoN9dnWnw6D2+OmRj13hkcuIoope0on3UdPtu2PEO8aCM9WgFmeZ6sWPC 2raBOlLSbb+e9m9ZvjqRylNj/wyQo51sYWEhuXcM1kiQSHmA7p4EmidCJfJYppNzUGNyv8SC1yY gdnfkkpPLEoLyfvMelt5pATER6UYO48xqJRg07Kc68zqXVgQaxMwPJswvsngADFafTVFrZa04fu o50xjNqA+4gxxLT84ia5f9qgfsX/x+j5PGD0GkeeMV+uwEBBDsRazt4cD+Zs9RY9xdnKcEeMqUa vow2i+fQoHyYOn4O6pauZ92zNDBDDWf/7C1w9bEDzC+aJUpRe0Orsm6mJOSCsGksh8EPJooL4+e dl5FhUQyaRtC93n0oTX6Tf0nowwJm01La5yqofbtH3zKoPbu+GNwc6mnanIgLG0kewCkJj/5M7s 5HWcAsFf89UrTvFhIOBdcNmBPY2FAiU6KOXM8lGW3vJGcigF98/rmvwiCgit+GiMBbkNuqJefk1 Bvmb+MwNc++/18qkLpsBQ6q82uv0z9NTLTNNib5dOgXk3hd6nHCrOF00rqK5d0+K5fsLHTb4Fht cp0R X-Received: by 2002:a17:902:ebcd:b0:2ca:481:de45 with SMTP id d9443c01a7336-2d64afa4e37mr124259535ad.6.1787315590698; Fri, 21 Aug 2026 05:33:10 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d62e36e1d8sm18402285ad.52.2026.08.21.05.33.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 05:33:10 -0700 (PDT) From: phucduc.bui@gmail.com To: Radhey Shyam Pandey , Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Michal Simek , Simon Horman Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH net v4 1/3] net: xilinx: axienet: Propagate errors from optional IRQ lookup Date: Fri, 21 Aug 2026 19:32:47 +0700 Message-ID: <20260821123249.41527-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821123249.41527-1-phucduc.bui@gmail.com> References: <20260821123249.41527-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc platform_get_irq_optional() returns a positive IRQ number on success or a negative error code on failure. For an optional IRQ, -ENXIO indicates that no optional IRQ is available, while other errors should be propagated. Propagate all error codes returned by platform_get_irq_optional() other than -ENXIO. Another call to platform_get_irq_optional() in the same function already handles the return value this way. Apply the same error handling to this call site for consistency. Fixes: d6349e3e14c7 ("net: axienet: Mark eth_irq as optional") Reviewed-by: Radhey Shyam Pandey Signed-off-by: bui duc phuc --- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/ne= t/ethernet/xilinx/xilinx_axienet_main.c index 1722b7038f34..207aecb5f8b9 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -2975,6 +2975,8 @@ static int axienet_probe(struct platform_device *pdev) dev_err(&pdev->dev, "could not determine irqs\n"); return -ENOMEM; } + if (lp->eth_irq < 0 && lp->eth_irq !=3D -ENXIO) + return lp->eth_irq; =20 /* Reset core now that clocks are enabled, prior to accessing MDIO */ ret =3D __axienet_device_reset(lp); --=20 2.43.0 From nobody Mon Sep 28 12:32:53 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06FE647ACF8 for ; Fri, 21 Aug 2026 12:33:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787315600; cv=none; b=XiEKJtAtr5MfDErDvQbVh93hGjF/9gLNqM1jl1XQCK/5Fd4YH3F02aIWkPF18EWih3B4EaskHwR9R5wLcKFVHjkJuA8VF1Nr06xND+NPcC4JoT22Pb+BsHXkBYiDko6ezWvNiOfSWU0a6NjnO+roCiIVk5hpuNlF38z7pvsReQg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787315600; c=relaxed/simple; bh=vc9oGAqRaMzb6Xdaj+3NGIpap5QZHwRnk2S+pTd4Ur0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TWce69lHx6wCNUS7JjFizkt/p8QhvC9B2vjYHgo5tTLN/XstKXFrDdV4e4x7l0Yvqb1FNTpBDv5YXaNvZ0qMFfrthdniSc64NfEXe8DdBfBwyzQAcOBB9QrqvTa3yCy3Cb1r332fmI07xGuW4nMyY4fCCmCasx1cjHCm3Npr100= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=tINavzeZ; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tINavzeZ" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2cedda2ce6fso5498005ad.1 for ; Fri, 21 Aug 2026 05:33:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787315595; x=1787920395; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vwKd+TdvIX9ZItYpiwc95hBpIK2+IZI68PvC5hF8oBU=; b=tINavzeZOKMANcMRwKeEUWydp5nWIoCKCrIuctzNkQTHBo31qrRTSBUTIDJjtxHnsi h4p/Wt+VS7MgdRRg1DeUNAnR5t+m9OXzxQGaGegxWFUNw8MynWuU63q93KlaLtzkt4tD fRwMOkbWF8ApoG2dkDeCd0zoPmtpuv5aAqb2Tk47BR2+tXh8Q+GHmkikR+BZQ9rGo+xf dSOJbOnrTCWLmv5W7rnGfhmNWha2CKjeBYNugHvOkpy+wj3UeqxabEacwOhYBZ814Wz2 meBrQK5cu/cUu6nENqQie/qHivE0WKpUZoNslaNbFVDJ0EZdODKp8Ra9D5MwnMAdPIVX tP3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787315595; x=1787920395; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=vwKd+TdvIX9ZItYpiwc95hBpIK2+IZI68PvC5hF8oBU=; b=XHkPd6noxMfOuM8IidkcAbXWgvlfaNW0mIV1j6a15q9lhT0BSWyyc50aWWyTG8ema4 igwq5u3wrTv97Hh+ZVfMELXXZnoNYexqg354mkqoko/xp7/4J1eNtSucjgDq5Ls0EHf4 kkLaVQG/dlUa9vcgCHJ/eGWkpVF7W30XJSxMvxj6N+r9xl+6zdXNN1b6KSe2Ca45NCvy kFD7OlJsP1rEumThYYDDA0PLUdybYJpok85AsNzeVDfFBO6Lyhax2Gn7Vx/FLG0bpjcT jN6KWxs6GQB7yUv9NrI14mfPu9flO3sN+VbLMN9moAfvqHwjyNE1x4Xg0R/2SSvhyzk4 tE2Q== X-Forwarded-Encrypted: i=1; AHgh+RpMqR347oe4W+L3DeeFT4KagyUONWK5QYIlZLNa5hj3CcYR6mpIt40wpNulwWW6OzXoyBTf/Y2NI1A36NU=@vger.kernel.org X-Gm-Message-State: AFuF++l7ujn4W7d4XOI2av9beWFprgoUv3ORY5wdRHqDKKKOdlI7BJtG BRBaYUN4NJ4piq4d1MfEDdu25wQsmgfqyJW7uSBhf422FF6QNdfDYZVH X-Gm-Gg: AR+sD12AswdIk1IBtuMAz1j4s25lV4/7KNbHmA33qflNia5Ms14TKoWrlYiay3pT/19 IUP/UKb+QbycD04TtLo2w2y/uokZWeWgncQVlQRJvma9vXBkMdAIluSFy5HUcG/KZXHatHkn79P Px6llsjzGzvyNTL5AbwibE2tkLlEJiOw+nBHha1/rmbgxI4Mz0ZteaP8z76M/J+vy/22+OFRdKJ Wqffn/SjlfwJeLKiYB4aZ5DFCfnLBNsoQbbY7ixgmPCjx2gYfsMj8Le3qUBxbh7eGwHMzTB224c s3nFlGQJwBTs721mN72PoGPD4QLd3wQ8B6njHgn3FxTPI+/B/KGcWCJprhvV4BVH+Sc2ncgoX3e xksCkhA5kWLiFV/RW950RrWEvq6rFDqLkBhzHLN5o2iH5Gxr57LhEVsEjKjX4ga+RHnFynpp81i EdIw8OSCH8dX72LwL86ornRIthLfhvXQt6OFp4V/Q8POm7L8QfiNYip11P7twslI3FT1TS7cRUu 2ugHouOrFh+XAcFXLcdaFScGfGbzY1UIob4tuyKJ/UW27ubgK6oTHwOoRuNhQinPADmsv4nuEm+ bOZ89DPKDhG5BFw= X-Received: by 2002:a17:903:3c6c:b0:2ca:9d5a:8b6c with SMTP id d9443c01a7336-2d64adc5f3emr120824505ad.5.1787315594849; Fri, 21 Aug 2026 05:33:14 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d62e36e1d8sm18402285ad.52.2026.08.21.05.33.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 05:33:14 -0700 (PDT) From: phucduc.bui@gmail.com To: Radhey Shyam Pandey , Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Michal Simek , Simon Horman Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH net v4 2/3] net: xilinx: axienet: Handle optional IRQ return value correctly Date: Fri, 21 Aug 2026 19:32:48 +0700 Message-ID: <20260821123249.41527-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821123249.41527-1-phucduc.bui@gmail.com> References: <20260821123249.41527-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc lp->eth_irq is assigned from platform_get_irq_optional(), which returns a non-zero interrupt number on success or a negative error number on failure. Errors other than -ENXIO are handled before this check, so -ENXIO is the only error value that can reach this point. Check for a negative value instead of treating 0 as an undefined IRQ. Fixes: 522856cefaf0 ("net: axienet: Add optional support for Ethernet core = interrupt") Reviewed-by: Radhey Shyam Pandey Signed-off-by: bui duc phuc --- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/ne= t/ethernet/xilinx/xilinx_axienet_main.c index 207aecb5f8b9..3927ababf833 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -3052,7 +3052,7 @@ static int axienet_probe(struct platform_device *pdev) ndev->ethtool_ops =3D &axienet_ethtool_ops; } /* Check for Ethernet core IRQ (optional) */ - if (lp->eth_irq <=3D 0) + if (lp->eth_irq < 0) dev_info(&pdev->dev, "Ethernet core IRQ not defined\n"); =20 /* Retrieve the MAC address */ --=20 2.43.0 From nobody Mon Sep 28 12:32:53 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 913A93CAA2F for ; Fri, 21 Aug 2026 12:33:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787315607; cv=none; b=jIPwHDpG0fbRoHKkM1hFMfXxHeQ1rDem8u5UyCirzvZcAk2V53c2p6C6JOckxHQoOtYOVmxVtR2cFIlOoyikoLb2LdYc8a3UcFZlKdRYFWqzRtXpsR/DkgB3cOfkplRMwHJHs5RLEm0ztTSTUbYZX2+ODwlFwa/qXHw0pe50u24= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787315607; c=relaxed/simple; bh=qWwV76eXl8pi9NZ1itpMyPueAYtNcqe/axydeitklGc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B4bRiMUcexGmMl0Nm9WAdJeRaYkWdZ8A08I0PKJoWHZXN5MZmE01G0aYNHWc5Z4mIS+DuAcU4DBAApGxWTVQAABMaBJXjKJd3MnUfVRpkO76A3pZoBt/gVKoqtPALgglnC4XWhlGcnua4KPVezjvmGvMzbzgT1kStO5r1SMBACs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ivjc4975; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ivjc4975" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2cacb8416a1so8875785ad.1 for ; Fri, 21 Aug 2026 05:33:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787315601; x=1787920401; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/AXB9IQGSbDb13imfwWL/kXTtQeUapOU81HM4JBB/5w=; b=ivjc4975SoQw545ulJPyewVPDufA0w9A9lQVJM1aMPAGO5ub1bKTyOjyWlq0CgQ86T 3Tw/YWZdddM00AoeAI9dHQwBaZSx2f01n7PAXWTqG5XkArs9S7MJKlCIwhL44R/VsWNC FhmhDuLCZOEp4sCdIKxdW4nVQaW9DQrjJ9np6HFi6MmF3+Pvf6Mq1DtpS3a9qEINEF3m Kip0bPIhruHUzMohafiJcHNw4RnTiNCdRuw/rcrKCkxGV70pugCUlOGOLdL4d/KsHNs1 +4JYuePWs9WoPG12mwGkPWYpKVfVVgBl6/dr0m7rpuyh9RCE92sveZSmjEn/2jFhCZUS eRSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787315601; x=1787920401; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=/AXB9IQGSbDb13imfwWL/kXTtQeUapOU81HM4JBB/5w=; b=duk6qJdoqFExrjoFz7jJSj64SGwSWoP2qV09pUiyvLGQiFiJEkDfPbQqvvIqUVnhzZ GxiZVxm1V/rnOq6Rsjl2gRUNq+eGuiOrMKMJOGwONwDPMX+ufASWGYjKSl2NzOmnYmDt Jnk7UVJuDxNkKuKZsw/K9sNxNL7sAAGMrpk57xmtm9ScSKIqaqSOF+jCc/+Jk/YHw7M3 5vgM+oVkQDmUeFgoNJDukse+a+qkg0WGGfZSQmKmOJyImTF8L0CCTN1hz0/kN+xt3+yY xgoP38X7v8c9xOhxJR4dfy6VcFpoK7P0WB+lCjYacKX9sjOQUcCrm/HiPOBb2uBzbGmy 5VMQ== X-Forwarded-Encrypted: i=1; AHgh+RqSM1Xsh/rmPsbini+9RBWtBJr0FYjSAUjqMJzTsORjVGe1SOcIDWOghRNR+jVHF4Ei4VSfmyf3JXE6gFA=@vger.kernel.org X-Gm-Message-State: AFuF++lKo4VKpc4RTVDHmbegD/Dx1H5O6+Q0lVAKMNmKEmysPURQ/t43 /h7+ZSieZIIT4vxKjkiCKStj1BpevjNFoZQnNFQ453IXJf7Nib8kDxV2 X-Gm-Gg: AR+sD126zk4xpEw9Q8oP6fVjOVFE0D9x5gue0rkR26gP1FuVFZ9//TFIt3WlQemeh5v ndMa3xTD7WDIyfZnDH7CI52cNzMpzVbrozk/nbCvucoE/Zkt59tpn5ZHZD15UkBrKJC7v0Ojyj2 Twi4ILKwRMFYqe4XY+BTy/U9zp0IjiWNAtPEAcr0loBPphJRmiiGqVIDIervNQl0IEBa87gSd+6 JuRYUsMkt47+oYwX11KI7khGIinj1YK3AUZFjn+W7JOI3qst2AT14Pa0tMYZ0k8waCFwu2JTQA5 wAeCA22WdqB0RNDfYT5UAlcbo6CFZDLmFCXnH9Jg9+Vdn2j71JP1zHCRj9A6wdrDqUkWe5NLPOZ RIGuz/gpDDYA9aGpYeQmPbgB2YO2c/QY8bm4B/5ss5SmD0wBmJ+7aPrTOgsXNylGsrcLK6Cymoa bqsj/q7xQzANmfKZBxdnJLP58lEv4X7Gz/7hpRW7XBX1FAq72iQBApzvX3HZhpjY03JMpMfbeEH CY54qz7gMjuQkWbw7jA+27cjpfOWUhFfnl2w6NO4iOpzlN8c2UYcD83pOV7qlnf3TqbUGCgmPPU Y9xZ X-Received: by 2002:a17:902:f70e:b0:2cf:afa5:b19a with SMTP id d9443c01a7336-2d64afd7c86mr130049755ad.11.1787315598800; Fri, 21 Aug 2026 05:33:18 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d62e36e1d8sm18402285ad.52.2026.08.21.05.33.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 05:33:18 -0700 (PDT) From: phucduc.bui@gmail.com To: Radhey Shyam Pandey , Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Michal Simek , Simon Horman Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH net v4 3/3] net: xilinx: axienet: Fix IRQ error handling Date: Fri, 21 Aug 2026 19:32:49 +0700 Message-ID: <20260821123249.41527-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821123249.41527-1-phucduc.bui@gmail.com> References: <20260821123249.41527-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc irq_of_parse_and_map() returns 0 when parsing or mapping an IRQ fails, while platform_get_irq() returns a negative error code on failure. Handle both cases and preserve the original IRQ lookup errors instead of returning -ENOMEM. Fixes: 28ef9ebdb64c ("net: axienet: make use of axistream-connected attribu= te optional") Signed-off-by: bui duc phuc --- Changes in v4 :=20 - Add error handling for irq_of_parse_and_map() drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/ne= t/ethernet/xilinx/xilinx_axienet_main.c index 3927ababf833..68b580191508 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -2971,10 +2971,14 @@ static int axienet_probe(struct platform_device *pd= ev) dev_err(&pdev->dev, "could not map DMA regs\n"); return PTR_ERR(lp->dma_regs); } - if (lp->rx_irq <=3D 0 || lp->tx_irq <=3D 0) { + if (!lp->rx_irq || !lp->tx_irq) { dev_err(&pdev->dev, "could not determine irqs\n"); return -ENOMEM; } + if (lp->rx_irq < 0) + return lp->rx_irq; + if (lp->tx_irq < 0) + return lp->tx_irq; if (lp->eth_irq < 0 && lp->eth_irq !=3D -ENXIO) return lp->eth_irq; =20 --=20 2.43.0