From nobody Mon Sep 28 12:32:54 2026 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3A7C1D432D for ; Fri, 21 Aug 2026 12:29:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787315391; cv=none; b=aRdlTGl2HD8M0XeIiAM6xfT72iYJk8YZutZ/ODZ/+Wle1GETSVIspvib7AKA5NZwZB7JGsrznpzQUQdsZQswLhM9MIn/4+35pwQhYZJytXqVCa8ckVI0R6NAxu/hJYP65/2ELwhaFXRgQeMxlUK9N+xQAMu1znEh1NaZKZ7kLxY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787315391; c=relaxed/simple; bh=JP9eOEHyaoXV9HbY5hWZqU+GNYeECJ8ryV8lwd7nplI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LnRIbpmHOpIdz45POnqUsgRIEXAufctyfTVrx6GZhEm7X1Q7tlkNmMkM/EslyNfQKZKyNaJ5eufoNPR88S2Y1wbT7LYXD0q/iU9Wk8DacvjTLczSMbg38vY9sKEsBhcH7ZM9LM2+wBSvZoHz3y7kWjk+B7fXqokNdTUoAQVO7Q0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CSnvZ6u3; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CSnvZ6u3" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-8520161fdb9so345028b3a.3 for ; Fri, 21 Aug 2026 05:29:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787315388; x=1787920188; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=axXA4DN3AZ7lZ4uoWKWlKISmN+79vPMNk4IXFpeL8kY=; b=CSnvZ6u3vsNqCBxlXpoeFtEDLpJC9Kmq00d987fMvI3JTW9U8OqNJGTcfk3kc9Vl8v drUWethG+ljyTYYLa6FKM6ChEXEieulh+QW8s6NURAMQP9F2QYhlRKvAYnfLnOMD7ZdG pKlEMBTvzSBONwe+PoNqyjL1RfwL4nrIayDTrhR9eVd5EwsxHCR76E0xripxz7T6377S eigH6Ob1Y7tat3zNpH9ZW5qb/02brdiYjBCh4ysks1UVVYDXCQGySy0aaMWZHl16KMX4 oVThkuT4VsrowvA3wrUh3NCwWK75awyy68Hmyd0WXmEEzX49q1io6M2uarM1HFbUye5v 2AQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787315388; x=1787920188; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=axXA4DN3AZ7lZ4uoWKWlKISmN+79vPMNk4IXFpeL8kY=; b=FNIubwnZSeYdrAUONkDAQc2BY3U1Flicf4KsiJewLw2OdP3l75nNeVRQDGYcx2iHQz CIEjmrccukXGv4f5s+HNK//UuVDjQDHYOVaNlbmYFwPH0i1w9aW9SLyN94SCRSgsPgOE wy7V7AxAqiJ1wxkSkNHxtzMhWCusklxaXl+kyOFt+QpnHK8B8qwhmFnxMTm2xvkAdEw1 038db/SBgvHU0q8EgLkHSlhRFjDrsTwJoAT0DeGVtnMs2NzjHJKcYR+Ft8zRoAN4QDpY MiwokXdKcNWmEIPsX3gEcqdM8Gyg3w0oXPbwm48Fp3o8kLQYpGP4J9WuSaRWGrtij6Sc gTGw== X-Forwarded-Encrypted: i=1; AHgh+RrW+muIVAIlj1fON/rTbHNezVau8tg6faIcFOeLm3Hs0sElX+V4HovwBAw0Qp+piEfz3jel1JVZ/7jmrjw=@vger.kernel.org X-Gm-Message-State: AFuF++lIlv2MlbLgm+RbR0qzpQoI827y2MIc3qAs6TkuVCXWVUSjfnRQ Jt3efkeONmNBw8usls7vf88DiDRTPSPJlZpPdG7yfxlh6Zl40Dni4TzY X-Gm-Gg: AR+sD10/cl0cfXh3tbnn8t19mzMUHBkoiSVVg2RKjyvm53OyJksrI7iNJYukYvIUIq4 T9zte1QKhPcUGnZkhKgmnFgOGgX9wpmwpUdWIG9cohJCUlDvxKES9eNvQwm/REO4IRKsJXhRtQj mgAFGwdO5CfYHnjk/8FXeG0RoC1mWC29ZXP75LRrMh0n0XHNGWDTxa84vaL9xD903MUqOvV8r0j HxmdJRpiW/V9zDd7GR2lSOQ9fr5qnJvkV3Pw7S9FHAbG7JtSDpsP8K+21oz1cn2n/cxaA4iP4Nz K73q0do6yr90twHqm8E7NVXFpKUOSAkyyKwo+XkmjK/dO3v8H+bH6bIFCjlXIiexo4QywFeNffZ PfadvfuD1USDSkHb0WXgc2pJv0Pfsjj0OaasRncASJfPv8uoueuakLFY9HXb5xmeyhs2NkStWsg GsGAxtgj7j4Cjg+NWfhJoVWRqNG8J+6IPqMbKRquIMefIBI460Ao6I3CqKoa9/rv+QL9g9lGbwZ fNSiXEuYtgi+ZI7nMQnkmGYaGwknH+nQ+zaZ567I6YYx+HdLtjOrZTL2B7CDwCEYlz2b/lPPLua nRYS X-Received: by 2002:a05:6a00:a589:b0:851:c2a6:172f with SMTP id d2e1a72fcca58-851f9efcc14mr9394852b3a.7.1787315387771; Fri, 21 Aug 2026 05:29:47 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-851d3389fc4sm2848582b3a.14.2026.08.21.05.29.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 05:29:47 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Matthias Brugger Cc: Liam Girdwood , AngeloGioacchino Del Regno , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 1/4] ASoC: mediatek: mt8183: Fix wrong clock cleanup on clk_set_parent() failure Date: Fri, 21 Aug 2026 19:29:25 +0700 Message-ID: <20260821122928.41343-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821122928.41343-1-phucduc.bui@gmail.com> References: <20260821122928.41343-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc In mt8183_afe_enable_clock(), when clk_set_parent() fails, the current error path incorrectly cleans up the previously enabled clock instead of the clock used by clk_set_parent(). Fix the error path to clean up the correct clock when clk_set_parent() fails. Fixes: a94aec035a12 ("ASoC: mediatek: mt8183: add platform driver") Signed-off-by: bui duc phuc Reviewed-by: Cezary Rojewski --- sound/soc/mediatek/mt8183/mt8183-afe-clk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/mediatek/mt8183/mt8183-afe-clk.c b/sound/soc/mediate= k/mt8183/mt8183-afe-clk.c index cc4f8f4d3dab..6ab0734ad136 100644 --- a/sound/soc/mediatek/mt8183/mt8183-afe-clk.c +++ b/sound/soc/mediatek/mt8183/mt8183-afe-clk.c @@ -137,7 +137,7 @@ int mt8183_afe_enable_clock(struct mtk_base_afe *afe) dev_err(afe->dev, "%s(), clk_set_parent %s-%s fail %d\n", __func__, aud_clks[CLK_MUX_AUDIO], aud_clks[CLK_CLK26M], ret); - goto CLK_MUX_AUDIO_ERR; + goto CLK_MUX_AUDIO_INTBUS_ERR; } =20 ret =3D clk_prepare_enable(afe_priv->clk[CLK_MUX_AUDIOINTBUS]); @@ -153,7 +153,7 @@ int mt8183_afe_enable_clock(struct mtk_base_afe *afe) dev_err(afe->dev, "%s(), clk_set_parent %s-%s fail %d\n", __func__, aud_clks[CLK_MUX_AUDIOINTBUS], aud_clks[CLK_TOP_SYSPLL_D2_D4], ret); - goto CLK_MUX_AUDIO_INTBUS_ERR; + goto CLK_AFE_ERR; } =20 ret =3D clk_prepare_enable(afe_priv->clk[CLK_AFE]); --=20 2.43.0 From nobody Mon Sep 28 12:32:54 2026 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC2BF280CFB for ; Fri, 21 Aug 2026 12:29:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787315395; cv=none; b=OojtMestGecPtWqXTKqmJMrb/s83XUGTA9Dun2gz2NJMPpyRzuy+PHEkwGVGf3+m0VCzO3Ihrqrf6cb6P1uYdtxZ246Hk9Evs8b9CV83b6k1KV1LVfe/grNJ2REUm0Bdg5UONUvcNlM98114VUfnPg4bkqYnsa9jT2ZTtFcFx98= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787315395; c=relaxed/simple; bh=o1MWaXkXr2aP1vAPknR4xkrDwfhPNsw9JwAuoBORvkU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K0lf2tQNyBd7/g2aDvRB5b1M28T4vHanbcweGgqTlclvBtlWuiKSw1W47ako19W2oWSKOw1U6wnudGTUx2HDIaemgMzV4BOOOufQSrojnAxFDc2pm0Lfabi2ENWOyylKVOgGZb4+C2kyj05/izBkhw5i2CUXT0uOEr38zwqXqro= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kzId3syV; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kzId3syV" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-84e3007a2b7so755803b3a.0 for ; Fri, 21 Aug 2026 05:29:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787315393; x=1787920193; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=g4hgMi6/uNAtRYrz9ZogYJurz7z1EY11bapUhL//V5s=; b=kzId3syVg6pWf2usunhJde+DoqY0Ik7itg6gKbH4FSUXXaVnrdfdXvAwzEgEKj3bPz +ShcRTvhM4KIJAzQBWpSVSvheWF8IVFS53zrLBEyqAl4BUa29ZcoiIBiJ8vywIeL12J6 d7eZI4ngZsBpC39RSM/uh1+L331mQKPcY5y2b2D5hRKo1MMkigPzNkqsvcc2Ax9zQ43w R/JtFwz576FY5tDJN5tZQw5bw1P/HHBJ3IvCmm1K792yVxgtQZMOxGglMVBo5TQ1iOPE 4qsrCLQxApyYVk9qjDXSJ6Z8uJDgzjA75E6eaNSa2G7fv7A4r0VbAJYFO7txiCkSe8Zi PrdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787315393; x=1787920193; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=g4hgMi6/uNAtRYrz9ZogYJurz7z1EY11bapUhL//V5s=; b=LQLBdHolkA2NUlB06SD9XQKRXincn452zhrPfv8pDoVIBgbcxVsiKygY3a82KHL4RJ ZQjBAN7jvt6Jp10XnL/UvwSrR3wIx+LSmAKmRl7diMyXWWFjqXQ2V6JeB1b/eRcZG8rP U0sla5NqWZRSNIhLSyI/ZmklqkZw36y9IspPwFyLIKo5Kq1ZtnaoYFY+GhbALcgui9DH 0a2qBaT3oq443Vu6HUlA0PNEO5jcEWO5nPPIk4ygx5zSVbG1EHwOARQB8R9dcIsgqY4H 201d9qbOLxXnDT2w0nD5YbwT1bKAt4ZJgQCDfKzswM2XR0olWb8C6Xvw6JadtUut3MDx 2RnQ== X-Forwarded-Encrypted: i=1; AHgh+RolyGgG7c45xOaCXckaWxVr+tJxO++lDVlpsgFo4UFTq912gAZTyXZh7SAAODmAM3j0eRMkMkxR52T9ED8=@vger.kernel.org X-Gm-Message-State: AFuF++ndFwgLHvmF6iimtT0imk8ez4+7KQ97uLw2FCwlwEySXfZf3KB1 Du9+4q9kxKO9co4K4cMiU1X1URrvF0grcwQPsE5AlE+vDswf1vYlRGKR X-Gm-Gg: AR+sD12+11vOlrgip/WfS72bxoyCzozTV/s4wzgAS+sZm3dpuO0rux6z7vr4Wp5JIoj H7c7Eb+3uYB1q47aqPDZRr6hhoQmEj4P+s+zn2QC8tF/B8aotA4d6tUxOYfGzOX/afXYhgnYtyS ELlFL7+RfdiLoymxOHp4ThthLN/rQZNy9KsPb/rz+4RaIXK/8eYxCk9e7K1kHevtGgQkzsIwZfN F4ye1zAdeVkIrM6dNpVcbG7n4qVqFP+S4e84I8daeZIqENNK9ZkV6BW8hJdJOR/MOq7m+f+fe5J QVtdyQkpTWMXAJF/N8tIDKFBNpnWb2VqBjv10NAox+nLYTudsdXxhYDtl43qz2zdQkMUclrK0mG GSiJ/owAgJEEBR4sEhm0JZLQxBDRRkEx7b/26x7QSlz88DBn4cez254B+iT7E/okbZ11jExed+Z 4onJAczQqcqxIqEac45CPCo+b+deiTvkna0AjGfp2dG901oVDRUKo8GpPQvg/eOiC61fqjLW+MC AFpnNeSZxttkt5sqKP5dp8RMt+5HXl21gAeUh/yr0qaBWs3WUdLs1nZ8GEalaf+bzzJW9t2f7xF n7QNOw== X-Received: by 2002:a05:6a00:328a:b0:851:b03a:fcb with SMTP id d2e1a72fcca58-851fa018184mr11023615b3a.14.1787315393221; Fri, 21 Aug 2026 05:29:53 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-851d3389fc4sm2848582b3a.14.2026.08.21.05.29.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 05:29:52 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Matthias Brugger Cc: Liam Girdwood , AngeloGioacchino Del Regno , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 2/4] ASoC: mediatek: mt8183: Fix APLL enable error handling Date: Fri, 21 Aug 2026 19:29:26 +0700 Message-ID: <20260821122928.41343-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821122928.41343-1-phucduc.bui@gmail.com> References: <20260821122928.41343-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Currently, the mt8183_apll*_enable() functions call mux_setting(afe, true) but do not check its return value to handle failures. In addition, the cleanup paths of mt8183_apll*_enable() do not call mux_setting(afe, false) when the enable operation fails, while the mt8183_apll*_disable() functions do. Add error handling for apll*_mux_setting() and call mux_setting(afe, false) in the cleanup paths when mt8183_apll*_enable() fails. Fixes: a94aec035a12 ("ASoC: mediatek: mt8183: add platform driver") Signed-off-by: bui duc phuc --- sound/soc/mediatek/mt8183/mt8183-afe-clk.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/sound/soc/mediatek/mt8183/mt8183-afe-clk.c b/sound/soc/mediate= k/mt8183/mt8183-afe-clk.c index 6ab0734ad136..0790d8123179 100644 --- a/sound/soc/mediatek/mt8183/mt8183-afe-clk.c +++ b/sound/soc/mediatek/mt8183/mt8183-afe-clk.c @@ -382,7 +382,9 @@ int mt8183_apll1_enable(struct mtk_base_afe *afe) int ret; =20 /* setting for APLL */ - apll1_mux_setting(afe, true); + ret =3D apll1_mux_setting(afe, true); + if (ret) + goto ERR_APLL1_MUX_SETTING; =20 ret =3D clk_prepare_enable(afe_priv->clk[CLK_APLL22M]); if (ret) { @@ -411,6 +413,8 @@ int mt8183_apll1_enable(struct mtk_base_afe *afe) ERR_CLK_APLL1_TUNER: clk_disable_unprepare(afe_priv->clk[CLK_APLL22M]); ERR_CLK_APLL22M: + apll1_mux_setting(afe, false); +ERR_APLL1_MUX_SETTING: return ret; } =20 @@ -436,7 +440,9 @@ int mt8183_apll2_enable(struct mtk_base_afe *afe) int ret; =20 /* setting for APLL */ - apll2_mux_setting(afe, true); + ret =3D apll2_mux_setting(afe, true); + if (ret) + goto ERR_APLL2_MUX_SETTING; =20 ret =3D clk_prepare_enable(afe_priv->clk[CLK_APLL24M]); if (ret) { @@ -465,6 +471,8 @@ int mt8183_apll2_enable(struct mtk_base_afe *afe) ERR_CLK_APLL2_TUNER: clk_disable_unprepare(afe_priv->clk[CLK_APLL24M]); ERR_CLK_APLL24M: + apll2_mux_setting(afe, false); +ERR_APLL2_MUX_SETTING: return ret; } =20 --=20 2.43.0 From nobody Mon Sep 28 12:32:54 2026 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0CF13B5F63 for ; Fri, 21 Aug 2026 12:29:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787315399; cv=none; b=spb7dnfdAd61yHQnHIuAAGiblkQaX+3mFRpFoGFnJkEUSIhvQhQtW1v8n2PdpFyFjxMxLzu71uY5hMo+B8heG3OJPi6N0I0qKpGDqFx8Uv/2tHhkolyb19WzlPPo+bMJONXJ1bxq0tkPbO3cBpR8B1HEBPWicrJxRoOG8YVWveM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787315399; c=relaxed/simple; bh=0nndnxehF8p8gtYhNyKcqNJYzw8UX2W6RofWyaFs+6M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LmWGUL5+/sUGAIoclw75K2PkyBXopRpgMX7IpTAcb04aPURGoW/XD/xEmOn2w65omU+MwCJhzK66M6C6IB+q4LMv5AAdxkQ1jwGL1vWQM+lEw1B72VLS35GYlB3SIeFtWbv5DBTv2/FAi5wh/O76ghlkqh/eFRAUaDfQDV3kRlM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VOJJh6DA; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VOJJh6DA" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-8486672f03cso879324b3a.0 for ; Fri, 21 Aug 2026 05:29:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787315397; x=1787920197; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4LEpADh7BRFyWhypphnGElkUejLABiWZIaIIaxvhaYU=; b=VOJJh6DAUJYMD8UNS7zwg9CL3NIRFBqeV8E5tWphL4Rw+cTYWSooiqB4fOZoz8qFJt 2AVB77TbZUhxO0OJb3q2EdsmkBBE+6k59Vi8IAiQhxW7P0MSgTTkYB8ASxpksouIeG2S 98Xdq+nop8brY0HDhmvn10g3sGZvfab7q0ODvaS0RuXs0irPEphIctAYUluIja29hPS5 75oXyaUSbsJitt26OCPa8RXZeoKx2trAP7vxAkDqYBThbZ9lGzTm//i/TbbpqwGohEp9 byYZsndpZpjFGLnXVS9FHXnGOcdZ0JLnz8CysnVX13vJCdd2OixTCWXai8t6zXQ9ujkp cedg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787315397; x=1787920197; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=4LEpADh7BRFyWhypphnGElkUejLABiWZIaIIaxvhaYU=; b=qDup8vvWc6pQWVsAH4OfpdLfM78yJTLC5yjVlbZ9/LOglCBDytxBjS2tFnq2psSDBu zytv2HxF7ciLBmgTbvvCJciL9uquM3CCw5QYU4+bS3XN9wyRKvNXL3tHa5tSZiD/Yr+e 7fvPxnt3s8ArzlaPIJLa4MGX/HMJ5jr4tfdJC0see/AfbryyXGNCR01Pl8rQ10TO9rXq yUNjic3HJcwRPE+HmRliqn1nOennuE9Rs4qjxRwfyuSemLc/Dat55jtd6aXWEUkziBxr g2+sUrdwqxkbckQwL81O7OTHYbyOQ+QKZOXbMQq9rDUQWL+FkbD0WTtPG9YGxId+oT57 tATA== X-Forwarded-Encrypted: i=1; AHgh+RoIn9o4AJJVFS9a65szfIXgWAgOJiFai8NrvlRudyOFmstRJMlz6JwNl095GUTbWszKEzAlg+3AO7WIc/w=@vger.kernel.org X-Gm-Message-State: AFuF++nnfPG1Pl4nlU+XrVITzfbDFTs4aFMtwRrKIla+VX2yFKmgnUWW aF31C3D2bs8Wm3bFCG0u+5lZMqGXkj1Tpe4/88/dQaAWo3FWhBK4SRi/ X-Gm-Gg: AR+sD13fNr5ufaJoXLftdMDifAQHUUBjJJAK3TxmaOsIX3e1FGze0vTcdYDArKye/AT 2hK4OVX3vz1xv+09sB8IrVwkmK5MB4VHr8CO47rOJQxPgOkfri7xIz17dQM7Sm3K/yJXUcl4Zyo vW8ISkmPYoj4CNVr3Jk6Xn2fAt2KFYZDdqx6A6VNiDV9Rh9fMBSQd8PiAUHrp1aNz7HDrouUa07 nVXVBkM3ENQ0XMWmLqVG3Kp5D0kmbtCk+OZNnHkECwpZ0oxXZsD/TvmZFSRe5kSIGVLshLNUTA+ yIzLCC35NC80Mvaj9LxqDhQyOeZf+x3UKmvWd6fgY+1cDB22ZJ6Ln3vsf6R8LST6rx0aYe3O+Wa VXdMABL+/ypVxVESWnxtXi7m4oJBafYlyfd8YqYavffaorYYxwZIFulnwtbPs9wQFZ5uf4mxmMU 5lnAtlmjHazOMUX89HuAtV88HfsETgL7qH08NUvdbulayI98CqBBjOTdBXHeXtZYDDP5D+GuE1d VLKT1dIshq/ytr3KhE90rOAToC1PH13iBTdKjIbnZMjxzTGqvWqD2aqmzcsOUH7oRg+7RfMZSrT Easx X-Received: by 2002:a05:6a00:ba8e:b0:848:34ad:3d6c with SMTP id d2e1a72fcca58-851f9f4a715mr9133903b3a.15.1787315397244; Fri, 21 Aug 2026 05:29:57 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-851d3389fc4sm2848582b3a.14.2026.08.21.05.29.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 05:29:56 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Matthias Brugger Cc: Liam Girdwood , AngeloGioacchino Del Regno , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 3/4] ASoC: mediatek: mt8183: Use dev_err_probe() for error handling Date: Fri, 21 Aug 2026 19:29:27 +0700 Message-ID: <20260821122928.41343-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821122928.41343-1-phucduc.bui@gmail.com> References: <20260821122928.41343-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Replace dev_err() with dev_err_probe() to prevent log spam when probe returns -EPROBE_DEFER. Signed-off-by: bui duc phuc Reviewed-by: Cezary Rojewski --- sound/soc/mediatek/mt8183/mt8183-afe-clk.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/sound/soc/mediatek/mt8183/mt8183-afe-clk.c b/sound/soc/mediate= k/mt8183/mt8183-afe-clk.c index 0790d8123179..46cab62220d9 100644 --- a/sound/soc/mediatek/mt8183/mt8183-afe-clk.c +++ b/sound/soc/mediatek/mt8183/mt8183-afe-clk.c @@ -101,12 +101,9 @@ int mt8183_init_clock(struct mtk_base_afe *afe) =20 for (i =3D 0; i < CLK_NUM; i++) { afe_priv->clk[i] =3D devm_clk_get(afe->dev, aud_clks[i]); - if (IS_ERR(afe_priv->clk[i])) { - dev_err(afe->dev, "%s(), devm_clk_get %s fail, ret %ld\n", - __func__, aud_clks[i], - PTR_ERR(afe_priv->clk[i])); - return PTR_ERR(afe_priv->clk[i]); - } + if (IS_ERR(afe_priv->clk[i])) + return dev_err_probe(afe->dev, PTR_ERR(afe_priv->clk[i]), + "failed to get clock %s\n", aud_clks[i]); } =20 return 0; --=20 2.43.0 From nobody Mon Sep 28 12:32:54 2026 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 161AC17A314 for ; Fri, 21 Aug 2026 12:30:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787315403; cv=none; b=HfxlQA3wEO+iwBzJF/vp5PQygscLWlCGgtkcqxjawDqNxx/aFIT9/AqVykdUpG6nYXrzmqbsAmQnll5eRJTF4nrYKMuQC5leZWa5gt5V4+g/yIlHIGYIcve0+9QvL6E+y2akbzOH60oRkQOpoEjrokdC76VrQQ5GS/WtEeq4onE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787315403; c=relaxed/simple; bh=zEAIp01i3h10m+RYZSGGuoMikAPiELBP+Eozmgpa9VI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mnTzcroBDqgioMqB/FZHj4WW+o7Y8jQoRO0WxiLFuzsM5RZ2VSpK4PgtrXjlm5poLLxcnjW+4hAaLDHaXih9+Gsrh8IDvhTTHGPjkU+VHRkRIE5b1GkNFF9U4qVP9818/scdcIcHAdPhdmX+s/UU5UsJ1ncV3EdTOqxZDgXza3k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GNaNAFpJ; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GNaNAFpJ" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-84a4d8fd6ecso900649b3a.1 for ; Fri, 21 Aug 2026 05:30:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787315401; x=1787920201; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=n/R8GtrWGADXhpWF6ZZO6tx1YvN32z2nTVacJoZ8tOM=; b=GNaNAFpJmuJPIDk2LVYgqYe5OE9XMsh2VVANeBzsjTWYbrUJvXdSQ0/0FOc5CKdj3+ kviJCaPn2UdoG8dVyxitWI8IsR+yuFax5opbTx8oImT1YDqAoSAotQEW43sPPuO2KgI2 rX0NWec/VFKJMRtZQLv8xcNe2Kb+Lz1ttnDRrz1AzsUMdJnpeMhv8PySq+aX/bRUf+1n dXhLcVHNpG3LDoZdSfghN/ga/788TxyFaIs4goejCUtuX8Fxhqzy6JMxatl2MktFhtqD e75jvx+YZD89rxW1VQAGGCTFMs7fSEcYi87h+rjYLsUh8AbaOrIu8InhbKEB6k/kgluL F6Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787315401; x=1787920201; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=n/R8GtrWGADXhpWF6ZZO6tx1YvN32z2nTVacJoZ8tOM=; b=OVS0cxQZsTpEHKTEJ2MSTv5qeUKR3hWNSO1y374psJT6Qw0LFmjY0uielbJhzOnTQW 4FouLnRMTI2cj//tsKJj9HgJwsXaHEYg7G57VnzWDcpNGYBCPqlIMrqe4LqWnnxnLj1A xHaKYv3Tx59414UjlvqiUxgp+5wgbKg0K5MhQM5f6f4/roMUcULXyHffF2N7vrcPmAMi qGU0ppsolXDbHeTqoXBNmJHzF2yPBSxZ30eqi58ygQAJ5IlIzFwBN6bHBAUknK7FkjQq rqcsuzoY3e0ropkIKrRJFnrNmH4o8HyN1V1ftRkaYPeBBny/QBYV75aqln/L6RPxeYAD o8ig== X-Forwarded-Encrypted: i=1; AHgh+RqebdQW23PBwDk1726JK/nnKOIhRJkUiWaQMKeYXXw7qa9rzUp5W3gouE7E2yzd/Vm2hRI3PJWb+M/dcV8=@vger.kernel.org X-Gm-Message-State: AFuF++kYsRtmePoQR4rkI4BqI6Utnrbk5TO4zhA7GHokF0XxjsseqV/n HvzMc7KaTk+91vzNg44GU2hi8GRE92EeCMlYxFzbo91GMaEeJPt5UkvvTdy/Eg== X-Gm-Gg: AR+sD13AN36UY0FP0Jzozv6b/F8ZplpJfu0zQL+cT1i03KW6icNjSqvEoZ1tWcIjhak noJSUYRUx221of4OKK1reS9PBG6Wu0ERl2WiVKoknHWg3tAzwQmcHQ0a6fynyifiRPmda2FArr0 D7aEx2AgANR+s+6K44kPf6CpXGsIKtybEQr140NZV5o8mZA7qjB+Q7mosXAE383d2OCC1SZ/86/ CiBjm78jw46ebSnZQm8WQlDJ1RpDgObPB17cMWF31CTXxyIBvZ4ysmRXGS1VrIGKkuFKvZYhsSi GJJljmFA3BasW8XlfmJIdq9Ow6d5mhxA2ZI4oId1SpTFmFSLO9KpY2EuXKgf+gXJBsSYgcHqHXQ 1PeKg/Nl4y9K2ozpWMVdt6Ja9mMoDich9GyzHZfMVxkZdEBWK1HTLFC0zW0L6vc1R4h4DMYNmB/ XzvvZmGizMpSY+aicZoaM7e7Z62p16Rg6m40we0LvXYOenBlrum5TkcfYxQxmhFGDckVX3dOVGA 18DUSoreldn2V+6OnnnrnQgj0kFIrwMTtKcJPx9nQBcTUJqWmy9N6Iox4FgbdpH+HQT23hmv67B U5nE X-Received: by 2002:a05:6a00:32cb:b0:84a:646f:193 with SMTP id d2e1a72fcca58-851f969b3b6mr10656377b3a.0.1787315401447; Fri, 21 Aug 2026 05:30:01 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-851d3389fc4sm2848582b3a.14.2026.08.21.05.29.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 05:30:00 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Matthias Brugger Cc: Liam Girdwood , AngeloGioacchino Del Regno , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 4/4] ASoC: mediatek: mt8183: Drop redundant probe error messages Date: Fri, 21 Aug 2026 19:29:28 +0700 Message-ID: <20260821122928.41343-5-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821122928.41343-1-phucduc.bui@gmail.com> References: <20260821122928.41343-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc The errors handled here are already reported by the called functions, either directly or deeper in the call chain. Therefore, the additional dev_err() calls are redundant and can be removed. Signed-off-by: bui duc phuc Reviewed-by: Cezary Rojewski --- sound/soc/mediatek/mt8183/mt8183-afe-pcm.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c b/sound/soc/mediate= k/mt8183/mt8183-afe-pcm.c index 2634699534db..46b7a2bb6aaa 100644 --- a/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c +++ b/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c @@ -809,10 +809,8 @@ static int mt8183_afe_pcm_dev_probe(struct platform_de= vice *pdev) =20 /* initial audio related clock */ ret =3D mt8183_init_clock(afe); - if (ret) { - dev_err(dev, "init clock error\n"); + if (ret) return ret; - } =20 pm_runtime_enable(dev); =20 @@ -903,10 +901,8 @@ static int mt8183_afe_pcm_dev_probe(struct platform_de= vice *pdev) =20 ret =3D devm_request_irq(dev, irq_id, mt8183_afe_irq_handler, IRQF_TRIGGER_NONE, "asys-isr", (void *)afe); - if (ret) { - dev_err(dev, "could not request_irq for asys-isr\n"); + if (ret) goto err_pm_disable; - } =20 /* init sub_dais */ INIT_LIST_HEAD(&afe->sub_dais); --=20 2.43.0