From nobody Mon Sep 28 12:32:55 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4386F3655E4 for ; Fri, 21 Aug 2026 12:29:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787315344; cv=none; b=V/jQPccLZ06tRQFIY5ruTpeXgH4EGNHBuCsmccBHoxGw17Mu9gsrwq1ghYmsahtYmXXYy+aZOEE0w3T6MZkgBI5iGjdVEDj9OWHj/vZOQNe+jXdzXNYF+NWw6KyMk8J6igI8EpH8COaVgrEGHkCfm445qLhMRy6jlHssrwVxr7w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787315344; c=relaxed/simple; bh=5KktxiklsF/0QCkN3dKJ354QFQXWmjZRHfGMH6yZW44=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=e/iKeR8+mbQ6f7clvGO1VxJFbomcJ0g7JRpY2s/+ljeEe8+Fv4jk4wgfbO4kWiGlq9mBg6QFYsZGWhp0uZwUrq+Wcv+Ix0gHC9pAG/fRSUtQAU14L6n3whbQLxIOJeI8NeVbabhL34/dyDku87p3FiznrGR6WSuvQ26A86+Bb7E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RqIBjrux; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RqIBjrux" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2ce98cb8165so8020615ad.1 for ; Fri, 21 Aug 2026 05:29:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787315338; x=1787920138; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7EdEJgY9D5VmAtVYQAvmQy6QO5FD2ftLDiJehs4hR10=; b=RqIBjruxWSEX+t9H9aOzZgXh9Jk8lVGcWZWJxcHmnjPCbb/2CMIqwUftJDsG/jui8k WUOmPb+djfmaUJVfH/JVZ0qQua0tG9FFYEQEK8Z+2NjBbf5RLxr/+GKvpGe4r85PL7U0 Bgarc1NIejHzxB9m7P7Op+LaFKCam7J5jqSrNMWdA3WDVI64R6wairW560PplTm9QMSZ lYZ9b8faSOebj2WsY8rvuwxuT9tvvDFcYuleWGxvDWKPyzlORU8gtN+3VCFJHyxKCe/o UUztpIl4IgKO+kufsYva2mWMr0c9rEobSmo6tIWH9wazl4iKN2qs7U6cO14x21wPNq9t HA+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787315338; x=1787920138; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=7EdEJgY9D5VmAtVYQAvmQy6QO5FD2ftLDiJehs4hR10=; b=dDvrVyCy3QlrsEh34hxaIO9+VT4OshaXGPlDJ+2McOnY4fuu2hx2JZmgbjHr9f5sxp 26ZYppWPVGOxFKl4q6EnUldkvxl8XADKFJAzPpsJprzuNZLvfKyY41p+2bCCuLUHUi/s zR1CyxweIazNUXg8UrtV68Df8BPKJP+Cxkrml1lUGVQ+9uTxqy+zF0MNLl07wg3t7DPI 10dLGrkdrNFDP/vQRqjsAu06Vj6NL+Ir1cO07Wu6fsNzEHpZbFj6y56/tObSY9pTwRCF zR5+CUcCmhNxjUeROF1uLWT9vAx3fTn77Lqequefuvs5uKlL1Hr84/gFxmA9HjaoFp1C PIFA== X-Forwarded-Encrypted: i=1; AHgh+RpnDPG9JMFwvinrp22wrJdDaOluQfq4coVoj/TlcbMcf/y8lFIi0Kg00hGn9IMna0czhsQp+k02dd9VfsA=@vger.kernel.org X-Gm-Message-State: AOJu0Yxa3OinAZBTyJfjCjEvz40XiYxEqZ12hJE9URJF1zZi1OCb+93B K2uSWEMd5b+bp/eIbpWM87XDF00wxA0Z7kFTSQY4uOQP4i9b61ufVARH X-Gm-Gg: AR+sD13Jqp2VLrK3NX+7B6inrecAoWSnTNXrXQQ23g7yMvQm62jK5Ppyrk2NAzCbuR5 ik7/0YGqNiOLhhpjstlpRLIalEZ7bzM2l715ezvwEm/KKw30IfU/sS/R0oMLWFHpqZVp9IXljmZ JRAwdesFkVieEfyaTrewN5gW6FjLT/gLdfL8s/IQGGm8CbQS3BAC4Zxp9GIim0lCCS5iiAq2Qvc fj4juVtYB84hxvDhnpesywE8QWZgY51i6LEJfPsQMom765Wggf4b06zxFB/aXqZfNe9bqTSK8Bo tB3X/bU+w6nXHHIJlWq/fEst8TnZph7jxT1lXP10FSWgbvgFXkAbMAvmq25BSvFH7xJZdRAXpNW Iq3EK3Y6q0pnCaZNaBmvQXplkYy2JSOk8qmJQqnX9e3O0ZmW31q7eeIjs70AJQcgQbRBKXVpKBu WBj6WH9iixpgktdKaxljB8Z1TadN6VaIjLROU76Nsnp+2VG+YD0cL3MntoW3UTTZJeIvf9IImFJ jIYX71Umg4Vj4dRO2SS9GUJwpZZBi7MUhpR6YxUvCyle2XHQIJP5Mn7PKKjrYcSW5dqfu2u9tu1 Y9Uig1bJmfFMZwU= X-Received: by 2002:a17:903:1aac:b0:2cf:af20:4254 with SMTP id d9443c01a7336-2d61a15e594mr181843635ad.10.1787315338494; Fri, 21 Aug 2026 05:28:58 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d62d554450sm18134515ad.2.2026.08.21.05.28.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 05:28:58 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Matthias Brugger Cc: Liam Girdwood , AngeloGioacchino Del Regno , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v3 1/3] ASoC: mediatek: mt6797: fix wrong unwind order and error code in enable_clock Date: Fri, 21 Aug 2026 19:28:38 +0700 Message-ID: <20260821122840.41266-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821122840.41266-1-phucduc.bui@gmail.com> References: <20260821122840.41266-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc The error paths in mt6797_afe_enable_clock() use incorrect goto labels, causing clocks that failed to enable to be disabled during cleanup. Fix the goto labels to only unwind clocks that were successfully enabled, and return the actual error code. Fixes: c5e7fca928d3 ("ASoC: mt6797: add structure define and clock control = function for 6797") Reviewed-by: Cezary Rojewski Signed-off-by: bui duc phuc --- Changes in v2: - Update the subject prefix from ASoC: mt6797: to ASoC: mediatek: mt6797:. Changes in v3: - Add Fixes tags. - Add Reviewed-by tags. sound/soc/mediatek/mt6797/mt6797-afe-clk.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/sound/soc/mediatek/mt6797/mt6797-afe-clk.c b/sound/soc/mediate= k/mt6797/mt6797-afe-clk.c index 6f3e6acfcfab..0ac04d73b777 100644 --- a/sound/soc/mediatek/mt6797/mt6797-afe-clk.c +++ b/sound/soc/mediatek/mt6797/mt6797-afe-clk.c @@ -63,21 +63,21 @@ int mt6797_afe_enable_clock(struct mtk_base_afe *afe) if (ret) { dev_err(afe->dev, "%s(), clk_prepare_enable %s fail %d\n", __func__, aud_clks[CLK_INFRA_SYS_AUD], ret); - goto CLK_INFRA_SYS_AUDIO_ERR; + return ret; } =20 ret =3D clk_prepare_enable(afe_priv->clk[CLK_INFRA_SYS_AUD_26M]); if (ret) { dev_err(afe->dev, "%s(), clk_prepare_enable %s fail %d\n", __func__, aud_clks[CLK_INFRA_SYS_AUD_26M], ret); - goto CLK_INFRA_SYS_AUD_26M_ERR; + goto CLK_INFRA_SYS_AUDIO_ERR; } =20 ret =3D clk_prepare_enable(afe_priv->clk[CLK_TOP_MUX_AUD]); if (ret) { dev_err(afe->dev, "%s(), clk_prepare_enable %s fail %d\n", __func__, aud_clks[CLK_TOP_MUX_AUD], ret); - goto CLK_MUX_AUDIO_ERR; + goto CLK_INFRA_SYS_AUD_26M_ERR; } =20 ret =3D clk_set_parent(afe_priv->clk[CLK_TOP_MUX_AUD], @@ -93,13 +93,11 @@ int mt6797_afe_enable_clock(struct mtk_base_afe *afe) if (ret) { dev_err(afe->dev, "%s(), clk_prepare_enable %s fail %d\n", __func__, aud_clks[CLK_TOP_MUX_AUD_BUS], ret); - goto CLK_MUX_AUDIO_INTBUS_ERR; + goto CLK_MUX_AUDIO_ERR; } =20 - return ret; + return 0; =20 -CLK_MUX_AUDIO_INTBUS_ERR: - clk_disable_unprepare(afe_priv->clk[CLK_TOP_MUX_AUD_BUS]); CLK_MUX_AUDIO_ERR: clk_disable_unprepare(afe_priv->clk[CLK_TOP_MUX_AUD]); CLK_INFRA_SYS_AUD_26M_ERR: @@ -107,7 +105,7 @@ int mt6797_afe_enable_clock(struct mtk_base_afe *afe) CLK_INFRA_SYS_AUDIO_ERR: clk_disable_unprepare(afe_priv->clk[CLK_INFRA_SYS_AUD]); =20 - return 0; + return ret; } =20 int mt6797_afe_disable_clock(struct mtk_base_afe *afe) --=20 2.43.0 From nobody Mon Sep 28 12:32:55 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB2823939D2 for ; Fri, 21 Aug 2026 12:29:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787315347; cv=none; b=P9XBYVSnSHQ865hvk/jIfOsCsQfrZLMbXzBi4RaGt0YfvqBgH3kZhmkYIxxBx9DMp332iKJn3GK+xc6mHrN3Xr2r2VEX11Vjv5wxSzYfNTauNuqb9gCD3xguNwAG9Yd8pdY+pEFjBYLiL1sK3Aqtv363A2/aDuyGFQPoCu+EELY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787315347; c=relaxed/simple; bh=/4u2SLF/VeE7FsrTrtRP221xMUuJQxfBqk4va58nyr4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oIhk6Sn6kKMsmYPhvdTtrR3MfVbsoEMJsSpEpoAuED+aGt9DkNBZ/1srmga4X48REUXdngWEYB0p2V4QdhacnXKbvbPoCB2gpbt+1Fvw91fCudV+yAFc9l83cnSHV8ZAFc/Js0e7CQynfLBh794fPqXpdlPpYWfWcQir+qv4038= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e93ptjjY; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e93ptjjY" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2cca0c5799eso8080695ad.0 for ; Fri, 21 Aug 2026 05:29:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787315343; x=1787920143; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dxWOmCJy6lCBH+hX8gsDYN0Y68D8NP3gz9hPpZDLYDs=; b=e93ptjjY/ekleF66U2V4LrvlX1IePq+L5z0F57KaSu9DEDroA5OfBw/7i5xFeL9Aod P8Np7fmcOLUKmjpBKi+K64EDOqxdXS3m1b7Ldb4+VFBse4bdwPC1u5CMk+QVGaNqxkol iFdincG1g9L3a/NJVUC5tALxxItkUb8lFFQIGdFrsXeHbSmzwXa3h7ZgB1qTKPnC+Wxg GvaQyjtGRcez1xcgE2ItFM0r8Gn+RyjrpLdiNoEVxzajA2Vd4rATMdIB1yFgy0qhe4SD 3YpQ4zKgXvf9bbJEZTX5D0dAZEWKBgympI7KuT6kJgRRbAbwSfrrUYYQiaPFTjIQA0qs +XSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787315343; x=1787920143; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=dxWOmCJy6lCBH+hX8gsDYN0Y68D8NP3gz9hPpZDLYDs=; b=EwbffLhfqb++GqcO958w71/yZlnTpqjXqATb9/KF+T2WU+8K5/Yhv7zNrfaXb/ls/Z 8/twF9sdBb9b9e8t+DP7wEryGvOpD94xDegbVFk95krkEZYZLwURb4pqhD5+O6C17SDM YgHG2A58tcNCplHse/heLmuBNYbnDotr8Ol154WOrDjyOyP4HeG/LeMDhjALVs9md8ds jM1BNRaxf9WaxYHO4lJ4Z1Spp1NDBWO6gBs1tIB+htklEaP2wJBhQ9YW69STv5W88vbW mfzqKT9KBK/lrFqyQkuoUSf+AP0ucoARxJdjj9V6UV5aC1wGU5mwYOJs0PRuxMqvV4DC 99tQ== X-Forwarded-Encrypted: i=1; AHgh+RqnPHyLrAlj7prTue6GfcuhZjpDlysNovnweBKM4O/atKOJLiSzQWl/GGNGwTuwGRABKnLKFZkpiJNAi/o=@vger.kernel.org X-Gm-Message-State: AFuF++lhKHZsTYde/02ceD3yKNGcxN3MwYiv58BSeAQQbThxEKO8GFNp ldS2r34WpwpPfgXLcv8hroR1/9tUKjHYAhoE1skUPp5oE/9US5Zo0Yb+ X-Gm-Gg: AR+sD12PT3OrgZvzMozTvyoi1DS8Ttykh9RNDSwdMzWXwIcK5UXugtx72W49f7CGACy YvauWuzVj3HhoxlbVBaYEFRMXxmsoAp8+bBp41wLQXFZgjxwnlqD3kNne1vYkY95NsjRfvUmYu+ X0Dp15pz2zzA7r3coz5Eea1ekt0RB+e+lRXXjuaApFt71XRbndl2AwMTruqsXybjHdwZWlJaq47 N0grcXP1Ge1ZzWxITR5wrJ9eyg6ZgWqSjmJLJ6sHoi33szixEHvioQIazDKpMkEjD9ImcwPw9sv Y4oeZd5pgj0yUPHN/+QCVyM2UKhtyWS5nhr0MGSgpkkOtJUTixi0AuUxSmmvD22CtwcXCr/nNrb w3UWEmz7RxCccY96MjLWd6kvT4WhGehIJOM4i+gSfgfZ/Zdb3LVDr+i0BkZt3a+x7bhOndQ1Zks PwyWp/LbWQ4MvlDH4rnCzjptdHu29GQ92GvmOUr3EU413DBLepKgiw0CB3cNpFkXRDze2mqd/oh +BJNsLoc5nojkoSW1XusOnzunESwku8t6Ui0+xsUnTRGKjBZAFMZ/oinEdgKuJ8WhzephUqshQF erRp X-Received: by 2002:a17:902:e790:b0:2ca:ce92:6e44 with SMTP id d9443c01a7336-2d64addf4a1mr124433205ad.8.1787315343392; Fri, 21 Aug 2026 05:29:03 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d62d554450sm18134515ad.2.2026.08.21.05.29.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 05:29:03 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Matthias Brugger Cc: Liam Girdwood , AngeloGioacchino Del Regno , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v3 2/3] ASoC: mediatek: mt6797: Use dev_err_probe() for error handling Date: Fri, 21 Aug 2026 19:28:39 +0700 Message-ID: <20260821122840.41266-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821122840.41266-1-phucduc.bui@gmail.com> References: <20260821122840.41266-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Replace dev_err() with dev_err_probe() to prevent log spam when probe returns -EPROBE_DEFER. Reviewed-by: Cezary Rojewski Signed-off-by: bui duc phuc --- Changes in v2: - Update the subject prefix from ASoC: mt6797: to ASoC: mediatek: mt6797:. Changes in v3: - Add Reviewed-by tags. sound/soc/mediatek/mt6797/mt6797-afe-clk.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/sound/soc/mediatek/mt6797/mt6797-afe-clk.c b/sound/soc/mediate= k/mt6797/mt6797-afe-clk.c index 0ac04d73b777..2326496f8b27 100644 --- a/sound/soc/mediatek/mt6797/mt6797-afe-clk.c +++ b/sound/soc/mediatek/mt6797/mt6797-afe-clk.c @@ -43,12 +43,9 @@ int mt6797_init_clock(struct mtk_base_afe *afe) =20 for (i =3D 0; i < CLK_NUM; i++) { afe_priv->clk[i] =3D devm_clk_get(afe->dev, aud_clks[i]); - if (IS_ERR(afe_priv->clk[i])) { - dev_err(afe->dev, "%s(), devm_clk_get %s fail, ret %ld\n", - __func__, aud_clks[i], - PTR_ERR(afe_priv->clk[i])); - return PTR_ERR(afe_priv->clk[i]); - } + if (IS_ERR(afe_priv->clk[i])) + return dev_err_probe(afe->dev, PTR_ERR(afe_priv->clk[i]), + "failed to get clock %s\n", aud_clks[i]); } =20 return 0; --=20 2.43.0 From nobody Mon Sep 28 12:32:55 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 849B446F484 for ; Fri, 21 Aug 2026 12:29:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787315352; cv=none; b=UM72yKqO++rAc8o55T9aKIObsmW055Im8dzLJUYyCVppXWXlvs4Nhhrer2b44zx8fzkJoAsT9el/v3EZpHn9MMyYAAElKxw/hmptgFo+STrek+sZLWTXP3kNbrIRpKZR6Yon7Noxnoel9O1rKPkgM0rCyTpRiEh+0V7P0v+nc20= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787315352; c=relaxed/simple; bh=zX2xH0hnleXnxASw3p8mQlwKldU26+p9sD9F+XzEK5E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a43As3xyveb0KtQdqIRtBEN/CHPXlO4gOd6WcC8EFwwL4duzKjuLAxCjgNdAtir6YbLpa4tmSlC82IVZrNI51JkTVdC+yCGq/e+Fsd+2od9uO1y6y2aUGLDSg7EAnZC8vjkmPWpOvP6YR3RwcuQBs0KWDcN1bIOvAMgPLH1bcgw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BVQBrkkP; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BVQBrkkP" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2d5655cc850so11449065ad.3 for ; Fri, 21 Aug 2026 05:29:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787315348; x=1787920148; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=A4REjDq3qQ541r3i4ayJG3CleHwU/s8ILvHOWp0kZT8=; b=BVQBrkkPMFrZmGHr5yoU5G8m63rUw9ws0EWoQTohk5ZRm71blab+ULdS9egcqjFC6q kuyxd4BlTzekDkq48cbNIfvNCBrOwzBn7+RoTEc/oPU1kPQ62PYTyeTHwFi0gpizDZqc SV/kNmq1cFBllOcDjYZae5TU6SQpHu3YGL4QRCDEcM5cmDtvG11o8cFg9IutTker/ztH rIC3XSF+bzeaFHMXt4lLxgQygPoxwDigEomwFcF1yVrQrgTgmHA7VE9HO6Gl1hz7to2Y khwKJ63rbWm3wnmDqsoruuEdvM/EeiUh7sFInx15SgKj0CvOzHOKWjoqZRGMuhzzcR1S HgCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787315348; x=1787920148; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=A4REjDq3qQ541r3i4ayJG3CleHwU/s8ILvHOWp0kZT8=; b=HtLSoZs+2G1YcjGh0L3lSBi4CIw7JVuNb6GG7mGa8t9GsdOE/W1YboFHWT62KxTjzO n1y50I8trDPMzzHVYmChDBFZt7X+f3Lb85lZFJGhBpT+DNw5Nd2/+fODj7dz5vUysc52 FDem5vnou+n+H/7iVm0k6gFhlWVHyvQQJ6Gz9TllmoPxJC9k6oUzfh7eGGN6T1eKWzw0 p6H57c4/e1nkLw6I6b9xDiKBG5ltHvSCQ+fmTSl3SMFANls0jGszv6UP318johswz58C jpBpVGxb/9FCbsNvHdCUBDPK88mrI631Ylgs9v8MC211nX1Ut53i8uVZifHNQJiU1V/y 5z0w== X-Forwarded-Encrypted: i=1; AHgh+RqeDQqsI16xSlKQMM6CYAy4j0d79TU2QrWiAtcaFOcpNEGIHgJaDO3sHkrR2mEVQmwrGaOUfaPTZECjpnE=@vger.kernel.org X-Gm-Message-State: AOJu0YwHD0tHY0c5UUah4TvprSXCDA+vMgySkPM5DGePoyg3dnQ+hiGF UThw2NbzhOFZ0Z2zfLkB9bLeO6kSi7qrdsuYwEdvHd7yNmPlL0IkJ5lg X-Gm-Gg: AR+sD10DyVWmGiV5c+agIwx4uR55Ql2fZp270/UMJhx93FGXp2gHufxA9XdpITRvlSE PHDWtwsS5jlbSdv007khlkLLhvCDacXJtf2hD/e1Vec6iXPJfOgdGF9Ezn6t7gamCNhFID9vr8P ohagLlccs2qzzWi52suKhaxOaB+w1cZ6XYCpYYSLc6D/NHJ9Tp76sEGTJz6Gx6ai86WFoF88VGM k6uqCp0zNJEeArvOnOfARY4ObpEviOty3Bz1ORvQPbDB6BXh6PVOQBzp56CHdPxzjeljLjzvJox 26H3b7yZQiT/nJmvdO3dudpJVezzXmSY+XIs/25oxvfcIBkRS3KmfzTQPvveeawtZYEaKtdYftl QcGptsdhYZb0cVBpH7Vq2KRGJ4L8yGknvWAUEfUqbRsMi6DLUylCeDEQqPGzZ1sBLDx9qkkVRpT 8vvQJl5awLUYsp5cqtBM6uFEW1HDhyUc0krozwqlRhXFOtbZ7KHFe7Zti41u3NC/TjwHBuevsFQ /Tce69wNXOO6hIsAsGPZaEqEfgK3XO2cWbjSTbxFfRuJWDvnwQhLyatO5wIkydBYiDePGmIeks5 O/6V X-Received: by 2002:a17:903:2b03:b0:2c7:f4bd:91b5 with SMTP id d9443c01a7336-2d64a9b349bmr122049005ad.0.1787315348266; Fri, 21 Aug 2026 05:29:08 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d62d554450sm18134515ad.2.2026.08.21.05.29.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 05:29:07 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Matthias Brugger Cc: Liam Girdwood , AngeloGioacchino Del Regno , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v3 3/3] ASoC: mediatek: mt6797: Drop redundant probe error messages Date: Fri, 21 Aug 2026 19:28:40 +0700 Message-ID: <20260821122840.41266-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821122840.41266-1-phucduc.bui@gmail.com> References: <20260821122840.41266-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc The errors handled here are already reported by the called functions, either directly or deeper in the call chain. Therefore, the additional dev_err() calls are redundant and can be removed. Reviewed-by: Cezary Rojewski Signed-off-by: bui duc phuc --- Changes in v2: - Update the subject prefix from ASoC: mt6797: to ASoC: mediatek: mt6797:. Changes in v3: - Add Reviewed-by tags. sound/soc/mediatek/mt6797/mt6797-afe-pcm.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/sound/soc/mediatek/mt6797/mt6797-afe-pcm.c b/sound/soc/mediate= k/mt6797/mt6797-afe-pcm.c index f62a32f2f2b6..dfe67727fe47 100644 --- a/sound/soc/mediatek/mt6797/mt6797-afe-pcm.c +++ b/sound/soc/mediatek/mt6797/mt6797-afe-pcm.c @@ -754,10 +754,8 @@ static int mt6797_afe_pcm_dev_probe(struct platform_de= vice *pdev) =20 /* initial audio related clock */ ret =3D mt6797_init_clock(afe); - if (ret) { - dev_err(dev, "init clock error\n"); + if (ret) return ret; - } =20 /* regmap init */ afe->base_addr =3D devm_platform_ioremap_resource(pdev, 0); @@ -800,10 +798,8 @@ static int mt6797_afe_pcm_dev_probe(struct platform_de= vice *pdev) =20 ret =3D devm_request_irq(dev, irq_id, mt6797_afe_irq_handler, IRQF_TRIGGER_NONE, "asys-isr", (void *)afe); - if (ret) { - dev_err(dev, "could not request_irq for asys-isr\n"); + if (ret) return ret; - } =20 /* init sub_dais */ INIT_LIST_HEAD(&afe->sub_dais); --=20 2.43.0