From nobody Mon Sep 28 13:18:32 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BFF93BFE33 for ; Fri, 21 Aug 2026 11:35:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787312156; cv=none; b=Ji/aYzAtfn6Mx/9TWhiAUGbtQlLkce+cuGCa77l5RK6OOSf5AR+8vmtMCT8rDaYvBDPFKsEmjkvhlh9ZfiTZnkMYBBCrZSbTyxMV4mVkew2UkJUQ+9nc4FY+E6xxEKa8RY7sqg6tOO6cAquDSSQeyArDWyq3uBCL4h5ufXkEIS8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787312156; c=relaxed/simple; bh=f4b6Z14LwAUVlBtVHyCQvaZ0gVyjp7iu6GQO8lPI2Rc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nJ3XEe2429cp+6bt1MbTVF/oBCMF2xBv3KEWWF0WZmGCy2CqfxOd8zi/JAlo0iP2w+hdsToINEUarDnNhZ/Yu5ShtcGVxhPyxNRSg6P3wMm4mwBsiDGXMZVy/1PLVqvSn9yhLRjl7kLKRR1H+xAwf9rPLvReTS00uD+2pQfd5+o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L+BRkV92; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L+BRkV92" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2cca0c5799eso7600945ad.0 for ; Fri, 21 Aug 2026 04:35:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787312154; x=1787916954; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=NrMxw7QdyXXxUtL5k1Ui0hoJIKBHXT1pSk1NNI967cw=; b=L+BRkV92secE720kEGoQ3ynW+XAHKM3QskwHDOAh9RS5N+YmP2eohmkkOJzyjLEgaO OXKyQniZXa2Q8G6e7D1B3OQ6A3G/4b3nlfIzRDATlMmhkQUb+dqj9LfGWfg+rIgCEPNX OV6VnRicGHVpq9bWmUclPaV8Ur+qVGi8PpGgAjDRDToYZMbFNiLmjLNu2aEXodcvOiCD 1q5BoHKeUVG8SzuA3B8nPPBTJZ2VoBrIqXc4wdYwpmgMJHGQrG8KuoSXsLGJyw/9kbQv jHvEFbnoyTGHYiZMNnA01bCDd3KIx/MG+ep8CXvEZc7riUBAQEQSK1n3+hNe/dxpB/qL kddg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787312154; x=1787916954; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NrMxw7QdyXXxUtL5k1Ui0hoJIKBHXT1pSk1NNI967cw=; b=e3Wm9TXNcXIT6RNaKoJYQShWavFRAMpyWklU/Tg2LYqtTU7QJH44oLHbQa8LlCQYTc hGnDl+lOH4N5CA4USmTT62l3hwFS+vCIBrwPXedWf1Tj+k5DhaMVeBX3KCT0cs+7vkaW f6/Aut8QJeOcOsipzMNpaMXxW+F0kBDkwQ5nQhhjhJ7ZQ1llmSbgqmfvq1qDeaBmTfJC MyDfi5r/OdsvAWmQQnNKww+aOiAmaCOUBBKtyMdz0mhQOfHNgJnkG1ItwO995308YN0Y Ht/uozmhf1ncftMlhIInW0OPmBTh58TTckDWCdt1OMbiT03rtOXTp9ezz3fV75WPwutV wedw== X-Forwarded-Encrypted: i=1; AHgh+RqPe6dAM09+nKilfvkX3DY1BuEHfZe3mr00O7Pu1yjI4zEQIBPcs7kLu8wDjHrLj4nT8ASpJjYBNJ8A9vg=@vger.kernel.org X-Gm-Message-State: AFuF++nUjGhlcwUoBrxxRiS6CutjFXv4vP1eBiDSdBWMcKj1NM0mUHB4 ZRKYguvPR6REDkUPSDDNAooLND6DTTpDSiwk9QJwllxduqUqjeT8Vnx8MFWqKtj5p3w= X-Gm-Gg: AR+sD11e0XZaoax5gneMk+mHL3dtRLk4NZVEYURAueXtFw91UJaK0QIfKUrnfv9qCTF rjLifk0P4NxGVWnovOp7/LtgHffvboKpPRLa9enapCuwhWLsath/q8huFnj08c51KBOPdQ8GRPb MwJYco1Q0E5jjqeIIGIOWdU5d+0uDWwC6XZdt3BPu3BDZ/XuMB8t0MFUwvdD0djh/eRKgGKQuCW QWUA3hs6/dmqldiY+dUrcuG2Cygox/B8g4FJs6eqKc6VAyn3Ye0rKs+cZe4Q9zp37HdLQhgXBvH 64esv4uoH4dPh7/MHG/7E46N9Z0NbSA7vJOsDsXv7TpaHP1SqEg71ZebH6+fmRifAFYRxjAAOC6 GuZpaTwb4Q4ybdoOg1SWvBw2nkruWc83nuB7DgLTUYEU4nXxc0c3s6zr8Qe2PJ4/JeiaE1qHE5G hPeG+JlqLh4sRO+wq+u6fO1ypugXsLG57sO3fuogL1vgmreoNKeHSqXBYSqR9gT1Yy+4OVlDqjm 37BKXcEKE3DSWXF9EGM2JDSjLv1zNnps7A0bfRaTKtmzrb/yMNA X-Received: by 2002:a17:902:f70e:b0:2cf:afa5:b19a with SMTP id d9443c01a7336-2d64afd7c86mr121829745ad.11.1787312154155; Fri, 21 Aug 2026 04:35:54 -0700 (PDT) Received: from hanzj-mi.. (ec2-99-79-140-187.ca-central-1.compute.amazonaws.com. [99.79.140.187]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d62d5ae489sm18261655ad.33.2026.08.21.04.35.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 04:35:53 -0700 (PDT) From: hanzhijian To: Greg Kroah-Hartman Cc: Viresh Kumar , Johan Hovold , Alex Elder , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, hanzhijian Subject: [PATCH] staging: greybus: bootrom: fix potential NULL dereference Date: Fri, 21 Aug 2026 19:35:40 +0800 Message-ID: <20260821113540.1989561-1-hanzhijian1991@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In gb_bootrom_get_firmware(), the queue_work label dereferences fw->size on a path where fw may have been set to NULL via the "if (!fw) goto unlock" path. This is currently masked at runtime by the !ret short-circuit (ret is non-zero on every path where fw can be NULL), but it relies on an implicit invariant that is fragile and hard to follow. Move the next_request calculation into the mutex-protected region where fw is known to be non-NULL, and initialize next_request to NEXT_REQ_GET_FIRMWARE so the queue_work label no longer dereferences fw. Signed-off-by: hanzhijian --- drivers/staging/greybus/bootrom.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/greybus/bootrom.c b/drivers/staging/greybus/bo= otrom.c index 83921d90c..289c9e957 100644 --- a/drivers/staging/greybus/bootrom.c +++ b/drivers/staging/greybus/bootrom.c @@ -245,7 +245,7 @@ static int gb_bootrom_get_firmware(struct gb_operation = *op) struct gb_bootrom_get_firmware_request *firmware_request; struct device *dev =3D &op->connection->bundle->dev; unsigned int offset, size; - enum next_request_type next_request; + enum next_request_type next_request =3D NEXT_REQ_GET_FIRMWARE; u8 *firmware_response; int ret =3D 0; =20 @@ -293,16 +293,14 @@ static int gb_bootrom_get_firmware(struct gb_operatio= n *op) dev_dbg(dev, "responding with firmware (offs =3D %u, size =3D %u)\n", offset, size); =20 + if (offset + size =3D=3D fw->size) + next_request =3D NEXT_REQ_READY_TO_BOOT; + unlock: mutex_unlock(&bootrom->mutex); =20 queue_work: /* Refresh timeout */ - if (!ret && (offset + size =3D=3D fw->size)) - next_request =3D NEXT_REQ_READY_TO_BOOT; - else - next_request =3D NEXT_REQ_GET_FIRMWARE; - gb_bootrom_set_timeout(bootrom, next_request, NEXT_REQ_TIMEOUT_MS); =20 return ret; --=20 2.43.0