From nobody Mon Sep 28 13:16:46 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C96745BD7F for ; Fri, 21 Aug 2026 10:25:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787307918; cv=none; b=bD8TqROhH5W0A33W/EX+0IC2cGD5u2cA1ezmIbN07Js021PFmcYfhBzb8PvEmGVvy/o5gyTIoud0sXKCvFd1m/DYwFDnXy7HK9JTRJQhFl5N2b/pImqteJrvbcllr6+tlTNE5p2lgzditkyWSsT0FYBjKYcpLZ6DhLEgbRWr6TM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787307918; c=relaxed/simple; bh=9gxlDRHqhuwt8FJ/CwukjTyzdPv7n6MCBFsd7dAHKR8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LY/MfyulT5oXXCuXjHzuiJu/mUkRc7w2h1XR8IogOT/xFk4mHqa6ky3SdkASCXytvjk1n4SG6WruY1SoPcUNdckIBodCRtFVIB61g1jc77V7eGky8dIWJLfSZtd3S16dGqxX89tQhRCzSEyWHRh3jCjSEsD32ePPb3eBeaUJYC0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HVbJYFFs; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HVbJYFFs" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-499840a2575so4592495e9.3 for ; Fri, 21 Aug 2026 03:25:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787307906; x=1787912706; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Ht5SF4+wx6Jf8JH+OLs35dYBN3IVS35rx1u5RktbmkM=; b=HVbJYFFsfHHdhr9I+hzI1eFyz3vSZWsjDeitoM/gZlePB9MjYHNieWY1PLlH4gMetJ pv90BUseyhihDJQpI2gtXDiO0tJnOUp8RrzjjpnsuO8vILUzWirjEZHpdtIYgNzG/FcC SRErJE9bsYyJe2C7U2o0DKDg2GJpaL4HJ8sFpSDbKy/kG6TWmz8EmUfUcCgbYaJAq+P/ 06YEKKTTwkEL0Ip1Z0HcVrJh1Kc0gjg6YxM2OpVtQp1ZI7hEGG+IPSRfOOW/v8PQcRN/ c5KSH2CZ12Z6b9MXlJgWBYOmkGvbxxSGpbLCLmEoPmOslqsYNWYZPSHWBb/OQWe0pDf0 wIng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787307906; x=1787912706; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Ht5SF4+wx6Jf8JH+OLs35dYBN3IVS35rx1u5RktbmkM=; b=mdysRL0ozrb/km/Ap0A84VGSxYbj15cVaE9GJ4c8UeTW03YI2K2To0dv1XU+QSWcIp BkGLspbDg5YCxMAmbT7Gd6r9KUlZaY0wpEOehbzdbWj9+2NWfHxLTR/xHe/lwnniWjar WKDGColo/0YXHonL1Hovyg4M30nIgqDDz/hbk0wXyrvGbgU+sS25MeH0++m0INirbtTQ BIXVvFZrLsu/FoJ3i6Wp622IFd6bb52krTT7O9D5kU1yQ0S0HkEdr+rS9tmCKJXFo6vP +5z4CpS2r0KGSZL8TDq4C/UpUoJl/ozHsA2JMqnQ6EPYjbrcZCeo9kK3Ms6wK+kewvNg GpMg== X-Forwarded-Encrypted: i=1; AHgh+Rqtzz/pSbDyIItsaJ9em0qQle9klxxPLfWpu5ezRqLNQg9O0h7mihaDGoPtTrvTV2dQ14XOOw2IBi9UFkM=@vger.kernel.org X-Gm-Message-State: AOJu0YwihCQQfEPD+1jhHR+baIP0zAzHSelffxuE3UUOCLfaEYmTxLeq 1ZxYU5ou4x8SoRJabpuOopYfxzsFXlg74g83GZNpXugKXQo/oAdX1IUF X-Gm-Gg: AR+sD11nJjFc7RdHB/A318NTamSG0zsN1KOnf7u3txGh7V1L7v6HAkyuhFkgjkX4v0W +ThRAXblxoZjMU5pqPpQk/G4lIHWSvh2o9xAZLVDlSylre1qH3LlBw3FH4+7RQD5DSlQjjAY250 zv4utghJe/G9zn6t1Qz5KfBUQ7xmdfreACYvCKFyAwM7ag+kICbGcDTWZzUK0r6cTYdCWOhXjUb tjhJlIWbSB//GshEIMvoKXo61P3gaPRAqErOZHSdSAy4Rzw9Wqpsj/sH/ekMnIoGuh4Bl35ihzb 4mfOpmuFVe1OgHnxfMHRXqoL7xwW1BDEAEBq/5vQQEwqFgQ9CxplWr1g6Q+MlZI2Uztl+H1SdV7 W9Zdx7fjmUQNjbAtbsqsa127ep6lVNJJW2txL9gIWS6dqpTykc46Ikj2PYKFSn9IcGA1zFHOs5B c8AK7dDFp/vZaIcX56Ljfb/tgAcSKwJE0hXJ2jbaQbX+DMOXfVS1zMhuiwzZYrhPdEFfmyL5w6d +Fw+5sEubwY5A== X-Received: by 2002:a05:600c:8b76:b0:499:8c68:a3aa with SMTP id 5b1f17b1804b1-499b8475133mr82881315e9.13.1787307906435; Fri, 21 Aug 2026 03:25:06 -0700 (PDT) Received: from fedora ([105.74.130.192]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499b9ba5139sm11663155e9.2.2026.08.21.03.25.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 03:25:06 -0700 (PDT) From: Taha Ed-Dafili <0rayn.dev@gmail.com> To: jic23@kernel.org, lars@metafoo.de Cc: Michael.Hennerich@analog.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, skhan@linuxfoundation.org, linux@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Taha Ed-Dafili <0rayn.dev@gmail.com>, Conor Dooley Subject: [PATCH v5 1/6] dt-bindings: iio: dac: ad5504: add output-range and missing gpios Date: Fri, 21 Aug 2026 06:24:43 -0400 Message-ID: <20260821102452.37407-2-0rayn.dev@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260821102452.37407-1-0rayn.dev@gmail.com> References: <20260821102452.37407-1-0rayn.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The AD5504 output range (0-30V or 0-60V) is determined by the R_SEL pin. Use standard output-range-microvolt and range-sel-gpios properties to describe the hardware configuration of the R_SEL pin. Ensure mutual exclusivity using the not/required logic. Additionally, add missing vlogic-supply, clr-gpios, ldac-gpios and datasheet links, and provide a complete usage example. Signed-off-by: Taha Ed-Dafili <0rayn.dev@gmail.com> Acked-by: Conor Dooley --- .../bindings/iio/dac/adi,ad5504.yaml | 39 ++++++++++++++++++- 1 file changed, 38 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5504.yaml b/Do= cumentation/devicetree/bindings/iio/dac/adi,ad5504.yaml index 9c2c038683b4..e0123dceaa33 100644 --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5504.yaml +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5504.yaml @@ -10,8 +10,10 @@ maintainers: - Lars-Peter Clausen - Jonathan Cameron =20 -description: +description: | High voltage (up to 60V) DACs with temperature sensor alarm function + https://www.analog.com/media/en/technical-documentation/data-sheets/ad55= 04.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/ad55= 01.pdf =20 properties: compatible: @@ -27,6 +29,29 @@ properties: maxItems: 1 =20 vcc-supply: true + vlogic-supply: true + + output-range-microvolt: + description: | + Specify the channel output full scale range. The R_SEL pin + determines if the range is 0-30V or 0-60V. + items: + - const: 0 + - enum: [30000000, 60000000] + default: [0, 60000000] + + range-sel-gpios: + description: + GPIO connected to the R_SEL pin to select the output voltage range. + maxItems: 1 + + clr-gpios: + description: GPIO that controls the /CLR pin (active low). + maxItems: 1 + + ldac-gpios: + description: GPIO that controls the /LDAC pin (active low). + maxItems: 1 =20 additionalProperties: false =20 @@ -34,9 +59,17 @@ required: - compatible - reg =20 +allOf: + - not: + required: + - range-sel-gpios + - output-range-microvolt + examples: - | #include + #include + spi { #address-cells =3D <1>; #size-cells =3D <0>; @@ -45,6 +78,10 @@ examples: compatible =3D "adi,ad5504"; vcc-supply =3D <&dac_vcc>; interrupts =3D <55 IRQ_TYPE_EDGE_FALLING>; + + output-range-microvolt =3D <0 60000000>; + clr-gpios =3D <&gpio 4 GPIO_ACTIVE_LOW>; + ldac-gpios =3D <&gpio 5 GPIO_ACTIVE_LOW>; }; }; ... --=20 2.55.0 From nobody Mon Sep 28 13:16:46 2026 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1486C35F60E for ; Fri, 21 Aug 2026 10:25:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787307925; cv=none; b=VByc5e8DPtuiLMhmOavZmuLqYZLEhzBHRK368uCY82Fs4oIicKI+EUsp8kU7otxdR6ShjQIwomobJULKjkKxtcSkKkWZavryHW+xXav9kILkgL0b3R7LFkQLsG9uLJ3Z7d7AnG/Rp4T20Xipf8JFgtF8F5ppawEijCI5x2F8qaQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787307925; c=relaxed/simple; bh=FQ4fyjXp2OqEnkYHwsfz+TTm/oRpClpjq1D/SX+fetU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KHfuRFvwwdLWQUk9oev6TX0Ly7g5Kzy1Zz0RMjngyYAnjGdkBaV0E3L6oODCSQkLJJMbIWi4pEsbLo6taDcr9JXMUN1v1l37LpShCnfc3GjzVJG7oxokYpfkJzM9+vDiZkbB1e5XmAxWv+AeAc0hdt5yqGrHCbjM/Va4jqKtYEc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=APlPsiNj; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="APlPsiNj" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4954f5e8020so3439375e9.2 for ; Fri, 21 Aug 2026 03:25:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787307909; x=1787912709; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cXCIKeHXfMN8TRcCWZhE+maVe8/ByjaTIx/Ywm2GTsw=; b=APlPsiNjTWO8PlFp79CkwZjpgFsRF4fCQEGz3+9PxrvmgtTj0nfUToDDz8m4geRAWE EjnA/9Y6XoM9R/Nyj5KMCzmoVSRM/NwyAJFz8HkH0WPGuIiclCs5v76QmxymJm6ueS8Y jwiKpxQcaxXHbc0JplcwEj0xtFOybYFJwwvj4YYjOpBns/O4P/h3pUmHzy/ZKbm0G5jP vJGnVqAT8VmKAP6NzDqyFKASg+ndzhWkyj4qhiqJ23cyYGdqyPBRJB4aN18RL/1SxOvc mWfOclH05CJNzhBycfqw2MzMwixoyStvMDuJMJXgOqg6ziz8QRz/xOm1u6Q3CReE1Mgy oQgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787307909; x=1787912709; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=cXCIKeHXfMN8TRcCWZhE+maVe8/ByjaTIx/Ywm2GTsw=; b=seW85zSoEVUCPsmjlhDVRl4gJ5oCa+GaXwozzAGNdYVuPLW9oNVITZud19cfD0ynh3 6+Nv7CNS2c5kHITXP0LQ/Md5Tw/tdtuOfh+3uX293izDcR9u2n8a1VY6DfCmWaZqN5IT mhDX617n3RlYf7u8OTi+eU+Rh5x3VunNZ9BPlNTFTUGP2ygEF5B7RVlci2hfMgI/EEyw HvLvyOk+pPQWAZSE4+j7dkF916hUBGii0AzSzmgfbXrP2oCoAgyrxXEv39ZpKoPpCO6d sQh1j8F435Q42pRDK3snBwuGkKS62yweA6ttFfDj24366cyy49m4tDypfGTKt7HRyMq2 nJvQ== X-Forwarded-Encrypted: i=1; AHgh+Rpqe5NQ9QwO7rON8ttFiToqBJq2rFrxjGvIKt2gKm6o79fWv0sahVaOVqkXWT/q8/AxKECc3GLr1s42iQY=@vger.kernel.org X-Gm-Message-State: AOJu0YwKBN/RCNalBFDuYBpwdRQU/4BZ6Gk5G5utxiaa9Sq6gOIn+yYO DUVPOReLBeVp9e9kuEjpMXy8nrYv18emmQHaGwfI/f52B6JZg/l/3Z+N X-Gm-Gg: AR+sD13dWLWRRh6YmrH0nG8N1d2mMHSLCYmbyljkrr/e5a5+ARRnJNXCM6UTjWM9bXO Sjc+4r36TQz+OSHeDVkMmpsGUKKgoBhXprqvvHjPs0znzqaaOPVvIcxsRxfhgDCdO9VTgQT64Xf EiYXbYa45AsiAshpRzdwlbuZtnGzMH+twB3Qjxef713K9AKDO0BLfBOHIMg4RFupHmYS23vIXSU JBNMylPpn3yoy1/mJPuKuPPoLBQORATmvI94Vv+weg89qR6owMWpOGl8eZhMNxcsNvNZSCI+JcN 3lxdmJXoDUHkUBwKqCe7DNRMvSkhAOXv0cGiOyRhR0lDEgmczLtgi2gwIfI0CTKLZFf4NxVQJD3 bb/sGDnziwaAwcmGxMD0HHNAQnC23EPu9pSuSpxCzhnOZ46MyFsKFJe72up8GI1b5TkQusVBJuZ hM2a+cLv3EaN8WbBLOHn7EkQPC0XfhxERE3kXop18IuLHWqVE54+EctdtEKdjwYOvPi6TeJ37ZH +pSP75spAt4bw== X-Received: by 2002:a05:600c:37c6:b0:499:858f:2653 with SMTP id 5b1f17b1804b1-499b830d08emr83406875e9.2.1787307908744; Fri, 21 Aug 2026 03:25:08 -0700 (PDT) Received: from fedora ([105.74.130.192]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499b9ba5139sm11663155e9.2.2026.08.21.03.25.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 03:25:08 -0700 (PDT) From: Taha Ed-Dafili <0rayn.dev@gmail.com> To: jic23@kernel.org, lars@metafoo.de Cc: Michael.Hennerich@analog.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, skhan@linuxfoundation.org, linux@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Taha Ed-Dafili <0rayn.dev@gmail.com> Subject: [PATCH v5 2/6] iio: dac: ad5504: Align headers with IWYU principle Date: Fri, 21 Aug 2026 06:24:44 -0400 Message-ID: <20260821102452.37407-3-0rayn.dev@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260821102452.37407-1-0rayn.dev@gmail.com> References: <20260821102452.37407-1-0rayn.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Update the header inclusions to follow the IWYU principle and ensure they are sorted alphabetically: - Remove , , and as they are unused. The driver relies on devm_ managed allocations, so slab is not required. - Replace with as only the BIT() and GENMASK() macros are used. - Add and for error codes and data types. - Add for cpu_to_be16(). - Add for ARRAY_SIZE(). - Add for string to integer conversions. - Replaced with Signed-off-by: Taha Ed-Dafili <0rayn.dev@gmail.com> --- drivers/iio/dac/ad5504.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c index ad1a74678cf2..5c9c66b04154 100644 --- a/drivers/iio/dac/ad5504.c +++ b/drivers/iio/dac/ad5504.c @@ -5,22 +5,25 @@ * Copyright 2011 Analog Devices Inc. */ =20 -#include -#include -#include +#include +#include +#include +#include #include -#include +#include #include #include -#include #include #include +#include =20 #include #include #include #include =20 +#include + #define AD5504_RES_MASK GENMASK(11, 0) #define AD5504_CMD_READ BIT(15) #define AD5504_CMD_WRITE 0 --=20 2.55.0 From nobody Mon Sep 28 13:16:46 2026 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AECC4746B1 for ; Fri, 21 Aug 2026 10:25:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787307919; cv=none; b=WPF4iwHaN7AYY9YzGQ1gujVBuWlFuCVkkST4Qs8jHE/tqJSl9kFRHDkleW+dlvSCWRq7C9ncmggp/d4VhCdyYwQv2Gg1NnLFxnkrRSvJo71K6rWonH8t1F4pGiIJhiM2rSxf4S4tAQnr++9JFoPSDfiBgJpnHi3TcE5tGDPdEXs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787307919; c=relaxed/simple; bh=qh4p6NiaYYKZWRo5SdC+29bJh1njzkmd5IdAQaiKg10=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Czd4EiMCIKe1qOrU72CfskI8oLaLzaTtpoury5Vg/o3Es7kbbpMk1Bh/T/JFX9LQOzgutIAW4oOtIl7hvM4NJvdQTQbPkaLTATwBvj9bIUmwAFulNLYxMRZ1z3yVVPaqXr1ie/lc9GzQXBGknBFG77W/S2puQHa4FvZWHVuBdrw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QwmKueW8; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QwmKueW8" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4980dc26022so5985685e9.1 for ; Fri, 21 Aug 2026 03:25:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787307911; x=1787912711; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XsQREIODkCao/QDK0V814PCMzSICvR9cgatjnm3y9Ns=; b=QwmKueW8i3NewAouoHlS1hrLhhNRGwI78Scj5VmDnm1ASoYnMgXDG15HIN2cOIVxCz mi59CO1xr9c6JtjXPgftU/f9kbaP8zNNjsp/oIJ+5X5vxniZDKFyNDITl2JivjhUS9wV D76OrnMiEOnF8HZP1aI4TiEGSC7Ihapj8JofYEe55D7B2quA0wtAu+ZwlwOAg54ArZqt HtDVUJQ8qN7VQIS7AWzxDHt6u0jEBeg/+7IJIgjH55xJeIctl2ugmCtNH1LBydEtkj8e 80nthjybcL50DdYNH5SdX9uy5zy1xjdW+rXH/cjaX3jxjJnahXMWRVG4L3hVmhNZ7RpW vFpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787307911; x=1787912711; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=XsQREIODkCao/QDK0V814PCMzSICvR9cgatjnm3y9Ns=; b=gqzf834vUiQwzEitd4YhsGZemDd+xcatNDRpjFW0crhLKdGdvTMedb2zm2HrczcGOK niJeQ62wyMCWQ6mmf7lJtyeoAV/nsEuxxsciAqlBoZaY38/LTF2ub6fmwVe9Q4ZXfzVy idBY1EnkMwvqBfypay2YYQclIpHl3j2QBCYQfpXB1x338Z2iWZr03povfTQudl0JBd9w 5Z1SMTwJzkAURYycbR3ZvT9EkQVeCTB4p8bXUGKax3wSULoK9uy0y/oGtPYu1QbO9DlJ 8Dn27m+zP5TMGlaHhywtJb462ygjAMT51ZUlUt5qeO1DB0pK9S1k25nYroZRbp3qZf7P aOlA== X-Forwarded-Encrypted: i=1; AHgh+RoculfQ+CpTZ0aI/Qu5n4DXvlPANc+RchleTRlKeQ5soNQZ8t2ctOrMOPOPP58z5/yBRSRWHnGg4ZVMcI4=@vger.kernel.org X-Gm-Message-State: AOJu0YxjIAtu0zJvWLu4FPVB7OYq0WWYddkBizY4qEP/q4FSrBkf1Cdb I3tPIMctbZZvKjGTwqMqiairf+ArrHxIdV2IPKrFEiWmQrV6GgCv0j6R X-Gm-Gg: AR+sD10CYC0nhOUoFy0F6YhIzXYqLf6dkZo+n9ZXCX414hc2f6E3GU1pC3yRnqZyCpo 9vhMdWQiJ2YnZZ55/sFkVzHa8x8Ks86ko5NeLJxt86B/86yqe/Ovi9p5I0iIKBsv7Tb1EG2KPZl nDJZL4Kp1ibhK75pacQfjW8bBX3i4Ypr2H7L5fhbsW/g40cURNV4Dn7zUkEZOQ8LvnYMgezD5j+ gYuc1tEv7LKe0PIMBzpya/+kpWdUtMBKf1aYhCbHjG/3KKAZaMvU3+aAwDjosM/15JFKyNYcuwa FKvdNgqPoPxmlj7fosFNaeQt3JPMV3+RivEukyRF72bpcF8jdpNyNtmWBxNfi0sbb7q2enKC12v 5p1xhyH/zQlnd27PPu6Fgzt5CqJ+A8IsLnIpQOO5t8q35TC59Z4/EeYhgjHy5ggKskaOZoo25iS DBYe1K0B/z7j2NqZcJNJowNQxBZd/e+Dx4i6bvTnxACSeOPkqzUe9OHVu2+h/MxhpHZp995Nr8T MeO3X9R02iTjw== X-Received: by 2002:a05:600c:3550:b0:499:8777:ccba with SMTP id 5b1f17b1804b1-499b830156bmr76380145e9.12.1787307911253; Fri, 21 Aug 2026 03:25:11 -0700 (PDT) Received: from fedora ([105.74.130.192]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499b9ba5139sm11663155e9.2.2026.08.21.03.25.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 03:25:11 -0700 (PDT) From: Taha Ed-Dafili <0rayn.dev@gmail.com> To: jic23@kernel.org, lars@metafoo.de Cc: Michael.Hennerich@analog.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, skhan@linuxfoundation.org, linux@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Taha Ed-Dafili <0rayn.dev@gmail.com> Subject: [PATCH v5 3/6] iio: dac: ad5504: separate ACPI and DT paths Date: Fri, 21 Aug 2026 06:24:45 -0400 Message-ID: <20260821102452.37407-4-0rayn.dev@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260821102452.37407-1-0rayn.dev@gmail.com> References: <20260821102452.37407-1-0rayn.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver relied on a fragile -ENODEV check from the regulator framework to bypass voltage configuration on ACPI platforms, sharing the same fallback path as legacy pdata. Fork probe on is_acpi_device_node() to explicitly handle each path. On ACPI, skip the regulator and use a fixed 60V default via AD5504_VREF_ACPI_DEFAULT_mV. The pdata fallback remains for non-ACPI systems in this commit; it is removed in the next. Signed-off-by: Taha Ed-Dafili <0rayn.dev@gmail.com> --- drivers/iio/dac/ad5504.c | 29 ++++++++++++++++++++--------- 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c index 5c9c66b04154..6f70c57c7a82 100644 --- a/drivers/iio/dac/ad5504.c +++ b/drivers/iio/dac/ad5504.c @@ -5,6 +5,7 @@ * Copyright 2011 Analog Devices Inc. */ =20 +#include #include #include #include @@ -12,10 +13,12 @@ #include #include #include +#include #include #include #include #include +#include =20 #include #include @@ -24,6 +27,10 @@ =20 #include =20 +/* + * In case of ACPI, we use the 60 V as default voltage reference. + */ +#define AD5504_VREF_ACPI_DEFAULT_mV (60 * MILLI) #define AD5504_RES_MASK GENMASK(11, 0) #define AD5504_CMD_READ BIT(15) #define AD5504_CMD_WRITE 0 @@ -285,16 +292,20 @@ static int ad5504_probe(struct spi_device *spi) =20 st =3D iio_priv(indio_dev); =20 - ret =3D devm_regulator_get_enable_read_voltage(dev, "vcc"); - if (ret < 0 && ret !=3D -ENODEV) - return ret; - if (ret =3D=3D -ENODEV) { - if (pdata->vref_mv) - st->vref_mv =3D pdata->vref_mv; - else - dev_warn(dev, "reference voltage unspecified\n"); + if (is_acpi_device_node(dev_fwnode(dev))) { + st->vref_mv =3D AD5504_VREF_ACPI_DEFAULT_mV; } else { - st->vref_mv =3D ret / 1000; + ret =3D devm_regulator_get_enable_read_voltage(dev, "vcc"); + if (ret < 0 && ret !=3D -ENODEV) + return ret; + if (ret =3D=3D -ENODEV) { + if (pdata->vref_mv) + st->vref_mv =3D pdata->vref_mv; + else + dev_warn(dev, "reference voltage unspecified\n"); + } else { + st->vref_mv =3D ret / 1000; + } } =20 st->spi =3D spi; --=20 2.55.0 From nobody Mon Sep 28 13:16:46 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAC6C476CE5 for ; Fri, 21 Aug 2026 10:25:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787307933; cv=none; b=KWuQw97k8qL5mPPBXHRuldDa5N+UDufqKfSubD+T/OJje+SHRGvDj5qPuufA0AVSql/5DxuSlyVh4na42lIav6xkQDk+28xYHnb5g60A+zvTLErsHlUzieSZ4wUercsbR3VdvQWdufsKPTxofOh1CJdSRYPTBVbuoGyZP55Gac8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787307933; c=relaxed/simple; bh=HCZVOF8T9m7E1Gm3Iq+tZImcQ0gw7AQRtwevkDBWDd0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KP852hf2oEwJt+1NGI2GqoFxEOoSdqDhid9o99uWG9go1drfRyb76Vm21EHLYrP2YcFQ9bUgP21jHTeXPv8fWgbC3D0JzCgLLIpUqIPbsEwAHJABACYud9S7U3BSSh63oHqt1yzLX2Gjse+Y6d5oMfm3bN/tEU0PqHfTp08sjY8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UtHLc+OU; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UtHLc+OU" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4956242332dso7056085e9.2 for ; Fri, 21 Aug 2026 03:25:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787307914; x=1787912714; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0dWiifvCNQ6/1XjQKOnLCIy+9xjui2vS7wMw6DuKzck=; b=UtHLc+OUTF+fZmq9XpVSv2JuxfjYbpBPEgeWJhlyrnxWStFtw0RR+ZCpA+GwngTb5j lT/ulqbApiN2yudQX2EsW/5g9yOW6QK1VhorQJi4j3aYd44AiFQfdYv46GIE4YK7aFgT iuWEv6j300X2pEaW7K58Mou/xuNd+iakhuya3tEHGSrbRonvKwnytpQxfMyk5hnB2Zyp RQIunIkVYcUHB98LO5f3nJq6GRPeFeL7wJf9mn5cOmJFNboiGO/mkMN+e+30isV3dvzS ryrL55bHwmG9eGswDMvXFVSMwR77pUtVSeycpKuPyQAPYv8FPvKdcEhYQpEPJJgW77xc etTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787307914; x=1787912714; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=0dWiifvCNQ6/1XjQKOnLCIy+9xjui2vS7wMw6DuKzck=; b=YkScPMtF5h9plDml09+IUUAHAFCFNpzWZsj5Bod6KVHkjtsfrcGLqk5ktM9NbnADP1 +m1wW6m5R/k1iDpC+lGMRqZlzpvNg2YyZhLnH1cOE/R36Iqp9NBA8m4J5Ajg7+USQN21 /2tywujhKVN8O0AHduI4qKeWIFolo8FcoOjh2F3Pns8WbgZhxixbRbTJvlnTeZkWLViZ nsqmG7iMegH8vZZJb8/ExKRV34Bx6O5fwqXYJZTwlJuKtHbuejmj1pX4giFqREP27vi0 sImTsqNdPFPs2mDXovozwnaJ/oMHhqrc6FVYGMCdzI/qBKnqyaOw75YuxQyz1hws6dsn ay3w== X-Forwarded-Encrypted: i=1; AHgh+RrbRFQc+h8E1gIqjF7HBTZZpnLJ1ctl1XpzvUs4RB9HZIxuNTeB5OEVr0BSjcGvHXHd/wlW6D77QbiVYOU=@vger.kernel.org X-Gm-Message-State: AOJu0YwBZttXoRn1+FQnKs1rEvS6JlaJAzHVr/5AezsJ+UnWhxxDypei fOsZi28+87UcMJ4xB+UxmKE497l5UYT1HP5TYn4LVPpry06sIrOoKKET X-Gm-Gg: AR+sD13LHyNHNR57TDAkgS6NIP7HzzEmFtYZQAVvUAsiY4oMiZQYd4EZRtba8frWaAF P46p09RF0sesn2qwJF1+1PxiCXbAdVy2+RljBPULXRAmn9tHatGYyRKRIFhCowHaDKDGQPL1vBg JtMZJzX8YiXvpPtqvkDJUTrRXQr8AkGYz6HgyJk1Ro/cyrKTDrpc/SMFfxTnmIV5gJa9qegS/KT vbDusqI6g/B4Ua/y1u+53t7v6tFP71ymsWh42z7Ohaj6isgMfQixlI2WhK9PGioYYDX/qOoIiXS dp4mepOwncM/4BE3rY/3ixX8bohPX6YizV3+0SX0AUeR2y0oE+w8BEy0/dmmieORG/RjAZ5g9o4 ixq1pjYVr6vKghvB4xssFCrGzNXfsQu7dddS5B9rLYZJ8zJdIx7otLQEuaKk58m46EW5Opqwu6a byqhyjze4SJ9mzW0dALSTR76wm55tEuf1sSSjCSihHQ4bnr35Mr+0zAh8Nzkkd4GH+4dKjr7qx0 aBjMf78pqY0mg== X-Received: by 2002:a05:600c:3b08:b0:499:b402:6c0 with SMTP id 5b1f17b1804b1-499b830d671mr64331415e9.3.1787307913677; Fri, 21 Aug 2026 03:25:13 -0700 (PDT) Received: from fedora ([105.74.130.192]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499b9ba5139sm11663155e9.2.2026.08.21.03.25.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 03:25:13 -0700 (PDT) From: Taha Ed-Dafili <0rayn.dev@gmail.com> To: jic23@kernel.org, lars@metafoo.de Cc: Michael.Hennerich@analog.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, skhan@linuxfoundation.org, linux@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Taha Ed-Dafili <0rayn.dev@gmail.com> Subject: [PATCH v5 4/6] iio: dac: ad5504: remove legacy platform data support Date: Fri, 21 Aug 2026 06:24:46 -0400 Message-ID: <20260821102452.37407-5-0rayn.dev@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260821102452.37407-1-0rayn.dev@gmail.com> References: <20260821102452.37407-1-0rayn.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The AD5504 driver has no in-tree users of its legacy platform data support. Now that ACPI has its own explicit path, non-ACPI systems can safely treat the vcc regulator as mandatory. Drop the ad5504_platform_data structure, remove the fallback logic from probe, and delete include/linux/iio/dac/ad5504.h. Signed-off-by: Taha Ed-Dafili <0rayn.dev@gmail.com> --- drivers/iio/dac/ad5504.c | 17 +++++------------ include/linux/iio/dac/ad5504.h | 15 --------------- 2 files changed, 5 insertions(+), 27 deletions(-) delete mode 100644 include/linux/iio/dac/ad5504.h diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c index 6f70c57c7a82..799726eafdf2 100644 --- a/drivers/iio/dac/ad5504.c +++ b/drivers/iio/dac/ad5504.c @@ -20,7 +20,6 @@ #include #include =20 -#include #include #include #include @@ -281,7 +280,6 @@ static const struct iio_chan_spec ad5504_channels[] =3D= { static int ad5504_probe(struct spi_device *spi) { struct device *dev =3D &spi->dev; - const struct ad5504_platform_data *pdata =3D dev_get_platdata(dev); struct iio_dev *indio_dev; struct ad5504_state *st; int ret; @@ -296,16 +294,11 @@ static int ad5504_probe(struct spi_device *spi) st->vref_mv =3D AD5504_VREF_ACPI_DEFAULT_mV; } else { ret =3D devm_regulator_get_enable_read_voltage(dev, "vcc"); - if (ret < 0 && ret !=3D -ENODEV) - return ret; - if (ret =3D=3D -ENODEV) { - if (pdata->vref_mv) - st->vref_mv =3D pdata->vref_mv; - else - dev_warn(dev, "reference voltage unspecified\n"); - } else { - st->vref_mv =3D ret / 1000; - } + if (ret < 0) + return dev_err_probe(dev, ret, + "Failed to get vcc regulator\n"); + + st->vref_mv =3D ret / 1000; } =20 st->spi =3D spi; diff --git a/include/linux/iio/dac/ad5504.h b/include/linux/iio/dac/ad5504.h deleted file mode 100644 index 9f23c90486ee..000000000000 --- a/include/linux/iio/dac/ad5504.h +++ /dev/null @@ -1,15 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -/* - * AD5504 SPI DAC driver - * - * Copyright 2011 Analog Devices Inc. - */ - -#ifndef SPI_AD5504_H_ -#define SPI_AD5504_H_ - -struct ad5504_platform_data { - u16 vref_mv; -}; - -#endif /* SPI_AD5504_H_ */ --=20 2.55.0 From nobody Mon Sep 28 13:16:46 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C60AA3B4E9D for ; Fri, 21 Aug 2026 10:25:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787307925; cv=none; b=Suz/z3qll8AsIR9x9zP7yVH5YyC6+DY4Y5FewzjBhhkMESkpTRhBZwiyu6yckHCH2FCqHrNnPwV0g95F2QGSrnPyxVAC+AyjI/7o1Gm9xdc8OiepBfNz7E8I55+XZf7bB88zS11izZ3V89G/3F0PYbu6+A/EiK4F0hLShjkLJao= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787307925; c=relaxed/simple; bh=xBnxiN14VeU0fDSul+psuINaNYuBf1EnMjbrI5YxO5k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kFmQX6oCw7FPTdZ9A2Dgjb10cqFldMD5Rwh4Uy4OkNpi/yMobhnDhOf2fZGzF+x0rHua6BU5dPpiuhtD1jOPzOfUWBBLRyXhfEDQVZ92LLdT02bKf2rIl00+LhSheBj8lmOBlFcvc1VM9ujqBOQuuqkHnhcokEgc2Fg7bYa4Fi4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F7wRqWO8; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F7wRqWO8" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-493b966dd74so3549735e9.3 for ; Fri, 21 Aug 2026 03:25:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787307916; x=1787912716; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nLLSpwKmauDrKByG1roh80ilhu5DeGRufmbN2+oazIA=; b=F7wRqWO8w1p5Zx4yGLE0qHkX+bgGQPoq4RFioEwZqsgkRRYjRheNvqET1f0tkxldx9 mDHjW6PSM++c/oA57rWcsMxkifVPiLgY2JcCO3KpSht950uZYMNqUUNSSJwYxtlnmLcI iDyAFxixG79Foost+SLFhXRY7R4X6TCcqT2IOx2bXp2OWDwgtI1fuN24SmeTxOeROHk3 gZ82CLFhjTJl6d9aunCAJmlBFi2gjbevBLIGYkcs6ejXVyEKRdbCBJAxD0dtPqXa4aLL 04PnYRjgHCwEiKLVVo15/MiIszU/O4kASp++ZqZvmEtJIFFXzrfMNE4AZSTJoc054T/b iwiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787307916; x=1787912716; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=nLLSpwKmauDrKByG1roh80ilhu5DeGRufmbN2+oazIA=; b=oJ9YZ1xwG60SglAJIUJRuxqYP5pzHn8rXDMsNZTI2GpHvdoaF2WpPtbuuuLKBY7bx0 Z/2dAulsrfSuAgln+5OYBi86SMc95PKAMfd2RjsoofmvyMa12wuR9Dip+1nY9cGaigmj Gf7MQh71JXMChIFr+MKQDwFwmF5jE00rW1wIG9hYyqiMd2XREleQd1GxSD+ruvWkNg9a +hjkDn7vAbmHhtPhVTrTXZcXjGaj07UJXRfhQCRVMrnDaUjWpJ6pSVDrb31klSGpm2EX xorBCOIoVzzwUlQS4JoCEKKbHa7SWIgs0hdZL8yCNnuFuJ+3et4egsqXcDeVmLfk5xqV StRA== X-Forwarded-Encrypted: i=1; AHgh+RpXtjmmryiB5XJWDCUuDws5kzdamZH1PAuiUfMH82dmS03lo3eBItPZBLetoi53WBCeq1ZQFLvOtmvWOas=@vger.kernel.org X-Gm-Message-State: AOJu0YxzBCLpQQm7Bc0HBZw53njlrzMdVzD0OziUdIpWqlKIuv93DqSO Y6w9lzohZiccQ89T3033v1dMoP0CGwxLr4ESunQ+LZe5S6BswkXGWdHB X-Gm-Gg: AR+sD10PjpXiNlsaYXDLOaZpmleO+cagHnKSCIUNgXDurHO/pAqBklFa9SN5o6CTCtj uRHPcSPN6I40lCRrNlQlcIDwXIXMAcST9AcxSdMnbOmjEaECgyOP808Evqb6TBFQUQyleTOhnO1 OxTUksZFAyK9hPKW+BJZZc0atMePxx+NjnlBDz32n3taiTxidcADPemP+SJVdjLxGfEnUixEit2 63ylqNX/cSLcVry3QDBMD5rVDfWyWhAB1usxMwg5psunCMXe265QYuCX5urI6fRHhGa82/w65kZ GzB/elZjYrEmLlmWbRd6YHFp/3a3C7dD6uNcTmBwWRCSmHfznKIt4wvzr3+CsTdA4v37RsN9a6v pcD4EVgzn+iCqA6SmQzhEBCZXw4Ojq8ctLevh1yPcUF32ttytTQaVynVSzv4R8uqFLt81ylin7r 8TEUKwYH1yyiTFC3IcT/e2ohFdGqUSmLEuF3EaN6ocdKZgw1sGcIK59R1U2Zn2Py+SDq3PWIvy4 6+/zpOrDpogap8= X-Received: by 2002:a05:600c:540e:b0:499:7ce1:d8a2 with SMTP id 5b1f17b1804b1-499b82b57afmr82696755e9.8.1787307916027; Fri, 21 Aug 2026 03:25:16 -0700 (PDT) Received: from fedora ([105.74.130.192]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499b9ba5139sm11663155e9.2.2026.08.21.03.25.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 03:25:15 -0700 (PDT) From: Taha Ed-Dafili <0rayn.dev@gmail.com> To: jic23@kernel.org, lars@metafoo.de Cc: Michael.Hennerich@analog.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, skhan@linuxfoundation.org, linux@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Taha Ed-Dafili <0rayn.dev@gmail.com> Subject: [PATCH v5 5/6] iio: dac: ad5504: introduce local lock to protect state and spi transfers Date: Fri, 21 Aug 2026 06:24:47 -0400 Message-ID: <20260821102452.37407-6-0rayn.dev@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260821102452.37407-1-0rayn.dev@gmail.com> References: <20260821102452.37407-1-0rayn.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver lacks locking, exposing concurrent access to the shared DMA SPI buffers, the non-atomic CTRL+NOOP write sequence in powerdown, and the pwr_down_mask/pwr_down_mode state variables. Introduce a mutex via devm_mutex_init() and guard(mutex) at the IIO callbacks to serialize access. In read_raw() and write_raw(), scope the lock to IIO_CHAN_INFO_RAW only since IIO_CHAN_INFO_SCALE reads vref_mv which is immutable after probe. Signed-off-by: Taha Ed-Dafili <0rayn.dev@gmail.com> --- drivers/iio/dac/ad5504.c | 26 ++++++++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c index 799726eafdf2..489d2e03e9f6 100644 --- a/drivers/iio/dac/ad5504.c +++ b/drivers/iio/dac/ad5504.c @@ -8,11 +8,13 @@ #include #include #include +#include #include #include #include #include #include +#include #include #include #include @@ -55,10 +57,12 @@ * @pwr_down_mask: power down mask * @pwr_down_mode: current power down mode * @data: transfer buffer + * @lock: lock to protect state and spi transfers */ struct ad5504_state { struct spi_device *spi; struct regulator *reg; + struct mutex lock; unsigned short vref_mv; unsigned pwr_down_mask; unsigned pwr_down_mode; @@ -109,7 +113,9 @@ static int ad5504_read_raw(struct iio_dev *indio_dev, int ret; =20 switch (m) { - case IIO_CHAN_INFO_RAW: + case IIO_CHAN_INFO_RAW: { + guard(mutex)(&st->lock); + ret =3D ad5504_spi_read(st, chan->address); if (ret < 0) return ret; @@ -117,6 +123,7 @@ static int ad5504_read_raw(struct iio_dev *indio_dev, *val =3D ret; =20 return IIO_VAL_INT; + } case IIO_CHAN_INFO_SCALE: *val =3D st->vref_mv; *val2 =3D chan->scan_type.realbits; @@ -134,11 +141,14 @@ static int ad5504_write_raw(struct iio_dev *indio_dev, struct ad5504_state *st =3D iio_priv(indio_dev); =20 switch (mask) { - case IIO_CHAN_INFO_RAW: + case IIO_CHAN_INFO_RAW: { + guard(mutex)(&st->lock); + if (val >=3D (1 << chan->scan_type.realbits) || val < 0) return -EINVAL; =20 return ad5504_spi_write(st, chan->address, val); + } default: return -EINVAL; } @@ -154,6 +164,8 @@ static int ad5504_get_powerdown_mode(struct iio_dev *in= dio_dev, { struct ad5504_state *st =3D iio_priv(indio_dev); =20 + guard(mutex)(&st->lock); + return st->pwr_down_mode; } =20 @@ -162,6 +174,8 @@ static int ad5504_set_powerdown_mode(struct iio_dev *in= dio_dev, { struct ad5504_state *st =3D iio_priv(indio_dev); =20 + guard(mutex)(&st->lock); + st->pwr_down_mode =3D mode; =20 return 0; @@ -179,6 +193,8 @@ static ssize_t ad5504_read_dac_powerdown(struct iio_dev= *indio_dev, { struct ad5504_state *st =3D iio_priv(indio_dev); =20 + guard(mutex)(&st->lock); + return sysfs_emit(buf, "%d\n", !(st->pwr_down_mask & (1 << chan->channel))); } @@ -191,6 +207,8 @@ static ssize_t ad5504_write_dac_powerdown(struct iio_de= v *indio_dev, int ret; struct ad5504_state *st =3D iio_priv(indio_dev); =20 + guard(mutex)(&st->lock); + ret =3D kstrtobool(buf, &pwr_down); if (ret) return ret; @@ -290,6 +308,10 @@ static int ad5504_probe(struct spi_device *spi) =20 st =3D iio_priv(indio_dev); =20 + ret =3D devm_mutex_init(dev, &st->lock); + if (ret) + return ret; + if (is_acpi_device_node(dev_fwnode(dev))) { st->vref_mv =3D AD5504_VREF_ACPI_DEFAULT_mV; } else { --=20 2.55.0 From nobody Mon Sep 28 13:16:46 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 533783E3C7A for ; Fri, 21 Aug 2026 10:25:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787307933; cv=none; b=Eepepzst4uqJn/qweaoKCdAwqzpyRrGNi3YoS49mf5yCitQpt6CF8/cN5qVsCgaWQLe5QpX/PUUP1E1lJPRwijmoS3vVOMGc2UjbG53q5j/LWhRTrQYifX+MGE06Nw3E/ch45YHqyiMFGM623mdjrvALfnCQ27+UIwJJ72FxSSY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787307933; c=relaxed/simple; bh=gPhH4u7kFmeg8EHT11wFoZiSLcRlZ7le7pXzWEpGGPE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iozAQluTfIojRe9gqVdSFvqX04Ji+iJ3xyTiSvp6mjA+E2uLtjTs6D1hP1qs9Re9uFzqXTdVMXCCzK3NkP+qvkz6wf3nyOVtipPYb7Dl/iRnXRCQ/FQtj9PUVPkrJy+fRjCXs7sWvAPsavzXOZQJAtAJFW11uiHTwspu4wAwrR0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y15U8pZ0; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y15U8pZ0" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-499b02fc590so5075165e9.2 for ; Fri, 21 Aug 2026 03:25:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787307918; x=1787912718; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wyIuAekOpVPDTOROhunhzyK0Yq3w+Qc14AFzLwRnzrE=; b=Y15U8pZ0GuPE7RdZiKMbS9/7LyVYhr+S3npWht5VFFl6bD+u1Ef3YGqZMp33R76Kfp 6briDVENEIpPeJnHVCIjyCJpD5xF24aoytgFRDu3EETAWKUT44udJQ2S/JePyGCp2gZj VUFdTLWXl+KB3mPOMqQzqJuLhQSeuP5/So10tId1YXQO9ZJ0yz4aeQA3+xeWaiVm3yT3 RWNCrwNL6YuLILRer5k8b6HcpnVajVmW6euhUA/8GH3CxJ3BCKThqBwogJqWD+OWNtsm zg2xM1hvmi1cwiXEn+e+o3IJQGe1WlTgEhlOdKhcuNpc1/CDqTSUyHXtuLYUwfLWYdXu Ogww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787307918; x=1787912718; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=wyIuAekOpVPDTOROhunhzyK0Yq3w+Qc14AFzLwRnzrE=; b=T097a/K4QdbvBhvfPeWMPI1EJijS4Q1DBIKVr8QbTcxDOYELYD0JgK6A47Z4PD0r9k 5gnU8z8gBdf0K6g0sGyFl9de229fK9UqCPWr9GhJnEsSmN6MIjGl/WoB0Oc+UUeT+vZZ nyA/AGWRjKxTPXTQJtlCCkdYxdA9wmM9ox1/fPudcksI0FyV2pVgXngPUR63E4YJ4zOL 8a4rdACkUMBO1i/UHTLs04DEWQsECMpVE5m/okympLW5zPd64Dj1OWyttyWJHI5gNqrp yrcavClQNEUBJAzvDQU5IhgcZ9LlLFsrG2ow87bv3uvozAlfPmXpiKLrYazMiVLeU9jZ 59hw== X-Forwarded-Encrypted: i=1; AHgh+Rqt/PnfHt+uPvDEcGLF0fOtwFu3o4bvohanBo5CrZsyzxd1cvmDxXJ9ZVnsZfZkP2VCrWv9vpra6TcElG0=@vger.kernel.org X-Gm-Message-State: AOJu0YytiayMPaCDI2uC4caH9GCtXuJKdakl8oJk9QH5/VuT9v8XfkGU LNVTDOPUQ6wtOstaBp7QG3Dc1dGgYR7v35hz1fA44uwP1m5LEQst0yPm X-Gm-Gg: AR+sD13PFtF+dx0iNHGW5guNLUY6TV3R/UlL4Eaj/bJt8X21CzJB7kDOIol5C1JyViE KF0/ejc11ncRZA/+FA+hmWxhQwl6OElwbnuSpvEqKRpFh076iK32jHoH7ewA5tRGi0x+ec86qNH q5y4c+T67WWJYUoFdeHGVINijDf8fQz3Rrl4m73O8sOq4adTFfvqQ7mgvt9gI2bT0OS0HhqDuiT qheE7nFU1b17csc8A4SARKUOy+y/fbgjz+4gffBN+S4j/XAAFgj+8YpQICBz/7itIgPGETTgT35 PC9285ZIFlm1RE1+s6S47oWLdNEIEESQTAElXdzvfTXCatcloqEnKp4J3miSMCPj2BtMZpDwUOK bRo1KDQaKyRPBk6qCzhTxhx3Lqc2oI2gBBVnHKVaTXdS8Kmbj5UPAO8X60sOTk+mhRKfzQTNUK5 TFGHjxFKtpQ7as+l7RwlY5mg8T0osIr3xzjLSNNFKBX7F5ApKxIlgVCG951oK797hBnwBQQvSCQ 9QCjK1XcJiTPw== X-Received: by 2002:a05:600c:c494:b0:499:a5c8:c6f3 with SMTP id 5b1f17b1804b1-499b82f4d3bmr68893055e9.3.1787307918131; Fri, 21 Aug 2026 03:25:18 -0700 (PDT) Received: from fedora ([105.74.130.192]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499b9ba5139sm11663155e9.2.2026.08.21.03.25.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 03:25:17 -0700 (PDT) From: Taha Ed-Dafili <0rayn.dev@gmail.com> To: jic23@kernel.org, lars@metafoo.de Cc: Michael.Hennerich@analog.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, skhan@linuxfoundation.org, linux@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Taha Ed-Dafili <0rayn.dev@gmail.com> Subject: [PATCH v5 6/6] iio: dac: ad5504: support scale via output-range-microvolt property Date: Fri, 21 Aug 2026 06:24:48 -0400 Message-ID: <20260821102452.37407-7-0rayn.dev@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260821102452.37407-1-0rayn.dev@gmail.com> References: <20260821102452.37407-1-0rayn.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The AD5504 output range is set by the R_SEL pin, not the VCC supply. Add support for 'output-range-microvolt' to set vref_mv directly from firmware. Use device_property_present() to distinguish absent from malformed property rather than relying on the ambiguous -EINVAL from device_property_read_u32_array(). Fall back to the vcc regulator voltage for old DTs that predate this property. Signed-off-by: Taha Ed-Dafili <0rayn.dev@gmail.com> --- drivers/iio/dac/ad5504.c | 31 +++++++++++++++++++++++++------ 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c index 489d2e03e9f6..19ece5a2af58 100644 --- a/drivers/iio/dac/ad5504.c +++ b/drivers/iio/dac/ad5504.c @@ -300,6 +300,7 @@ static int ad5504_probe(struct spi_device *spi) struct device *dev =3D &spi->dev; struct iio_dev *indio_dev; struct ad5504_state *st; + u32 range[2]; int ret; =20 indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); @@ -315,12 +316,30 @@ static int ad5504_probe(struct spi_device *spi) if (is_acpi_device_node(dev_fwnode(dev))) { st->vref_mv =3D AD5504_VREF_ACPI_DEFAULT_mV; } else { - ret =3D devm_regulator_get_enable_read_voltage(dev, "vcc"); - if (ret < 0) - return dev_err_probe(dev, ret, - "Failed to get vcc regulator\n"); - - st->vref_mv =3D ret / 1000; + if (device_property_present(dev, "output-range-microvolt")) { + ret =3D device_property_read_u32_array(dev, "output-range-microvolt", + range, ARRAY_SIZE(range)); + if (ret) + return dev_err_probe(dev, ret, + "Error parsing output-range-microvolt\n"); + + if (range[0] !=3D 0 || (range[1] !=3D 30 * MICRO && range[1] !=3D 60 * = MICRO)) + return dev_err_probe(dev, -EINVAL, + "Invalid output-range-microvolt\n"); + + st->vref_mv =3D range[1] / (MICRO / MILLI); + + ret =3D devm_regulator_get_enable(dev, "vcc"); + if (ret < 0) + return dev_err_probe(dev, ret, "Failed to enable vcc regulator\n"); + } else { + /* Backward compat: old DTs without output-range-microvolt */ + ret =3D devm_regulator_get_enable_read_voltage(dev, "vcc"); + if (ret < 0) + return dev_err_probe(dev, ret, "Failed to get vcc regulator\n"); + + st->vref_mv =3D ret / (MICRO / MILLI); + } } =20 st->spi =3D spi; --=20 2.55.0