From nobody Mon Sep 28 13:17:22 2026 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 244E63ACEE2 for ; Fri, 21 Aug 2026 08:45:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787301952; cv=none; b=rOPb8UPRAdFMea3VIUQaaEveAlrwmxmslutFyr2a0e7/AcwXaQXHRjFog0oIprdcffjap5ey1wB56DG5Y3Hvq0zJ3AfEXvLBAe9NLrTtE8pWXVpEmW7Ec//bI6vBRmsYPcxrc1yssCdD4evdw/DOVA+Dx09GtXjo68PK3CKI7Yo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787301952; c=relaxed/simple; bh=hECz+rTVF4JahtvtK36ICZ2v3e438UAepa3Jm1G/eh0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Zy7osQ/qMkOd6OQqFmiXM4MbOqIKg/WINPy6gtQISx0WUZAD875Zs72yKW6/bk3ijODJDtcMr/J80Q/51CPveY7Af0BBOy2Kq4oEyiVelhLoeHJnP7i8haGb7GtcrjQvlFvYyUWTQl5I13XMZ2dUwPNjdShectMfk6dbCmgN7Fg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fslGJVK7; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fslGJVK7" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-6a17211b9ecso2229710a12.2 for ; Fri, 21 Aug 2026 01:45:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787301949; x=1787906749; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=iYefBj/AHN1n4yIAZB/3J8tNso/f+xEHco2SVVZ9szI=; b=fslGJVK7NiDaJxyjl4hcMXJITJWW8pv8KIy9RIwAja79MISOlXmOH0BCktpKeSur0x 0/XFMikHTuTcU/IjzKET+qYu/6/3bOgdlXaMrUDNcHsqk5DUObTo6V2bTEd9sb5p720a uguxieZNAFrHAGnknHpCQG4zXZeT0TXv1adgLPbYVFbgHRGi5nbcaGeS8TzXokXbBOUY 698sOVOs3+pADfv0j9j3fQxitIeYoH4FIauseIv7koo6aiUAGAZ0mUcjlIrklyavxlww IyPFb1Qt5I59f8YiDmvFoLSLxGn8uIl28VNYJky4+4eEK3vmaL7yJCXAUIi+pkOsexQS Qj/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787301949; x=1787906749; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=iYefBj/AHN1n4yIAZB/3J8tNso/f+xEHco2SVVZ9szI=; b=KTneAClvJWPZ2nWdKIk6IsXfnQcpuJ4XRMYJRNkpS9Nh/+bpGOWY6UWpiBIGcN0fa7 pduUcIpqDmjTWcFoBbjIVhUSdcB3cfqK4bN1xp/7OGcSxx9XEMP9FN5y0cMfroNF0B+f phw8AnnSHbRSKiLj4ywAAcPRO4B63ICSTOhAcXWXZ1AGKCLzMZ+w974BnhIXzLHDeiFT fCMeoV4iC1rDHX7pio4l/1huQkY1DYlLz4sErOnVZDxkQH9TaXfNEfR8071W4u4qbex4 p+Qp3uRLp53kA/6tB8inZOe9jV3DAethb493AlquvharhE6Wd8YM/ovpHIQCiY0HTiXK JChw== X-Forwarded-Encrypted: i=1; AHgh+RpIZE6d3zGE2jhCKt+Wr5iqCKpzLQMAQ9/4xGKw0OUSKscJL3XOs+SZGzZLUXNcI6RMxF1r4QaA3snKCc4=@vger.kernel.org X-Gm-Message-State: AFuF++l4FDEUlWLNcpmjbV88KAFl/Q+cSn6nFgtH+9JMffD20Xt9iwFe 3n8gLEpvUV2ls0GAClpTnSVAGW/fdCjo/s6AheCl3jeIxfAo5/29W5UM X-Gm-Gg: AR+sD11IMhtMcdz3gbJHCvwwBk89BSkucr7212THI52lisO+MiRI6vIgas6CX4ELwAY q8d9hfpuwYsh+EHJzhStdochtFQQaMUpubKRGUlJQ4lLDxa+Y43ltZShwgJrBPH0+GKMeBEzGeS 79tYQymM3QPlCO+Ok2SgRhuEy1rDPboVWbZpjH/yhnwCPTaPh4QJRdz8XNSILKCNRW7AOF3se9F bCt743DEfiEdPRnKTee714oq6uR3+RxjYgn74TsS6toevkWWOkJxEMA+WEln74Vd6KB4XDkqPZJ U9VYByMJqLsiBFvAJQXQfzVy/kZxskszKYYTE/E5XvG2mS519LgnhBt+Gue5/FkJQ13NCH47GAw lnzNL5s9lYX/fTt4cMLO8D0uFQ+eSqjsKSrGQt28AdqxPjVmHb3+219hZcIAHEePMzx1lc4VON+ ZaYPvPgYxoQFQmg2GKwsjotE8d7xKIeV72RH9psDizkDU/QeMcIcuehQANPqC8fh6qqShSe19DL Q315w== X-Received: by 2002:a05:6402:505b:b0:69c:811f:8f5 with SMTP id 4fb4d7f45d1cf-6a42f1b9325mr5134767a12.6.1787301948672; Fri, 21 Aug 2026 01:45:48 -0700 (PDT) Received: from Ansuel-XPS24.localdomain ([95.236.20.157]) by smtp.googlemail.com with ESMTPSA id 4fb4d7f45d1cf-6a3ff16c2cbsm5579500a12.22.2026.08.21.01.45.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 01:45:47 -0700 (PDT) From: Christian Marangi To: "Rafael J. Wysocki" , Viresh Kumar , Christian Marangi , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Daniel Schwierzeck , stable@vger.kernel.org Subject: [PATCH] cpufreq: airoha: fix probe failure with correct error check Date: Fri, 21 Aug 2026 10:45:39 +0200 Message-ID: <20260821084541.139703-1-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Daniel Schwierzeck dev_pm_domain_attach_list() returns the number of attached PM domains on success (a positive count), or a negative error code on failure. The driver checks "if (ret)" which treats a successful attachment of one or more PM domains as an error, causing the probe to fail with return code 1. Fix by checking "if (ret < 0)" like all other users of this API. Cc: stable@vger.kernel.org Fixes: 84cf9e541ccc ("cpufreq: airoha: Add EN7581 CPUFreq SMCCC driver") Signed-off-by: Daniel Schwierzeck Signed-off-by: Christian Marangi Reviewed-by: Zhongqiu Han --- drivers/cpufreq/airoha-cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpufreq/airoha-cpufreq.c b/drivers/cpufreq/airoha-cpuf= req.c index 3e7770860d13..8283c528d0c1 100644 --- a/drivers/cpufreq/airoha-cpufreq.c +++ b/drivers/cpufreq/airoha-cpufreq.c @@ -64,7 +64,7 @@ static int airoha_cpufreq_probe(struct platform_device *p= dev) /* Attach PM for OPP */ ret =3D dev_pm_domain_attach_list(cpu_dev, &attach_data, &priv->pd_list); - if (ret) + if (ret < 0) goto clear_opp_config; =20 cpufreq_dt =3D platform_device_register_simple("cpufreq-dt", -1, NULL, 0); --=20 2.53.0