From nobody Mon Sep 28 13:59:18 2026 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 348A1322A for ; Fri, 21 Aug 2026 02:10:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787278211; cv=none; b=ENVe6Tz7DB01VKzGsGpeDI+l2ZC+HEHggyDj+x1vpbBdlGDjziYAZOhQ5zUGv49sTw3NUE8SGcoK97iKmrniRVvSNThO9tDmZXXbUjSGapxS26IU7+twIXVcvRMDmyJV8b2e7DTr57GF8rJeU6LeNJnmrU5DMtDa+tXpBrMgFAc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787278211; c=relaxed/simple; bh=gxy/RAB7TReQL1k1dfKT9uu0OttQHTTAjGHQOCvhe4E=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=agDlfaT05zPhoGGr1mvVW92jnOIup+JzQC6DvnwamBDrlTlxbHJHHYoXboqNSl2Hft56wv+v4hS9WjSum4Y1LFJIkMg7kt79F1QLDKXR8Tolsho+Ix2NDkH2eBjoISqyO4miduAbCiruPP8KK0V/Eeon93YFCg9QVNqdQl9PruQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L9ZLSyql; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L9ZLSyql" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2d0407aedd6so5948755ad.0 for ; Thu, 20 Aug 2026 19:10:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787278209; x=1787883009; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ERmq5VrqfpbnfKAY7qSZX83W66jy6ztOiCpK3nABUcQ=; b=L9ZLSyqlV+wlh3vU0uzv87x/mfjQoJjKrKXsNKJ8cWuTsx4gihvDRifccvtY9SlBUo SQM/RKUsnFvJ11DQWve7rBdlHMoOevokkXwa6Y0N/eMiOtt5Qwd0knJm4tI8gZM/ZQb7 xIaoSncdC2YG92lKTNBKZMWUsN6wBRDN+yPam1f5xLCNSLFfZhuzeHGEjgRMYnh8DdsT MM1JF7qEt2YetvMxGpQIWMxB3HoxfcXAt55uNWGqwnwZJjK7vKMSJIlhde+A/SI54ZGP OQLhpoyaqHgkefgaN2WZqnkOjrbUMZfmKOs+Jyc9WPytVpYbG3rVuNz93ts29mvMaNiS RgDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787278209; x=1787883009; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ERmq5VrqfpbnfKAY7qSZX83W66jy6ztOiCpK3nABUcQ=; b=PgMYWpEzEdtaDVfDFA5vscA0JfxFTPgq31VLzzVHGHlj22yz1mHjxD2hMYE9WviobS j8JI8vfbWfBRoLI/njS9eO6+dzzBgxjtvQTEFELL4+jcj3/g8HlA/qr3436RZ+jGon7c 5JX6VMgf/7di2pyYsPLLVvtDqpCWLkkT5HnsJtvwPWbSe2qemdPdqDeEU7yLSsOZ0fGM LOpzAOEeoPGtxIv/MUHmOIfGOHA7bE9zvBcSBwfnLD6A1Tw5UitndvQWp1vVP+8JyrAO r3mDnrbv+MakAYtvHI9JcY23lYTeJ2fqhvbiwsPMklKGIbAM9bFSV+Va2x38bkYitHOz xFOQ== X-Forwarded-Encrypted: i=1; AHgh+RpwtH3ySuxj0o8I2rOxqKn/NP/JMenhjS2rb3oTr7endyWwQnqx1PqYn99QGzFqsQ/KQwuM5xJgb/AvRDI=@vger.kernel.org X-Gm-Message-State: AFuF++na7xjf6bqslUdU6HMQdulg8mRShCovukeCMJdszV03XfyfK65O 1lHoPxQJaEkQsl7WiO7veevgKY+wcB0O6c35SIQCNPcqxS0fd1EbgY54 X-Gm-Gg: AR+sD10bhldrtEDCPWW6eIFSgX/imB3mTSKbjUpD/Js4zbuuED7HXs4jR/jEWuWfUEr 4XpmLVbdwFXPtaJW5K3rIFtw3UCvVckCIpBGsUqs7/RN8GrKqUJQggZBTY3t0QRIxMuFwBEjhXc XTl31s68xV73BUwsXjP08F4nmm4U7Fp6R9SwYFDqfOb19STyyv8I2Qy4eh4tjLm4i/V4IKXjOly iXk7XD9yE7kyMpfWDWCYkR36lTr76Fb1D6o4p3KwE0lyWHfyB4/RbUrBHsJnZKKy4ppq5s5zYMi SYGLEA3GS8X4PZ7veX3z5yBLTrIm9l626rI8uVeCZReCJ5G13zouYWU5ZZiPwFBEj2lsw25exjc kOqQbDdhiU6p6sPRhcUy5CmjgIS2loLhqq/CHLEEJCTN9ek5+4YQ2nLRMkrf+1plX6lNDlhnjyu Y/FjNBSyXYF9C8KGzJFqwW+y6MKHVxPP+eR21Wxv7J/+tOEOSsBl9suA0a3wpf1XnUyxVdul52k BtcMZgsJNxGDmnizWTUtQnO7BentKy9TurhrrR+l0NPGkd1AAiZw70dvuT5 X-Received: by 2002:a17:90b:3912:b0:392:e5b1:d833 with SMTP id 98e67ed59e1d1-395c3738b35mr4301453a91.13.1787278209224; Thu, 20 Aug 2026 19:10:09 -0700 (PDT) Received: from open.dhcpserver.bu9bmc.local (61-220-246-151.hinet-ip.hinet.net. [61.220.246.151]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-395c4697358sm1035847a91.8.2026.08.20.19.10.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 19:10:08 -0700 (PDT) From: Alan Tsai X-Google-Original-From: Alan Tsai To: corey@minyard.net Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, Sam_Tsai@quantatw.com, tsaisam218@gmail.com, Alan Tsai Subject: [PATCH] ipmi: ssif_bmc: Prevent pending response from being lost Date: Fri, 21 Aug 2026 10:09:06 +0800 Message-Id: <20260821020906.880029-1-alan-tsai@quantatw.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" A pending response may be completed and cleared before the response data is loaded into part_buf. This causes the pending response to be lost, so the host cannot retrieve it. Add a flag to track whether the response data has been loaded into part_buf. Do not process or complete the pending response until the response data has been loaded. Signed-off-by: Alan Tsai --- drivers/char/ipmi/ssif_bmc.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c index 6036897725f3..815d16c0540e 100644 --- a/drivers/char/ipmi/ssif_bmc.c +++ b/drivers/char/ipmi/ssif_bmc.c @@ -101,6 +101,8 @@ struct ssif_bmc_ctx { bool response_in_progress; bool busy; bool aborting; + /* Response was loaded into part_buf for the on-going read transaction */ + bool part_buf_loaded; /* Buffer for SSIF Transaction part*/ struct ssif_part_buffer part_buf; struct ipmi_ssif_msg response; @@ -639,6 +641,7 @@ static void on_read_requested_event(struct ssif_bmc_ctx= *ssif_bmc, u8 *val) } =20 ssif_bmc->msg_idx =3D 0; + ssif_bmc->part_buf_loaded =3D false; =20 /* Send 0 if there is nothing to send */ if (!ssif_bmc->response_in_progress || ssif_bmc->state =3D=3D SSIF_ABORTI= NG) { @@ -653,6 +656,7 @@ static void on_read_requested_event(struct ssif_bmc_ctx= *ssif_bmc, u8 *val) =20 calculate_response_part_pec(&ssif_bmc->part_buf); ssif_bmc->part_buf.index =3D 0; + ssif_bmc->part_buf_loaded =3D true; *val =3D ssif_bmc->part_buf.length; } =20 @@ -671,7 +675,8 @@ static void on_read_processed_event(struct ssif_bmc_ctx= *ssif_bmc, u8 *val) } =20 /* Send 0 if there is nothing to send */ - if (!ssif_bmc->response_in_progress || ssif_bmc->state =3D=3D SSIF_ABORTI= NG) { + if (!ssif_bmc->response_in_progress || !ssif_bmc->part_buf_loaded || + ssif_bmc->state =3D=3D SSIF_ABORTING) { *val =3D 0; return; } @@ -763,7 +768,8 @@ static void on_stop_event(struct ssif_bmc_ctx *ssif_bmc= , u8 *val) ssif_bmc->aborting =3D true; } } else if (ssif_bmc->state =3D=3D SSIF_RES_SENDING) { - if (ssif_bmc->is_singlepart_read || ssif_bmc->block_num =3D=3D 0xFF) { + if (ssif_bmc->part_buf_loaded && + (ssif_bmc->is_singlepart_read || ssif_bmc->block_num =3D=3D 0xFF)) { memset(&ssif_bmc->part_buf, 0, sizeof(struct ssif_part_buffer)); /* Invalidate response buffer to denote it is sent */ complete_response(ssif_bmc); @@ -773,6 +779,7 @@ static void on_stop_event(struct ssif_bmc_ctx *ssif_bmc= , u8 *val) =20 /* Reset message index */ ssif_bmc->msg_idx =3D 0; + ssif_bmc->part_buf_loaded =3D false; } =20 /* @@ -835,6 +842,7 @@ static int ssif_bmc_probe(struct i2c_client *client) ssif_bmc->request_available =3D false; ssif_bmc->response_in_progress =3D false; ssif_bmc->busy =3D false; + ssif_bmc->part_buf_loaded =3D false; ssif_bmc->response_timer_inited =3D false; =20 /* Register misc device interface */ --=20 2.25.1