From nobody Mon Sep 28 11:41:18 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAED923393C for ; Sat, 22 Aug 2026 01:12:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787361143; cv=none; b=dPPWGmbO5M9oECRR/mT1TY1hc3Mo0jGBR5JVwBoceLJ+Vi4acSOpyvhd/HU45WcSjnqNRLqgBE2SEBc+wHOdSjZYSYoYbUmnHVImE9DuR6LGZon2dBYhAOm2I8NGDYDoyFGi3Dd656pNZLv5CJCbLpHeISnbCETuaGXkIAq7gxc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787361143; c=relaxed/simple; bh=wN1MwfUvPUgv6Pty4uwJnzpztqBgXcgXAOukobtm6cE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=MIwViVNVFaoqTViTYnAWDfEH8e6Immxl15IWalw94vrkNwbQgv2loEnVp9k7gg9Eaf4mLNoWvnMbCmDMvkK4cV9Q82u4wss4i33Vf9Oq0BeXcztk1orWK0qHlbHOuzrbhu4t4pwNuipCHYxcu9QHNvJycRgRchBa1UGE5FyE8f4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nexthop.ai; spf=pass smtp.mailfrom=nexthop.ai; dkim=pass (2048-bit key) header.d=nexthop.ai header.i=@nexthop.ai header.b=OWZw7xt2; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nexthop.ai Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nexthop.ai Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nexthop.ai header.i=@nexthop.ai header.b="OWZw7xt2" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2cf6d65d8a7so19564875ad.0 for ; Fri, 21 Aug 2026 18:12:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexthop.ai; s=google; t=1787361141; x=1787965941; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=wN/b91/dIiXaYiNY6AMuG5UAHrJgyvCbCYyK8iXNFeU=; b=OWZw7xt2Qrn80LNf77R/YjVlwjkZWppPmbNhKYNQyG2D0EQiTZCPCQAwKJSh0MlsnO U19Dz6+FNF36DNUoZh22eAXMfBWREdTcOOZ7tir2F55LGx9YzzaOoqqtSovGCHoRNgD0 lTV0ne2xh1TXGlHM2b2qNXj/y+rm0WvNMipQUK+yaWL04UHX4X++vVCVDPFbHaE1pW9W PSDp7OKAbmMs5LMhza1KLCzFKdIqTA3WQlde2XOgny3gtVxkmOLuMutykcNcCPEvAUZg 7bd6QBEHmnxPPlpnbN1zrT3l8+208vRgRwURpiM/0z4h9GK28dPMSPigWN9ehLu/pywQ E0pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787361141; x=1787965941; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=wN/b91/dIiXaYiNY6AMuG5UAHrJgyvCbCYyK8iXNFeU=; b=PhzZtwkCjV5fHla9tnjU6fFj/e0ld4kkIKmA0c2FIzlYGZydDwMUzfAqGogcFYYGOf JnqvlfU8ADCdi5mPzImdG4c11naB+00KNpRbdn2+8kP8Pws4J2Ntc0T1BQxtz0tM2Pit zXa0RjyP+kPT2ZFEOjLkJcOAqoLo1OjUIB750RT1w169yNfD2YTCqN02KzbETG9oUkhy pLBhIgb8ZLu5oHLHEZY2cv8obC/PTSmTDvir279qM8ILOKCqRECHYCJ2u3Py2ZEG0ZcX pKMxd6ah6vTvAh9yjS6q0UQd66DaRWUAgMdliYjrrUNH67AKzi8MmweniWcpW0aHbh+z wtag== X-Forwarded-Encrypted: i=1; AHgh+RoA630nu90Jfd5mFUH79NRgJC+dHf6LmobgVdjufXkjV2gn1DlgKFYwGSJTydTHgOSAYNGjP7BWtMg9+W4=@vger.kernel.org X-Gm-Message-State: AFuF++nZieLq3by9DEkEZuZxqfIHPAkWkZADeg9zR5W7TAaKw+2nX3vi kPz6WH3De3lMqkuHyyCSn+47vMOr2em1PlVve+s3B/yOaotEK5w0C7vlRHZb3YZSaoOW+0LK5pY x9vqH6nM= X-Gm-Gg: AR+sD10+tIqT98ffg1/xe+zK5q1uQrapX4ZYZ7lyO3rNnoRNGBrOoWSWPd3TUMzeNai LL1vSK/KqadGsA5HgRyCnxStyg4lDdPEesc8nswrlZ0SBcj6G92v8XExyhvL/gJ4sf4yMtaDXCr LmWyJsaGZZICM9EDRAmMWVU7mHlY8uW1Ny40xKcxCYzEVn3JW0/ax5UVjjVJuOzo/J5hzkN3TGR wdo4u/yOuHnlH5ubTrckYhlu/+6okicBmA8liR8u72zdWEZBcSlUhKInJnCBKI0HHRTYSmwZV/g tQFazG+F+c/NuqTWVuYh9OZLuiFmdgnoruBtiSNVZ6QJ94V2oCT37abxKaYudXYckX1DIiYX/mR KF3sIXJFOxnJM4rMy0zPiUrwqeGxQOlAFGCgjeQ6n29HDTsRWT1XDwvObq0HgpvliSFubgDgGEQ 62x9782FAFpZQhdpF9XLSWMHH9x+E5RWYe3aCPXt9Dub10ZXnui8E6Cfi9Ov0jIOw= X-Received: by 2002:a17:902:ebcd:b0:2cf:ccc2:6088 with SMTP id d9443c01a7336-2d64af6b6aemr207150365ad.4.1787361141009; Fri, 21 Aug 2026 18:12:21 -0700 (PDT) Received: from [127.0.0.2] ([50.145.100.174]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327f90cb8e3sm1136529eec.12.2026.08.21.18.12.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 18:12:20 -0700 (PDT) From: Abdurrahman Hussain Date: Fri, 21 Aug 2026 18:12:17 -0700 Subject: [PATCH v7] i2c: xiic: restore non-managed runtime PM to fix clk WARN flood Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260821-i2c-xiic-restore-runtime-pm-teardown-v7-1-954e06765144@nexthop.ai> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/53RTW6DMBAF4KtEXtfV2MY2zqr3qLLwz1BcKYAMI VQRd6+dbqjY0C6fNPreaOZBRkwRR3I+PUjCOY6x73LQLyfiW9t9II0hZ8KBK6iZoJF7usToacJ x6hPSdOumeEU6XOmENoX+3tEQwDoWHPfASaaGhE1cnjXvl5883twn+qnYZaKNRft67jGzMvfHy plRRgF1aBwHpQ28dbhMbT+82khK58y3anVQ5VnVFmUAL6Bp+E4VW7U+qIqsyiYIJh3oGtlOrba qOahWWVXGGHSVqALzO1VuVA4HVZlVb2VwRoGUUO9U9R9VlQsEJ73QIND+/ta6rt8nUXppmQIAA A== X-Change-ID: 20260813-i2c-xiic-restore-runtime-pm-teardown-dd0ab1db2c02 To: Michal Simek , Andi Shyti , Andy Shevchenko Cc: linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Abdurrahman Hussain X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1787361139; l=8752; i=abdurrahman@nexthop.ai; s=20260510; h=from:subject:message-id; bh=wN1MwfUvPUgv6Pty4uwJnzpztqBgXcgXAOukobtm6cE=; b=2e8rBZs4veqnDNBR4JmfQHiW14cySID95HGyycLLuRfDo7abiViCnXKz2tIOmoMn6nOSDixVF H78DYyFgPrtC3tmuSUK9zz6YMB8gzFl9MXbnOVEXXxwXSvirRW93WEI X-Developer-Key: i=abdurrahman@nexthop.ai; a=ed25519; pk=omTm9cCAbO0ZhS32aKfJDKue0W3sQGpG9ub5eYHif8I= The devres conversion replaced manual pm_runtime_enable()/disable() with devm_pm_runtime_set_active_enabled() and dropped the remove-time runtime PM teardown. The managed release tears runtime PM down in the wrong order: it calls pm_runtime_dont_use_autosuspend() before pm_runtime_disable(), i.e. while runtime PM is still enabled, and devres is LIFO so the devm_clk_get_enabled() release runs afterwards. At remove(), pm_runtime_put_sync() leaves the device active with the autosuspend timer armed. Clearing use_autosuspend then makes rpm_idle() suspend immediately, and xiic_i2c_runtime_suspend() clk_disable()s the clock. The later devm_clk_get_enabled() release clk_disable_unprepare()s the already-disabled clock, so clk_core_disable() WARNs ("clkN already disabled") on every teardown. Drop the managed helper and restore the non-managed runtime PM setup and teardown, so runtime PM is enabled once in probe and disabled once in remove and the clock enable count stays balanced. Order the remove teardown so runtime PM is disabled before the usage count is dropped: pm_runtime_disable() followed by pm_runtime_put_noidle() instead of pm_runtime_put_sync(). Dropping the count first with autosuspend still enabled arms the autosuspend timer, and a preemption before pm_runtime_disable() lets it expire, suspend the device and clk_disable() the clock, which the devm release then disables again - the same WARN. Restore the non-managed IRQ request as well. The probe error paths now unwind runtime PM by hand via goto, and a devm-registered handler is only freed later during devres unwind, so it would stay live across the manual teardown (and across any future failing step added after it). Request the IRQ with request_threaded_irq() and free it explicitly in the probe error path and in remove. The probe error path also clears use_autosuspend, to match the teardown in remove(). Fixes: 50c63491ff26 ("i2c: xiic: switch to devres managed APIs") Signed-off-by: Abdurrahman Hussain --- Changes in v7: - Add the missing kernel-doc entry for the new @irq member of struct xiic_i2c (the non-managed IRQ request added in v4 introduced the field but not its doc), fixing a "struct member 'irq' not described" W=3D1 kernel-doc warning. No functional change. - Link to v6: https://patch.msgid.link/20260820-i2c-xiic-restore-runtime-pm= -teardown-v6-1-5db5c3703ea0@nexthop.ai Changes in v6: - probe: check the pm_runtime_set_active() return value and unwind on failure (undo pm_runtime_use_autosuspend()) instead of ignoring it. On failure runtime PM would stay suspended while the clock is left enabled, and remove()'s pm_runtime_get_sync() would then resume, enable the clock a second time and leak the enable across the manual teardown (Sashiko). - Link to v5: https://patch.msgid.link/20260820-i2c-xiic-restore-runtime-pm= -teardown-v5-1-ca5db9605508@nexthop.ai Changes in v5: - remove(): disable runtime PM before dropping the usage count (pm_runtime_disable() + pm_runtime_put_noidle() instead of pm_runtime_put_sync()), so the armed autosuspend timer can no longer race pm_runtime_disable() and re-trigger the clk double-disable. - probe error path: also call pm_runtime_dont_use_autosuspend() so it mirrors the teardown in remove(). - Link to v4: https://patch.msgid.link/20260819-i2c-xiic-restore-runtime-pm= -teardown-v4-1-6999eb434d1c@nexthop.ai Changes in v4: - Request the IRQ non-managed (request_threaded_irq/free_irq) and free it in the probe error path and in remove(), instead of a devm handler that would only be released during devres unwind and so stay live across the manual runtime PM teardown in the goto error paths (Andy). - Link to v3: https://patch.msgid.link/20260818-i2c-xiic-restore-runtime-pm= -teardown-v3-1-5fd315b078e1@nexthop.ai Changes in v3: - Drop the managed devm_pm_runtime_set_active_enabled() helper entirely and restore the non-managed runtime PM setup (pm_runtime_set_active + pm_runtime_enable, with probe error unwinding) and teardown (pm_runtime_disable + set_suspended + dont_use_autosuspend), so the disable depth stays balanced rather than being disabled twice (Andi). - Link to v2: https://patch.msgid.link/20260814-i2c-xiic-restore-runtime-pm= -teardown-v2-1-7ae5d0c30ff2@nexthop.ai Changes in v2: - Move the Signed-off-by into the commit message proper (Andy). - Link to v1: https://patch.msgid.link/20260813-i2c-xiic-restore-runtime-pm= -teardown-v1-1-0e7dfb206790@nexthop.ai To: Michal Simek To: Andi Shyti To: Abdurrahman Hussain To: Andy Shevchenko Cc: linux-arm-kernel@lists.infradead.org Cc: linux-i2c@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/i2c/busses/i2c-xiic.c | 49 +++++++++++++++++++++++++++++++++++----= ---- 1 file changed, 40 insertions(+), 9 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 3e7735e1dae0..92cefc7e221b 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -67,6 +67,7 @@ enum i2c_scl_freq { * @rx_pos: Position within current RX message * @endianness: big/little-endian byte order * @clk: Pointer to AXI4-lite input clock + * @irq: Interrupt number * @state: See STATE_ * @singlemaster: Indicates bus is single master * @dynamic: Mode of controller @@ -92,6 +93,7 @@ struct xiic_i2c { int rx_pos; enum xiic_endian endianness; struct clk *clk; + int irq; enum xilinx_i2c_state state; bool singlemaster; bool dynamic; @@ -1475,9 +1477,17 @@ static int xiic_i2c_probe(struct platform_device *pd= ev) =20 pm_runtime_set_autosuspend_delay(dev, XIIC_PM_TIMEOUT); pm_runtime_use_autosuspend(dev); - ret =3D devm_pm_runtime_set_active_enabled(dev); - if (ret) + /* + * Enable runtime PM by hand: devm_pm_runtime_set_active_enabled() + * tears down in an order that races the devm-enabled clock release and + * makes clk_core_disable() WARN (see xiic_i2c_remove()). + */ + ret =3D pm_runtime_set_active(dev); + if (ret) { + pm_runtime_dont_use_autosuspend(dev); return ret; + } + pm_runtime_enable(dev); =20 /* SCL frequency configuration */ i2c->input_clk =3D clk_get_rate(i2c->clk); @@ -1486,10 +1496,15 @@ static int xiic_i2c_probe(struct platform_device *p= dev) if (ret || i2c->i2c_clk > I2C_MAX_FAST_MODE_PLUS_FREQ) i2c->i2c_clk =3D 0; =20 - ret =3D devm_request_threaded_irq(dev, irq, NULL, xiic_process, - IRQF_ONESHOT, pdev->name, i2c); + /* + * Request the IRQ non-managed: later probe steps unwind manually via + * goto, so a devm handler could still be live after that teardown runs. + */ + i2c->irq =3D irq; + ret =3D request_threaded_irq(irq, NULL, xiic_process, IRQF_ONESHOT, + pdev->name, i2c); if (ret) - return ret; + goto err_pm_disable; =20 i2c->singlemaster =3D device_property_read_bool(dev, "single-master"); =20 @@ -1506,14 +1521,16 @@ static int xiic_i2c_probe(struct platform_device *p= dev) i2c->endianness =3D BIG; =20 ret =3D xiic_reinit(i2c); - if (ret) - return dev_err_probe(dev, ret, "Cannot xiic_reinit\n"); + if (ret) { + dev_err_probe(dev, ret, "Cannot xiic_reinit\n"); + goto err_free_irq; + } =20 /* add i2c adapter to i2c tree */ ret =3D i2c_add_numbered_adapter(&i2c->adap); if (ret) { xiic_deinit(i2c); - return ret; + goto err_free_irq; } =20 if (pdata) { @@ -1526,6 +1543,15 @@ static int xiic_i2c_probe(struct platform_device *pd= ev) res, irq, i2c->i2c_clk); =20 return 0; + +err_free_irq: + free_irq(irq, i2c); +err_pm_disable: + pm_runtime_disable(dev); + pm_runtime_set_suspended(dev); + pm_runtime_dont_use_autosuspend(dev); + + return ret; } =20 static void xiic_i2c_remove(struct platform_device *pdev) @@ -1537,6 +1563,8 @@ static void xiic_i2c_remove(struct platform_device *p= dev) /* remove adapter & data */ i2c_del_adapter(&i2c->adap); =20 + free_irq(i2c->irq, i2c); + ret =3D pm_runtime_get_sync(dev); if (ret < 0) dev_warn(dev, "Failed to activate device for removal (%pe)\n", @@ -1544,7 +1572,10 @@ static void xiic_i2c_remove(struct platform_device *= pdev) else xiic_deinit(i2c); =20 - pm_runtime_put_sync(dev); + pm_runtime_disable(dev); + pm_runtime_put_noidle(dev); + pm_runtime_set_suspended(dev); + pm_runtime_dont_use_autosuspend(dev); } =20 static const struct dev_pm_ops xiic_dev_pm_ops =3D { --- base-commit: d58772d8520c7ef247c4b95c9bd76d3a25da9ff5 change-id: 20260813-i2c-xiic-restore-runtime-pm-teardown-dd0ab1db2c02 Best regards, -- =20 Abdurrahman Hussain