From nobody Mon Sep 28 13:18:02 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC1A6375ABE for ; Fri, 21 Aug 2026 06:36:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787294195; cv=none; b=fSCLpUjW1nL3HwEgNjDS1SpGIfntCp6gZpbX7l2PMyGy4qmThH1roDkHUYBZWiFyYeDsCIAbIqv/qx511W70PMPpDaAh+Kal+Putk+Jh4qAucQzq/54u6tFaPHKx7RXkQ1vTDcKGiubCUdGNqzNPINcMa690f8wlRTJtWuPkbN4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787294195; c=relaxed/simple; bh=nzZOtbt5OVvyXTsuO2enZMGjCyp7ObHjMnPZY+OoxFs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uKf/GtUO2XVgmH4m3uoaa31FSv5PGM/pc/rLXUFFq1/2Ji2jnhaagZ4aI4QrT7edjls/cjEAW8SoIiFLDwrLQXy9pgb/b+VMVZjlR4j35tpLTbntTQlwleeouNtBZBDIlLvmAoyCEz/r8LLN1A6lOAFQCKNH/PTaKZ+5sqhqkTs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QmYfYqHT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hVcRE5Xo; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QmYfYqHT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hVcRE5Xo" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67L5TiFE1478262 for ; Fri, 21 Aug 2026 06:36:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qryDsqatoi20683XWRj2TQyfOjsImSdTWpK8VqCl+pI=; b=QmYfYqHTBhxbYCWf sqn9kwqRqxtyhewzNt2a9VyI0mabwmRmqDhJ7HVkFcHMIXhTF7VgydASY/UHATT0 Cz5rq4CboK9RTg+Wn2ULO2RF8AGI3JJJk8p5lxBf3NP/sHcGMTRPDne5yEi7auKP 8gjQYCtKZghVCMcdJpMEJFtqdkI3ZmrgrMID0DmwqhSx4UQH/ALfwyxG1oQ+JybG ET8Ol80zaUGtYcT7qVMHci5YAuap6tlyKAH1fomymjKJtHArqFEFcgaMixe3flq8 +1XeneEbE9ElWdpuL/mpuJi3b/diZgI2CrczGolcGM6RFB+GturgPXes4+r6wjqd zJ6xAw== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g6gddg7nn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 21 Aug 2026 06:36:31 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2cee894b3d8so13965925ad.2 for ; Thu, 20 Aug 2026 23:36:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787294191; x=1787898991; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qryDsqatoi20683XWRj2TQyfOjsImSdTWpK8VqCl+pI=; b=hVcRE5Xoh+TSQBJaIHHJZMJ8xGMdAUV+Yzo3Lfm3enGjEYnEEOWCaHHnGhX6nKZuBF uxNOsROLra2d2bVTjwlP3m8sBYBBTeMKl0Yx4i4lvC1GPm8EAO1cV5orPQJojPXfM8iz nPf3wJcGaUzPqnrPGkFdUOBtXOiaybaow7DogYBGWMPm50wmv2D1VW4ObuiNlZnFHcDA SrH2gJl+heAhcUw18rYPG3DhKLVRw8JoTJEwpFskg66B2Om+bmB0kKa9eojpRi1Suk6o dvKmKdXbOKMWcd/ZZ+JnAaZIKaHv/ln09HQVC/522Gt7v85aFM88NbRX3yCXfbs6Hc8X FAqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787294191; x=1787898991; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qryDsqatoi20683XWRj2TQyfOjsImSdTWpK8VqCl+pI=; b=gxYDiJvXPJsRq9oglOs1RLgjTp0gNf0PKvgMc4bfvAPM1+SvPgqa8D/Amow6y7nwc/ GtXXLzGYf9+UAXvuADpQ45hLHTImE2wwrFsIKIb3eh4bgfjtR72iAYnC2cCO370Z0Ayt kK5YyJlVVPf7iD5Q8TDKVSQyCMqMDX4IMYkfoGon+7UIhZLqTeTYXGkQrWO8cUsNags/ VCdg8HQgA3sG3TFmrN/O+sMv9zxgTzO54JenM8dQl2isLT6LSRKGe6MhQkFdRiZvriyA pLEr+K1NZVHA0Hg0OotpqCZwrigIBdpAKue2pUJbYXSCoJ5jFRlfZyniHqCTLMM09zlp e+Rw== X-Forwarded-Encrypted: i=1; AHgh+Rqex2D7rfQwhPAp8dNNijFc8LDL7jWT31uflFoiUfWW9Af/Y30SkH0kjp01PqLRHAj9qK5zcIKsM5FXpUI=@vger.kernel.org X-Gm-Message-State: AFuF++mOAxnJbL0Zid23BIBMNz8cZ2/9u1xAQT7JjXth+vNSqqaZZZQf ZTZdotugv7CwBecepr0yefnU0CjGvCGCEJUoFlXSVXum1ReyX00qAs9PKZz0LA5Wx9rEPIum79w DUjO6YBN4qbs5ldTptZyPdZDzIR0Ejl2usjp94WLM4/8/CvBewFdbVDYek6emAqCT5ug/E1sPfl s= X-Gm-Gg: AR+sD10sQr9Pvpgwy6mpciItQ2e6pRxnUVIVGa1021EEudDKFaQ4+fZPTGcjGY/v6Mg Kxnxe1fZTyp1jwFDLSp4fkLqbavEeMNB83553Vv/7LwVBYps8kN/wdPLjTx+AmJA/RBA/OylSRQ SrTarKU1XQ2Li1iK0ReIXUnaZFfTqOswpg1n0O3+qKrZqZWxDUdbZsyDFCYuTzmKCSPLk1c0C/v 9IbWKPtaDTlQmkGdIaAM5yHuo9I8eD2v25EFCCMpISuIap5OgIT0aSutr4QvKnGG4aUq5lBiSHh Md6uEvXSgiTjGNarMDR8Pqxl8vNGkMaf5QF6WYY5EolO7sUkPx4JD0KdAhGbdyzWmFKupetbRkJ HeNvgG6dUw/NZGbWPvooqXuCrLJBaav5Uf1aT X-Received: by 2002:a17:90b:4fc2:b0:38d:dfd1:7a8 with SMTP id 98e67ed59e1d1-395c33e1194mr7801566a91.2.1787294190836; Thu, 20 Aug 2026 23:36:30 -0700 (PDT) X-Received: by 2002:a17:90b:4fc2:b0:38d:dfd1:7a8 with SMTP id 98e67ed59e1d1-395c33e1194mr7801532a91.2.1787294190422; Thu, 20 Aug 2026 23:36:30 -0700 (PDT) Received: from hu-vdadhani-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-395c4c3da9csm1787377a91.17.2026.08.20.23.36.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 23:36:29 -0700 (PDT) From: Viken Dadhaniya Date: Fri, 21 Aug 2026 12:06:17 +0530 Subject: [PATCH v3 1/4] soc: qcom: geni-se: Fix endian conversion for serial_protocol comparison Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260821-fix-write-to-read-only-firmware-buffer-v3-1-43e6a3abd651@oss.qualcomm.com> References: <20260821-fix-write-to-read-only-firmware-buffer-v3-0-43e6a3abd651@oss.qualcomm.com> In-Reply-To: <20260821-fix-write-to-read-only-firmware-buffer-v3-0-43e6a3abd651@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Viken Dadhaniya , Mukesh Kumar Savaliya Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.16-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1787294183; l=1231; i=viken.dadhaniya@oss.qualcomm.com; s=20260324; h=from:subject:message-id; bh=nzZOtbt5OVvyXTsuO2enZMGjCyp7ObHjMnPZY+OoxFs=; b=BQQ1wJCWvzeU6abNEBjxhD7QNvPqS3ho1zXZzQ+AXlgB66HbSCIT5aixn1xBTi2RnJDVd3OQx u5r+IVkjLZ2Aa0e1GcAjYs55d6/mhVa47Sh21OLCvKQ45M7rict32th X-Developer-Key: i=viken.dadhaniya@oss.qualcomm.com; a=ed25519; pk=C39f+LOIGhh/02LQpT46TsUSXRvBn9qXC8Xb26KJ44Y= X-Proofpoint-Spam-Info: AW1haW4tMjYwODIxMDA0NSBTYWx0ZWRfX7WkKSGA461QA 4R3t17dVlHR9pjd//JBRE+ILLCqE4O7YqS27KkEyXXVq9HVqewTqReKyaOGTGn0GoQPhawyn+3T mViSKLIthDKL1XshXYIiF6jshntZfWg= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODIxMDA0NSBTYWx0ZWRfX6UPgqvkSH/7n g8XDnf/FaN6gYAovq8J1NddX46DfpGhslBAkgwg58Ou7HRAMJi3bU8QP/CXH6fOVsGBbuJtsA3c vjsNWFtJKpBSNcATCJE2rmh6JYYVq23Sg29V4nYzSSxcd433zOXfo1FyPy0fjZgYyWVSs1247jG LzgRjjVqaxZYhPxJ+RIjNrjeymy8GWUhwCsCn7dRnTkjjfQghe74NYTWOk77F8ihwZBDuAqlmxb fi7kmuura+8jjzQABb34fhoZc/OIr785xW194N7Qj8oHXGjQVPJDevC9UrUDHnxUlR29uvDSnp6 xiSbUQxTHOOZS9PFVNiNC1NeFoHeSKNoW0IjbVOMfIiJBIKui0zIa0WINz2yKdUbYC+w4/Kfu5e nxrpqdmXIeyp+oisTVFcaVHmhFgsgvtwL2KKOHiqIfSNgnKGRymrOVBvuivwYV8rjZioaAIkjU3 GOciThwy750RltkJ7Fg== X-Authority-Analysis: v=2.4 cv=ApHeGu9P c=1 sm=1 tr=0 ts=6a87f1ef cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=BdrV15eiT15NMrSX6N4A:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-GUID: hf_TtNoYRSnHyJMa78yYdACL5wuBi_-r X-Proofpoint-ORIG-GUID: hf_TtNoYRSnHyJMa78yYdACL5wuBi_-r X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-21_02,2026-08-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 adultscore=0 phishscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608210045 serial_protocol is declared as __le16 in struct se_fw_hdr, but was decoded with le32_to_cpu(). On big-endian systems the extra byte swap causes the field to always compare unequal to the protocol argument, so no firmware segment is ever selected. Use le16_to_cpu() to match the field width. Fixes: d4bf06592ad6 ("soc: qcom: geni-se: Add support to load QUP SE Firmwa= re via Linux subsystem") Cc: stable@vger.kernel.org Reviewed-by: Konrad Dybcio Signed-off-by: Viken Dadhaniya --- drivers/soc/qcom/qcom-geni-se.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-s= e.c index 873bfbd6b2b7..1d6e6611441d 100644 --- a/drivers/soc/qcom/qcom-geni-se.c +++ b/drivers/soc/qcom/qcom-geni-se.c @@ -1298,7 +1298,7 @@ static struct se_fw_hdr *geni_find_protocol_fw(struct= geni_se *se, const struct if (le32_to_cpu(sefw->magic) !=3D SE_MAGIC_NUM || le32_to_cpu(sefw->vers= ion) !=3D 1) continue; =20 - if (le32_to_cpu(sefw->serial_protocol) !=3D protocol) + if (le16_to_cpu(sefw->serial_protocol) !=3D protocol) continue; =20 if (fw_size % 2 !=3D 0) { --=20 2.34.1 From nobody Mon Sep 28 13:18:02 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 432B13905E7 for ; Fri, 21 Aug 2026 06:36:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787294197; cv=none; b=lngoqeQApd3MFCMQMJfTOeLkwL6jt52nt4cGMTxwOYuOJ7mmnHcV1WT0yTqzzTKThVeeWmNae4KASNCy2xMc5turQ9P8IpgIlKIReyhc80hy6h6h+7O2iJj8cwRcjxdWlZz11LSSCDw5WRvNjSFhRT+q/wPfQacwe4cN551rGoI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787294197; c=relaxed/simple; bh=gZJAfTY3BHN4SpZtXuYVir/rz1xZsotjK6RAexDWS9o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=REfNCtBDFOUJvcNbW6LjCPX0yx9iihPm64UW5yWpzEUHjJ62DDESMc5n4cTJc2kNJ2rW+4ZpzIGIFp1EaPo1tOGZ+62wlMaxafmKST9S6+wY+k5qrNISPW4gH4X/3lW2gGbwXQcjFLpnz0LlSHDzf9EWDFSjQey7YiDho6og32Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=k2BOWTfs; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AMZQVTB+; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="k2BOWTfs"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AMZQVTB+" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67L5ToX61367005 for ; Fri, 21 Aug 2026 06:36:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Sv4OKfp4ZqCdBoH2aBeZxcxEWRZQzQZoAtKASLW6guY=; b=k2BOWTfsg/hCDozV Yd67REK3AIEz9PftmfB/8RLZk7SLmTetBmJjrz0hWGswNxwl95aKqs8iny5IRDr9 w+cx0Nyg6eEDvCMjJBiyTA5HzhA8xtreWPS63voTd5pT1pOOBHWgYBkoLVP5/XCB EPAcU79tkAqShpFqXXRr0KEjCXfA+3Xd5l9xu3mAI/LIW6kp6QSC5xsvmnU7HJ05 7C6OSXFQ7cNh3jLV69L5/L9V0KyYDwRgs9O3BOXPIuvYtWuJF0m8/n8bg/du7pvK QDHuFuqqgTo6vXl/+o3eigwdijptEQ+21wNgggqdI2pH79EINlv/ezp7oFNanUEr VKMB0w== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g6gdn87fa-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 21 Aug 2026 06:36:35 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-38dde0df80bso1059362a91.3 for ; Thu, 20 Aug 2026 23:36:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787294194; x=1787898994; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Sv4OKfp4ZqCdBoH2aBeZxcxEWRZQzQZoAtKASLW6guY=; b=AMZQVTB+4ZgG8L8gamK00hLDiHv4Yj5+1Y3O43P4mnOmA+9GCOWeYBp1F6lwAc60ne b8x+vrf7fJ7cYPjv0f4saadtBAcpiLUwEVmZLdzjKa0JKjcdXzSnteZ09U9pi06l27pm +SvuSGCuetrDsH4s6j1muXSFh5ks2GilCVOvlVZyVwnWMNSAVc8udw2cxd8iUltCgodK TxldrM4zg6S1NRZYH35aYztk7A5UrLELvWFhqA9nVetX7/1LjxrZEGk+RtmlnlaNELbc LitNLc1g0Q9D+EaxnW0yqdMILYXRMFERMvvZJGWXjE6lAcjLFdjNiXVqlNfu2VKzVphO I8Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787294194; x=1787898994; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Sv4OKfp4ZqCdBoH2aBeZxcxEWRZQzQZoAtKASLW6guY=; b=SYg6PnM2fppVp6al9CgUV5WehQTvmKhTBONzHyYRIiuSXaHnHtcMjMR59Of9+GHD+a 4iHgRZJYFvviiE4HjL5GQZAq9kQ2548HXiNJKbJca2Ep55p64fKTfJUC4RHCLwTGr35h uxS65n7QN/odcR0DHi5YliHZcZIUne8m5wdsoUXwJ007DB/RZWjzI3TOR7dfjKJRgiuU yikWVgrHUMx+GvYZRnccdE5LTTH1ot10eamQG+rJ/7ArwW61DchuhwFVsdK+8k41I2wK CSg4yc2ti9KhrG4BJJulTpVPW5fR/umltiuL3xSGdk1xTR7IhErwPDDQxwH03HSq/vM/ 3adA== X-Forwarded-Encrypted: i=1; AHgh+RoxDmuHyFUMnkXSy08JxT41BeABPtsfeeijCAjY3DV1Fdpk+QW/0Gd1WuuyJqnVKofjRrFznHmjLKvDXSw=@vger.kernel.org X-Gm-Message-State: AFuF++kuur9AJNLOJ1ozvU/eQ+iMav9gyqNb77ZDLiFv0rgd5WnJQe8u yz+yaCA5l++I3ygjUcuS985F5Fk7C4D6K93o2o2V9X4kjauWa0Fwv+eghn5soIUaYCxLGS/NAyw MJ6NC6pcJf7P8JSV1dt8Op7SrEwuqfJO8dtciTX8iiO1ByrP+RqNDLJxi03H/eL6GL7Av+PDT16 E= X-Gm-Gg: AR+sD126r9e9m+lotHh8QppekeHUOvjhpv7FD9qKDzZ8BG5xIUswp2lAXM2G4iYVzXJ TOplaRNjfTZ9+Oz7Q0khjy6f/QpTRuE3O/WiHOWM7PcPzZMwjjviA84/oLMiYCAeLIcjzgFPfE3 UlDDJIXq8ijobeWHDc45Px2YxxhdWbA994k9wDjxkD2Z/j2DKazQBKBxtsCc9WRbnRRS+Y/wvMD 2K6WWNH1BUgNfUgSv5+Q0a6fpcPU0jCduq4ELUWnUDswy4+i7F4O0OJWCgFLfEpTh0WSXoVOMkF yJlzEczBdV/wt4m5dVcWrjIEs6mx4scLLmrjZUechR0M89tVOO5sNTX8OLW3E5pYEmpco7ONaUi n+nNRxcY5DX+HGm3zAgT4qsCm/4hxA28x9ng4 X-Received: by 2002:a17:90b:3d87:b0:38f:837e:fc5d with SMTP id 98e67ed59e1d1-395c334050emr8076481a91.3.1787294194250; Thu, 20 Aug 2026 23:36:34 -0700 (PDT) X-Received: by 2002:a17:90b:3d87:b0:38f:837e:fc5d with SMTP id 98e67ed59e1d1-395c334050emr8076406a91.3.1787294193815; Thu, 20 Aug 2026 23:36:33 -0700 (PDT) Received: from hu-vdadhani-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-395c4c3da9csm1787377a91.17.2026.08.20.23.36.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 23:36:33 -0700 (PDT) From: Viken Dadhaniya Date: Fri, 21 Aug 2026 12:06:18 +0530 Subject: [PATCH v3 2/4] soc: qcom: geni-se: Widen fw_size to u32 to prevent wrap-around Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260821-fix-write-to-read-only-firmware-buffer-v3-2-43e6a3abd651@oss.qualcomm.com> References: <20260821-fix-write-to-read-only-firmware-buffer-v3-0-43e6a3abd651@oss.qualcomm.com> In-Reply-To: <20260821-fix-write-to-read-only-firmware-buffer-v3-0-43e6a3abd651@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Viken Dadhaniya , Mukesh Kumar Savaliya Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.16-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1787294183; l=1169; i=viken.dadhaniya@oss.qualcomm.com; s=20260324; h=from:subject:message-id; bh=gZJAfTY3BHN4SpZtXuYVir/rz1xZsotjK6RAexDWS9o=; b=3GL0AGQcBRvKEQ2JC8Pb3AJIHShOyU5k7vI8JqyFCz0Iy3iD4qbQzBwLYL5nBFBKQ3vtrAi3c 2E4BnGTM619BA8wvMdhmFYO+SpR0Svr2BknTdobZzsK67cumvySYIaL X-Developer-Key: i=viken.dadhaniya@oss.qualcomm.com; a=ed25519; pk=C39f+LOIGhh/02LQpT46TsUSXRvBn9qXC8Xb26KJ44Y= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODIxMDA0NiBTYWx0ZWRfXzWyoQNM7j6q0 leKb+Xi//62zGzJLp7Bpf+x3LUjfmVvr9YcUI1EAAkWW/y6Sc0YVs5Uh9kRGcETpaUXF2/3VV7k RiaUK4Fe1cn8WrZ1A8ysP4NtNOPO7K6elkMCRUZ17Bi7Y0YgtyMiFMg6Zo8JqiWt22BKq0nxEZK QtegXHHwXJCP/i91e4Lp5bYb6uQLA03bTYKPm8YG+bWe10/XI0uBtAmMnmZWMqZlFgDIEmzrY88 Yj5YeT/psj0LfujKG1LY2aU6+GChQaPely5GIewiuFb9/hITkBKAIlSFKV81DbCRN9JD07PmfyH co9mmW5Pw/W77gfohnwNtVP0uKaIkUs5M1GAPb0jNXq/cxD9jG9fyCHabr3nig2xcloHz7WLo/f fQRcVkcbfly+qsSxfBtYXKkA86wTaqtDmULotBhAksz70kyyRN0m1iyM6nRh6FaY42ezfTsddgh PkTzNShMyF7cECUcpeQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwODIxMDA0NiBTYWx0ZWRfX58lvKQ84PSNi ekujLiRi2ByRALHbP0GLbYgw+MocJFFYvqdlBPdhXRA0gYB9iCFU7SuW/8qkpgHjCDbqlJE+w7h YjsY5eLZv9OoGeYdfIbfhcnMBV/RdvM= X-Proofpoint-ORIG-GUID: 5cx-JVc6XD_56hG__deY0qbtPDTUKZx3 X-Authority-Analysis: v=2.4 cv=BJyDalQG c=1 sm=1 tr=0 ts=6a87f1f3 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=65oZO8-CLbckpCt6umIA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-GUID: 5cx-JVc6XD_56hG__deY0qbtPDTUKZx3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-21_02,2026-08-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 bulkscore=0 clxscore=1015 impostorscore=0 adultscore=0 phishscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608210046 fw_size is read from the 16-bit fw_size_in_items field and incremented when the count is odd. If fw_size_in_items =3D=3D 0xffff the increment wraps to 0 as a u16, making the bounds check below pass for a firmware segment whose actual size was not validated. Widen fw_size to u32 so the increment never wraps. Fixes: d4bf06592ad6 ("soc: qcom: geni-se: Add support to load QUP SE Firmwa= re via Linux subsystem") Cc: stable@vger.kernel.org Reviewed-by: Konrad Dybcio Signed-off-by: Viken Dadhaniya --- drivers/soc/qcom/qcom-geni-se.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-s= e.c index 1d6e6611441d..54c0a66d6dd6 100644 --- a/drivers/soc/qcom/qcom-geni-se.c +++ b/drivers/soc/qcom/qcom-geni-se.c @@ -1248,7 +1248,7 @@ static struct se_fw_hdr *geni_find_protocol_fw(struct= geni_se *se, const struct struct se_fw_hdr *sefw; u32 fw_end, cfg_idx_end, cfg_val_end; u32 prog_ram_depth; - u16 fw_size; + u32 fw_size; int i; =20 if (!fw || fw->size < sizeof(struct elf32_hdr)) --=20 2.34.1 From nobody Mon Sep 28 13:18:02 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D2FF3F8ED3 for ; Fri, 21 Aug 2026 06:36:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787294203; cv=none; b=NB5Vo633pFiSZWpGZYYR8yuPfHqmOlrcSx7pUO3GieZCZNT8wYGaX6BcLtz43igavSWZBMQ6mAc5NhVQoKIvNCppALMPDau+7tS6xPwoYs6bZU4mZTCKGQ5YRefQm0ahYtTFE5EFlaAMy3bkuCgCLpVx6BN0NMhKKibTq8s1mIk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787294203; c=relaxed/simple; bh=kEUbBJqe7KY73S/5VTbme4LmRbHaXNvMiB6AKyMb6NU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=A0gZZnw8+uCXodYQSOWlNa+SwJg3eIEiucO1UoPQ9KTPWDUcOzKk5GksAvxT06TxDYikKhX2oyS6EU89JY1Tiv9kp3C6sKQ0b1MMqDYejEwFjyGrxv4zTFh95s3+9UsKexG+eCPY+C3umd3CdrIFNlTgG3N5g6Z0gWCNS3ym/8A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Is5me5vY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AwI6DN4k; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Is5me5vY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AwI6DN4k" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67L5Tit41478260 for ; Fri, 21 Aug 2026 06:36:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5pzpKER50O1NpYiqhCGwCZ+0bZCuJrRVw6p1KzcrdTA=; b=Is5me5vYWUOtjZGp frW+uV8/az3fBgQx2u9kjZqw64jozYDZVGBnOMyezXuq3t/v2q/7dvs/Fg+ww1hr OJuwOUugHEQ4hlPstKSLHGYQoPuKXqoP+CA0DxzS+NOhd2hggaMaH10AGr8WXqQ2 EsLROImk2BKPOItsbs9T9NGL2bs0WLw+LfM5eZrzQMAgeKWtP7bahg+4axfslfEH uXFnPFbh1eQYDixi1Q6si4ShaEg3EnldPZeGIttv6RvIu/fVx+EvaUYZ73Ndg8wn XTtvK3Sc2VaE98OlA5waQRpp3MrmfuYbvTq4bybkpQmHz8Fj/hqgn5LsRyV4qowj Y3hzCw== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g6gddg7pc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 21 Aug 2026 06:36:38 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-38e5a616d07so758459a91.2 for ; Thu, 20 Aug 2026 23:36:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787294198; x=1787898998; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5pzpKER50O1NpYiqhCGwCZ+0bZCuJrRVw6p1KzcrdTA=; b=AwI6DN4kfdUKxCkOQH4yM8hB4iHE7XP3C+Yv8+FjWAWBtgl4Vv1O9pWsxmXlaGk66f h7TWrNLm0Lhyq6kOPSjrqBX6hGyd5MG/caGmk6OrrYTV9sa3DXZManZZ6U4VG2ns+3lK 5ScQWG7idUg8xpMLGG17ZpUDVkf9AG17xVlqlqQbZEp9wmcn3mexueXuTh3EkmD3/nX6 fOPKzLFSiI9vearpTvAF8/ZNVqzOx4OBnQHWhx10howkQm+gmV3l+3/JM62stn2M9bp7 q1y3mxO6Q+Z/PoN5UNsRbG3HAHyOBu+n9HZ0XGyQY61mxMkISrRfJWmoRpgBtMt0NIKW yROw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787294198; x=1787898998; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5pzpKER50O1NpYiqhCGwCZ+0bZCuJrRVw6p1KzcrdTA=; b=npXCWWzO630dtb3jxFIlZzZcbFE03CwFNTKpPGwwz0qSgsB7vzuMbumqyfDKTMmOEX 3TjRlm28Rc3AusRsgwFFV8OE5Z9uajrUaSt7+vTPlN0dTV3CFMnmAGQFlNWARikKzhIX OTa+zFrduqX/Xuy+BRlzOq5sKaivs917C4c3PEMh7JVg1kvNMbJUOS5RXWnv0nN2/TT8 FOe+OD968iZPzLE4Kcvnl//Dyi4nX5SKakVMopvU8j2csQWr0T0yvl2V2BPWDizFIYpV jy+M/vVX6RqGMNWin4OUQSA3DJPdqRVoEfx3S4iYphXNJXHd5GbAyibcxlhx0AEuK/jV Q7Pg== X-Forwarded-Encrypted: i=1; AHgh+Rpk8oJCQjf8Nyse9UpzlppukP7OvbvOBDp+HCSw5UZ5COUmhuAUbUazaAld7h9b2G/fnQYTU1BIflL25bM=@vger.kernel.org X-Gm-Message-State: AFuF++mSqRLhONmouA9fZhCjFOZJkvuLIM3m6rI6rRw8JqReXDAOVI6f P7sZs19x5FENozWbw/uN9mN7R4QApP+HY5FEa6tajHTbVjHn2kG8efe9bky53nypdX5i5viKMjC kFQ3MKEpFh23Km2TOZYja6qxmFU+ziyV1Y1d2Dp1kVAaUAEZdwgkCnwmsiqoQV3Bgh5aB7WO6ZG A= X-Gm-Gg: AR+sD13TX98RPz4Rny0pZiMCbaTAbyIkk/bmSmOW0HOb68tqSEMvSs7NYjm8w08r3Oq 2dwcWNQYL0u4TOI7z+5eKVOv/tepmBPpL+lIwO5/2kLVDV41F/Qyk0zWulF9jBPqyyqn6ClLqwX XT6of6v+gaulsWD218HBW80HIaWO5ZZ8tN6x5KeNynsdRTRfTkmSAikySC1gfFJPNz0ea8kCavV Q2zvGdkSwiSDRixE5tqhKTI525piuirDibRXnc73KWsmqM0G3iBhd3kCGiGz4EAFasntBlkvpW9 uEteXbBGq44kq7E0Fwzp2+SPBWiC4s5PfY/Jxj5zYTUtRkB9WnYTvdBLPJ975HukhfZzYPZyKAQ 5W2PKAgbe6PbolUSYEchGf/ve1hhDM/Zv23oM X-Received: by 2002:a17:90b:3d87:b0:37f:b0a9:1a68 with SMTP id 98e67ed59e1d1-395c3702bc7mr7872544a91.7.1787294197921; Thu, 20 Aug 2026 23:36:37 -0700 (PDT) X-Received: by 2002:a17:90b:3d87:b0:37f:b0a9:1a68 with SMTP id 98e67ed59e1d1-395c3702bc7mr7872465a91.7.1787294197441; Thu, 20 Aug 2026 23:36:37 -0700 (PDT) Received: from hu-vdadhani-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-395c4c3da9csm1787377a91.17.2026.08.20.23.36.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 23:36:36 -0700 (PDT) From: Viken Dadhaniya Date: Fri, 21 Aug 2026 12:06:19 +0530 Subject: [PATCH v3 3/4] soc: qcom: geni-se: Fix fw_end computed before round-up; propagate size to caller Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260821-fix-write-to-read-only-firmware-buffer-v3-3-43e6a3abd651@oss.qualcomm.com> References: <20260821-fix-write-to-read-only-firmware-buffer-v3-0-43e6a3abd651@oss.qualcomm.com> In-Reply-To: <20260821-fix-write-to-read-only-firmware-buffer-v3-0-43e6a3abd651@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Viken Dadhaniya , Mukesh Kumar Savaliya Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.16-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1787294183; l=4358; i=viken.dadhaniya@oss.qualcomm.com; s=20260324; h=from:subject:message-id; bh=kEUbBJqe7KY73S/5VTbme4LmRbHaXNvMiB6AKyMb6NU=; b=JtdkvLnEy9n7MrC4EcG1L6OYoZ4tvq77Etayo1IZ1k0Em+5rgSfivKgWeOH0kyYizQtoCljyh pLJ5UfqaVW1DJ1sWsDwgjiAOTTWz81eSdDGTrmxiol9YwukvYt/Jss7 X-Developer-Key: i=viken.dadhaniya@oss.qualcomm.com; a=ed25519; pk=C39f+LOIGhh/02LQpT46TsUSXRvBn9qXC8Xb26KJ44Y= X-Proofpoint-Spam-Info: AW1haW4tMjYwODIxMDA0NSBTYWx0ZWRfXw75zhMDf13bA +Bhr0jK7VKZXRbsgunnbXSPQ9T3rgzmGh0Uzsqrh62wTVP2MctuKVW74CMfofvhfSlpKjwnqlVE SG6dvArYtwmR2IHVDoKf7wpQuuisfTU= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODIxMDA0NSBTYWx0ZWRfX+BsTQvlvHHHC 93Uvpn0CRUBLU1oPDO87KqJI2N4+8jLxzPeNSdxjr6XwEKEyaSNzkow1cZ1AClabW0zHRD7JQSc 6GwaasY66uZ37mytX10LJFUV+H5oqyuGdGeHUVyq7LjhRCkfnjFfLxvFcGjtpVz79gTiY0Sn1zL BSMBH2JDKElKylf1P2rZFIn6flzw7sXbNfxsI9WRddj5mvM/NFvx1HLCYkcHdYdqpSbjtl8ruaq 1wGw+zpoZKWVW/Jj4xHT59u+XSBmjxmICs4jJZO7/dHkYoB0oxtH/GMrUJHgwJ68TfLbxeG5YTG MiA4yuXjddIf7oLHK9j8Ag8/csmKYS5+OMdunxN+H93jF+IBf92tlJnYZJTzlW2UEy6PAOMSUx+ L7SRItq/u1ppmxzHVxIDiYZi9oPVxlVCAAK0RjCEiIpM/6Y18lld8FzY7Q3KS//tF6OgtA+Gdii YxHLu4W3TXVrWuM5VqQ== X-Authority-Analysis: v=2.4 cv=ApHeGu9P c=1 sm=1 tr=0 ts=6a87f1f6 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=TnNaAZle1ZcGXod9oXcA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-GUID: ROgAEP1LdmRDN2Obyvx2MA9bS5aNZVKK X-Proofpoint-ORIG-GUID: ROgAEP1LdmRDN2Obyvx2MA9bS5aNZVKK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-21_02,2026-08-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 adultscore=0 phishscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608210045 fw_end was computed from the raw fw_size_in_items, before the odd-word round-up. A segment with an odd word count could pass the bounds check at the unrounded value but then be copied one word past the validated limit. Move fw_end (and the cfg_{idx,val}_end) calculations to after the round-up so they always reflect the true copy extent. The caller geni_load_se_fw() re-read hdr->fw_size_in_items for the memcpy_toio() length, bypassing the validated and rounded value established by geni_find_protocol_fw(). Add a fw_size_out output parameter and use it in the caller. Fixes: d4bf06592ad6 ("soc: qcom: geni-se: Add support to load QUP SE Firmwa= re via Linux subsystem") Cc: stable@vger.kernel.org Reviewed-by: Konrad Dybcio Signed-off-by: Viken Dadhaniya --- drivers/soc/qcom/qcom-geni-se.c | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-s= e.c index 54c0a66d6dd6..11ca8223fbcd 100644 --- a/drivers/soc/qcom/qcom-geni-se.c +++ b/drivers/soc/qcom/qcom-geni-se.c @@ -1230,6 +1230,8 @@ EXPORT_SYMBOL_GPL(geni_se_resources_init); * @se: Pointer to the serial engine structure. * @fw: Pointer to the firmware image. * @protocol: Expected serial engine protocol type. + * @fw_size_out: Non-NULL output parameter; receives the rounded, validated + * firmware word count on success. * * Identifies the appropriate firmware image or configuration required for= a * specific communication protocol instance running on a Qualcomm GENI @@ -1239,7 +1241,8 @@ EXPORT_SYMBOL_GPL(geni_se_resources_init); * Return: pointer to a valid 'struct se_fw_hdr' if found, or NULL otherwi= se. */ static struct se_fw_hdr *geni_find_protocol_fw(struct geni_se *se, const s= truct firmware *fw, - enum geni_se_protocol_type protocol) + enum geni_se_protocol_type protocol, + u32 *fw_size_out) { struct device *dev =3D se->dev; const struct elf32_hdr *ehdr; @@ -1289,11 +1292,6 @@ static struct se_fw_hdr *geni_find_protocol_fw(struc= t geni_se *se, const struct =20 sefw =3D (struct se_fw_hdr *)(fw->data + phdr->p_offset); fw_size =3D le16_to_cpu(sefw->fw_size_in_items); - fw_end =3D le16_to_cpu(sefw->fw_offset) + fw_size * sizeof(u32); - cfg_idx_end =3D le16_to_cpu(sefw->cfg_idx_offset) + - le16_to_cpu(sefw->cfg_size_in_items) * sizeof(u8); - cfg_val_end =3D le16_to_cpu(sefw->cfg_val_offset) + - le16_to_cpu(sefw->cfg_size_in_items) * sizeof(u32); =20 if (le32_to_cpu(sefw->magic) !=3D SE_MAGIC_NUM || le32_to_cpu(sefw->vers= ion) !=3D 1) continue; @@ -1306,6 +1304,12 @@ static struct se_fw_hdr *geni_find_protocol_fw(struc= t geni_se *se, const struct sefw->fw_size_in_items =3D cpu_to_le16(fw_size); } =20 + fw_end =3D le16_to_cpu(sefw->fw_offset) + fw_size * sizeof(u32); + cfg_idx_end =3D le16_to_cpu(sefw->cfg_idx_offset) + + le16_to_cpu(sefw->cfg_size_in_items) * sizeof(u8); + cfg_val_end =3D le16_to_cpu(sefw->cfg_val_offset) + + le16_to_cpu(sefw->cfg_size_in_items) * sizeof(u32); + prog_ram_depth =3D FIELD_GET(PROG_RAM_DEPTH_MSK, readl_relaxed(se->base + SE_HW_PARAM_2)); if (fw_size >=3D prog_ram_depth) { @@ -1320,6 +1324,7 @@ static struct se_fw_hdr *geni_find_protocol_fw(struct= geni_se *se, const struct continue; } =20 + *fw_size_out =3D fw_size; return sefw; } =20 @@ -1430,11 +1435,11 @@ static int geni_load_se_fw(struct geni_se *se, cons= t struct firmware *fw, { const u32 *fw_data, *cfg_val_arr; const u8 *cfg_idx_arr; - u32 i, reg_value; + u32 i, reg_value, fw_size_in_items; int ret; struct se_fw_hdr *hdr; =20 - hdr =3D geni_find_protocol_fw(se, fw, protocol); + hdr =3D geni_find_protocol_fw(se, fw, protocol, &fw_size_in_items); if (!hdr) return -EINVAL; =20 @@ -1511,7 +1516,7 @@ static int geni_load_se_fw(struct geni_se *se, const = struct firmware *fw, =20 /* Program RAM address space. */ memcpy_toio(se->base + SE_GENI_CFG_RAMN, fw_data, - le16_to_cpu(hdr->fw_size_in_items) * sizeof(u32)); + fw_size_in_items * sizeof(u32)); =20 /* Put default values on GENI's output pads. */ writel_relaxed(0x1, se->base + GENI_FORCE_DEFAULT_REG); --=20 2.34.1 From nobody Mon Sep 28 13:18:02 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46C5C40D57B for ; Fri, 21 Aug 2026 06:36:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787294206; cv=none; b=G6XZgBa5BkPEmhmdAn5rmIg/eb+tiUCqvhuj1ojZMybWthjwwdcTv5tGtybwM78ZlJgFjxl39rgYCdGwdcrbRnttAF1x/FJpFvGS+Kf4taWXfIWCPK0w5n/O9v5CDyu1pK368QMHsYBVhf/KGUAtr5PtTY5p6qZFFfDBAluDRkc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787294206; c=relaxed/simple; bh=iLOd5yAhK5P2AM+amPAmfpxXe+Bhv9OynPfLmQn11oA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OrCiZBG8IXPkFFA79XVRvZRg08wTq7T/hdfmz4ZLIM578MvD29Dr1z8QqXKI0y46ax09oQ/EwxlFNZzUSyOuJHYNBAtkZk1dDUB6j0qAj/L3qqiHzX2tMbArQ/mycikac7KLa7pwe2/MGnCBBcMJVMTyGi0cB3NVQEmANKZnHHI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DMln0fvs; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=duPizQX7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DMln0fvs"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="duPizQX7" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67L5Tcb41042271 for ; Fri, 21 Aug 2026 06:36:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fjlnSLWR0ywZS5UYemIa8tk6i7wCrwYGJGzNfwUbZLo=; b=DMln0fvsaaYAjKBJ aKIqN8JpY9uoAt8HeBmmh4s6oK0uPCEsg9HDwoQw+YcZU3r0jbCUP/kYjwLWjYUy rjmdi5zI5Q0BbPngDgWp6zQuKvFQ9bXgLZsJRk1QX85TzBtLfSgMdu8e+0ARAlH4 fKvL9bpu+g5QyO656I2If9CRbCjZL2f6rRr2GzlKU7IxThPCOwn8qQCN0POSwaH3 xYtQapv+GRQY54hlATql8TpYLkOIrYhru/rZaHDdfU7ZihCH0SztE7XaiVM5PN1w ZcegV29Cyi9uRX9UAtlRge1NGk7jVXVWwczX9ENlpgCenOM2QBiW6Kd6t6m06ipQ CVcQdA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g6fue0anu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 21 Aug 2026 06:36:42 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2d004f13426so9954035ad.3 for ; Thu, 20 Aug 2026 23:36:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787294201; x=1787899001; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fjlnSLWR0ywZS5UYemIa8tk6i7wCrwYGJGzNfwUbZLo=; b=duPizQX7HvuJXpd+bFCIda7ZkOfaOAWUU2Cx1H1KFnLQ+Yr3sclxHdAl7+JiSoVNdy GNifc/RxvZlOjaIrfKFKbNNEPZkn6BsxsNYquk6mPj+dYKo9cjwW4LN23PSR8bj694+m QtuDdLdOI9BqUmFs/cNvjsHnn5A2qu0ZAnoI+nXBiatoM5FVU+WurGxg+Jc3l/4Nuei8 5TPsfsurnE32lMp5XKEY5XV/jsFfPj0DM3Tp/4b5BMJYzqSgcfDwAgDZM+9jghUfVAoo PeHdxA/UCtoKrMu4nOBhWXZeIFqRcdwI+uvUiwzECpuTdVcY69lbID2Czxi2h4DAKLgp RMqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787294201; x=1787899001; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=fjlnSLWR0ywZS5UYemIa8tk6i7wCrwYGJGzNfwUbZLo=; b=QVYMzOfLnAP8u+oo9vaDRyk5jQM2oNyxTCwNvGf0LlSceGJznkAal0+SLRZwMFW6iS 7Q+5cf8Yq89BK9vsDjmV2PiPHv37HSw8oQVtc9l2uCv8798BjR/6X20JmNQx1yv/nnyd cSssr6uNYHiUNYvU0R+rT8mwnkCkWJA1pWFaJR2fK0vkeAtHtqdmkuryKvCX9gJ67L6R lCHZPAGXFLl5IN7TsgxLt+ruB0krM+ztd+KSaxNqBujNpLzhziIfLAhzCTbnzbavUbxk 057lGHBN4a5AEFuDcmcztfBNJsJfqypxfj4gkMtYk9mn+lGqRUI/6DAfE2Y6cTumHR3m 3XEg== X-Forwarded-Encrypted: i=1; AHgh+RpTTZkSEIo6lnRuKiGshCco+KFqJezkqwgTb5E9hFjiZyhzGHq9v7YCgw+60bS8udJ4ledMAdUlPqZ/tUw=@vger.kernel.org X-Gm-Message-State: AFuF++n/VYwqnw9zYRBmLOPaIjNx3idKsEbDKk+pC9JvEKrvdaifd93A a/gEqs0eoiRfeGnMV1UQV4jmXki0zO/5Z9NjFSBI/W2QUb2IxicuQdiWrSo8s63uURjLoJ2OKQS L8JXCwii7XYdW2LUSnI8+yRQNUhraON0mJuH2eDDAj93UzPhtxLtzGfnxfxcDZiHKlQPhbrzA6D w= X-Gm-Gg: AR+sD12/7YUKcPLuKZEt25AhV2b0T0u0WNJ0Ku7zZAojVdVGLGNBnV0xqNJfSIx/WYO Mxjmy6/OszmSUqEiqHcovdHBUBe+ZzGoBC79MX71Owrdj2NG8qQHQafg2mzCXDuFn5FxnOret6W 78YkJUOnG2Rac8+S7XIOv+cqUWU5xSRn1DnIpBPJR7MfEV+wv5NJ5g1bd/mlgxcLF/HXVPdfXxF 3qB+YYQG+VxwjPeh4spcRc0mcP38VZatb/ATvB4CoS+2LBjFWZ+E5ANsyBLww2K407IVyltR51T SUhd1H8JrYn/kDdMUOuR7+ndoyydX1VQg6Hemn/aLeWbl6wwtkwRszZkK7I3a/Xz/wvdMVGoHxN 3oQI0v7SmOYhqpVATnJPVjhJ+ztLBsw3Mv4WQ X-Received: by 2002:a17:90b:1c90:b0:393:19a3:4f1 with SMTP id 98e67ed59e1d1-395c351d788mr7451310a91.6.1787294201407; Thu, 20 Aug 2026 23:36:41 -0700 (PDT) X-Received: by 2002:a17:90b:1c90:b0:393:19a3:4f1 with SMTP id 98e67ed59e1d1-395c351d788mr7451223a91.6.1787294200881; Thu, 20 Aug 2026 23:36:40 -0700 (PDT) Received: from hu-vdadhani-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-395c4c3da9csm1787377a91.17.2026.08.20.23.36.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 23:36:40 -0700 (PDT) From: Viken Dadhaniya Date: Fri, 21 Aug 2026 12:06:20 +0530 Subject: [PATCH v3 4/4] soc: qcom: geni-se: Fix write to read-only firmware buffer Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260821-fix-write-to-read-only-firmware-buffer-v3-4-43e6a3abd651@oss.qualcomm.com> References: <20260821-fix-write-to-read-only-firmware-buffer-v3-0-43e6a3abd651@oss.qualcomm.com> In-Reply-To: <20260821-fix-write-to-read-only-firmware-buffer-v3-0-43e6a3abd651@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Viken Dadhaniya , Mukesh Kumar Savaliya Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.16-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1787294183; l=3808; i=viken.dadhaniya@oss.qualcomm.com; s=20260324; h=from:subject:message-id; bh=iLOd5yAhK5P2AM+amPAmfpxXe+Bhv9OynPfLmQn11oA=; b=rXFeKi5e1CFPsN0AH08chsQJ2dOpv4QwjMLEg/IdQLXylj6qU9RjFrMEUGl6eBUlfZY8VUnyg lhxJa0pXbVpBTS98NE9EBLLvJwb3GoRCbSNgO59JF6LictlPvYMEL3w X-Developer-Key: i=viken.dadhaniya@oss.qualcomm.com; a=ed25519; pk=C39f+LOIGhh/02LQpT46TsUSXRvBn9qXC8Xb26KJ44Y= X-Proofpoint-Spam-Info: AW1haW4tMjYwODIxMDA0NSBTYWx0ZWRfX7J5FU75EmKrb zc90BLsiC0FZ7fC/wBwPl1kIdhPLNinuKw//LeXq/UzKDbV7MAF3+osbR5nxhjzAFbblDNNXgN6 51TkI4tUANJSApGHaW8VK6lHjk9GEZ4= X-Authority-Analysis: v=2.4 cv=U9+iy+ru c=1 sm=1 tr=0 ts=6a87f1fb cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=jfHSOdyuYKquJek64F8A:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-GUID: AXV26ELwHrxxFAJ4RfWUK4qUXSKxOfqG X-Proofpoint-ORIG-GUID: AXV26ELwHrxxFAJ4RfWUK4qUXSKxOfqG X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODIxMDA0NSBTYWx0ZWRfX2dCqhI6c64/4 oSMb3E6m8ynvl9gs+XqaN3/5detFo8UVTybtH1eWzEeOmbY/cLUNiIltW/rq8GYRdmOGStcLlXi EhSqJ2oViW2mS6cplaW4dtBzmhZF17p41xZEswbKlMHroC96Z6+mxcxOaJ6Z6URSZJEI+a18Krm L1jgEKYBUFZS9c47omrl8SS/2bn84R5RCw4pGbVY1+G/mXO/W1PK4d3kTfYc8zhcUBjgMfm0Zb5 sMgBZjeFvIgsSoXpAMHEhCX1XLRiqOhx2LWt4T4PgWknzmUa4pbZJDOTGTq45l03Jih+exk6pVl sdaYd7Y46eZbYhI2Swvp+vyMZzo9bKNH2Zs+WaFDOZ66nYxLwRPcwsR15phKMEIpLWnUpX/PVSG x7/HknI2ptFUKmtKDMlZiGeCLmh5DT6NmnhcRHNn2zwbwNR4jp4oQWoCESEyWYesjJzHKhejE8t eUx5zRs7wUL2vGN/Tag== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-21_02,2026-08-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 malwarescore=0 phishscore=0 suspectscore=0 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608210045 geni_find_protocol_fw() casts fw->data to a non-const struct se_fw_hdr pointer and writes back the rounded-up fw_size value: sefw->fw_size_in_items =3D cpu_to_le16(fw_size); The firmware subsystem maps the firmware blob read-only. Writing through the cast pointer causes a level-3 permission fault on AArch64 and crashes the kernel during driver probe. The write-back is no longer necessary: geni_find_protocol_fw() now propagates the rounded size to the caller via fw_size_out. Remove the write-back and make sefw (and the hdr pointer in the caller) const-correct. Fixes: d4bf06592ad6 ("soc: qcom: geni-se: Add support to load QUP SE Firmwa= re via Linux subsystem") Cc: stable@vger.kernel.org Reviewed-by: Konrad Dybcio Signed-off-by: Viken Dadhaniya --- drivers/soc/qcom/qcom-geni-se.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-s= e.c index 11ca8223fbcd..6ac2bdc16984 100644 --- a/drivers/soc/qcom/qcom-geni-se.c +++ b/drivers/soc/qcom/qcom-geni-se.c @@ -1238,17 +1238,17 @@ EXPORT_SYMBOL_GPL(geni_se_resources_init); * controller. Validates the firmware size against the hardware PROG_RAM_D= EPTH * read from SE_HW_PARAM_2. * - * Return: pointer to a valid 'struct se_fw_hdr' if found, or NULL otherwi= se. + * Return: pointer to a valid 'const struct se_fw_hdr' if found, or NULL o= therwise. */ -static struct se_fw_hdr *geni_find_protocol_fw(struct geni_se *se, const s= truct firmware *fw, - enum geni_se_protocol_type protocol, - u32 *fw_size_out) +static const struct se_fw_hdr *geni_find_protocol_fw(struct geni_se *se, c= onst struct firmware *fw, + enum geni_se_protocol_type protocol, + u32 *fw_size_out) { struct device *dev =3D se->dev; const struct elf32_hdr *ehdr; const struct elf32_phdr *phdrs; const struct elf32_phdr *phdr; - struct se_fw_hdr *sefw; + const struct se_fw_hdr *sefw; u32 fw_end, cfg_idx_end, cfg_val_end; u32 prog_ram_depth; u32 fw_size; @@ -1290,7 +1290,7 @@ static struct se_fw_hdr *geni_find_protocol_fw(struct= geni_se *se, const struct if (phdr->p_filesz < sizeof(struct se_fw_hdr)) continue; =20 - sefw =3D (struct se_fw_hdr *)(fw->data + phdr->p_offset); + sefw =3D (const struct se_fw_hdr *)(fw->data + phdr->p_offset); fw_size =3D le16_to_cpu(sefw->fw_size_in_items); =20 if (le32_to_cpu(sefw->magic) !=3D SE_MAGIC_NUM || le32_to_cpu(sefw->vers= ion) !=3D 1) @@ -1299,10 +1299,8 @@ static struct se_fw_hdr *geni_find_protocol_fw(struc= t geni_se *se, const struct if (le16_to_cpu(sefw->serial_protocol) !=3D protocol) continue; =20 - if (fw_size % 2 !=3D 0) { + if (fw_size % 2 !=3D 0) fw_size++; - sefw->fw_size_in_items =3D cpu_to_le16(fw_size); - } =20 fw_end =3D le16_to_cpu(sefw->fw_offset) + fw_size * sizeof(u32); cfg_idx_end =3D le16_to_cpu(sefw->cfg_idx_offset) + @@ -1437,15 +1435,15 @@ static int geni_load_se_fw(struct geni_se *se, cons= t struct firmware *fw, const u8 *cfg_idx_arr; u32 i, reg_value, fw_size_in_items; int ret; - struct se_fw_hdr *hdr; + const struct se_fw_hdr *hdr; =20 hdr =3D geni_find_protocol_fw(se, fw, protocol, &fw_size_in_items); if (!hdr) return -EINVAL; =20 - fw_data =3D (const u32 *)((u8 *)hdr + le16_to_cpu(hdr->fw_offset)); + fw_data =3D (const u32 *)((const u8 *)hdr + le16_to_cpu(hdr->fw_offset)); cfg_idx_arr =3D (const u8 *)hdr + le16_to_cpu(hdr->cfg_idx_offset); - cfg_val_arr =3D (const u32 *)((u8 *)hdr + le16_to_cpu(hdr->cfg_val_offset= )); + cfg_val_arr =3D (const u32 *)((const u8 *)hdr + le16_to_cpu(hdr->cfg_val_= offset)); =20 ret =3D geni_icc_set_bw(se); if (ret) --=20 2.34.1