From nobody Mon Sep 28 13:18:03 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DFC248B389 for ; Fri, 21 Aug 2026 11:44:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787312661; cv=none; b=fgniBld1jBZIx1ICfwRYpGOLNS+QAR5SFlNJAIekdC3DChXT+FjgV//XVi5t/Ht5Ij5kKnUkjBZoDGUpyNz6NZiv5/frRYa5mpNNfimOaSJGLM7DiPeLJxai6Rbo6gILgfLhFZmj7WTo00l5jDS+vYRoRybllwvcqNmHUgIZF78= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787312661; c=relaxed/simple; bh=mw69rgogv25Vpqgd3XtEuUAi41G1udw7Gmgj1TV2LTM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=iWEIupiVakvPkaIS97qI3Z0ic1zEGVyQxvlDaTxAoVp49y/Vs92ewoYXz0FV6eCmTWDngNuFZlrg9IIOAmqZYvzkcOO1fbdVfTxwcSv33xF/x+KEKGCYhRzEKizX0/qhfZyO6p4dxTaOSUIF/KEw8RZNy2Npymhx7bNUGxWvWXA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=J/hD0f0s; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="J/hD0f0s" Received: by smtp.kernel.org (Postfix) with ESMTPS id A1750C19425; Fri, 21 Aug 2026 11:44:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1787312660; bh=mw69rgogv25Vpqgd3XtEuUAi41G1udw7Gmgj1TV2LTM=; h=From:Date:Subject:To:Cc:Reply-To:From; b=J/hD0f0sao1bImlmF1Tj0zpOJ4bBliolmzMJYNxkhCFYc4RDYdazM1etOHp/miR9j leLq7G70IiisjU6tFxl5ntTK7w8eZzs20GTq/AGfz3Wdni19FF+z8firy7VZHWGqOV YX69smMUZgG4Yyb8+V+3R/CqF7Gd47D/euvElBP9QBMJmPTHUVOmJJNaHrNw48HzbZ HmykMlk/FC9GgI2YID73X/ToUAW40W76cMBCJtOSdLSTKnTfN2KuiAmBSuWW745wit C6euo69a8luxWFYCFF9a2B0qN7B6wWE5rCCb+Syj/vYvLdspJBalAtzEabk+HnvIo8 Tbpy/olpBVMwQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D2DFC5DF89; Fri, 21 Aug 2026 11:44:20 +0000 (UTC) From: Jason Yang via B4 Relay Date: Fri, 21 Aug 2026 19:44:19 +0800 Subject: [PATCH] phy: rockchip-samsung-dcphy: Enable runtime PM at PHY core level Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260821-dcphy-rpm-v1-v1-1-a7db728b2539@gmail.com> X-B4-Tracking: v=1; b=H4sIABI6iGoC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDCyND3ZTkgoxK3aKCXN0yQ11Dk2QLg5TE1OSkNHMloJaCotS0zAqwcdG xtbUA9ZQPJF4AAAA= To: Vinod Koul , Neil Armstrong , Heiko Stuebner , Sebastian Reichel Cc: Heiko Stuebner , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Jason Yang X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1787312659; l=2166; i=jason98166@gmail.com; s=20260721; h=from:subject:message-id; bh=rV+NofLh7S6yCChqGRpahjAqRQEXtDM0htO9np1Bxqo=; b=57lr4YbeWUQV/oNo07yMtqo7IjzVndgDcWGOgaLPrTo3CyHIsAirw6wRlUFdK8mWyj0DJbew5 /a7QHFJ7gIHBi6hFxN2KWVW9a6aXFhoO7j4aDFXxQy2pX4JkjZHmv/N X-Developer-Key: i=jason98166@gmail.com; a=ed25519; pk=xQmD001Q/ooHl39PxyQtusbUQmgbOsSfpFryRVWZ/k4= X-Endpoint-Received: by B4 Relay for jason98166@gmail.com/20260721 with auth_id=887 X-Original-From: Jason Yang Reply-To: jason98166@gmail.com From: Jason Yang phy_create() only enables runtime PM on the new PHY device if the parent already has it enabled, and this driver enables it afterwards. The PHY device therefore never gets runtime PM, and phy_pm_runtime_get_sync() returns -ENOTSUPP for every phy_init() and phy_power_on(). The block is still resumed today, but only through the supplier link fw_devlink builds from the phys phandle, which fw_devlink=3Doff and =3Dpermissive do not. Move devm_pm_runtime_enable() before devm_phy_create(), as done for the sibling HDPTX PHY in commit 10ba8479f460 ("phy: phy-rockchip-samsung-hdptx: Enable runtime PM at PHY core level"). Fixes: b2a1a2ae7818 ("phy: rockchip: Add Samsung MIPI D-/C-PHY driver") Signed-off-by: Jason Yang Reviewed-by: Heiko Stuebner Reviewed-by: Sebastian Reichel --- drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c b/drivers/ph= y/rockchip/phy-rockchip-samsung-dcphy.c index cbd780556da8..11e872cc6611 100644 --- a/drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c +++ b/drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c @@ -1610,16 +1610,16 @@ static int samsung_mipi_dcphy_probe(struct platform= _device *pdev) return dev_err_probe(dev, PTR_ERR(samsung->grf_apb_rst), "Failed to get system grf_apb_rst control\n"); =20 + ret =3D devm_pm_runtime_enable(dev); + if (ret) + return dev_err_probe(dev, ret, "Failed to enable runtime PM\n"); + samsung->phy =3D devm_phy_create(dev, NULL, &samsung_mipi_dcphy_ops); if (IS_ERR(samsung->phy)) return dev_err_probe(dev, PTR_ERR(samsung->phy), "Failed to create MIPI = DC-PHY\n"); =20 phy_set_drvdata(samsung->phy, samsung); =20 - ret =3D devm_pm_runtime_enable(dev); - if (ret) - return dev_err_probe(dev, ret, "Failed to enable runtime PM\n"); - phy_provider =3D devm_of_phy_provider_register(dev, samsung_mipi_dcphy_xl= ate); if (IS_ERR(phy_provider)) return dev_err_probe(dev, PTR_ERR(phy_provider), --- base-commit: 1590cf0329716306e948a8fc29f1d3ee87d3989f change-id: 20260821-dcphy-rpm-v1-14c80daecbf7 Best regards, --=20 Jason Yang