From nobody Mon Sep 28 15:33:27 2026 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 606143D7D8C for ; Thu, 20 Aug 2026 11:15:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787224524; cv=none; b=guOPIeinsq4R3//vEsy+/PbyGKRgLLlrAO28nGrzV2sEuxJIcXDVg4VtcZSOfv/fmwhCNqfewMGt/LOdGUkUxCHhR618jfPmdbNsmBGavgr8XefnsWullb5KmSD0C9nOqT2ke+YEnK19HEUOab3zZZAn6pWz4BJ2/KICj8pgxrQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787224524; c=relaxed/simple; bh=3uDE4EBPIrEu/wlRDQMGu8LdJv+K8TTLdEoIbXB62jY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=o6rntf4WKif0rXeSp6q+VDbd+s+z6eJ7/RFHBdIA0H7NNYOn03AIhIRm8LFYh+XG4lKcza7nTvlv/JCjPsvJztuFV8HaCNLRPHmSQbqGLxM6hWMXHGIp0aRysd2vYW4Lv890HM7DtIsa462WrWiVkNlx+BgQeXD+eylZLId5TmQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qedqFoz3; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qedqFoz3" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-cbedbaba5fdso1080596a12.0 for ; Thu, 20 Aug 2026 04:15:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787224523; x=1787829323; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BpV7OrLLJSmZ27VksgMp3lb1FLdxWSw9DXcxUIDAfzY=; b=qedqFoz3rN62rk457GrvMTkSFB4v2rMlmJQ7igPidq5l9IL5b4woOq5+/e7zSjW91c GYWkHAe3+XmPZ1xEmJhLhRnDy1dZNCyvdw4qiCuVdrj1+OsYF1kzfoQC3hx4D7j3UwJc t8Kmkh1XEiF5grSS5TQU4AnHvSEMayWJN29WaPH23ksr4b9RxZGLLApbRKYShNquf+zG 89uEX4A0txhntiPhjbBxOa8HoE3zj5CMbFiP6o6sKiOmiE4q3TAqjZGJECOHqVFKiCtF su3Qnml0Ce2EoQYcwNFJDqwH0p7xwS+wvJIBnrmbD10FaEbZ2obzDOHYGNPZBzAUNyc8 X3wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787224523; x=1787829323; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=BpV7OrLLJSmZ27VksgMp3lb1FLdxWSw9DXcxUIDAfzY=; b=chityiTFpvrYZ7lehXAlfYv6PlTrryyqwdFTQ6Y0lDFyIkdrzYECc/D25vGvTY249Q JzxX1aFBPX1KgB8n4bdM2269tympV2zzmPcjD9yULQVGP4juu0oQ2jqJPNGJpwCPom0h vvvy9EHhJZ/s8kRktnh4/JEWHVBQfIWRW5yDEhR3l5M1icHi58K+6bjATsM5Q5hVzUvt i6lpuGKw5kFEAY6bQ17lM142n8h7BkjTd3IPBQt+V0JMebDugZxHGiOa5mKllnwN9tnp upe2+gbEzRvb+Xwe0dPQpu6SVWEa0RhIqF5PfKve9jprHVTDtrC3NOTc3OAK8dcFK751 2yhg== X-Forwarded-Encrypted: i=1; AHgh+Ro1OrVH2Kuen/F3AlvPXQZgTeTtpZXfENg3WkVVnrMVuuUC8W2yBjgg5HRRUCmbOB49Ylzi/iusLbiLb+I=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4loUKc8cKrvkkYBFGBbMxnx6VIqsqLXd15XUZuzdphilBqkfz cuZCyH9wrXI6GjJ2vavknZc/UJ0PRs/R/Ol4zLMImZiFhtPBva/RGryV X-Gm-Gg: AR+sD13nuVVv/m2QBudOSpykPPG3AhO9djLQ9MFKXykhxUrqPTcB7RnXeTX8Pb1pdts jha0F3yANQuwdruQtHnqn3bUQep4vXZagxtwRZsCT/WWBx1ghuVSl/xlOdNf210YpTYmb1paQCs rBFfazBzZJeYBO5CQTdDilNvNqwSWq0u5h+H3QS36GOcrm39ukp5dyU5Kd81V+E7/1KsNUqCpSN Ha1Dxa/qHO53TWvXDYoa9i8LoiIFZ3X9N6NqrXNSgURnidVuvmybuqxSHlhd2SMYgC7uwD0o8/3 kjd614nnL+LqQbt7Mluv+zC9w7k09U0v0zhTwrVxeDd3xLSfLDGya+5oukf9jAHSVCLxIYJWRAI dWiYmfD9l93wJeigdCrRX9Y27WjENQY0iZ8l/nBkHEMvaTHmv4vOp3qed8FqNnkvNHoKix3vpUy BLj6MMgFAJzSbLIwOfp5BQD2in8AB3Wr+9ouSMkV7ZLHOmFz77K6kR93bZTj3umffr96/GJQw2f mq//rt7IV77opKjRWorWehHBI1cYxebpThzRNosKXl24SxYtFTBHSD2pprrDaR2ghWg1oBk/i8d mgtiqCagDg== X-Received: by 2002:a05:6a20:2446:b0:3c3:b57b:6459 with SMTP id adf61e73a8af0-3cd0107f1eamr23055896637.7.1787224522634; Thu, 20 Aug 2026 04:15:22 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc15568c722sm1676503a12.24.2026.08.20.04.15.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 04:15:22 -0700 (PDT) From: phucduc.bui@gmail.com To: Justin Chen , Florian Fainelli , Doug Berger Cc: Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Broadcom internal kernel review list , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bui duc phuc Subject: [PATCH 1/4] net: bcmasp: Use platform_get_irq() for IRQ lookup Date: Thu, 20 Aug 2026 18:14:53 +0700 Message-ID: <20260820111456.97947-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260820111456.97947-1-phucduc.bui@gmail.com> References: <20260820111456.97947-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc The platform_get_irq_optional() function currently returns all negative error values without distinguishing between the case where no IRQ is available and actual errors occurring during the IRQ lookup. Use platform_get_irq() instead, as it matches the existing error handling by propagating any error encountered during the IRQ lookup. Found by manual code inspection. Signed-off-by: bui duc phuc --- drivers/net/ethernet/broadcom/asp2/bcmasp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp.c b/drivers/net/ethe= rnet/broadcom/asp2/bcmasp.c index 972474893a6b..d66a8bbd6e38 100644 --- a/drivers/net/ethernet/broadcom/asp2/bcmasp.c +++ b/drivers/net/ethernet/broadcom/asp2/bcmasp.c @@ -1094,7 +1094,7 @@ static int bcmasp_get_and_request_irq(struct bcmasp_p= riv *priv, int i) struct platform_device *pdev =3D priv->pdev; int irq, ret; =20 - irq =3D platform_get_irq_optional(pdev, i); + irq =3D platform_get_irq(pdev, i); if (irq < 0) return irq; =20 --=20 2.43.0 From nobody Mon Sep 28 15:33:27 2026 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 773BC40EBB6 for ; Thu, 20 Aug 2026 11:15:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787224528; cv=none; b=e/6desTGS57EiIvCdK7dn0tC7Fbtzy3mWkZcGYliADokZg/xq6xQwfisulLY2My8ZcO+sS69sgi7jOXBwqC/KRcKd0icHmu8v4ALQgIhUHCiHbK3oOqrgMgmxiwuM30M3iix5gMD86Afs4mS8pqhAyhlLISS3JQ5dGZjdFQ7F8M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787224528; c=relaxed/simple; bh=bnOez2D7W1xADEeYSlrlChjQSRZM4eKefXSq81oer5U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EYfGC0s7FSoBbf66csxA5SjnqkJi8uL39P5AQ86hIcQqRQ3vb8gpaGErbiC6j+XJ0z8EZgcC3AZA/cq9ltBZIFO+Sl1vxTGFsdNWih0XFjy5xQvbfVMUlbSe7hEOZg5GdsKRnuz+/UAt+d7xm58nIuuDj0P8vYN7OWbDRZCzo4s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aJKFpWqA; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aJKFpWqA" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-c9d1fff21edso1373120a12.1 for ; Thu, 20 Aug 2026 04:15:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787224527; x=1787829327; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0EV4ghgeCZRM5rzTYzzjwsX6ZmAWQhJnMm9mekXvTWM=; b=aJKFpWqAKakPkQJC+b4Qf47S8gAU0AqtM4dwYAwgz0caF5GLBtx+M8b8hqNe739do8 MFuwJ563FGAoeDd4DfKPKJMH+miUgHFm4WY9fDBZkxvQO/hCVs3JAoPQfSCQemtHsSrG GBnR/YIj+1s7kZi8x5kBOfRGnpSw+OnhwinyQICY/uftwqj/1OOLd2/O+T0nymyyqDqw rr6f71ZM1SR58xReT9vGPeNazF14aqE828Rt0CgaH1qgIsqfhRLjRLq2zC93STsmnFXj 61tIiF6dT83TH4kRJWg33XTPhXPhzAypfTbt5FW3omP4zaq/8Ap7wErapfCGBa1JYhOl hpIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787224527; x=1787829327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=0EV4ghgeCZRM5rzTYzzjwsX6ZmAWQhJnMm9mekXvTWM=; b=MyD0mq9arcdsbjKkUfbbnhZm84KGKhoXAMEOpfOpm8m0iPO+AMbxthePgD1U1XWKM2 oZDSIbKRrECoheXrOMfjixazKu1p/yXw0LLyKZJYYYRjLWpLEKyI0WCIvT4QkaZQdBOR 1f6k5b/s9KqDZbbOKBNGnJNFb39PVMAIP4l8Rdt/hZlVUUqEfjQRmlarooz51e2a64iF OqiOUXyht9nshxrcYL75aryBA/RlWFFeuqHIHrm3Z0cPe6HiXSKgVdgbzG3uNH2JEV+L MUY5DrsNh5XVAeF0euEaT6d+JkDr5OWYLjpWYHPVoojqR2nYJc4T3yRSABLQm95y64yW tEWw== X-Forwarded-Encrypted: i=1; AHgh+RrHahNBTvkXBrG667NwqIYRfw6XjGSUmP54LakX/14lmMljoSjnYOPOps03VnQWwIz81bfiIIEFBVOrOB8=@vger.kernel.org X-Gm-Message-State: AOJu0Yyobawhy3R+tfnOAS6+keOXCetmJ0KX5Zg2982erBAPSisOR5If GZkcNAiO67nUUjuAGOYzoqygH5XNqBXaUqYpVQDIY3FSMVUPW2QrtOWy X-Gm-Gg: AR+sD112wlVzmJ2OMa2U+D+go0QwlNIo7EoEViFnWUIg/mHtxKWFBynJkMzGZD4tJpG EpXQL783G+At9tC2aJswdqQKzkYxArp37XgHw12bmHd2AeAnlcdoAt3T/pQo9okmcCN8tJ33Tmj J4VeTgy7/9aUnOB9UWoR1o6j0HiHL7s41cdUv2CO1uESTTLd7kOk3X7TkZV9h5kgEoHILLVejpg HFPJjLD5bpJrAOCXmCeNhdko22lEU9yakGE2R9swdWqMJc8sWTsS5wJIaeDhbOnwSXR0npvLRnO HMPwjJiX4Bxw2/hEymw4oQGv8uJd0kUxCr0v+7w/imVNsRCfoSxcuJ4vJ9QApWaGXb3ZOgaLZrP aYtZw/Rcqgndd9ax490Q+sw2iGL2DMaZoLupH9u0bj1KoJS8FpX6NGSo2H+4u0HtlRJ6Z4bUj6h 4cbdO7FE05EJbeUVwUaAJ9HBbo04JeUjvszMnfV+THiFRvbzBOPChLzOJlP+lQy+ri/FBwHtKRO LbdZcSf6tCQHkGZUPugoSAR116FWAl1Cm7u0bHRmJuOOvpe0ZvVGFuWRoQNDZbxTJ8HYjCjdDr/ efcM X-Received: by 2002:a05:6a20:2443:b0:3a0:bc61:62e6 with SMTP id adf61e73a8af0-3cd010d6404mr21262791637.8.1787224526694; Thu, 20 Aug 2026 04:15:26 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc15568c722sm1676503a12.24.2026.08.20.04.15.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 04:15:26 -0700 (PDT) From: phucduc.bui@gmail.com To: Justin Chen , Florian Fainelli , Doug Berger Cc: Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Broadcom internal kernel review list , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bui duc phuc Subject: [PATCH 2/4] net: bcmasp: Propagate WoL IRQ errors from probe Date: Thu, 20 Aug 2026 18:14:54 +0700 Message-ID: <20260820111456.97947-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260820111456.97947-1-phucduc.bui@gmail.com> References: <20260820111456.97947-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc bcmasp_init_wol() currently ignores errors returned by bcmasp_get_and_request_irq() and allows the probe to continue. Return the error from bcmasp_init_wol() and propagate it to the probe function instead of silently ignoring the failure to initialize the WoL IRQ. Found by manual code inspection. Signed-off-by: bui duc phuc --- drivers/net/ethernet/broadcom/asp2/bcmasp.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp.c b/drivers/net/ethe= rnet/broadcom/asp2/bcmasp.c index d66a8bbd6e38..02e88adf4939 100644 --- a/drivers/net/ethernet/broadcom/asp2/bcmasp.c +++ b/drivers/net/ethernet/broadcom/asp2/bcmasp.c @@ -1106,21 +1106,20 @@ static int bcmasp_get_and_request_irq(struct bcmasp= _priv *priv, int i) return irq; } =20 -static void bcmasp_init_wol(struct bcmasp_priv *priv) +static int bcmasp_init_wol(struct bcmasp_priv *priv) { struct platform_device *pdev =3D priv->pdev; - struct device *dev =3D &pdev->dev; int irq; =20 irq =3D bcmasp_get_and_request_irq(priv, 1); - if (irq < 0) { - dev_warn(dev, "Failed to init WoL irq: %d\n", irq); - return; - } + if (irq < 0) + return irq; =20 priv->wol_irq =3D irq; priv->wol_irq_enabled_mask =3D 0; device_set_wakeup_capable(&pdev->dev, 1); + + return 0; } =20 void bcmasp_enable_wol(struct bcmasp_intf *intf, bool en) @@ -1321,7 +1320,9 @@ static int bcmasp_probe(struct platform_device *pdev) =20 bcmasp_core_init_filters(priv); =20 - bcmasp_init_wol(priv); + ret =3D bcmasp_init_wol(priv); + if (ret) + goto err_clock_disable; =20 ports_node =3D of_find_node_by_name(dev->of_node, "ethernet-ports"); if (!ports_node) { --=20 2.43.0 From nobody Mon Sep 28 15:33:27 2026 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78FC141B8D0 for ; Thu, 20 Aug 2026 11:15:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787224532; cv=none; b=kaZR+9rs8P3an0DKcJweivYMOET0jiSkxCenQ8EeLZXzNA8ga61LKjJK3/s+QBjhd0JjcEXXFELgfKGD8F8L+ATcVx/2EHX3qKP1ThPYUH1aPhrc5/g1mbATXU5ye0K9XsioRq6QXbt9Hm9vjUKwNQLYJLJO3BC7hAtj1jZuQAo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787224532; c=relaxed/simple; bh=o5CuQsLtqAHkVCYO0+td7xiYDLntqu61PDPsgViuQIY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Cl1SBvoNZ0eZ2pekEKGuDDullHXP5j5aBZdRVDi6+2oGvGF9m+5uODiS0Sxm15x2K7Y/clzg4TZox5eNK5XE1kFO7vXjERwBkww9MJm9gJTNlq/YuKzLESZOSBjtqxB1KNNLSIbfkI38MOP4gSi8Wjlrk7GkkpIC6Bm0aQq7Xp0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=efpxZWKj; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="efpxZWKj" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-cbedda4c154so965856a12.1 for ; Thu, 20 Aug 2026 04:15:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787224531; x=1787829331; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kXwo8eezAKAf2A4o/+O3GLjl9XPgejnrObTpGultTzc=; b=efpxZWKjmdjKc8Rgl4dBxb8pRxaF5owqeizHklNX3qIps4/V/E+yHT6K4fCdcXzKT8 5VPOigTn7Q8QD7dFe8uVldtFVfHTfDNURJgj/tvvciQXRNB8qlxowzReqgS+nr1wZT0K cWmlplD+y6xdIAl3iFiMupZQUHPQwJPt4bUxDXthshme4QsyGZbfH6WIjq7pcHlb4ZPh VegLNLRE8AjsiKcG3b1FwEMih6QvDMhQe6Mifr/GgoMmPmRzI5WRc9QgpFI7qZmK6M4v vwRHFK1BUKMkHoil+KH3jNAg0FWe6ZUQAFlhmAqeKkcvJ+SfgOhKEBEdildVoObr80x8 257g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787224531; x=1787829331; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=kXwo8eezAKAf2A4o/+O3GLjl9XPgejnrObTpGultTzc=; b=iOGoTWUeGukX7DyLIS9IRI3RDDLexWhCBsxzYQ+X6FJEANB1YigXHrqMg+ENTjfnyZ EyuMZ16L0kbMNbyC+LtHA6ZIrM+xMRcmvoKfnyUtVzmMQGxkH60Z+w2p08ceZ8mFDbGT YrqFNZp3dG9dmEebdpD9zUVTaW4P4mhKhclzV6C/rMn6D8fUOEtz8ERxYRPgt1WE3+WZ TxQWDmPMqYoJw03aEEuYTpX+msGO19qgyRToyIEBpO58+WuxMuMeHItGWiOJbXEUZEZ4 XhV6KYaP19WbHvG397miju5R7Eqi8PYgLb1yuXBG9JFTe5TU9ekAEbi6BtrauYfRAcQ5 SZ8A== X-Forwarded-Encrypted: i=1; AHgh+Rp3LMUsomzlXRrf8503I055ozktE1CFhUy/7dpvTojjRBvOQJaRsg+0eCZRCNGNt8L0FBfOBK+8GPCCpNw=@vger.kernel.org X-Gm-Message-State: AOJu0YyEut0A9W2VRhKMSHP99ZzfADbvM0T2Nw8yuLAQNIZGLnwXeUXU +RiIEI8uheEvoV548/KNQKtBhmZ18EhruydblBRj1kcvlpoUp6+XJkh0 X-Gm-Gg: AR+sD12Jd5kV7Vf9dwcrBGV4q3l+yvQeHxHrOsqpL5DptNOWkl550ZVD7fRrLVfWU0a qGB7v9h6klid54lEu1tFE0LdNmm3s2pxEU2f+ALfAL2juO8Z6IEMDNQbrWVFujLdUrIXZPGa9hi 3arGtbGaGTelg1w2PvwVmLB9YLlJxwodJ02RpFqOBRvizR4p3eI3zuZxbTgpNbXUzVe5sLwKLAP wicxF+i+ZFo+3g2PCXJ8+Txvmf5dUXlSHbtNb/IvoFJn7x2H71Eg9eyF3iGFnMY49K5qM7S9Lyi tLuEhfT1fhPEaRaxoNiErcWyCoucvUNGpM2srDUg5mROn8F7Nne6PGk2NX+7R8ziHVESq+vJsue g1W8k1YA8MD2SY0p26Z7s1uaCz/TdxqmidwfdEXdc0XXd18+PPkG5VYy8JBSCACtD3mFuKyAooy aulKz6DQxbcahfUHNCJgKEnpM9nYNU6TRqfTW05fPBo+KhgMEj3MURJr3LU+9zelI5ZehxSmfNv b2AW+m8i26K+Mcb4p6wn8oKVVkgIXkGSAKwZIJGaUshDkXGdiYMx4wx0+Uk+apwO7brjQyXvUR3 xxZ+ X-Received: by 2002:a05:6a20:3ca1:b0:3c3:66c5:68d6 with SMTP id adf61e73a8af0-3cd00f77410mr21961884637.9.1787224530717; Thu, 20 Aug 2026 04:15:30 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc15568c722sm1676503a12.24.2026.08.20.04.15.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 04:15:30 -0700 (PDT) From: phucduc.bui@gmail.com To: Justin Chen , Florian Fainelli , Doug Berger Cc: Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Broadcom internal kernel review list , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bui duc phuc Subject: [PATCH 3/4] net: systemport: Propagate IRQ lookup errors Date: Thu, 20 Aug 2026 18:14:55 +0700 Message-ID: <20260820111456.97947-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260820111456.97947-1-phucduc.bui@gmail.com> References: <20260820111456.97947-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Propagate the error codes returned by platform_get_irq() and platform_get_irq_optional() instead of converting them to -EINVAL. For the optional WoL IRQ, allow -ENXIO to indicate that the IRQ is not available, but propagate any other error returned by the IRQ lookup. Found by manual code inspection. Signed-off-by: bui duc phuc --- drivers/net/ethernet/broadcom/bcmsysport.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ether= net/broadcom/bcmsysport.c index 4d06c6ba6641..2acaffccdb08 100644 --- a/drivers/net/ethernet/broadcom/bcmsysport.c +++ b/drivers/net/ethernet/broadcom/bcmsysport.c @@ -2499,14 +2499,22 @@ static int bcm_sysport_probe(struct platform_device= *pdev) priv->num_rx_desc_words =3D params->num_rx_desc_words; =20 priv->irq0 =3D platform_get_irq(pdev, 0); + if (priv->irq0 < 0) { + ret =3D priv->irq0; + goto err_free_netdev; + } if (!priv->is_lite) { priv->irq1 =3D platform_get_irq(pdev, 1); priv->wol_irq =3D platform_get_irq_optional(pdev, 2); } else { priv->wol_irq =3D platform_get_irq_optional(pdev, 1); } - if (priv->irq0 <=3D 0 || (priv->irq1 <=3D 0 && !priv->is_lite)) { - ret =3D -EINVAL; + if (priv->irq1 < 0 && !priv->is_lite) { + ret =3D priv->irq1; + goto err_free_netdev; + } + if (priv->wol_irq < 0 && priv->wol_irq !=3D -ENXIO) { + ret =3D priv->wol_irq; goto err_free_netdev; } =20 --=20 2.43.0 From nobody Mon Sep 28 15:33:27 2026 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A372D41D101 for ; Thu, 20 Aug 2026 11:15:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787224537; cv=none; b=KDrmaYsGvuNebE8x06m29cQrfOmEuJ6rAStQlixvgkV9nKHhXk//D+knLO0XOKYPLUUn3WNu5fRldpIF5JtojSGN3AmrjZEWrMs4LTIW/1WK2/b97CxTchypII9wDP7UqCdaPAJyTx07lpNBQB1Fp/6QsN9on26nesuR74mBpUM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787224537; c=relaxed/simple; bh=1x2GjawIorbw/4908l+ScmK5Fw9DJ/ZcMIgpbcs16xM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WnIy/tL5lN7igv/rBLei06i67hheSD18K+I6qMrOo8vip5T7Ai1PN+ay5NpwX7xZDDcDZ+wVAewFwq3/BoKtXb5OtvKBQk0SZxiPq1QcW8Pvwx6ibmNX/PEfn5/lbOUZhlv0H88tooPYfi4F5I9t/HXeympc56dJXmMJdNuto5I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b4qavLid; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b4qavLid" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-cb5b8572b70so2118141a12.2 for ; Thu, 20 Aug 2026 04:15:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787224535; x=1787829335; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3splNz+eKCLGRh8XFY3AA6oSixILCEDeXRfbtthshOI=; b=b4qavLidcS7rsxUKMhUFKAXMMRSMP3XCCZc99ChEsGt6Xc2PGmpFNj+mEPxVZs6DVg zCxsbOlr2EJSJWSxvRP2o9Bsl9NPeiNPeRh0T10wg5u1fwNffEmmn8LqLBvA5u5M/svG ow6yC8Spw03t/+5qq2t9rgNXYvmbJayRheO+eAUZzDeALp2K/jIBjIOb69PTV92Hp1oE Nfs0R0lbQXVI0Jw0OYx5E7KOQNri51vYz/F3ERN/0AcSBV2Q7h9ymIeGQP8VeM8fBcpn XNDD8+C4TqjWBHH0lCKB+G291sFBBuHu7Q+uOhEgGWopEWMXmO1fCpRDs/fkem4M9zTE TTPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787224535; x=1787829335; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=3splNz+eKCLGRh8XFY3AA6oSixILCEDeXRfbtthshOI=; b=GQP2Z0Ou257bex3x8hTTf854Ks+Tof3HpFYATyn6TVcr++FnUsXuo+OBaP3mTJ1Xki HZC3qu3l5GUYJ6T+X6aAZoqxRCBrRL1Y7ErgBJ8/2kKbKrpoFOZQF92i/nan501zVaCg K5pBFm2KgvlrAliod+WR+G4FnpCnfLAi85+OjCyJ6se8i4ypLkzTx5XelfGDfIKJP528 rCJHNRko2/9CVNctNz+37hgC3pc8w3dAgb8rw99OxYVrZXzEb0aIb20TvLZ9d86OgDzI 99L1e5RbksEyGp9kwhgl8Jn3Xdb4+Ud7/I+sxVyldZg32t3qvovuseCQ5VBiNBfO5hRB cSMg== X-Forwarded-Encrypted: i=1; AHgh+RrNvC0hQrn70rOsaUM8rJM/wsecOYYgRfncfnKONlsTEGRG0AIPMgy+gzJuVG+j9mWKeNWb74L/ig3DvuQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyqAXpriGdXHknAwr5Acn4uqvtQbx3sXDPIZTepxVJ8WiYjopJp cuhQq3bqFfXGrRDnU8d9zmdDK8LPXYI06AanhHIVKILB0IqpWWpFgdkR X-Gm-Gg: AR+sD10ph3qVyqFSQlaTSV7IetSFVNC9e9xZVz3574i1dMKxHGyev2+/m7CvGhYq5JR UHuqUK/gxdy5iH23r1/ROX+Gts4lGY8Rbwm7FdHhB0489z3yw7GpLU3hlYmvVXI2ZFhkxkV+2bD RkXZRAJaL9r8LZoRVbEmN8pYbuMCiyxQQC1p9Vu40BfI4ieskOnPmJLrEYvAKRz0X+9qlOMWllL 0F4vy7tfSxrIGgg7sRX4f8oglCN2ofmPfGr+/I83Q2IT7pOk2Nm+NK164bLmfsodNhJRXSCzSxi 5P7i9ZaBiVByjzpnc7eEdlilZ6DkeU/psdp5I0a/o3GJxvGAXYh6LwPP+/LSQJOvIDu7hIoD7L5 LY+hJfT+xY8CjE4QAyokrUxKEoLvIrldla0wen7dTN0qoCfzP+xhig5V/IFzR8wghzb6MyQhY/o zgHGA8c68K9BIjtHqsjfFldF3nZTjzFmM1iyN6p7v5Js7DE0Xf20sgGtM+V0eWMstvaAlxMAlx6 g9ICbsvTe48ySKdL8bLREXJa/RXK21iIpZERa36FYDI0+eQ4AhSLmhvFhmh6h2YYaWNVmJK3kGq v3GL X-Received: by 2002:aa7:9319:0:b0:846:bc60:5bf7 with SMTP id d2e1a72fcca58-851d3862b53mr23055166b3a.6.1787224534715; Thu, 20 Aug 2026 04:15:34 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc15568c722sm1676503a12.24.2026.08.20.04.15.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 04:15:34 -0700 (PDT) From: phucduc.bui@gmail.com To: Justin Chen , Florian Fainelli , Doug Berger Cc: Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Broadcom internal kernel review list , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bui duc phuc Subject: [PATCH 4/4] net: bcmgenet: Propagate WoL IRQ errors Date: Thu, 20 Aug 2026 18:14:56 +0700 Message-ID: <20260820111456.97947-5-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260820111456.97947-1-phucduc.bui@gmail.com> References: <20260820111456.97947-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Propagate errors from platform_get_irq_optional() instead of only handling -EPROBE_DEFER. Allow -ENXIO to indicate that the optional WoL IRQ is not available. Also propagate errors from devm_request_irq() instead of continuing the probe when the WoL IRQ cannot be requested. Found by manual code inspection. Signed-off-by: bui duc phuc --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/e= thernet/broadcom/genet/bcmgenet.c index a2305e6428d1..c1c66a52efd0 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c @@ -3993,7 +3993,7 @@ static int bcmgenet_probe(struct platform_device *pde= v) goto err; } priv->wol_irq =3D platform_get_irq_optional(pdev, 2); - if (priv->wol_irq =3D=3D -EPROBE_DEFER) { + if (priv->wol_irq < 0 && priv->wol_irq !=3D -ENXIO) { err =3D priv->wol_irq; goto err; } @@ -4033,8 +4033,10 @@ static int bcmgenet_probe(struct platform_device *pd= ev) if (priv->wol_irq > 0) { err =3D devm_request_irq(&pdev->dev, priv->wol_irq, bcmgenet_wol_isr, 0, dev->name, priv); - if (!err) - device_set_wakeup_capable(&pdev->dev, 1); + if (err) + goto err; + + device_set_wakeup_capable(&pdev->dev, 1); } =20 /* Set the needed headroom to account for any possible --=20 2.43.0