From nobody Mon Aug 24 05:26:52 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 871E73FDBEA for ; Thu, 20 Aug 2026 09:41:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787218868; cv=none; b=CRknrNtf59DcVkU/8lad/tno0CX1LGQ42/h4SQCItDAPg8IGkjxkoQbC9d2xlDfpRGUR7Di7H3y4x724jTkiFrfQoHj+2A4A9fiH6fOiwHLExl91mSfnkkeOpMKOKNe9kjP6Lx9qkypdS28dapKC/es2rXd9L5aw+Qc+L+nPvZg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787218868; c=relaxed/simple; bh=FzHg9or1Zwm8rHfuvlBTPbxJtQYBwLJ33RJpzjd9Uq8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=att23kE7KKac2L+JxAE1F1gbzfNQmALaaSLVAs5Hm5a8nGAAtuyH1Ut2542F7irvBW2TOCotiktbj5p0b4xpzFIH0Vweh4AUUPuR43W4WwGBja9kahdIsGOvXG5oX0anyb44MnqcPEOwAccJeMd5uh8f7G7QY8iCBlX4Zuw9BRM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Gs4sGP6g; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Gs4sGP6g" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-38fdeaed181so2861959a91.1 for ; Thu, 20 Aug 2026 02:41:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787218858; x=1787823658; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=yF1JbB5R/FVZprSXPu19zqoBb23lz+r7CLHDK21Q7Ng=; b=Gs4sGP6g+kAFvymtg57O2qy9qp33etYUYtHr8EnhesCjg24pmJLYmVHPzhWsmhouXF hiR6hPNOWUjpTVKO3bLHj+pYbRMtX1TKKQ+Uo+WDXzi8rVOZquwj89M/ncE38qsJ2hPZ n7j8Z1SigAQaAwH6WK+YSp6HmVLL+W+5G+lw1ojcdekT7ITMar7SbUcQts+KnTwlra+8 2+i2BKOsyrpmn+bOCfmxdCsByuWLREXTC4dTMl7b148yPWRn5TheAXRpSwDRsBbqkG43 qW8bGql6S9MxnwliKnULZu3hoh0ZGHKSVZDMdg7XpX1RQftdk5h7/CrO6GOUQUD553Af PRsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787218858; x=1787823658; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=yF1JbB5R/FVZprSXPu19zqoBb23lz+r7CLHDK21Q7Ng=; b=DoxbOTKWB5wOc3TAlLuwSfFvt3SVR6J9LMOtWusMvdgIn8uCBuJKmiwNEr5AtWjBWJ hLOGybAa+u0TnJ8Fdd1Q7ZSpD7oDp3HL1ZhE4y4Q/2yv7/K+3NIXPtWdGfGkKszCWEjn JTT8sfPfBPrqDnzLql4a5onep0wocF/G+IHbrCBF0ErM9tXQuzzTYGvp6v+8dBIeX49+ RdGC+vlndtFKTZuFqNjznh3OJieh3AFK0KE8fUEksiMc+e649KqthXlW77ins9jYB/g4 T8aNBGXhXGEvsN284BiY3ttF1t+ids9YgxUT7tkcViSPUhHpbNolMMtlGK5wHgU/6xa/ iOZA== X-Forwarded-Encrypted: i=1; AHgh+Rqdln0ztidj7MKjznsMJG4+9HNoHYkJhFVQK/N5Gcj/GcZr10UEC1qBAAsHB+3KsLiyX27Zq+OlQa7pNEE=@vger.kernel.org X-Gm-Message-State: AFuF++kyF/DsCpQf0zuQh74nSvjtKdZmXH6s3G6G9PFMCxYemZYvBC9b EpxrHBUWi0lySEZhqfE/NstHP5hzNxD287yF9K48uxPAhlizq4L1NKaG X-Gm-Gg: AR+sD10BcmWXHbiHL3fe7BbmT54c2flwktfYAAOXaDe/8rxN60JEZ7soha0BkgoINeF nMPc/r7oJf8QdziunPDc6UGuMJjlsqT73ytH79O1lcGdbit7CC8qFsnAp2rgkAhAsfU7biLowx4 axQ1s0iJZRHzpOcW91OHq42p7KfT7u4KoKihTG0kbv16+OPQIIj4vPOTouMtF/R2X8uUlRdpHAt Jr1zJgvIkJpYCjgtab8LLXTStPw8jAwcJzxLm8UAaNvl4DE1t/Ef6jxGoDZen/ohl+CfTupvy09 QBqGW+hhA19O8vAXewwTyrH7Nkh8boeoDq6kFzFe1j9rZsQg05YP94UDx45aN186IGFXiTY/w5o ssbq1C/I/gK/YYpZth+D7RT9hteDbTYNv3Tocfgg0jJX6RDIDNJsJ78uOs+cPef/gaWT0DCmgLl WPJf3Ne2a6BqUBqeEJ1T15noD9Y82T/fmvxw/QpjwfoWyX5ei6DOz/sJPVM93DEyJZ19ee15/AN lliGvW2 X-Received: by 2002:a17:90b:4ac9:b0:37f:ed7e:7e42 with SMTP id 98e67ed59e1d1-395810cad6amr20759699a91.14.1787218857689; Thu, 20 Aug 2026 02:40:57 -0700 (PDT) Received: from user.. ([2405:201:c052:b00b:6143:5a42:8472:2f21]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327cb5a9831sm8393939eec.21.2026.08.20.02.40.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 02:40:56 -0700 (PDT) From: pavankumaryalagada@gmail.com To: Tony Nguyen , Przemek Kitszel Cc: intel-wired-lan@lists.osuosl.org, Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, syzbot+e0abb1d45ac291ebebeb@syzkaller.appspotmail.com, kohei@enjuk.jp, aleksandr.loktionov@intel.com, Yalagada Pavan Kumar Subject: [PATCH iwl-next v4] e100: prevent shift-out-of-bounds in EEPROM access Date: Thu, 20 Aug 2026 15:10:45 +0530 Message-ID: <20260820094045.41400-1-pavankumaryalagada@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Yalagada Pavan Kumar When reading the EEPROM address length, e100_eeprom_read() can return an invalid length. This value is then used as a shift count when calculating eeprom_wc, resulting in a shift-out-of-bounds UBSAN warning. Stop EEPROM address probing if the detected address length exceeds the initial address length to prevent addr_len from underflowing. Validate addr_len after reading it from the EEPROM in both e100_eeprom_load() and e100_eeprom_save(), and return -EIO if the value is zero or greater than 8. Reported-by: syzbot+e0abb1d45ac291ebebeb@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3De0abb1d45ac291ebebeb Signed-off-by: Yalagada Pavan Kumar --- v4: - Squash the v1-v3 changes into a single standalone patch. - Prevent addr_len underflow during EEPROM probing. - Validate addr_len in e100_eeprom_load() and e100_eeprom_save(). - Use BIT() and cast the result to u16 for eeprom_wc. - Target iwl-next as requested by Tony Nguyen. v3: https://lore.kernel.org/all/20260816113754.22900-1-pavankumaryalagada@g= mail.com/T/ v2: https://lore.kernel.org/all/20260810083355.21631-1-pavankumaryalagada@g= mail.com/T/ v1: https://lore.kernel.org/all/20260807145626.52692-1-pavankumaryalagada@g= mail.com/T/ --- drivers/net/ethernet/intel/e100.c | 29 ++++++++++++++++++++++++++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel= /e100.c index 29960762e64a..cd8190386652 100644 --- a/drivers/net/ethernet/intel/e100.c +++ b/drivers/net/ethernet/intel/e100.c @@ -744,7 +744,14 @@ static __le16 e100_eeprom_read(struct nic *nic, u16 *a= ddr_len, u16 addr) * complete address. Use this to adjust addr_len. */ ctrl =3D ioread8(&nic->csr->eeprom_ctrl_lo); if (!(ctrl & eedo) && i > 16) { - *addr_len -=3D (i - 16); + u16 len =3D i - 16; + + if (len > *addr_len) { + *addr_len =3D 0; + break; + } + + *addr_len -=3D len; i =3D 17; } =20 @@ -765,7 +772,15 @@ static int e100_eeprom_load(struct nic *nic) =20 /* Try reading with an 8-bit addr len to discover actual addr len */ e100_eeprom_read(nic, &addr_len, 0); - nic->eeprom_wc =3D 1 << addr_len; + + if (!addr_len || addr_len > 8) { + netif_err(nic, probe, nic->netdev, + "Invalid EEPROM address length %u\n", + addr_len); + return -EIO; + } + + nic->eeprom_wc =3D (u16)BIT(addr_len); =20 for (addr =3D 0; addr < nic->eeprom_wc; addr++) { nic->eeprom[addr] =3D e100_eeprom_read(nic, &addr_len, addr); @@ -791,7 +806,15 @@ static int e100_eeprom_save(struct nic *nic, u16 start= , u16 count) =20 /* Try reading with an 8-bit addr len to discover actual addr len */ e100_eeprom_read(nic, &addr_len, 0); - nic->eeprom_wc =3D 1 << addr_len; + + if (!addr_len || addr_len > 8) { + netif_err(nic, probe, nic->netdev, + "Invalid EEPROM address length %u\n", + addr_len); + return -EIO; + } + + nic->eeprom_wc =3D (u16)BIT(addr_len); =20 if (start + count >=3D nic->eeprom_wc) return -EINVAL; --=20 2.43.0