From nobody Mon Sep 28 16:22:28 2026 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDD5C1A9FBC for ; Thu, 20 Aug 2026 01:45:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787190355; cv=none; b=MVrq6/LqtmlmAt6x0KOT14WGPOkuLcQ3bqVhvETBxEb3LTATEV+mO7XqvYSv1WMApM0gK01Udzu/Y/wNj3CQakllpxibS3w8NECbH//xAPn3BQa89tlCAf3ioQvuM8IjTwvF16HOPZ4m+5Nzj6jfNcKIUt9rHqgnH/91V+7MGsQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787190355; c=relaxed/simple; bh=gEnzG0Socuu7wvKzQDT9gW4fhgzW4vgr+HZWjFlh7Nc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qub0x2PHrmyPbMahz4jt/V1ddxMersG2QgK7ztGnvJgu47oxVXn8mJ4i/l44yoh9aOSFtYG6aZPfAyjkl+n+uz3c6NaUlRth94nS4ruN9SQtfFCcrZ8jXs2l/abGY8kDDEraM/JcFeML/+iyWVOksOPKFewkdDYXagC3/hvVbe8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=mAtDv8P/; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="mAtDv8P/" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-cc11a30a259so1446816a12.3 for ; Wed, 19 Aug 2026 18:45:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1787190353; x=1787795153; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=hcbmxgCXq1Ai2lvtBMwQpFOstE3BYsfTfvmqnVMkCrA=; b=mAtDv8P/tWl67pz5snhYSEL1Lyx+LrZdPjxqLsfuzW52Nmifba80FpnqekeE8Cwv0G 5l1bXxY1/TDDPAFmuGHI1f4ba1ApmB4sn8cKX2kjqbBGx71NuwaOJOjf9JSGdvYWRitE ilvPQo5MdcOk9b7qOOThhKToNDTLA32Z+P3CiWHzEGU+qxGdm5wZGmD2oH6KmNyPP0yk sGefKQRx5E5VOLX25ggHhIkuSFvMRpI1fDtdyiJcdfCV8gxGGvQdXHR0gLyCVJ8DyGJn kk3hRLfIULF386ADfP+g0z3cClX4iK2hf8G5/jaQ09co747CxDU35ugRpHrLnwR7BYbN qLHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787190353; x=1787795153; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hcbmxgCXq1Ai2lvtBMwQpFOstE3BYsfTfvmqnVMkCrA=; b=UeZr60/SRAbeupccJ2uUb/pHjpvNY2xni0sJTpmtNEuoW00TsI+lmDWZABsseYehlG FCRu0B3tOkD2dY3Knz442mur4mFl/5jRIGu/a0podKksMNqTGZ2ugpERXKM9/FLt4HJj NAWqoZ659+Tb+ChP7P5TmTmz9Hw4b6nZiCuru3f5g5qVouFkBXoTkCasVKZIDsef0dii oF+WeRHe6Ns2OB9JOlkNDUG75UEqoVKoSg+9bbRt3epfvGKaOmgbKc2b7WZPYJ5e6BKk FwDpHRr72MkczpTJMUYlSxeIjo5o56RwL/VVqigsk5d3pzt7hmNNDW3e/yX/T8RHI27m S3gA== X-Forwarded-Encrypted: i=1; AHgh+RoovMIjFFu7xej6bX8seh2rL3s6uR39HsBhGZUwx8VSnDS5S09ArV1RvTl2BturLEKGxdJ14apw+U9FmGU=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5JBmIVihGELwkZNTDzjeuNJ/SgG2hULe0bO3YJTK/rtDFGs/N 2jyL7WirCxF9q/k9iIX7TmxkZeVk1lq2ngiMJEs/A7ZQr5/8sA9Tll7trDtt7Fq9nsv/9XDs/sf SX7tl X-Gm-Gg: AR+sD10wQ96cBtyDH0coAc3G+kKd5kQcTByl7glco4JD2qo298ROciHPp/CLaEQ53tL bAMid6iyVf6f5tbFWq6MQfnPawXkXHg373o2U8ptIVIe+8iNDveInrWmIQk9k6jbrmFme6ZSbAl JlUnLqD1oXsTUQomB/kFBCSWO24jKX/EIQe9aTsXbUslGx+TLJVxxQSZZGbpLsj5ID4E3Y0ojsv eYyhDBTDppst1WN/pAuWOOZupNYJX3As0ZAAZ2bVVCNS9AKPrAIlkGOByR94vQk1Q+wYPw74up9 89bHtQuIK6TNXYW3Xi16/ACv0aljNEK18odnEftlzizuFDujbIKSZse6qVqzc0UQYOQFr6VcsbR OJcYO7X6Fkk1mS11zpIdrl16UhVMV1bAai3sQWWjUosZccAG7ECUNHWm7iNWGpir9zzHn6/BvVx /uFvGbkVHFLdUAeqfO3eqSPooQpOOixa8w6naDPG9DoOf0HoI391Jcbjm7jOb0fNOCMdW3nSRLB hRMksRVgYyohTYbaEj3 X-Received: by 2002:a05:6a21:6b0f:b0:3c3:8c91:5da0 with SMTP id adf61e73a8af0-3cd012342ecmr16884819637.15.1787190353142; Wed, 19 Aug 2026 18:45:53 -0700 (PDT) Received: from sw06.internal.sifive.com ([4.53.31.132]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327c946293dsm5052389eec.22.2026.08.19.18.45.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 18:45:52 -0700 (PDT) From: Samuel Holland To: Palmer Dabbelt Cc: linux-riscv@lists.infradead.org, Samuel Holland , Albert Ou , Alexandre Ghiti , Deepak Gupta , Paul Walmsley , Simon Schuster , Zishun Yi , Zong Li , linux-kernel@vger.kernel.org Subject: [PATCH] Revert "riscv: Reset pmm when PR_TAGGED_ADDR_ENABLE is not set" Date: Wed, 19 Aug 2026 18:45:16 -0700 Message-ID: <20260820014551.1979772-1-samuel.holland@sifive.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This reverts commit 3033b2b1e3949274f33a140e2a97571b5a307298. The reverted patch is userspace-visible behavior change, not a bug fix. The two variables here (pmm and pmlen) control two independent features: pmm is the _hardware_ pointer masking mode that applies while executing in userspace. pmlen is the shift amount that the _kernel_ uses when untagging addresses; PMLEN_0 means no untagging occurs, so the kernel does not accept tagged addresses in syscall arguments. It is valid (as documented and tested by the self test) to enable pointer masking without enabling the tagged address ABI. This separation is necessary to allow userspace to create an execution environment similar to what the kernel supports on arm64 by default, where TBI is enabled but the tagged address ABI is not. (On arm64, there is no equivalent to PR_PMLEN_MASK because TBI is always enabled.) Signed-off-by: Samuel Holland --- arch/riscv/kernel/process.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/riscv/kernel/process.c b/arch/riscv/kernel/process.c index b2df7f72241a5..7cc5a6a5c0206 100644 --- a/arch/riscv/kernel/process.c +++ b/arch/riscv/kernel/process.c @@ -349,10 +349,8 @@ long set_tagged_addr_ctrl(struct task_struct *task, un= signed long arg) if (arg & PR_TAGGED_ADDR_ENABLE && (tagged_addr_disabled || !pmlen)) return -EINVAL; =20 - if (!(arg & PR_TAGGED_ADDR_ENABLE)) { + if (!(arg & PR_TAGGED_ADDR_ENABLE)) pmlen =3D PMLEN_0; - pmm =3D ENVCFG_PMM_PMLEN_0; - } =20 if (mmap_write_lock_killable(mm)) return -EINTR; --=20 2.52.0 base-commit: a4ff2be345d0abc943da8dd8da98151843b750dc branch: up/pointer-masking-fix