From nobody Tue Sep 29 18:55:13 2026 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C5323CAE76 for ; Wed, 19 Aug 2026 17:51:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787161891; cv=none; b=Qph7i08xPDI9OC9MFDYUBiVMXyAl5dJZwkqyN/2QvksUJJeLobIx2/GMRpsXF+jRN1tQH5sraUa0EVUqvqIS+kI3bvvCfRyFXurMWEvSMVqoHuYtPzsNESr6LCz85mJNSE2Sqs0UoOGnmI0dFP1Ld/6OOUv0kUXaVlFkhk2kSMQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787161891; c=relaxed/simple; bh=Soo8oe3J7AFA6oj6G+skotNR2awzsKlDGT8J932ZjJQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bNkwU0HkjCJ19CUgwD1Y0NwJlWSeVF9YfkI3zhQWlHIRp+zpoV5pA5hj3N56bj1+Eej72CWJhJlKxyQfEbpGLH5XSMqoH8UkvHg52pvMirmbLtTxZj6qZWHIxg1axPNyV5gHeU0koCdqrHHFlsu4fiDdqn7geNIB2LwuJXu9qzQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Cgem1xkK; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Cgem1xkK" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-c15b1da6b82so144408766b.1 for ; Wed, 19 Aug 2026 10:51:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787161888; x=1787766688; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=/Cj9RQcolWEoew7IEYyQVrf8OU6NrQl3Vo0NlQLDW8U=; b=Cgem1xkKAZ4lVOVTo2mlCppv6Ds6aPDUC4ZZknuR7gy2Cj8N/i63Jg8CNUYDm0lBsq Yj/X138NOcAR86OAj5g+3VN79d+XVxcxsRG+MaRHarmF55anYzH30+lWGsW8O/EYW4Sl pK6pgtqw1YOGFzMwR4Wr5eIOS1uleEshtDyP6oIv74qijAvzU4hgGyhKOyFYg1MdvHI7 JY4mS4m9OWuzZWQys3W0l+XfZNdem7Bp7SAgZPtkCMmpaZamdQXtE2ZBqodGTHPKepo4 Hr+6lj+IofVFyluuufq2OXoiPrUWx2hNgL2tMlNgrseCPOKz5M/MUCaQzf1egNw2XxQL wAsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787161888; x=1787766688; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/Cj9RQcolWEoew7IEYyQVrf8OU6NrQl3Vo0NlQLDW8U=; b=Cm69/AOyM6Avg/rqkrFBJSBENwak4NVY00vZKxIkaEQpnMiSWwBY++TOtNEgj/Xwp8 YF+yosZthhFLAuJ0OcRtNBKZ5fzxeMCltdes/CHyzgunu0tAmr2dbNG5jYffHwcU28qM mdGqjG6tkbf7lxEnTrafInxNR8FZj20guyTMRxj7iCt4u6VX+xEC3e2NWxHvuHxxydpk 5uHOWCHwTOBq8LWl/P4uj0kdSbVEjW6FFcHFxf5+sOtNnof9du4XSpQn0ijlNGofKLZH Lw6y7S81t9WxtzTIRAr80BxxTFVkz19FlDdxFQx7ttfp4JgIcPr44cPByw7e+h7+YMta CNOg== X-Forwarded-Encrypted: i=1; AHgh+RqtOQjssJRqYLqVC8OmaHjXHPtqhvr0yue9f2zOVqEBj4zpFOUPwxjX8JyxtEyVKBbAbCCGpGjoZCL9b3g=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3J3Q0PBJ7puGupgoBxtW1hj/5x+i0NcOMlpLnciBUaBLNzIRG 0MPjavN3zgi7E+2tO67O/dBvXsHuyI1K46OO+c2vD/9PeNFukGpH/CI7 X-Gm-Gg: AR+sD11ELscMQ+yfWuqcmzQrBFL94S56/1kD4AGmfQkltvrrLYTGU++j334pXgaFGlR zyGMlSVtO9dmyLDk+extKi/cw9UGOJeva/M0Ft0vIt5QKoOd7OSKQirtVjEcS9Oxm538dm9xw74 ZdPXItGYbnNtRI5Lo1cDr1SnpmeufETac4OEks0dIECfGSw0+2h5r9vEsKCIafKrq7eQHe3FiDr JG3QARrc91uV/hBx29S5w8nKovTAW1Y/br35DdTZiS1qVgYB6igfv4/TisO/MwrbTyc5sRjrNoU HshUgK0gFPmt6d+ypnzhYQoq8rsBATqtJVe+4JPaFO3hU8kX6hYfRhh+GXk/PapwVWQzL1EaQAn yU41gjD53ey75F6yejKYZgNV1Yjnp78upYlOqVJKOchNjc3pGQfH7YQWIcklqImI9p02oqQ2XYa TT7rcibI5QbxZVU7izA006KGivmx5ZgnEe6DjnIGSu7upnprFrtv9+g4tAhKn7WZbTSWNgIMOMG A== X-Received: by 2002:a17:907:7247:b0:c21:74ad:8b7a with SMTP id a640c23a62f3a-c23f92d53damr467518566b.9.1787161887573; Wed, 19 Aug 2026 10:51:27 -0700 (PDT) Received: from localhost.localdomain ([165.51.35.158]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c243c38d532sm110631366b.38.2026.08.19.10.51.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 10:51:25 -0700 (PDT) From: Salah Triki To: =?UTF-8?q?Nuno=20S=C3=A1?= , Michael Hennerich , Antoniu Miclaus , Jonathan Cameron , David Lechner , Andy Shevchenko Cc: linux@analog.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Salah Triki Subject: [PATCH] iio: frequency: admv1013: fix wrong channel field used in admv1013_read_raw() Date: Wed, 19 Aug 2026 18:51:19 +0100 Message-ID: <20260819175119.6235-1-salah.triki@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" admv1013_read_raw() switches on chan->channel instead of chan->channel2 when handling IIO_CHAN_INFO_CALIBBIAS. The channel field only ever holds 0 or 1 (see ADMV1013_CHAN_CALIB()), while the IIO_MOD_I / IIO_MOD_Q modifiers are stored in channel2. As a result, the switch always falls through to the default case and calibbias reads always fail with -EINVAL, even though the corresponding admv1013_write_raw() path correctly uses channel2 and works as expected. Fix the read path to switch on chan->channel2, matching the write path and the actual channel_spec definition. Fixes: da35a7b526d9 ("iio: frequency: admv1013: add support for ADMV1013") Signed-off-by: Salah Triki --- drivers/iio/frequency/admv1013.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/frequency/admv1013.c b/drivers/iio/frequency/admv1= 013.c index b823adfb0f70..bb06a94ccc50 100644 --- a/drivers/iio/frequency/admv1013.c +++ b/drivers/iio/frequency/admv1013.c @@ -195,7 +195,7 @@ static int admv1013_read_raw(struct iio_dev *indio_dev, =20 switch (info) { case IIO_CHAN_INFO_CALIBBIAS: - switch (chan->channel) { + switch (chan->channel2) { case IIO_MOD_I: addr =3D ADMV1013_REG_OFFSET_ADJUST_I; break; --=20 2.43.0