From nobody Mon Sep 28 17:50:13 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C94ED43DA5E for ; Wed, 19 Aug 2026 10:39:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787135994; cv=none; b=piYCbkf9lPaHVZWz/suyIrQBMwcMI6R/URA/ic+FTid/7DYdMwL6G0apP6Ixxqv6ccaWLvbJOIWCAKXpsn6ATO6HH7caP7XxN2jW6EZ+zilJoqRR0+xvlbdYfsSXTHgWID7GEnIPxRj7DpD/7CZaLyV4PxznYGSEbfy+xjWWuyk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787135994; c=relaxed/simple; bh=9hfEGYW5YgRL4YzWycO5l87g466MjXZ3blJAK2XRTMY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ItLkKYl7By899DaTMTLeskaO+nCu880MD/sFt8iZiTc94pxg+uGUH4VHV9/Chi4TJG2dgA1gcTHUakcyUnqmyzGD7UUY1Vmwz0bly4qpVNRKuVkV5/pInxz/L3VCl/38pfUcSqXcDoqqH0sAN1tkdicXtlGdlFShdxDTNH9yMG0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mFMd7gny; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mFMd7gny" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2cc61541f8cso22910375ad.0 for ; Wed, 19 Aug 2026 03:39:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787135992; x=1787740792; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=heP0mE3qyhx9OeaojnGQkHIk8X/axZX4MpRVNDZWMuk=; b=mFMd7gnyrhRXzdvzfRUOxV3zslXIYOZzwxaUI48U+PaB1WWb2gt6yjxhL1o0t/Phnr CFwIXV0eQZokFtMdYd+JL3xitQSjF6R+A2h5GcZsU4KFy+PiTOidWqPs6wUptn6hAyqI inJqhCa0BcWAvV7zxYK/HrDc55/K1il1O6HbQ7llUJmSlhfErKoq7v6qhC6pMPnO3LBE t1qAbrG4p3WSc9EHoybKFm9Hq+Dl7NUVprXXkkEoC4I2EPeY0WxpgAhM/65NSuxT5Dh+ yUTlUmaCYYW1ieQ55a5i+oYwktexJbo5LKhb2Zk6PmCz6FtYqzFyRMFb4BGfxNEoipsl ubOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787135992; x=1787740792; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=heP0mE3qyhx9OeaojnGQkHIk8X/axZX4MpRVNDZWMuk=; b=QAGSOSIF+LV+4rqOZzOp07+5jwRMZiNBm3gWL8QgSnEeJn0xmpCz/0x/MO+cHNQyoi lpYJ5xcspEEhNeCsDaq/CyXVq8yBmo6Tun92GUYtKd7h1VVR/MYzhZWrPpAFQ+WQj28+ pNKKf1Nk5xEpuLhb1JFdxUPKhQLaqNgmU2O8v0+XYoFXehQFl/oxal+oPlL5Sf9QLlIq 6iUEQ7F9wR10zO3XwgjsLP+jDgz21eRNckhClEWMXHHNhJwAAvOBCTORrEntzupgtRc5 vZz1tvTso2ah2tsHp6HWIK1w81o4ZrYAyvJN/0zadfreHvr3gICAg10Q2RlL1AvilM4a ncsA== X-Forwarded-Encrypted: i=1; AHgh+RpU876/MAYZJHnJpu0X1mxm+O/IRYi9ul53upPWpz6GjxnYsSDabA5cW6gfdlpuE/2Bx3LAd1nyAf/1YD4=@vger.kernel.org X-Gm-Message-State: AOJu0YxsuVZj88ENSyOUILo7R8SttNexzuiDiiVLkvIuxYFwxhB4F/9e TOFtCp30LPFx92Ypn/ZImgA2Mc0kP3mjAPZeFAeYMHfWvXEIPXBC4GPujMdUA9qu X-Gm-Gg: AR+sD12/+YJTvLiIeMfShaYyHCHNCAmFTBoVtA729iuiT2TjnxC0m2bskIsLYM1OOjq ETwKK/uzH9DUWs1cR7Z4XgV035pqn3zd8D8aQ1TpHRrct2DUSx+Wxve61pNi+36xj2PAFMQ+ap6 jDOUm51PoPeUHD0pk0UgY6T3SYgxrn4MxDb8dw/YcTVrzGI8/yktCclXl6k1UXBVNJsYEtfpbHJ N6ZGTncYpgtNs4BJ/1sxtCUlcGOv8zq1CN6I1ELza4Mxt5PJtarHsQnv07ZfUmm9vRtaHqdf6TQ dkmbERZAxvPB3Ar192NIKf6BiQQlRLmA+k6E/ag6Yx9zrj3olnDXcxtAJctCNZ3PIGBuFCQ+9Dj 9PocyBKMy3bVDPe2rFx9rvAL0abupE16kM5q3euN6g/akxMEZ/Tjh2QM5c3yOtKUYYedta9H1MI WEW/19/lh53oqPfM6i6uJ4BbG3B+ROyrc0TU3ntzgCYjRfuVFEEHnRVkRnP6CKF/EbuWJ4NLTfh +18g1JVjmcabxzf08zyPnSK/AvOP7cAxZaLEXYAap0JgIOIf8McRMydpjo6hbNfGdgWMvwdHjLh KOPVg2xGPQ== X-Received: by 2002:a17:903:350c:b0:2cf:af20:4254 with SMTP id d9443c01a7336-2d5fc9bf1c7mr48441305ad.10.1787135991951; Wed, 19 Aug 2026 03:39:51 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:a897:a9b5:e171:c935]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bef77fc0sm11169630eec.8.2026.08.19.03.39.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 03:39:51 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Miquel Raynal , Alexandre Belloni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Wolfram Sang , Magnus Damm Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar , Conor Dooley Subject: [PATCH v4 01/15] dt-bindings: rtc: renesas,rzn1-rtc: Add RZ/T2H and RZ/N2H support Date: Wed, 19 Aug 2026 11:39:12 +0100 Message-ID: <20260819103926.2136712-2-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260819103926.2136712-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260819103926.2136712-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Add compatible strings for the RTC block found on the Renesas RZ/T2H (R9A09G077) and RZ/N2H (R9A09G087) SoCs. These SoCs integrate a closely related variant of the RZ/N1 RTC IP. Unlike RZ/N1, they do not implement the RTCA0SUBU register. This is not a limitation for Linux support, as these registers are not used when the RTC operates in "scmp" clock mode, which is required on RZ/T2H and RZ/N2H due to their 195.3 kHz input clock. The RZ/T2H RTC variant also supports a 1Hz output signal on the RTCAT1HZ pin, controlled by the RTCA0CTL1[RTCA01HZE] bit. This bit is marked as reserved in the RZ/N1 hardware manual. Update the binding schema to require the additional clock inputs used by these SoCs. Signed-off-by: Lad Prabhakar Acked-by: Conor Dooley Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v3->v4: - No changes. v2->v3: - No changes v1->v2: - Updated commit message to drop reference about RTCA0TCR register. - Added Acked-by and Reviewed-by tags. --- .../bindings/rtc/renesas,rzn1-rtc.yaml | 35 +++++++++++++++---- 1 file changed, 28 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml b/= Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml index 1860f0e4c31a..ea7b039a91e7 100644 --- a/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml +++ b/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml @@ -9,15 +9,19 @@ title: Renesas RZ/N1 SoCs Real-Time Clock maintainers: - Miquel Raynal =20 -allOf: - - $ref: rtc.yaml# - properties: compatible: - items: - - enum: - - renesas,r9a06g032-rtc - - const: renesas,rzn1-rtc + oneOf: + - items: + - enum: + - renesas,r9a06g032-rtc + - const: renesas,rzn1-rtc + + - const: renesas,r9a09g077-rtc + + - items: + - const: renesas,r9a09g087-rtc + - const: renesas,r9a09g077-rtc =20 reg: maxItems: 1 @@ -54,6 +58,23 @@ required: - clock-names - power-domains =20 +allOf: + - $ref: rtc.yaml# + + - if: + properties: + compatible: + contains: + enum: + - renesas,r9a09g077-rtc + - renesas,r9a09g087-rtc + then: + properties: + clocks: + minItems: 2 + clock-names: + minItems: 2 + unevaluatedProperties: false =20 examples: --=20 2.43.0 From nobody Mon Sep 28 17:50:13 2026 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54C413E1218 for ; Wed, 19 Aug 2026 10:39:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136000; cv=none; b=ajMwAaX1Zyxh4AHEXfcH5w6y+KJRFzLMNmAOmY+ahwbrbwW7YBTPdt8WSSD9zeJzISY4h9LieE5jgHBf+pq0Qx32f+5rin8dcBpfsJq08Xd+Y2pueuBmOv/EKIMVB7I8/6jJXMVK6jGZIklGiJ8yjeH52BCYDdr4xwu0+5sBbS8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136000; c=relaxed/simple; bh=qDcB+Mkl6hrvJLtzWJ/l4rkGLgqhuvNTVfKWLhnH62Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R8FFbwkzHh42kWukUcRc+oodQsm4DatQJJU+bwzWWWEFl56S9PbkJlJ66NJ11FCyNmMbX3ZmkQXfwqEb/PvIFEcFVdoEmqc5dnbdNEb5xsAVBgpZ87d0mehvq7GerT4eCuJey2oIuvhsxUf8lrXfuBFmWs8PyV26fWR/49/C5oE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UH58KPQe; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UH58KPQe" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-cc11a905ba5so473583a12.2 for ; Wed, 19 Aug 2026 03:39:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787135999; x=1787740799; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=X3zcIIt2Vy30AFXeLDvAuFYCcKu6Lcu6lcEJtD928ow=; b=UH58KPQeMapf4Mg1NDvvrOGP4mPYNynntmy16iMgpLqrc5U1n67XiMFwKybHsrsBDF kfDYeAbyK29QxZICSQDDXjzpdclRr11RMXWo8+R+dm0C792q58oWD7CFflVkuKxDMUn6 K5tq06CQSCcFhc/ipFFU63eNWqFTcVH9J1SmhURPOIam9du41v7wUCD+9UD2sBvuj8Pi jzYS6GKLmTs5FxD6CdqcmmLAwDlSsOtQNwXpHgKCnpis/sYMVyMZ/WWsc0C6YKA8/5RP maFDR0+XILcu0jX2OgIcNmbOXMZgz8qm8dG5DjGTFiQQuGr+pnG2gJisZctfgedsvLVq 4yJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787135999; x=1787740799; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=X3zcIIt2Vy30AFXeLDvAuFYCcKu6Lcu6lcEJtD928ow=; b=QNnGrEhsbdyS/Ekn7ZAkAMiTUx+0YFzAlp8qFcejR4JHFjwEdeOVCl1hDCKLfYtz6f xKETl5V6oGWhL/x5Zctwb5mQnVRCxHFqPgBPxwgEfWbkHi7BEycpQfWKeqwZym0fUV9D mi43P5TjU0wMRfRxCUWWgtNqStMSsPapGv06GfysN+T/x8KJ67R0GH63MVY1lyAnwUnU 6xFqVjbLxFgNBREDEK4jS9zWwn1zgX9OilSlZCbQynD2h0zEevEiNAyFFtxYtYCAjQ4q DFmCOX6lpD00nOH+U+8dvtpRmuTdQEUmIQfk21wnQS6eM3ntLNl4n1s/pz7Fh4Vb5D26 f/mQ== X-Forwarded-Encrypted: i=1; AHgh+Rr+W+szoLvXMv81ZHQsBJdREjgjSpfYsU7YRwo6FSx2Uo741/UaHe35phXwyrb9YhvACtpSLE9bAELlrDw=@vger.kernel.org X-Gm-Message-State: AOJu0YyaDhT07hKFPtQScRWYBNf8/31GIzvzIOcJY5+eQ+orUnvk7hhD tvMFvkLtZzs+l19JLE6ZqHtGXghcEgLApn8Qx5jwdahC33X//WdhTVOo X-Gm-Gg: AR+sD13wgqOSHgYIok8x45zA/w+0iN6/4zHuYP87V9teBrq/gA5zsR+jeqVbinYs5FK NCIDka1AXWlRfqZv3wpoYdCOFwHCJFETl8Q1t3CpRVIZFaCyNKcskb3gYQnFA8IMVypYhsr/ru5 LGCIFjQNHIO4zHJA2XNwK0tNC2o9Mvhsu4tWvVLrLKZG9L1IEbb4WSg7xWDIqSvPTME3iQMOtvW ut/5Ou/PgN08GVK11plL8n0z3nkDSUnkCKt+ci4g+vMBWLRRyJWMr5xl1xbbr2B8sxKdG1A9B0x ABCbpl/MJsZyE573V3Uob3C5sT0jdtNeFt7LX0/mac9cieUyH9HoIbmeeEwxJkVS84mlOf9hQKV nn/uHSaz8XfpUkTG5lJEHYXMDog3XD9IihPstpvGKXBv5ijuRACqv95go+zTfo7Vy77NWMwSpwI xNkEclQb1drwewCrGKSqmg0UzYW78evYu97H5JmsvLo74aLFQ6rprY1JrXQwW7skAI4ErDxP2k6 24QDNuGOv3Z3BIToBXBJrOIu3vfOeRdSXFh+09ZH1B5Q0kC2Joe8AbvrO47jKGN3ZkAEt+zh6Vq Svdhj/RZhF7HJwOPocYf X-Received: by 2002:a05:6a21:3398:b0:3cb:8280:71f8 with SMTP id adf61e73a8af0-3cd0130416emr6883921637.18.1787135998592; Wed, 19 Aug 2026 03:39:58 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:a897:a9b5:e171:c935]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bef77fc0sm11169630eec.8.2026.08.19.03.39.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 03:39:58 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Miquel Raynal , Alexandre Belloni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Wolfram Sang , Magnus Damm Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar , stable@vger.kernel.org Subject: [PATCH v4 02/15] rtc: rzn1: Handle EPROBE_DEFER for optional pps interrupt Date: Wed, 19 Aug 2026 11:39:13 +0100 Message-ID: <20260819103926.2136712-3-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260819103926.2136712-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260819103926.2136712-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Check for -EPROBE_DEFER from platform_get_irq_byname_optional() and handle the deferred probe request properly. Although the "pps" interrupt is optional, an error code of -EPROBE_DEFER indicates that the interrupt subsystem is not yet ready. Intercept this specific error condition, assign it to the return value, and jump to the dis_runtime_pm label to avoid ignoring a valid probe deferral. Fixes: eea7791e00f33 ("rtc: rzn1: implement one-second accuracy for alarms") Cc: stable@vger.kernel.org Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v3->v4: - Added Reviewed-by tag from Wolfram. v2->v3: - No changes v1->v2: - No changes --- drivers/rtc/rtc-rzn1.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 305f10a8a85b..aa27ad7f5941 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -464,6 +464,10 @@ static int rzn1_rtc_probe(struct platform_device *pdev) } =20 irq =3D platform_get_irq_byname_optional(pdev, "pps"); + if (irq =3D=3D -EPROBE_DEFER) { + ret =3D irq; + goto dis_runtime_pm; + } if (irq >=3D 0) ret =3D devm_request_irq(&pdev->dev, irq, rzn1_rtc_1s_irq, 0, "RZN1 RTC = 1s", rtc); =20 --=20 2.43.0 From nobody Mon Sep 28 17:50:13 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5C5644C662 for ; Wed, 19 Aug 2026 10:40:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136008; cv=none; b=t/2+r+35kiq2HsOcDQ4XWwtLw8jIL0rkkjXugC3bplW1GnXv4CxTlVy2FOx/LypZTxo5zeYtYwLc09Kp7x40GG7Vt/MS21QeQthY89NPqne25tAZcN77YMwElpMeKiEqBquDJPeD8htlDB3WP2Lxl0cdtlOMKhAzpq1mRr1LvcQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136008; c=relaxed/simple; bh=5fmAaxImXhb9DVCIm6rQf2g2DAKEL8lDwCzTCOBuKFs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=f9GExGZKR24k/zBtRlGOGcH+WvpdRvFi2AsWrvATyoZ4URw4Bct7Wi2xNZecASjnjcF49wNEUatTqEfY2tQP4947nWsQlNov8enWF0BrgTWOyvNslyG4QtRMYFZVGNYIj23cO32W4WrRXPwvyHVyEr8oxJS/aGvD6jTKm5aghsk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T0PrZVgO; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T0PrZVgO" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-383cb94f742so1043350a91.3 for ; Wed, 19 Aug 2026 03:40:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787136006; x=1787740806; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=35kkPCJ/2LvdcW4cQVn4DKW/qTDdzoABPZcDG7evXUU=; b=T0PrZVgO0rdklDQmpw0xoLn+Ea3FEtRRQfEVgilN06KnmANu09WhO8uQ0/DYof8o7m hff/6EPz3gqYREBJGAyyqhNIKdqyhLCeZgs7ioSeU2JMB+2GrDbItgZ7ANHzxlY9UyJc P5qds2Ep5yXxOBQTFlcBr8cSunKD9YvJpmYLmrkKi3JbaKLxpEOJ01+2xsnh6/itdxol 9S24dAm4O692POu6B5anzck6FsMdt/0JCdxaKL8dHugYm4uVeaiwwBRmq9ILuj7nO3lD wKWhZAmT3wkAx75zYfD906F10URWzfBY3d5xFEu1Et0Bob8uPLmX/U12KtilG30iuSn9 hOqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787136006; x=1787740806; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=35kkPCJ/2LvdcW4cQVn4DKW/qTDdzoABPZcDG7evXUU=; b=PDAZWo3sxhBJdQn6pFZ1x9RlTaEFHHv4JSIg+uCNVxixbTcbqXA8WHS7/U+QeCocJs 61Je9sVg+q+v+7SM+ZabCoAGprz+d9ROsa+8YahwLB6QKfOQeh78lkydBJ/xTugWgNwp +cveQWPzO2ESp4rNZt7HGRUizo8/az7ApN3BmbXeC25HiH+s2Sn69V6fzRz8nLY1YS+p Aas4fkjBKhVSfa7uvUrkFcaVU8WKSZMy9z09vzeovTnuegEtyZbprSktWHeFb3/6Yqlv /LFGPe4QAfZBQ2a+QakbEa+OG9KhRUMBL2SHojUIaAthK3j5K2JuoWThH6BCzE/focnH uFKA== X-Forwarded-Encrypted: i=1; AHgh+Ro6odE1f9mcuammNqbWe+2wv2ETXt4qLORa1Gtub9fby6kD0TxCJgNQS2/cF90yMrFzxxrbXHC5GFO44Xc=@vger.kernel.org X-Gm-Message-State: AFuF++mzmEoQ+woIuxSQ5NlgERPxpMAoMgLkpRrJxksEbFtDtgGftZGU TJL4JK6F5z/Ug27Std0XSkgm3iBmk26cy6hClCgtHR0cx1JAvTdFp7wr X-Gm-Gg: AR+sD11U89CbSI1xZs3LFyfXYnox3dReZnrRr9s5nqkm7RPeCXL/mC+JaXthsrCO67F 7O1XRZkvZy6yjubNTwu6wt4IJuw8lKf/cnIIqrvf5/OuAVmt16i3miAFFnAXNzPHZrLDyRI3xmP u+cZKdbyly2XoX/0UCESiDsPQYxjvTOC7uertDYSTveDegC0NYlggD6v3x1scYDXZvgG/R22FQ7 7Zme6cayWyowtX2TWcaBR3L9T3i9S58e+W7A6TFxvIki2tMhOnFF3vnK7+W6/jWhH4VEk3MmNZj dw6j/46AeEuqA1rliO/GPfynFUe6rhDqes6HwuDwdgKDjCIViIkEFMce8KGNumyhr/ziqtKyG0F SwsiU4PREn+jEoSJOtGz4/EGK1LNXN9bD66MC1kM8RhQ85KtTq8sFT8RwP3MMhpIpFdmHW8MzqO qDC4RvSWH8qoN6UiS+MCuuxWUSNYf79uz+AYDl2UKL+cf2FIT6qyqIuku9/n+cmyNfg4k1jm+42 DDM3wn82HQ+mzF9WeuYe0NAnDe6q2LaDMutv60BVlK88OMIkr/U6JFgIQUTnEJQ3xeU+85zjYLF XLnMFpb9bQ== X-Received: by 2002:a17:90b:4d0b:b0:38c:a59b:5189 with SMTP id 98e67ed59e1d1-3958127d8bdmr6290926a91.15.1787136005521; Wed, 19 Aug 2026 03:40:05 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:a897:a9b5:e171:c935]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bef77fc0sm11169630eec.8.2026.08.19.03.39.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 03:40:05 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Miquel Raynal , Alexandre Belloni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Wolfram Sang , Magnus Damm Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar , stable@vger.kernel.org Subject: [PATCH v4 03/15] rtc: rzn1: Fix weekday underflow when alarm crosses month boundary Date: Wed, 19 Aug 2026 11:39:14 +0100 Message-ID: <20260819103926.2136712-4-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260819103926.2136712-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260819103926.2136712-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar rzn1_rtc_set_alarm() calculates the alarm weekday from the difference between the alarm day and the current day of the month. When the alarm crosses a month boundary, this difference can become negative. Since days_ahead is unsigned, it underflows and results in an incorrect weekday being programmed into RZN1_RTC_ALW. The RTC core already provides a fully populated struct rtc_time for the alarm, including the correct tm_wday. Use tm->tm_wday directly instead of recalculating the weekday from the day-of-month. This avoids the underflow and ensures alarms scheduled across a month boundary use the correct weekday. Fixes: b5ad1bf00d2c4 ("rtc: rzn1: Add alarm support") Cc: stable@vger.kernel.org Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Suggested-by: Wolfram Sang Tested-by: Wolfram Sang --- v3->v4: - Made use of tm->tm_wday directly instead of recalculating the weekday from the day-of-month. - Updated commit message. v2->v3: - New patch to fix weekday underflow when alarm crosses month boundary. --- drivers/rtc/rtc-rzn1.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index aa27ad7f5941..8c70dbf8c7ec 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -260,7 +260,6 @@ static int rzn1_rtc_set_alarm(struct device *dev, struc= t rtc_wkalrm *alrm) struct rzn1_rtc *rtc =3D dev_get_drvdata(dev); struct rtc_time *tm =3D &alrm->time, tm_now; unsigned long alarm, farest; - unsigned int days_ahead, wday; int ret; =20 ret =3D rzn1_rtc_read_time(dev, &tm_now); @@ -273,13 +272,9 @@ static int rzn1_rtc_set_alarm(struct device *dev, stru= ct rtc_wkalrm *alrm) if (time_after(alarm, farest)) return -ERANGE; =20 - /* Convert alarm day into week day */ - days_ahead =3D tm->tm_mday - tm_now.tm_mday; - wday =3D (tm_now.tm_wday + days_ahead) % 7; - writel(bin2bcd(tm->tm_min), rtc->base + RZN1_RTC_ALM); writel(bin2bcd(tm->tm_hour), rtc->base + RZN1_RTC_ALH); - writel(BIT(wday), rtc->base + RZN1_RTC_ALW); + writel(BIT(tm->tm_wday), rtc->base + RZN1_RTC_ALW); =20 rtc->tm_alarm =3D alrm->time; =20 --=20 2.43.0 From nobody Mon Sep 28 17:50:13 2026 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 665593FC5D3 for ; Wed, 19 Aug 2026 10:40:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136015; cv=none; b=q6sHhi118ZjPL78irajzMM+2geyYqQiAbjYztJTAfWlGAKCiDT8GYOOwcNJHZ4ltDJJ2zNAu80hwc/diDixRX1sORrUuTESesDN88/t8X/ouyhPKpWdvesPcWUVgvb/IOd/rbGGXv3qT/R/yalzbqdqvs0PCtq1W1hfc3tmO2+c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136015; c=relaxed/simple; bh=pIh3ZGCspa7wJibCNWZv+tmS81lRNPmMa6+/3QMQUqQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B4uw8QLvOp8tfOLvql+xIb239vdrxHZt6I5uEVgFf9Mpk9O8R4a/2ULRr65pvfgWGC//a4+DE8/MsOAhjIFUd376mQtvbhBQd6qmUywx75X3J0/X/fESNH1wlb48msJnLnMdSndvsmL952uMsdvwL7+stwru8pJlRwV3VNxbBhg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NZ/3OnoB; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NZ/3OnoB" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2d01663d816so6372675ad.1 for ; Wed, 19 Aug 2026 03:40:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787136012; x=1787740812; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=p35PMWuNq9g80SJw4x1gXCwK/9VH0twhB+7CIMwKn8A=; b=NZ/3OnoBR4f2aquP0yHpeu8ZCbBor9DH9V1nFTi7nRLrB58XQtmjqXdIE6niPDy0BY ofuJL3uVKRLjRFZxBkvjS+FSPzqYl1A+BHXSfgBmDGPGehIgLC9C5mPWMzmIxQwPGR0n 7SVQ4xy6cbxOtK2Wpi2lv1u3ZyV4tEKjAX2FuodAPRJiBmiIlj4B398lWo/d+bDgKFZm 8xIcxpvyMIzXfJwu2JIFbcXxYkrU9uL64dwWrGz49ynf24EbCy4LPLOJ4IE5A+RvQk/h CgkvtGeAfzHWop+xE68aIIutX1Bb1Pas6x9glu2BSwTgOdyn76G/NFxhszPlbBjI7u7g EnNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787136012; x=1787740812; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=p35PMWuNq9g80SJw4x1gXCwK/9VH0twhB+7CIMwKn8A=; b=jx6+tNCnNIF+zSJNMP3vRSar6cvBdOR3QYSWFXuMHjgLynTm+QJQubCMR4wOZZf9ph 4UI4m2yTIQiLEs1Tm+w6Z4XH8pk0Sdumfz93Z26A6SDAQGl1TeLA88N+/Ggx617XpC/E SqYQvdjMRhSmO0HlkVJNgJC2AKxZwYH6mc2NRd8rFHOaBqDaOVueyHwSEoH6we14Frov JTFqtFjZvdAuaHkfpe21MTxer/DA5wpxnQW1tD4RODIgITepZV5JpGKzw9ijhv2YqqVU lJ0MFSbNueRjb560OxACoTyf5f7nSfYp6Mf2hWcaZ4RR2GCFKndyImbalu3zEvUYwD2F ifTg== X-Forwarded-Encrypted: i=1; AHgh+RqepOYIDlpSXyF35aH+OkLfvY4y/G4jJ/7iGyaJKHnnH0c8bD0dqPZ+RbtW936TxnQTiqHAmt1KiyvLMQs=@vger.kernel.org X-Gm-Message-State: AFuF++nfMTjCzMPDQqZKQ0wKRFT/aD0BWsdG5hnZdSLU5CzXbI0T/xwc FeWgkhs0wNSNMT4UumGdY29elMBwou9q+/8MQxXyOh9MlW2JbwaJra5h X-Gm-Gg: AR+sD13rmWLyb8IfAfMi1lesfwOCwRkpCkrNLAgEfaRLSIKZLIhDT2tcSD71b1z/JJH TJSZdGRpTTL8o6i3D0jzaIzNmKJowm7IBof+VD6rjUaSfVfzCrWX+jUazCPAtkcYnJjZFiShD8v 07ez4Ee2qtk69+Yv86aLLHAEZKoOn4HV6AyipYCMNk1M4+UwtJ4hlg3oNgPlVcYJIKE+eqiwdPE FDOKhsQWzuasBQRYVzbqRFJ+69mbyInFM/c0VGbWPptM8zK8FBrSv7kv+ahgS7QR+WJ8c1MN1g1 UTibiFs36gi6nDCG04sU7vJMPlRXicmaYX0cXwUd9o5AcxanyyG5k90BETfc+aOKhxB/TxsgsyE B1HEllklMnkxzCEGJajlcK1CWmjy7iyL4e640Eu25jaKf2YWs3ddv+nNzeC4HtVFRv/7zNnCPAL vKpnUcbbddZTAPAoDnYvx0IfAOK4hyZSDaFtIbkvKnd+u0oNcm/Dk8TxVDSyCmwBBxQgHEBLtlP Iv7zx3c40jgdhk38kUUcXAbm3pBHt0q1JaxRgkdE/0i0Ky5xbW71caV4PkQU63D6qMkN8lBTn3w xsj5HprEvQ== X-Received: by 2002:a17:903:1aa3:b0:2d0:8b28:51ab with SMTP id d9443c01a7336-2d5fd710544mr71371885ad.7.1787136012388; Wed, 19 Aug 2026 03:40:12 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:a897:a9b5:e171:c935]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bef77fc0sm11169630eec.8.2026.08.19.03.40.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 03:40:11 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Miquel Raynal , Alexandre Belloni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Wolfram Sang , Magnus Damm Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v4 04/15] rtc: rzn1: Fix malformed MODULE_AUTHOR string Date: Wed, 19 Aug 2026 11:39:15 +0100 Message-ID: <20260819103926.2136712-5-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260819103926.2136712-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260819103926.2136712-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Fix a malformed MODULE_AUTHOR macro in the rtc-rzn1 driver where a missing closing angle bracket on the second author entry creates an invalid format. Correct it to the standard "Name " format. Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v3->v4: - No changes. v2->v3: - No changes. v1->v2: - Added Reviewed-by tags. --- drivers/rtc/rtc-rzn1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 8c70dbf8c7ec..d03d252fdfe1 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -511,6 +511,6 @@ static struct platform_driver rzn1_rtc_driver =3D { module_platform_driver(rzn1_rtc_driver); =20 MODULE_AUTHOR("Michel Pollet "); -MODULE_AUTHOR("Miquel Raynal "); MODULE_DESCRIPTION("RZ/N1 RTC driver"); MODULE_LICENSE("GPL"); --=20 2.43.0 From nobody Mon Sep 28 17:50:13 2026 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 002743438B7 for ; Wed, 19 Aug 2026 10:40:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136022; cv=none; b=Tl/t/tw9HwJ/bA1ldvEHzhjJKtKd5ddTTBXPBvOZijSKA8uRYZUPtB9OddLPZYR//DzMROR4lDSgoVgY1Qn5U36UfBk2tlSDJY+vLpz0qxxAE58wuProaM5xF4DTAwu782oQi11hYYBiTLe3fsb8BCjWGamupvpaN17nmMLrvVs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136022; c=relaxed/simple; bh=DY0q0xPx63XcLnbKsfqeJS12HVZomAtI+ZEXuXm8Sio=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=avNwJenyO9eHy+TQQqfVUqr5SAYdsGVB1CKw7pl2Novk9foXId0JBjVzCQEBmcotpLJ4mcTavY/JwcvMI91lStSdK1ueDMmUIRwYgX7j5gp9tXJoFrNJUDhSGsIHzt8ff5iLOwnUov+d1gsr9S3isgBX1/HfqAmOfhgaA0LwcCw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=razxKpvY; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="razxKpvY" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-38a0c7e841fso1338263a91.2 for ; Wed, 19 Aug 2026 03:40:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787136019; x=1787740819; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=uGtbsIyEK58caKUAI4NkFCHbnbaFbCN/BWCCBxCs0Ek=; b=razxKpvYAHmvBivGgHX66raEsksttSnRdC9Ad9+jMaVAIWjWuz65YKSOm2CIDtObt6 soIuehqYCU8gHleCpUj+Av75cyteLBpSRoZBeRAtwoS5sy12OCcrl+y6G7bTbzPRngLM 34rW8iaf6TNlfk4zfdlwKK8ncBOc01XCFEbCOaDcrMNCV4GsZ4wVAuvbkKdXVxaF4ANr ntxiw8nhhSRkARqLInp+xdu0NCp/WeVoa03miBXSijEaF3RhkaYcr6mgI4/zfpR1hr+z KSC2BsfEqz79LMxeE6S+JtgEXgidyEJ2cuGXNr5pthzgPem5tTDaVRQgQETbww6zRcZn E3/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787136019; x=1787740819; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=uGtbsIyEK58caKUAI4NkFCHbnbaFbCN/BWCCBxCs0Ek=; b=U+mVJ3DZAq+68JEo/1bSxHPI85Uw1cRZpan7T5hSQDAYKUGLGWdACpMi9BQbBg6sUm xofX08Q0M4auAyzvGGlM6rkHtPz9ab1Ikdt762zibtZkFjotWnLFb52hPUw+lEE0IcAm BiCMSTo8HYNvzEqUFCi0F/T8HCMLj7YPZs3BV6mUOEVCpkd+ZwI0k/v003q8KvBh/T8U 3XFBIn1eIuthCw7mjV1DtW1g2ySyyfHl/CVB3/V65/sgHCm1rnlIH+RZgcD2y83CC7FA i/NUw9kRQJwHAHhMSdUE1aEb0rh2i517qCa9O+0nvq6zzwUdZmU1LNNTSqKSqbP8Sr7e A0iw== X-Forwarded-Encrypted: i=1; AHgh+RrWX3fTlfJ5O6uh8SWHPho1gM8piTO7SlJnNISGm/qsf2VM+4t0Q/OmT4HLSHOl0r6JhwaepiIkyHqje8g=@vger.kernel.org X-Gm-Message-State: AFuF++mDflLNWWpKEob4LK0XZZ3tohvhX08SyP7DGTpO92dxdTeOt/h/ zLiMsd3Pz9eAt4uSkxavlqgKiOdGKm9VDX6R1TcqKgtxbrRU/5yceHpN X-Gm-Gg: AR+sD10XWHEqZ7/CIw13JSUo6Iy5LDS4zANUjRQoM7dLT1F/bpAFf4wyc9CK9/7ZHfM cHhzculMRwMRZvVWep0nOu8pboOxknfoAd2jp+p0z2SNuBbDTVXYDUBpgsTHvEbLGUGoF3V4Mo5 lUjwelDXIzPFvkGMfnwZGZKIPbV1c4aQigLJN7DMuqukhq7TPzPf77J5VdUOR/MMsfBP6ReEzdr tZUBTNq5ORujYIoEX85CpvHWPDHuQ2PAgTDOrEjpobrpGB02ONP6KQOSxjXiqx8MQI2zPlOIUFg 2Ob7S4juIkw9+MacBFUk4OX0onVJPC4m9Sj84dLcS3UQRADVOWsY7t6kSPgWyn0XLh6VwnUswtU IMWCiU7jbXuDBoj6WczqEaQo3oy57imUh7f60D3LC2ISqU5tdw8NKRtbOdsxh0aFb3ayalmLCi5 xKO5AnS3iOtWrH1GydUcLDBA+njq43AZ9WQM3uJfxCtNxrLbWVGhWyr2XyHZxxv5mW/KdCVxPLw 00yO0zmbGxJylfxMqLgeLClbgDTOmDNsVHmXEIdBZgRQNQpbeJ6EUB6smBS9D/KxI32+dgVHC+G 5f26bUjgxvSMcHcKiXt9 X-Received: by 2002:a17:90a:fc45:b0:38a:c3f:3b87 with SMTP id 98e67ed59e1d1-39580f6d136mr7421193a91.12.1787136019196; Wed, 19 Aug 2026 03:40:19 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:a897:a9b5:e171:c935]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bef77fc0sm11169630eec.8.2026.08.19.03.40.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 03:40:18 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Miquel Raynal , Alexandre Belloni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Wolfram Sang , Magnus Damm Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v4 05/15] rtc: Kconfig: Broaden RTC_DRV_RZN1 dependency to ARCH_RENESAS Date: Wed, 19 Aug 2026 11:39:16 +0100 Message-ID: <20260819103926.2136712-6-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260819103926.2136712-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260819103926.2136712-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Replace the ARCH_RZN1 dependency with ARCH_RENESAS for the RTC_DRV_RZN1 config option to make the driver available across both ARM32 and ARM64 Renesas architectures. The newer RZ/T2H and RZ/N2H ARM64 SoCs integrate a closely related variant of the RTC IP block found on the RZ/N1 SoCs. Update the build dependency and expand the Kconfig help text to allow this driver to be selected for these additional platforms. Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v3->v4: - Added Reviewed-by tag from Wolfram. v2->v3: - No changes. v1->v2: - Updated help text to keep it generic and not specific to RZ/N1 SoCs. --- drivers/rtc/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index 01def8231873..d23a0fbe8d89 100644 --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -1635,10 +1635,11 @@ config RTC_DRV_RS5C313 =20 config RTC_DRV_RZN1 tristate "Renesas RZ/N1 RTC" - depends on ARCH_RZN1 || COMPILE_TEST + depends on ARCH_RENESAS || COMPILE_TEST depends on OF && HAS_IOMEM help - If you say yes here you get support for the Renesas RZ/N1 RTC. + If you say yes here you get support for the RTC initially found on + Renesas RZ/N1 SoCs. =20 config RTC_DRV_GENERIC tristate "Generic RTC support" --=20 2.43.0 From nobody Mon Sep 28 17:50:13 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33E2444AB9A for ; Wed, 19 Aug 2026 10:40:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136027; cv=none; b=NnKDsX92uef8ZjVK+aZmj2Q2hlDf1d4fpGN8kfDNx0orE5d0AwVTcOwLEpwc0D50hcGizaP6Qd0QeUVOdRmJicjGTDlkY8F0cE5MBDANQCubLjB7s6nnIcTuQ2KHXaf1VpzE8GT1ATdlecbiwg62sTLlz/7ey8EqOwC9oKH/e94= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136027; c=relaxed/simple; bh=3BUzoj28E6V8GJmTinFm2vYFBwCspjBgpneyKufA2pw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Wpcv52VeqadmuIWdIu2U74PBLqJZ17dGRTJ413YbHaPKNK+KJDSqvulE0pOxxFh6rMGUDCiurHaTd87GzD3lzh8b3ldvPeNZK+nCiTYPaZnx0jLbm593QJJfk1GPYQBZGmXkLpHuABYa08XVwYnacuKo8SJk3wRGMTVwGFaVDuU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ThUVolbL; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ThUVolbL" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-381b831d535so1441132a91.0 for ; Wed, 19 Aug 2026 03:40:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787136025; x=1787740825; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mRLnlvi+bhNjkkBKcOqI3gaZTagiJN+P03FYzuxJbNM=; b=ThUVolbLUE+JNfhklCa/1O+6fecJ5vwoGdBvHOtfcZKxqFtEb8n8zXlioykGYfTUfz KSDAlhtOBkbgd+5oCBQhFxSOSX0dH6bISINylnVBxws7fwfJ7b5Rhecr6EpiJGGyfFX/ TnAHC4Xsu0YacxREXLU+TjVKrMEThf1jNNxPc943FzLf/gPGLPKhznlCqqSEYDNacG+N S2RVP5eK8MTqXjq+gHBeIHNmrHXC9algN/7RjLj/LKuPqwgPzyc+e11MVf7MG65xbndh Xu7K1dDQvuoPeMIqXDmymSK49vkURPMnr3X8OlHediGnZdijx6EHxHMTFUwXj0Dw3i96 VWUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787136025; x=1787740825; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=mRLnlvi+bhNjkkBKcOqI3gaZTagiJN+P03FYzuxJbNM=; b=Fe9DiPjjg4Ww5o7BfwJBsehCz21tzV9wftJTPdCS3XXJ5mF8MZ9rEmL54axFQpfd7/ t50n4CwAT4uzgMAdchWJiDShyZ4CgpQoyHfI7eWdv/62o/LC9hF+dYk77mvVGZxLpcxv DnjFeaGpRSFI9V3x9TU9kJ9VwmW5MS3y9mKR2ge0dxeFWQqcfJ8afQdhQCmQUfSdbMU4 Sl6Gn3T+YXSqTJzZ3jUfl0dRPz4o8O6aB7ktoydW2n3/of7tLrrqZioLySSLg79qGQRD m9ck79FHv/4zJ3fbz0yH+7xFsAtAK+B/yRxd4vOtY5wx0kffNUu/atA/0sNKSqsqKjQ/ Gosg== X-Forwarded-Encrypted: i=1; AHgh+RoEb9O0Z9T6n6BZCVhxOJ6c0MyMkwd8wCgaxKlenBE4GVqgwc8PTl54XXoh/TodBjc4ioz4S+3+R3lOOWA=@vger.kernel.org X-Gm-Message-State: AFuF++nQmlHTG8rU16mwNQmcVIj/tp8+JEtxkhio7OslxNX6xGwhHjof psgsYx9PUeB1sl9vk5kiLSQLbwc920Rov55Ax4hYRoDP12kSEJYyzOrL X-Gm-Gg: AR+sD10uK4VLLzJrwCMldJVS5YVJLb1QfS53XZ9TO0uG2jXNjzDXEKwB2c5jJDkWXxS 4v48QhnFt4QwxGMKTAZ3ZAHARXHFf4ZDmz3KsQ9UFMoAExHuNwsQ0rXIfnXsZSUFVCvDi3YC5iT NLMnr3IKdeEyVVQyI//9fNsdGQyZ2/LQA64l5B03tmIEJRa7N3YOzH+/VK8x/QwKlQjIvZhsjFL QzZEnwYVeyn4nAAcrYuvQ+Y1anXtkSU7xopQgcJhlstdrm01KXKka/j1qWeyZBPbrz3FD+/gTJJ gX1UJfF24ZhuRtLXMy74hjMFJb35a8PeMuXFfPqBzevAtE84YhGYDLR7eEPCfuMwAF6vABXRZtR iDDeshnYWtbPMLt4Dpl4qF/HN79OTKSitdjAiPp6tP3C9FHPFiJGdjdtMTgKoOcJwtTufWZ8dwO mNqzeLmAwE1jFFVx3HcREXILQEPP7s86BvNzUCBTkhvgw2nXGbzexc3ozIBXW9tHD5UyYRxFcAR Y1IYCa4ZXsxlx9z9aFY1Qm5EsiqDU8nwaBC1QDbd6WxsegEz94RJzXlfreBuuWgAAxnKLYQyaoH KKX1WrkT7A== X-Received: by 2002:a17:90a:fc45:b0:38a:c3f:3b87 with SMTP id 98e67ed59e1d1-39580f6d136mr7422152a91.12.1787136025518; Wed, 19 Aug 2026 03:40:25 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:a897:a9b5:e171:c935]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bef77fc0sm11169630eec.8.2026.08.19.03.40.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 03:40:24 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Miquel Raynal , Alexandre Belloni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Wolfram Sang , Magnus Damm Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v4 06/15] rtc: rzn1: Fix alarm range check truncation on 32-bit systems Date: Wed, 19 Aug 2026 11:39:17 +0100 Message-ID: <20260819103926.2136712-7-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260819103926.2136712-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260819103926.2136712-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar alarm and farest were declared as unsigned long, but rtc_tm_to_time64() returns time64_t (s64). On 32-bit systems where unsigned long is 32 bits, the assignment silently truncates the upper 32 bits of the timestamp. Fix by declaring alarm and farest as time64_t and replacing time_after() with a direct signed comparison, which is correct for time64_t values that will never realistically overflow. Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v3->v4: - Added Reviewed-by tag from Wolfram. v2->v3: - No changes. v1->v2: - Added Reviewed-by tag. --- drivers/rtc/rtc-rzn1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index d03d252fdfe1..94d592e88a04 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -259,7 +259,7 @@ static int rzn1_rtc_set_alarm(struct device *dev, struc= t rtc_wkalrm *alrm) { struct rzn1_rtc *rtc =3D dev_get_drvdata(dev); struct rtc_time *tm =3D &alrm->time, tm_now; - unsigned long alarm, farest; + time64_t alarm, farest; int ret; =20 ret =3D rzn1_rtc_read_time(dev, &tm_now); @@ -269,7 +269,7 @@ static int rzn1_rtc_set_alarm(struct device *dev, struc= t rtc_wkalrm *alrm) /* We cannot set alarms more than one week ahead */ farest =3D rtc_tm_to_time64(&tm_now) + rtc->rtcdev->alarm_offset_max; alarm =3D rtc_tm_to_time64(tm); - if (time_after(alarm, farest)) + if (alarm > farest) return -ERANGE; =20 writel(bin2bcd(tm->tm_min), rtc->base + RZN1_RTC_ALM); --=20 2.43.0 From nobody Mon Sep 28 17:50:13 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B063448BB3 for ; Wed, 19 Aug 2026 10:40:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136033; cv=none; b=P/4Lp4eOAZtU6WI4Jgk0rtv+XP3AbRIS2EdrIBkWGHl7zpnvsQzQ6aqQwARQUH+OF4GfBAfrPV5qphHq4FFvYE4oW3EP7+e5Yc5E9VcZIfoB9+4M8BwqEHSlOlAIrEh/Clv/zIOhScAYQcjHAq20pqmax0QXQAZdt+wzsxGgWNk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136033; c=relaxed/simple; bh=aTcOo0XibAPOtRvO+8kyvsr/qOC9+prnWMiglEoD9Tg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qafXQbn9uHznxV6ok9qjrxMTVoGDE+rWyLiB5dvrp1Z9xz/G/d9ka1ln6rM25F/4XYCurFhfMHCWChMfho1IlQXlev89tmCp4AD7Ftf6L8kPwu2oNmcOWnkIdsZVNM8h0Yt1Et709keNegtJvit7+g3o3Q59SkPF7Za0Beyu6Wk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OeKfFoVE; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OeKfFoVE" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2caf228a910so5565155ad.2 for ; Wed, 19 Aug 2026 03:40:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787136031; x=1787740831; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XJmShcdu2pD9ZAClgzTisDQ5+0emOusWZQx2PntskkA=; b=OeKfFoVEawaweUbXWl9789KAjrlr2LKSFS4qCzHFOze0WWGrDO8EtLvADKtEbnmZZh k1NGNGAqFCjQkS8p0ZWC2nL2n4Nx5H6lUpw8A3vi8Dv9hqSy61Sk/F3AYkLDm4G/ROgh rDR+/zRnElveCejxZCGNm1Dy/7zkyC7eNRniMI0EvCdc4GQo72mFoeFzXL2wNEO1C3Ym KB7M4xe0CSaAtSxwp4/AwR9QQtrPQv2OWFLH3Dc3tlVPjynpToh3AuUTaex+47R6x3q4 sXYYvmVnQQY2uRIIrSpn7ckm3GnFO4bqKJfZUGVX2UlxBhCD5/70rf8QcVLe77qMU/Iy hoUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787136031; x=1787740831; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=XJmShcdu2pD9ZAClgzTisDQ5+0emOusWZQx2PntskkA=; b=eQkI161TJHCA5yEx1eXpKdWOTTnw7kZPm3PKJT+pxC95AOPvbXk6hgvHgE+5UNbHv7 ywzHAm9H+fOhxa5AlvDPTcBgvsPIX+exidS4J23a9pHNYOIQmZZV32pT0vWOe9YrQRga yhahrSYCwAqwW722aFDrmjVTHX6flYQLg/g9xuQ7DEdJ3sz72eORf/CIw8cv66IIF/jh wJqwUYq8K8Vs9+zV99E59GD21salRBT08UkQABHhvMNUZgoVJgwVcz4rnM+VCORP47If iOyfGEcG+lUaf55+bC5Iuzn4qHLz2Q1K4A8g9j/dG2pFYVe4OuXUV4WIUcTScrvpw75T V5hw== X-Forwarded-Encrypted: i=1; AHgh+Rp3iPUVqr67AbP657IVO3WEYDlGESvRkgPs5nVkEpG6nbmet65owQXXKQJsgXdp6e72C8J8KG2ZL+aJaYo=@vger.kernel.org X-Gm-Message-State: AFuF++lDq9VhSg3/FJcYd40C9CKRZvlOZmGIu0UJS1uC11BoPZLoghEG bp1kj6Y0vMxOjBlBy66Onxl8TaDTvhLbsvxSJjGI/pNHW7nompJckOCc X-Gm-Gg: AR+sD11F6fsJ+2ruoEzjGZbFAxYRQzbwq0vBJsH9iuZjV3M1gMmwyatAK3db/NFIv11 CvoN1MmE5P6wP8NTLeTNxUyGfcKX0TW9Jn5xFhigEk++RgzeaL/q3BLND/ehuyX35s9erSA64J6 h0Gjh1eqgfgfEiLbRsjNXRYMUsUz2jDEC4XAINNMjfOfmKqA25yszhJReXwdx97tmONehb2UYzy VUWyDjvXSlC0syh4QDcEiruxZ25ihA6WgAc2C2SiEFOK527dPRMDSPlnY7+0YJDB7fZI/JJ2Xbc BG3PFbi9ZNHH1A9l/uGLcuWR22k4Er03j2CZkeiVeSY6SpdCZImppYUiFWSEVNaLw5i6fRrEBiY RhBzH7A1I2T/DK4ZDNTeg8VII6t+Fk8polUTCa7vdMUImUXKAnU1Z8T/vgLqg6wXlMhaqR4j3Ox EPGrpaOFpSLAnG31Cax7xbM0mpzHpIHCyqT3bNUQfgMnIMLZs7sV+8XTjSGEulfQWJREX6VdYdm m9AviSBUfWdkOusBwOoeOIsHzTem5usIUblLeRJLUdbh9J3GY9AqIhAYmV+eDcdic1boPmT5YXA L0bh1BFXmg== X-Received: by 2002:a17:903:3887:b0:2d1:1a18:4d0a with SMTP id d9443c01a7336-2d5fd740167mr64973755ad.9.1787136031538; Wed, 19 Aug 2026 03:40:31 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:a897:a9b5:e171:c935]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bef77fc0sm11169630eec.8.2026.08.19.03.40.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 03:40:31 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Miquel Raynal , Alexandre Belloni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Wolfram Sang , Magnus Damm Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v4 07/15] rtc: rzn1: Replace remove callback with devm_add_action_or_reset() Date: Wed, 19 Aug 2026 11:39:18 +0100 Message-ID: <20260819103926.2136712-8-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260819103926.2136712-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260819103926.2136712-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Simplify the driver teardown by registering a managed cleanup action with devm_add_action_or_reset(). This eliminates the explicit probe error path and allows the .remove() callback to be dropped. Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v3->v4: - Added Reviewed-by tag from Wolfram. v2->v3: - New patch to replace the remove callback with devm_add_action_or_reset(). --- drivers/rtc/rtc-rzn1.c | 56 +++++++++++++++++------------------------- 1 file changed, 23 insertions(+), 33 deletions(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 94d592e88a04..da7d13337c0d 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -371,6 +371,17 @@ static const struct rtc_class_ops rzn1_rtc_ops_scmp = =3D { .alarm_irq_enable =3D rzn1_rtc_alarm_irq_enable, }; =20 +static void rzn1_rtc_disable_hardware(void *data) +{ + struct device *dev =3D data; + struct rzn1_rtc *rtc =3D dev_get_drvdata(dev); + + /* Disable all interrupts */ + writel(0, rtc->base + RZN1_RTC_CTL1); + + pm_runtime_put(dev); +} + static int rzn1_rtc_probe(struct platform_device *pdev) { struct rzn1_rtc *rtc; @@ -408,18 +419,19 @@ static int rzn1_rtc_probe(struct platform_device *pde= v) if (ret < 0) return ret; =20 + ret =3D devm_add_action_or_reset(&pdev->dev, rzn1_rtc_disable_hardware, &= pdev->dev); + if (ret) + return ret; + /* Only switch to scmp if we have an xtal clock with a valid rate and != =3D 32768 */ xtal =3D devm_clk_get_optional(&pdev->dev, "xtal"); if (IS_ERR(xtal)) { - ret =3D PTR_ERR(xtal); - goto dis_runtime_pm; + return PTR_ERR(xtal); } else if (xtal) { rate =3D clk_get_rate(xtal); =20 - if (rate < 32000 || rate > BIT(22)) { - ret =3D -EOPNOTSUPP; - goto dis_runtime_pm; - } + if (rate < 32000 || rate > BIT(22)) + return -EOPNOTSUPP; =20 if (rate !=3D 32768) scmp_val =3D RZN1_RTC_CTL0_SLSB_SCMP; @@ -432,7 +444,7 @@ static int rzn1_rtc_probe(struct platform_device *pdev) ret =3D readl_poll_timeout(rtc->base + RZN1_RTC_CTL0, val, !(val & RZN1_RTC_CTL0_CEST), 62, 123); if (ret) - goto dis_runtime_pm; + return ret; =20 /* Set desired modes leaving the controller disabled */ writel(RZN1_RTC_CTL0_AMPM | scmp_val, rtc->base + RZN1_RTC_CTL0); @@ -455,14 +467,12 @@ static int rzn1_rtc_probe(struct platform_device *pde= v) ret =3D devm_request_irq(&pdev->dev, irq, rzn1_rtc_alarm_irq, 0, "RZN1 RT= C Alarm", rtc); if (ret) { dev_err(&pdev->dev, "RTC alarm interrupt not available\n"); - goto dis_runtime_pm; + return ret; } =20 irq =3D platform_get_irq_byname_optional(pdev, "pps"); - if (irq =3D=3D -EPROBE_DEFER) { - ret =3D irq; - goto dis_runtime_pm; - } + if (irq =3D=3D -EPROBE_DEFER) + return irq; if (irq >=3D 0) ret =3D devm_request_irq(&pdev->dev, irq, rzn1_rtc_1s_irq, 0, "RZN1 RTC = 1s", rtc); =20 @@ -472,26 +482,7 @@ static int rzn1_rtc_probe(struct platform_device *pdev) dev_warn(&pdev->dev, "RTC pps interrupt not available. Alarm has only mi= nute accuracy\n"); } =20 - ret =3D devm_rtc_register_device(rtc->rtcdev); - if (ret) - goto dis_runtime_pm; - - return 0; - -dis_runtime_pm: - pm_runtime_put(&pdev->dev); - - return ret; -} - -static void rzn1_rtc_remove(struct platform_device *pdev) -{ - struct rzn1_rtc *rtc =3D platform_get_drvdata(pdev); - - /* Disable all interrupts */ - writel(0, rtc->base + RZN1_RTC_CTL1); - - pm_runtime_put(&pdev->dev); + return devm_rtc_register_device(rtc->rtcdev); } =20 static const struct of_device_id rzn1_rtc_of_match[] =3D { @@ -502,7 +493,6 @@ MODULE_DEVICE_TABLE(of, rzn1_rtc_of_match); =20 static struct platform_driver rzn1_rtc_driver =3D { .probe =3D rzn1_rtc_probe, - .remove =3D rzn1_rtc_remove, .driver =3D { .name =3D "rzn1-rtc", .of_match_table =3D rzn1_rtc_of_match, --=20 2.43.0 From nobody Mon Sep 28 17:50:13 2026 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B735744AB90 for ; Wed, 19 Aug 2026 10:40:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136040; cv=none; b=Q2f3Of8byEYZxUccpqcfStQSEbbHc51MLFKrJXWx7o6wDRXkOrri9EKRaVberccjCccyJ7CPKgce3zflZLN4k/FG75N+kEVWHl7Vwu9dpQ+tEo/Q69aYc7/wWXApZaq4B1epfqP9kuujGOXvcr3cgMq1En9Jahb6FWUozG9MA7w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136040; c=relaxed/simple; bh=RCjmT/Q7v1w5wuF6vPZbR3owes4uAzeW/tyOyXg5scg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AGVzxISlw58Z66S4RboQOk1JGvB7zy0IE+7dEz49zfZa6jkSUqE6dGIL0pK1sSuQoyHPxJrdMm+pNPylzIwp9xY4nr6jcVRPIj+p0vrQTdYXzG6/kS6o/eK6Rik4Wo0b2srMGaqQOowWFGRdurZV4+KZRiZ1XtboYtB5lMH8HFk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gioJdU91; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gioJdU91" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-cc11a30a259so737673a12.3 for ; Wed, 19 Aug 2026 03:40:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787136038; x=1787740838; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Dnzc7GZdTOxbd3quZMussPF4U86iKiRKoVv0Cicg+UM=; b=gioJdU914pfgZMP1JNEi6KSIhGuzS5bFVENuZcuuP5skVfDhcmUHav8nmA++Hufmwv Q9ltH+CPhJIMx9ORbptz4I2/Mog4bhGAnOzyRK4v3Y+tb0HFBBiY+nOjBd0qz8kg4MZo Y0BN3WLb/8NEDcd+M+yMbZ+miNr399Qd5UhORvKf1GVKAoobaB9c21NIkdXwkl9NwtbM qz/zvcTS3ToFCOZvprSWcqN0VscrtrdS9lJmFVYv8S9chOP6ZmQexyUqEC6e+8ZC+Hn6 MAkOjrvdmwN2xopiA8nukpT2mb/8Lyduppq82Ej9WEcCA4prlnbLMFfBvuMagU3dFWnI VkKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787136038; x=1787740838; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Dnzc7GZdTOxbd3quZMussPF4U86iKiRKoVv0Cicg+UM=; b=niIZNwSx4jPj5ljlxwkcrpUkccZCGVghTTZz/LweepHe7aE/LnYPZj1P9988TI8Qg5 dYzAn9ifEz9W+LVqW/ASWimGDGacR1Quzm+ddaiRO0PQw9WAAcQVjSbViE6Iz2pWI/5w ReM2+7oGSOflYN2a4Zcrgb7o0KhWqSBnd7rSESqSHoxuIAWkDHrMR27HVkokcdvVdfKn bsTYGnnYwzGXMBdRqkd6tpPAcDbb+rxNd9iTAkWwuPyGZ0AosclgzVeGx3aQDIojgVpQ IOYNC8/Dz2wkdQ0jidc8aNc61c0kFn1J51iXQFpTW+TpTIIY9a32escJseIu1LwjP29O H+RA== X-Forwarded-Encrypted: i=1; AHgh+RqMP259WIn+mOAR2ttkUrlYAEbiQSxJ0lZ+ntBOsE2UN3KBJNFrn7q6+9vVVZEqbLzHFunj7BB87oV+RWs=@vger.kernel.org X-Gm-Message-State: AOJu0YzNiGzqI2byeAAQvp3PH52M9YoW3ozv4YL4MMntFwbnHSAlAXQ5 uwhBRLCzpFKMbcDpDCUxFjbCyavMfaTELUk2huM9CPPLBU9i8146GLLA X-Gm-Gg: AR+sD12q1RH33HLCoc1pRLEkrZ3I7C2UwNB2BiKdUgMZoG6GHmu1pqyqlEftU+2re+o 8gK/tk+vk13XCw//BDps8rIlcG5WMV5pXOKiUTyIZ3sneb1YbAGUi8P/I4V92X073CcISzqcGgC Owqw29+Q3lzrCsl8kAO4sJsv3en8ZSsVMn24G7TfL7pywTcC+NzWCM0Xd8KIU98CiYKRP/JcW3x ZvQOIgCblMPfFTZAnUM1yTr9MG7zfOjaYh9G8L1GF6RhmeKWu+3rRby0dYyNPlhpBAffe2ZHh96 c2MWKG+/Kx4gPFWpa8RcJVFuDS4PX3b6ocJu8uPHoodh48W+OPVfG6ha2ISyuRQhKw0kUc/or7I V8UbtZ5inN355zt6iTegT7ApltCCp45GYTJZsXcYG2xiALyrVX2i9biJtmsY5vW2NlCOIpcj9em n0Pg7mv0lbQULT+G4jm/sGqJaP8PvPGMVJMubTH1+BMXe4QNzsry+tLku/tyADOE0FrcYsAFzih FnhNiZijEBbj124FuY2eEi1BvfgQz5XlmRKDft+azm56LOIi7AZlBmH17xo6g26sosx3I8zZl+j qKtmn4kgZmriZSvSilkY X-Received: by 2002:a05:6a20:7f92:b0:3c3:a3f4:5485 with SMTP id adf61e73a8af0-3cd00e53f45mr7055144637.6.1787136037960; Wed, 19 Aug 2026 03:40:37 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:a897:a9b5:e171:c935]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bef77fc0sm11169630eec.8.2026.08.19.03.40.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 03:40:37 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Miquel Raynal , Alexandre Belloni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Wolfram Sang , Magnus Damm Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v4 08/15] rtc: rzn1: Use pm_runtime_put_sync() in rzn1_rtc_disable_hardware() Date: Wed, 19 Aug 2026 11:39:19 +0100 Message-ID: <20260819103926.2136712-9-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260819103926.2136712-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260819103926.2136712-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar pm_runtime_put() may trigger the idle check after pm_runtime_disable() is run as part of devm_pm_runtime_enable()'s cleanup action, leaving runtime PM active. Use pm_runtime_put_sync() to ensure the idle check runs synchronously. Signed-off-by: Lad Prabhakar Tested-by: Wolfram Sang --- v3->v4: - New patch --- drivers/rtc/rtc-rzn1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index da7d13337c0d..425d9590c55b 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -379,7 +379,7 @@ static void rzn1_rtc_disable_hardware(void *data) /* Disable all interrupts */ writel(0, rtc->base + RZN1_RTC_CTL1); =20 - pm_runtime_put(dev); + pm_runtime_put_sync(dev); } =20 static int rzn1_rtc_probe(struct platform_device *pdev) --=20 2.43.0 From nobody Mon Sep 28 17:50:13 2026 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18B0544AB9A for ; Wed, 19 Aug 2026 10:40:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136047; cv=none; b=HGwJ8asu57fCvtZkLyP9dnH6h1zXlMKTv0qcRR7Y435aLntjZAbSrbIauuBH9vONedQJW+1KCtr1urIarV+NTp2PGiAIdmsjR4AuFPkKlQoex4XPy+rWj+uR39Y6LaXac/0Xnp9hkYSND+isji76VvLYYxxlePesZsB97f+ZoPU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136047; c=relaxed/simple; bh=o0gQVCX2jUgC0OSispZmWD76pHaSa5t7YdNfc6z+j/8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gxMVmjV6N+m0cTuJrKdjJbXtHqANI10/nWQQbIR4XoOHktbsedr8Jwikhya1zt2XwTTjhSZT9/86yosJa2Xgk/yHm5+I7HA1um6bZ8vZDtjbJAXtaRANQNIA75Nr4AUFo1CHiMANL7eZEJF9FD1KihCwA7uNIbXP5lWhrGwaSHM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IZXorDvq; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IZXorDvq" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-ca00f126b7eso494539a12.2 for ; Wed, 19 Aug 2026 03:40:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787136045; x=1787740845; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Lr4Op+emA6JiU4Ny16/9KhdkQPyJvGPjtOQDkD4fONY=; b=IZXorDvqyXMHC9Iv7vrXAPYsvNZ8rNcACZVByu9/ZWksHb6ZX4Zh7z4sAVJBGvLFms jdNBdi31agxKop9FrxxvFkrXUxJrLc4xYS3rpT16qV6yru6NkoN0U+Cz7SHn5w6rWky1 iZaYDaORJYCz5G5Fw1c33p7vww01Cfgoue0+JAk/pQjG+0fGgU2dHpIat4Gio5R9oZMJ dnZnKS+DkTSWolhOIxuJJyE86J9cNEB4Wq/nqB4Mc+l1u+5AlnpYxpAyblFZ207jhHAd cH5CYbW4QVaufBDKAL7i+O/TJYC7slr5heck5/zCrSd9bpbOex5O9QnwwLd7ye7hAccP FdFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787136045; x=1787740845; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Lr4Op+emA6JiU4Ny16/9KhdkQPyJvGPjtOQDkD4fONY=; b=rB2JBvmSeU/GujhXPQxZAEal3eHCh+sLx+FG+zdrSuENNU4/Ju8IYJxYyYD72w50WN qcB5UmQ5IHZZvLu5EKiIzXkvUVlV5ai9hEap6gVcgUT8tD2oeQshe6nMOhykEUEE8ePA O3CBG6ZePDWPLikkG5jmDqldbLNG3Zj7c6Ff6y1r8FTwTrlIG+3Wv2r3ts8S83QjrP+Q gJu3TqwN69V1j8Z5+p3iw0FiPyfvt4RuP5M+86HrkIv2L4X7S+38TtZvc8i75TRkFEQT wv4m9f41CV53ZcObaQbIvU++86v7b2l0c/CvpfJowbzNTznhAmPZd8+0dmOCgtd5KIW3 834w== X-Forwarded-Encrypted: i=1; AHgh+RrEP4S0w5JPJaoCEBt0fi3kpwYMgHRTQFHEHs7cessBSWeJNREJiW6FImYNV3BwaNdkebQe2Vu+sRwAlBE=@vger.kernel.org X-Gm-Message-State: AOJu0YyyjpApE/PfrOPffKKg2umlcZhenoKlxG1XnIg9lNAAuHDkEx17 /+ctW7uOYGyxUphzLzvBx9ClA0zAH9IJ1i/c9zEusV7Cvk7m17TCeMuE X-Gm-Gg: AR+sD11Dp6cYUZ/VsB9mkB0Ok5rR+LEiXGlM0T18/3B2tWD7VP2hlWm1Zh5wQmWq3Fg a659KuWas2CKw7QWxj5cgpcIBBlJ+vQ0D3CZ8ik91cCpXzwTYtQ29O5oC0zCQUC53vMf3Om+opo C31B9ji1uMXI9ZPQlOm4JxdoKluFTG5uU3SBh6bRxvzMzuX9EudH2XzDEWrsSC38Vy4vvnSs/3n 6KdiHJ8I00/Q3yzrI0LXxQu3y0+3WdHKRCIXRAFoXYY5WXTa8AN5EVW5hpVY5ht1+zul1F+NVRB C5nM9WOMlG3SjURgqgVtPAGpxP47TiUqGZ2sbWsWYznduRs+f6OfZxlEK/pcOwoD23bjJHLQFzL II4hv9bvafISVNFU4UPhqpLM1qyMuuOZ4LEu1cjfhRSZqHMj0LXQlj/nziN8PHQPBc/7hv8KoRc IrDu91858mFax1IXe9ixeMRCCQ8SCvPmLH4oRGzWbRVylNtiqflaDw805iiZM+woFLfYQ2sjqhd rOT25TJulGVK5iUGAWmZvSnusp1MIcOAH/LFxqoJBLMKF2oOi+UNCRSDX3KA8vuUhTQAUFjkNvU 5orDMKsrqA== X-Received: by 2002:a05:6a21:8cc4:b0:3b3:1b38:d9c3 with SMTP id adf61e73a8af0-3cd016b16e8mr8210052637.4.1787136044429; Wed, 19 Aug 2026 03:40:44 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:a897:a9b5:e171:c935]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bef77fc0sm11169630eec.8.2026.08.19.03.40.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 03:40:43 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Miquel Raynal , Alexandre Belloni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Wolfram Sang , Magnus Damm Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v4 09/15] rtc: rzn1: Dynamically calculate synchronization delay based on clock rate Date: Wed, 19 Aug 2026 11:39:20 +0100 Message-ID: <20260819103926.2136712-10-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260819103926.2136712-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260819103926.2136712-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Replace the hardcoded hardware synchronization delays with a calculated time window derived from the operating sub-clock frequency. The driver currently hardcodes microsecond ranges assuming a fixed sub-clock frequency of 32.768 kHz. Newer SoC variants, such as the RZ/T2H, drive this hardware block using a much faster clock rate (~195.3 kHz). Hardcoding these wait windows forces faster blocks to over-sleep, introducing unnecessary delays during clock initialization and register configuration. Calculate the duration of the required clock cycles in microseconds based on the runtime clock rate, and store this value in the driver private structure to adjust the usleep_range() and readl_poll_timeout() boundaries dynamically. Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v3->v4: - Shortened the comment describing the calculation of RTC_PCLK. - Updated usleep_range() value to use 2 * rtc->sync_time. v2->v3: - No changes. v1->v2: - Initialized rate variable to 32768 to avoid timeout_us of 0. --- drivers/rtc/rtc-rzn1.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 425d9590c55b..9eceeed14486 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -69,6 +69,7 @@ struct rzn1_rtc { */ spinlock_t ctl1_access_lock; struct rtc_time tm_alarm; + unsigned long sync_time; }; =20 static void rzn1_rtc_get_time_snapshot(struct rzn1_rtc *rtc, struct rtc_ti= me *tm) @@ -119,8 +120,8 @@ static int rzn1_rtc_set_time(struct device *dev, struct= rtc_time *tm) /* Hold the counter if it was counting up */ writel(RZN1_RTC_CTL2_WAIT, rtc->base + RZN1_RTC_CTL2); =20 - /* Wait for the counter to stop: two 32k clock cycles */ - usleep_range(61, 100); + /* Wait 2-4 RTC_PCLK clock cycles for the counter to stop */ + usleep_range(rtc->sync_time, rtc->sync_time * 2); ret =3D readl_poll_timeout(rtc->base + RZN1_RTC_CTL2, val, val & RZN1_RTC_CTL2_WST, 0, 100); if (ret) @@ -384,10 +385,10 @@ static void rzn1_rtc_disable_hardware(void *data) =20 static int rzn1_rtc_probe(struct platform_device *pdev) { + unsigned long rate =3D 32768; struct rzn1_rtc *rtc; u32 val, scmp_val =3D 0; struct clk *xtal; - unsigned long rate; int irq, ret; =20 rtc =3D devm_kzalloc(&pdev->dev, sizeof(*rtc), GFP_KERNEL); @@ -437,12 +438,16 @@ static int rzn1_rtc_probe(struct platform_device *pde= v) scmp_val =3D RZN1_RTC_CTL0_SLSB_SCMP; } =20 + /* Calculate the duration of two RTC_PCLK clock cycles */ + rtc->sync_time =3D DIV_ROUND_UP(2 * USEC_PER_SEC, rate); + /* Disable controller during SUBU/SCMP setup */ val =3D readl(rtc->base + RZN1_RTC_CTL0) & ~RZN1_RTC_CTL0_CE; writel(val, rtc->base + RZN1_RTC_CTL0); - /* Wait 2-4 32k clock cycles for the disabled controller */ + /* Wait 2-4 RTC_PCLK clock cycles for the disabled controller to stop */ ret =3D readl_poll_timeout(rtc->base + RZN1_RTC_CTL0, val, - !(val & RZN1_RTC_CTL0_CEST), 62, 123); + !(val & RZN1_RTC_CTL0_CEST), rtc->sync_time, + rtc->sync_time * 2); if (ret) return ret; =20 --=20 2.43.0 From nobody Mon Sep 28 17:50:13 2026 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51DED304BB3 for ; Wed, 19 Aug 2026 10:40:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136052; cv=none; b=YctOTAI/pAbiRDqdWl+Q9HyEik3IVUIJErxRVpOxokVTbhGfJUkANJ9YLWemRmIkJc38RW1pppufzVsIuFFFo002DaZKMQYeitO6gucpcN1i7i6T5wOMXRJCdca4ppj3xS4oYcO/n4IwYzWEBmSwwaeqmH0DuCJ8qJotAm+F5aE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136052; c=relaxed/simple; bh=pVdKmvMJrg0xfyZCRZm5q3uorX98aPSMinpzfHA7cPM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IShJwosIagvgF6Snu5E5wIeW3qbe2oSuaeQPoQYpuadb5MKubreAM91jBYw3rxG3uCgqZ32ADuG65olVuhcZeYomUtwE5orQin1gBJ9wai7JeAgh0tkQr5Mf+Vg1K9JMLPGm/tTnBtl7+dRPnbF4VnxDDwg0NP1wkW4i36eKEvw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HmmLqDGY; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HmmLqDGY" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2d01663d816so6376585ad.1 for ; Wed, 19 Aug 2026 03:40:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787136051; x=1787740851; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vBZzFA3dzWnnOqa8IAFyQP010uCKcQ78Q06wXjSSio8=; b=HmmLqDGYXvu5HtOW14ZX/aB4mD7TjFnkiUhTcCyC9qVmcOSVoAqYuaUoRXxWJZoeyT A3MozKoueIcssO2c9hr/67Vl3OdbyplMhYIGPXJ76GxZk+I/vEa5ysj5rH9hMCg7Na7A aX9Yn6mkbj6JSJMNHne1gvHOePfm5blCmQr8zYqPBBnYbpdOvIpXo330PFbGxmTgQtqY elDQ+4Kd5gbwQUn1hctXm6zHAyz567t5HNa7XbEIJv5L5elQzKp6kCFbz+ICjgSBfBSg K0o7H/4vUpcnfLCpNLSNp4x2vzWOdgGlOuGxVLQzly3odb+y4/urBYOyED+yD9M9Pfsr /HbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787136051; x=1787740851; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=vBZzFA3dzWnnOqa8IAFyQP010uCKcQ78Q06wXjSSio8=; b=bxUTDiz7Cu7uCsbV9ZFn0NUYuDnHN8t+oB4afgIuR6rQ4OwOQj6v1aotpGUUPIjoPD 2fBQTQqLMRNAm/sNrMLoynOyLT/ekTzI+uR7pQbzDrC+Z73XdrmjZ1wALD2qkL3YolTP JEN8Xa/05YvJ8XPCpmBoWPgtlrm+ugPeb8pI8izAYYB8k+Ip3dpmHBKWT+KXRzCqcnZZ 62SXU5r6jAEf5qzqTf79toXCFoYVjUQq2U/04kNc+hk+3Mw+b6XreH9keTmr8WTB9BbH hUAXwYm7+PMh7ycTCXw5mihDnNYMAsrpEbuaPO2F51ITI1vUcu0YgrLXf+C45ihUeYFL aJrQ== X-Forwarded-Encrypted: i=1; AHgh+Rrhl3d6g8Y4YZ4uRiPPDP0Djv4gdeeejl+naLWQWSEmP78KNV+6axyu3k0jHWuLcfRD2I8pzjxfKt2rXqg=@vger.kernel.org X-Gm-Message-State: AFuF++lRBmzOJXuNcbRZm9Sz7ib2TXvX1rvSKCvCMZDBzytyJ1e3OAfU 9g404RWeJ8abe9U0eJYzMKJDy56qQH/QaVlbcBz849dSsSaCJCOzO3Hrqmpgrk03 X-Gm-Gg: AR+sD13CIN58Igj4KTDoVxTMPYVLHQKXGxy5aXvT2K1BwNEsPenD26EuWLlO0l4Bfee SsqpFBTiJkGQ6jCV2pFH2+AoGsPzZsz0+W/GORe3eL6F6UMHKHzcpIFIA1B4Uo5iHvgrAQcpomb 4y+WWjSIUHxFNFqO2B/KhNmbb4vfguXSWA2rvJtW2Q46xNc7sgVfV32vKok2Q/mIthLHCwo23m2 jHFBJ5slwRG9wKq15L7NTT9pNkKQbtjLM/AmgxkcVITSFoZdLVs6RKmVfIzhyPuOqf3JKcfkwFa 1hdzTZ8CN23HwU8czZTNeJ0It3ub3v4eVyNQjkmNHtpe9prImYH/DmdyVOXRP2JSEkkPF8JeqLm J39+fNkTblI69CS4zZTqj83ZrOsOD+3WN0zroRWr2o+D0zyMMtTfYaWSu2ycgUCNs4AyyfmAbyQ ScsNpL6816DMWr1RCsm/dA/CKraG/YlZCVEJxoZGVuHaN1nEoi8agj8gv2P1jPY7gBg5NWTPTU8 5ACjUAO/oyYScR8qZyFqREZkpWzyT8Z5HwochGUPs1AyBESasBqRO7xH2ZS1YBKJPFMAjvqDmd9 7FBQqEGKZjRGJAlVjfiX X-Received: by 2002:a17:902:fd8e:b0:2ca:f21a:a6c5 with SMTP id d9443c01a7336-2d5fd644437mr71597595ad.1.1787136050651; Wed, 19 Aug 2026 03:40:50 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:a897:a9b5:e171:c935]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bef77fc0sm11169630eec.8.2026.08.19.03.40.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 03:40:50 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Miquel Raynal , Alexandre Belloni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Wolfram Sang , Magnus Damm Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v4 10/15] rtc: rzn1: Use temporary variable for struct device Date: Wed, 19 Aug 2026 11:39:21 +0100 Message-ID: <20260819103926.2136712-11-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260819103926.2136712-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260819103926.2136712-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Use a temporary variable for the struct device pointers to avoid dereferencing. Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v3->v4: - No changes. v2->v3: - No changes. v1->v2: - Added Reviewed-by tag. --- drivers/rtc/rtc-rzn1.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 9eceeed14486..e67bc8831cb7 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -385,13 +385,14 @@ static void rzn1_rtc_disable_hardware(void *data) =20 static int rzn1_rtc_probe(struct platform_device *pdev) { + struct device *dev =3D &pdev->dev; unsigned long rate =3D 32768; struct rzn1_rtc *rtc; u32 val, scmp_val =3D 0; struct clk *xtal; int irq, ret; =20 - rtc =3D devm_kzalloc(&pdev->dev, sizeof(*rtc), GFP_KERNEL); + rtc =3D devm_kzalloc(dev, sizeof(*rtc), GFP_KERNEL); if (!rtc) return -ENOMEM; =20 @@ -399,13 +400,13 @@ static int rzn1_rtc_probe(struct platform_device *pde= v) =20 rtc->base =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(rtc->base)) - return dev_err_probe(&pdev->dev, PTR_ERR(rtc->base), "Missing reg\n"); + return dev_err_probe(dev, PTR_ERR(rtc->base), "Missing reg\n"); =20 irq =3D platform_get_irq_byname(pdev, "alarm"); if (irq < 0) return irq; =20 - rtc->rtcdev =3D devm_rtc_allocate_device(&pdev->dev); + rtc->rtcdev =3D devm_rtc_allocate_device(dev); if (IS_ERR(rtc->rtcdev)) return PTR_ERR(rtc->rtcdev); =20 @@ -413,19 +414,19 @@ static int rzn1_rtc_probe(struct platform_device *pde= v) rtc->rtcdev->range_max =3D RTC_TIMESTAMP_END_2099; rtc->rtcdev->alarm_offset_max =3D 7 * 86400; =20 - ret =3D devm_pm_runtime_enable(&pdev->dev); + ret =3D devm_pm_runtime_enable(dev); if (ret < 0) return ret; - ret =3D pm_runtime_resume_and_get(&pdev->dev); + ret =3D pm_runtime_resume_and_get(dev); if (ret < 0) return ret; =20 - ret =3D devm_add_action_or_reset(&pdev->dev, rzn1_rtc_disable_hardware, &= pdev->dev); + ret =3D devm_add_action_or_reset(dev, rzn1_rtc_disable_hardware, dev); if (ret) return ret; =20 /* Only switch to scmp if we have an xtal clock with a valid rate and != =3D 32768 */ - xtal =3D devm_clk_get_optional(&pdev->dev, "xtal"); + xtal =3D devm_clk_get_optional(dev, "xtal"); if (IS_ERR(xtal)) { return PTR_ERR(xtal); } else if (xtal) { @@ -469,9 +470,9 @@ static int rzn1_rtc_probe(struct platform_device *pdev) =20 spin_lock_init(&rtc->ctl1_access_lock); =20 - ret =3D devm_request_irq(&pdev->dev, irq, rzn1_rtc_alarm_irq, 0, "RZN1 RT= C Alarm", rtc); + ret =3D devm_request_irq(dev, irq, rzn1_rtc_alarm_irq, 0, "RZN1 RTC Alarm= ", rtc); if (ret) { - dev_err(&pdev->dev, "RTC alarm interrupt not available\n"); + dev_err(dev, "RTC alarm interrupt not available\n"); return ret; } =20 @@ -479,12 +480,12 @@ static int rzn1_rtc_probe(struct platform_device *pde= v) if (irq =3D=3D -EPROBE_DEFER) return irq; if (irq >=3D 0) - ret =3D devm_request_irq(&pdev->dev, irq, rzn1_rtc_1s_irq, 0, "RZN1 RTC = 1s", rtc); + ret =3D devm_request_irq(dev, irq, rzn1_rtc_1s_irq, 0, "RZN1 RTC 1s", rt= c); =20 if (irq < 0 || ret) { set_bit(RTC_FEATURE_ALARM_RES_MINUTE, rtc->rtcdev->features); clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, rtc->rtcdev->features); - dev_warn(&pdev->dev, "RTC pps interrupt not available. Alarm has only mi= nute accuracy\n"); + dev_warn(dev, "RTC pps interrupt not available. Alarm has only minute ac= curacy\n"); } =20 return devm_rtc_register_device(rtc->rtcdev); --=20 2.43.0 From nobody Mon Sep 28 17:50:13 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2264449EB6 for ; Wed, 19 Aug 2026 10:40:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136061; cv=none; b=Q8ruhdQE/uoISWvsooY5UVN3nscprpfQ/49APEidhuEiKgesm0g6jzofzlCYoGbLGt6IjIt7ZYL51BJMHOH2LtfqeWQZHK9748sQtaqjBDH5WTd995E+QSt2QcPWpuk610f8Pp1Sfo3RstHvqkG+IX4viscuiejfYb89Hsx9wO0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136061; c=relaxed/simple; bh=6VygO8fJq97cv2/LDT6K/RY5WR4BNmBEN9fDoyhwQUA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oF6igHP0r1ZoYYnweAIfQplOdiDokqoE3VPfgiAtJz+yRbzoAWPBx79iysmke2867iObbuCWBnLNgzbkUfcuETpvoFy6XIkYh6DCfJNQvBI2j9fuDj0tC46qmOuivd249Broq13Sy8Ex7LsoBQyLUIcwz7UJLiXkbGcg/MtmKUE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HvRnzely; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HvRnzely" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2d5655cc850so9838525ad.3 for ; Wed, 19 Aug 2026 03:40:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787136057; x=1787740857; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BGNWO1eqT3R5Th3PNhdxmu4ZmPk2gjulxaMorpXLcZA=; b=HvRnzely38dTiK+3hNCLddjbcd0Vp+OpOopUkScqRaJk2H2jiw4IV7UQNGgU0szn0V b64WllxRGzeQWHauHOi6wrQ6A88xgD1kGqcxt8MjxozbnsIIeJ6Bxyx5sSe2nL3lUwnk cZI/V8bwsdWapp+qMjSBQhm3IqJNz9lqgzzrM67BL+moVyGmACtR8jZJYnDwLYTmE2zU 6InDJ3/1/mhR4KGTHjbj3a+uddWpnzg86rxhXDZTaWILC7qPkDyoIwlLHeA/IGzKVVgh dArFs5K2folg6NQuiBKVJt8AVNgof9nulk55SD+0cwBmRelFYjcTbY1OcJ9hp0pztzit 8V+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787136057; x=1787740857; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=BGNWO1eqT3R5Th3PNhdxmu4ZmPk2gjulxaMorpXLcZA=; b=aRMtbxD9xHEkPTpa2Hn873JAAsPGyIHFPETbp+AzUCTvpTpQiepqk2Sm/S/fF2aGHI 8WtHn5J9vWdS67S4cpfRAQkFidnxyMD4Y7FfruOlnc/DH6LwPvBZPDYPEAkBskMUKRb8 0H/19//Uej/BiIZ5nnItivy9XQDPh0mG9MM+rzncYG5EcFG/qgNcB7mHNlW9bSpGdPzB rYlGaeGagYsk9AFg98ocdB55godRUcrar7MZaW0mk9s6Eue4QPT19DeOcxipxb3FsCQ1 ZqbH6Adxb6N1VvoyoT94u4023leSt3rDA0byJZ6g4l34Q24Fes13GocPlQkimZFYbCp+ zUvA== X-Forwarded-Encrypted: i=1; AHgh+RqYpy3YOXvD0sa0vB50cBCezV2fdaTeSnsmUDFmwqkwY9KoLsx/Fy0Whj4dzwUr6i22nn6QnCNzBm/ezaY=@vger.kernel.org X-Gm-Message-State: AFuF++mdBHgl+zF0Ed3hcUavJ3SHkJ2dKfMoFtRyJrC7F3ORRfOEz6Ld jUkhLyV295CoxvArfQkVTrccklJ/4rLpBBMP1t7sOQjPBndSxElrf2Un X-Gm-Gg: AR+sD12q0KFWf/GxL81icNs+ImriJU6aoz3nC4Oda5+7zFpvjxvpxlEinwc+9o7GNq/ ZBoVS9AnpFRN9bHKpIG1QKlnzYoGNqn9iHzl2+9jTVsEA122fBc6iGky/7JLwTnuQ8/AvRGhkiZ JUSmJUUYo5Kvcns4gXvOhdPCbyaSpbZqI9q1PnTBXvsSxxuJZXLw8uHPbYlkpbvBMshwhothQHk iisQBm56lL+6MBOgIgFTZkq+kfb2j0Rp8xLZQmzTnpmpDtu1aB73eOzQhm6NVwLVHfGrIFZtrzl Axend0S4nx9zMSxKgu7W65gzEylL7x+D/kc4R888B3UJJCoFKMPs4rcH++2tNRuJRM5VIX2566T De94sQFIf5ugBrsezzQUqDhFNQHUkL+jn+Nltat/tewC/LX7rs5VeslnqmRgken0CRDDTJgfppa eFHjj7shcib4q+PJ0ikagepuXsScELBmevzjRyw4LpHWbxqhA2MFYTIYIpYBCaN4Hw7zPS8O6ki 4sAXMLr5qqf5dR/1yGR9u+ZVuFr8o13g0C3G12TsEW+Cns9DkRj5CxPwh7YXB2VbPzPH/bSigtl yM+n1B0b2Q== X-Received: by 2002:a17:902:ef43:b0:2d5:e9d5:8ae with SMTP id d9443c01a7336-2d5fd62ae4fmr69464095ad.5.1787136057289; Wed, 19 Aug 2026 03:40:57 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:a897:a9b5:e171:c935]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bef77fc0sm11169630eec.8.2026.08.19.03.40.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 03:40:56 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Miquel Raynal , Alexandre Belloni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Wolfram Sang , Magnus Damm Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v4 11/15] rtc: rzn1: Consistently use dev_err_probe() Date: Wed, 19 Aug 2026 11:39:22 +0100 Message-ID: <20260819103926.2136712-12-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260819103926.2136712-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260819103926.2136712-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Use dev_err_probe() in the IRQ request error path to make error handling consistent with the rest of rzn1_rtc_probe(). Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v3->v4: - No changes. v2->v3: - No changes. v1->v2: - Added Reviewed-by tags. --- drivers/rtc/rtc-rzn1.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index e67bc8831cb7..7e2177f46313 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -471,10 +471,8 @@ static int rzn1_rtc_probe(struct platform_device *pdev) spin_lock_init(&rtc->ctl1_access_lock); =20 ret =3D devm_request_irq(dev, irq, rzn1_rtc_alarm_irq, 0, "RZN1 RTC Alarm= ", rtc); - if (ret) { - dev_err(dev, "RTC alarm interrupt not available\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "RTC alarm interrupt not available\n"); =20 irq =3D platform_get_irq_byname_optional(pdev, "pps"); if (irq =3D=3D -EPROBE_DEFER) --=20 2.43.0 From nobody Mon Sep 28 17:50:13 2026 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F54D45040B for ; Wed, 19 Aug 2026 10:41:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136068; cv=none; b=k32BvkQwJWur/iD4CCEMXyoHzUAhVVKp9n5DRlgqi1BYxpxeYtF4f/5BpWvUxkq6XR8uu82JA5T5a6D4eW1Gqa3IDlorPjOJepvJ+z8VTVu0DmxOUJpqWGxnYHaOOECLhlI7493PazUCXoPgcGVJb7kkqtZG/DOX1drdPzXXwcA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136068; c=relaxed/simple; bh=fqDxLMxq201J5OX95IYuNjtL/jRJH0w03O9tgHXacaE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IgyPFKPxjTJCYkiompi+CbVlnGgKfz1YQSgEt/m5/fn4oAiPSfnui90FDfTXMttu8tyxyG0TsvcEZ9ZPjxqN8AuT24qID4a5ptHb0S7PDU+mreZxP6G3v8U+9zT2ODBu9roqezyRGfRWFjJcDIoUiwOhUwUijYYavxLD/ZBz0KE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pivtkAR2; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pivtkAR2" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-3811f512167so1294743a91.3 for ; Wed, 19 Aug 2026 03:41:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787136064; x=1787740864; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jRmLRFgoYJjChjT5n0JT9k4wL4AVamUoFR+vPjRw0Ag=; b=pivtkAR2FTl9ASI3TlSP6ypSo/PXw7UiqIUxrKAhToGSaQUSqx027LitLNhGBZ0f9a e13ZfBAcgOTISk8wXS83GdYouhUYkQpexMSr8B9izIaXqOKtJL+Ryx5FDUZLMpTmIs7k yKtyov5jSxriF3HtDGkLNW31H0QXoLg74st+hQLesJJeRpjehTH8CLVHZzZ81qcpozHM PybrbyLAPCu7n6iRuWhgPTn0U1Gpx1o7X4BIxof8xS9s2tvIXCispV8SQWDTnI/DGlhT wQHA8sSA/pCpnN5cKqH7ReEmrCJLqpdPRJ05sLTwQyTXzPRV+XUVJQbHH8h3EiHShdoG k9hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787136064; x=1787740864; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=jRmLRFgoYJjChjT5n0JT9k4wL4AVamUoFR+vPjRw0Ag=; b=YnmyfxEl9DzdJFOs+pg6kGHXy4N7GB08cT4x0efq5fZMQ5VOzkV64Y6KLapsFCP2uS ET6aifTPKMEACEhbjFX/anPPkOneaGElZM8cfGugj3HC8XGjCv0A/Lh1c4R5b8xrp9wo eEdZxSymzH32uDNDDog37o+udSts20KX6M9ZrFhd306Mqn5lX6swS3E3snm+DpQD28gM fAOusCGEkOckElUdhMnFG4fgbOUzoD8qMdOGTxH5lTv7QF4SfxKNvTHJhFHYr586iCZc nRzL16QefK7on4Mlh3BDuQJvggsvEMEFXPVetvyKWiX5/6iVyiGGpPwJUCXt+lCWADWq GBPw== X-Forwarded-Encrypted: i=1; AHgh+RqBN49MFOC+KuL8rU4jGwU1MQvBcTaJQsdxU0f4NIbhdB18QAPioPElPv1VSEMiowPFLHiJOtpEveSFphI=@vger.kernel.org X-Gm-Message-State: AFuF++kjmq/E5taWbpTbZmR0chd5JcbY9fOO84od2xP6E6ukTOPfn3ld 1vWuAXe5kMVwUtkFjWVuANniXullFi1SIUf5kCYwFyR5d9iAHOPn3r7l X-Gm-Gg: AR+sD106xlJWnJ9Q/Nz2jTV0XdCmC4i8WjR2j+gxdA7oX9Xn+rbJs0RO456cblR6nn/ nbHThHyCPQB8C2zF7rOsZ2Oe2QMxcny0o4wSj9CGT9MTDB6J38z2V52OSVXFhx/icU+wXbjhKdZ 8VWpfjbkUGb6xvoHAJL4LZGwOWLzfn/l0FGFeGfOPlvcOiRQgCMi+FO53/sY+ec3npoWWBFMgwZ bMGVCVSrRudjL4E6pb1F8SibWL2EaIQWSJoSXb3+WfovKTjYUBQldSs87Jctpnag4hBHekweRFt hrR0jb9N2UMMre8gC9uWZgq567Sq1y9z1Us5KRgMvVdYDwWHy/UCOfaMAuoWTRy5pxiWzthoBjh vuAMYT6IXhZLg+1h9FsUaSJVXrAnLTCzAiJozSmh5lG1HBtGst3UnpxfosKldNdy9hGeny39kWL YA6Nw5wxLICXMY6Pz3hQV5Rpwk8SwGII4nI/oC9pkCKuKj5RZ/VG36zHzxDPVxEqpMgrybu1w1Q jHEYScMyPjz3VhVRhvH4JGDMd8lr0t9G0w0znp/NI8XS8eqoB4NF3ZQ1N1vRSnSbXpKAUIkKnn6 w+JWbq9qZQ== X-Received: by 2002:a17:90b:1e4a:b0:37f:c97a:939f with SMTP id 98e67ed59e1d1-39580ace5fcmr6816160a91.7.1787136064030; Wed, 19 Aug 2026 03:41:04 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:a897:a9b5:e171:c935]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bef77fc0sm11169630eec.8.2026.08.19.03.40.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 03:41:03 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Miquel Raynal , Alexandre Belloni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Wolfram Sang , Magnus Damm Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v4 12/15] rtc: rzn1: use FIELD_PREP/FIELD_GET and GENMASK for register access Date: Wed, 19 Aug 2026 11:39:23 +0100 Message-ID: <20260819103926.2136712-13-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260819103926.2136712-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260819103926.2136712-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Replace open-coded shift and mask operations with the bitfield API. Note that the weekday field is changed from an explicit 0x0f mask to an 8-bit field definition, matching the hardware manual. This does not change behaviour, as valid weekday values cannot exceed 7. Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v3->v4: - Added RB tag from Wolfram v2->v3: - No changes. v1->v2: - Made use of RZN1_RTC_SUBU_RTCA0FX mask for SUBU register access instead o= f 0x3F. --- drivers/rtc/rtc-rzn1.c | 50 +++++++++++++++++++++++------------------- 1 file changed, 28 insertions(+), 22 deletions(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 7e2177f46313..02cff5fe117a 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -12,6 +12,8 @@ */ =20 #include +#include +#include #include #include #include @@ -38,14 +40,18 @@ #define RZN1_RTC_CTL2_STOPPED (RZN1_RTC_CTL2_WAIT | RZN1_RTC_CTL2_WST) =20 #define RZN1_RTC_TIME 0x30 -#define RZN1_RTC_TIME_MIN_SHIFT 8 -#define RZN1_RTC_TIME_HOUR_SHIFT 16 +#define RZN1_RTC_TIME_SEC GENMASK(7, 0) +#define RZN1_RTC_TIME_MIN GENMASK(15, 8) +#define RZN1_RTC_TIME_HOUR GENMASK(23, 16) + #define RZN1_RTC_CAL 0x34 -#define RZN1_RTC_CAL_DAY_SHIFT 8 -#define RZN1_RTC_CAL_MON_SHIFT 16 -#define RZN1_RTC_CAL_YEAR_SHIFT 24 +#define RZN1_RTC_CAL_WDAY GENMASK(7, 0) +#define RZN1_RTC_CAL_DAY GENMASK(15, 8) +#define RZN1_RTC_CAL_MON GENMASK(23, 16) +#define RZN1_RTC_CAL_YEAR GENMASK(31, 24) =20 #define RZN1_RTC_SUBU 0x38 +#define RZN1_RTC_SUBU_RTCA0FX GENMASK(5, 0) #define RZN1_RTC_SUBU_DEV BIT(7) #define RZN1_RTC_SUBU_DECR BIT(6) =20 @@ -77,15 +83,15 @@ static void rzn1_rtc_get_time_snapshot(struct rzn1_rtc = *rtc, struct rtc_time *tm u32 val; =20 val =3D readl(rtc->base + RZN1_RTC_TIMEC); - tm->tm_sec =3D bcd2bin(val); - tm->tm_min =3D bcd2bin(val >> RZN1_RTC_TIME_MIN_SHIFT); - tm->tm_hour =3D bcd2bin(val >> RZN1_RTC_TIME_HOUR_SHIFT); + tm->tm_sec =3D bcd2bin(FIELD_GET(RZN1_RTC_TIME_SEC, val)); + tm->tm_min =3D bcd2bin(FIELD_GET(RZN1_RTC_TIME_MIN, val)); + tm->tm_hour =3D bcd2bin(FIELD_GET(RZN1_RTC_TIME_HOUR, val)); =20 val =3D readl(rtc->base + RZN1_RTC_CALC); - tm->tm_wday =3D val & 0x0f; - tm->tm_mday =3D bcd2bin(val >> RZN1_RTC_CAL_DAY_SHIFT); - tm->tm_mon =3D bcd2bin(val >> RZN1_RTC_CAL_MON_SHIFT) - 1; - tm->tm_year =3D bcd2bin(val >> RZN1_RTC_CAL_YEAR_SHIFT) + 100; + tm->tm_wday =3D FIELD_GET(RZN1_RTC_CAL_WDAY, val); + tm->tm_mday =3D bcd2bin(FIELD_GET(RZN1_RTC_CAL_DAY, val)); + tm->tm_mon =3D bcd2bin(FIELD_GET(RZN1_RTC_CAL_MON, val)) - 1; + tm->tm_year =3D bcd2bin(FIELD_GET(RZN1_RTC_CAL_YEAR, val)) + 100; } =20 static int rzn1_rtc_read_time(struct device *dev, struct rtc_time *tm) @@ -128,15 +134,15 @@ static int rzn1_rtc_set_time(struct device *dev, stru= ct rtc_time *tm) return ret; } =20 - val =3D bin2bcd(tm->tm_sec); - val |=3D bin2bcd(tm->tm_min) << RZN1_RTC_TIME_MIN_SHIFT; - val |=3D bin2bcd(tm->tm_hour) << RZN1_RTC_TIME_HOUR_SHIFT; + val =3D FIELD_PREP(RZN1_RTC_TIME_SEC, bin2bcd(tm->tm_sec)) | + FIELD_PREP(RZN1_RTC_TIME_MIN, bin2bcd(tm->tm_min)) | + FIELD_PREP(RZN1_RTC_TIME_HOUR, bin2bcd(tm->tm_hour)); writel(val, rtc->base + RZN1_RTC_TIME); =20 - val =3D tm->tm_wday; - val |=3D bin2bcd(tm->tm_mday) << RZN1_RTC_CAL_DAY_SHIFT; - val |=3D bin2bcd(tm->tm_mon + 1) << RZN1_RTC_CAL_MON_SHIFT; - val |=3D bin2bcd(tm->tm_year - 100) << RZN1_RTC_CAL_YEAR_SHIFT; + val =3D FIELD_PREP(RZN1_RTC_CAL_WDAY, tm->tm_wday) | + FIELD_PREP(RZN1_RTC_CAL_DAY, bin2bcd(tm->tm_mday)) | + FIELD_PREP(RZN1_RTC_CAL_MON, bin2bcd(tm->tm_mon + 1)) | + FIELD_PREP(RZN1_RTC_CAL_YEAR, bin2bcd(tm->tm_year - 100)); writel(val, rtc->base + RZN1_RTC_CAL); =20 writel(0, rtc->base + RZN1_RTC_CTL2); @@ -294,12 +300,12 @@ static int rzn1_rtc_read_offset(struct device *dev, l= ong *offset) val =3D readl(rtc->base + RZN1_RTC_SUBU); ppb_per_step =3D val & RZN1_RTC_SUBU_DEV ? 1017 : 3051; subtract =3D val & RZN1_RTC_SUBU_DECR; - val &=3D 0x3F; + val =3D FIELD_GET(RZN1_RTC_SUBU_RTCA0FX, val); =20 if (!val) *offset =3D 0; else if (subtract) - *offset =3D -(((~val) & 0x3F) + 1) * ppb_per_step; + *offset =3D -(((~val) & RZN1_RTC_SUBU_RTCA0FX) + 1) * ppb_per_step; else *offset =3D (val - 1) * ppb_per_step; =20 @@ -341,7 +347,7 @@ static int rzn1_rtc_set_offset(struct device *dev, long= offset) subu |=3D steps + 1; } else { subu |=3D RZN1_RTC_SUBU_DECR; - subu |=3D (~(-steps - 1)) & 0x3F; + subu |=3D (~(-steps - 1)) & RZN1_RTC_SUBU_RTCA0FX; } =20 ret =3D readl_poll_timeout(rtc->base + RZN1_RTC_CTL2, ctl2, --=20 2.43.0 From nobody Mon Sep 28 17:50:13 2026 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC78D44E64A for ; Wed, 19 Aug 2026 10:41:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136073; cv=none; b=AZ7byPl9McQUA7zZk9wQ3WJEwPWkxdiAh6807sIxJHzyhz2qhRAIOmoZKeeE005n5KlkpHcYAuYeqvOvrxSn52nQhN3tpfZdzoicfZk7Rg6T17MLd7/OnCJsSnSnoRFR+A5KJmvlBh/TOooHRg8i7GxVnJQ2Rs/vW0xRbSik7FQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136073; c=relaxed/simple; bh=u4VgIyfXWMB8BkJNBw63P10SL3BGld4PWaviUvNwfhs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iTvg8B3U8CJLF6mMLOhX0xzYftoPmjNGZOi04rDkxAFA+ZV6ZlY7Q3s1DkkYoUE7s9Jluazw83NhGvi0mytAU82RVh3MtfmraFWKvIYLrPDEJhMLWx7zEh6//RzanW/XQookHX5wujITNopUWiLyzB4tnboY82lzEEh0oCUOZQc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E5tB4XlR; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E5tB4XlR" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2d5655cc850so9840335ad.3 for ; Wed, 19 Aug 2026 03:41:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787136071; x=1787740871; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0X7PVCFnMu15gJNVFEZ+mwlsTpP3SMGTChmDH3l0QZ4=; b=E5tB4XlRWr52tfd3A5b6Z+WxgWbrk5d7COOJAsVB75gl0KayFpow50NhTemsgD4A/x xMsL76EeriqB3BR/jpS2KcpZeafkAtePh/2lQunNF/WorMxNOIaB2GAX9NR5VWITDvgC SwHCSE4v5fYL5Erdw0IEJJp5m+3ti7k+n9ZrGg4p8eWhnzNgC16Gl8AcoV1y8qNmANIM lu2kVuruzFnwawyP5JA1M7km5iM52UusKglDvi93z3SO5ociA0OLQnuTrRwoVplRt7rf e/3r0bkLMYjshIb+Kxs3n2P/dGnzyECPEnjrcqyG6QxGCjzOTruyDragphXf/9lIexqj 4KmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787136071; x=1787740871; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=0X7PVCFnMu15gJNVFEZ+mwlsTpP3SMGTChmDH3l0QZ4=; b=BjxozRPXXcJRFDlsugLzDNmHbiEYsE6Sa63d31FsYdokXLrM5dZc87RM5cn2s7aH+u GDsaYNfiS65WnwHkn8SNKgnuSLyzg/nA0xHSSVNrmDAIKcJElhyAVx1A85/wtkhZb39m jBd/UFYFE4VnwOFAGn2wYHcTBBFIP62/54yuTGDdivGqZSs25LrqT98I5+nNYkQSDeri +hKcqv1pFZrA/pvgoZKWQMV8Z92Dx7H9p8PA5hn74K7mFDu2z4OGfIebh0aELWvWAIt0 +FQsrUy7MlI+ULhT9ovSbIaQuH7fhwlZS4XlfNINKjT6dXse/BGjpr0q4VkApkUUhUdV wRxw== X-Forwarded-Encrypted: i=1; AHgh+RqutSBxDkv51MqHgiFhzsy/11geXIK1XD3WY91aWObB1pGSmJW/aIdwwKgY68LMpQAdrjmxIkSbgD7r+mI=@vger.kernel.org X-Gm-Message-State: AFuF++kmgkV9LrMoPX/0Y75jMarz+bJINig25a2Ja6ZaWDZqlAm+B1tY B/33SzUh4HLGum1Z2U79hQWF5fK+X57J2yX0rNNC5B92bhUB3s7rt8UQ X-Gm-Gg: AR+sD11aYrq0S16sLyw3Iz3NusWaBsmKCjRI7DOl8dNrvHLyt0oe2jJ5Rbha1RALfsY gzz7rqhj6Q7n1DIObyL03kIR+k6EJthJ8sSM7c+D/oM9JkuECOPGP6sGOpgscxb4e8ey6RKeU0u M8UcYxccU9xPc46qS9jHrPJIMrR1rfqfLZU8eWQDpKPSD9lt9OjEuz15qcd6B0ej2wwbJfD1Tkc 0mrt81rTY468VWcYxFWKwJ1PdzmmOKbYpzKQbbno5zTxfKOg3IXHrsnjL6uoJa1BnFclv5K/zw2 Jgqck8y7jHs79wuMX6sYdSUEFlXFLLD4uVadxrEJiapm6thNtOng9pkUsbjtWARwxdM1amNQVHd pA0rVd0f73qw07q4eOa+marwBjSAuvWMbq2K5FxFo5/xNmn+AD4nSqDU4tbZQcHDO66hP0/oWOe Z5XDmOr92kabgQew5iD5jI0DkAMAazWarRUvK+AA0E4o4S0C3X/Ls990i3FGVbxsKKxDeSMTjlz Zpw+REqmkOdneKhkXUPuO5ZNVaFmrqI6OVXQiFj2+EUYBxgihhg8XjulnHFnYFeTCvEFbbGBId0 A0fZmrBHzg== X-Received: by 2002:a17:902:d483:b0:2cc:f5aa:9513 with SMTP id d9443c01a7336-2d5fd6fb665mr60736685ad.10.1787136071114; Wed, 19 Aug 2026 03:41:11 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:a897:a9b5:e171:c935]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bef77fc0sm11169630eec.8.2026.08.19.03.41.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 03:41:10 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Miquel Raynal , Alexandre Belloni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Wolfram Sang , Magnus Damm Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v4 13/15] rtc: rzn1: Add OF match data to gate SUBU register access Date: Wed, 19 Aug 2026 11:39:24 +0100 Message-ID: <20260819103926.2136712-14-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260819103926.2136712-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260819103926.2136712-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar The RZ/N1 RTC driver selects SCMP mode only when an optional xtal clock is provided at a valid rate other than 32768 Hz. Without an xtal clock, or when it runs at 32768 Hz, the driver uses SUBU mode. However, the RTCA0SUBU register used by SUBU mode is not present on all SoCs that integrate a similar variant of the RTC block. Allowing SUBU mode on those variants would expose RTC offset operations that access a non-existent register. Add OF match data to describe whether the RTC supports the SUBU register. Reject probe with -EOPNOTSUPP when SUBU mode would be selected on a variant without SUBU support. Signed-off-by: Lad Prabhakar Suggested-by: Wolfram Sang Tested-by: Wolfram Sang --- v3->v4: - New patch --- drivers/rtc/rtc-rzn1.c | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 02cff5fe117a..202840eb86a6 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -18,6 +18,7 @@ #include #include #include +#include #include #include #include @@ -65,6 +66,10 @@ #define RZN1_RTC_TIMEC 0x68 #define RZN1_RTC_CALC 0x6c =20 +struct rzn1_rtc_data { + bool has_subu; +}; + struct rzn1_rtc { struct rtc_device *rtcdev; void __iomem *base; @@ -391,6 +396,7 @@ static void rzn1_rtc_disable_hardware(void *data) =20 static int rzn1_rtc_probe(struct platform_device *pdev) { + const struct rzn1_rtc_data *data; struct device *dev =3D &pdev->dev; unsigned long rate =3D 32768; struct rzn1_rtc *rtc; @@ -398,6 +404,10 @@ static int rzn1_rtc_probe(struct platform_device *pdev) struct clk *xtal; int irq, ret; =20 + data =3D of_device_get_match_data(dev); + if (!data) + return -ENODEV; + rtc =3D devm_kzalloc(dev, sizeof(*rtc), GFP_KERNEL); if (!rtc) return -ENOMEM; @@ -445,6 +455,9 @@ static int rzn1_rtc_probe(struct platform_device *pdev) scmp_val =3D RZN1_RTC_CTL0_SLSB_SCMP; } =20 + if (!scmp_val && !data->has_subu) + return -EOPNOTSUPP; + /* Calculate the duration of two RTC_PCLK clock cycles */ rtc->sync_time =3D DIV_ROUND_UP(2 * USEC_PER_SEC, rate); =20 @@ -495,8 +508,12 @@ static int rzn1_rtc_probe(struct platform_device *pdev) return devm_rtc_register_device(rtc->rtcdev); } =20 +static const struct rzn1_rtc_data rzn1_data =3D { + .has_subu =3D true, +}; + static const struct of_device_id rzn1_rtc_of_match[] =3D { - { .compatible =3D "renesas,rzn1-rtc" }, + { .compatible =3D "renesas,rzn1-rtc", .data =3D &rzn1_data }, {}, }; MODULE_DEVICE_TABLE(of, rzn1_rtc_of_match); --=20 2.43.0 From nobody Mon Sep 28 17:50:13 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 060E0449EB6 for ; Wed, 19 Aug 2026 10:41:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136079; cv=none; b=Z6ndhCkptSYM2rnr1wQENfWvjYpea318jss9ANRxV/QhDCJag1hjPeHxBgiX5YPr34vZGHlDTXhfZTmuYZJDpiSWq3uDxsdVczCd8j22kB3wjW2LqM41X1NCwJC+ffX3XfPKYxydPKOYfN386VTT2knG3RIoPieRF9sVEzzsQ5k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136079; c=relaxed/simple; bh=QvmAY2zQ/bnEha1G+lZ6sMfuqhFsDr9MAHAlO2Gs0Fw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q0/oMD/tbDsZOWlTxcuFj9EeQTiFDQeHX5pjNjU6o9lYPJ3F+5nI1cTWAh1TIQkcO2my8QwVI2/PO2HdfUbYCcssUhzFc9YGRFgnqL/sVV0XJOS7h7wcK9QhRdSLa4ZBE+yVe81H6gKGwEzU70aXxOmevPjZT6cGgUr3NvpcgNc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jgOUvVsH; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jgOUvVsH" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2d58efc7356so9202915ad.1 for ; Wed, 19 Aug 2026 03:41:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787136077; x=1787740877; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ugIT9VUnw0CMyTauhyEPxNk/2S/UCQe05/BRnC/Umfg=; b=jgOUvVsHjf147ud0cI9pnavGAeL1on78R8Pt/BCpSN5xakYZrqSpSEo7jk4TGTnCOw F6upehfW5yK82P4ODOLGdLLTcy79ZLfbuyHCCKQd3jfPVUd6QG/P6h9TxDjtPYl4gLRv sQegHq79pfIXXQR5kihQRPcRIVDH7oqI43li+kZbM5APyhthF+/3xddtVNYg4jnR7Xlj zCA2G3QiTgl/q3Ng3zg7MrFatuLoKIxMpQ0jXo7Qbz8JNV2zYlIOVkmZ/dNSv+SV4z8K I8cUV8lC1eaZnn8snmOh7uvyvfXVH3/uBh+Y1WtjaUz7gzA/gSfkmtVurWTC+4igjKGm kGsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787136077; x=1787740877; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ugIT9VUnw0CMyTauhyEPxNk/2S/UCQe05/BRnC/Umfg=; b=MnYfjFhup8zYcJgUtEWGnTj0wWIWtvzylKb5N1UXMdM/fZb2QZzDr9UZhy5mFVTXfI 7Lc1p+6hs4MuNs5l3E/gfGrM+UeU1AmE5JojtwbdOhDSnzQzD++mfhEgr2KnIHmpW7VE vuHMtvV+5LVgTwa0I9b5Dg/gO1wBKHNmj63J1ouuEt7hma2+1ah5F3g7+QxCiqkUKQcC X8rcnIsWJw0bJZCpyXoNKQDN2jkaOoJQo6Jz17OWW995KEZh8/8HJKVZWahMTMWGixva vDYqaAb0cbzf/k8sAsAxmLeGLxgRnhxyGnejrpEo19kOP50KzhWYbtWbWA3MzTkTeGTO IpYg== X-Forwarded-Encrypted: i=1; AHgh+RrV4qUwdapaaTr440RoRoVw3OelyWPu016BzZNUx9ltNWI8E/8fy0bxdeeJwH9gHfO8OHEZfICeg2jxiAQ=@vger.kernel.org X-Gm-Message-State: AFuF++lIhBjk0MpR8ywqr36mCcLQTkR0t8dwwH4+lxlGRaH/dXQloo68 RP8UCrh/OAdkyA4ACRnR9Iw5DaDy6R0vugS9/mEVmxmm+XvPPVPACXA3 X-Gm-Gg: AR+sD119okgjEhEWG+WlYS074fxS91ZqNa4SOWxTMo7aOj8PzOwpOcKlDKU4/+Q/ETS xAyIHvP58sO9DFeakvcuQurowkNqGpNoUkTHVXuXZAr8A7QHMhEmIXTrTuiBzAv+bv8KnV+XKFT UA2KKlANlQepTkkYacYFjhPga+nRzK8Lwpaa2C/3dPtzYae4pKglfIN0Pwie7Jlkr2BCGpTdfM0 fSfsDJtYocPm7qv2u4o3rSUIxPAUo5ohEcATGNX9jW/2j/6a2XYpfulQMIlXvmZ0P/z7d1NDVnk bXRCNugpvW2ghrLhZFDhUa03u9wyloR+S8IsdQdwm4u6+pZ/3JYKkrMLumdpN7HOrd7UpV9Mnwa 0bLjgBN9AEeIDWqDfQ3t5a8NLh4rjru4LJ2PPT26d6D9INbIoTdVV8Nts33/twWpk5m7u0fMpaI QVhqY+6qILq31vgujIl0U6q2Llbc4m8I8Ml/Jy7z/H2+4f+B4pMuZD3SfnBDPC0JuKDSgmdJUCH B6HloYzBjd4EKWWaKglokUdTxd1pMt5YRh50fJ/n8RWNKeBkrZmdCN2WEIX+FkP9Fas4bJFBPvG UIftmnu2fA== X-Received: by 2002:a17:90b:2c8f:b0:37f:bfa2:1887 with SMTP id 98e67ed59e1d1-39580f119d1mr7016222a91.8.1787136077359; Wed, 19 Aug 2026 03:41:17 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:a897:a9b5:e171:c935]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bef77fc0sm11169630eec.8.2026.08.19.03.41.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 03:41:16 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Miquel Raynal , Alexandre Belloni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Wolfram Sang , Magnus Damm Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v4 14/15] rtc: rzn1: Drop trailing comma from OF match table sentinel Date: Wed, 19 Aug 2026 11:39:25 +0100 Message-ID: <20260819103926.2136712-15-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260819103926.2136712-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260819103926.2136712-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Drop the trailing comma from the final empty entry in the RZN1 RTC OF match table and mark it explicitly as the sentinel. Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v3->v4: - New patch --- drivers/rtc/rtc-rzn1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 202840eb86a6..6097563c5f13 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -514,7 +514,7 @@ static const struct rzn1_rtc_data rzn1_data =3D { =20 static const struct of_device_id rzn1_rtc_of_match[] =3D { { .compatible =3D "renesas,rzn1-rtc", .data =3D &rzn1_data }, - {}, + { /* sentinel */ } }; MODULE_DEVICE_TABLE(of, rzn1_rtc_of_match); =20 --=20 2.43.0 From nobody Mon Sep 28 17:50:13 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BCFB44E654 for ; Wed, 19 Aug 2026 10:41:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136085; cv=none; b=ris/cD8QQ0C4NvBts/CL3d16v9KwmBPngcEj9kA5J575VFGM4uwMo6YONQj+P3MLGhpujXASIdwSqfLYwCYP93H2Dam5Eu5DiXbfD6ljBySi+g53lO+4jeutkxpU6lIp1Bd2p09phkVMLXtRnbaJi8gmOcwfBIKrLTF3iXSAmVI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136085; c=relaxed/simple; bh=uQI3XAHDTn8+KY5L4ouP+6SB6FMgV+T6fRXQElDCkUI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=m+wvQ+m5zB2Cu3xEsgrYswA+q+DZtx4icNNR8co3i72H96KiwJbfz3xvsaeirUALe/D0ZAnEAFKBpzMuArG3VXVGiHl789YOKvIHhCMDGpuWD4RLdMyGlfaNxAqo5ytmNPIyR5IMaUDAsjAsDImcvu8DCbEE9iTp82V4aZWQBdc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E4h/52IU; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E4h/52IU" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-38e08baf860so1000517a91.2 for ; Wed, 19 Aug 2026 03:41:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787136084; x=1787740884; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=G8E97ZQvAGrXyZ8ICqBm9FXVCnTnFkg/F1lMXTTvhqA=; b=E4h/52IUWYsnudlN910qJUAk9yRyhIbW+pVWWMofeo1NQLql2pnBd56JCdx7T77Rvh aIirMS/JcdCsIyh66X9VyCx44UeHug6s+74G/msz6MG4v9mDRqGXhdEXc/NSOmoyV4MR 5oypUsBIkH4404pD/WPSjoGo99Ishc2QNm4gL1Rd/+YYdBlwJNl5aZ0PP1u2MnLSktG9 AHGaRrakWwXUnUqgoMIgYoYIfGhz5OzOTBKf/2GIpuYlL4POA+hRxgrrxfPD33fo2wpJ 33e8CnkW7QKTgISUQrn2y9TRmwVPx6ARqL5FYbfLkSP3GI/EwtJVT+90EBcpf75dmR+g 2K+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787136084; x=1787740884; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=G8E97ZQvAGrXyZ8ICqBm9FXVCnTnFkg/F1lMXTTvhqA=; b=goladrpKnFFdw95FbN4ix4fP4D6udT99FbPKRGCqxIarFLpssz32B5r3rhA/zQXUIw n6DXJ/FgHlcCrqf8e67s+SozJRvMvTK/PsU0EDX3G/uiq7kbmWD5SP6gav2jJ7L2lXJp y01igdi7I8ml7EK3xuYezWPdW/OTsAtDXBJFPoInfDQOwrUotUn2wT8PvS5AKutNsK97 YGX+L1Pyidc6iJNj4dcvXkp1DeWYnT7EY2pRud9Ro3McOxexGsTK2fCJfXYD1xTBENg8 VC6Tr9zyx7PQTGsxW4iV10eEZ37mBrnNcSYl6eTZVHnWePSP7KROohxVeMlfN5OpeKEu kK7g== X-Forwarded-Encrypted: i=1; AHgh+RplAb5qBE6kcFuqSHbBgad2uTXEQngXZeBo6l3guolQ8PtcTBy2EwfacJb4sBk3+iCXQvei1CHhWg7VpzU=@vger.kernel.org X-Gm-Message-State: AFuF++kSVHK5dIf5T3XBRnM/iqMKGcepoiIG7Xitx7hIwsyQs6TDduO/ gyvaakOe/jsDgUX9gsWohNmmyvbi/x9cIjDffeEn1Dba5Wptg5Ss/Yxv X-Gm-Gg: AR+sD130d5jEKMw5LbXi5o8CNIj3fwnHvYSHTH+RQ8VrxkiwfLOUMbxetWF4tfqBCtX iSc38rnxzpg+JEJUJew1Owr9TIxBQKViNNM29DOBEeFmh6EgsBx/Gmu9YEEnASPXPw8p1GQNm2G zLF8Dd+IQvKTuF4JGEQrKGrYtXQ0nclJ7yOaSFr8jV0dUTYQzYYxdetot9DhjIQ7BccFaFMq+Rs EkOjw8bjT4qV+ASr31SdhNQDRJSYn62beIY2h90oJ/2sJEC4bMpuDy6pNwAgS190n/rLjcWvk0a WJEwAK7vIarSluWqvjA8nQ4pjNu3A/AO6qlGhk9vxz4zHgHYf2PuPmxpyAtByCNSPKq230I+rBV 4+vYjsn9spf9rZcn3HrqNRG3AwiqmVlrWYaHk8SNAsti9eqLJuXfupYQiZJlzQU4nYPcZCIiKEY PIuTFxNjbWZF50iu1P3uwRHMasIG+zIXAM4O2gi4GYuDKxb8n5C4MrI5M3JGIkv25Y+51+0167P vozxGMsE0w+MTpyYItZc/2sd9zoNYTIVzT5iRyAId2Z+Kxvvy7G6V7Z+THDECqLheEfC5qVMV2f HOA3i88qmbI= X-Received: by 2002:a17:90b:5250:b0:381:9028:5945 with SMTP id 98e67ed59e1d1-3958125375amr7486669a91.14.1787136083791; Wed, 19 Aug 2026 03:41:23 -0700 (PDT) Received: from iku.example.org ([2401:4900:1c07:efb3:a897:a9b5:e171:c935]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bef77fc0sm11169630eec.8.2026.08.19.03.41.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 03:41:23 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Miquel Raynal , Alexandre Belloni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Wolfram Sang , Magnus Damm Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v4 15/15] rtc: rzn1: Add support for Renesas RZ/T2H and RZ/N2H SoCs Date: Wed, 19 Aug 2026 11:39:26 +0100 Message-ID: <20260819103926.2136712-16-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260819103926.2136712-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260819103926.2136712-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Add support for the RTC block found on the Renesas RZ/T2H (R9A09G077) and RZ/N2H (R9A09G087) SoCs. These SoCs integrate a closely related variant of the RZ/N1 RTC IP, but do not implement the RTCA0SUBU register. Use variant-specific match data to disable SUBU support for these SoCs. Signed-off-by: Lad Prabhakar Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang --- v3->v4: - Dropped RB tag from Wolfram. - Added OF rzt2h_data - Updated commit message. v2->v3: - No changes. v1->v2: - Updated commit message to drop reference about RTCA0TCR register. - Added Reviewed-by tag. --- drivers/rtc/rtc-rzn1.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 6097563c5f13..32f6464fe7d2 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -508,11 +508,16 @@ static int rzn1_rtc_probe(struct platform_device *pde= v) return devm_rtc_register_device(rtc->rtcdev); } =20 +static const struct rzn1_rtc_data rzt2h_data =3D { + .has_subu =3D false, +}; + static const struct rzn1_rtc_data rzn1_data =3D { .has_subu =3D true, }; =20 static const struct of_device_id rzn1_rtc_of_match[] =3D { + { .compatible =3D "renesas,r9a09g077-rtc", .data =3D &rzt2h_data }, { .compatible =3D "renesas,rzn1-rtc", .data =3D &rzn1_data }, { /* sentinel */ } }; --=20 2.43.0