From nobody Mon Sep 28 18:36:40 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE3A41B4138 for ; Wed, 19 Aug 2026 05:30:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787117456; cv=none; b=SslKCaPMyMAssly1/AME5wzeqn8P7xaTV9ceEcs4DJmeAApphyyM5JjNJ5kWh+6Qz9ZmU6FZH4QlY3IaezdAfUWg86YWNCeurb1rI5zjm4Cj43c2iK6kkatjpwJuomasNAaFygJjS77C4s/epPWtCPRQoiieBb3fxv3Lsd2Skb0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787117456; c=relaxed/simple; bh=e2VGds5X/xfzMLSQ5PCs6zLcnqNPR99m7+/78W47KFo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=FfHBgKbRocMYKwATeax+iCV1StGLTJ4j7D2JqvI6HOnWjqK72sjhE38eQqXAsVTklNe281UmPjROkyoGkhgIFfDye+bUZfc/aBNCcc64YWOZBzKYgw+XbUx3fSKrvlkhy1xZ7vkh/l993Co5dyTjVOXwQeYgsdK3sg+M9Bijc7A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hV2DdeL2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ctvvgFtw; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hV2DdeL2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ctvvgFtw" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67J5I3BB3498681 for ; Wed, 19 Aug 2026 05:30:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=Iz/k6daqN3MTzD7Fc8HPs7 D5ldtsQ3zRn+5/COHyddc=; b=hV2DdeL2AnOpADX8lLcpW9NFttq1AV79/AQ7t2 B+1XVN3ZwBVPaufgji/1nIDWeZflWSE6wMvCjvlUp+jzuXL+TVyKXEDBDsxSsQkl dxEAVyIZQ1fAQasN4BTKh12FdCez+3vBeQLTaA0aGP8BMvCfB/17yqK1vUNNYYsX 42o5aFD0817XS09z+XGyWs7ao+6dOPWN8NjO+YtHrw75y6NYw0oP2cxrQXbK0T4r i45/HqTHsAh3DmobIkUcHAzO383Zze2RdFNEAcRDym9BaFYkgmiBYgXIK6Xu20DV cShetdRJkGLfZOL+S5jANUx6bgAtVLPFu8Regl9uDw2g5dvQ== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g4yftsgdv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 19 Aug 2026 05:30:54 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2cccfa32670so11156885ad.2 for ; Tue, 18 Aug 2026 22:30:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787117454; x=1787722254; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=Iz/k6daqN3MTzD7Fc8HPs7D5ldtsQ3zRn+5/COHyddc=; b=ctvvgFtwgs6kLfLj5z2wlCAgAbw05Vbxd5+03TgOG5z07enbHmNW23qy1sC+X0jA8e uJQoCOMECwClssMJNxAROZmGgln0HLLemBDrvHRnhOv8F3yoA+mPKzZsywTiL3W8AqAI Cum+uCpXMSFflYOTbcRrPrttETs+OGTOuEvmsctei04xfScz661C69+1NkLkRaFFoadt Yr4tqtNX1YL8oVgnSDeDOvl9xxVgU1u9CnzXiKFl+Pmjlf+/CBYifC0GygxC9g3nIRE2 zgFq0Fx6URoXUTzRAT7rgZcnmnyCfbzgcrXcITho618knXFf6d3RakhqdKWycihaYu+n NSjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787117454; x=1787722254; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=Iz/k6daqN3MTzD7Fc8HPs7D5ldtsQ3zRn+5/COHyddc=; b=Aye5qBPqUqfJjfwxxpnR5RwnZwIYmf3ML9xdRSVnej32BAjqSyIM5edMwFhrPhI1xo k/wdz19G5Qbzq2Y/1IbNwW/GNrfx51VIK7qNF0VtLNb/RJe2IANRealJgAx/i7DNejxw O60yszEvDKYqLzm1kSf6S2/7A74voK/SGKRCAmoIbz1paeY4kNXPlJ7OY4UasQHlDviz JvM04QUAibEPRNUQ4OwBE7d8bpyUTDaspC5QYO0ukkPJwRniThEWCHqTxB4x8st8PcFC Y/c3Ac/Z5NvtlplEkV7yVJnMzp4dx00AnFm3J1GtOd4OO0NMUikeVUGkgYB4pBK0IEuz 2/2A== X-Forwarded-Encrypted: i=1; AHgh+RrLmqGhhKTUzkMzvkLsowlDTCMXosC+4pNiInqKacAFVurbZw3QQf8SK3O7bHicQ7EcGLLNw3yvzwNAPFY=@vger.kernel.org X-Gm-Message-State: AOJu0YxHo5UcXIqttMrMB7FHxPrLvQuJOE/q/JQkQpIshHE3dEFf/5lI LLsynZq+GtK5aklVO+gx4JNEVAj2OxWuXD/gvx5KW33BzoH5OQX0b0268OuT9+7HSxcHcxhKdj9 IYBrjEZxwtGUbB/c4d7Y08opYOwyHsoN8FCXUqq2iSFJ5VNsEl9hp53jj/cJUE39FoVs= X-Gm-Gg: AR+sD11tzq8Uf40RkWL87Jkhn9HbdAF3FZ5NGqGk9p++ly9DgwaGTBwlC2yOReBOvDF JINli89mWi0UQcOjc9sTDI8Uy1GzSA+QAO4SE0PwakRqUxuQ11P9rq76zwi/Xvj2yPAJWtSlsbi aK3Ezy80pmO9uFsa3jvV1PY4PAghXRaQPIu9pQvsNBkeKNlEGrLw6vdqByPpWdjblUhM66pfw+N 0dOQubkbEzXCMoAwK5Qod+OIjd2BeJ8z4HHsf6EkaEA0hnDmFJnwrHYT7JEMGZPGeGVOHWnXCkb Vb9wc/fuSHqs88Nud5J68vU2XIiptR6LxJOPvQY2+MflQ/c6pZ+jk87OrjRHLwBvGGAADI0QHlF p7U5KYHtm1pZ4TWB6SQB3EiIpPjIrWrVLhYAfqHtDc8vpAx52Hal2GDJ6+wouNEzXBtV+y4DfQC S3Ku0xNfa9NB2xEuIWzQGkzeQ9BCI6Xg== X-Received: by 2002:a17:902:ccc8:b0:2cc:ae2b:b6d2 with SMTP id d9443c01a7336-2d601c7c8edmr39916875ad.15.1787117453913; Tue, 18 Aug 2026 22:30:53 -0700 (PDT) X-Received: by 2002:a17:902:ccc8:b0:2cc:ae2b:b6d2 with SMTP id d9443c01a7336-2d601c7c8edmr39916095ad.15.1787117453406; Tue, 18 Aug 2026 22:30:53 -0700 (PDT) Received: from hu-viswanat-blr.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d5bb4dfe6dsm23345275ad.18.2026.08.18.22.30.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 22:30:53 -0700 (PDT) From: Vignesh Viswanathan Date: Wed, 19 Aug 2026 11:00:30 +0530 Subject: [PATCH] remoteproc: qcom_q6v5_pas: Fix error masking in qcom_pas_stop() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260819-rproc_dtb_fix-v1-1-cb6be7f93bc9@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAHU/hWoC/yXM3QpAQBCG4VvRHNua9bPJrUiyazAO0CxScu8Wh 89X33uBJ2HyUEYXCB3seZkDdByBG9t5IMVdMCSYGCx0oWSVxTXdZpueT2Wwz9FkFk2qIXxWoTB /var+7Xc7kdveCNz3A/I4DZVxAAAA X-Change-ID: 20260818-rproc_dtb_fix-60f5064b0631 To: Bjorn Andersson , Mathieu Poirier , Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Vignesh Viswanathan X-Mailer: b4 0.17-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1787117449; l=2097; i=vignesh.viswanathan@oss.qualcomm.com; s=20260518; h=from:subject:message-id; bh=e2VGds5X/xfzMLSQ5PCs6zLcnqNPR99m7+/78W47KFo=; b=iF15ADwIcNNuvnx9f+fsBgEsfR8d4lhDCD8e7vDqtvNGh4a7nWEn5dLHehdckns45CAf91Qg5 JkbBs67pyZGBBxMCm5DSLNtzbAxzLcURaX7qDfB5r4I4ZNMJe1iS3EM X-Developer-Key: i=vignesh.viswanathan@oss.qualcomm.com; a=ed25519; pk=/lHspsTTqZQg546ZudgrbywCsk3Whx/C0XNVUevaKNk= X-Authority-Analysis: v=2.4 cv=FIorAeos c=1 sm=1 tr=0 ts=6a853f8e cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=nI7rSZthmJYPCuEtDAYA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE5MDAzOSBTYWx0ZWRfX9L6oDz2sFfD4 OQZXu/L8J1Mexi4lUxfXSj1HEcXNPVDl8c+uVw9gxAJxQLqkrLw91jUgYrIb46IJRjGVT01f/7p Gdx318RaL4HKYjzOtoZuv75u5Jc8j+M= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE5MDAzOSBTYWx0ZWRfX9p1x3TGpZsfo fIMmBKdN0G4I3pgOupDtFqefQSFNfD5U0KZFSmTDXG9rcMyHBNPFBHn0DgXc4ak+whUgl6snWHD 7pHnDbUDAySlKvKN8nZrSKCb8B1QD39aTbGWxBKr5tz2O75Fwi5id1rkIZ+plCtwk5hdc+agYST TME4hC16fLnj12/4m5/m9VbdpD2GY+hExzhA78mfk5s3k1WK2rUe8UXyGaw6h/ARgJQvyl1bhIm 4f+d4LDkFPD60IftFLls+P7lcrGseBbOb1Gz1fIFkV45E4wTiE0LUiMkWanV8GCHwkKmj9iWa5W koVC7ecNzTgbLo2T3o3wOkf71YYJ+zE8lppferaoZVL/jf0I399qILcGzkJAhrmiaspvR/ptD8n GluJ2bXLTgwNTk2ZOO08TXAOtxR9xPlfgPI1MlghI4WgRcszZHW6Iexd5ftUteoJr8qCTHYtaKr eIhcpJFXUIZJRbI7enA== X-Proofpoint-GUID: B6PHZNGSu6Q9yBlUiTDykQCyHpDUBY9C X-Proofpoint-ORIG-GUID: B6PHZNGSu6Q9yBlUiTDykQCyHpDUBY9C X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-19_01,2026-08-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 adultscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608190039 In qcom_pas_stop function, return value of qcom_pas_shutdown for pas_id is overwritten by the return value of qcom_pas_shutdown for dtb_pas_id. This causes errors seen on qcom_pas_shutdown failures for pas_id to be masked to the caller. This might lead to issues where the memory regions locked by PAS, as part of qcom_pas_auth_and_reset, are not released for access by linux and rproc_coredump flow will end up accessing the locked memory, leading to an access violation. Fix this by using a separate variable for the dtb_pas_id shutdown call and only overriding the main return value if the pas_id shutdown succeeded but dtb_pas_id shutdown failed. Fixes: 29814986b82e ("remoteproc: qcom_q6v5_pas: add support for dtb co-fir= mware loading") Signed-off-by: Vignesh Viswanathan Reviewed-by: Konrad Dybcio Reviewed-by: Mukesh Ojha --- drivers/remoteproc/qcom_q6v5_pas.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q= 6v5_pas.c index ca8e61254c44..40e8f3e32aa9 100644 --- a/drivers/remoteproc/qcom_q6v5_pas.c +++ b/drivers/remoteproc/qcom_q6v5_pas.c @@ -405,6 +405,7 @@ static int qcom_pas_stop(struct rproc *rproc) { struct qcom_pas *pas =3D rproc->priv; int handover; + int dtb_ret; int ret; =20 ret =3D qcom_q6v5_request_stop(&pas->q6v5, pas->sysmon); @@ -419,9 +420,12 @@ static int qcom_pas_stop(struct rproc *rproc) dev_err(pas->dev, "failed to shutdown: %d\n", ret); =20 if (pas->dtb_pas_id) { - ret =3D qcom_pas_shutdown(pas->dtb_pas_id); - if (ret) - dev_err(pas->dev, "failed to shutdown dtb: %d\n", ret); + dtb_ret =3D qcom_pas_shutdown(pas->dtb_pas_id); + if (dtb_ret) + dev_err(pas->dev, "failed to shutdown dtb: %d\n", dtb_ret); + + if (!ret && dtb_ret) + ret =3D dtb_ret; =20 qcom_pas_unmap_carveout(rproc, pas->dtb_mem_phys, pas->dtb_mem_size); } --- base-commit: e6664f2b33db9b6811eb4cec109f06cb2b4f458d change-id: 20260818-rproc_dtb_fix-60f5064b0631 Best regards, -- =20 Vignesh Viswanathan