From nobody Mon Sep 28 19:23:38 2026 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 425B72E7BD3 for ; Tue, 18 Aug 2026 13:27:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787059678; cv=none; b=AgfZ9VBlqb6cspMe5JCJ0HEW2ZO1H+B45JtFLQiI1mW8yXUdJ4L/1TMaxZoykzkqvPK1Et1Pq8thOrg57iBn4oyFa77LCUCy0hqgMoRm26Mrv8Kagh2IZyyO/BXrvpJXZYQkhMRORt0Z5niQUnDMmDOW/iWuyWoYu4Rs0Ile+Vo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787059678; c=relaxed/simple; bh=7NJByljIoIPorv3/Xy4RQAnsrnQSGyXDo7PFeEhMbNI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JTdYQeC8OfVNsM2Wn3SbrClFcDa5LZENAg0MY8m8ppLGkG88LSoSzu6iavWpRZReC+Ue21mjEUKWM6w+Hhcyc5vPZt5cRjAvSVabvR12PRsaCZul3PEEJDqArfHPZxvDA7N3fbzf3v3zbCgAVQOKsCdDKu7M0oIE1uBJU7OjLCM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JmIx4K4y; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JmIx4K4y" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-47f904e80eeso4498795f8f.1 for ; Tue, 18 Aug 2026 06:27:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787059674; x=1787664474; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+3s0Ug7tKmBUVY9glqgI6hd1KhOLM6Z7RD4robd3dno=; b=JmIx4K4yGcxqwr/LGZZm+HrwQc15zBseTQ5v9gdGGfGzL5mwQR1G0dzcCLTThcSr3u G34J/MASz6WwZpBhKc4/UlUXq+KtyADEJGgiLL3fwdtKsLpIE/6GJmhcYhS1tUnYZuQu +AU1PWrlQ3gbJt0NuokTgPQ9XgHV6D1GIEzFCq1eOxxZqkj+nw8hBWWUBIoriF0inakI GpduzLQ8Xsj4FFtG5VOCKoYhLJk6ZqW8mtrZ0w2+Li5ITtfJzgS0m0nWgY719zt30giZ 4fUQJ9uIw+oTBIPKo4rn3GWdcZamP2yLYPoX24lPBMg1qI+9lS/X09XKA2BiLwv9oDTi iwWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787059674; x=1787664474; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=+3s0Ug7tKmBUVY9glqgI6hd1KhOLM6Z7RD4robd3dno=; b=K5fg/Q0I4poZmPIzOHb+A9q/odSvqlJArYQkI+Hl1BzaPdp5n/kuUJZv4awl5bPDMj VFuBFMtY4fNvxP0abf9PAo2/WPRK4xjpUbgmopTun9vyGZyHv62Ven2SwjOW6ZqTfDPM 6CNLHefYzp7lhATV3odYWem6GRFpv7H2ryiGvp7nypKu9dxPPmdSQITyoPMGEDg4o5wi Cv5tJez2ItbAyFq5i4yFjxemFfaCr+6j04sfs/gX7sBZ5nt6GiH/kPJQuJHAgfpeVVrk B5ISMzHaPb4S/y5xt+yACdwDp4sKfrZThkzgtPq94LYU5GO5J69A4IzSylJuHMTdk6gZ 8LgA== X-Forwarded-Encrypted: i=1; AHgh+Rpj+ca6OweNxhBp1rIX8dgx/oeFBEBfVU5kC/bMJM5469svNTGDmCnlN3VgtdCN6p4q0LM2B8BQ3L5E3Js=@vger.kernel.org X-Gm-Message-State: AOJu0Yyoe93FFDdQSRPGIfyM5ParMZf2brLdQAWlN2B2uUV5JVdxaGeC h+Yx9lkZNpL0ebJMomO6USA70RAmirVFzCwd7tu4Uc2yhumU3H8W6A/f X-Gm-Gg: AR+sD11OCia+QGmM9ZRZX9GvslIWbV8ckH/bVYV3A8gfmFAfuU4tWH5T+ja7Y9IxlX4 SwKxNxnujcMR8cZoYIkrk9kc56VJVXKjzXbj+3PmD1B2yPHtfoDk2npjimao7aW2qS8LCPqNI7n xOx9cUlHWSUZHyeHveX//nWQwUbRaJ7AM+xCBLmLGNjs62aLlEMvHgsRq+x9hu5jYimdNCIfWhQ rTrMpSF/98A5cH8C2kTf4/ypLvH8aIjsITonlW+41TELQt/WuhCSkULrieTYBlE1+u+W4x+y9p4 ADwj8NeBXYjRyFyqYFuPD3ApcWYMUxrQ+xW9EoqnfUs7CE9r0z7/SuQWOeIfpVF0JvNDHVX0h+Z /WA9pmtnT2EMepaVoA2zmsQk9WA/qKZRHB/eSxfRhAdonZe4WnfdsP/gng7Wbd/sDAb8XpoXTh3 I6m39LgbI9V3nYz4O/562RO5Mlu74Zi6qXf5U5v+8h0uTLObO6D99ow6h/u0ZmfTp+qPfVLg== X-Received: by 2002:a05:6000:25fe:b0:482:a9d7:7ced with SMTP id ffacd0b85a97d-482a9d77d37mr13957650f8f.14.1787059673878; Tue, 18 Aug 2026 06:27:53 -0700 (PDT) Received: from server227.. ([39.170.101.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482a5a7c568sm12140145f8f.18.2026.08.18.06.27.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 06:27:53 -0700 (PDT) From: Zxyan Zhu To: maxime.chevallier@bootlin.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, andrew+netdev@lunn.ch, richardcochran@gmail.com Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, muhammad.nazim.amirul.nazle.asmade@altera.com, Zxyan Zhu Subject: [PATCH net-next v3 1/2] net: stmmac: dwxgmac2: add XGMAC timestamp interrupt support Date: Tue, 18 Aug 2026 21:27:21 +0800 Message-Id: <20260818132722.1852876-2-zxyan0222@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260818132722.1852876-1-zxyan0222@gmail.com> References: <20260818132722.1852876-1-zxyan0222@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" DWXGMAC2 uses XGMAC_TIMESTAMP_STATUS at offset 0xd20, while the generic stmmac PTP handler reads the dwmac4 offset GMAC_TIMESTAMP_STATUS (0xb20). Before this change, the DWXGMAC2 and DWXLGMAC2 hwif entries used &stmmac_ptp, whose timestamp_interrupt callback read the wrong register and whose config_hw_tstamping callback never enabled the XGMAC timestamp interrupt (XGMAC_TSIE was not in XGMAC_INT_DEFAULT_EN). As a result, auxiliary snapshot events were never reported on XGMAC platforms. Add a dedicated DWXGMAC2 timestamp interrupt handler that: - reads XGMAC_TIMESTAMP_STATUS before checking STMMAC_FLAG_EXT_SNAPSHOT_EN, so that the timestamp interrupt status is cleared even when auxiliary snapshots are disabled - derives the pending auxiliary snapshot count from the persistent ATSNS field instead of the transient AUXTSTRIG status bit - generates the corresponding PTP_CLOCK_EXTTS events Also enable XGMAC_TSIE in XGMAC_INT_DEFAULT_EN and hook the new handler into the DWXGMAC2 and DWXLGMAC2 hwif entries. Signed-off-by: Zxyan Zhu --- .../net/ethernet/stmicro/stmmac/dwxgmac2.h | 2 +- .../ethernet/stmicro/stmmac/dwxgmac2_core.c | 43 +++++++++++++++++++ drivers/net/ethernet/stmicro/stmmac/hwif.c | 4 +- drivers/net/ethernet/stmicro/stmmac/hwif.h | 1 + .../ethernet/stmicro/stmmac/stmmac_hwtstamp.c | 12 ++++++ .../net/ethernet/stmicro/stmmac/stmmac_ptp.h | 1 + 6 files changed, 60 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h b/drivers/net/e= thernet/stmicro/stmmac/dwxgmac2.h index 61b6d45a02f5..76e2860a9517 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h @@ -87,7 +87,7 @@ #define XGMAC_TSIE BIT(12) #define XGMAC_LPIIE BIT(5) #define XGMAC_PMTIE BIT(4) -#define XGMAC_INT_DEFAULT_EN (XGMAC_LPIIE | XGMAC_PMTIE) +#define XGMAC_INT_DEFAULT_EN (XGMAC_LPIIE | XGMAC_PMTIE | XGMAC_TSIE) #define XGMAC_Qx_TX_FLOW_CTRL(x) (0x00000070 + (x) * 4) #define XGMAC_PT GENMASK(31, 16) #define XGMAC_TFE BIT(1) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c b/drivers/= net/ethernet/stmicro/stmmac/dwxgmac2_core.c index f02b434bbd50..b849cebf9b29 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c @@ -1154,6 +1154,49 @@ static int dwxgmac2_get_mac_tx_timestamp(struct mac_= device_info *hw, u64 *ts) return 0; } =20 +void dwxgmac2_timestamp_interrupt(struct stmmac_priv *priv) +{ + u32 ts_status, pending_snapshots, acr_value, channel; + struct ptp_clock_event event; + unsigned long flags; + u64 ptp_time; + int i; + + /* Read XGMAC_TIMESTAMP_STATUS to get the AUX snapshot + * count. This read also clears the TSIS bit in + * XGMAC_INT_STATUS. + * TX timestamp polling may have already cleared TSIS + * and AUXTSTRIG, so rely on ATSNS instead. + * TXTSC is cleared by XGMAC_TXTIMESTAMP_SEC, not by + * this register, so there is no conflict. + */ + ts_status =3D readl(priv->ioaddr + XGMAC_TIMESTAMP_STATUS); + + if (!(priv->plat->flags & STMMAC_FLAG_EXT_SNAPSHOT_EN)) + return; + + pending_snapshots =3D FIELD_GET(XGMAC_TIMESTAMP_ATSNS_MASK, ts_status); + if (!pending_snapshots) + return; + + acr_value =3D readl(priv->ptpaddr + PTP_ACR); + channel =3D FIELD_GET(PTP_ACR_MASK, acr_value); + if (!channel) + return; + channel =3D ilog2(channel); + + for (i =3D 0; i < pending_snapshots; i++) { + read_lock_irqsave(&priv->ptp_lock, flags); + stmmac_get_ptptime(priv, priv->ptpaddr, &ptp_time); + read_unlock_irqrestore(&priv->ptp_lock, flags); + + event.type =3D PTP_CLOCK_EXTTS; + event.index =3D channel; + event.timestamp =3D ptp_time; + ptp_clock_event(priv->ptp_clock, &event); + } +} + static int dwxgmac2_flex_pps_config(void __iomem *ioaddr, int index, struct stmmac_pps_cfg *cfg, bool enable, u32 sub_second_inc, u32 systime_flags) diff --git a/drivers/net/ethernet/stmicro/stmmac/hwif.c b/drivers/net/ether= net/stmicro/stmmac/hwif.c index 511b0fd5e834..9718582b8480 100644 --- a/drivers/net/ethernet/stmicro/stmmac/hwif.c +++ b/drivers/net/ethernet/stmicro/stmmac/hwif.c @@ -258,7 +258,7 @@ static const struct stmmac_hwif_entry { .dma =3D &dwxgmac210_dma_ops, .mac =3D &dwxgmac210_ops, .vlan =3D &dwxgmac210_vlan_ops, - .hwtimestamp =3D &stmmac_ptp, + .hwtimestamp =3D &dwxgmac2_ptp, .ptp =3D &stmmac_ptp_clock_ops, .mode =3D NULL, .tc =3D &dwmac510_tc_ops, @@ -280,7 +280,7 @@ static const struct stmmac_hwif_entry { .dma =3D &dwxgmac210_dma_ops, .mac =3D &dwxlgmac2_ops, .vlan =3D &dwxlgmac2_vlan_ops, - .hwtimestamp =3D &stmmac_ptp, + .hwtimestamp =3D &dwxgmac2_ptp, .ptp =3D &stmmac_ptp_clock_ops, .mode =3D NULL, .tc =3D &dwmac510_tc_ops, diff --git a/drivers/net/ethernet/stmicro/stmmac/hwif.h b/drivers/net/ether= net/stmicro/stmmac/hwif.h index e6317b94fff7..818ab3daa91c 100644 --- a/drivers/net/ethernet/stmicro/stmmac/hwif.h +++ b/drivers/net/ethernet/stmicro/stmmac/hwif.h @@ -671,6 +671,7 @@ extern const struct stmmac_desc_ops ndesc_ops; =20 extern const struct stmmac_hwtimestamp stmmac_ptp; extern const struct stmmac_hwtimestamp dwmac1000_ptp; +extern const struct stmmac_hwtimestamp dwxgmac2_ptp; =20 extern const struct stmmac_mode_ops ring_mode_ops; extern const struct stmmac_mode_ops chain_mode_ops; diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c b/driver= s/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c index b9a985fa772c..9d7d24259abd 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c @@ -277,3 +277,15 @@ const struct stmmac_hwtimestamp dwmac1000_ptp =3D { .get_ptptime =3D dwmac1000_get_ptptime, .timestamp_interrupt =3D dwmac1000_timestamp_interrupt, }; + +const struct stmmac_hwtimestamp dwxgmac2_ptp =3D { + .config_hw_tstamping =3D config_hw_tstamping, + .init_systime =3D init_systime, + .config_sub_second_increment =3D config_sub_second_increment, + .config_addend =3D config_addend, + .adjust_systime =3D adjust_systime, + .get_systime =3D get_systime, + .get_ptptime =3D get_ptptime, + .timestamp_interrupt =3D dwxgmac2_timestamp_interrupt, + .hwtstamp_correct_latency =3D hwtstamp_correct_latency, +}; diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.h b/drivers/net= /ethernet/stmicro/stmmac/stmmac_ptp.h index 3fe0e3a80e80..dade09614163 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.h +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.h @@ -103,6 +103,7 @@ int dwmac1000_ptp_enable(struct ptp_clock_info *ptp, =20 void dwmac1000_get_ptptime(void __iomem *ptpaddr, u64 *ptp_time); void dwmac1000_timestamp_interrupt(struct stmmac_priv *priv); +void dwxgmac2_timestamp_interrupt(struct stmmac_priv *priv); =20 extern const struct ptp_clock_info stmmac_ptp_clock_ops; extern const struct ptp_clock_info dwmac1000_ptp_clock_ops; --=20 2.34.1 From nobody Mon Sep 28 19:23:38 2026 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFE64476CF7 for ; Tue, 18 Aug 2026 13:28:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787059687; cv=none; b=EyDL1ydshyxSRQNiMq7xpEykx+S2H6x0RSqW7+MouKQgxArqgjlOmFY1PQ6o/8IvkJsw+x6PusoxI7b37raGqPI4FBMvrAWGS2P3DgfI47yOtr3gBCUTh3uZBmcmhGC9wHPeZoy+TjIN7ivArpZMYlbJEYc8e1siOd2ahk1UpdI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787059687; c=relaxed/simple; bh=hKXgIueQ+cktyJ3NvuIdviR5rHT5VkYLFJZj7Ezv9gc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=StP7EbSsokJE4uhPnaOkK6prCx3dcjSXI1Feru+7UQwQvswPaBOAJwJBeSEzgLRjkV00ayXSnqZRk1W8j6T5LRpoqUnizWkoBq13PsdFpjmHQ248Dd6Nc1pUo7mehzN8zKNk0HLbB0T3nxreCuQoC/LSfad+StQsJbSbKyAHjqA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GyW9vgPi; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GyW9vgPi" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-47fd4531020so2792927f8f.3 for ; Tue, 18 Aug 2026 06:28:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787059684; x=1787664484; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=djPZzMb89wYlNjLL6Fty3Ib9LSWHKIU4RnghfXD9YU0=; b=GyW9vgPi3VKZAXKWNVwxYUI80wrImrCMojgMewxH/nG41g1H7jZKOPQMg9exZtBdiP uvx96KMQlSwdF67gf+vx1JBpMoV6DMPQ2L6mVjOMl4ck09bYO10vb1rDa7eYNcWCpP8t dDVYwyPI8bbSBhM4vElVqP2YGbt8Zkru9Xntl/iqgUJLu39V5Q16tXci6A19I6jC1sBA YUL56d43p+49xKDw4nqucc9XZDDIZykpISG8Uu8ZZDIUkKDY1J3RM4f9OygOo9NGs8Bt m5m9epmcZDViCRTh1LPI8OXDX/95zOGkLzj0wZn9fqkM8R951t5oYw6YGvkVAzy4CPHb Ir2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787059684; x=1787664484; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=djPZzMb89wYlNjLL6Fty3Ib9LSWHKIU4RnghfXD9YU0=; b=JyzpIibwusk5H3dp9sp4lvOJ5k6n/oFOvHm9TfbTWaM5GNydcBi+nmITH+WFcXd/aa D80nFFzK1bKxMmh7vBV+wRzUijZfPofNMe+diorw52dhN4kq849cAld+kq5stQMPMNNU VOV3+6QhQprIz1uTgZOq35SYE4XeF9fdI0TikfLk8AFv/HBSo69NBtWDMkEmlkih2vR9 TwiiRl8w5FqfwB72CYgycZhadLPECYnyUsw4cFSJQ8sciMpAi0jU+IJxBYdzYltqWfkR C2rwsL6skYST90OB+NvngmdnnX0e+ey9pSRNEvdhI2Ur9s/1Tq7NkhWT0XoQUJECaEz/ 8K2A== X-Forwarded-Encrypted: i=1; AHgh+RpFN7moAHs1oocH5F/For0eCvrLOdsQR+wADhnxUlZwg39eDr9hPPMVe3BemfrjCbYsFq6RrCaFoBntFro=@vger.kernel.org X-Gm-Message-State: AOJu0YyKjMEBsDu6No4KCRWs+WNclz7SB8r/YfLmn1S44aNnh8Vmh6c8 EKVcxbQRqm1cj9fCl15osIH2jxOmHbwFXdyInFCv/OjLu+RxTG6DA0jsIOfCoBiY X-Gm-Gg: AR+sD121nJ0KY8LwIpKeOcBeIkMJ4OcQ0G7BDjPkbZdpjT+RMLL+WWXwWJhvxuKunrN LKG6vPQraxELviWMxLvGhwHKWCH2hAZXUUcmAe8KvvBQNgk5d2zYJBaGvhBbK4IeH6upNC/hTNp ECtcdt4vda8OCaMGZMLQYgwNhTkG8hDOuNMQaRc3OeAKN9aydXjmBfRNjPMnNG9iwAUHC9qljGw RyW0RXBLJ7T8e1GREMbid32df969MudpBVvU4QpHKuLtesfGnM6ubvLzCdy3xCnY8ggZeBZOVbC BB/1CWjwattfHGGOgT5MRYEVtk5RtjG3pfOJN1VXxuGi5uCiYOvQ5UvJMSrOa5O9/fpfDGFvJXV wd68E1ryMKcV/U7ydWfqyLS54RYt1oKl2b5RgGAk9FdfZOJ0th/Ox6n+jWo60zhlg5PnXa2NEP4 PG8Wv0jwUaA4bMiYCrfOIrhb7Yd/OPczaBirz3BxqOMYAAzqo7A6IiybBZpLM= X-Received: by 2002:a05:6000:1a85:b0:480:c5:d635 with SMTP id ffacd0b85a97d-481606ac8bemr51077592f8f.0.1787059683663; Tue, 18 Aug 2026 06:28:03 -0700 (PDT) Received: from server227.. ([39.170.101.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482a5a7c568sm12140145f8f.18.2026.08.18.06.27.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 06:28:03 -0700 (PDT) From: Zxyan Zhu To: maxime.chevallier@bootlin.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, andrew+netdev@lunn.ch, richardcochran@gmail.com Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, muhammad.nazim.amirul.nazle.asmade@altera.com, Zxyan Zhu Subject: [PATCH net-next v3 2/2] net: stmmac: dwmac-socfpga: mask XGMAC_TSIE during cross-timestamp Date: Tue, 18 Aug 2026 21:27:22 +0800 Message-Id: <20260818132722.1852876-3-zxyan0222@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260818132722.1852876-1-zxyan0222@gmail.com> References: <20260818132722.1852876-1-zxyan0222@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Agilex5 smtg_crosststamp() handler arms an internal auxiliary snapshot, toggles GPO0 and then polls XGMAC_INT_STATUS for TSIS in process context to learn that the snapshot is ready. Once XGMAC_TSIE is unmasked (done by a companion change that enables it in XGMAC_INT_DEFAULT_EN), the DWXGMAC2 timestamp interrupt handler runs from hardirq on every timestamp event and clears TSIS by reading XGMAC_TIMESTAMP_STATUS. That read can win the race against the poll loop, which then times out and makes PTP_SYS_OFFSET_PRECISE fail with "Wait for time sync operation timeout". Mask XGMAC_TSIE around the snapshot trigger and FIFO read so the hardirq handler cannot clear TSIS while smtg_crosststamp() owns it, and restore it on every return path. Tested-by: Nazim Amirul Signed-off-by: Zxyan Zhu --- drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c b/drivers/= net/ethernet/stmicro/stmmac/dwmac-socfpga.c index 1d7f0a57d288..a4d00bf81423 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c @@ -310,6 +310,13 @@ static int smtg_crosststamp(ktime_t *device, struct sy= stem_counterval_t *system, if (priv->plat->flags & STMMAC_FLAG_EXT_SNAPSHOT_EN) return -EBUSY; =20 + /* The XGMAC timestamp interrupt handler clears TSIS by reading + * XGMAC_TIMESTAMP_STATUS, which would race with the TSIS poll + * below. Mask XGMAC_TSIE for the duration of the cross-timestamp + * so the handler does not run while we own the snapshot FIFO. + */ + stmmac_mac_irq_modify(priv, XGMAC_TSIE, 0); + mutex_lock(&priv->aux_ts_lock); /* Enable Internal snapshot trigger */ acr_value =3D readl(ptpaddr + PTP_ACR); @@ -329,6 +336,7 @@ static int smtg_crosststamp(ktime_t *device, struct sys= tem_counterval_t *system, break; default: mutex_unlock(&priv->aux_ts_lock); + stmmac_mac_irq_modify(priv, 0, XGMAC_TSIE); return -EINVAL; } writel(acr_value, ptpaddr + PTP_ACR); @@ -353,6 +361,7 @@ static int smtg_crosststamp(ktime_t *device, struct sys= tem_counterval_t *system, ret =3D readl_poll_timeout(priv->ioaddr + XGMAC_INT_STATUS, v, (v & XGMAC_INT_TSIS), 100, 10000); if (ret) { + stmmac_mac_irq_modify(priv, 0, XGMAC_TSIE); netdev_err(priv->dev, "%s: Wait for time sync operation timeout\n", __func__); return ret; @@ -375,6 +384,8 @@ static int smtg_crosststamp(ktime_t *device, struct sys= tem_counterval_t *system, read_unlock_irqrestore(&priv->ptp_lock, flags); } =20 + stmmac_mac_irq_modify(priv, 0, XGMAC_TSIE); + get_smtgtime(priv->mii, SMTG_MDIO_ADDR, &smtg_time); system->cycles =3D smtg_time; =20 --=20 2.34.1