From nobody Mon Sep 28 19:23:42 2026 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CCBC3A6F1B for ; Tue, 18 Aug 2026 08:06:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787040406; cv=none; b=Wu1L8iBMA3OSo5GvPlFiOWd9NVSpOOXsX6FvQsIqQwaiFzuytiTyYgeiFIoze6vTCwj6MJfQeseaRjtwZvOgEZA3EGsmoqn8zW/quj8DlX/I71x/FUgn2jxMbiuUpT+UfZ8vNVpci0g3H4Q2bEmbAO0iAt00Lp3DjCDiI7B6XDo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787040406; c=relaxed/simple; bh=BtMVAHXM9KoBuSaBgXcPyEGGY8yWHDBQpY2nHDSPMuc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SSUORvtkcMUHMEuFhzvXTisl7hvweXTgzIUZHIzDZo+8I0AMfzI9D9NoPXSyzq8FIzWUOU6NRcId0SExeMUOLNZBGxDlShshcB1r1YiXvPHR1eZioQrkal+GaVnvMo8KC9whiXQjqlz/inKucNm7T4HQtZgoq+dWOkCs2rfzBAo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a2LQDWR+; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a2LQDWR+" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4953e04ef16so47894355e9.2 for ; Tue, 18 Aug 2026 01:06:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787040403; x=1787645203; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JlTQW/BF9URteLWdGLssLkReJV29Ip7yvpMIAoyvb8I=; b=a2LQDWR+82bkS9J4eXV+4nSAptKMRKco4H+M7q4CHMtuvtIyanozbI60LeUts7hKkd MyhDlYmGsRYWvRITQtRseg8rimW3Q/Sk+eST/8FEJhJQSyh5ega7sQD5HdlFuH1KwQFH 4nNDqitvnvlcsbdMFVvq6Z1eLtPds1dbSzMmEt7H3WzEQWW7Z9JziN98rEP3+nd1jgrt OqfsShoOvfG9GZdjsJRpKcANzWpcLn09kBSG8jRvKCwpNwogDD9V4k1evhg1D+X1vvOy 7MMIRc58F8LXNkXJHAnM0uS8GBLQgaORZSN+lYoNqdPC8Y5FDujbfCyMnzYbi1MS78gL 5Mbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787040403; x=1787645203; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=JlTQW/BF9URteLWdGLssLkReJV29Ip7yvpMIAoyvb8I=; b=TsRQ+KNqIcdUG06JuPgApwwcAm0OWtSW5uWzAlyGRf7qbHlPXK9dle0Sr0BBkbBdTG /iC/ogrwl75WxrfRxhMKcpvOZUCriNZLaaLS72oaHvhW6EwJRy8RxBPXyxzK1e2E7NE0 LcKeocKXesacHmpM93Ih+WwdzorxlbIZDpyNfupj4lgBb4w47R6ZY/ylDOmksiqewVWg NcPPyVIXUfC40/5L3rmSG6afsP7OBz0WWNhuXr+S2cSzp+tHvFMEn3vmKmsMkJ42Czda I5SPRufBMjQCxESYFZW2AZ3eq+fxkeayFM07L4N9tNO3IwqckER2HStyT1Akl1RuvxQ2 WRzA== X-Forwarded-Encrypted: i=1; AHgh+RoJQMayuy+SAhs/DOcAUs2dgB+nTuxuAXBDmHzsi1xld4kuFLwNeJaX0Jr9R1l+7S7CCpMBooJpn1iQNeE=@vger.kernel.org X-Gm-Message-State: AOJu0YyfbaIlpIBk+Lfr6Z49ilVK4P2CpoNfTOzgb13huqYdZT8kXOsH 86qoDu5Cu6+qmvQUUAOoedjAwlUFkQuw7L5cdVURIQ6ca4fDX9pKRoh2 X-Gm-Gg: AR+sD12qXF36UGq7r57Uw2jn3/hYvKm/QwGND5o6KKzB/HFELzYRFxNF06+Zytk8xqb iv4AoN2pFMTQzR1uJh/JIYssY6DWDKRcr4o0zBtmZgXxwQlvaprZ+CQ0H+0pFrml8dp+F3E2np/ JZwaHjjA5eiZ0xeVgbVPWfbPqiYKPQULokELT4rtqvBGV8uebLWvKHBTwiplvHH+F64UN5txJnQ twD4zasdyeY58EWla4lamYFiEV5GDMmOUfcxljfMcOwuBY7xajMwejwasjOopZ7Nj8yRC4M1AkH jMg7+cTv5VkrqSnzBfgBuPOCJpe03ofOB8AAMraHkmFJN7k3a3T3kNLAfa387RQaq13jRCYc4p9 rsXTgb9YROCqX3m/2OZau7jNgyOUvmH0wS4NdGWAVXOZtJw7rc5LVF0RgOPsjIGSRqgl3Bs0txY YW9CPTYD3Dn9vcHygYrNeODZyttfFBJoSKNllVT9/sQtAfa4nzjiVTFUYcKGGVshmdcVQTV8rfA Ds= X-Received: by 2002:a05:600c:528d:b0:499:900c:9c69 with SMTP id 5b1f17b1804b1-499900c9e99mr376832095e9.9.1787040403473; Tue, 18 Aug 2026 01:06:43 -0700 (PDT) Received: from anthony.local ([2a06:c701:9cc4:c200:33d8:8ea2:e077:ebe1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482a5a3b2e9sm10367223f8f.9.2026.08.18.01.06.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 01:06:43 -0700 (PDT) From: Amit Barzilai To: Javier Martinez Canillas , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Andy Shevchenko , Fabio Piparo , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Amit Barzilai , Krzysztof Kozlowski Subject: [PATCH v4 1/6] dt-bindings: display: Add Solomon SSD1351 OLED controller Date: Tue, 18 Aug 2026 11:06:21 +0300 Message-ID: <20260818080626.30430-2-amit.barzilai22@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260818080626.30430-1-amit.barzilai22@gmail.com> References: <20260818080626.30430-1-amit.barzilai22@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a device tree binding for the Solomon SSD1351, a 128x128 65k-color RGB OLED display controller driven over a 4-wire SPI bus. The binding builds on the shared solomon,ssd-common.yaml properties already used by the other Solomon display controllers. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Amit Barzilai Reviewed-by: Javier Martinez Canillas Reviewed-by: Krzysztof Kozlowski --- .../bindings/display/solomon,ssd1351.yaml | 42 +++++++++++++++++++ 1 file changed, 42 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/solomon,ssd13= 51.yaml diff --git a/Documentation/devicetree/bindings/display/solomon,ssd1351.yaml= b/Documentation/devicetree/bindings/display/solomon,ssd1351.yaml new file mode 100644 index 000000000000..80850c2ab5b3 --- /dev/null +++ b/Documentation/devicetree/bindings/display/solomon,ssd1351.yaml @@ -0,0 +1,42 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/solomon,ssd1351.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Solomon SSD1351 OLED Display Controller + +maintainers: + - Amit Barzilai + - Javier Martinez Canillas + +allOf: + - $ref: solomon,ssd-common.yaml# + +properties: + compatible: + enum: + - solomon,ssd1351 + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + #include + + spi { + #address-cells =3D <1>; + #size-cells =3D <0>; + + oled@0 { + compatible =3D "solomon,ssd1351"; + reg =3D <0x0>; + reset-gpios =3D <&gpio2 7 GPIO_ACTIVE_LOW>; + dc-gpios =3D <&gpio2 8 GPIO_ACTIVE_HIGH>; + spi-max-frequency =3D <10000000>; + }; + }; --=20 2.55.0 From nobody Mon Sep 28 19:23:42 2026 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 813B741A926 for ; Tue, 18 Aug 2026 08:06:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787040409; cv=none; b=dNmDdys81x35gGuhP+AtFBE+5tqUEx4IawRfAjn5r4IhfpX0wOcURPJa3c9XVfkqd4hlTx8zi3exf2bzv1pybz7s8q0bWCmrzZiNKYTQVO3wses/ShrF3J8DS3YPEp3J7Gn9y4HSSIenWSqcNaYXPr2Y/ijNaWlOnaopFOom9rs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787040409; c=relaxed/simple; bh=TVi24iBQ1QVrTa+rzUHLKX53+fSWuDkq8cbLEoN9vMs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RXkMae7GggKUeU796TiO+7VuvNw25NPVQBQpzhKZJH+RVOYEuhJQ3jYhbCJKUDb/6Xa/vZIgFtQ09ABq9P1KNe/tPSLwKfvH+2faLKFjG3Lv/8FAfTuxqhy3+PfLrUJ7IyI8YQtafA9bBMX46BjIAVcSTTnIYAN8jlzmlwOi6JI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I1C7/d5f; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I1C7/d5f" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-c160420289bso579540366b.0 for ; Tue, 18 Aug 2026 01:06:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787040406; x=1787645206; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9ky5AAenkhb8FlnMl43V7nWMO27MSh6zMgGttM+QAy0=; b=I1C7/d5ftt5iUpudS8y5TDZ60gadD80gVRZXHoTLO5DNr0Q8ZYkwU1wO6ldngYYSrL v6w89rUceYPpdOSCmhYjWOCAQrJIYm/L8JygtomcvtHeHjXpWEoanha+L5/8YIN4T19J Y8NLGIQzYU5K56Zl82jZRm8iNNhno0+hMW0gAyDHZai1OVB1GcdsGiV7sdEweO7Hn/0p ZETkfz/WSFEFJInV/ShLlWLcfGAomGOSD8XuJxHN5jLn+Ay2O9MTQYXdvT1O1PmHjAk0 wlASePQZhDEBHEfxWv3DUv6V2iOoBiqnAXxIp+gv4HjNkWiSlneZWzwra2wKvwueNQ9G yyug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787040406; x=1787645206; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=9ky5AAenkhb8FlnMl43V7nWMO27MSh6zMgGttM+QAy0=; b=rELg3uWs5tLuBGJ84H0bdaF1AUBogAWw3y+O189U/nRXjlas4BIStrEuzfRGs/ewjp GAeZL357WznyUs3mDZmYDgNIVSPGfNZEfYiPQ5oyFoCb1Ben/CXGjHIiTc64HeX1JfZk fdSIcmvEm+T36JN56+ymaPtYQ9d8e/PAgStHep1TY5WC6EXNobHDGxRzi8DIYkg7fVKe IJ/8Bpn/2Dei3M6lDtKGjbCRkrJ198QIxPQ/WTv1hYytrFlWUKKXHkbNa252etL63M6y 4ED/EU9H0wFJF5jafnXHLAIYPe0OMRtZIvPeUglpUVSuX1A4++C48Jveadu/6IgYdgwI hE7Q== X-Forwarded-Encrypted: i=1; AHgh+Rp+NLY2QgPef3n0jvlCE4DK5E/9T5vxcgdB921gdXeFNMI70TvVb2rIrNpAi7eh4yHx0i0/31UFv1xR8Ik=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4fN4Lns7YH9Fhvz/a9v4aeNoABzVzmQHpyrSUY4OhFkdGkG7m cYaV0dtee/oDlwm8mn/ernCJF3aDhampamcBX1jm59pyyhK2q5blNLXJ X-Gm-Gg: AR+sD10j8iwgfbyA42wpSPzcyKz2kfyNhswqdqqFp5Ky/Q8dn6t5O4qwHqRTMOfI5rT I5Mf/mminzGSjlhJep3oJt5On96q8LKXmkaFKoZ8S1isZEU00EGk2JcMaKmC/2XYDIAohBE2MsI 1kv4WwylNcBFMb4lUIQDqr4ah0PuCeoC/5TOIpq/niCCgY1f8Kef5c6o4inxQy3vlKuokYcAA1P 8Da0s52+BYgCnxrW067j6NlFtsj1bNJ1twaZeunsrj7TNjJBkPTP9QJX4xHO0FWffoyRKtq6V06 C4qtQKtcwcc2TwNd9+M5yx8ewCqzJuv8OA4sec5/uREg7KMu+A+JmM8WcqlA44S7Wtyk/e5hBDn r6dhi9VbCAK1gWngJpzd/aztNZJEHlu0huiwh9+j1XwlryDvFaPmM8r7DpA36DdD6O0TvgZ8C/p NZNs99emjOv/1oEaq4XacUbvjKllwes0sjCzIw7NAmREXK4FuzcxFHNJJAXdEjq3frzVm/Hfc+m ZZc X-Received: by 2002:a17:906:a8c:b0:c20:31d1:a899 with SMTP id a640c23a62f3a-c2188470ce8mr280058166b.4.1787040405261; Tue, 18 Aug 2026 01:06:45 -0700 (PDT) Received: from anthony.local ([2a06:c701:9cc4:c200:33d8:8ea2:e077:ebe1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482a5a3b2e9sm10367223f8f.9.2026.08.18.01.06.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 01:06:44 -0700 (PDT) From: Amit Barzilai To: Javier Martinez Canillas , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Andy Shevchenko , Fabio Piparo , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Amit Barzilai Subject: [PATCH v4 2/6] drm/ssd130x: Change SSD133X color format to RGB565 from RGB332 Date: Tue, 18 Aug 2026 11:06:22 +0300 Message-ID: <20260818080626.30430-3-amit.barzilai22@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260818080626.30430-1-amit.barzilai22@gmail.com> References: <20260818080626.30430-1-amit.barzilai22@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" SSD133X screens were driven at 8bpp RGB332 despite supporting 16bpp RGB565. Switch the SSD133X data path to RGB565. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Amit Barzilai Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/solomon/ssd130x.c | 45 +++++++++++++++++++------------ 1 file changed, 28 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ss= d130x.c index 0b0fc6fe3df2..1110aa63d066 100644 --- a/drivers/gpu/drm/solomon/ssd130x.c +++ b/drivers/gpu/drm/solomon/ssd130x.c @@ -146,6 +146,11 @@ #define SSD133X_DEFAULT_CONTRAST_B 0x50 #define SSD133X_DEFAULT_CONTRAST_C 0x7d =20 +/* ssd133x remap byte (data of SSD13XX_SET_SEG_REMAP) */ +#define SSD133X_SET_REMAP_COM_SPLIT BIT(5) +#define SSD133X_SET_REMAP_COLOR_DEPTH_MASK GENMASK(7, 6) +#define SSD133X_COLOR_DEPTH_65K 0x1 + #define MAX_CONTRAST 255 =20 const struct ssd130x_deviceinfo ssd130x_variants[] =3D { @@ -618,17 +623,17 @@ static int ssd133x_set_contrast(struct ssd130x_device= *ssd130x, u32 brightness) static int ssd133x_init(struct ssd130x_device *ssd130x) { int ret; + /* + * Horizontal address increment, normal SA,SB,SC (e.g. RGB) sub-pixel + * order, COM split odd even and 65k (RGB565) color depth. + */ + u8 remap =3D SSD133X_SET_REMAP_COM_SPLIT | + FIELD_PREP(SSD133X_SET_REMAP_COLOR_DEPTH_MASK, SSD133X_COLOR_DEPTH_65= K); const u8 cmds[] =3D { 2, SSD133X_SET_MASTER_CURRENT, 0x06, 3, SSD133X_SET_COL_RANGE, 0x00, ssd130x->width - 1, 3, SSD133X_SET_ROW_RANGE, 0x00, ssd130x->height - 1, - /* - * Horizontal Address Increment - * Normal order SA,SB,SC (e.g. RGB) - * COM Split Odd Even - * 256 color format - */ - 2, SSD13XX_SET_SEG_REMAP, 0x20, + 2, SSD13XX_SET_SEG_REMAP, remap, 2, SSD133X_SET_DISPLAY_START, 0x00, 2, SSD133X_SET_DISPLAY_OFFSET, 0x00, 1, SSD133X_SET_DISPLAY_NORMAL, @@ -829,14 +834,20 @@ static int ssd133x_update_rect(struct ssd130x_device = *ssd130x, * COM0 to COM[N - 1] are the rows and SEG0 to SEG[M - 1] are * the columns. * - * Each Segment has a 8-bit pixel and each Common output has a - * row of pixels. When using the (default) horizontal address - * increment mode, each byte of data sent to the controller has - * a Segment (e.g: SEG0). + * Each Segment holds one pixel and each Common output has a row + * of pixels. A pixel is 8 bits (one byte) in the 256 color + * (RGB332) format or 16 bits (two bytes) in the 65k color + * (RGB565) format. When using the (default) horizontal address + * increment mode, the pixel data is sent Segment by Segment + * (e.g: SEG0 first). * * When using the 256 color depth format, each pixel contains 3 - * sub-pixels for color A, B and C. These have 3 bit, 3 bit and - * 2 bits respectively. + * sub-pixels for color A, B and C. These have 3, 3 and 2 bits + * respectively. + * + * When using the 65k color depth format, each pixel contains 3 + * sub-pixels for color A, B and C. These have 5, 6 and 5 bits + * respectively. */ =20 /* Set column start and end */ @@ -909,7 +920,7 @@ static void ssd132x_clear_screen(struct ssd130x_device = *ssd130x, u8 *data_array) =20 static void ssd133x_clear_screen(struct ssd130x_device *ssd130x, u8 *data_= array) { - const struct drm_format_info *fi =3D drm_format_info(DRM_FORMAT_RGB332); + const struct drm_format_info *fi =3D drm_format_info(DRM_FORMAT_RGB565); unsigned int pitch; =20 if (!fi) @@ -978,7 +989,7 @@ static int ssd133x_fb_blit_rect(struct drm_framebuffer = *fb, struct drm_format_conv_state *fmtcnv_state) { struct ssd130x_device *ssd130x =3D drm_to_ssd130x(fb->dev); - const struct drm_format_info *fi =3D drm_format_info(DRM_FORMAT_RGB332); + const struct drm_format_info *fi =3D drm_format_info(DRM_FORMAT_RGB565); unsigned int dst_pitch; struct iosys_map dst; =20 @@ -988,7 +999,7 @@ static int ssd133x_fb_blit_rect(struct drm_framebuffer = *fb, dst_pitch =3D drm_format_info_min_pitch(fi, 0, drm_rect_width(rect)); =20 iosys_map_set_vaddr(&dst, data_array); - drm_fb_xrgb8888_to_rgb332(&dst, &dst_pitch, vmap, fb, rect, fmtcnv_state); + drm_fb_xrgb8888_to_rgb565be(&dst, &dst_pitch, vmap, fb, rect, fmtcnv_stat= e); =20 ssd133x_update_rect(ssd130x, rect, data_array, dst_pitch); =20 @@ -1446,7 +1457,7 @@ static int ssd133x_crtc_atomic_check(struct drm_crtc = *crtc, struct ssd130x_device *ssd130x =3D drm_to_ssd130x(drm); struct drm_crtc_state *crtc_state =3D drm_atomic_get_new_crtc_state(state= , crtc); struct ssd130x_crtc_state *ssd130x_state =3D to_ssd130x_crtc_state(crtc_s= tate); - const struct drm_format_info *fi =3D drm_format_info(DRM_FORMAT_RGB332); + const struct drm_format_info *fi =3D drm_format_info(DRM_FORMAT_RGB565); unsigned int pitch; int ret; =20 --=20 2.55.0 From nobody Mon Sep 28 19:23:42 2026 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21F8E411F8D for ; Tue, 18 Aug 2026 08:06:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787040412; cv=none; b=GStGqcW4PQ1zn6nlKH122G1Kvt9lbUboTv3jSB+lf2c0fC4oY0n4g5rwqPcecE57jb/Dd4I3pMfzq4LOz1VdM8V4/jowSaDpG6SUsqpPV35sEXpH/VV+9MB6JQWrpKwfZUxJFqyHpWR7G95dqtoPtemwPQVxtjxPZ95AQ9CHofs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787040412; c=relaxed/simple; bh=B9c8jb9rQA3GFHFqTD8wK1YNQ2znwhPRYnqMXhDoVSI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=l5dr3ZpTRj3c57hNn9YvU7xzPVonvLd7jMVUeV+HizwqYPUBrP45h6A6SfCP2LFdkGcu3VWmUKFj/fDq29u3atIHtR4tubG6sLAETqOeDqUzPLkLlq4VwqdZ/NXeLWRb8LsnWevpu/oXMs+sOVb7YKKtdr9SGpx+ka6UTJg/mbM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aIFEYMFe; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aIFEYMFe" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-480033bdcf4so2588592f8f.2 for ; Tue, 18 Aug 2026 01:06:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787040407; x=1787645207; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FdfM282bTwDxgzUYhlGJdjRXvx9tdxayiYRVrgHSBtk=; b=aIFEYMFezsTBgoDo+eJMZrG3u/J6yZO5ByAwgY1Q9+XrdayyhnOCRIkcxyBOgoc+GL JiC93ky8awxv2i/CnHgAG9X8W+sZZ+ZoWTTInj0IHX2toAzlNBFe7zncW2MfdryLaRWc ILdwVns2IbMwmlNhDfvD4DRgfsZ/ug/Rh3Z0xsdpW/bEVxISnVjlxW4Qo597cPonMD8U pf0IKimWPJSqvc40T/rzJ0hL+tTPpDaCr1dKrFiBiHYvf6KiXv5CvKi3T4uJbC8J77sk TzdVGY7MAg+G5G7MZ72auJu4li39c03tZF7hr/68IBF2XKvR9q/nnoKa+6YF6Uueemda hgsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787040407; x=1787645207; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=FdfM282bTwDxgzUYhlGJdjRXvx9tdxayiYRVrgHSBtk=; b=J9OSHZMMyxB4MWwf5Hg7dwr9KGseyrQriEozn2E8kgTE/NQVKjr/VanvEsPIi1lydp KeQP/VuE4H75HVJGmlzLsALMqTyyl++yp/TSaV+0I804PIoe+5unYJExjxBNyvJZXXkl 0UVzidIRB365085P4LpbP3Ixpgg19zCf1rRl2bWf40FocQ3Y3xrMfFzC5Wor8pEt940d loRYT/ohpKyvqH2tzrvHbiSd+BThwa7gmFjH6iwW7i0Yiopz1r2BLe/H0smH12xuHPeG 0LPOl8EQT2VeCiYDMK7NSFFn4t99nnGdF79uwKZRUz/LhHbT/2Tk+rgLu3TGgh3OAdDU sesw== X-Forwarded-Encrypted: i=1; AHgh+RojzGyf92CWMFAtlFnzkg139r4Q+1NKH+OdEH2n5DOMIYL8U7QfB2/JVvM4cAyG80gUVwHatmFyCl3PDRI=@vger.kernel.org X-Gm-Message-State: AOJu0YzWC6lAzsUrSx13pgYsbHDI66wmW00qOmLZl7ZaEswsivX2hSAe +G6FzztYgU2xxSPhRuNSf/JoyRzQikAyqHM0MENuI1+dEsGsabbBqP9E X-Gm-Gg: AR+sD12HOXElzmNstmmK0e88k8USgKS4WzoGfVp/Ns4rTi+9dzHQ+HDrndueael/Jrz sZapYoGEQIl5i6wDFor/q6rpmzkiq1AZmELzI6UaCB5W+07sAqy4Gk19FhiX9LmAcctLpptuvbK mE3HzQAHR+YkhUkUVJnxM2cp4XkV+FJNc0uyQPIu5NwFrpQB0CEjFdxaMRIuPC4/8j2LYKQhTZA RSdDWCI6izQoeodYr9YPM0XCUSn7lwSGVF2BlyrSpxZVkiKsSBsiujlVWjddsmB2PzsBrXgiqNJ KOVG8QJ2rdYsJQbi4P93vWx4MvkFT8Z1w29kblZMO+u7bBKlQ7S4mQQ0QpZRYumCdnqcLWw5POG POXAM+dthEMobvtDuI/2vx0aZc/lWep23KnD/UnlQ941TKr7ryfzbXwnJ+1agH5BnO6j/ruWOiB VMLvCXCy/zNeMrfbXydLjN+1yTTr79DUDvvvV0g1TIOPQwv27hP6L/fF8TgfI6zLAbsm6IculOW JQ= X-Received: by 2002:a05:6000:41f7:b0:482:aa2a:52f6 with SMTP id ffacd0b85a97d-482aa2a5496mr7478849f8f.1.1787040407150; Tue, 18 Aug 2026 01:06:47 -0700 (PDT) Received: from anthony.local ([2a06:c701:9cc4:c200:33d8:8ea2:e077:ebe1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482a5a3b2e9sm10367223f8f.9.2026.08.18.01.06.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 01:06:46 -0700 (PDT) From: Amit Barzilai To: Javier Martinez Canillas , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Andy Shevchenko , Fabio Piparo , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Amit Barzilai Subject: [PATCH v4 3/6] drm/ssd130x: Constify ssd130x_write_data() 'values' parameter Date: Tue, 18 Aug 2026 11:06:23 +0300 Message-ID: <20260818080626.30430-4-amit.barzilai22@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260818080626.30430-1-amit.barzilai22@gmail.com> References: <20260818080626.30430-1-amit.barzilai22@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" At no point does ssd130x_write_data() change the bytes it receives via the 'values' parameter. Constify the parameter so const-qualified buffers pass through without casting away const. Signed-off-by: Amit Barzilai Reviewed-by: Javier Martinez Canillas Reviewed-by: Andy Shevchenko --- drivers/gpu/drm/solomon/ssd130x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ss= d130x.c index 1110aa63d066..a229d7a87da0 100644 --- a/drivers/gpu/drm/solomon/ssd130x.c +++ b/drivers/gpu/drm/solomon/ssd130x.c @@ -252,7 +252,7 @@ static inline struct ssd130x_device *drm_to_ssd130x(str= uct drm_device *drm) /* * Helper to write data (SSD13XX_DATA) to the device. */ -static int ssd130x_write_data(struct ssd130x_device *ssd130x, u8 *values, = int count) +static int ssd130x_write_data(struct ssd130x_device *ssd130x, const u8 *va= lues, int count) { return regmap_bulk_write(ssd130x->regmap, SSD13XX_DATA, values, count); } --=20 2.55.0 From nobody Mon Sep 28 19:23:42 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECED1413787 for ; Tue, 18 Aug 2026 08:06:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787040412; cv=none; b=dJ+0iUXHj9kTvvbdLIvAzFTibUL+nles3YuVyPlfVhSnk9tlbDuSKzXFKKHqVblvWR5jYs0Hwdwf+Prm62qCZOCuerkEMCVpmFDm6AzeD9+v08+DcSc8izeBHDcdLjTi+DaAKs4ZAbQHnUuvC5ESG2+ObRY6XapywobN38H9IAg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787040412; c=relaxed/simple; bh=4yQSsuP73a62lSM8d5JnIUkQGusOmnBrzoODOLgFF/U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KXEPWCUrglSmgY7HEeNqeVhSf6nEwO6iZqxTGmdwKdQAAGwuJhnjzLFUd1eGFsQWURbFC5VzEL5RZG7O/6RCrev711XW/ClmqnkhbqcakjuLPJD0E0jEu1otE73FodfHB47nMHrN5otVAwZatCqx6hwKXn2JeFkYwZBWSUbsmrg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rglWjo3L; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rglWjo3L" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4996f1ee4a4so35038825e9.2 for ; Tue, 18 Aug 2026 01:06:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787040409; x=1787645209; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hDobaOMuKjNNpK+xr0rXVpHpoQTLjSO4XFTBJQNN0Ug=; b=rglWjo3L5Zla2G2O6rOvsk+f3oZQANv5b2+YTLEmY0CKFqCeeqwMdhaZIcyOevr+zt jtMPxNmSTsjrAy080kzluZRbsGke7s8JK97yMCRIc5ZoYesNTMlJ4ETMLggxjZe0bkrQ BMvCQa/9ysy1RLOH1Xko+kUovIYuMDJpmWs5eMWlc4+YeVlMfgAfQ+SOJQXC7my6E//S yGMMU0b6C9f6PqaOPOaxJG7GNWHGZKqN5CmYM1maBl4XH844FkDqMdVJAcxbCC5Mqqro vIo2bafqQ0MnuDR9Y3rHfotZ1A/Pn+x/iIQ248ZBX8dPJOmABliR+dvVVqQm/6KIruMz bauA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787040409; x=1787645209; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=hDobaOMuKjNNpK+xr0rXVpHpoQTLjSO4XFTBJQNN0Ug=; b=kOG79qJE9xnPjqBK5V1mEG/+7wfI7SjhpcItpTswu+Z3+RjJkG/icRxiGyIUCQ4/lo gZ59BbB2NGQx1uEKOg3A4DogWmUwijrSOF3nn5IVT/7t8kaGjAoiwrH8yfpMj+86F8wN AY8b5ITWaAsT1W1QALO5KDyFqUKF8OXUP0Xvrjv8xQCnCFN8T5yd4F0G6W97VBPGI9lD NAppfejBGtNMkDggJO7RIFl3n8e0/vaVSivVwPngsL+UjjV1gUWSwfevjOw/pmlPOsxu wbjFHHt+bLjlp0aaUx21zRoFcC9cUlgnvoUVtmRNed0jQvGOPhkHV2Wc5lu1k5jGAl6B wPkA== X-Forwarded-Encrypted: i=1; AHgh+RruwaVCQPDVsxqlwTZm/4rqIWY+h8ETJKZ5MdqhMio/QjyH+cETPiLjIyhdrOz0qFBbFU/nMeBn4haed1A=@vger.kernel.org X-Gm-Message-State: AOJu0YywPsPfFhyqLPDk5H4Za+ZBnNC1AhIRw8Wi/DDH4Ypy2+N8oDpS qGbyNmDcgx/miZBzRCM+hV4Y8mrD3nIjK/GektP4UVn6Nk11yShvVRi6 X-Gm-Gg: AR+sD10P3Rrc5nF9+LkDMqVW9JOCNu/Z/iJKkJ92AtHMluh1XPBk/fMJHOfC7NlvW+M Y7D2WvZ1ReVfjfBIE7d8SwlShIbLxBeWcXd8QyGPUSMYGZpsGTEO+7Dt2RH1kLrF0CaJ3nTZLum vViOkZSu6PCHNcie3zjbmCMVb1KZa5z+ftpzRWC49aBqcsdNDD/OOtEq9fQEKbZSZi9EYyiicee XszZVnK71LVKacH4oQ1s6wLYyVKedNC5te17hkBsWR8xxfvtvL7PRjULqePrj0p1+0aS3SBmplB HN4o1I9uGhrGOCq/wCKCy2aN/RjEl5nvEtzl/rvTaFLfVKYZ9/Vy3m3wOrKMoztPmXH6yOaQJlq OMC2IA++ocL2m0TLbAwHq1XB+dddfjey7B6pHzA6WUqkiwBPEpVWYEQSIxXaKbr2GNm5O9DlHcq tWL7pOfKAUZIT+KecernDJlM5kBwjjPkchhEUzNDqJJqp/Qc/Gq8/Ms9PKDp9deGEIIh8J94nTy DQ= X-Received: by 2002:a05:6000:4a01:b0:47f:7b75:9dfe with SMTP id ffacd0b85a97d-482a9109c9bmr10864250f8f.8.1787040409063; Tue, 18 Aug 2026 01:06:49 -0700 (PDT) Received: from anthony.local ([2a06:c701:9cc4:c200:33d8:8ea2:e077:ebe1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482a5a3b2e9sm10367223f8f.9.2026.08.18.01.06.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 01:06:48 -0700 (PDT) From: Amit Barzilai To: Javier Martinez Canillas , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Andy Shevchenko , Fabio Piparo , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Amit Barzilai Subject: [PATCH v4 4/6] drm/ssd130x: Replace positional ssd130x_spi_id[] initialization with C99 Date: Tue, 18 Aug 2026 11:06:24 +0300 Message-ID: <20260818080626.30430-5-amit.barzilai22@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260818080626.30430-1-amit.barzilai22@gmail.com> References: <20260818080626.30430-1-amit.barzilai22@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ssd130x_spi_id[] is initialized with positional initializers, which easily create easy-to-miss bugs when changing the members of the target struct (struct spi_device_id in this example). Change this to C99 initializers to guarantee each member is initialized with the correct value. Signed-off-by: Amit Barzilai Reviewed-by: Andy Shevchenko --- drivers/gpu/drm/solomon/ssd130x-spi.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/solomon/ssd130x-spi.c b/drivers/gpu/drm/solomo= n/ssd130x-spi.c index b52f5fd592a1..be50e5aa2c87 100644 --- a/drivers/gpu/drm/solomon/ssd130x-spi.c +++ b/drivers/gpu/drm/solomon/ssd130x-spi.c @@ -160,17 +160,17 @@ MODULE_DEVICE_TABLE(of, ssd130x_of_match); */ static const struct spi_device_id ssd130x_spi_id[] =3D { /* ssd130x family */ - { "sh1106", SH1106_ID }, - { "ssd1305", SSD1305_ID }, - { "ssd1306", SSD1306_ID }, - { "ssd1307", SSD1307_ID }, - { "ssd1309", SSD1309_ID }, + { .name =3D "sh1106", .driver_data =3D SH1106_ID }, + { .name =3D "ssd1305", .driver_data =3D SSD1305_ID }, + { .name =3D "ssd1306", .driver_data =3D SSD1306_ID }, + { .name =3D "ssd1307", .driver_data =3D SSD1307_ID }, + { .name =3D "ssd1309", .driver_data =3D SSD1309_ID }, /* ssd132x family */ - { "ssd1322", SSD1322_ID }, - { "ssd1325", SSD1325_ID }, - { "ssd1327", SSD1327_ID }, + { .name =3D "ssd1322", .driver_data =3D SSD1322_ID }, + { .name =3D "ssd1325", .driver_data =3D SSD1325_ID }, + { .name =3D "ssd1327", .driver_data =3D SSD1327_ID }, /* ssd133x family */ - { "ssd1331", SSD1331_ID }, + { .name =3D "ssd1331", .driver_data =3D SSD1331_ID }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(spi, ssd130x_spi_id); --=20 2.55.0 From nobody Mon Sep 28 19:23:42 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC72F41A928 for ; Tue, 18 Aug 2026 08:06:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787040416; cv=none; b=ZP/TQ816GSAQGG3UV4LZCmu2Ae2IrnQjSY4O7vMVlyIHJGY2nRJVTDx5GpGD+TDdGddzljyRrXf1hCPe4C8ooROP8molI/TURu/hp3kwMWxKbSue1JHwzjDcJn8vbajP2JFW2lEAfvInd6xBwJ+oyecgxvD2gF3ObvvN9q9K1d4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787040416; c=relaxed/simple; bh=zoMfMXQWJIM3HEr/u2+8QjshJpYaJWozbvInBUqnoEA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j9HcHb1QQhL+lV3tKDqyk3ZPPdPf8YNVCIJF6iQqmWmHIgPOjf1jEefaHKj+OwZ2icRyI/XedCMJ6TvDt8soc6zmtgs5I8EjFM7T8h+a2RTLke4L9aGiAyloc8wPfiS8XRFvOetGV5FskIQHrA4ft2k9W3mZD0PTT1ceWhKsqIk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lacQmNx3; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lacQmNx3" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-480033bdcf4so2588650f8f.2 for ; Tue, 18 Aug 2026 01:06:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787040411; x=1787645211; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LmOA0dUy4iPUy3GXyYFTKqQUYL4L03dnOD0Ttu1y9OE=; b=lacQmNx3GTojMA0RRI9CuES6N/5og/1ZUJnfikLi5lHT1mLEEQ43iVvaaFd3ykxRMR S1FIUuOYEjiwFmAL2WLcTFcfzVReMK4P/eEdvsBOP0Hkq0fBsPZy15rf2Rwgr1Wk6SiX gX/PBNTQ3U73OFE1/eGw9AD16U54ZDlyEwru8q7DYFCnLQ8L22+DpqOjezv03m8BgjWB Wi/eQs8UNV9bWebRu4BU8NvMnvBKdu1D7Eum9RdUAf6TcTTycbfCOx2lCzhmNTXotzbu JBbuhupfbNyp01215hEgPpqTCcs0CmO+DV6W5qaifyafmjYHH+sJ6wG/qczfDsVqXjis oo4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787040411; x=1787645211; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=LmOA0dUy4iPUy3GXyYFTKqQUYL4L03dnOD0Ttu1y9OE=; b=GxbcTMkYCvbekTzqc0KOoB6SCdH01H0ro9cplg3k7mmXM1TOLeYm9b3BFQQEJPhXHa u3Q27ou9Ng8MMlNzF7Icsr42Plq5EvvmNB9PF1jg6vU+h61RKWnoWUqd9BzEkRr9G9jc zw08kNUylbcrXlicg9x8KDBcgJnPtJ4q8MKyEkB0iltWtzB5mjtrH93/4u8G86VW5w+q QGE6dSXLTweqAxjxLPQ6xxyq/xg3ySf4IY53bEObQhNfG92cT+eIkyOm3y3qf61EHLUN 48xQAHZnzIX8nS4aDcqw/Fa102ENB+KV7INE8BI0wi4S7i+KCOzc0xDgcjkTKW6qrO5V FYeg== X-Forwarded-Encrypted: i=1; AHgh+Rr+To0R8crxUMf3islxIJwiW/kvVYuRy9Mo4djgNvds5foGlKjRPxPGhyHtVvwbQ+U14+O7hBnnSPbMSh4=@vger.kernel.org X-Gm-Message-State: AOJu0YwjQbDHy3CRwU8yAhOLe/4r8IFdWTp7TNqC5KcyQooOFal+1JTu i1XULrceE5TPJhF8Tk8coXmuH5t2Pm/KtxUthR1BCcWq3FgJwCvucIBJ X-Gm-Gg: AR+sD12P50XjKhAOJVQ3e+DC27yGNcmxeHvK15ZFc/LjSPsMI+mF5irth6JG0k0ph4f 0haooBT6VlwdJSfNKDpHiCeuuJo/W4UNAfMlT0DMbUBcx0bwSILEYPmTZz+z/YLwoBwk3q5fCnR wrvdd8jOfSx2157r7Iyox1y997qQJvfd6DOIRQdBQE9MI+Vs+uxYahx01W+46USNoS+OXSeawQh HtvnrT6hmD8W1u6EvJMPfx85QvMwyRPv6Ds4TlZjmfE/xnXXOhRTHE9oj2S7RovQscfAOZbd4/x qlle52KgVZoDjnkq1YG8OB5EVf1Ds+yhYM/DN9ZfgcjhIw1eszoPS64JFFwXRhpVzKL1gz4h2/1 aMclxiU0v6mS9yQfDXf4ByZR0eTxMhBCX/qGkHxQQEtR/PdFtHct9fx3jqAV5hlmDDyQxJ2dF6C 9Y26uBmp+R8xtjCfARFy9/iu2iNkjD0pt94XBOwvw+3yrpjIbHQQdn5cQDkz/n X-Received: by 2002:adf:e18b:0:b0:481:568e:11b5 with SMTP id ffacd0b85a97d-4816070fc33mr53173391f8f.5.1787040410813; Tue, 18 Aug 2026 01:06:50 -0700 (PDT) Received: from anthony.local ([2a06:c701:9cc4:c200:33d8:8ea2:e077:ebe1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482a5a3b2e9sm10367223f8f.9.2026.08.18.01.06.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 01:06:50 -0700 (PDT) From: Amit Barzilai To: Javier Martinez Canillas , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Andy Shevchenko , Fabio Piparo , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Amit Barzilai Subject: [PATCH v4 5/6] drm/ssd130x: Implement ssd130x_write_cmd() on top of ssd130x_write_cmds() Date: Tue, 18 Aug 2026 11:06:25 +0300 Message-ID: <20260818080626.30430-6-amit.barzilai22@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260818080626.30430-1-amit.barzilai22@gmail.com> References: <20260818080626.30430-1-amit.barzilai22@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ssd130x_write_cmd() and ssd130x_write_cmds() each carried their own regmap_write() loop over SSD13XX_COMMAND, differing only in how the caller supplies the bytes. Turn ssd130x_write_cmd() into a thin variadic wrapper that collects its arguments into a small stack buffer and defers to ssd130x_write_cmds(), and move the protocol comment onto the latter, which is where the loop now lives. No functional change: the bytes sent and the bus transactions used to send them are identical for every chip on both the I2C and SPI transports. Assisted-by: Claude:claude-opus-5 Signed-off-by: Amit Barzilai --- drivers/gpu/drm/solomon/ssd130x.c | 65 +++++++++++++++---------------- 1 file changed, 31 insertions(+), 34 deletions(-) diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ss= d130x.c index a229d7a87da0..61187a630a0d 100644 --- a/drivers/gpu/drm/solomon/ssd130x.c +++ b/drivers/gpu/drm/solomon/ssd130x.c @@ -258,41 +258,12 @@ static int ssd130x_write_data(struct ssd130x_device *= ssd130x, const u8 *values, } =20 /* - * Helper to write command (SSD13XX_COMMAND). The fist variadic argument - * is the command to write and the following are the command options. + * Helper to write a command (SSD13XX_COMMAND) from a buffer. The first by= te + * is the command opcode and the following ones are its parameters. * - * Note that the ssd13xx protocol requires each command and option to be - * written as a SSD13XX_COMMAND device register value. That is why a call - * to regmap_write(..., SSD13XX_COMMAND, ...) is done for each argument. - */ -static int ssd130x_write_cmd(struct ssd130x_device *ssd130x, int count, - /* u8 cmd, u8 option, ... */...) -{ - va_list ap; - u8 value; - int ret; - - va_start(ap, count); - - do { - value =3D va_arg(ap, int); - ret =3D regmap_write(ssd130x->regmap, SSD13XX_COMMAND, value); - if (ret) - goto out_end; - } while (--count); - -out_end: - va_end(ap); - - return ret; -} - -/* - * Write a command byte sequence from a buffer. - * - * Like ssd130x_write_cmd() but takes a pre-built byte array instead of - * variadic arguments, handy when the command is already in an array or - * when the caller wants to use sizeof() for the length. + * Note that the ssd13xx protocol requires the opcode and each parameter to + * be written as a SSD13XX_COMMAND device register value. That is why a ca= ll + * to regmap_write(..., SSD13XX_COMMAND, ...) is done for each byte. */ static int ssd130x_write_cmds(struct ssd130x_device *ssd130x, const u8 *cm= d, size_t len) @@ -309,6 +280,32 @@ static int ssd130x_write_cmds(struct ssd130x_device *s= sd130x, const u8 *cmd, return 0; } =20 +/* + * Variadic wrapper around ssd130x_write_cmds(). The first variadic argume= nt + * is the command opcode and the following are its parameters. + * + * The arguments are gathered into a fixed size buffer, so at most 8 bytes + * can be sent per call, i.e. an opcode and seven parameters. That covers + * every command this driver sends through it. Commands taking more parame= ters, + * such as the grey scale tables, must use ssd130x_write_cmds() instead. + */ +static int ssd130x_write_cmd(struct ssd130x_device *ssd130x, int count, + /* u8 cmd, u8 param, ... */...) +{ + u8 buf[8]; + va_list ap; + + if (drm_WARN_ON(&ssd130x->drm, count > ARRAY_SIZE(buf))) + return -EINVAL; + + va_start(ap, count); + for (int i =3D 0; i < count; i++) + buf[i] =3D va_arg(ap, int); + va_end(ap); + + return ssd130x_write_cmds(ssd130x, buf, count); +} + /* * Run a packed command sequence. The format is a flat byte array where e= ach * entry starts with a length byte followed by that many command bytes. A --=20 2.55.0 From nobody Mon Sep 28 19:23:42 2026 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFF3641A781 for ; Tue, 18 Aug 2026 08:06:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787040419; cv=none; b=I+9ClNPh5LrfSQ5dvXUHvfNA+Y2sUMGjLdC5WhZEos6l+EvYtip3NA8GbyMxiHOErX7dxNNgP/UrhYXKsopawg4hxzdTCDY/XQoSvUl71C8CCV1mQZZiBNuXQhpol2V0rgeyMeT79ZabU2h+Zt0ZgtvAD0bZ+tA0kb8oKmCiQcE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787040419; c=relaxed/simple; bh=HT4P9iGTVCZ2p4ImtmiQ0X+zf9BM8Aor7wcgVsTXeFs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sOK311PzJZ609VUpRrhY6OzsfOeScpgLn9y11/m4kvuAbZeYHF8A2sOV3r9nj3OjLjgNWh3p7n+yHhbM8fkuhQXnonOnZhiWS/jKsnSf31FgbHpf3s2XCdk+oBJ9FR9w7AbX7X1aR7ZZfAC6DOusLRuI9BHs+yXCIbAcmEVqATo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=S5iSObe1; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S5iSObe1" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4998b5a63e2so36601055e9.1 for ; Tue, 18 Aug 2026 01:06:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787040413; x=1787645213; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=B2fVEcJvgOMMHDfgHu6eikQjPaW5FYExfbHusAlmMxs=; b=S5iSObe1W99UnvGcsHqPsp8fhDm0SzQf9UwE/43Yg/GEJGrH5Wy/HJp9SA28xbUqzP Oc1CRI2ypGFYiB7fUW0xKRzbkjXMrNg4tG/i39WceZXXGrdlYBzWQuyyBZyL1FyAmkS+ kxpB2j4LQAI/q77Y4vsXi02cac5I+OuV1KfZKEc/tSnHS2bGYI57f4xkIOkXPrqdwZB0 50U0+V0uBtkzySgj9FPLnncWyImjHVRX92Mzj9UVktXNxGraf9MA/Ba5mJ5+KbvaMQIc MImN3QSuojOk7jKUpMYzB1E1DGANGs4DR2IKe4nMPgU6AjVTNULydOd3neBd5ZTucGNh 8bUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787040413; x=1787645213; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=B2fVEcJvgOMMHDfgHu6eikQjPaW5FYExfbHusAlmMxs=; b=WuVc55HiBVDgxll9NPvIGuj/jbwuqSz/veIyTMWrkHuXvSFzIuVp1KZ1138WwtD111 4RdXMJ6U2RABCcAyaNCadhn/e2xY8jbwPBvD9VcyJd8ijDgV+GhK9U/+Btg/M86gOAPg WtfXOh/iLHQohn4f/qtLeDEb1u7fzt61HfKX7SJ599zyc17ZaztTECxCgf3vdu3WANu7 fv64Tfclh6Xnr5ZTkTCtVjZJbuA/2a9jkG6oHDYYbYBDtnT82QLIWjWHt4vSpXHzqwIC MOR64RT50KRHCcV/eTfTlsh2G1E0+1cvoFPjQk9X0+0QiLfdMOuwtVNadepxhrwoGLwg Dgjw== X-Forwarded-Encrypted: i=1; AHgh+RrYlsRyihOl1AUqMo7kqK8nB+WtMDY6ICaytcHwLKxP21rD821JCpv2PMv40s5SbR0uniEZVXfXd8qS7yI=@vger.kernel.org X-Gm-Message-State: AOJu0YxC2md2j7Wbv5iLbzjJPUBbxqMl9kcCLTpGzVy0froHvgtOQv7V QrlI2W8W0EbSZC9bVoG2WrNE9XPSQnQBSWjFq+aMHIn2yz+RwDd8+PKp X-Gm-Gg: AR+sD11Meeax1Y/sLSWLqnz7lCZlsrxCs4A6ON2uGPDIePiFatTuJ7SotiFN5Di0vmW ewWZcOM80WGyTH8dzPsPWZa4Nl+YK+9vgstYUHeI/++0Byj+oRGP93khr9x1paiDG6fqN0GM5O4 y0xtBJR4Abl0Ldx+b/Gayx/Kh7D80v1LIYR149t8flVXO4Dr76/RXQyAe8LYC2tUA+x4UHukbNk Q+hvlZMhXrGpBK0QQ1hWaH24Ew0al0XRxwdqUvJ8y3lR6+NOROu3NVoRPbaUdOJnHic2uyRFqcj mA8BzkDuw/WoYJsCmhZu5y/TSdHcjTZL2SuC2sBQmCz+A/OSiJGBNeMl/AZzgRCQ9ykxv9Zsr/0 Fa+M4V7gWFC+4IhyxzDfclwbIaM0xEdH+Yrt806ZE5orFi+HFLgSb/LmWBrNvD4KgerS4JUwUsL NH0dHLutFCAS8k2tSAa7UOGA8DTDcHZ6E3RmIaoXZ2OtkwKvryIrNWbJz80580eCAow1Kv5Oxpo iw= X-Received: by 2002:a05:600d:8489:20b0:499:8b13:3a98 with SMTP id 5b1f17b1804b1-4998b133b3dmr307330665e9.4.1787040412707; Tue, 18 Aug 2026 01:06:52 -0700 (PDT) Received: from anthony.local ([2a06:c701:9cc4:c200:33d8:8ea2:e077:ebe1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482a5a3b2e9sm10367223f8f.9.2026.08.18.01.06.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 01:06:52 -0700 (PDT) From: Amit Barzilai To: Javier Martinez Canillas , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Andy Shevchenko , Fabio Piparo , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Amit Barzilai Subject: [PATCH v4 6/6] drm/ssd130x: Add SSD135X_FAMILY and SSD1351 support Date: Tue, 18 Aug 2026 11:06:26 +0300 Message-ID: <20260818080626.30430-7-amit.barzilai22@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260818080626.30430-1-amit.barzilai22@gmail.com> References: <20260818080626.30430-1-amit.barzilai22@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Solomon SSD1351 is a 128x128 RGB color OLED controller. It shares the SSD133X pixel layout: one 65k color (RGB565) pixel per Segment, written as a bulk transfer once a column/row addressing window has been programmed. Add it as a new SSD135X_FAMILY rather than as a separate driver, so that the ssd130x plane, CRTC and encoder infrastructure is reused. Give the family its own primary plane update and disable, encoder enable and backlight callbacks instead of teaching the ssd133x ones about a second family. Only the callbacks that carry no family specific logic are reused as is: ssd133x_primary_plane_atomic_check(), ssd133x_crtc_atomic_check() and ssd130x_encoder_atomic_disable(). The data path differs from the ssd133x family in one respect. The SSD1351 only starts accepting pixel data after an explicit Write RAM command (0x5c), while the SSD133X enters data mode as soon as the address window has been programmed. Emit it from ssd135x_update_rect(), which both the damage update and the clear screen paths go through. SSD1351 differs from previous controllers in the command protocol. While the opcode is still sent on the command path, the parameters are sent on the data path. Introduce the cmd_params_are_data flag to struct ssd130x_deviceinfo and let ssd130x_write_cmds() split the buffer in accordance to the device specifications. The SSD1351 also needs its own init sequence (ssd135x_init). The remap byte is fixed at horizontal address increment, COM split, reversed COM scan direction, BGR sub-pixel order and 65k color depth; rotation is not supported. Contrast is calibrated per color channel as for the ssd133x family, but the three channels are parameters of a single command (0xc1) instead of one command per channel. Add ssd135x_set_contrast() for that and use it from both the init and the backlight update paths. The SSD1351 is SPI-only, so only the SPI transport match tables gain an entry; no new config symbol is needed. Assisted-by: Claude:claude-opus-5 Signed-off-by: Amit Barzilai --- drivers/gpu/drm/solomon/ssd130x-spi.c | 7 + drivers/gpu/drm/solomon/ssd130x.c | 308 +++++++++++++++++++++++++- drivers/gpu/drm/solomon/ssd130x.h | 10 +- 3 files changed, 318 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/solomon/ssd130x-spi.c b/drivers/gpu/drm/solomo= n/ssd130x-spi.c index be50e5aa2c87..c41064aa8221 100644 --- a/drivers/gpu/drm/solomon/ssd130x-spi.c +++ b/drivers/gpu/drm/solomon/ssd130x-spi.c @@ -146,6 +146,11 @@ static const struct of_device_id ssd130x_of_match[] = =3D { .compatible =3D "solomon,ssd1331", .data =3D &ssd130x_variants[SSD1331_ID], }, + /* ssd135x family */ + { + .compatible =3D "solomon,ssd1351", + .data =3D &ssd130x_variants[SSD1351_ID], + }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(of, ssd130x_of_match); @@ -171,6 +176,8 @@ static const struct spi_device_id ssd130x_spi_id[] =3D { { .name =3D "ssd1327", .driver_data =3D SSD1327_ID }, /* ssd133x family */ { .name =3D "ssd1331", .driver_data =3D SSD1331_ID }, + /* ssd135x family */ + { .name =3D "ssd1351", .driver_data =3D SSD1351_ID }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(spi, ssd130x_spi_id); diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ss= d130x.c index 61187a630a0d..af1f8e21f159 100644 --- a/drivers/gpu/drm/solomon/ssd130x.c +++ b/drivers/gpu/drm/solomon/ssd130x.c @@ -151,6 +151,37 @@ #define SSD133X_SET_REMAP_COLOR_DEPTH_MASK GENMASK(7, 6) #define SSD133X_COLOR_DEPTH_65K 0x1 =20 +/* ssd135x commands */ +#define SSD135X_SET_COL_RANGE 0x15 +#define SSD135X_WRITE_RAM 0x5c +#define SSD135X_SET_ROW_RANGE 0x75 +#define SSD135X_SET_DISPLAY_START 0xa1 +#define SSD135X_SET_DISPLAY_OFFSET 0xa2 +#define SSD135X_SET_DISPLAY_NORMAL 0xa6 +#define SSD135X_SET_FUNCTION 0xab +#define SSD135X_SET_PHASE_LENGTH 0xb1 +#define SSD135X_SET_CLOCK_FREQ 0xb3 +#define SSD135X_SET_VSL 0xb4 +#define SSD135X_SET_GPIO 0xb5 +#define SSD135X_SET_PRECHARGE2 0xb6 +#define SSD135X_SET_PRECHARGE_VOLTAGE 0xbb +#define SSD135X_SET_VCOMH_VOLTAGE 0xbe +#define SSD135X_SET_CONTRAST 0xc1 +#define SSD135X_SET_CONTRAST_MASTER 0xc7 +#define SSD135X_SET_MUX_RATIO 0xca +#define SSD135X_SET_COMMAND_LOCK 0xfd + +/* ssd135x A/B/C channel contrast at full brightness (white balance) */ +#define SSD135X_DEFAULT_CONTRAST_A 0xc8 +#define SSD135X_DEFAULT_CONTRAST_B 0x80 +#define SSD135X_DEFAULT_CONTRAST_C 0xc8 + +/* ssd135x remap byte (data of SSD13XX_SET_SEG_REMAP) */ +#define SSD135X_SET_REMAP_COLOR_BGR BIT(2) +#define SSD135X_SET_REMAP_COM_SCAN BIT(4) +#define SSD135X_SET_REMAP_COM_SPLIT BIT(5) +#define SSD135X_SET_REMAP_65K BIT(6) + #define MAX_CONTRAST 255 =20 const struct ssd130x_deviceinfo ssd130x_variants[] =3D { @@ -218,7 +249,14 @@ const struct ssd130x_deviceinfo ssd130x_variants[] =3D= { .default_width =3D 96, .default_height =3D 64, .family_id =3D SSD133X_FAMILY, - } + }, + /* ssd135x family */ + [SSD1351_ID] =3D { + .default_width =3D 128, + .default_height =3D 128, + .family_id =3D SSD135X_FAMILY, + .cmd_params_are_data =3D true, + }, }; EXPORT_SYMBOL_NS_GPL(ssd130x_variants, "DRM_SSD130X"); =20 @@ -261,9 +299,10 @@ static int ssd130x_write_data(struct ssd130x_device *s= sd130x, const u8 *values, * Helper to write a command (SSD13XX_COMMAND) from a buffer. The first by= te * is the command opcode and the following ones are its parameters. * - * Note that the ssd13xx protocol requires the opcode and each parameter to - * be written as a SSD13XX_COMMAND device register value. That is why a ca= ll - * to regmap_write(..., SSD13XX_COMMAND, ...) is done for each byte. + * By default every byte is written as a SSD13XX_COMMAND register value, h= ence + * the regmap_write() per byte. Controllers that set cmd_params_are_data e= xpect + * the parameters on the data path instead, so only the opcode is written = as + * SSD13XX_COMMAND and the rest as SSD13XX_DATA. */ static int ssd130x_write_cmds(struct ssd130x_device *ssd130x, const u8 *cm= d, size_t len) @@ -271,6 +310,17 @@ static int ssd130x_write_cmds(struct ssd130x_device *s= sd130x, const u8 *cmd, unsigned int i; int ret; =20 + if (ssd130x->device_info->cmd_params_are_data) { + if (!len) + return 0; + + ret =3D regmap_write(ssd130x->regmap, SSD13XX_COMMAND, cmd[0]); + if (ret || len =3D=3D 1) + return ret; + + return ssd130x_write_data(ssd130x, cmd + 1, len - 1); + } + for (i =3D 0; i < len; i++) { ret =3D regmap_write(ssd130x->regmap, SSD13XX_COMMAND, cmd[i]); if (ret) @@ -617,6 +667,20 @@ static int ssd133x_set_contrast(struct ssd130x_device = *ssd130x, u32 brightness) return ssd130x_run_cmd_seq(ssd130x, cmds); } =20 +/* + * Same white balance calibration as for the ssd133x family, except that t= he + * ssd135x controllers take the three channels as parameters of a single + * command instead of one command per channel. + */ +static int ssd135x_set_contrast(struct ssd130x_device *ssd130x, u32 bright= ness) +{ + u8 a =3D ssd130x_scale_contrast(SSD135X_DEFAULT_CONTRAST_A, brightness); + u8 b =3D ssd130x_scale_contrast(SSD135X_DEFAULT_CONTRAST_B, brightness); + u8 c =3D ssd130x_scale_contrast(SSD135X_DEFAULT_CONTRAST_C, brightness); + + return ssd130x_write_cmd(ssd130x, 4, SSD135X_SET_CONTRAST, a, b, c); +} + static int ssd133x_init(struct ssd130x_device *ssd130x) { int ret; @@ -654,6 +718,47 @@ static int ssd133x_init(struct ssd130x_device *ssd130x) return ssd130x_run_cmd_seq(ssd130x, cmds); } =20 +static int ssd135x_init(struct ssd130x_device *ssd130x) +{ + /* + * Horizontal address increment, COM split, reversed COM scan direction, + * BGR sub-pixel order and 65k (RGB565) color depth. Rotation is not + * supported, so the remap byte is fixed. + */ + u8 remap =3D SSD135X_SET_REMAP_65K | SSD135X_SET_REMAP_COM_SPLIT | + SSD135X_SET_REMAP_COLOR_BGR | SSD135X_SET_REMAP_COM_SCAN; + int ret; + const u8 cmds[] =3D { + /* Unlock the controller, then the extended command set */ + 2, SSD135X_SET_COMMAND_LOCK, 0x12, + 2, SSD135X_SET_COMMAND_LOCK, 0xb1, + 1, SSD13XX_DISPLAY_OFF, + 2, SSD135X_SET_CLOCK_FREQ, 0xf1, + 2, SSD135X_SET_MUX_RATIO, ssd130x->height - 1, + 3, SSD135X_SET_COL_RANGE, 0x00, ssd130x->width - 1, + 3, SSD135X_SET_ROW_RANGE, 0x00, ssd130x->height - 1, + 2, SSD135X_SET_DISPLAY_START, 0x00, + 2, SSD135X_SET_DISPLAY_OFFSET, 0x00, + 2, SSD135X_SET_GPIO, 0x00, + 2, SSD135X_SET_FUNCTION, 0x01, + 2, SSD135X_SET_PHASE_LENGTH, 0x32, + 4, SSD135X_SET_VSL, 0xa0, 0xb5, 0x55, + 2, SSD135X_SET_PRECHARGE_VOLTAGE, 0x17, + 2, SSD135X_SET_VCOMH_VOLTAGE, 0x05, + 2, SSD135X_SET_CONTRAST_MASTER, 0x0f, + 2, SSD135X_SET_PRECHARGE2, 0x01, + 1, SSD135X_SET_DISPLAY_NORMAL, + 2, SSD13XX_SET_SEG_REMAP, remap, + 0, + }; + + ret =3D ssd130x_run_cmd_seq(ssd130x, cmds); + if (ret < 0) + return ret; + + return ssd135x_set_contrast(ssd130x, ssd130x->contrast); +} + static int ssd130x_update_rect(struct ssd130x_device *ssd130x, struct drm_rect *rect, u8 *buf, u8 *data_array) @@ -863,6 +968,44 @@ static int ssd133x_update_rect(struct ssd130x_device *= ssd130x, return ret; } =20 +static int ssd135x_update_rect(struct ssd130x_device *ssd130x, + struct drm_rect *rect, u8 *data_array, + unsigned int pitch) +{ + unsigned int x =3D rect->x1; + unsigned int y =3D rect->y1; + unsigned int columns =3D drm_rect_width(rect); + unsigned int rows =3D drm_rect_height(rect); + int ret; + + /* + * The pixel layout is the same as for the ssd133x family: one 65k + * color (RGB565) pixel per Segment, sent Segment by Segment when the + * (default) horizontal address increment mode is used. + * + * But unlike the ssd133x family, which starts accepting pixel data as + * soon as the address window has been programmed, the ssd135x family + * needs an explicit Write RAM command before the data is written. + */ + + /* Set column start and end */ + ret =3D ssd130x_write_cmd(ssd130x, 3, SSD135X_SET_COL_RANGE, x, x + colum= ns - 1); + if (ret < 0) + return ret; + + /* Set row start and end */ + ret =3D ssd130x_write_cmd(ssd130x, 3, SSD135X_SET_ROW_RANGE, y, y + rows = - 1); + if (ret < 0) + return ret; + + ret =3D ssd130x_write_cmd(ssd130x, 1, SSD135X_WRITE_RAM); + if (ret < 0) + return ret; + + /* Write out update in one go since horizontal addressing mode is used */ + return ssd130x_write_data(ssd130x, data_array, pitch * rows); +} + static void ssd130x_clear_screen(struct ssd130x_device *ssd130x, u8 *data_= array) { unsigned int pages =3D DIV_ROUND_UP(ssd130x->height, SSD130X_PAGE_HEIGHT); @@ -931,6 +1074,22 @@ static void ssd133x_clear_screen(struct ssd130x_devic= e *ssd130x, u8 *data_array) ssd130x_write_data(ssd130x, data_array, pitch * ssd130x->height); } =20 +static void ssd135x_clear_screen(struct ssd130x_device *ssd130x, u8 *data_= array) +{ + struct drm_rect screen =3D DRM_RECT_INIT(0, 0, ssd130x->width, ssd130x->h= eight); + const struct drm_format_info *fi =3D drm_format_info(DRM_FORMAT_RGB565); + unsigned int pitch; + + if (!fi) + return; + + pitch =3D drm_format_info_min_pitch(fi, 0, ssd130x->width); + + memset(data_array, 0, pitch * ssd130x->height); + + ssd135x_update_rect(ssd130x, &screen, data_array, pitch); +} + static int ssd130x_fb_blit_rect(struct drm_framebuffer *fb, const struct iosys_map *vmap, struct drm_rect *rect, @@ -1003,6 +1162,29 @@ static int ssd133x_fb_blit_rect(struct drm_framebuff= er *fb, return 0; } =20 +static int ssd135x_fb_blit_rect(struct drm_framebuffer *fb, + const struct iosys_map *vmap, + struct drm_rect *rect, u8 *data_array, + struct drm_format_conv_state *fmtcnv_state) +{ + struct ssd130x_device *ssd130x =3D drm_to_ssd130x(fb->dev); + const struct drm_format_info *fi =3D drm_format_info(DRM_FORMAT_RGB565); + unsigned int dst_pitch; + struct iosys_map dst; + + if (!fi) + return -EINVAL; + + dst_pitch =3D drm_format_info_min_pitch(fi, 0, drm_rect_width(rect)); + + iosys_map_set_vaddr(&dst, data_array); + drm_fb_xrgb8888_to_rgb565be(&dst, &dst_pitch, vmap, fb, rect, fmtcnv_stat= e); + + ssd135x_update_rect(ssd130x, rect, data_array, dst_pitch); + + return 0; +} + static int ssd130x_primary_plane_atomic_check(struct drm_plane *plane, struct drm_atomic_commit *state) { @@ -1245,6 +1427,45 @@ static void ssd133x_primary_plane_atomic_update(stru= ct drm_plane *plane, drm_dev_exit(idx); } =20 +static void ssd135x_primary_plane_atomic_update(struct drm_plane *plane, + struct drm_atomic_commit *state) +{ + struct drm_plane_state *plane_state =3D drm_atomic_get_new_plane_state(st= ate, plane); + struct drm_plane_state *old_plane_state =3D drm_atomic_get_old_plane_stat= e(state, plane); + struct drm_shadow_plane_state *shadow_plane_state =3D to_drm_shadow_plane= _state(plane_state); + struct drm_crtc_state *crtc_state =3D drm_atomic_get_new_crtc_state(state= , plane_state->crtc); + struct ssd130x_crtc_state *ssd130x_crtc_state =3D to_ssd130x_crtc_state(= crtc_state); + struct drm_framebuffer *fb =3D plane_state->fb; + struct drm_atomic_helper_damage_iter iter; + struct drm_device *drm =3D plane->dev; + struct drm_rect dst_clip; + struct drm_rect damage; + int idx; + + if (!drm_dev_enter(drm, &idx)) + return; + + if (drm_gem_fb_begin_cpu_access(fb, DMA_FROM_DEVICE)) + goto out_drm_dev_exit; + + drm_atomic_helper_damage_iter_init(&iter, old_plane_state, plane_state); + drm_atomic_for_each_plane_damage(&iter, &damage) { + dst_clip =3D plane_state->dst; + + if (!drm_rect_intersect(&dst_clip, &damage)) + continue; + + ssd135x_fb_blit_rect(fb, &shadow_plane_state->data[0], &dst_clip, + ssd130x_crtc_state->data_array, + &shadow_plane_state->fmtcnv_state); + } + + drm_gem_fb_end_cpu_access(fb, DMA_FROM_DEVICE); + +out_drm_dev_exit: + drm_dev_exit(idx); +} + static void ssd130x_primary_plane_atomic_disable(struct drm_plane *plane, struct drm_atomic_commit *state) { @@ -1317,6 +1538,30 @@ static void ssd133x_primary_plane_atomic_disable(str= uct drm_plane *plane, drm_dev_exit(idx); } =20 +static void ssd135x_primary_plane_atomic_disable(struct drm_plane *plane, + struct drm_atomic_commit *state) +{ + struct drm_device *drm =3D plane->dev; + struct ssd130x_device *ssd130x =3D drm_to_ssd130x(drm); + struct drm_plane_state *plane_state =3D drm_atomic_get_new_plane_state(st= ate, plane); + struct drm_crtc_state *crtc_state; + struct ssd130x_crtc_state *ssd130x_crtc_state; + int idx; + + if (!plane_state->crtc) + return; + + crtc_state =3D drm_atomic_get_new_crtc_state(state, plane_state->crtc); + ssd130x_crtc_state =3D to_ssd130x_crtc_state(crtc_state); + + if (!drm_dev_enter(drm, &idx)) + return; + + ssd135x_clear_screen(ssd130x, ssd130x_crtc_state->data_array); + + drm_dev_exit(idx); +} + /* Called during init to allocate the plane's atomic state. */ static void ssd130x_primary_plane_reset(struct drm_plane *plane) { @@ -1385,7 +1630,13 @@ static const struct drm_plane_helper_funcs ssd130x_p= rimary_plane_helper_funcs[] .atomic_check =3D ssd133x_primary_plane_atomic_check, .atomic_update =3D ssd133x_primary_plane_atomic_update, .atomic_disable =3D ssd133x_primary_plane_atomic_disable, - } + }, + [SSD135X_FAMILY] =3D { + DRM_GEM_SHADOW_PLANE_HELPER_FUNCS, + .atomic_check =3D ssd133x_primary_plane_atomic_check, + .atomic_update =3D ssd135x_primary_plane_atomic_update, + .atomic_disable =3D ssd135x_primary_plane_atomic_disable, + }, }; =20 static const struct drm_plane_funcs ssd130x_primary_plane_funcs =3D { @@ -1539,6 +1790,10 @@ static const struct drm_crtc_helper_funcs ssd130x_cr= tc_helper_funcs[] =3D { .mode_valid =3D ssd130x_crtc_mode_valid, .atomic_check =3D ssd133x_crtc_atomic_check, }, + [SSD135X_FAMILY] =3D { + .mode_valid =3D ssd130x_crtc_mode_valid, + .atomic_check =3D ssd133x_crtc_atomic_check, + }, }; =20 static const struct drm_crtc_funcs ssd130x_crtc_funcs =3D { @@ -1626,6 +1881,31 @@ static void ssd133x_encoder_atomic_enable(struct drm= _encoder *encoder, ssd130x_power_off(ssd130x); } =20 +static void ssd135x_encoder_atomic_enable(struct drm_encoder *encoder, + struct drm_atomic_commit *state) +{ + struct drm_device *drm =3D encoder->dev; + struct ssd130x_device *ssd130x =3D drm_to_ssd130x(drm); + int ret; + + ret =3D ssd130x_power_on(ssd130x); + if (ret) + return; + + ret =3D ssd135x_init(ssd130x); + if (ret) + goto power_off; + + ssd130x_write_cmd(ssd130x, 1, SSD13XX_DISPLAY_ON); + + backlight_enable(ssd130x->bl_dev); + + return; + +power_off: + ssd130x_power_off(ssd130x); +} + static void ssd130x_encoder_atomic_disable(struct drm_encoder *encoder, struct drm_atomic_commit *state) { @@ -1651,7 +1931,11 @@ static const struct drm_encoder_helper_funcs ssd130x= _encoder_helper_funcs[] =3D { [SSD133X_FAMILY] =3D { .atomic_enable =3D ssd133x_encoder_atomic_enable, .atomic_disable =3D ssd130x_encoder_atomic_disable, - } + }, + [SSD135X_FAMILY] =3D { + .atomic_enable =3D ssd135x_encoder_atomic_enable, + .atomic_disable =3D ssd130x_encoder_atomic_disable, + }, }; =20 static const struct drm_encoder_funcs ssd130x_encoder_funcs =3D { @@ -1728,6 +2012,15 @@ static int ssd133x_update_bl(struct backlight_device= *bdev) return ssd133x_set_contrast(ssd130x, ssd130x->contrast); } =20 +static int ssd135x_update_bl(struct backlight_device *bdev) +{ + struct ssd130x_device *ssd130x =3D bl_get_data(bdev); + + ssd130x->contrast =3D backlight_get_brightness(bdev); + + return ssd135x_set_contrast(ssd130x, ssd130x->contrast); +} + static const struct backlight_ops ssd130xfb_bl_ops[] =3D { [SSD130X_FAMILY] =3D { .update_status =3D ssd130x_update_bl, @@ -1738,6 +2031,9 @@ static const struct backlight_ops ssd130xfb_bl_ops[] = =3D { [SSD133X_FAMILY] =3D { .update_status =3D ssd133x_update_bl, }, + [SSD135X_FAMILY] =3D { + .update_status =3D ssd135x_update_bl, + }, }; =20 static void ssd130x_parse_properties(struct ssd130x_device *ssd130x) diff --git a/drivers/gpu/drm/solomon/ssd130x.h b/drivers/gpu/drm/solomon/ss= d130x.h index a4554018bb2a..fd81262f2ceb 100644 --- a/drivers/gpu/drm/solomon/ssd130x.h +++ b/drivers/gpu/drm/solomon/ssd130x.h @@ -26,7 +26,8 @@ enum ssd130x_family_ids { SSD130X_FAMILY, SSD132X_FAMILY, - SSD133X_FAMILY + SSD133X_FAMILY, + SSD135X_FAMILY, }; =20 enum ssd130x_variants { @@ -42,6 +43,8 @@ enum ssd130x_variants { SSD1327_ID, /* ssd133x family */ SSD1331_ID, + /* ssd135x family */ + SSD1351_ID, NR_SSD130X_VARIANTS }; =20 @@ -54,6 +57,11 @@ struct ssd130x_deviceinfo { bool need_pwm; bool need_chargepump; bool page_mode_only; + /* + * Whether the controller takes a command's parameters on the data path + * instead of as further command bytes. + */ + bool cmd_params_are_data; =20 enum ssd130x_family_ids family_id; }; --=20 2.55.0