From nobody Mon Sep 28 20:07:43 2026 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F125D2F8E86 for ; Tue, 18 Aug 2026 07:28:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787038093; cv=none; b=D9Q4MjcC5Rp9qxo9Fcz0JZjPqAUkWFgmNtiGZaqIiooZL9Mkatsqhm9BUTdsNeJ1j+G6LkP1H0ksPs2o+1vluEozwTF7rrqG3hEjqscne26vfa80pyXo8PA2P6wdX+8Xi9x37edb40WuFFc1o3ZBQAzW/GKteMY/7mBs+Cam7t0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787038093; c=relaxed/simple; bh=llI1eYDiE1+44pcJabFhew7U9QxDwmAqAUb32p9WxAY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gWJwQH0jGzuWFoVjGY247XyH0329jZuG/KiTNyi6V6lqL0AToMos9zrQTlhDqNDTfa9Yj4qlPNDJNJNl0NU5Q00Mcdvlcd6DdNkRbeIu9gf5IoOlaZSxOyCA6V9Ms58AxFR9UgIazrzUxObyjly6J4wpY6btLe4epqh+geEiQCI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=huaqin.corp-partner.google.com; spf=pass smtp.mailfrom=huaqin.corp-partner.google.com; dkim=pass (2048-bit key) header.d=huaqin-corp-partner-google-com.20251104.gappssmtp.com header.i=@huaqin-corp-partner-google-com.20251104.gappssmtp.com header.b=NTbCVQSD; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=huaqin.corp-partner.google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaqin.corp-partner.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=huaqin-corp-partner-google-com.20251104.gappssmtp.com header.i=@huaqin-corp-partner-google-com.20251104.gappssmtp.com header.b="NTbCVQSD" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-cbedf318752so2983978a12.0 for ; Tue, 18 Aug 2026 00:28:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=huaqin-corp-partner-google-com.20251104.gappssmtp.com; s=20251104; t=1787038091; x=1787642891; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=i/J6livk/VLSut+74toCa5+NkTdeXoYOz8nw8KIzNek=; b=NTbCVQSD7q3EZJhYjmEdN7PkWwHf/yLZ2dkzGxM+Wk/8ar6nAYvfdi1z4Qe0Z5GNdL 8a7V4H4WQ0q153QA9uCTI9le3witxiNSfmDoyXAE4ebcw4H50nYxk74IaJQaej8KqBIj SvAAUqvGDOCrKH3xoPvMkX4oNnEJxb8Isg/kI7CQ4gEXwO/dBHkLatdyJo58xgedTFDY qEeP7CeUYns7o5InGDwKdUkqSlJTjG7aEPL9PgPqZAOip4Lv9uefj6HWJpzUAgEdwYEO 7pnlfIm5rNe8/kh9x5MYyp5QOAJtyqGxozx+cCX0OWQdS+LB+qCYuCeXQtutbY6hCCGZ ePuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787038091; x=1787642891; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=i/J6livk/VLSut+74toCa5+NkTdeXoYOz8nw8KIzNek=; b=JUuyoBwVH1G+yUYcCVVqftjdL9cbwvIXepwe8h57K0OK1/XOd7C9lf/eagu5Vok1qx VUXA42HT81txA5aBAJ3XNHTiw94tBLDaxxeDW9CFoAUaU8qkT9VJy/T12HGkO6xRJvx4 64+9yDSD6uFda3N5m6NtIXU54Hogc+hLVUHe3A+BTSYQWKR/r0p3/60BVvVXOSVWJKxG tRe1HTmknmbxJ8nku302a47wt2zqIqz31PQ+2QesvZvcaWCwncm0rbD8AVVPT4Ptbv0c WoEmXK0XBbJZkUlirgRBEVkst5m5U9lieGXeHa3pbQt1jC3COFGCQtE0PcwnfMoKf6Nb Hxmw== X-Forwarded-Encrypted: i=1; AHgh+RrT6uZUtgFgyc020KBBGOYWqrssofdTaw1A3Wx6Jk33l7GZbXQNbo1Kec/8oBa+mDg7uUIRRsZR/HtnPR8=@vger.kernel.org X-Gm-Message-State: AOJu0YxsdMEA+Jn/qA4gJdRELO5I3q5lcl0G7MSIt3cQr6pYs84sPHkF 58t/79qzO6imi0goHD2P6lANrNLvtarQqJUTuOMtqlRy9v1QaR9mmLdv0zcQ5j9WMn0= X-Gm-Gg: AR+sD10yiWWwiWM2epv5zRusRIcM89qWS2ThyDovH3f6JW5WigzaNQwa5Is226eOvkE +7wzFYITVfR2wpE3IeW+gVeWcb2mP16Tvru0wKegGjW6DeuQi0SDpmoNOnXpGoilnkDZd3GYqo3 A67pOVEFc63ttUkOVSvSEbDs3qtrndOKGess6xsG8m482l2WdDg2dV7QoU9okGxIAzETMEFbc1G hth3oHCz4RGLOnFA08b9wnC/vMntXo/r3XEBSOAs01qob1Z4vUJBHFYPxfgQEIZ2w5g61STkjrp tOCwI9nQOp/TPnk3DfsQwAIfsAypW1Sn1mRvM+aa1iSV5/AsCB53MYhKVGj0zBmkC3grzqZ2pRb p7KJZWv/ZPpQ21UflBO5OJkM9x9vF7yWKobBAvOrE6+CoIDwUftC5DdGZLrTh6GkkXQyFvwse3c fma5GJfS3PuMAOjoy9KRks2JtQdvWRIXJcLc4Nar/BS8N7elhPWQTcI+gWJkJTLS+RkHQ5OniA9 2A1HUy0h2MQ+Y68rTcJFsIFfQgCoYQBNJ22LqbGFi5bKoXTpMPYYjk= X-Received: by 2002:a17:90b:4b01:b0:38f:240d:b857 with SMTP id 98e67ed59e1d1-3933b714d4dmr29278418a91.2.1787038091235; Tue, 18 Aug 2026 00:28:11 -0700 (PDT) Received: from lucianna-LOQ-15AHP11.huaqin.com ([103.117.77.121]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3954d38bd51sm5146630a91.12.2026.08.18.00.28.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 00:28:10 -0700 (PDT) From: Zhang Jie To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org Cc: gwendal@chromium.org, swboyd@chromium.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Zhang Jie , stable@vger.kernel.org Subject: [PATCH] iio: proximity: sx9324: Correct proximity channel resolution Date: Tue, 18 Aug 2026 15:28:03 +0800 Message-ID: <20260818072803.463864-1-zhangjie14@huaqin.corp-partner.google.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The proximity channels were previously defined with 12 realbits. However, PROXDIFF is read from RegDiffMsb (0x65) and RegDiffLsb (0x66). The SX9324 datasheet assigns bits 7:0 of each register to PROXDIFF and documents it as a signed two's-complement value (Revision 3, Section 8, Table 8, page 43). In contrast, RegOffsetMsb explicitly marks bits 7:6 as reserved. Thus, PROXDIFF is a 16-bit signed value. With realbits =3D 12, sx_common_read_proximity() uses bit 11 as the sign bit in sign_extend32(), causing samples outside the 12-bit signed range to wrap into the [-2048, 2047] range. Correct the realbits value to 16 to accurately reflect the hardware. Tested on an SX9324-based device: a phase 0 DIFF readback of 0x7fff was reported as -1 before this change and as 32767 afterward. Fixes: 4c18a890dff8 ("iio:proximity:sx9324: Add SX9324 support") Cc: stable@vger.kernel.org Signed-off-by: Zhang Jie Reviewed-by: Andy Shevchenko --- drivers/iio/proximity/sx9324.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/proximity/sx9324.c b/drivers/iio/proximity/sx9324.c index 36c45d101336..de6176fd8d47 100644 --- a/drivers/iio/proximity/sx9324.c +++ b/drivers/iio/proximity/sx9324.c @@ -223,7 +223,7 @@ static const struct iio_chan_spec_ext_info sx9324_chann= el_ext_info[] =3D { .scan_index =3D idx, \ .scan_type =3D { \ .sign =3D 's', \ - .realbits =3D 12, \ + .realbits =3D 16, \ .storagebits =3D 16, \ .endianness =3D IIO_BE, \ }, \ --=20 2.53.0