From nobody Mon Sep 28 18:36:39 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB5853AB260 for ; Tue, 18 Aug 2026 15:54:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787068477; cv=none; b=Z4NCBt3jm3CBkWeL7Ok6I0MkYqNfhf/IEvhWuHlp9JgEjvw/t0adHadGajOtKBZzZ9V/ym6QQjHrKr0v43ygz4aqUCZRtsCtgFzYTHu1NBsoMjMLTjmh5FumkhNmPfVhiuaD81ak5oMmvROGLmf5maLhGYknEByBJIaiRVP1/TY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787068477; c=relaxed/simple; bh=BJj+h6cqFz7a8jDJBV4N5fl7HAGSE22AVRcbeP06B/M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WDfmkPGjsR5uK14LS0/5M2npJdUBusi8cgXS8E+1LMUR1vCLInZEcP2ukOwOWE7+DTbxR6S5PjT1Ab8UbOPGKXTMaI41l/yX8ViuLOpKOMru28v9k3HNE/GUI/sJpgafsA3U2ggv4LvtXIsecK/8AZkPAyLiIBtT9YbEBBTQqE4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KoHi1EiB; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=f/us1bWu; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KoHi1EiB"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="f/us1bWu" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67IE0TIj1017838 for ; Tue, 18 Aug 2026 15:54:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uNUPIhgDn26t1adXEsWMB0BzKTY4owl+xpM8zcLh8mc=; b=KoHi1EiBC6jfZcYC QSvidTv9Wd3jNuzJaoi1aA7Rpu9eHPSlan9JCtpZqvXfHCnviCVlOtWa6ZxPEIOz z1ZyPw170scNBZtf9KfpfYr2SuXSoZVM86G+qXJM1nJwNPobCbLef0MxeGU1CmoL ffldrTIya82O0f0ovbLFk90Ke00Hm16IRazYv/ToOB1+c1xX/c534yF465QL/NwU h+QBMWvDWj6E/EnUKhYJ1a0oCI4BmMgTPJmiJtfoF3uotcQgldnktlOen0KuBZqQ iRxtLjXXBpDIt9xt+Vr+6eN1vK4LWlO0IDQpM9ZR/ukThW/WoVtUrSyKHtufmxde +QAazA== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g4qxj0wun-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 18 Aug 2026 15:54:35 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-cbedf6e8a42so6084651a12.1 for ; Tue, 18 Aug 2026 08:54:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787068474; x=1787673274; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=uNUPIhgDn26t1adXEsWMB0BzKTY4owl+xpM8zcLh8mc=; b=f/us1bWuTr1RLU/nGzb9Lil5JzPu6WEMMG+ODd9rNwB4JY0LorQ5JyndYWTL+1HGnZ vFOOlIHqOydxcZJLWrNdT9DpYn6N4ooxnJFcG7xkJnnHR9ZyPAZoUAska5uHlJRt3aU9 0//Ry/1CUlK9cMTzWMqhyI2R+3j6W5HNeoiQ0FsjbeJeXur1ZgTN9RbgXHOMGqHEiXAJ Ptgwma7qQ+TMu+3JExyvta0/5C8AYupgBmg8uQgMWFnF8VpJpbg5NX5mG+C69gatyB0I XYbY0nTeU049ElM4mWnkO5Hv+9nABZDX6lT1Gvtf0374YnYgyxZ10RPFnwILFpoCDsbm DVXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787068474; x=1787673274; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=uNUPIhgDn26t1adXEsWMB0BzKTY4owl+xpM8zcLh8mc=; b=RBgb2m7iG3WW/LGB15HNjRMH3cEpNOf3AYHdaLsnh0vUrI+OXBacBWxrG7sohZ+mfl ejch2/J8DKKMov57o7tAPqxVtB+0/UsYT9Mn4/FMnH7DsY7ILbTktppVukNgLVvbp14F XqQT2xd/7rR0I/t4MV7i6TSWl3BHLg7T+I+yQp9GmvJG53TcSTVJQCR04Nnvja6GjAZR hBpFCL1vsAM7XDC7Tea2X4thQ6s9hdmNxdd9R3BH+dFvmqBUIeb0a41W+oHkFzu1dk0U Pau03xjvroiGQi1ILDwwUQn3wEFvaYxnf+UgVvPmIeojgCECjPswKIvpc5JbtIw349/N SiVQ== X-Forwarded-Encrypted: i=1; AHgh+RorEUvz7/FTPWKnWKQvy6MT7LLL1ceK/lPjsxzLS39ErjS7kldsyr1CEKQfh9DRDVnv/YScWVsWFUQ7Z+c=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5qq18NIVgVhuz9TvZhdvg59E5qXmJvvxiCWPOpC83cWJ2oFkv qCXiJ7xnVqzPWCXdsXT5WGIbIxkjvJFIkv//SuYzUe91uU10YzvEwdDvI++aKKWWhBZukI99Daj 4wB1IzEXDGsa9b/e1f72xsus0ZIl69Gf9MgZWxc6ExHkChksFVOtCey9oRzFr4dfJtfk= X-Gm-Gg: AR+sD11XHnkw0mh2KDjOvK4XHrD80f17t8vejNyQA95zwqnkeYSMOmGAKuCfxSfzk7F 2H4yG97tJgd7gq/U3lbxC4gNUo9MO+MMASOk2GtVfcQemuQOUSXpImuaI/P1GONmD3hcT2XevE4 YqHpXt+yhgjCLzVMRx0ebxR4g+HUh27QU+/GcJ5hzZXWnkBgtk8s3H7kOkgvgf2qIrfr6n/ahDT 84xQ/4RkAem3T0Mem5Wn1UJFQl9RsnIq6NMle1tcgVOmafKjC9yWfFroksskziGWQnETabvF+Pp Xu3qW6cqRhzHlTSEMJ3gLsKJHeN/lT3Tgx4V5fwyzyYE9JSkX/iDGQ7DBTvj74+rR9auJ1kJJGZ AqM9cXDTT7WNmOU3oh8dZWAcpxFFF9/qINw== X-Received: by 2002:a17:90b:554d:b0:381:152b:d596 with SMTP id 98e67ed59e1d1-3955a7b15e0mr12443646a91.11.1787068474174; Tue, 18 Aug 2026 08:54:34 -0700 (PDT) X-Received: by 2002:a17:90b:554d:b0:381:152b:d596 with SMTP id 98e67ed59e1d1-3955a7b15e0mr12443583a91.11.1787068473674; Tue, 18 Aug 2026 08:54:33 -0700 (PDT) Received: from hu-bvisredd-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39531fbb41esm8877721a91.10.2026.08.18.08.54.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 08:54:33 -0700 (PDT) From: Vishnu Reddy Date: Tue, 18 Aug 2026 21:24:14 +0530 Subject: [PATCH v2 1/5] media: iris: Add dma sync calls for input and output buffers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260818-iris-fixes-dma-pseq-fint-v2-1-8dc8c4b3880e@oss.qualcomm.com> References: <20260818-iris-fixes-dma-pseq-fint-v2-0-8dc8c4b3880e@oss.qualcomm.com> In-Reply-To: <20260818-iris-fixes-dma-pseq-fint-v2-0-8dc8c4b3880e@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stanimir Varbanov , Bjorn Andersson , Konrad Dybcio , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Mansur Alisha Shaik Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Vishnu Reddy X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1787068460; l=1822; i=busanna.reddy@oss.qualcomm.com; s=20260216; h=from:subject:message-id; bh=BJj+h6cqFz7a8jDJBV4N5fl7HAGSE22AVRcbeP06B/M=; b=LNSWQJ0jEEwG5D2jDFEvMvuGDkumH4jv3k41dqOwv7gmEqT/9Cft6q6q32zjzDer19dYL4Fgc JYH4rzTJ2+fAWZYi9ufsCiytkJsAQPpMpv0FmJrsDhUgc2bmYohs5g0 X-Developer-Key: i=busanna.reddy@oss.qualcomm.com; a=ed25519; pk=9vmy9HahBKVAa+GBFj1yHVbz0ey/ucIs1hrlfx+qtok= X-Proofpoint-Spam-Info: AW1haW4tMjYwODE4MDExNyBTYWx0ZWRfXy4EGjFu0Yg5a e03WuO0bJMnhElfu3uWPAGKXTaDxorAj+6C2IdpH0rySt8REHe7pY6dc79W8NdBuS1zw9YoUy3w v8i6FH/E4fEllR/UVBHkG3lQ29QZXSk= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE4MDExNyBTYWx0ZWRfXwKTcKma/pBUv pMFDlKSnSEYUryQ3NCmrWWLVQpQJWvPPjT0PsUnAce2t0cXbaDQ8RpKpCNvN+vNuKdEEuIXkBzG bBcrsfx2qfAG0/PrX1APkeKBg3YQuvxHQrOk7w3auatnc7eyhnIWrANdy6BhI6tUp9ir3H/bcHG 3zyyL6jn9KZ2aGscR/tv6D/x+VR3it3PSWRg37+z/uT+EbmuKH2ah34osuayLYrWvs9WAD9kdhL eQQYYTVmE9ig56ELSJUnB1cdnytKSHLDknrZXK+AiYkncDB+I0FWiPVZ2cWdVcfrbKuudTaTt+2 /P4l1NNrD9n4k16Tixq56qfNDaw2mdrnJgG+sm36rPPaziEEQKlMA+j71ZF4wAaRUAw7MUSjD2s vi3cXrEnDdME1dbkQe/5Xk34Fqst2ba/hZtNryAkupv9rHIqq/QjcTmteiD4PUFZuBHHX1fQa+m 2DPjtaZCc7UdgsPnhBQ== X-Proofpoint-ORIG-GUID: ce4N8ZkbyefuOytJqQjTlaCuLMw7PMzE X-Proofpoint-GUID: ce4N8ZkbyefuOytJqQjTlaCuLMw7PMzE X-Authority-Analysis: v=2.4 cv=bvB8wkai c=1 sm=1 tr=0 ts=6a84803b cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=cW1-DYLjWNxHbtL6yV8A:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-18_02,2026-08-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 spamscore=0 phishscore=0 malwarescore=0 clxscore=1015 impostorscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608180117 While testing with some higher resolution clips, the venus hardware triggers a fault due to wrong input data being received. Corruption was also observed in the captured output when the client dumped it to a file. On debugging, found that DMA buffers shared between the CPU and the venus video hardware/controller are not in sync. CPU writes to an input buffer can remain in CPU cache without being visible to the video hardware when it reads the same buffer, so the hardware receives input data that does not match what the CPU wrote. Likewise, on the capture path, data written by the video hardware to the output buffer may not be visible to the CPU, so the client reads stale or partial data, resulting in corruption. Add dma sync API calls to synchronize the data between the CPU cache and the venus hardware/controller. Signed-off-by: Vishnu Reddy --- drivers/media/platform/qcom/iris/iris_buffer.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/media/platform/qcom/iris/iris_buffer.c b/drivers/media= /platform/qcom/iris/iris_buffer.c index eb8de60c1177..c7a664426187 100644 --- a/drivers/media/platform/qcom/iris/iris_buffer.c +++ b/drivers/media/platform/qcom/iris/iris_buffer.c @@ -585,6 +585,13 @@ int iris_queue_buffer(struct iris_inst *inst, struct i= ris_buffer *buf) const struct iris_hfi_session_ops *hfi_ops =3D inst->hfi_session_ops; int ret; =20 + if (buf->type =3D=3D BUF_INPUT) + dma_sync_single_for_device(inst->core->dev, buf->device_addr, + buf->data_size, DMA_TO_DEVICE); + else if (buf->type =3D=3D BUF_OUTPUT) + dma_sync_single_for_cpu(inst->core->dev, buf->device_addr, + buf->data_size, DMA_FROM_DEVICE); + ret =3D hfi_ops->session_queue_buf(inst, buf); if (ret) return ret; --=20 2.34.1 From nobody Mon Sep 28 18:36:39 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F104F3D34A4 for ; Tue, 18 Aug 2026 15:54:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787068484; cv=none; b=O+Q2AG+g/hguH06iSm2/+tWkGXEo33u2TUokF7ippT/hygXdJk/ahjuaRinvNEBeT2Y0rchq6TYomIzqLcPrhETLJ+endT8WtRmtBMb2WZ4kD1F+SAvHyXWGtJxr0pOcwQPkdhaR+0wAkYtOHr7M2ZSpJwbIi0Zu0jlc1cfRLcU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787068484; c=relaxed/simple; bh=0PqC6+pA+upeSdG9qohub10QOHiozDL+AqpKZ0qsSlo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XL3Hi6MLHP/EMXXbby/r7fPe5VS3CCYUusFIV9eNhn1J5kIg+BhXHI0eEdtXx9bEnwEhBN7WTY+srIPuJwMqfJsY+zrjjsHOxFNSMKVjJMRMLJpXagezeH/5lNjq8ZRNX8mJI2JsOqBqe9vLdcT2TghEKIji3BHiqYuFIwLZLdU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PNFH0FyY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZqC6U9DV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PNFH0FyY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZqC6U9DV" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67IE0lXH292853 for ; Tue, 18 Aug 2026 15:54:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BEW+CIRrZQp0gkZZZbYGm+dB8HccqIdZMRtCd6mN3HQ=; b=PNFH0FyYDp2KGwtZ noL4J5gY1SUl8W9K9KAI3DbwVqazMzbH7MEbGqch+zi9sBaLpa7jA1M538J9YMPn FWY1J0cdn/bYLFlB/6YtChV9fu6KYhiprRAEQkFO95CJ+osL2FHWrP1jTM/K7axg aynDkWLJE0i2Fnq5Mw2g8B+OkS94odqCiO3BTym4c8tfkWrM6Bugi63tCmstlpYr oeCQ6z3GIiQUBFl71/7EnUiSw21jKYLAhyJlEIYase8DE8kib4xYXEm9RagAhbUY ofYKiV54Hwp3Lx1iOqBasIuN7DmiRtb4V9LgmSbI/XgnNtZ5bbIqP0UeSDTZ0WxM 4DlU2A== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g4resgnhv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 18 Aug 2026 15:54:41 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3950b1371a7so96951a91.2 for ; Tue, 18 Aug 2026 08:54:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787068481; x=1787673281; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BEW+CIRrZQp0gkZZZbYGm+dB8HccqIdZMRtCd6mN3HQ=; b=ZqC6U9DVMWSZSQKHkJ5e5nu9OMJ37KdBy4es1ypg3rzxWGWSiITok2L1iMxxGMPPHi AbRfYux4eU9BDlGO3mrDVe3nvf9ynUb9B/eE4T7vopB7gswUkg0LtLr8FkvpGuwzDRxK Z8zpZEn1YeXhiRZW31PAuzUON35GoC8z4uvfWIA1eZZFU+um2IY9S0qx/V9HQHWoDRGf Qx6caTiRHnHKDSPrqAeWlQ66XwhUvu/vwps5SWW0Y719wJs6RHYoIx3LAFPYh5WRpizE U9fETbWVz6r6lo5ldMnzjMtAy10L8n5+AdINMiQILBxBYmTPpMYNRYeHT1g2H188mX6n oPIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787068481; x=1787673281; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BEW+CIRrZQp0gkZZZbYGm+dB8HccqIdZMRtCd6mN3HQ=; b=VudA1SZ09UsHC51P91CvzpfzCQawHVpTZABN5jUo56wEQxryJLLT2BlQNfYg+ektPq gogsPo0ZE+pVznIx5q5IFMcE5SQgVn2OtykK+qtqgzhTE8PltEzTSLMZbD+wrCaODv3b x80gqFAaELsRlWMlxSc/gyvDaIVxviziXW2VXB9ZOFEefngXmOTHZ6fXooi2CbcC0rQ4 KTNC+Tr008cRWfMptiJz2KlY4zO0QHgd9MZd92xwq4WE2ZhiruObP0juh4d8TOsZY9LV 2YOZV+nVq9pXFq4bE9U8So84HsNTSnUdtqT0yCmp8VVbFadK++z/PR1w0ldf+/9dAXn4 XQaw== X-Forwarded-Encrypted: i=1; AHgh+RpqpmOaAe5d5bvLoSPbAskG2ASq6PVJEGQ/UYeaYM0ICS3Ur3tTsRZoiQGmHsSX8XqRBpNYTJ6ECOFWG2o=@vger.kernel.org X-Gm-Message-State: AOJu0YzRDY6OzIldnCwyxI/iaBpkDULmmd4EIuB1fv4GAHKqns39A1Ht KObn/5Tj59C85yHg8LefEVGAJkQ8a+MPJmThKTkZwr98kAkGUiKKXmButvKEztv//J1iwxYw+Y3 5KdtDCAX9E8peLARByKhJm+SrUmgIEYNmdeoY1TycAiBs1IaAYgYjOYJCFWbQaqBMtUo= X-Gm-Gg: AR+sD12S4Z+MnMKnH1itQDinKDD9HtpU2hVZFTpxwyLjZ/AQTUX8xqm/XmNvpiPHmGd pWO7RCAOoxauOPpA9apth5puWFmUT3Z/T74Mi7ZLKpK3o/iMzE3/+FuSUYJ5ExqO2q3R4RWzT1J i53d5O72JQVJDmMiB4kj39g0Aft5IDTHGu4A00fNBRlW8ZQbs6PjKw/M2hkqK/tWtGcLzOE2CPJ brOW95lKhrtMJdkqh1AaL31D+4jSthyro5AQt6iHfPjm/XOrcPa7x6+vja8HcW9+CHE3Qzra3kx /TQYBXhUrzFehweu8T8+1qYE5E+hGwh/u6Sbc/bVy3AwENS+CBdMygWbOvrY/9pIRbCrSldvJBM 4cgLehn2WeVJVnv2DoCLk1dquxgRhLz8TZQ== X-Received: by 2002:a17:90b:5645:b0:383:5a16:bd70 with SMTP id 98e67ed59e1d1-3955a7f8e97mr13337461a91.16.1787068480655; Tue, 18 Aug 2026 08:54:40 -0700 (PDT) X-Received: by 2002:a17:90b:5645:b0:383:5a16:bd70 with SMTP id 98e67ed59e1d1-3955a7f8e97mr13337399a91.16.1787068480246; Tue, 18 Aug 2026 08:54:40 -0700 (PDT) Received: from hu-bvisredd-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39531fbb41esm8877721a91.10.2026.08.18.08.54.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 08:54:39 -0700 (PDT) From: Vishnu Reddy Date: Tue, 18 Aug 2026 21:24:15 +0530 Subject: [PATCH v2 2/5] dt-bindings: media: qcom,sc7280-venus: Add dma-coherent property Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260818-iris-fixes-dma-pseq-fint-v2-2-8dc8c4b3880e@oss.qualcomm.com> References: <20260818-iris-fixes-dma-pseq-fint-v2-0-8dc8c4b3880e@oss.qualcomm.com> In-Reply-To: <20260818-iris-fixes-dma-pseq-fint-v2-0-8dc8c4b3880e@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stanimir Varbanov , Bjorn Andersson , Konrad Dybcio , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Mansur Alisha Shaik Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Vishnu Reddy , stable@vger.kernel.org, Bryan O'Donoghue X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1787068460; l=1821; i=busanna.reddy@oss.qualcomm.com; s=20260216; h=from:subject:message-id; bh=0PqC6+pA+upeSdG9qohub10QOHiozDL+AqpKZ0qsSlo=; b=hCNhAws51z6kUkElVeslS+xeCq7dkznJyZ8l65o5+9B1qAZyCmMoFrHjgijblBpo/C+hjCyK7 mxKvXtn0zTOBJtm+NnFXX8nfq5qAU6iroHVxbIOZfuMu6ghMNEg2cMV X-Developer-Key: i=busanna.reddy@oss.qualcomm.com; a=ed25519; pk=9vmy9HahBKVAa+GBFj1yHVbz0ey/ucIs1hrlfx+qtok= X-Authority-Analysis: v=2.4 cv=Ne/WEWD4 c=1 sm=1 tr=0 ts=6a848041 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=iEGguDXwTU0lvcBalcwA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: nqTvQ09ei7ieX03tLSqbwhTICaVmlsu6 X-Proofpoint-ORIG-GUID: nqTvQ09ei7ieX03tLSqbwhTICaVmlsu6 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE4MDExNyBTYWx0ZWRfX6OpAXj5h+zbg Z0TOfbPafV4B+myjsctSC3wwoDgPEW/GZiE0IXeJu8szDJk1WqQbj6vTQ79i1IRlUP0/L5YSMB9 jDT0JHFJNRFn3CJ7+BlFVTpX0dVNVCc= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE4MDExNyBTYWx0ZWRfX7sOHi15W1N6U idyC/K5gWe45XC39hb5elWmyujY46KtnebRnEf0e6gqWocBL+6g4MFaIRfYHbPI9SWPAnRBSQlG LqZL9HFDa+nmIZqBjcmGYhth5Ix0qyO6g4IoNutoNmN4hGTErbn3QCn6sMB45smM0T3KYSGpQij +6taN7B27h7BdAEEMsxUPnfME9p/kOU5tw4cfbRpYTNN2fmUM3qslhL8sxC1W63QTuT3b9ZEAU7 wWmH8Daava+7ToK85F8HB3L+44udGqv/sWQdloRlcwE+XSyQQH3UgMjlxyZyE97RCLC3jyh6GQe TvDxDiXKVQPej6ivRbsfsEZuvBZaGgn4XlXhnkDlHrFw54E1WSmcGiZ2OnbBXKcQJGGS3+lim8s ok/Q6j5PTZsFMNksZnzSy/Lm9pfq0FrkbI7VQ6zQPR9s7D2++Bc6jFNEWBvyuFysHTw7VPNGNHf 1O0XIc5Lw1AlDV7bkUA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-18_02,2026-08-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608180117 The venus video hardware on SC7280 is IO-coherent hardware: even though the driver does dma_sync*() calls for the input and output buffers, the venus node still needs to declare dma-coherent so that the DMA mapping layer relies on this hardware level snooping to keep the CPU cache and the DMA buffers in sync. This avoids the unnecessary cache clean or invalidate operations performed by the dma_sync*() calls, which are not required once hardware level snooping is enabled via dma-coherent. Add the dma-coherent property to the venus node to describe this hardware capability. Fixes: 37613aee2179 ("arm64: dts: qcom: sc7280: Add venus DT node") Cc: stable@vger.kernel.org Reviewed-by: Bryan O'Donoghue Signed-off-by: Vishnu Reddy --- Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml= b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml index 9725fcb761dc..cc31f3ba7e7e 100644 --- a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml +++ b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml @@ -42,6 +42,8 @@ properties: - const: vcodec_core - const: vcodec_bus =20 + dma-coherent: true + iommus: maxItems: 1 =20 @@ -85,6 +87,7 @@ properties: =20 required: - compatible + - dma-coherent - power-domain-names - iommus =20 @@ -119,6 +122,8 @@ examples: <&mmss_noc MASTER_VIDEO_P0 0 &mc_virt SLAVE_EBI1 0= >; interconnect-names =3D "cpu-cfg", "video-mem"; =20 + dma-coherent; + iommus =3D <&apps_smmu 0x2180 0x20>; =20 memory-region =3D <&video_mem>; --=20 2.34.1 From nobody Mon Sep 28 18:36:39 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B8103B5319 for ; Tue, 18 Aug 2026 15:54:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787068492; cv=none; b=L7LlrRhiPhsImzzTLunshB+EPxbT8fD3zfKrEv4ISY42iteN5vaYipxzXlQNxgZZrHxZ5Wuuh844M0fKYXx5jicwu1iR79cjzBnkKJs02Vzcgnc45juIykaviY5o/ZWm6HkaLkAOOUQGScoGyidwID+Sr8fJBh1bSv2QVpf2CHw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787068492; c=relaxed/simple; bh=NM+SVCwRjrTn0Ct0OojvIaz+v6i9CmljcmsXUs7015E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LEl54SZul8tqOCKpKAI24bsH9RBCcoLjntZkmxMTYYbccba2BCRJ9QEdWdMzvmy1kwnSSBhyJKXCTO5vQd3ZxKJaCEAgCkuWgNubH0iW7QomsR6gK4KOcxi46DCGJWoVCZXBrbTTzQBQrL5xs3iD1u8m13RskjfB2glMePK4yfY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XSGGlsNv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ag5y1FGJ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XSGGlsNv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ag5y1FGJ" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67IE0llZ292801 for ; Tue, 18 Aug 2026 15:54:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VplzGt0KGttO7fI6MDL4GLu3+FXO0PZKPRbhx5iOWvk=; b=XSGGlsNvbQzho9Kg Zb0hgWZx7H4uyNxlO/Xoa9vBIfiK0biFwqVFD/szYLP2kYhEvOhVbhLszYBLYepo dPGFvD9wo1+cI4G13XgVRj3A4dAp1BuPAYMwGP8uMEQlU9Kn/TTdl+b5PLiJFwAw M9ws4XWmpum4s+v0Zp4L1VKCVumRhQvXY3rHcgRIzgqwB56/oNan7x2w698Hdll0 GJw5kJ+f7L1ho429uyI/A8PDarirg4xox4MDr2YHg8BAAhmuVabqOvr/+FpI16ZW qB1IHw0vYIFYVzqhX/qzH2zHI9kmEhcvdB9+bC8zBRV+3c7hbjy7jgmOg4DVAnBA nB4g4w== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g4resgnjn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 18 Aug 2026 15:54:48 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2d004f13426so73702455ad.3 for ; Tue, 18 Aug 2026 08:54:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787068487; x=1787673287; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VplzGt0KGttO7fI6MDL4GLu3+FXO0PZKPRbhx5iOWvk=; b=Ag5y1FGJZn9eVXXcnwC0o9XNroXrrEUOsD1qRniX5MkhV4R2R2p0AXHmJr4d2/rS2r ntxqqaU3QEKpyTGApSzFHt0hqhLXC3qZQL3OQGBQ1t44U5xL01VLETrERjFALjs2BAHu N8prRc9U6f4VWccUjxM1/KfojfAqvO7qk45EhqIti9/O4LKZGR3T77EUrocFsW5GCoDd A5YZ10Xkl9HfyLe59atEqQ/+fL9HTwTUA58Abk+59gdcs85Z/ob1ttzTuVgCuPIZ2N8x R9AA64bSBY9+SkUL6ik9lMPeg30WMo+8UciYvvrC43iOrD3DKynYCDf1QWxnkMDc8Re0 YdsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787068487; x=1787673287; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=VplzGt0KGttO7fI6MDL4GLu3+FXO0PZKPRbhx5iOWvk=; b=d/3BVKuXG/e8dWb55BJ88XexGxqbVyYAQtGqmKpOwsFG0/sSVzeJ5XIEdHzsPasz53 W2+8uUex+ysLrJ/86A6fNZgzb2Z9EVjFenHHsZgaqOgpd0TJS6RrDzUzmAgivq1DZtRr bbdf3gKgg2XwcRhFrOytuw/VmU3ZiyKgUcsuuWa3tXIXZo7580k8NoqvAyXVBSniOX7i ZiFJHyhx3mc6oqpwZ28Vrm0tTEWQCXBSUsRbJu0/k2ltjA7M5dsuvz5JuCyfvKwVWYTF kic1Da3lfzVgL2coRf7ND5VHyZOuw6HmOBFMlpnc5g8TWn09RobaXBpuS8XViR4zWBw0 2dVQ== X-Forwarded-Encrypted: i=1; AHgh+RpflN/0b3+JA2FV5XQZDbkbIJkVcQhExtaygeyCkudWJ4iqulJ1MhhUoy2Cv4Qs/NN6HwBu9lxrt1IBaK0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1ys20qqtxdJPUr/Aa+tSiRNKFRDNk20VuOQxQkyQO7IsxMKtK 52ljfVp2tiv26DEToPRUv2gaPICecnKQsPA5jSgU96TiLAMUTYcVwNZYypMpRnKNJPTQaXlpVXB arh0zQKbVw3gxKfoh+ahA8lpAxH/PgwCzNPXw3EWml169zquywNNm92P+TLv8CTvyfLs= X-Gm-Gg: AR+sD125eonrsJue0NMSrDDrGchEp2Aual+G+UBX4kdkYWzGMl24Z/DgHXoibTCf/94 uLUoSLzJMs1PAcaKIezY45c2ZxRySCnVk7NZe7JNGNRCAYDwgG4YSfrMzKlnffRU8tod0Bz3zY8 aR4liaFyeQxz5/R4VRqFVkJVbVjinyZmOgUoZbHtqYg4X2IFmROZ1hBbyUhzLsjF2cKTXRZhq8r cklUJLccbzvhM1ldXwHtYDLv9nX/mjavp1JDGmxH4SbaZv35Y5EPT5/CTI/96T7KjUyPxREC34N BNOxsTKar+4KzBz39w2Bwz6iqMPJW4u1RvItyGY5bIByC0JunRc+02m3mMtuWn1MlYJDrgW9nRJ UtymaGc8ENkwR3zdKPPRc1TlOU22shCizAQ== X-Received: by 2002:a17:90b:278f:b0:38e:57a3:f218 with SMTP id 98e67ed59e1d1-3955a7c464bmr13640456a91.13.1787068487400; Tue, 18 Aug 2026 08:54:47 -0700 (PDT) X-Received: by 2002:a17:90b:278f:b0:38e:57a3:f218 with SMTP id 98e67ed59e1d1-3955a7c464bmr13640382a91.13.1787068486871; Tue, 18 Aug 2026 08:54:46 -0700 (PDT) Received: from hu-bvisredd-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39531fbb41esm8877721a91.10.2026.08.18.08.54.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 08:54:46 -0700 (PDT) From: Vishnu Reddy Date: Tue, 18 Aug 2026 21:24:16 +0530 Subject: [PATCH v2 3/5] arm64: dts: qcom: sc7280: Add dma-coherent property into venus node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260818-iris-fixes-dma-pseq-fint-v2-3-8dc8c4b3880e@oss.qualcomm.com> References: <20260818-iris-fixes-dma-pseq-fint-v2-0-8dc8c4b3880e@oss.qualcomm.com> In-Reply-To: <20260818-iris-fixes-dma-pseq-fint-v2-0-8dc8c4b3880e@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stanimir Varbanov , Bjorn Andersson , Konrad Dybcio , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Mansur Alisha Shaik Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Vishnu Reddy , stable@vger.kernel.org, Bryan O'Donoghue X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1787068461; l=1397; i=busanna.reddy@oss.qualcomm.com; s=20260216; h=from:subject:message-id; bh=NM+SVCwRjrTn0Ct0OojvIaz+v6i9CmljcmsXUs7015E=; b=OgtH7SwjOfbutdA32u3izUhOzp9rsimX/RNBwDxYSTZyfJZF6qsTp34Ukh3wBNtwbmdVkbW8x pREOpr5kWa2Cy9CrYn6o4DEOLYYR6iOKeG2/4Svn1rvsvPHAHKlkR1Y X-Developer-Key: i=busanna.reddy@oss.qualcomm.com; a=ed25519; pk=9vmy9HahBKVAa+GBFj1yHVbz0ey/ucIs1hrlfx+qtok= X-Authority-Analysis: v=2.4 cv=Ne/WEWD4 c=1 sm=1 tr=0 ts=6a848048 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=wmxX9RSyIuGEu2EnybwA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: esvxNlBB2Lb1F5w5iXyUnIYGk8TmWDIl X-Proofpoint-ORIG-GUID: esvxNlBB2Lb1F5w5iXyUnIYGk8TmWDIl X-Proofpoint-Spam-Info: AW1haW4tMjYwODE4MDExNyBTYWx0ZWRfXy9AmgPerzrkA hASp3C6hRIyRKtdOxVqc4WDysgYJXdMwKdYX8iQhZw6H4GoEYW1i3TBgzdQ7pzqAYOCPL1yfcFP TpAL93oeSjJhdaXVSlHsVro1K/1gDhQ= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE4MDExNyBTYWx0ZWRfXy69XoW7A9Bd2 QS2CWXuLeCKgRU/86DQNEtYimZX8C4PcT8I43yv21BRru+oLevJ3J1QoIntnz/nz550Sn/Kd571 q5NfP/cgOmDFrytF/D1gJ0MKJInIpwCjccvEVG1t0KaunWFSgG8cAoqvEI3+/S57o2AjuepS7RT XU3YTJRPQNqOfabrR2M64o6P3qUbt6X1hQP6hhg8q0mZTo2aDFKORSjeqOd9oEZzKzvq4zeTF3C kgABSzaxknf18m7VLmCpBAkzM9ZPDTtcKYn6GhM2Ujym7tL3xaFfVx9pP4Mj3gfryy5uGwQiDbW +AOLsFDgt9QZ0DihWJXmaq5YudIvtFnoeAaXLR1SXvSMQweCs0qWHRAtAPKnAZNCYD//R3yeKLD 5Z15FWRNTSnhqHAwByFoTVsaW+lMjr1PCbwOLd8ryAwusJU9dAdBx5BP9ADJFmBNaO5kwfXssgE rjuVre19UU403wOrZWw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-18_02,2026-08-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608180117 The venus video hardware on SC7280 is IO-coherent hardware: even though the driver does dma_sync*() calls for the input and output buffers, the venus node still needs to declare dma-coherent so that the DMA mapping layer relies on this hardware level snooping to keep the CPU cache and the DMA buffers in sync. This avoids the unnecessary cache clean or invalidate operations performed by the dma_sync*() calls, which are not required once hardware level snooping is enabled via dma-coherent. Add the dma-coherent property to the venus node to describe this hardware capability. Fixes: 37613aee2179 ("arm64: dts: qcom: sc7280: Add venus DT node") Cc: stable@vger.kernel.org Reviewed-by: Bryan O'Donoghue Signed-off-by: Vishnu Reddy --- arch/arm64/boot/dts/qcom/kodiak.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qco= m/kodiak.dtsi index f2da3706d5c8..b8f5705ebfc8 100644 --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi @@ -5025,6 +5025,8 @@ venus: video-codec@aa00000 { <&mmss_noc MASTER_VIDEO_P0 0 &mc_virt SLAVE_EBI1 0>; interconnect-names =3D "cpu-cfg", "video-mem"; =20 + dma-coherent; + iommus =3D <&apps_smmu 0x2180 0x20>; memory-region =3D <&video_mem>; =20 --=20 2.34.1 From nobody Mon Sep 28 18:36:39 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB96F3B5319 for ; Tue, 18 Aug 2026 15:54:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787068497; cv=none; b=dJQNW9LkWsLRml93QPv+UQP03Fg2CxwDI/0e7D4MmqQ1RONmVPnYMwf4MdPRzB1DaVfsyP0fnBjEt39T9Su1MIg3lSri/NaJdefLxe9oN5M7P8pDRONcolL/L+4V9Q5qfUkk3LCcJF8Mhv1tyHig5qyV4IN02TRUI2VYzhYpfTM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787068497; c=relaxed/simple; bh=N8g+DXNfDRJOD41XTpggaSV1LHWFsbXlVA7q2pwOZdk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fju4UlQ+Cp0WmbhjzEvnKdZ3BqKbcVUSWlQoGHoMbH6suewDrJSH/cnr11hYvp9G6dFdRXGFVm+CsDMZbIc5VftNj6Xga88grmNYLIZtgGGm8+sJsgvMZCGkMX2FGgYB9hZ8EoSJc0xNxFBUaI2LmntiT5YXc6i4qw3NJCDHHQA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OoL6cXfT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CYALFQNT; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OoL6cXfT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CYALFQNT" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67IE0jx01327128 for ; Tue, 18 Aug 2026 15:54:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= E3jglw0Wq9Oscb5y0P5uqnvM312XMF7ZNYTvPJQRdZA=; b=OoL6cXfTsJI5mELS /S6bfnV2UhT5L8ox5PRSWYxVFmVzjn5LqOOE0/jsanWsgjYK8GKvliH+14RrdUIs KAoHM+kJFDyU2GWXCcaEiHdUOoRHpbl8d6b71NtY4AJcl+xrQ9XSRKeuLdZ+mELa 3Kbuy18Rp01j3+GlYteXqmvXr8iAzFHbxz4UP9YG5HDP0DkaonRwWZnwFBNOeU2Q nZAav2bSE+EgDdgOIbc2pHo22hIpoKyryR/oxKCF/CiIOWY24qH2qbfgKhTHEi1Y ZmyWBsG27ngab+YAbAleKKOjavvNTToVqg58QS6vK7QsJmTeuaE5/Dnda34Y5tXk a6oMwQ== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g4g2p2xuq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 18 Aug 2026 15:54:54 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-cb48f41343aso978515a12.1 for ; Tue, 18 Aug 2026 08:54:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787068494; x=1787673294; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=E3jglw0Wq9Oscb5y0P5uqnvM312XMF7ZNYTvPJQRdZA=; b=CYALFQNTcd3PqNdlRO5VikxIAZTkGmIAtkreZywiV/BWql7IhJwh/QuurA5zjmwpfQ n4Jd5hL66gWKT9icQdbvmwgiSUsgwj5it4MRTppA1Ar7vNLizxOkHxkYm6LMokiUXtFo e8puIRemYOTBt/Q/bj27QzQZ/1qagoS95sDnUBga3cEGAxvnIx9fBkCW0Be/UcPB3JEp ey2tp1GcUO6HXQJ35zImGJ5xA3Xuw1vOyA/W5J91kSGsjDoYh12a7R+okC0jGq0TqShu gB2pULINnjeVAxYlym+yHZ+8FSrcIrq4gFQFIspwBgEHIiKvNaVHdMc5zdaROj7Lmo3r 48Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787068494; x=1787673294; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=E3jglw0Wq9Oscb5y0P5uqnvM312XMF7ZNYTvPJQRdZA=; b=lk511jUX8TvWoXpniqMK9zk+Ade5CfVNfdD3o4hrvjZVf1KGwFi8x7ifIt8nS0QYCu L89RNdsbVeWL4xQEwSbmpdMsqFLgFRlCtQLOiZf13sg3C1v9v/7AQoxBn6tTeATlOuiv QMABv2mCNYWUFEda3lAJxZpSD6mwMDbko/kklEScwoNUSRwIhNrVBB753bD7P5lQ+riq YP/NUyzGZDo4WL6QqASJm9FBlV8NApH2R4OghnvdtmhpBLlYbHBZuEdo1KXSFIihUFd0 j+r57Z6W+am8rexBfvprvqFSFX5VWSs0a3iL78o1Udto7Yv0hvVmNKOAEIR6NsvDXPHq 6Qog== X-Forwarded-Encrypted: i=1; AHgh+Rpg0fyOE6Ge/6UKhOCxMpU63o6tCeg53tNwTTKETl8aAxMjBkkD57cwX3io+FZKRkLSZnlDk1aOUi5Lb5I=@vger.kernel.org X-Gm-Message-State: AOJu0YykZJ133ej8EhMZgHJSrFNJ9ODF9Sry8v6vVF15E/IlXSZVrUK6 wRyMYNVtzpUSYmIYy7rueestZS1alNPwlDwTUR8ZS17o19tREKc3o7iRoLfDarat77BbEPUIEsr IvBLcOpRZPNwa6HQlT4FwuV53BrLUKkuqWIY5zY//pSQxa88NsinudQE+yYA4b98QDYk= X-Gm-Gg: AR+sD13D5VB9nxVJ8pTuya9Lg1+x3Sw1q25WIUlqO2eAff7ANnFLkNsWu1n2D+nmFwL dn7W6VemfeDmvOfaTckwZk1Nhi+xuTWDjO8bUv81td5VfYgWcPq6ZshFRYZZhdsIt4DDrSWlUH8 yxeCINasMzIxxFxl1fJHSmUj7eW7SrDLrjKis/pd8/9ukCJqviyATG3HKhcyewb6OpqoViYaKiM lYaZL0AuciG+mAyoRC/9NQc7Vko8RPusb0HPGJdW07a9ySSWgPtmSwXAMCe7QAuTBeUDykYp3h3 94YeCc7fuMZy27bErRBPFmf0C4EDR7J6FN7wfOB0fLN4ezfjEKU3Q/FUndgYmBpvL1NR2WIm7s7 058F9DrTdqpPGpqOJCbDO0V0F+iMm49wdPw== X-Received: by 2002:a17:90b:3d92:b0:384:927f:3db9 with SMTP id 98e67ed59e1d1-39563854dadmr5435299a91.1.1787068493912; Tue, 18 Aug 2026 08:54:53 -0700 (PDT) X-Received: by 2002:a17:90b:3d92:b0:384:927f:3db9 with SMTP id 98e67ed59e1d1-39563854dadmr5435258a91.1.1787068493455; Tue, 18 Aug 2026 08:54:53 -0700 (PDT) Received: from hu-bvisredd-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39531fbb41esm8877721a91.10.2026.08.18.08.54.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 08:54:53 -0700 (PDT) From: Vishnu Reddy Date: Tue, 18 Aug 2026 21:24:17 +0530 Subject: [PATCH v2 4/5] media: iris: Fix power-off ordering to disable power domain after clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260818-iris-fixes-dma-pseq-fint-v2-4-8dc8c4b3880e@oss.qualcomm.com> References: <20260818-iris-fixes-dma-pseq-fint-v2-0-8dc8c4b3880e@oss.qualcomm.com> In-Reply-To: <20260818-iris-fixes-dma-pseq-fint-v2-0-8dc8c4b3880e@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stanimir Varbanov , Bjorn Andersson , Konrad Dybcio , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Mansur Alisha Shaik Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Vishnu Reddy , stable@vger.kernel.org, Bryan O'Donoghue X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1787068461; l=1899; i=busanna.reddy@oss.qualcomm.com; s=20260216; h=from:subject:message-id; bh=N8g+DXNfDRJOD41XTpggaSV1LHWFsbXlVA7q2pwOZdk=; b=YS4oHlm8T8nCDzMMg9SyTy5BQFzxnfosvqqjBnu1xiAUXnPBIKNHNGhgZMbqLDDNVQ2jWNqek okaZrqlPtpPBpf8eVhlWHydpoSkCSt0g/tuoP5IqMhkuugyWG3CcTq+ X-Developer-Key: i=busanna.reddy@oss.qualcomm.com; a=ed25519; pk=9vmy9HahBKVAa+GBFj1yHVbz0ey/ucIs1hrlfx+qtok= X-Proofpoint-GUID: tNapwOIhJWnNLGazB54cOqgmZqWxCIFY X-Proofpoint-Spam-Info: AW1haW4tMjYwODE4MDExNyBTYWx0ZWRfX0ppXVjm4r/57 zxO8idKWTLTU9iuSrCD2BY2hWMVvM3TmApKoCUAO4fB+1V3nimLOLXp5MBM6LW2OhAOv+c3QJpK BtuG6ZielTYxuZ+Q0do6KFLWhQYhI7Q= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE4MDExNyBTYWx0ZWRfX2Ul4W9cjEilb jSmkYgnlNlVd48fj+9ynYB2T31t/5yTXDqLTcODD8XALKNFkMrtzCkh1zfOQxQM7Yo6FYZnL7Yq PTwhd2rlG/CILi2aPfpy3H8zxFENtJXbh6Dgr+Te2qHD/zSjN0ysz7A9NzozOsqC6GquMPPcN/h eH/piu5cAq6wOQ0cPFV5/EhY4gVjpGzZtRkhfp5xb6bCDpI9qs7JtnO3C1T4hY1SOJC/BbSTOD/ gL9fQ+NjGYbv5vMPv7niWqEshaCGJbrno4MG+ki0QZf2SZ7Kv+zsnI/O3Dv0ImjC7i9WCvFfteu EqFNsueFxAQEylnreuc76GIWD2hOb+gzAD8GapdYFpNVt/1OlLPeffYPzXcJvop/S7pJxnFnhaf Ru7Wrlq91fA59mZdpeHDUsuKEZfUoJicACkSHihH0CpBCjmttpcy6lPcCr7H1vISdHKrX2zqLb0 98/g5tkJ2ln7IfAZK7A== X-Proofpoint-ORIG-GUID: tNapwOIhJWnNLGazB54cOqgmZqWxCIFY X-Authority-Analysis: v=2.4 cv=bfRbluPB c=1 sm=1 tr=0 ts=6a84804e cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=Ou1eOjPKtcA3bHzkrowA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-18_02,2026-08-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 malwarescore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 bulkscore=0 spamscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608180117 In iris_vpu_power_off_hw(), iris_disable_power_domains() was called before the associated clocks (IRIS_BSE_HW_CLK, IRIS_HW_AHB_CLK, IRIS_HW_CLK) were disabled and unprepared. This reverses the correct power-down sequence: with the power domain already removed, the subsequent clk_disable_unprepare() calls end up operating on clock-controller hardware that is no longer powered, which can hang or behave unpredictably. Reorder the calls so iris_disable_power_domains() runs after all three clocks are disabled, ensuring clocks are always turned off while their power domain is still active, and mirroring the reverse of the power-on sequence. Fixes: bb8a95aa038e ("media: iris: implement power management") Cc: stable@vger.kernel.org Reviewed-by: Bryan O'Donoghue Signed-off-by: Vishnu Reddy --- drivers/media/platform/qcom/iris/iris_vpu_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_vpu_common.c b/drivers/m= edia/platform/qcom/iris/iris_vpu_common.c index e4847c107709..3cd493b06d84 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu_common.c +++ b/drivers/media/platform/qcom/iris/iris_vpu_common.c @@ -223,10 +223,10 @@ int iris_vpu_power_off_controller(struct iris_core *c= ore) void iris_vpu_power_off_hw(struct iris_core *core) { dev_pm_genpd_set_hwmode(core->pmdomain_tbl->pd_devs[IRIS_HW_POWER_DOMAIN]= , false); - iris_disable_power_domains(core, core->pmdomain_tbl->pd_devs[IRIS_HW_POWE= R_DOMAIN]); iris_disable_unprepare_clock(core, IRIS_BSE_HW_CLK); iris_disable_unprepare_clock(core, IRIS_HW_AHB_CLK); iris_disable_unprepare_clock(core, IRIS_HW_CLK); + iris_disable_power_domains(core, core->pmdomain_tbl->pd_devs[IRIS_HW_POWE= R_DOMAIN]); } =20 void iris_vpu_power_off(struct iris_core *core) --=20 2.34.1 From nobody Mon Sep 28 18:36:39 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDADE43E08F for ; Tue, 18 Aug 2026 15:55:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787068504; cv=none; b=YHwbxeT12gLamcF1BP1Ctf5zR9OPHVUzSWrB4jDQ5r0tHJeR2QSLKbBMOKhdXVPOYt6Ir5mYP+yCTrHNMLzP5+2fLM6d8aEFA46Iq0zKP0YgFyJt4ppKRCXFjGt+UB22GQMN5xrKVicYjRURUQF2j0Gauh2WZgUIjb3s3NIGxhE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787068504; c=relaxed/simple; bh=oZTefR/5KZdPemiGpbUvpVCazLZz7wSby+xVQN9JpOA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Hle+mWUcr3jn0GWyHRo2LdylLT+HbVGFa4dpVMIjIQPIJqtSxM4/lKqi3dXHPZrqExwzTXvdjHGIRTQook4gmmps8xRfBLkPd+nIkt3nu5IchtJYaeSFKanF/e5lGG+mMIT8veZfUPFFGaRekU/BJp3JEKIS9Q6JRNrjyTnRf98= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=V5i6mEah; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Q9hJpmV+; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="V5i6mEah"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Q9hJpmV+" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67IFKCAO1503672 for ; Tue, 18 Aug 2026 15:55:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nt5vfztKEXyZ/EZLhnIuWwUGzJoCvT1w4EXFSWZSD9k=; b=V5i6mEahNVsGRW0w BkX0qTmp/HMeRUBuotkKjJmJrPOMA6uRCswlBrz4DYYQC5Oh8Gr+T5L7OZLiIngC lrtJkarlTfwMYFk6G06keUSb6q9UlSck3IPhBH9a5crwyHaNHN0xrm6CWIUngIL7 eM+Z6vLPDA4y3tp+xzcvOWQhu/KqfK7ioSfgRdRm2K077jrU01m2BofuGzc37ly2 vA/fZTI9UwkaZS68KUwtQDoFhF27EWGED7qgl52UoLMwO99x0EGpbgtgVn7m3LL7 ZOPG6wVofNM9/FIJOPRO7a21tO02v9Im/GcY58wLWz9ZntgiW0fVCYweskw1elTD F7b/Jg== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g4g2p2xv9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 18 Aug 2026 15:55:01 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-38ec0f510a9so142414a91.2 for ; Tue, 18 Aug 2026 08:55:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787068501; x=1787673301; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nt5vfztKEXyZ/EZLhnIuWwUGzJoCvT1w4EXFSWZSD9k=; b=Q9hJpmV+7Ine1rpXr86O2BpXWieFQRoaZnlHK8qN2uUFi/zSoUTJUajhKcphkvf1hG IxmT8KwrGUEEJHSKeeUcxpT0A/75LcXCglkjA/zEaXpaU5cE09Y4OK39+VA8V7tUcEz5 YPl+vn0xt4Gb58UWWM3iRqeai6ZfL+ZvMUHQS9lxyO6HBCt/UkDH5XzVgkSgwLwtE2cE mM/tJq4eWWOBQ7aTqhGJparSmacnQC2wTwCiIe5fCaiNtoN0P2bWsH9WwEQ63DUapAr0 J5RlFuP/oy/sZkADMOfH3yCV2mtLXX6uducd9EMH5XwlNdDfYkbYVmLePP5y7y/B8Cyh E/OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787068501; x=1787673301; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nt5vfztKEXyZ/EZLhnIuWwUGzJoCvT1w4EXFSWZSD9k=; b=MLJROeeZjpia0YfqztJy+9ULUVDdHLOHwpKvvHFO4V7LdcT3+Ew3nRoXVmMbysicqF tK/AEmiF9BbaveXpGjdT0tsuB3y+LgzYP1RUgK7xeEPmB/sQNVwxVpo/bEmswvmrBN73 OJNmG88FJ+0o9DgrJ3//SSV8jRBwR5+6TWVIdvuK6AgCpCyJ0BnDoHMC+9tvpMLBv2e9 snM227Da/ppsf9/fdYqCRgCiPvGlMy46soIPfNk7lP5TMMCt4LLnezRXxAzFZy7EaDx/ T5owj+vErWk/ykDfGKMw8A6zBnVADG/4v8/3Ane2fW48I4EOwK+PgjtzGdvj/qtoq46r RDIA== X-Forwarded-Encrypted: i=1; AHgh+Rq53rb50sx1rzNLLskotxdr51S6TZ/ZQ9WnbgYpTVwJ9hPNr/tWtLwjPatIOdQf7S09emX7HP3wMfKecZI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0Uyx3N+ga+l1n/hgeDP8ku39UbTKAAfkprARwjhR/Z0bPzfwI 6N8ZdnSPlB7yjXHxCZUIj3ngpPaC4tPwG/HCyX4PSFiCyK9VEU7njUK3Irg/8W2D0mu4Fq/P04m z5OaJbb3RhUhI4g8OSyt8yC317kaotTqelH4XncRnk2m64NJJsyMPYJLnF6RQEe5TNcU= X-Gm-Gg: AR+sD11eg8tAL2qvR6WtwYkMV1sPd0mHb4TLY1HgaNw3s6m++W4s9IEL29SzsGgQicv k20Xxdk1m48YGnowP2mExbJZVDAKI4b8bjQ+mcA0tXmvyGaLadkaZsyroSwJD/hvgHLpu+r+fAu WhTIrYu+GiPig+FCpx6iR18h8HsNEwO/hB6piJ3klAm36rvtiT3y1MZmey1BE/v56YdypQ/8p9j MvjksiwNOrPtUh3231rwggCt+szegXp9ULl7SAgd+lvAtM/NFK78DDKaX5MxQ836hmcw9+zsHAw vyDR3rJzFD0f8a5RtS6wZDHU/MSRiC3JYIUOTfs+CV8t4bGBOfIQLPkrcWxRzRO3dw6DX1mO0S7 pmQrX6qkq8yavUgdsPOeSv1Wc539gtolJOA== X-Received: by 2002:a17:90a:e7cd:b0:380:fead:448d with SMTP id 98e67ed59e1d1-3933b87224cmr34639683a91.13.1787068500744; Tue, 18 Aug 2026 08:55:00 -0700 (PDT) X-Received: by 2002:a17:90a:e7cd:b0:380:fead:448d with SMTP id 98e67ed59e1d1-3933b87224cmr34639565a91.13.1787068500087; Tue, 18 Aug 2026 08:55:00 -0700 (PDT) Received: from hu-bvisredd-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39531fbb41esm8877721a91.10.2026.08.18.08.54.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 08:54:59 -0700 (PDT) From: Vishnu Reddy Date: Tue, 18 Aug 2026 21:24:18 +0530 Subject: [PATCH v2 5/5] media: iris: Fix frame interval enumeration for non-divisor framerates Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260818-iris-fixes-dma-pseq-fint-v2-5-8dc8c4b3880e@oss.qualcomm.com> References: <20260818-iris-fixes-dma-pseq-fint-v2-0-8dc8c4b3880e@oss.qualcomm.com> In-Reply-To: <20260818-iris-fixes-dma-pseq-fint-v2-0-8dc8c4b3880e@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stanimir Varbanov , Bjorn Andersson , Konrad Dybcio , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Mansur Alisha Shaik Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Vishnu Reddy , stable@vger.kernel.org, Bryan O'Donoghue X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1787068461; l=2282; i=busanna.reddy@oss.qualcomm.com; s=20260216; h=from:subject:message-id; bh=oZTefR/5KZdPemiGpbUvpVCazLZz7wSby+xVQN9JpOA=; b=QZOmU8jQM5TE2xRprsP1ccg2VlIppe2h57LdibGJhA1DO5lUrpH3q0hGl444T0Uv4DdhwFQqd 6gjGxWNcWC+CiTjj6FJlRiossxuLDukCJbtnRKYL3DoNwGx3NL3LCXT X-Developer-Key: i=busanna.reddy@oss.qualcomm.com; a=ed25519; pk=9vmy9HahBKVAa+GBFj1yHVbz0ey/ucIs1hrlfx+qtok= X-Proofpoint-GUID: 59rfKMdDSs0OG44CS-Sx_Pxgmv78fcoQ X-Proofpoint-Spam-Info: AW1haW4tMjYwODE4MDExNyBTYWx0ZWRfXyCYuQdZRVyWx ORX9toSCoGBuXusNfOZkWwfCcfdPGzRgpXpv4vyrElcURA8IWznjhvPdcmO2R/mx04hrXUi01rT kQpsmlgKUK+ifLjRUQWbJ2yY6PATJPs= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE4MDExNyBTYWx0ZWRfX9jwPQfDYvrX5 PxjN+Xc/nxEiOAzU4lGlFt3jJopMmckFMAbIU2RNrKvSVVXsAPUX93JAD/VHS98/wftqUWPEMok ctzeF0fK0NHwrj+UtygSTHcIdeTtmB4D5nCb54yJgtZ+k22e50wgbQ9vUdqRoOElaI5koDc6dLx yOtXemEP0CntzEI4x3rsX0JN6xJelM+uMJ9IRs3FojPM57spK3XpAt11GJ63rkzEg46ctw3WQvJ YgNHIMRrxFBK5iO3MN7WtipIBaLLLO6nCLPn1EDB6L3xNtZPAnf7aEcPywjX3cbUqtfC2YqkYOM oBw1EIdmYeARHFZrNlEVBG5ZuwzRwRiGXO9xxGSyNJP2SRIiv0Pwg1ImL+wH2Bbwm6l5eO9Jh6i 66sV8zzQn7KYLcaf8pFPgC51BWdqPQS9eR4FQnj1MCklAz0iNfF2rlOmCoFp6GvKjBDLpMJW4fr 2WfDYRNIQ9kKn4UhjQw== X-Proofpoint-ORIG-GUID: 59rfKMdDSs0OG44CS-Sx_Pxgmv78fcoQ X-Authority-Analysis: v=2.4 cv=bfRbluPB c=1 sm=1 tr=0 ts=6a848055 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=SOCO_u0IuGyKYXpwI1gA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-18_02,2026-08-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 malwarescore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 bulkscore=0 spamscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608180117 iris_enum_frameintervals() advertised frame intervals using V4L2_FRMIVAL_TYPE_STEPWISE with step=3D1/MAXIMUM_FPS where MAXIMUM_FPS is 480. This caused client to enumerate only framerates of the form MAXIMUM_FPS/n (where n is a positive integer), restricting support to exact divisors of MAXIMUM_FPS (e.g., 480, 240, 160, 120, 96, 80, 60, 30, 24, 1). Framerates that are not exact divisors of MAXIMUM_FPS, such as 29 fps, 25 fps, were excluded from the enumerated list. There is no hardware restriction to framerates that are exact divisors of MAXIMUM_FPS. This caused GStreamer caps negotiation to fail with an "internal data stream error" when encoding content at such framerates. Fix this by using V4L2_FRMIVAL_TYPE_CONTINUOUS. With CONTINUOUS type, GStreamer creates a continuous framerate range [1, max_fps], allowing any integer framerate within the range to pass caps negotiation. The step field is set to 1/1 as required by the V4L2 specification for continuous frame intervals. Fixes: a6882431a138 ("media: iris: Add support for ENUM_FRAMESIZES/FRAMEINT= ERVALS for encoder") Cc: stable@vger.kernel.org Reviewed-by: Bryan O'Donoghue Signed-off-by: Vishnu Reddy --- drivers/media/platform/qcom/iris/iris_vidc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_vidc.c b/drivers/media/p= latform/qcom/iris/iris_vidc.c index fcbc60016bee..8f20cb281a93 100644 --- a/drivers/media/platform/qcom/iris/iris_vidc.c +++ b/drivers/media/platform/qcom/iris/iris_vidc.c @@ -438,14 +438,14 @@ static int iris_enum_frameintervals(struct file *filp= , void *fh, mbpf =3D NUM_MBS_PER_FRAME(fival->height, fival->width); fps =3D DIV_ROUND_UP(core->iris_platform_data->max_core_mbps, mbpf); =20 - fival->type =3D V4L2_FRMIVAL_TYPE_STEPWISE; + fival->type =3D V4L2_FRMIVAL_TYPE_CONTINUOUS; fival->stepwise.min.numerator =3D 1; fival->stepwise.min.denominator =3D min_t(u32, fps, MAXIMUM_FPS); fival->stepwise.max.numerator =3D 1; fival->stepwise.max.denominator =3D 1; fival->stepwise.step.numerator =3D 1; - fival->stepwise.step.denominator =3D MAXIMUM_FPS; + fival->stepwise.step.denominator =3D 1; =20 return 0; } --=20 2.34.1