From nobody Mon Sep 28 21:03:44 2026 Received: from mail-qt1-f225.google.com (mail-qt1-f225.google.com [209.85.160.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE909441636 for ; Mon, 17 Aug 2026 15:40:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.225 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786981252; cv=none; b=hHOlZTJqa3BnxOwjl7LX6gdisnh0HQrtEeWxZ2LLw2qcSR/fFLl5oI3U5ndKEkpbC/CkgTQDRTGU0EIgwfxPBnAHtUOqnI/8bm/KfP7MIZvg3vbWZrnwd4MMOeo64FKf21gkfvD4KyGmDt4Q35Vl1XqOETfhab0J4xwaPpYORKU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786981252; c=relaxed/simple; bh=KwsvnoEHCvYF2uIrLWwVXtjUnI6GmMwqQ4JSbvpEjRI=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=VTTrJpRi2ZvO6F1y3LP1rdVDZzzBBcy5d/VYQqneBh27IL91fdfMQGOmbMk8/G29coa4Yi8rvrE0dTfs4b4NYRDR6uSOkqn5lv1dzYN3/9mxkQtBSOwthNIS7s7iDjIgPWs07u4vm497MqH+FSRkTDaBqa9AK2w3fiI6tn4x/84= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com; spf=pass smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=XpZnFeyN; arc=none smtp.client-ip=209.85.160.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="XpZnFeyN" Received: by mail-qt1-f225.google.com with SMTP id d75a77b69052e-526f963372aso22015421cf.1 for ; Mon, 17 Aug 2026 08:40:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1786981249; x=1787586049; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=48/o27CH4bla+GkGB+3sO8ImvqwmZCfCNEfhnKyYNX8=; b=XpZnFeyNNzT5GV+57tJyL+wDZ83DaBRIufwmR9GQvjdurwA/QIAX80GAZ1rgB9+hvb ym4LGJRCqIxWKlhrQBzWGZXB0Qs9K5RtVJgbCVcyQ/lefuzBZcDXccTICm5KEIuRKs0E fM0y+NfBsVVbZptnv0io8a/ORiGh07TCLmR7PU5wJj2waKsZPH6uTAnBcAx/xKmfOdyc FsMA3rlX0NRlBdGle219HZ8pn7nSZiPLHRLouRtn29BJfZQ0jeOf94TS3QqF1YKLKiy2 BeMf108QEyknzybU8KNnB+2yKPUDf1sJobP6+knkzauJqXFCViusKWdWqxlTV3W549AI TsNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786981249; x=1787586049; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=48/o27CH4bla+GkGB+3sO8ImvqwmZCfCNEfhnKyYNX8=; b=d7H6Nd9TW/E9MKJXXSZArHEUcjkqfz0Xk0Q+cKSNBqmF2hXBgxj2bHxiun+ibGBbtT mnufj1ZBLlPxqYtE5fwcgYVlCUYHuJ1akBZVfrRCGp+5G/Om/5ZwYmQkfAsvf8aKmhw4 E9N2anrXhIdSt+j5FzZ4m8zC9aZWhOr4X1/jFJ/lBF03qQ0FdcMbEaaDGhCddsli9GDl LMQ9X5+KzL8hyxyFKcx73lRoG7+21sbHAbqTnIebY7vOrSWdn7DggjhyTWqNP7W9Sqxu 5uNqh0HNCIqQu19eJf/KTaF2VseHgZEe2Z2Xsy5V84jmVbEuF/TB5L8tMdvrpPo7Rp+4 muaQ== X-Forwarded-Encrypted: i=1; AHgh+RpLbyu+Frhny1lg7SVDAwJtubjR8Z4+pMxXVNBGOiNTDFOuqQ8HyHipTMWZcp7v76w6A7IgNRG5fy7kVY0=@vger.kernel.org X-Gm-Message-State: AOJu0YyMKF6KWnjP+3A2x0Bzo2i+LySykBw/QQ4nPYD5CyJmcOVH39UK 94w45wjctCzQR1+rU01gvCc2pMkH//ug3vrmS2/lLif8cLJWlyl0EHbEYpucn7nO639k7vghaox jIoxgQ2j3w8s4zKxYs4Vq/KP1SmLAA90nkguB X-Gm-Gg: AR+sD12yv2Kr/OL1KE3EDJSC+yRjdCQ4n3jwSNHEux+4Qu9ifF2rKgN14mo6o6EZB8S 1+G3R+NwRwxWrJUk5DMczoCiEZj5IKO55CkUqQvXgpoYsMGpn8zgaPj+UzgYziiu6tw0ZA6jjsM XNRxYltI7wprSHTIPfxFxUQHSMDrMI/o/1hsGYWDzH3btenGK95g8n6SMDjqHeitFM9hCMENVTc 6503A3SlUJISfTmspLVscXkRCYLkL3FrYWqW4RVyd26DDzx0+VspTyqdjNKCZN5m/itRZADz8qd zH6QVomLX0yhJQzHz6pVg/xRDxEot3NKj2Mm0keP2zdP2pYvGpa0MusozC9Cia707i/pwGZsJW/ GP5uHzMB07qu0iI61VC8rfTaklhK7AeFPguzrww== X-Received: by 2002:ac8:5805:0:b0:51b:fc67:c73c with SMTP id d75a77b69052e-52d8536169emr269542441cf.16.1786981248628; Mon, 17 Aug 2026 08:40:48 -0700 (PDT) Received: from c14-smtp-2023.dev.purestorage.com ([208.88.158.128]) by smtp-relay.gmail.com with ESMTPS id d75a77b69052e-52db6297d8esm260121cf.29.2026.08.17.08.40.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 08:40:48 -0700 (PDT) X-Relaying-Domain: purestorage.com Received: from irdv-tmenninger.dev.purestorage.com (irdv-tmenninger.dev.purestorage.com [10.32.149.15]) by c14-smtp-2023.dev.purestorage.com (Postfix) with ESMTPS id 0D25834018F; Mon, 17 Aug 2026 08:40:47 -0700 (PDT) From: tmenninger@purestorage.com To: trondmy@kernel.org, anna@kernel.org Cc: jlayton@kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Tim Menninger Subject: [PATCH] pNFS: Fix EBUSY check in pnfs_layout_need_return Date: Mon, 17 Aug 2026 15:40:44 +0000 Message-Id: <20260817154044.1799634-1-tmenninger@purestorage.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Tim Menninger Commit 41d0a8ead9720 ("NFSv4/pnfs: Add support for the PNFS_LAYOUT_FILE_BULK_RETURN flag") changed pnfs_layout_need_return() to check whether pnfs_mark_layout_stateid_return() returns -EBUSY. However, the new check compares the return value against EBUSY rather than -EBUSY. Since pnfs_mark_layout_stateid_return() returns negative errno values, the -EBUSY case is never detected. But pnfs_layout_need_return() calls pnfs_mark_layout_stateid_return() calls pnfs_mark_matching_lsegs_return(), which returns 0 if a layoutreturn needs to be scheduled. Fix the comparison in pnfs_layout_need_return() to check for 0, i.e. a layoutreturn needs to be scheduled. Fixes: 41d0a8ead9720 ("NFSv4/pnfs: Add support for the PNFS_LAYOUT_FILE_BUL= K_RETURN flag") Signed-off-by: Tim Menninger --- fs/nfs/pnfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c index 9f32dd7c4c63..fb141cef4d54 100644 --- a/fs/nfs/pnfs.c +++ b/fs/nfs/pnfs.c @@ -1389,7 +1389,7 @@ pnfs_layout_need_return(struct pnfs_layout_hdr *lo) return false; return pnfs_mark_layout_stateid_return(lo, &lo->plh_return_segs, lo->plh_return_iomode, - lo->plh_return_seq) !=3D EBUSY; + lo->plh_return_seq) =3D=3D 0; } =20 static void pnfs_layoutreturn_before_put_layout_hdr(struct pnfs_layout_hdr= *lo) --=20 2.34.1